)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"16d0caf3f90b4effec2c00055b0a79eca2f972af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b44b52b_962c6188","updated":"2023-02-13 15:53:01.000000000","message":"please address Brian\u0027s comments and LGTM","commit_id":"5e8310b2f33c086db87b17be0731e6dde7aa7725"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5163bb4ef6ebe09576e221028f6c84c8b1aaae48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cd80157e_49f0ce0a","updated":"2023-06-07 13:34:32.000000000","message":"1) Please fix the import, you are declaring twice the constants module\n2) Do you have a link to check this error? Please open a launchpad bug describing this issue\n3) Shouldn\u0027t be vpnaas the one in charge of adding these routes?","commit_id":"3c47bdf90747acd69b708daf95f3f5238dde36a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2711028a5c642b4c291ed5b181b5a79caaaba11e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"edb05811_596b6879","updated":"2023-06-07 11:18:02.000000000","message":"thanks for review","commit_id":"3c47bdf90747acd69b708daf95f3f5238dde36a6"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"14573e24e05e3b63ba73db419aca6cd10b32396b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"49c4ea04_8b6d0150","in_reply_to":"cd80157e_49f0ce0a","updated":"2023-06-09 13:05:28.000000000","message":"1) Done\n2) This is internal tracker, dropped mentioning\n3) Not sure that vpnaas should do this, at least now we cover existing logic. If in future automatic routes added to vpanaas we can update this test.","commit_id":"3c47bdf90747acd69b708daf95f3f5238dde36a6"}],"neutron_tempest_plugin/vpnaas/scenario/test_vpnaas.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"45035efb9b8d65399cede3da34f248aa97947e3d","unresolved":true,"context_lines":[{"line_number":124,"context_line":"        if is_distributed:"},{"line_number":125,"context_line":"            snat_port \u003d cls.os_admin.network_client.list_ports("},{"line_number":126,"context_line":"                device_id\u003dcls.router[\u0027id\u0027],"},{"line_number":127,"context_line":"                device_owner\u003d\u0027network:router_centralized_snat\u0027)"},{"line_number":128,"context_line":"            snat_ip \u003d cls._get_ip_on_subnet_for_port("},{"line_number":129,"context_line":"                cls, snat_port[\u0027ports\u0027][0], cls.subnet[\u0027id\u0027])"},{"line_number":130,"context_line":"            cls.os_admin.network_client.update_subnet("}],"source_content_type":"text/x-python","patch_set":1,"id":"1ce5637f_b4299644","line":127,"updated":"2023-02-07 16:13:12.000000000","message":"neutron_lib.constants.py has a constant for this, DEVICE_OWNER_ROUTER_SNAT","commit_id":"5e8310b2f33c086db87b17be0731e6dde7aa7725"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2711028a5c642b4c291ed5b181b5a79caaaba11e","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        if is_distributed:"},{"line_number":125,"context_line":"            snat_port \u003d cls.os_admin.network_client.list_ports("},{"line_number":126,"context_line":"                device_id\u003dcls.router[\u0027id\u0027],"},{"line_number":127,"context_line":"                device_owner\u003d\u0027network:router_centralized_snat\u0027)"},{"line_number":128,"context_line":"            snat_ip \u003d cls._get_ip_on_subnet_for_port("},{"line_number":129,"context_line":"                cls, snat_port[\u0027ports\u0027][0], cls.subnet[\u0027id\u0027])"},{"line_number":130,"context_line":"            cls.os_admin.network_client.update_subnet("}],"source_content_type":"text/x-python","patch_set":1,"id":"a117a5e0_c3a36b7b","line":127,"in_reply_to":"1ce5637f_b4299644","updated":"2023-06-07 11:18:02.000000000","message":"Done","commit_id":"5e8310b2f33c086db87b17be0731e6dde7aa7725"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"45035efb9b8d65399cede3da34f248aa97947e3d","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        if is_distributed:"},{"line_number":175,"context_line":"            snat_port \u003d cls.os_admin.network_client.list_ports("},{"line_number":176,"context_line":"                device_id\u003drouter[\u0027id\u0027],"},{"line_number":177,"context_line":"                device_owner\u003d\u0027network:router_centralized_snat\u0027)"},{"line_number":178,"context_line":"            snat_ip \u003d cls._get_ip_on_subnet_for_port("},{"line_number":179,"context_line":"                cls, snat_port[\u0027ports\u0027][0], subnet[\u0027id\u0027])"},{"line_number":180,"context_line":"            cls.os_admin.network_client.update_subnet("}],"source_content_type":"text/x-python","patch_set":1,"id":"c1a73310_176c8d82","line":177,"updated":"2023-02-07 16:13:12.000000000","message":"same","commit_id":"5e8310b2f33c086db87b17be0731e6dde7aa7725"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2711028a5c642b4c291ed5b181b5a79caaaba11e","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        if is_distributed:"},{"line_number":175,"context_line":"            snat_port \u003d cls.os_admin.network_client.list_ports("},{"line_number":176,"context_line":"                device_id\u003drouter[\u0027id\u0027],"},{"line_number":177,"context_line":"                device_owner\u003d\u0027network:router_centralized_snat\u0027)"},{"line_number":178,"context_line":"            snat_ip \u003d cls._get_ip_on_subnet_for_port("},{"line_number":179,"context_line":"                cls, snat_port[\u0027ports\u0027][0], subnet[\u0027id\u0027])"},{"line_number":180,"context_line":"            cls.os_admin.network_client.update_subnet("}],"source_content_type":"text/x-python","patch_set":1,"id":"78b56bce_5c2d660d","line":177,"in_reply_to":"c1a73310_176c8d82","updated":"2023-06-07 11:18:02.000000000","message":"Done","commit_id":"5e8310b2f33c086db87b17be0731e6dde7aa7725"}]}