)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"80d3367b4abff7a58cb97367b82f3167cf494cb8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9a88b36d_6eec2662","updated":"2023-03-07 17:14:02.000000000","message":"-1 for Brian\u0027s question","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"808ae2b1355cfa5daa1bef438db16f4d8be9d52c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3aba19e4_680ca928","updated":"2023-03-09 23:46:59.000000000","message":"Could you please Depends-On this patch to https://review.opendev.org/#/q/I3888d457d1c069c24eb8943fb54b9a9dc9f14819 that should fix slaac / dhcpv6 stateless for stateless SGs? Thanks. I\u0027d like to see if the neutron fix actually achieves what it aspires. Thanks.","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1fca80581f8e6069718288db20612e5702b003e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43901d91_c962ef4e","updated":"2023-03-01 18:30:16.000000000","message":"looks ok, I checked a few jobs but it was skipped, which job we execute these tests?","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"676d57688609bd68eb3d07bc32212260e650c26e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93e68002_83501f31","updated":"2023-02-28 12:16:33.000000000","message":"recheck - unrelated fwaas test failure","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"a0ca3e5ca083d07c6da33d253db205504c09e28b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5c98d4e7_d89f274c","updated":"2023-03-22 17:12:21.000000000","message":"But we need to discuss first (in the PTG), what to do with this traffic (ipv6 RA/NS) with stateless groups.","commit_id":"0fb6417b81504608fcf35cddb59e73ed33e283dc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8de7c79319a8957bb82676cb553215820da6e96d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a4a1fb88_83962f1f","updated":"2023-03-22 16:46:22.000000000","message":"Minor nits, code looks fine.","commit_id":"0fb6417b81504608fcf35cddb59e73ed33e283dc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"75a3d0111cc12678001443dd9223422d52dde64e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d483cf24_2837466d","updated":"2023-03-29 19:47:10.000000000","message":"Since we are going to allow dhcpv6 icmp replies by default in ovn (and presumably this is the behavior for ovs implementation), we\u0027ll have to plan for stable branches here. Ideally, we consider the relevant dhcpv6 behavior pre- neutron patch a bug and backport the fix down to all supported stable branches. On the other hand, the fix is a bit intrusive (e.g. adding revision-numbers for all port_groups, also adding ovn db migration rules). Should I plan backports for the fix to all stable branches with stateless sg ovn support?","commit_id":"f7f6dbb368b550a315f9716a248f8984fc6578fc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"cd12b4f45ebc9799bf6e98dee505dda8d57c6e6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"75b639d5_2d8589d0","updated":"2023-03-29 12:05:49.000000000","message":"recheck - unrelated bagpipe failure","commit_id":"f7f6dbb368b550a315f9716a248f8984fc6578fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"174c23f2ed338010d9c6994bda1d46d60a647946","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"de0181f3_89945c7f","in_reply_to":"ac112b20_d04d0a3e","updated":"2023-03-30 12:56:08.000000000","message":"For me it\u0027s a choice of two options:\n1. consider this behavior part of the definition of stateless-sg api and hence fix it as a bug in implementation.\n2. consider this behavior undefined for stateless-sg api and hence consider it a curiosity / implementation difference that is not a bug.\n\nI think the decision was made for (1) during vPTG \u003d\u003e hence it\u0027s a bug in implementation \u003d\u003e hence it should be fixed \u003d\u003e hence it should be fixed in master branch \u003d\u003e and hence it should be considered for backport for stable branches (subject to regular stable branch rules - e.g. we may consider some bug fixes too unsafe for some stable branches and just leave the bug in, perhaps just noting it as a known issue in a release note.)\n\nWe can attend to the question of backport desirability separately to the choice above. Or do you think we should revisit the choice itself again?","commit_id":"f7f6dbb368b550a315f9716a248f8984fc6578fc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"1192ad530cd493a3f92c080be38f89c82015f2cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ac112b20_d04d0a3e","in_reply_to":"d483cf24_2837466d","updated":"2023-03-30 09:02:57.000000000","message":"My initial though on this was that all those changes sounds for me like internal implementation\u0027s details without real changes for user (except fixing bug which blocks e.g. ingress NA/RA traffic).\n\nBut now, longer I think about it, more doubts I have.\n\nFirst question is: what will happend internally if user already have rules to allow such traffic in his stateless SG and we will now add it internally also. May it cause any issues (like errors in code for example)?\n\nAlso would it be ok if we will in fact change behavior of stateless SGs in stable branches now? Like e.g user now have rules to allow NA/RA ingress traffic and will want to remove that but that will still be allowed by our internally created PG. Will that be ok to have such change in stable branch? In master we can add upgrade check to check in db if there are stateless SGs and warn operator that there is such change in Neutron so behavior will change.\n\nMaybe I\u0027m overthinking and backports will be fine. That\u0027s just my doubts and I would like to know opinion from other stable cores too.","commit_id":"f7f6dbb368b550a315f9716a248f8984fc6578fc"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d7611c4acf5c8a2c9eedf42d3393f80f21e88c9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f6eca5a6_d691921a","updated":"2023-03-30 13:00:38.000000000","message":"I think a good place to focus the discussion on first is: https://review.opendev.org/c/openstack/neutron-lib/+/878947 If we accept the patch there, it indicates we have a bug in our implementation in all stable branches. If not, then it\u0027s not a bug and we may keep current behavior of the implementation. But we cannot on one hand claim it\u0027s the intended behavior of the API and at the same time allow this mis-behavior in any branches. (Subject to backportability rules.)","commit_id":"661a7780c7aedd1fa75136efd8d4fa1c58a90ca0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"634032cd8190a736b232e3c2fc22994f2262263c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c9242b29_35fff31d","updated":"2023-04-19 20:37:40.000000000","message":"AFAIU I6d7f6f4fbabc6273b170dfb963a8a37200e9fbc2 should bring the OVN version in the gate that has a fix that makes RA / NA / MLD* work by default (implemented in ovn-controller), at which point you won\u0027t need to create explicit SG rules to do the same.","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"a212efe4d5f24817a3b8cc11b2bab49b6739b0a6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"04e438f4_31908805","updated":"2023-04-17 07:38:01.000000000","message":"recheck\nneutron-tempest-plugin-ovn failed due to mirror issue","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58721e1d82a35eaeda94df15f63f9b8f7a4a672c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"6cb6b2cb_44357863","updated":"2023-04-20 08:31:10.000000000","message":"recheck - another unrelated failures","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"e67cf1e8c4ad0d3e294ff295f40b245f437d7617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4aadb46c_f51a23c3","updated":"2023-04-19 12:30:26.000000000","message":"recheck - mirrors issue","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"9d3f2ebe1a09b451003b54db93dc48549a85e99a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"080a5f9a_0a3f8180","updated":"2023-04-17 07:45:11.000000000","message":"recheck - mirrors problem","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"7659cccd02fed82447c2f32ff0de2d7561d19dc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a3c6589b_51c08d27","updated":"2023-04-05 06:59:33.000000000","message":"recheck - unrelated designate issue","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"3d86389110d19b90a57127f286ebded2a71a0b3f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"d546ddcf_79576263","updated":"2023-04-11 09:11:15.000000000","message":"recheck - vpnaas unrelated timeout","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"24d0172a90e4c8589010acfdeb3b1ecd25279534","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7185ccd1_b078a2f8","in_reply_to":"43eec97e_8b66c410","updated":"2023-04-20 14:59:12.000000000","message":"I think stable branches should rely on a supported OVN release (that includes the fix).","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19a1be3ca0705fa07e1a39d19ced2462ff83eb67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"05d114f7_5349e3fd","in_reply_to":"7185ccd1_b078a2f8","updated":"2023-05-04 10:59:42.000000000","message":"ok, lets try it on top of Your change","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"58721e1d82a35eaeda94df15f63f9b8f7a4a672c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"43eec97e_8b66c410","in_reply_to":"c9242b29_35fff31d","updated":"2023-04-20 08:31:10.000000000","message":"But this will not work in stable branches IIRC. Can we maybe merge it as it is now and I will propose follow up to remove this workarounds somehow from master branch?","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c6e88d70f75275cf0d59868c382da74f46dd2f39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"fcbc11f8_e4816f95","updated":"2023-05-04 20:10:22.000000000","message":"I\u0027ve added depends-on for devstack patch change-id so that it - hopefully - picks up all the backports for the devstack patch I just created in corresponding stable jobs.","commit_id":"0fa55f8b97ecf87cb44483b290128af369164e85"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"298c3c886eaa8c105729296db7b242dfea28281b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"dbd1f4e6_d82d4eb1","updated":"2023-05-05 13:10:29.000000000","message":"The code is fine. We\u0027ll still have to resolve the issue of yoga and below failing to start ovsdb-server, but that\u0027s not a problem for this patch. Once we resolve the issue elsewhere, this should be good to go. Thanks!","commit_id":"d21864a3d6b1357c9f8e7585ed8c16dee810ba7c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0149bafe49841fb8ddcccb9d5c840022d201d39b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dd130faa_0193d4b0","updated":"2023-05-15 20:16:32.000000000","message":"all passed, nice. now just need to land all the dependencies (backports) in devstack...","commit_id":"5a9c67741274e49841091221e21365db810b81b1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"335ed3aea130717b6155fe121616850894da21d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"21563727_becda58a","updated":"2023-06-28 13:13:43.000000000","message":"recheck - patch below that one in the chain is in the gate now","commit_id":"5a9c67741274e49841091221e21365db810b81b1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"51b52cea98d011271259e02dc426f711cf86ba29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"09037b5a_fff10dbd","updated":"2023-06-29 13:42:40.000000000","message":"recheck - unrelated failures in 2023.1 branch jobs","commit_id":"5a9c67741274e49841091221e21365db810b81b1"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a42d6667a6a8e45f63e1f23293a5d7e6c778b0b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"92f0d35c_99bc4165","updated":"2023-06-29 05:45:50.000000000","message":"recheck - unrelated timeout","commit_id":"5a9c67741274e49841091221e21365db810b81b1"}],"neutron_tempest_plugin/scenario/test_security_groups.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f31acb905e047b19ddc0f8c1b0d9d1d815b2c5a7","unresolved":true,"context_lines":[{"line_number":872,"context_line":"class StatelessNetworkSecGroupIPv4Test(BaseNetworkSecGroupTest):"},{"line_number":873,"context_line":"    required_extensions \u003d [\u0027security-group\u0027, \u0027stateful-security-group\u0027]"},{"line_number":874,"context_line":"    stateless_sg \u003d True"},{"line_number":875,"context_line":"    ipv6_mode \u003d \u0027slaac\u0027"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    @decorators.idempotent_id(\u00279e193e3f-56f2-4f4e-886c-988a147958ef\u0027)"},{"line_number":878,"context_line":"    def test_default_sec_grp_scenarios(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ce120058_8a3dfdeb","line":875,"range":{"start_line":875,"start_character":16,"end_line":875,"end_character":23},"updated":"2023-03-01 18:32:10.000000000","message":"Should this be None as this is the IPv4 class? Although the dual-stack class isn\u0027t testing any of these...","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"166b86c8e135405a7fe3a17a2efdc1aac3fca864","unresolved":false,"context_lines":[{"line_number":872,"context_line":"class StatelessNetworkSecGroupIPv4Test(BaseNetworkSecGroupTest):"},{"line_number":873,"context_line":"    required_extensions \u003d [\u0027security-group\u0027, \u0027stateful-security-group\u0027]"},{"line_number":874,"context_line":"    stateless_sg \u003d True"},{"line_number":875,"context_line":"    ipv6_mode \u003d \u0027slaac\u0027"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":"    @decorators.idempotent_id(\u00279e193e3f-56f2-4f4e-886c-988a147958ef\u0027)"},{"line_number":878,"context_line":"    def test_default_sec_grp_scenarios(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5bb02ca5_37474b2d","line":875,"range":{"start_line":875,"start_character":16,"end_line":875,"end_character":23},"in_reply_to":"ce120058_8a3dfdeb","updated":"2023-03-10 09:40:02.000000000","message":"Done","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"79e6edbf703b684beeaf8f0c8ee7b79a581918ef","unresolved":true,"context_lines":[{"line_number":962,"context_line":"                subnet_cidrs[subnet_id] \u003d subnet_cidr"},{"line_number":963,"context_line":"            ips.append("},{"line_number":964,"context_line":"                netaddr.IPNetwork("},{"line_number":965,"context_line":"                    \"%s/%s\" % (fixed_ip[\u0027ip_address\u0027], subnet_cidr.prefixlen)))"},{"line_number":966,"context_line":"        return ips"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    def _test_default_sec_grp_scenarios(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"c0f483bf_5d6e3ed8","line":965,"updated":"2023-03-09 22:55:11.000000000","message":"shouldn\u0027t it test ipv6 subnets?","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"73a99c694f61476b3d6b670616e6d68aacba17db","unresolved":true,"context_lines":[{"line_number":962,"context_line":"                subnet_cidrs[subnet_id] \u003d subnet_cidr"},{"line_number":963,"context_line":"            ips.append("},{"line_number":964,"context_line":"                netaddr.IPNetwork("},{"line_number":965,"context_line":"                    \"%s/%s\" % (fixed_ip[\u0027ip_address\u0027], subnet_cidr.prefixlen)))"},{"line_number":966,"context_line":"        return ips"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    def _test_default_sec_grp_scenarios(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"dabde48b_83792932","line":965,"in_reply_to":"c0f483bf_5d6e3ed8","updated":"2023-03-09 23:48:02.000000000","message":"Disregard.","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"79e6edbf703b684beeaf8f0c8ee7b79a581918ef","unresolved":true,"context_lines":[{"line_number":966,"context_line":"        return ips"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    def _test_default_sec_grp_scenarios(self):"},{"line_number":969,"context_line":"        server_ssh_clients, _, servers \u003d self._test_default_sec_grp_scenarios()"},{"line_number":970,"context_line":"        for i, server in enumerate(servers):"},{"line_number":971,"context_line":"            ip_cmd \u003d ip.IPCommand(ssh_client\u003dserver_ssh_clients[i])"},{"line_number":972,"context_line":"            ports \u003d self.client.list_ports("}],"source_content_type":"text/x-python","patch_set":2,"id":"0fa76239_7f657877","line":969,"updated":"2023-03-09 22:55:11.000000000","message":"unexpected recursive call\n\nyou probably want to:\n\n+        ssh_sg \u003d self.create_security_group(stateful\u003dFalse)\n+        self.create_loginable_secgroup_rule(secgroup_id\u003dssh_sg[\u0027id\u0027])\n+        server_ssh_clients, _, servers \u003d self.create_vm_testing_sec_grp(\n+            num_servers\u003d1, security_groups\u003d[{\u0027name\u0027: ssh_sg[\u0027name\u0027]}])","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"166b86c8e135405a7fe3a17a2efdc1aac3fca864","unresolved":false,"context_lines":[{"line_number":966,"context_line":"        return ips"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    def _test_default_sec_grp_scenarios(self):"},{"line_number":969,"context_line":"        server_ssh_clients, _, servers \u003d self._test_default_sec_grp_scenarios()"},{"line_number":970,"context_line":"        for i, server in enumerate(servers):"},{"line_number":971,"context_line":"            ip_cmd \u003d ip.IPCommand(ssh_client\u003dserver_ssh_clients[i])"},{"line_number":972,"context_line":"            ports \u003d self.client.list_ports("}],"source_content_type":"text/x-python","patch_set":2,"id":"ced25343_44f87be6","line":969,"in_reply_to":"0fa76239_7f657877","updated":"2023-03-10 09:40:02.000000000","message":"Good catch. I want to run _test_default_sec_grp_scenarios() from parent class and later, as an additional check check those IP addresses.","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"79e6edbf703b684beeaf8f0c8ee7b79a581918ef","unresolved":true,"context_lines":[{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    def _test_default_sec_grp_scenarios(self):"},{"line_number":969,"context_line":"        server_ssh_clients, _, servers \u003d self._test_default_sec_grp_scenarios()"},{"line_number":970,"context_line":"        for i, server in enumerate(servers):"},{"line_number":971,"context_line":"            ip_cmd \u003d ip.IPCommand(ssh_client\u003dserver_ssh_clients[i])"},{"line_number":972,"context_line":"            ports \u003d self.client.list_ports("},{"line_number":973,"context_line":"                device_id\u003dserver[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ccae4233_f5c46564","line":970,"updated":"2023-03-09 22:55:11.000000000","message":"you could: for ssh, server in zip(server_ssh_clients, servers):","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"166b86c8e135405a7fe3a17a2efdc1aac3fca864","unresolved":false,"context_lines":[{"line_number":967,"context_line":""},{"line_number":968,"context_line":"    def _test_default_sec_grp_scenarios(self):"},{"line_number":969,"context_line":"        server_ssh_clients, _, servers \u003d self._test_default_sec_grp_scenarios()"},{"line_number":970,"context_line":"        for i, server in enumerate(servers):"},{"line_number":971,"context_line":"            ip_cmd \u003d ip.IPCommand(ssh_client\u003dserver_ssh_clients[i])"},{"line_number":972,"context_line":"            ports \u003d self.client.list_ports("},{"line_number":973,"context_line":"                device_id\u003dserver[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"2ab5159c_96dbb473","line":970,"in_reply_to":"ccae4233_f5c46564","updated":"2023-03-10 09:40:02.000000000","message":"Done","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"79e6edbf703b684beeaf8f0c8ee7b79a581918ef","unresolved":true,"context_lines":[{"line_number":973,"context_line":"                device_id\u003dserver[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027]"},{"line_number":974,"context_line":"            for port in ports:"},{"line_number":975,"context_line":"                configured_cidrs \u003d [ip.network for ip in"},{"line_number":976,"context_line":"                                    ip_cmd.list_addresses(port\u003dport)]"},{"line_number":977,"context_line":"                for port_cidr in self._get_port_cidrs(port):"},{"line_number":978,"context_line":"                    self.assertIn(port_cidr, configured_cidrs)"},{"line_number":979,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2d21a6ee_a74f3380","line":976,"updated":"2023-03-09 22:55:11.000000000","message":"not sure why yet, but this doesn\u0027t return ipv6 addresses that are clearly set inside the VM (I see slaac addresses set in console) [that\u0027s with the corresponding neutron patch I\u0027m going to post that should fix RA/NA for stateless SG).","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"166b86c8e135405a7fe3a17a2efdc1aac3fca864","unresolved":true,"context_lines":[{"line_number":973,"context_line":"                device_id\u003dserver[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027]"},{"line_number":974,"context_line":"            for port in ports:"},{"line_number":975,"context_line":"                configured_cidrs \u003d [ip.network for ip in"},{"line_number":976,"context_line":"                                    ip_cmd.list_addresses(port\u003dport)]"},{"line_number":977,"context_line":"                for port_cidr in self._get_port_cidrs(port):"},{"line_number":978,"context_line":"                    self.assertIn(port_cidr, configured_cidrs)"},{"line_number":979,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"390a1de1_bcefbb69","line":976,"in_reply_to":"2d21a6ee_a74f3380","updated":"2023-03-10 09:40:02.000000000","message":"I just tried it locally with Your patch https://review.opendev.org/c/openstack/neutron/+/877049 and it worked fine.\nAlso I removed skip of those tests and made this patch to depends on Yours.","commit_id":"361139f21904b760f594c9708e448a11c4ce59f0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8de7c79319a8957bb82676cb553215820da6e96d","unresolved":true,"context_lines":[{"line_number":984,"context_line":"    stateless_sg \u003d True"},{"line_number":985,"context_line":"    ipv6_mode \u003d \u0027slaac\u0027"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    def _get_server_ipv6_configuration(self, server):"},{"line_number":988,"context_line":"        configuration \u003d collections.defaultdict(list)"},{"line_number":989,"context_line":"        ports \u003d self.client.list_ports(device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027]"},{"line_number":990,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":5,"id":"db131350_bd50a02e","line":987,"range":{"start_line":987,"start_character":8,"end_line":987,"end_character":38},"updated":"2023-03-22 16:46:22.000000000","message":"Where are you using this method?","commit_id":"0fb6417b81504608fcf35cddb59e73ed33e283dc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"c4e84b80561d0565dd8dd76bc49080bb4f731abc","unresolved":false,"context_lines":[{"line_number":984,"context_line":"    stateless_sg \u003d True"},{"line_number":985,"context_line":"    ipv6_mode \u003d \u0027slaac\u0027"},{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    def _get_server_ipv6_configuration(self, server):"},{"line_number":988,"context_line":"        configuration \u003d collections.defaultdict(list)"},{"line_number":989,"context_line":"        ports \u003d self.client.list_ports(device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027]"},{"line_number":990,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":5,"id":"9f313527_02115118","line":987,"range":{"start_line":987,"start_character":8,"end_line":987,"end_character":38},"in_reply_to":"db131350_bd50a02e","updated":"2023-03-30 09:14:32.000000000","message":"hmm, good catch. It\u0027s leftover which should be removed 😊","commit_id":"0fb6417b81504608fcf35cddb59e73ed33e283dc"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"8de7c79319a8957bb82676cb553215820da6e96d","unresolved":true,"context_lines":[{"line_number":1004,"context_line":"                subnet \u003d self.client.show_subnet(subnet_id)[\u0027subnet\u0027]"},{"line_number":1005,"context_line":"                subnet_cidr \u003d netaddr.IPNetwork(subnet[\u0027cidr\u0027])"},{"line_number":1006,"context_line":"                subnet_cidrs[subnet_id] \u003d subnet_cidr"},{"line_number":1007,"context_line":"            ips.append("},{"line_number":1008,"context_line":"                netaddr.IPNetwork("},{"line_number":1009,"context_line":"                    \"%s/%s\" % (fixed_ip[\u0027ip_address\u0027], subnet_cidr.prefixlen)))"},{"line_number":1010,"context_line":"        return ips"}],"source_content_type":"text/x-python","patch_set":5,"id":"c9ca386d_1d74f549","line":1007,"range":{"start_line":1007,"start_character":12,"end_line":1007,"end_character":15},"updated":"2023-03-22 16:46:22.000000000","message":"nit: just for debugging purposes, is it possible to write this information in the test logs? just to have the port IP addresses somewhere explicitly printed.","commit_id":"0fb6417b81504608fcf35cddb59e73ed33e283dc"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"ca836bd335c631ef4f0073aa06ca9e5fedf05d18","unresolved":false,"context_lines":[{"line_number":1004,"context_line":"                subnet \u003d self.client.show_subnet(subnet_id)[\u0027subnet\u0027]"},{"line_number":1005,"context_line":"                subnet_cidr \u003d netaddr.IPNetwork(subnet[\u0027cidr\u0027])"},{"line_number":1006,"context_line":"                subnet_cidrs[subnet_id] \u003d subnet_cidr"},{"line_number":1007,"context_line":"            ips.append("},{"line_number":1008,"context_line":"                netaddr.IPNetwork("},{"line_number":1009,"context_line":"                    \"%s/%s\" % (fixed_ip[\u0027ip_address\u0027], subnet_cidr.prefixlen)))"},{"line_number":1010,"context_line":"        return ips"}],"source_content_type":"text/x-python","patch_set":5,"id":"731669e8_89fcab11","line":1007,"range":{"start_line":1007,"start_character":12,"end_line":1007,"end_character":15},"in_reply_to":"c9ca386d_1d74f549","updated":"2023-03-29 09:37:50.000000000","message":"Done","commit_id":"0fb6417b81504608fcf35cddb59e73ed33e283dc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ffad5df9224dafb1847476f58995ddb1ef96b8de","unresolved":true,"context_lines":[{"line_number":1110,"context_line":"    stateless_sg \u003d True"},{"line_number":1111,"context_line":"    ipv6_mode \u003d \u0027slaac\u0027"},{"line_number":1112,"context_line":""},{"line_number":1113,"context_line":"    def _get_server_ipv6_configuration(self, server):"},{"line_number":1114,"context_line":"        configuration \u003d collections.defaultdict(list)"},{"line_number":1115,"context_line":"        ports \u003d self.client.list_ports(device_id\u003dserver[\u0027id\u0027])[\u0027ports\u0027]"},{"line_number":1116,"context_line":"        for port in ports:"}],"source_content_type":"text/x-python","patch_set":6,"id":"ea1e8dec_59f105b0","line":1113,"range":{"start_line":1113,"start_character":8,"end_line":1113,"end_character":38},"updated":"2023-03-30 09:17:48.000000000","message":"good catch","commit_id":"f7f6dbb368b550a315f9716a248f8984fc6578fc"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0cff0f9c0ca93fb53d772f21f7380cb873cfdedd","unresolved":true,"context_lines":[{"line_number":1199,"context_line":"    stateless_sg \u003d True"},{"line_number":1200,"context_line":"    ipv6_mode \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"    @decorators.idempotent_id(\u0027c61c127c-e08f-4ddf-87a3-58b3c86e5476\u0027)"},{"line_number":1203,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":1204,"context_line":"        self._test_default_sec_grp_scenarios()"}],"source_content_type":"text/x-python","patch_set":9,"id":"7e674847_0ceef028","line":1204,"range":{"start_line":1202,"start_character":0,"end_line":1204,"end_character":46},"updated":"2023-04-14 07:08:50.000000000","message":"nit: are you sure that you have to define the test here also? as StatelessSecGroupDualStackSlaacTest is the parent class it is not necessary","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":13252,"name":"Dr. Jens Harbott","display_name":"Jens Harbott (frickler)","email":"frickler@offenerstapel.de","username":"jrosenboom"},"change_message_id":"a49e8ccb4f48d0c6c27e9085c0698e8f2a3a161d","unresolved":true,"context_lines":[{"line_number":1199,"context_line":"    stateless_sg \u003d True"},{"line_number":1200,"context_line":"    ipv6_mode \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"    @decorators.idempotent_id(\u0027c61c127c-e08f-4ddf-87a3-58b3c86e5476\u0027)"},{"line_number":1203,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":1204,"context_line":"        self._test_default_sec_grp_scenarios()"}],"source_content_type":"text/x-python","patch_set":9,"id":"b4f447b9_1b680935","line":1204,"range":{"start_line":1202,"start_character":0,"end_line":1204,"end_character":46},"in_reply_to":"7e674847_0ceef028","updated":"2023-04-14 07:21:06.000000000","message":"But it is better to have a different idempotent_id defined","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"af4cdaf998dd57f843df1194f80497a2d765f243","unresolved":true,"context_lines":[{"line_number":1199,"context_line":"    stateless_sg \u003d True"},{"line_number":1200,"context_line":"    ipv6_mode \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"    @decorators.idempotent_id(\u0027c61c127c-e08f-4ddf-87a3-58b3c86e5476\u0027)"},{"line_number":1203,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":1204,"context_line":"        self._test_default_sec_grp_scenarios()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9722ae56_89133830","line":1204,"range":{"start_line":1202,"start_character":0,"end_line":1204,"end_character":46},"in_reply_to":"7e674847_0ceef028","updated":"2023-04-14 07:29:40.000000000","message":"yes shouldn\u0027t be needed here.","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"19a1be3ca0705fa07e1a39d19ced2462ff83eb67","unresolved":true,"context_lines":[{"line_number":1199,"context_line":"    stateless_sg \u003d True"},{"line_number":1200,"context_line":"    ipv6_mode \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"    @decorators.idempotent_id(\u0027c61c127c-e08f-4ddf-87a3-58b3c86e5476\u0027)"},{"line_number":1203,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":1204,"context_line":"        self._test_default_sec_grp_scenarios()"}],"source_content_type":"text/x-python","patch_set":9,"id":"e696b954_6a03bba6","line":1204,"range":{"start_line":1202,"start_character":0,"end_line":1204,"end_character":46},"in_reply_to":"9722ae56_89133830","updated":"2023-05-04 10:59:42.000000000","message":"I did it exactly to have different idempotent_ids for each test and I think it should be like that.","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"efb6a1463513b63f5d6410347b17318eb7187e7a","unresolved":false,"context_lines":[{"line_number":1199,"context_line":"    stateless_sg \u003d True"},{"line_number":1200,"context_line":"    ipv6_mode \u003d \u0027dhcpv6-stateless\u0027"},{"line_number":1201,"context_line":""},{"line_number":1202,"context_line":"    @decorators.idempotent_id(\u0027c61c127c-e08f-4ddf-87a3-58b3c86e5476\u0027)"},{"line_number":1203,"context_line":"    def test_default_sec_grp_scenarios(self):"},{"line_number":1204,"context_line":"        self._test_default_sec_grp_scenarios()"}],"source_content_type":"text/x-python","patch_set":9,"id":"5b2acab4_e4537a5d","line":1204,"range":{"start_line":1202,"start_character":0,"end_line":1204,"end_character":46},"in_reply_to":"e696b954_6a03bba6","updated":"2023-06-20 08:02:19.000000000","message":"Ack","commit_id":"b603927dbf539176a2e931ebad4aa0eee3ee188f"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"967f130f671b9272404f96de07ee8d27ea227b99","unresolved":true,"context_lines":[{"line_number":881,"context_line":"        self._test_remove_sec_grp_from_active_vm()"},{"line_number":882,"context_line":""},{"line_number":883,"context_line":"    @decorators.idempotent_id(\u002701f0ddca-b049-47eb-befd-82acb502c9ec\u0027)"},{"line_number":884,"context_line":"    def test_established_tcp_session_after_re_attachinging_sg(self):"},{"line_number":885,"context_line":"        \"\"\"Test existing connection remain open after sg has been re-attached"},{"line_number":886,"context_line":""},{"line_number":887,"context_line":"        Verifies that new packets can pass over the existing connection when"}],"source_content_type":"text/x-python","patch_set":14,"id":"ce6c7124_41890d8f","line":884,"updated":"2023-06-20 07:53:19.000000000","message":"we disable this test in iptables_hybrid jobs and since we changing the Test class name we should update the skiplist as well.,\n\nthe last run logs are not available but seems those jobs passed, so issue with test fixed? may be with move to ubuntu-jammy?","commit_id":"5a9c67741274e49841091221e21365db810b81b1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8ef81c259b5667d714ff0da7327a30a17b1f689d","unresolved":true,"context_lines":[{"line_number":1155,"context_line":"            ips.append("},{"line_number":1156,"context_line":"                netaddr.IPNetwork("},{"line_number":1157,"context_line":"                    \"%s/%s\" % (fixed_ip[\u0027ip_address\u0027], subnet_cidr.prefixlen)))"},{"line_number":1158,"context_line":"        LOG.debug(\"On port %s found IP cidrs: %s\", port[\u0027id\u0027], ips)"},{"line_number":1159,"context_line":"        return ips"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":"    def _test_default_sec_grp_scenarios(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"bff29cfb_5bb16983","line":1158,"updated":"2023-06-01 17:31:03.000000000","message":"Not sure if you intended to remove the debug as most tests don\u0027t have it?","commit_id":"5a9c67741274e49841091221e21365db810b81b1"}]}