)]}'
{"neutron_tempest_plugin/scenario/base.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b8dc8d88916df145a400c1a541964e97aa5f97b3","unresolved":true,"context_lines":[{"line_number":196,"context_line":"        Allowing ingress traffic from metadata server, required only for"},{"line_number":197,"context_line":"        stateless security groups."},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        # NOTE(slaweq): in case of stateless security groups, there is no"},{"line_number":200,"context_line":"        # \"related\" or \"established\" traffic matching at all so even if"},{"line_number":201,"context_line":"        # egress traffic to 169.254.169.254 is allowed by default SG, we"},{"line_number":202,"context_line":"        # need to explicitly allow ingress traffic from the metadata server"}],"source_content_type":"text/x-python","patch_set":1,"id":"18b4c699_53f6fe68","line":199,"updated":"2023-02-17 08:18:38.000000000","message":"I don\u0027t understand this patch TBH. Now comment isn\u0027t valid anymore as it will add this rule always, not only to stateless sg. Can You explain a bit more why Youp proposed this change?","commit_id":"0ea053cb32fc292c643dae4c0d1518382f25f70d"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"e4d8a8c7764e695ebec99800410c3d331ae67cc2","unresolved":true,"context_lines":[{"line_number":196,"context_line":"        Allowing ingress traffic from metadata server, required only for"},{"line_number":197,"context_line":"        stateless security groups."},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        # NOTE(slaweq): in case of stateless security groups, there is no"},{"line_number":200,"context_line":"        # \"related\" or \"established\" traffic matching at all so even if"},{"line_number":201,"context_line":"        # egress traffic to 169.254.169.254 is allowed by default SG, we"},{"line_number":202,"context_line":"        # need to explicitly allow ingress traffic from the metadata server"}],"source_content_type":"text/x-python","patch_set":1,"id":"916c8ac5_d493b015","line":199,"in_reply_to":"18b4c699_53f6fe68","updated":"2023-02-22 11:35:11.000000000","message":"\u003e Can You explain a bit more why Youp proposed this change?\nI wanted to allow this base method to be called regardless of \u0027stateless_sg\u0027 attribute.\nWhen this method is used in all repo, currently only in stateless security group tests, there is a check using \u0027self.stateless_sg\u0027 every time, so this check inside the base method in L199 isn\u0027t needed anymore.\nA few examples of that can be seen here:\nhttps://review.opendev.org/c/openstack/neutron-tempest-plugin/+/871397\n\nIf other tests need to use this method, for example: a security group logging test, which needs stateless security groups as well.\nSuch tests can use which ever conditions needed in the test code, regardless of \u0027stateless_sg\u0027 property in L199.\n\nLet me know if that explanation makes more sense.\n\n\n\u003e Now comment isn\u0027t valid anymore as it will add this rule always not only to stateless sg. \nI can also drop the comment, whatever you prefer.\n\nThanks!","commit_id":"0ea053cb32fc292c643dae4c0d1518382f25f70d"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"02bf86af7df29ef3e095ea0aeb098d3b6d78d551","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        Allowing ingress traffic from metadata server, required only for"},{"line_number":197,"context_line":"        stateless security groups."},{"line_number":198,"context_line":"        \"\"\""},{"line_number":199,"context_line":"        # NOTE(slaweq): in case of stateless security groups, there is no"},{"line_number":200,"context_line":"        # \"related\" or \"established\" traffic matching at all so even if"},{"line_number":201,"context_line":"        # egress traffic to 169.254.169.254 is allowed by default SG, we"},{"line_number":202,"context_line":"        # need to explicitly allow ingress traffic from the metadata server"}],"source_content_type":"text/x-python","patch_set":1,"id":"27ae5bb4_4172aa6d","line":199,"in_reply_to":"916c8ac5_d493b015","updated":"2023-02-27 14:13:16.000000000","message":"ok, makes sense, thx","commit_id":"0ea053cb32fc292c643dae4c0d1518382f25f70d"}]}