)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"ef003fffa70c6fa577d28cfd92fc30cc6fa2e9bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4ffe7930_f2b50a2b","updated":"2023-07-03 20:48:22.000000000","message":"Verified to work with OSP17.1 and fragmented traffic accepted test","commit_id":"dff43fe484e80a2f5b9d15b4286340f6857b0bee"}],"neutron_tempest_plugin/scenario/test_security_groups.py":[{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"892c6500c261349da8170450669dcee26fb89635","unresolved":true,"context_lines":[{"line_number":1121,"context_line":"        for fip in fips.values():"},{"line_number":1122,"context_line":"            self.check_connectivity("},{"line_number":1123,"context_line":"                fip[\u0027floating_ip_address\u0027],"},{"line_number":1124,"context_line":"                CONF.validation.image_ssh_user,"},{"line_number":1125,"context_line":"                self.keypair[\u0027private_key\u0027])"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        # Check that ICMP packets bigger than MTU aren\u0027t working without"}],"source_content_type":"text/x-python","patch_set":1,"id":"30ee01a3_0c04d2fd","line":1124,"range":{"start_line":1124,"start_character":16,"end_line":1124,"end_character":47},"updated":"2023-07-03 21:16:43.000000000","message":"I believe it should be self.username, but only in case it is set somewhere earlier like\n\n        if CONF.neutron_plugin_options.default_image_is_advanced:\n            cls.username \u003d CONF.validation.image_ssh_user\n        else:\n            cls.username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user","commit_id":"dff43fe484e80a2f5b9d15b4286340f6857b0bee"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"b58f88e7dbfcc539559ece7b37e6c15fc6a1252b","unresolved":true,"context_lines":[{"line_number":1121,"context_line":"        for fip in fips.values():"},{"line_number":1122,"context_line":"            self.check_connectivity("},{"line_number":1123,"context_line":"                fip[\u0027floating_ip_address\u0027],"},{"line_number":1124,"context_line":"                CONF.validation.image_ssh_user,"},{"line_number":1125,"context_line":"                self.keypair[\u0027private_key\u0027])"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        # Check that ICMP packets bigger than MTU aren\u0027t working without"}],"source_content_type":"text/x-python","patch_set":1,"id":"f1989c85_bf27d072","line":1124,"range":{"start_line":1124,"start_character":16,"end_line":1124,"end_character":47},"in_reply_to":"30ee01a3_0c04d2fd","updated":"2023-07-04 09:56:45.000000000","message":"It seems in L1118 a few lines back, this test case uses only advanced image, so I think it is best to handle possible failure by adding the advanced_image_ssh_user configuration set by CI.\n\nLet me know if you agree, if there is no objection, I will abandon this change.","commit_id":"dff43fe484e80a2f5b9d15b4286340f6857b0bee"},{"author":{"_account_id":29350,"name":"Roman Safronov","email":"rsafrono@redhat.com","username":"rsafrono"},"change_message_id":"8dbf5ce8a220f94ebb1947132e4b827a59a6543c","unresolved":true,"context_lines":[{"line_number":1121,"context_line":"        for fip in fips.values():"},{"line_number":1122,"context_line":"            self.check_connectivity("},{"line_number":1123,"context_line":"                fip[\u0027floating_ip_address\u0027],"},{"line_number":1124,"context_line":"                CONF.validation.image_ssh_user,"},{"line_number":1125,"context_line":"                self.keypair[\u0027private_key\u0027])"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        # Check that ICMP packets bigger than MTU aren\u0027t working without"}],"source_content_type":"text/x-python","patch_set":1,"id":"1c431804_6d25e33b","line":1124,"range":{"start_line":1124,"start_character":16,"end_line":1124,"end_character":47},"in_reply_to":"f1989c85_bf27d072","updated":"2023-07-05 08:45:32.000000000","message":"agree","commit_id":"dff43fe484e80a2f5b9d15b4286340f6857b0bee"}]}