)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"23461a8e526bf71b66b69962747d602f923d136b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Bracha Frenkel \u003cbfrenkel@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-12 12:51:22 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adds a test for SSH connectivity for 3 VMs on the same network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I107ca20426bc408f5ce494d472f5d58a577f3a2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d8699630_3141cb48","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"updated":"2023-07-12 10:53:06.000000000","message":"Please add DNM prefixed in title (Do Not Merge), and explain that this patch is for testing and exercise purposes.","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":36141,"name":"Bracha Frenkel","display_name":"Bracha Frenkel","email":"bfrenkel@redhat.com","username":"bfrenkel"},"change_message_id":"daf5508b0afe5eab39bb9a9e8fee81e10a2ad178","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Bracha Frenkel \u003cbfrenkel@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-07-12 12:51:22 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"adds a test for SSH connectivity for 3 VMs on the same network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I107ca20426bc408f5ce494d472f5d58a577f3a2d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7153ab4a_32bdd684","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":4},"in_reply_to":"d8699630_3141cb48","updated":"2023-07-25 14:48:24.000000000","message":"Ack","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"99ec3d3613944e69712713559bb7055c9582d79a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6e91cf1d_6f730255","updated":"2024-01-24 09:19:50.000000000","message":"This was a DNM patch:\nGuided exercise in order to more easily contribute to plugin code more complex tasks.\n\nNo need to merge, can be abandoned.","commit_id":"89d1ab2dda93c1a37a1fe5e0b6f09302d560e582"}],"neutron_tempest_plugin/scenario/test_basic.py":[{"author":{"_account_id":36141,"name":"Bracha Frenkel","display_name":"Bracha Frenkel","email":"bfrenkel@redhat.com","username":"bfrenkel"},"change_message_id":"daf5508b0afe5eab39bb9a9e8fee81e10a2ad178","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import testtools"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from tempest.lib import decorators"},{"line_number":18,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron_tempest_plugin.common import ssh"},{"line_number":21,"context_line":"from neutron_tempest_plugin import config"}],"source_content_type":"text/x-python","patch_set":1,"id":"ae2842bb_220caf0f","line":18,"in_reply_to":"0075f791_794314fe","updated":"2023-07-25 14:48:24.000000000","message":"\u003e pep8: H306: imports not in alphabetical order (tempest.lib.decorators, tempest.lib.common.utils.data_utils)\n\nPlease fix.","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"3f2b654e6ccb33f7933a2dcb5b76fcc9448d0bb1","unresolved":true,"context_lines":[{"line_number":37,"context_line":"        # Create a network resource"},{"line_number":38,"context_line":"        self.network \u003d self.create_network()"},{"line_number":39,"context_line":"        self.subnet \u003d self.create_subnet(self.network)"},{"line_number":40,"context_line":"        secgroup \u003d self.os_primary.network_client.create_security_group(name\u003ddata_utils.rand_name(\u0027secgroup\u0027))"},{"line_number":41,"context_line":"        self.security_groups.append(secgroup[\u0027security_group\u0027])"},{"line_number":42,"context_line":"        router \u003d self.create_router_by_client()"},{"line_number":43,"context_line":"        self.create_router_interface(router[\u0027id\u0027], self.subnet[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fcdf1f82_26e77b3f","line":40,"range":{"start_line":40,"start_character":71,"end_line":40,"end_character":72},"updated":"2023-07-12 10:27:50.000000000","message":"nit:\nNotice the line length according to PEP 8, you can use flake8 and pylint to check that before uploading.\nYou can enter a new line after parenthesis opening, to keep lines short and avoid using line continuation with backslash.","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":36141,"name":"Bracha Frenkel","display_name":"Bracha Frenkel","email":"bfrenkel@redhat.com","username":"bfrenkel"},"change_message_id":"daf5508b0afe5eab39bb9a9e8fee81e10a2ad178","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Create a network resource"},{"line_number":38,"context_line":"        self.network \u003d self.create_network()"},{"line_number":39,"context_line":"        self.subnet \u003d self.create_subnet(self.network)"},{"line_number":40,"context_line":"        secgroup \u003d self.os_primary.network_client.create_security_group(name\u003ddata_utils.rand_name(\u0027secgroup\u0027))"},{"line_number":41,"context_line":"        self.security_groups.append(secgroup[\u0027security_group\u0027])"},{"line_number":42,"context_line":"        router \u003d self.create_router_by_client()"},{"line_number":43,"context_line":"        self.create_router_interface(router[\u0027id\u0027], self.subnet[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"5bdf5f7a_b0fc3e60","line":40,"in_reply_to":"6eb35bec_18dc3924","updated":"2023-07-25 14:48:24.000000000","message":"\u003e pep8: E501 line too long (110 \u003e 79 characters)\n\nPlease fix.","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":36141,"name":"Bracha Frenkel","display_name":"Bracha Frenkel","email":"bfrenkel@redhat.com","username":"bfrenkel"},"change_message_id":"daf5508b0afe5eab39bb9a9e8fee81e10a2ad178","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        # Create a network resource"},{"line_number":38,"context_line":"        self.network \u003d self.create_network()"},{"line_number":39,"context_line":"        self.subnet \u003d self.create_subnet(self.network)"},{"line_number":40,"context_line":"        secgroup \u003d self.os_primary.network_client.create_security_group(name\u003ddata_utils.rand_name(\u0027secgroup\u0027))"},{"line_number":41,"context_line":"        self.security_groups.append(secgroup[\u0027security_group\u0027])"},{"line_number":42,"context_line":"        router \u003d self.create_router_by_client()"},{"line_number":43,"context_line":"        self.create_router_interface(router[\u0027id\u0027], self.subnet[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"ed1f3f6c_214296a6","line":40,"range":{"start_line":40,"start_character":71,"end_line":40,"end_character":72},"in_reply_to":"fcdf1f82_26e77b3f","updated":"2023-07-25 14:48:24.000000000","message":"Done","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"23461a8e526bf71b66b69962747d602f923d136b","unresolved":true,"context_lines":[{"line_number":42,"context_line":"        router \u003d self.create_router_by_client()"},{"line_number":43,"context_line":"        self.create_router_interface(router[\u0027id\u0027], self.subnet[\u0027id\u0027])"},{"line_number":44,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":45,"context_line":"        self.create_loginable_secgroup_rule("},{"line_number":46,"context_line":"            secgroup_id\u003dsecgroup[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        server_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"525d965d_b7463c5b","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":43},"updated":"2023-07-12 10:53:06.000000000","message":"nit: This can be grouped with previous lines of security group creation in L40.","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":36141,"name":"Bracha Frenkel","display_name":"Bracha Frenkel","email":"bfrenkel@redhat.com","username":"bfrenkel"},"change_message_id":"daf5508b0afe5eab39bb9a9e8fee81e10a2ad178","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        router \u003d self.create_router_by_client()"},{"line_number":43,"context_line":"        self.create_router_interface(router[\u0027id\u0027], self.subnet[\u0027id\u0027])"},{"line_number":44,"context_line":"        self.keypair \u003d self.create_keypair()"},{"line_number":45,"context_line":"        self.create_loginable_secgroup_rule("},{"line_number":46,"context_line":"            secgroup_id\u003dsecgroup[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        server_kwargs \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"e06688e1_3307f585","line":45,"range":{"start_line":45,"start_character":8,"end_line":45,"end_character":43},"in_reply_to":"525d965d_b7463c5b","updated":"2023-07-25 14:48:24.000000000","message":"Done","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"3f2b654e6ccb33f7933a2dcb5b76fcc9448d0bb1","unresolved":true,"context_lines":[{"line_number":46,"context_line":"            secgroup_id\u003dsecgroup[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        server_kwargs \u003d {"},{"line_number":49,"context_line":"            \u0027flavor_ref\u0027: CONF.compute.flavor_ref,"},{"line_number":50,"context_line":"            \u0027image_ref\u0027: CONF.compute.image_ref,"},{"line_number":51,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":52,"context_line":"            \u0027networks\u0027: [{\u0027uuid\u0027: self.network[\u0027id\u0027]}],"},{"line_number":53,"context_line":"            \u0027security_groups\u0027: [{\u0027name\u0027: secgroup[\u0027security_group\u0027][\u0027name\u0027]}],"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a324870_2d300d65","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":48},"updated":"2023-07-12 10:27:50.000000000","message":"Would these flavor/image arguments work with advanced image and cirros?","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":36141,"name":"Bracha Frenkel","display_name":"Bracha Frenkel","email":"bfrenkel@redhat.com","username":"bfrenkel"},"change_message_id":"daf5508b0afe5eab39bb9a9e8fee81e10a2ad178","unresolved":false,"context_lines":[{"line_number":46,"context_line":"            secgroup_id\u003dsecgroup[\u0027security_group\u0027][\u0027id\u0027])"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        server_kwargs \u003d {"},{"line_number":49,"context_line":"            \u0027flavor_ref\u0027: CONF.compute.flavor_ref,"},{"line_number":50,"context_line":"            \u0027image_ref\u0027: CONF.compute.image_ref,"},{"line_number":51,"context_line":"            \u0027key_name\u0027: self.keypair[\u0027name\u0027],"},{"line_number":52,"context_line":"            \u0027networks\u0027: [{\u0027uuid\u0027: self.network[\u0027id\u0027]}],"},{"line_number":53,"context_line":"            \u0027security_groups\u0027: [{\u0027name\u0027: secgroup[\u0027security_group\u0027][\u0027name\u0027]}],"}],"source_content_type":"text/x-python","patch_set":1,"id":"9b427c81_d81d6f4c","line":50,"range":{"start_line":49,"start_character":0,"end_line":50,"end_character":48},"in_reply_to":"1a324870_2d300d65","updated":"2023-07-25 14:48:24.000000000","message":"I fixed it for advanced image and taste. Won\u0027t there be a problem now with image/flavor not set as advanced?","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"23461a8e526bf71b66b69962747d602f923d136b","unresolved":true,"context_lines":[{"line_number":56,"context_line":"        # create servers"},{"line_number":57,"context_line":"        for i in range(num_of_servers):"},{"line_number":58,"context_line":"            server_kwargs[\u0027name\u0027] \u003d \"server-%s\" % i"},{"line_number":59,"context_line":"            self.server \u003d self.create_server(**server_kwargs)"},{"line_number":60,"context_line":"            self.port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":61,"context_line":"                                               device_id\u003dself.server["},{"line_number":62,"context_line":"                                                   \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"b0bf6b28_e4a81eb3","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":17},"updated":"2023-07-12 10:53:06.000000000","message":"Why is it saved to instance? is it needed for other tests in class?\nNotice that each iteration overrides previous reference to details of last server created.","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":36141,"name":"Bracha Frenkel","display_name":"Bracha Frenkel","email":"bfrenkel@redhat.com","username":"bfrenkel"},"change_message_id":"daf5508b0afe5eab39bb9a9e8fee81e10a2ad178","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        # create servers"},{"line_number":57,"context_line":"        for i in range(num_of_servers):"},{"line_number":58,"context_line":"            server_kwargs[\u0027name\u0027] \u003d \"server-%s\" % i"},{"line_number":59,"context_line":"            self.server \u003d self.create_server(**server_kwargs)"},{"line_number":60,"context_line":"            self.port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":61,"context_line":"                                               device_id\u003dself.server["},{"line_number":62,"context_line":"                                                   \u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3e061758_b8cad096","line":59,"range":{"start_line":59,"start_character":12,"end_line":59,"end_character":17},"in_reply_to":"b0bf6b28_e4a81eb3","updated":"2023-07-25 14:48:24.000000000","message":"Done","commit_id":"e00984931e46176014cab201621095bdcb24c8bd"},{"author":{"_account_id":36141,"name":"Bracha Frenkel","display_name":"Bracha Frenkel","email":"bfrenkel@redhat.com","username":"bfrenkel"},"change_message_id":"daf5508b0afe5eab39bb9a9e8fee81e10a2ad178","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"            # check connectivity"},{"line_number":69,"context_line":"            self.check_connectivity(fip[\u0027floating_ip_address\u0027],"},{"line_number":70,"context_line":"                                    CONF.neutron_plugin_options.advanced_image_ssh_user,"},{"line_number":71,"context_line":"                                    self.keypair[\u0027private_key\u0027])"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @testtools.skipUnless("}],"source_content_type":"text/x-python","patch_set":3,"id":"57d8a712_f5a01f7f","line":70,"in_reply_to":"a005bdd9_9a5420f3","updated":"2023-07-25 14:48:24.000000000","message":"\u003e pep8: E501 line too long (88 \u003e 79 characters)\n\nPlease fix.","commit_id":"ab4ffdaa75429674ae91329dd4597093ee74d8ec"}]}