)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"80d14ccb2d2b1d8cc5d6c6d5d092cbda2f52135b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66645496_35c43ff2","updated":"2023-07-24 08:59:24.000000000","message":"Generally looks great :)\nI just wrote about some things to notice","commit_id":"4b18d30db16cf2851cd3b3900601d1da20554594"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"8328207a40cdf083b4d673aee86b2d70b8f452d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8f9020d_21e514ef","updated":"2024-01-24 09:03:54.000000000","message":"This was a DNM:\nGuided exercise in order to more easily contribute to plugin code more complex tasks.","commit_id":"6ccb42359efdbe0c19c43d3b1f1bfd2737b09cbe"}],"neutron_tempest_plugin/scenario/base.py":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"80d14ccb2d2b1d8cc5d6c6d5d092cbda2f52135b","unresolved":true,"context_lines":[{"line_number":323,"context_line":"                server_kwargs[\u0027name\u0027] \u003d one_server"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"            server \u003d self.create_server(**server_kwargs)"},{"line_number":326,"context_line":"            self.port \u003d self.client.list_ports(network_id\u003dself.network[\u0027id\u0027],"},{"line_number":327,"context_line":"                                               device_id\u003dserver[\u0027server\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":328,"context_line":"            self.servers.append(server)"},{"line_number":329,"context_line":"            fip \u003d self.create_floatingip(port\u003dself.port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2fd502cc_4087ac83","line":326,"range":{"start_line":326,"start_character":12,"end_line":326,"end_character":21},"updated":"2023-07-24 08:59:24.000000000","message":"Current use of \u0027self.port\u0027 is local to this method, could be used only as \u0027port\u0027, otherwise if needed in other places of a test class, it may be better to use a list saved for all test class (similar to \u0027self.fips\u0027).","commit_id":"4b18d30db16cf2851cd3b3900601d1da20554594"}],"neutron_tempest_plugin/scenario/test_basic.py":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"80d14ccb2d2b1d8cc5d6c6d5d092cbda2f52135b","unresolved":true,"context_lines":[{"line_number":33,"context_line":"    @decorators.idempotent_id(\u0027de07fe0a-e955-449e-b48b-8641c14cd52e\u0027)"},{"line_number":34,"context_line":"    def test_basic_instance(self):"},{"line_number":35,"context_line":"        # Update the function call to create three VMs."},{"line_number":36,"context_line":"        self.setup_network_and_servers(server_name\u003d[\u0027vm1\u0027, \u0027vm2\u0027, \u0027vm3\u0027])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Perform the connectivity checks for each VM"},{"line_number":39,"context_line":"        for server, fip in zip(self.servers, self.fips):"}],"source_content_type":"text/x-python","patch_set":1,"id":"c611df0b_7cdf8f88","line":36,"range":{"start_line":36,"start_character":46,"end_line":36,"end_character":50},"updated":"2023-07-24 08:59:24.000000000","message":"nit: plural form, like: \u0027server_names\u0027 is more intuitive IMO.","commit_id":"4b18d30db16cf2851cd3b3900601d1da20554594"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"80d14ccb2d2b1d8cc5d6c6d5d092cbda2f52135b","unresolved":true,"context_lines":[{"line_number":36,"context_line":"        self.setup_network_and_servers(server_name\u003d[\u0027vm1\u0027, \u0027vm2\u0027, \u0027vm3\u0027])"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"        # Perform the connectivity checks for each VM"},{"line_number":39,"context_line":"        for server, fip in zip(self.servers, self.fips):"},{"line_number":40,"context_line":"            self.check_connectivity(fip[\u0027floating_ip_address\u0027],"},{"line_number":41,"context_line":"                                    CONF.validation.image_ssh_user,"},{"line_number":42,"context_line":"                                    self.keypair[\u0027private_key\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"02b2fe3c_2beecfa3","line":39,"range":{"start_line":39,"start_character":12,"end_line":39,"end_character":18},"updated":"2023-07-24 08:59:24.000000000","message":"No need to iterate self.servers, server isn\u0027t used inside for loop.","commit_id":"4b18d30db16cf2851cd3b3900601d1da20554594"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"80d14ccb2d2b1d8cc5d6c6d5d092cbda2f52135b","unresolved":true,"context_lines":[{"line_number":44,"context_line":"    @testtools.skipUnless("},{"line_number":45,"context_line":"        CONF.neutron_plugin_options.global_ip_address,"},{"line_number":46,"context_line":"        \u0027Global IP address is not defined.\u0027)"},{"line_number":47,"context_line":"    "},{"line_number":48,"context_line":"    @decorators.idempotent_id(\u002749609189-3a0e-43c7-832e-a7e114aad1c9\u0027)"},{"line_number":49,"context_line":"    def test_ping_global_ip_from_vm_with_fip(self):"},{"line_number":50,"context_line":"        self.setup_network_and_server()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6a899051_e0df8200","line":47,"range":{"start_line":47,"start_character":0,"end_line":47,"end_character":4},"updated":"2023-07-24 08:59:24.000000000","message":"nit: whitespace added","commit_id":"4b18d30db16cf2851cd3b3900601d1da20554594"}]}