)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"039531f68856769192ac0f5eb32d97a0ce8c2aa4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow updating of address pair on shared network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-on: 886214"},{"line_number":10,"context_line":"Bug: 1833455"},{"line_number":11,"context_line":"Change-Id: I6d3fb91e86fa4bb2d9c28aa75937dfb0d204b68d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dd293603_6d6a6767","line":9,"updated":"2023-08-03 11:37:03.000000000","message":"This will be (perhaps the commit hash is good as well)\nDepends-On: https://review.opendev.org/c/openstack/neutron/+/886214","commit_id":"cbdc84fe61297acfa0c2a3db9840b1599651d047"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"039531f68856769192ac0f5eb32d97a0ce8c2aa4","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Allow updating of address pair on shared network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Depends-on: 886214"},{"line_number":10,"context_line":"Bug: 1833455"},{"line_number":11,"context_line":"Change-Id: I6d3fb91e86fa4bb2d9c28aa75937dfb0d204b68d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"65934c00_8dffc31a","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":12},"updated":"2023-08-03 11:37:03.000000000","message":"This will be:\nRelated-Bug: #1833455","commit_id":"cbdc84fe61297acfa0c2a3db9840b1599651d047"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"3f0c8c65cc4543589bd6d82fdb7118671f95e4d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"91287fa2_efc1278b","updated":"2023-08-31 17:40:35.000000000","message":"recheck","commit_id":"4b1659fe8697ce912f997f711cc2d565a966b4ec"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6a6baec2a9b8e20318b32c8f9463f71e0cb6e2da","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"6a1a5b96_cb561c82","updated":"2024-04-22 09:01:56.000000000","message":"Hi, I can\u0027t recall the history of this patch, was it green with the depends-on:\nDepends-On: https://review.opendev.org/c/openstack/neutron/+/886214 ?","commit_id":"ebe841d6ba365af361d8b5a1d5e75ff1f6c0338b"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"cbc26a6fc06e11fabcb796ac513b1f86691ccd48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"7ffb4a8b_ccf273bd","in_reply_to":"6a1a5b96_cb561c82","updated":"2024-04-23 14:41:39.000000000","message":"It does indeed depend on that patch. But /that/ patch depends on this one, and my recollection is that if I mark each to depend on the other it makes Jenkins despair :(","commit_id":"ebe841d6ba365af361d8b5a1d5e75ff1f6c0338b"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"4cd91d6a31f23b54e8043932bcb1dd4a057910b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"7f7338b4_2bca0f4b","updated":"2024-05-09 20:03:11.000000000","message":"recheck","commit_id":"228ded06bc158c078f5819a9135931e685aee18f"}],"neutron_tempest_plugin/api/admin/test_shared_network_extension.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"9d9401167189ac47ae9c72dbf44c04742822881a","unresolved":true,"context_lines":[{"line_number":167,"context_line":"    @decorators.idempotent_id(\u002786c3529b-1231-40de-803c-ffffffff2fff\u0027)"},{"line_number":168,"context_line":"    def test_update_with_address_pair_allowed_on_other_network(self):"},{"line_number":169,"context_line":"        port \u003d self.create_port(self.network)"},{"line_number":170,"context_line":"        self.update_port("},{"line_number":171,"context_line":"            port, allowed_address_pairs\u003dself.allowed_address_pairs)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.assertEqual[port[\u0027allowed_address_pairs\u0027],"},{"line_number":174,"context_line":"                         self.allowed_address_pairs]"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"eb6d4013_7dc50b88","line":172,"range":{"start_line":170,"start_character":8,"end_line":172,"end_character":0},"updated":"2023-08-02 07:32:23.000000000","message":"By the failures this operation is not allowed for the tenant of this test, consider using another tenant/user or check the policies in Neutron repo","commit_id":"cbdc84fe61297acfa0c2a3db9840b1599651d047"},{"author":{"_account_id":12932,"name":"Andrew Bogott","email":"andrewbogott@gmail.com","username":"Andrew"},"change_message_id":"75d919876037fad4f9b76ab1a76b30476876d747","unresolved":true,"context_lines":[{"line_number":167,"context_line":"    @decorators.idempotent_id(\u002786c3529b-1231-40de-803c-ffffffff2fff\u0027)"},{"line_number":168,"context_line":"    def test_update_with_address_pair_allowed_on_other_network(self):"},{"line_number":169,"context_line":"        port \u003d self.create_port(self.network)"},{"line_number":170,"context_line":"        self.update_port("},{"line_number":171,"context_line":"            port, allowed_address_pairs\u003dself.allowed_address_pairs)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        self.assertEqual[port[\u0027allowed_address_pairs\u0027],"},{"line_number":174,"context_line":"                         self.allowed_address_pairs]"},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ee7e7b8_0ed5252c","line":172,"range":{"start_line":170,"start_character":8,"end_line":172,"end_character":0},"in_reply_to":"eb6d4013_7dc50b88","updated":"2023-08-02 16:41:44.000000000","message":"I cannot claim to fully understand these tests, or the depends-on tag. Can you advise? This test was failing with my policy changes in https://review.opendev.org/c/openstack/neutron/+/886214 so the test needs to be changed. I\u0027m struggling with the chicken/egg issue inherent in that, but also probably misunderstanding what this test is meant to do.","commit_id":"cbdc84fe61297acfa0c2a3db9840b1599651d047"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f09ff257158507b1a7bebb0cdbf101c5a1e683cd","unresolved":true,"context_lines":[{"line_number":151,"context_line":"class AllowedAddressPairSharedNetworkTest(base.BaseAdminNetworkTest):"},{"line_number":152,"context_line":"    allowed_address_pairs \u003d [{\u0027ip_address\u0027: \u00271.1.1.1\u0027}]"},{"line_number":153,"context_line":"    required_extensions \u003d [\u0027allowed-address-pairs\u0027]"},{"line_number":154,"context_line":"    force_tenant_isolation \u003d False"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @classmethod"},{"line_number":157,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":9,"id":"bf810138_a0d1aff1","line":154,"updated":"2024-05-09 15:10:55.000000000","message":"Should we be creating a new class with this setting? Do the below tests pass if this is True? Just trying to make sure we don\u0027t remove test coverage for a valid case.","commit_id":"228ded06bc158c078f5819a9135931e685aee18f"}]}
