)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"38d60420490dc82991efc3bf68724fecbb2ee684","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2690c442_89916a33","updated":"2023-09-08 05:16:37.000000000","message":"recheck","commit_id":"7aa02077ac12c05950eac6094f330d4082cf8881"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b9530573f0b6e08cac70066ae5ded19b3ca69a30","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"28bc6f9a_a2676e43","updated":"2023-09-07 15:02:55.000000000","message":"recheck neutron-tempest-plugin-openvswitch-iptables_hybrid-zed","commit_id":"7aa02077ac12c05950eac6094f330d4082cf8881"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"090ed1917184ec1929d0325029f98a2b18d78e71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"df7ad212_997df0e4","updated":"2023-09-07 21:54:18.000000000","message":"recheck neutron-tempest-plugin-ovn-2023-1","commit_id":"7aa02077ac12c05950eac6094f330d4082cf8881"}],"neutron_tempest_plugin/scenario/test_security_groups.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"188440a5c640e120875d3c885b8e05db3577e5c6","unresolved":true,"context_lines":[{"line_number":111,"context_line":"            cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet_v6[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":113,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":114,"context_line":"            cls.use_advanced_image \u003d False"},{"line_number":115,"context_line":"            cls.username \u003d CONF.validation.image_ssh_user"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            cls.use_advanced_image \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"ef6a089d_2dd1ab54","line":114,"updated":"2023-09-07 06:47:37.000000000","message":"this isn\u0027t used anywhere in that class, or am I missing something?","commit_id":"c8ceac13777e90473ebcf43aa0d22651d4f583b0"},{"author":{"_account_id":34777,"name":"Fiorella Yanac","email":"fyanac@redhat.com","username":"fyanac"},"change_message_id":"af586e01b85671a5b1a6483e4296e2f56cdbec91","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet_v6[\u0027id\u0027])"},{"line_number":112,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":113,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":114,"context_line":"            cls.use_advanced_image \u003d False"},{"line_number":115,"context_line":"            cls.username \u003d CONF.validation.image_ssh_user"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            cls.use_advanced_image \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"8ee972bc_c506aba5","line":114,"in_reply_to":"ef6a089d_2dd1ab54","updated":"2023-09-07 10:30:22.000000000","message":"yes, that\u0027s true. I removed it","commit_id":"c8ceac13777e90473ebcf43aa0d22651d4f583b0"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"188440a5c640e120875d3c885b8e05db3577e5c6","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":113,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":114,"context_line":"            cls.use_advanced_image \u003d False"},{"line_number":115,"context_line":"            cls.username \u003d CONF.validation.image_ssh_user"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            cls.use_advanced_image \u003d True"},{"line_number":118,"context_line":"            cls.username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"}],"source_content_type":"text/x-python","patch_set":1,"id":"45ee85bd_51374bc1","line":115,"updated":"2023-09-07 06:47:37.000000000","message":"this cls.username is used only once in this whole module, and it is in L1130. Maybe You can move this check simply to the test which needs it instead of having it here, set also for tests which aren\u0027t really using advanced image at all?","commit_id":"c8ceac13777e90473ebcf43aa0d22651d4f583b0"},{"author":{"_account_id":34777,"name":"Fiorella Yanac","email":"fyanac@redhat.com","username":"fyanac"},"change_message_id":"86901d7ae71b90c4c09b046524caba6da8b47d99","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":113,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":114,"context_line":"            cls.use_advanced_image \u003d False"},{"line_number":115,"context_line":"            cls.username \u003d CONF.validation.image_ssh_user"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            cls.use_advanced_image \u003d True"},{"line_number":118,"context_line":"            cls.username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"}],"source_content_type":"text/x-python","patch_set":1,"id":"2623b0a0_a3b8df13","line":115,"in_reply_to":"3ea87ab1_73654ea8","updated":"2023-09-07 12:35:04.000000000","message":"maybe I was wrong with patch2, I did patch3","commit_id":"c8ceac13777e90473ebcf43aa0d22651d4f583b0"},{"author":{"_account_id":34777,"name":"Fiorella Yanac","email":"fyanac@redhat.com","username":"fyanac"},"change_message_id":"af586e01b85671a5b1a6483e4296e2f56cdbec91","unresolved":true,"context_lines":[{"line_number":112,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":113,"context_line":"        if CONF.neutron_plugin_options.default_image_is_advanced:"},{"line_number":114,"context_line":"            cls.use_advanced_image \u003d False"},{"line_number":115,"context_line":"            cls.username \u003d CONF.validation.image_ssh_user"},{"line_number":116,"context_line":"        else:"},{"line_number":117,"context_line":"            cls.use_advanced_image \u003d True"},{"line_number":118,"context_line":"            cls.username \u003d CONF.neutron_plugin_options.advanced_image_ssh_user"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ea87ab1_73654ea8","line":115,"in_reply_to":"45ee85bd_51374bc1","updated":"2023-09-07 10:30:22.000000000","message":"yes, but I saw there are more \"check_connectivity\" in different tests so in patch2 I replaced user to self.username","commit_id":"c8ceac13777e90473ebcf43aa0d22651d4f583b0"}]}
