)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"bc5552326bcfe134838224104616d9c24851d49c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7225edd6_30756964","updated":"2023-11-21 21:18:56.000000000","message":"I don\u0027t think the SG tests should be removed here, plus there is https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/901051 - which should be abandoned?","commit_id":"3d9a1148b0f25e11043780694b144d4e0bf4874a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d5cf927fe49b9c8077b0d314db014f20d8198c51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3becc5d0_c1bf0d45","updated":"2023-10-23 08:19:11.000000000","message":"Just one small question.","commit_id":"3d9a1148b0f25e11043780694b144d4e0bf4874a"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"e836d3843ba152fd848283471bb84d3835a5e44b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d0aea81c_07858264","updated":"2023-10-19 08:19:06.000000000","message":"recheck timeouts","commit_id":"3d9a1148b0f25e11043780694b144d4e0bf4874a"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"810264bcd4e32339652883aa446fcc669a98fadf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e823722b_53c1c28d","in_reply_to":"7225edd6_30756964","updated":"2023-12-04 08:57:14.000000000","message":"Brian, what about removing the stateful test (test_create_list_update_show_delete_security_group)? Isn\u0027t it identical to this [1] test in tempest if I understand it correctly?\n\n[1] https://opendev.org/openstack/tempest/src/commit/8def25cbb5885e91899793f8575d3919816a0d12/tempest/api/network/test_security_groups.py#L83","commit_id":"3d9a1148b0f25e11043780694b144d4e0bf4874a"}],"neutron_tempest_plugin/api/test_security_groups.py":[{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"424789fd8319dbb462c327ba6f2825b9889aa9ec","unresolved":true,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @decorators.idempotent_id(\u00271fff0d57-bb6c-4528-9c1d-2326dce1c087\u0027)"},{"line_number":168,"context_line":"    def test_show_security_group_contains_all_rules(self):"},{"line_number":169,"context_line":"        self._test_show_security_group_contains_all_rules()"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    @decorators.idempotent_id(\u0027b5923b1a-4d33-44e1-af25-088dcb55b02b\u0027)"},{"line_number":172,"context_line":"    def test_list_security_group_rules_contains_all_rules(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"75d07ee0_c2be3380","side":"PARENT","line":169,"range":{"start_line":169,"start_character":13,"end_line":169,"end_character":57},"updated":"2023-09-26 07:57:36.000000000","message":"AttributeError: \u0027StatefulSecGroupTest\u0027 object has no attribute \u0027_test_show_security_group_contains_all_rules\u0027","commit_id":"370f71e9877fad13883413225bf25051c0c9c391"},{"author":{"_account_id":22873,"name":"Martin Kopec","email":"mkopec@redhat.com","username":"mkopec"},"change_message_id":"424789fd8319dbb462c327ba6f2825b9889aa9ec","unresolved":true,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @decorators.idempotent_id(\u0027ddbc0e4c-840f-44ab-8718-0b95b7c7b575\u0027)"},{"line_number":194,"context_line":"    def test_show_security_group_contains_all_rules(self):"},{"line_number":195,"context_line":"        self._test_show_security_group_contains_all_rules()"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"    @decorators.idempotent_id(\u0027cdf3a63a-08fe-4091-bab4-62180847990f\u0027)"},{"line_number":198,"context_line":"    def test_list_security_group_rules_contains_all_rules(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3b6bf3bf_694119ba","side":"PARENT","line":195,"range":{"start_line":195,"start_character":13,"end_line":195,"end_character":57},"updated":"2023-09-26 07:57:36.000000000","message":"AttributeError: \u0027StatefulSecGroupTest\u0027 object has no attribute \u0027_test_show_security_group_contains_all_rules\u0027","commit_id":"370f71e9877fad13883413225bf25051c0c9c391"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"d5cf927fe49b9c8077b0d314db014f20d8198c51","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class StatelessSecGroupTest(BaseSecGroupTest):"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    required_extensions \u003d [\u0027security-group\u0027, \u0027stateful-security-group\u0027]"},{"line_number":187,"context_line":"    stateless_sg \u003d True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @decorators.idempotent_id(\u00270214d58a-2177-47e1-af83-dcd45c024829\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c463aa8c_31d05cb5","side":"PARENT","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":17},"updated":"2023-10-23 08:19:11.000000000","message":"Maybe it\u0027s not important. It just caught my attention. Can we delete these tests? They seem to be testing the security groups when stateful-security-group extension is enabled. I was able to find only these corresponding tests in tempest [1] and they probably test the security groups only when \u0027security-group\u0027 extension is enabled.\n\n[1] https://opendev.org/openstack/tempest/src/commit/2ce81e5185acc832da41709bc61379c66fe63adc/tempest/api/network/test_security_groups.py","commit_id":"370f71e9877fad13883413225bf25051c0c9c391"},{"author":{"_account_id":30674,"name":"Lukas Piwowarski","email":"lpiwowar@redhat.com","username":"lukas-piwowarski"},"change_message_id":"9093f9d9e3a8b148fc3a6d1568cf24c8335cf680","unresolved":true,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class StatelessSecGroupTest(BaseSecGroupTest):"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    required_extensions \u003d [\u0027security-group\u0027, \u0027stateful-security-group\u0027]"},{"line_number":187,"context_line":"    stateless_sg \u003d True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @decorators.idempotent_id(\u00270214d58a-2177-47e1-af83-dcd45c024829\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f9d9078_46e2e145","side":"PARENT","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":17},"in_reply_to":"381ab242_f9c00e7f","updated":"2023-11-16 08:21:09.000000000","message":"This happens sometimes:). There seems to be a pep8 issue in the new patch btw.","commit_id":"370f71e9877fad13883413225bf25051c0c9c391"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"16048ba6f93754a41e7e23c2dccf6a43ce6547f6","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class StatelessSecGroupTest(BaseSecGroupTest):"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    required_extensions \u003d [\u0027security-group\u0027, \u0027stateful-security-group\u0027]"},{"line_number":187,"context_line":"    stateless_sg \u003d True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @decorators.idempotent_id(\u00270214d58a-2177-47e1-af83-dcd45c024829\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"959d8dba_5c3b6777","side":"PARENT","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":17},"in_reply_to":"3f9d9078_46e2e145","updated":"2023-11-20 13:21:17.000000000","message":"Done","commit_id":"370f71e9877fad13883413225bf25051c0c9c391"},{"author":{"_account_id":35229,"name":"Jakub Skunda","display_name":"jskunda","email":"jskunda@redhat.com","username":"jskunda"},"change_message_id":"bbaa2d9e72bf9063a5447225bc822ced6b5ec977","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"class StatelessSecGroupTest(BaseSecGroupTest):"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    required_extensions \u003d [\u0027security-group\u0027, \u0027stateful-security-group\u0027]"},{"line_number":187,"context_line":"    stateless_sg \u003d True"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    @decorators.idempotent_id(\u00270214d58a-2177-47e1-af83-dcd45c024829\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"381ab242_f9c00e7f","side":"PARENT","line":186,"range":{"start_line":186,"start_character":0,"end_line":186,"end_character":17},"in_reply_to":"c463aa8c_31d05cb5","updated":"2023-11-15 16:42:48.000000000","message":"Yeah you are right. I accidentaly created new review while I was fixing this :( https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/901051","commit_id":"370f71e9877fad13883413225bf25051c0c9c391"}]}