)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"9e8d5e0b97e8d0c357dc75272572155ea708874d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"04708230_4b61924e","updated":"2023-10-20 16:39:38.000000000","message":"recheck","commit_id":"3fda0657f8f4af2b31ea34df24e2d36ef11d77b2"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"1ac665c854a64b34df1aa3446e3cfb193e20c034","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8f000fb1_9e085ec2","updated":"2023-10-20 19:16:59.000000000","message":"recheck","commit_id":"b26c900f2f6ec1b3ac7aed8ddcd293154774f811"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"cfc672d2fc742bd4c04158e68ea9760c3e393f9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dd39b8a9_1051ccc3","updated":"2023-10-20 23:09:31.000000000","message":"recheck logs not recorded","commit_id":"b26c900f2f6ec1b3ac7aed8ddcd293154774f811"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"4cad0306b7891c3ef2ad1e5984eaff446f5c9524","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"de6840eb_2c3a6bb8","updated":"2023-10-21 17:37:41.000000000","message":"recheck dependent change updated","commit_id":"f0b8825386b82625b7761c19f663db2f22217e91"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"7c3f41e5b8c7cfd9687b2d345f8fd3c03e1afefd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"d304c07f_d3bd7647","updated":"2023-10-22 12:29:42.000000000","message":"recheck non-related intermittent failure in neutron-tempest-plugin-sfc-2023-1","commit_id":"d1b85052a1f125117f6de96a9acb82d5c81d3650"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"b71eb7aeb4919f19dda32e10a2043f0ff23729fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4a3a1b6b_5149837c","updated":"2023-12-04 15:51:37.000000000","message":"recheck on rebased dependency","commit_id":"6e06c5483ebe7852f297bbb514fe43797c324662"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"58920f4888a84e61b19b3a0d70da90dc4a164449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2a7d0315_a67764f8","updated":"2023-12-05 22:18:41.000000000","message":"I think maybe you should rebase parent to master, there might have been a doc fix there, I could not get \u0027tox -e docs\u0027 to fail locally :(","commit_id":"4897cd024eb55063d137803dbc196aca0f9259cd"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"5d5320f5e698f7b5c4d3920c547584d95f918592","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5457676b_a054ea60","updated":"2023-12-05 09:31:25.000000000","message":"I\u0027m struggling a bit with these sphinx docstring errors, after fixing the warning introduced by me other unrelated to this change warnings crop up. Has something changed elsewhere to start this check?:\n```\nWarning, treated as error:\n/home/zuul/src/opendev.org/openstack/neutron-tempest-plugin/neutron_tempest_plugin/api/base.py:docstring of neutron_tempest_plugin.api.base.BaseNetworkTest.create_conntrack_helper:7:Field list ends without a blank line; unexpected unindent.\ndocs: 29539 C exit 2 (24.74 seconds) /home/zuul/src/opendev.org/openstack/neutron-tempest-plugin\u003e sphinx-build -W -b html doc/source doc/build/html pid\u003d2510 [tox/execute/api.py:279]\n.pkg: 29540 W _exit\u003e python /home/zuul/.local/tox/lib/python3.10/site-packages/pyproject_api/_backend.py True setuptools.build_meta __legacy__ [tox/tox_env/api.py:427]\n```","commit_id":"4897cd024eb55063d137803dbc196aca0f9259cd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3eb8affe5e6cbc6232e2db0ff5e8630b241b4e62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"4ffbf0da_ac49208a","updated":"2023-12-05 22:27:29.000000000","message":"So after the rebase it now fails locally for me, odd.","commit_id":"397ea3567dd2b15607e6e110876b518a80b1e812"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2fc0d1e4d4881a6db619831771abaaac29376cd3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"14c8b915_1a771a5f","updated":"2023-12-07 16:10:32.000000000","message":"Tests look good","commit_id":"bb8b906716e25e2670ff68f04ebdab8a150adab9"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"4fa2d91773082e6b7caf63c0875e281eb5979372","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"0d695057_635a2f3d","updated":"2023-12-07 14:02:29.000000000","message":"recheck unrelated internet download issue","commit_id":"bb8b906716e25e2670ff68f04ebdab8a150adab9"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"6f302f42e900779b0bd3d889865e5a1e24e656c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"d1831246_73620c26","updated":"2023-12-08 17:55:50.000000000","message":"recheck intermittent internet connection issue","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ee1ca33920df36a459ab23e111b355667d0664a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"b3de65a7_821d3f1b","updated":"2023-12-09 07:01:17.000000000","message":"recheck intermittent issue downloading images from internet","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"6a74d5b4117262bbcb5742ef49b46ec0aeaa7f1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"d750c26e_bc6f8906","updated":"2023-12-11 13:54:34.000000000","message":"recheck intermittent issue downloading images from internet","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"45c836397588a59a9842dd9f5d45d1aa4ed51505","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"bfa0f564_27c1b5ff","updated":"2023-12-15 09:35:29.000000000","message":"recheck neutron_tempest_plugin.scenario.test_qos.QoSTest.test_attach_previously_used_port_to_new_instance","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ee6767de5abb156588eed7c2d11a261e7c2033b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"6b6c8048_7d6ce8ec","updated":"2024-02-01 10:25:08.000000000","message":"recheck the dependency has been modified after manual rebase, let\u0027s reconfirm it works.","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"ac32df17e16e8d4a66ea53102dd8b5cf90a60cc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"122d3461_5a4a708b","updated":"2024-01-31 09:58:27.000000000","message":"recheck to see if the new tests really triggered","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"660a7c55edb7c479fcc7fda43ee9ab517c0299f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"21c50984_f9cbe8b3","updated":"2023-12-15 07:04:18.000000000","message":"recheck unrelated failure in neutron-tempest-plugin-linuxbridge-2023-1 and CI POST_FAILUREs","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"7766cb5ffc635585e24e53ba2881db6eca63f5cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"fb2c63ea_99667f63","updated":"2023-12-08 08:07:03.000000000","message":"recheck unrelated failure in openvswitch-iptables_hybrid job and a couple of intermittent internet download issues in other jobs","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"e06faff4d2aef336d54d8b164bdf7d3f1a0477d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"85d15832_8dc07717","updated":"2024-02-01 22:21:19.000000000","message":"recheck unrelated intermittent failure in the neutron-tempest-plugin-openvswitch job","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ffd35ba1b51bdb97d4be4a2156ad9ce6f0d00751","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":22,"id":"6c4362cf_c62877fb","updated":"2024-02-28 09:10:33.000000000","message":"recheck failure in test unrelated to this change: `neutron_tempest_plugin.scenario.test_security_groups.StatefulNetworkSecGroupTest.test_multiple_ports_portrange_remote`","commit_id":"200ffd8878be2308017e688b722e97db98e51200"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1094d697b34ba4801ab52013ab5b50608fb0e4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"0cafa372_45c0c8fd","updated":"2024-05-10 15:02:12.000000000","message":"recheck\nLet\u0027s have test logs, seems zuul removed the last runs\u0027","commit_id":"b01ef8de137cbae359ceb44659cfc98ffe852cd6"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"497db47be3a444274a96e099d4a215505ce0804a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":25,"id":"28d7b072_401529c9","updated":"2024-03-26 15:03:54.000000000","message":"recheck unrelated failure in `neutron_tempest_plugin.scenario.test_security_groups.StatelessNetworkSecGroupIPv4Test.test_overlapping_sec_grp_rules`","commit_id":"b01ef8de137cbae359ceb44659cfc98ffe852cd6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2dedf54a417f7275e6971dd3e4df2cdc6cc3685a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"bce16f01_c9fd2915","updated":"2024-05-10 15:27:18.000000000","message":"Rebased to fix merge conflict","commit_id":"7182d273eec424134b2b060bfb7a5b5878a31da3"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3fb2ba0313162756333cf91bd636b35130c2fba6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"76830e60_10e44113","updated":"2024-05-10 18:25:40.000000000","message":"We have to first settle the zed issues: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/917696","commit_id":"7182d273eec424134b2b060bfb7a5b5878a31da3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"334e3b8848f071a724a65e1b3fbc950ff35a38e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"d9bc55e2_7ce9f6a8","updated":"2024-05-29 03:08:28.000000000","message":"recheck kick gate jobs","commit_id":"7182d273eec424134b2b060bfb7a5b5878a31da3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1620ee41353840b8a94092610a998dd33f1ce5e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"45a14ab4_893fb5dd","updated":"2024-05-21 15:45:45.000000000","message":"recheck zed jobs are not in gate anymore","commit_id":"7182d273eec424134b2b060bfb7a5b5878a31da3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1454a9dcc428fbf553caa9d017c9f64c388e03c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"53cd30d4_1031eec1","updated":"2024-06-12 01:16:46.000000000","message":"We will need to look at disabling the sfc job as it\u0027s failing too much","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b22baf672956ee6b3214318715c1de047bbe262e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ff8f578e_1d0ea307","updated":"2024-05-29 17:10:14.000000000","message":"recheck gate fix merged","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"346e08369384b6e2944466c6698d5ac6f4a5c575","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"b55ce2a0_2be0ee02","updated":"2024-06-03 18:36:00.000000000","message":"recheck gate should be fixed","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"832d81257c07b056bfab6b9909ef3c162b93cd87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"19a6c2cf_300016eb","updated":"2024-06-11 18:48:19.000000000","message":"recheck neutron-tempest-plugin-sfc unrelated failure","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b875954b2460a00d0d98d54451ee48d9717ed777","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5ddffe61_1d096573","updated":"2024-06-11 22:03:47.000000000","message":"recheck neutron-tempest-plugin-sfc unrelated failure","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d5f8ffbd55c6bd91a15693fe4bbb7925ffa89800","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"bbbd6268_28636d2c","updated":"2024-06-13 20:15:51.000000000","message":"recheck sfc non-voting patch merged","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"49d10e05fc4acec59915e1474405590e1132fa5f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ad5b57ef_07548b3b","updated":"2024-05-30 14:53:00.000000000","message":"recheck unrelated complete test failures","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"746a72bd263d02737b0d467c64b83359fc7309ac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"58d0a04f_6d6b5189","updated":"2024-06-10 14:59:50.000000000","message":"recheck unrelated sfc failure","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"20a28fadcd86f5665bb2a805ec929b3a57aaa70b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"b7f1a9db_519526ae","updated":"2024-05-30 18:45:12.000000000","message":"recheck unrelated sfc test failure","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e502b716da43cfbb7fa18ee762dd721411ddbcb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"55b7b404_7a085a45","updated":"2024-06-14 13:58:00.000000000","message":"recheck unrelated test failures","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"8bc8f391e8e00e5b9411be7b1fefdefc064ba4f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"71d4ede6_5a088f9f","updated":"2024-06-10 20:39:06.000000000","message":"recheck unrelated test failures","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"de3d3f8fbc2f3b3458e3fabc0471cb8bf7b3640d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"71acf2f2_85280f88","updated":"2024-06-14 19:34:53.000000000","message":"recheck unrelated test timeout","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"274e602575c139d7042854de78b5009565b62ae6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"3cb585e7_fe30fb5d","updated":"2024-05-29 21:10:57.000000000","message":"recheck unrelated timeout","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"972659467e082bda5db8dfa9e54b2e00e334a608","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"ecdf312c_b5495df2","updated":"2024-06-11 13:41:49.000000000","message":"recheck unstable jobs","commit_id":"1bb8e62a3a9e985f80a187a44310db5b734f8bf8"}],"doc/source/conf.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"58920f4888a84e61b19b3a0d70da90dc4a164449","unresolved":true,"context_lines":[{"line_number":79,"context_line":"#intersphinx_mapping \u003d {\u0027http://docs.python.org/\u0027: None}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def autodoc_skip_member(app, what, name, obj, skip, options):"},{"line_number":82,"context_line":"    print(name)"},{"line_number":83,"context_line":"    if (name \u003d\u003d \u0027neutron_tempest_plugin.scenario.\u0027"},{"line_number":84,"context_line":"                \u0027test_multiple_gws.NetworkMultipleGWTest\u0027):"},{"line_number":85,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":14,"id":"5fa86d08_443fe7b5","line":82,"updated":"2023-12-05 22:18:41.000000000","message":"debug?","commit_id":"4897cd024eb55063d137803dbc196aca0f9259cd"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"1128518687b9132e75ef27f1649f966d12bb05b2","unresolved":false,"context_lines":[{"line_number":79,"context_line":"#intersphinx_mapping \u003d {\u0027http://docs.python.org/\u0027: None}"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def autodoc_skip_member(app, what, name, obj, skip, options):"},{"line_number":82,"context_line":"    print(name)"},{"line_number":83,"context_line":"    if (name \u003d\u003d \u0027neutron_tempest_plugin.scenario.\u0027"},{"line_number":84,"context_line":"                \u0027test_multiple_gws.NetworkMultipleGWTest\u0027):"},{"line_number":85,"context_line":"        return True"}],"source_content_type":"text/x-python","patch_set":14,"id":"e2bc2d5b_2ec50719","line":82,"in_reply_to":"5fa86d08_443fe7b5","updated":"2023-12-06 07:46:04.000000000","message":"Done","commit_id":"4897cd024eb55063d137803dbc196aca0f9259cd"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2da4fd374f2ed1efa8ebc372b5e0f1e00714be73","unresolved":true,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":"import sys"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def autodoc_skip_member_handler(app, what, name, obj, skip, options):"},{"line_number":19,"context_line":"    return skip or (what \u003d\u003d \"class\" and not name.startswith(\"test\"))"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3e97d4c1_77a1d878","line":18,"updated":"2023-12-05 23:42:04.000000000","message":"So it seems you were defining a second skip method, if you remove the below and add this here:\n\n    if (what \u003d\u003d \u0027module\u0027 and name \u003d\u003d \u0027NetworkMultipleGWTest\u0027):\n        return True\n\nit builds the docs. Can probably make it nice and pretty, but that\u0027s up to you :)","commit_id":"397ea3567dd2b15607e6e110876b518a80b1e812"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"ce80e24cb0e01ae34c1650fd074dc17ffe36a9c6","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import os"},{"line_number":16,"context_line":"import sys"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def autodoc_skip_member_handler(app, what, name, obj, skip, options):"},{"line_number":19,"context_line":"    return skip or (what \u003d\u003d \"class\" and not name.startswith(\"test\"))"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":15,"id":"d05e7402_de40481b","line":18,"in_reply_to":"3e97d4c1_77a1d878","updated":"2023-12-06 07:12:48.000000000","message":"Thanks! AFAICT sphinx does not like my ASCII art, so think I need the skip rule regardless of how its formatted.","commit_id":"397ea3567dd2b15607e6e110876b518a80b1e812"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c7e4a388dd7865d9259cb4b2b78e629389ccb7dc","unresolved":true,"context_lines":[{"line_number":88,"context_line":"def autodoc_skip_member(app, what, name, obj, skip, options):"},{"line_number":89,"context_line":"    # NOTE(fnordahl): Sphinx does not like the ASCII art in the docstring."},{"line_number":90,"context_line":"    if (what \u003d\u003d \u0027module\u0027 and name \u003d\u003d \u0027NetworkMultipleGWTest\u0027):"},{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":"    return None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a9b778f_e7bb7c62","line":91,"updated":"2023-12-06 15:26:42.000000000","message":"This should be in the one on L19, i don\u0027t think we need two methods.","commit_id":"783683d842cb072e0cab3f863c12339775b2b5b6"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"0017ecf473afdf31fa05bf7ce1f33a00c13fe611","unresolved":true,"context_lines":[{"line_number":88,"context_line":"def autodoc_skip_member(app, what, name, obj, skip, options):"},{"line_number":89,"context_line":"    # NOTE(fnordahl): Sphinx does not like the ASCII art in the docstring."},{"line_number":90,"context_line":"    if (what \u003d\u003d \u0027module\u0027 and name \u003d\u003d \u0027NetworkMultipleGWTest\u0027):"},{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":"    return None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":17,"id":"63e32dbd_22ab1d7b","line":91,"in_reply_to":"3a9b778f_e7bb7c62","updated":"2023-12-07 05:55:58.000000000","message":"Ha! That explains why all these other lint errors crept out when adding it ;-)\n\nSo do we want to keep https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/902747 or should I just throw it away?","commit_id":"783683d842cb072e0cab3f863c12339775b2b5b6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2fc0d1e4d4881a6db619831771abaaac29376cd3","unresolved":true,"context_lines":[{"line_number":88,"context_line":"def autodoc_skip_member(app, what, name, obj, skip, options):"},{"line_number":89,"context_line":"    # NOTE(fnordahl): Sphinx does not like the ASCII art in the docstring."},{"line_number":90,"context_line":"    if (what \u003d\u003d \u0027module\u0027 and name \u003d\u003d \u0027NetworkMultipleGWTest\u0027):"},{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":"    return None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":17,"id":"a95c6383_f2d23326","line":91,"in_reply_to":"63e32dbd_22ab1d7b","updated":"2023-12-07 16:10:32.000000000","message":"I don\u0027t think we need the other one, wish we could just disable the docstring checking as this is just a test repo.","commit_id":"783683d842cb072e0cab3f863c12339775b2b5b6"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"1ec0078acffa95934e3ed8f14f2ecc1de76585c0","unresolved":false,"context_lines":[{"line_number":88,"context_line":"def autodoc_skip_member(app, what, name, obj, skip, options):"},{"line_number":89,"context_line":"    # NOTE(fnordahl): Sphinx does not like the ASCII art in the docstring."},{"line_number":90,"context_line":"    if (what \u003d\u003d \u0027module\u0027 and name \u003d\u003d \u0027NetworkMultipleGWTest\u0027):"},{"line_number":91,"context_line":"        return True"},{"line_number":92,"context_line":"    return None"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"def setup(app):"}],"source_content_type":"text/x-python","patch_set":17,"id":"9bf8ca70_431ec093","line":91,"in_reply_to":"a95c6383_f2d23326","updated":"2023-12-07 17:54:14.000000000","message":"Ack, yes, I was thinking several times why do we care, but you know, sometimes it is down to whatever make the CI happy ;)\n\nWill rebase and get it out of the series.","commit_id":"783683d842cb072e0cab3f863c12339775b2b5b6"}],"neutron_tempest_plugin/api/base.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"58920f4888a84e61b19b3a0d70da90dc4a164449","unresolved":true,"context_lines":[{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"        :param router_id: The ID of the Neutron router associated to the"},{"line_number":1102,"context_line":"        conntrack helper."},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        :param helper: The conntrack helper module alias"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        :param protocol: The conntrack helper IP protocol used in the conntrack"}],"source_content_type":"text/x-python","patch_set":14,"id":"ebcede12_4c02a0b6","line":1103,"updated":"2023-12-05 22:18:41.000000000","message":"So it\u0027s complaining about something right around here? strange, i don\u0027t see anything obvious","commit_id":"4897cd024eb55063d137803dbc196aca0f9259cd"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"deb0402ad138a13217c535d9e4f7f577d9f2b30e","unresolved":false,"context_lines":[{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"        :param router_id: The ID of the Neutron router associated to the"},{"line_number":1102,"context_line":"        conntrack helper."},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        :param helper: The conntrack helper module alias"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        :param protocol: The conntrack helper IP protocol used in the conntrack"}],"source_content_type":"text/x-python","patch_set":14,"id":"519d926b_0cc59028","line":1103,"in_reply_to":"409194ed_9de3692b","updated":"2023-12-06 07:58:32.000000000","message":"I wonder if there is some setting to only impose the linting when files are changed or something like that, because it is a bit unpredictable when and when not the warning appears.\n\nThe doc jobs of the change referenced above just passed, so I\u0027ll make it a part of this series and we should be able to make it pass.","commit_id":"4897cd024eb55063d137803dbc196aca0f9259cd"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"1128518687b9132e75ef27f1649f966d12bb05b2","unresolved":true,"context_lines":[{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"        :param router_id: The ID of the Neutron router associated to the"},{"line_number":1102,"context_line":"        conntrack helper."},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        :param helper: The conntrack helper module alias"},{"line_number":1105,"context_line":""},{"line_number":1106,"context_line":"        :param protocol: The conntrack helper IP protocol used in the conntrack"}],"source_content_type":"text/x-python","patch_set":14,"id":"409194ed_9de3692b","line":1103,"in_reply_to":"ebcede12_4c02a0b6","updated":"2023-12-06 07:46:04.000000000","message":"It wants the subsequent line of the `param` description to be indented. It\u0027s also only complaining about one item at a time, which is not particularly helpful.\n\nI made an attempt at fixing up lint here: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/902747 but if we follow that trail it will create a lot of noise which could be problematic for backports.\n\nSo not sure if that is a path to pursue or if we should figure out what changed in sphinx or its configuration and revert that?","commit_id":"4897cd024eb55063d137803dbc196aca0f9259cd"}],"neutron_tempest_plugin/scenario/test_multiple_gws.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3fe3d82082d1ffe932b782aad26199500af2aed0","unresolved":true,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        ext_alias \u003d \u0027external-gateway-multihoming\u0027"},{"line_number":356,"context_line":"        try:"},{"line_number":357,"context_line":"            cls.client.get_extension(ext_alias)"},{"line_number":358,"context_line":"        except lib_exc.NotFound:"},{"line_number":359,"context_line":"            raise cls.skipException(f\u0027{ext_alias} extension not available.\u0027)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"300945a1_6e4698de","line":357,"updated":"2024-02-02 05:59:15.000000000","message":"For scenario jobs we enable extensions for tests in job itself, like for ovn specific:- https://github.com/openstack/neutron-tempest-plugin/blob/master/zuul.d/master_jobs.yaml#L598-L599\nand then skip based on check like https://github.com/openstack/neutron-tempest-plugin/blob/887d41532da1345a91d2e0bcc8a33a52f0b971b2/neutron_tempest_plugin/scenario/test_vlan_transparency.py#L37 or https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/scenario/test_floatingip.py#L51","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"3b5d21466628ea863015561e7a7a691f7ab6ae6a","unresolved":true,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        ext_alias \u003d \u0027external-gateway-multihoming\u0027"},{"line_number":356,"context_line":"        try:"},{"line_number":357,"context_line":"            cls.client.get_extension(ext_alias)"},{"line_number":358,"context_line":"        except lib_exc.NotFound:"},{"line_number":359,"context_line":"            raise cls.skipException(f\u0027{ext_alias} extension not available.\u0027)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"bbb0d9a3_50d90c47","line":357,"in_reply_to":"300945a1_6e4698de","updated":"2024-02-02 06:46:33.000000000","message":"I did take a stab at that approach at one point (ref [0][1]), however this is not feasible for this feature as it changes core functionality, and it cannot be toggled once a driver implementing it has been loaded.\n\nThere are multiple other extensions that operate in the same way and afair the extension is more to expose to the end user through the API whether the functionality is available in the version of Neutron they are speaking to?\n\nConsequently, when attempting to use the standard `required_extensions` check, the test would be attempted executed even for configurations where it would not work, which is why I ended up with this solution.\n\nWDYT?\n\n0: https://review.opendev.org/c/openstack/neutron/+/897919\n1: https://review.opendev.org/c/openstack/neutron/+/897822","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"92102078a1eda0effcedc90df327e5fae01bde98","unresolved":true,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        ext_alias \u003d \u0027external-gateway-multihoming\u0027"},{"line_number":356,"context_line":"        try:"},{"line_number":357,"context_line":"            cls.client.get_extension(ext_alias)"},{"line_number":358,"context_line":"        except lib_exc.NotFound:"},{"line_number":359,"context_line":"            raise cls.skipException(f\u0027{ext_alias} extension not available.\u0027)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"a60f9ae0_b80585f9","line":357,"in_reply_to":"7b2ad8d9_ca741d97","updated":"2024-02-06 14:39:04.000000000","message":"It works as expected in the other patch so those changes can be included here unless and until you see some issue:-\nhttps://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_976/907553/2/check/neutron-tempest-plugin-ovn/97659a4/testr_results.html\nhttps://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_31d/907553/2/check/neutron-tempest-plugin-openvswitch/31d4798/testr_results.html","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"66a96beec3e0ac0e950f5812d28878cdb9c2eae5","unresolved":true,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        ext_alias \u003d \u0027external-gateway-multihoming\u0027"},{"line_number":356,"context_line":"        try:"},{"line_number":357,"context_line":"            cls.client.get_extension(ext_alias)"},{"line_number":358,"context_line":"        except lib_exc.NotFound:"},{"line_number":359,"context_line":"            raise cls.skipException(f\u0027{ext_alias} extension not available.\u0027)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7b2ad8d9_ca741d97","line":357,"in_reply_to":"953b925e_3fe45029","updated":"2024-02-02 14:11:55.000000000","message":"i think those devstack changes not needed, pushed https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/907553 with what i think would work consistantly like other tests. If it doesn\u0027t work then i am missing something and you can ignore it.","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"eb54b788b79b88f4eb842bc8261c5b2a6baf2347","unresolved":false,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        ext_alias \u003d \u0027external-gateway-multihoming\u0027"},{"line_number":356,"context_line":"        try:"},{"line_number":357,"context_line":"            cls.client.get_extension(ext_alias)"},{"line_number":358,"context_line":"        except lib_exc.NotFound:"},{"line_number":359,"context_line":"            raise cls.skipException(f\u0027{ext_alias} extension not available.\u0027)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"3c70e4d2_88d30e5b","line":357,"in_reply_to":"a60f9ae0_b80585f9","updated":"2024-02-28 06:50:21.000000000","message":"It does indeed appear to work, I guess I conflated this with something else I struggled with while developing this series.\n\nI\u0027ll incorporate your proposal into this patch, thanks!","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"8d53b232ca21394b7b0dee80eea050e9e9402d85","unresolved":true,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        ext_alias \u003d \u0027external-gateway-multihoming\u0027"},{"line_number":356,"context_line":"        try:"},{"line_number":357,"context_line":"            cls.client.get_extension(ext_alias)"},{"line_number":358,"context_line":"        except lib_exc.NotFound:"},{"line_number":359,"context_line":"            raise cls.skipException(f\u0027{ext_alias} extension not available.\u0027)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"953b925e_3fe45029","line":357,"in_reply_to":"adc2057f_87244f87","updated":"2024-02-02 13:51:07.000000000","message":"I honestly do not remember the details, but the multihoming extension is not comparable to the `vlan-transparent` extension. It is not optional and it cannot be toggled through Neutron configuration.\n\nIf we can make the devstack neutron api extension path work, it would be scaffolding just for the purpose of populating tempest configuration to allow the default required_extension code to work, without actually making any changes to the Neutron configuration, which does appear a bit unnecessary?\n\nI\u0027ll revisit in any case so we can make an informed decision.","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"96717c444d1941f83ccd0d9ce6d41460770b4c6d","unresolved":true,"context_lines":[{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        ext_alias \u003d \u0027external-gateway-multihoming\u0027"},{"line_number":356,"context_line":"        try:"},{"line_number":357,"context_line":"            cls.client.get_extension(ext_alias)"},{"line_number":358,"context_line":"        except lib_exc.NotFound:"},{"line_number":359,"context_line":"            raise cls.skipException(f\u0027{ext_alias} extension not available.\u0027)"},{"line_number":360,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"adc2057f_87244f87","line":357,"in_reply_to":"bbb0d9a3_50d90c47","updated":"2024-02-02 13:28:55.000000000","message":"Can you give more context for configurations where it would not work, you mean ovs/linuxbridge here, or something else?\n\nSo what i meant was to add this extension to just ovn job like, for other jobs/drivers the tests would skip as extension not enabled.\nhttps://review.opendev.org/c/openstack/neutron-tempest-plugin/+/898810/21/zuul.d/master_jobs.yaml#599","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"f1c1ebb453e192f492f7adac8994011fc169984e","unresolved":true,"context_lines":[{"line_number":372,"context_line":"        cls.ext_networks \u003d []"},{"line_number":373,"context_line":"        for n in range(0, 2):"},{"line_number":374,"context_line":"            vid \u003d 4040 + n"},{"line_number":375,"context_line":"            ext_network \u003d cls.create_network("},{"line_number":376,"context_line":"                network_name\u003df\u0027public-vlan-{vid}\u0027,"},{"line_number":377,"context_line":"                client\u003dcls.admin_client,"},{"line_number":378,"context_line":"                external\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":22,"id":"2019ee8d_7097dcbb","line":375,"updated":"2024-02-28 09:42:48.000000000","message":"While testing with high concurrency this failed with `tempest.lib.exceptions.Conflict`: https://pastebin.ubuntu.com/p/Q89WXH85cB/\n\nI\u0027ll investigate whether we can use https://github.com/openstack/neutron-tempest-plugin/blob/9c55bfc36400c16013a997304173114ed6eb55cc/neutron_tempest_plugin/api/base.py#L1351-L1372, failing that I\u0027ll add similar handling here.","commit_id":"200ffd8878be2308017e688b722e97db98e51200"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"7831855c2ea308add935354dc1918e8023e9a1d9","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        cls.ext_networks \u003d []"},{"line_number":373,"context_line":"        for n in range(0, 2):"},{"line_number":374,"context_line":"            vid \u003d 4040 + n"},{"line_number":375,"context_line":"            ext_network \u003d cls.create_network("},{"line_number":376,"context_line":"                network_name\u003df\u0027public-vlan-{vid}\u0027,"},{"line_number":377,"context_line":"                client\u003dcls.admin_client,"},{"line_number":378,"context_line":"                external\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":22,"id":"cda86f9f_e2227a8f","line":375,"in_reply_to":"2019ee8d_7097dcbb","updated":"2024-02-28 10:02:48.000000000","message":"Done","commit_id":"200ffd8878be2308017e688b722e97db98e51200"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d1094d697b34ba4801ab52013ab5b50608fb0e4e","unresolved":true,"context_lines":[{"line_number":29,"context_line":"from neutron_lib import constants as const"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from oslo_log import log"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"from os_ken.tests.integrated.common import docker_base as ctn_base"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":36,"context_line":"from tempest.lib import decorators"}],"source_content_type":"text/x-python","patch_set":25,"id":"41196c5d_608c8a16","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":66},"updated":"2024-05-10 15:02:12.000000000","message":"good to learn about this module in os-ken","commit_id":"b01ef8de137cbae359ceb44659cfc98ffe852cd6"}],"neutron_tempest_plugin/services/network/json/network_client.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"3fe3d82082d1ffe932b782aad26199500af2aed0","unresolved":true,"context_lines":[{"line_number":1259,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":1260,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"    def get_network(self, network_id):"},{"line_number":1263,"context_line":"        uri \u003d \u0027%s/networks/%s\u0027 % (self.uri_prefix, network_id)"},{"line_number":1264,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":1265,"context_line":"        body \u003d self.deserialize_list(body)"},{"line_number":1266,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1267,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":1270,"context_line":"        uri \u003d \u0027%s/subnets/%s\u0027 % (self.uri_prefix, subnet_id)"},{"line_number":1271,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":1272,"context_line":"        body \u003d self.deserialize_list(body)"},{"line_number":1273,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1274,"context_line":"        return service_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":19,"id":"b05e64a0_ecaf0436","line":1274,"range":{"start_line":1262,"start_character":0,"end_line":1274,"end_character":54},"updated":"2024-02-02 05:59:15.000000000","message":"these seems duplicating show_network and show_subnet, can just reuse those instead.","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"caf45b1cd57d3f37de853e4ad541f7cea8a6da5f","unresolved":false,"context_lines":[{"line_number":1259,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":1260,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"    def get_network(self, network_id):"},{"line_number":1263,"context_line":"        uri \u003d \u0027%s/networks/%s\u0027 % (self.uri_prefix, network_id)"},{"line_number":1264,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":1265,"context_line":"        body \u003d self.deserialize_list(body)"},{"line_number":1266,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1267,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":1270,"context_line":"        uri \u003d \u0027%s/subnets/%s\u0027 % (self.uri_prefix, subnet_id)"},{"line_number":1271,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":1272,"context_line":"        body \u003d self.deserialize_list(body)"},{"line_number":1273,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1274,"context_line":"        return service_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":19,"id":"e532de1c_21d6d49c","line":1274,"range":{"start_line":1262,"start_character":0,"end_line":1274,"end_character":54},"in_reply_to":"6a142fc7_e155538b","updated":"2024-02-02 06:57:52.000000000","message":"Done","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"3b5d21466628ea863015561e7a7a691f7ab6ae6a","unresolved":true,"context_lines":[{"line_number":1259,"context_line":"        self.expected_success(204, resp.status)"},{"line_number":1260,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":1261,"context_line":""},{"line_number":1262,"context_line":"    def get_network(self, network_id):"},{"line_number":1263,"context_line":"        uri \u003d \u0027%s/networks/%s\u0027 % (self.uri_prefix, network_id)"},{"line_number":1264,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":1265,"context_line":"        body \u003d self.deserialize_list(body)"},{"line_number":1266,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1267,"context_line":"        return service_client.ResponseBody(resp, body)"},{"line_number":1268,"context_line":""},{"line_number":1269,"context_line":"    def get_subnet(self, subnet_id):"},{"line_number":1270,"context_line":"        uri \u003d \u0027%s/subnets/%s\u0027 % (self.uri_prefix, subnet_id)"},{"line_number":1271,"context_line":"        resp, body \u003d self.get(uri)"},{"line_number":1272,"context_line":"        body \u003d self.deserialize_list(body)"},{"line_number":1273,"context_line":"        self.expected_success(200, resp.status)"},{"line_number":1274,"context_line":"        return service_client.ResponseBody(resp, body)"}],"source_content_type":"text/x-python","patch_set":19,"id":"6a142fc7_e155538b","line":1274,"range":{"start_line":1262,"start_character":0,"end_line":1274,"end_character":54},"in_reply_to":"b05e64a0_ecaf0436","updated":"2024-02-02 06:46:33.000000000","message":"Thanks, I\u0027ll look into those!","commit_id":"69b99683d824b6021ac3175b92c25a2983af01c5"}],"zuul.d/master_jobs.yaml":[{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"cff4aeab1f4efd50e55252e43bac6ac0c85efbee","unresolved":true,"context_lines":[{"line_number":663,"context_line":"            ml2:"},{"line_number":664,"context_line":"              type_drivers: local,flat,vlan,geneve"},{"line_number":665,"context_line":"            ml2_type_vlan:"},{"line_number":666,"context_line":"              network_vlan_ranges: public"},{"line_number":667,"context_line":"        test-config:"},{"line_number":668,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":669,"context_line":"            network-feature-enabled:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"a172c0b9_bfd900d3","line":666,"updated":"2023-10-21 08:21:12.000000000","message":"This change overshadowes a parent configuration for `foo:1-10` causing other tests to fail.\n\nI\u0027ll update to repeat that config here as I\u0027d want to avoid making changes to the test runner OVN bridge mapping configuration.","commit_id":"599aac02b07df42f6355f010f08629c0bdf2bb54"},{"author":{"_account_id":13686,"name":"Frode Nordahl","email":"fnordahl@ubuntu.com","username":"fnordahl"},"change_message_id":"b21932eb81c28c4d8a41f45d70946f771f89e03a","unresolved":false,"context_lines":[{"line_number":663,"context_line":"            ml2:"},{"line_number":664,"context_line":"              type_drivers: local,flat,vlan,geneve"},{"line_number":665,"context_line":"            ml2_type_vlan:"},{"line_number":666,"context_line":"              network_vlan_ranges: public"},{"line_number":667,"context_line":"        test-config:"},{"line_number":668,"context_line":"          $TEMPEST_CONFIG:"},{"line_number":669,"context_line":"            network-feature-enabled:"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"610e82d2_b54e6783","line":666,"in_reply_to":"a172c0b9_bfd900d3","updated":"2023-10-21 13:40:07.000000000","message":"Done","commit_id":"599aac02b07df42f6355f010f08629c0bdf2bb54"}]}