)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"943dd420090042b131daf05f783b2284b35b7ceb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"62c08948_71a7f795","updated":"2023-12-20 11:26:54.000000000","message":"1) Please open a LP bug describing this issue and where is this happening.\n2) We need to add \"quotas\" extension to our CI jobs to test that. Please, add it.\n3) By default we are always setting quota\u003d-1 for RBAC, thus this check is no needed. Directly define the RBAC quota to 5 (a reasonable number) and test it.\n4) After the test, add a cleanup method to restore the RBAC quota to -1.","commit_id":"556ab50a5e6e5761c4415d9e76dfbc4833d77403"},{"author":{"_account_id":36115,"name":"liwenjian","display_name":"liwenjian","email":"594253850@qq.com","username":"liwenjian"},"change_message_id":"cc668aab8c7952b2f017a92d9db51378628911bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b4a53e57_2abc40ef","in_reply_to":"62c08948_71a7f795","updated":"2023-12-21 13:02:40.000000000","message":"Great.How to solve the point (2)? \nAre there any similar examples and documents that can be referenced?","commit_id":"556ab50a5e6e5761c4415d9e76dfbc4833d77403"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bea27fdb2a2902f7fd5a04858be639ecaed005e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"30979877_7630ffc7","updated":"2023-12-21 09:01:14.000000000","message":"Please, add the \"quota\" extension to the CI job in order to execute this test in the CI.","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":36115,"name":"liwenjian","display_name":"liwenjian","email":"594253850@qq.com","username":"liwenjian"},"change_message_id":"cc668aab8c7952b2f017a92d9db51378628911bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1846fdf0_ba2103c9","in_reply_to":"30979877_7630ffc7","updated":"2023-12-21 13:02:40.000000000","message":"\u003e Please, add the \"quota\" extension to the CI job in order to execute this test in the CI.","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"0a154628a61edcec894703670a5eb50a4a2f1364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e291d62f_2ac74c76","updated":"2023-12-21 09:09:27.000000000","message":"-1 for PS2 questions","commit_id":"fb879ec6495d5a7598f98c273a8c7e1f6334cba7"},{"author":{"_account_id":36115,"name":"liwenjian","display_name":"liwenjian","email":"594253850@qq.com","username":"liwenjian"},"change_message_id":"cc668aab8c7952b2f017a92d9db51378628911bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7cf67b80_0346694f","updated":"2023-12-21 13:02:40.000000000","message":"recheck","commit_id":"fb879ec6495d5a7598f98c273a8c7e1f6334cba7"},{"author":{"_account_id":36115,"name":"liwenjian","display_name":"liwenjian","email":"594253850@qq.com","username":"liwenjian"},"change_message_id":"cc668aab8c7952b2f017a92d9db51378628911bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"966979de_39363cce","in_reply_to":"e291d62f_2ac74c76","updated":"2023-12-21 13:02:40.000000000","message":"In patch set 3, the quota was set to 5.\nself.admin_client.update_quotas(\n            self.client.project_id, rbac_policy\u003d5)","commit_id":"fb879ec6495d5a7598f98c273a8c7e1f6334cba7"}],"neutron_tempest_plugin/api/admin/test_shared_network_extension.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bea27fdb2a2902f7fd5a04858be639ecaed005e4","unresolved":true,"context_lines":[{"line_number":370,"context_line":"    @decorators.idempotent_id(\u0027c5f8f785-ce8d-4430-af7e-a236205862fb\u0027)"},{"line_number":371,"context_line":"    @utils.requires_ext(extension\u003d\"quotas\", service\u003d\"network\")"},{"line_number":372,"context_line":"    def test_rbac_policy_quota(self):"},{"line_number":373,"context_line":"        quota \u003d self.client.show_quotas(self.client.tenant_id)[\u0027quota\u0027]"},{"line_number":374,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":375,"context_line":"                        self.client.tenant_id, rbac_policy\u003d-1)"},{"line_number":376,"context_line":"        max_policies \u003d quota[\u0027rbac_policy\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"782420eb_c61d7f4a","line":373,"range":{"start_line":373,"start_character":52,"end_line":373,"end_character":61},"updated":"2023-12-21 09:01:14.000000000","message":"project_id","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":36115,"name":"liwenjian","display_name":"liwenjian","email":"594253850@qq.com","username":"liwenjian"},"change_message_id":"cc668aab8c7952b2f017a92d9db51378628911bf","unresolved":false,"context_lines":[{"line_number":370,"context_line":"    @decorators.idempotent_id(\u0027c5f8f785-ce8d-4430-af7e-a236205862fb\u0027)"},{"line_number":371,"context_line":"    @utils.requires_ext(extension\u003d\"quotas\", service\u003d\"network\")"},{"line_number":372,"context_line":"    def test_rbac_policy_quota(self):"},{"line_number":373,"context_line":"        quota \u003d self.client.show_quotas(self.client.tenant_id)[\u0027quota\u0027]"},{"line_number":374,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":375,"context_line":"                        self.client.tenant_id, rbac_policy\u003d-1)"},{"line_number":376,"context_line":"        max_policies \u003d quota[\u0027rbac_policy\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c1c2f48_9d752141","line":373,"range":{"start_line":373,"start_character":52,"end_line":373,"end_character":61},"in_reply_to":"782420eb_c61d7f4a","updated":"2023-12-21 13:02:40.000000000","message":"Done","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bea27fdb2a2902f7fd5a04858be639ecaed005e4","unresolved":true,"context_lines":[{"line_number":372,"context_line":"    def test_rbac_policy_quota(self):"},{"line_number":373,"context_line":"        quota \u003d self.client.show_quotas(self.client.tenant_id)[\u0027quota\u0027]"},{"line_number":374,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":375,"context_line":"                        self.client.tenant_id, rbac_policy\u003d-1)"},{"line_number":376,"context_line":"        max_policies \u003d quota[\u0027rbac_policy\u0027]"},{"line_number":377,"context_line":"        self.assertGreater(max_policies, 0)"},{"line_number":378,"context_line":"        net \u003d self.client.create_network("}],"source_content_type":"text/x-python","patch_set":2,"id":"1169f2c9_9fb43ceb","line":375,"range":{"start_line":375,"start_character":36,"end_line":375,"end_character":45},"updated":"2023-12-21 09:01:14.000000000","message":"project_id","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":36115,"name":"liwenjian","display_name":"liwenjian","email":"594253850@qq.com","username":"liwenjian"},"change_message_id":"cc668aab8c7952b2f017a92d9db51378628911bf","unresolved":false,"context_lines":[{"line_number":372,"context_line":"    def test_rbac_policy_quota(self):"},{"line_number":373,"context_line":"        quota \u003d self.client.show_quotas(self.client.tenant_id)[\u0027quota\u0027]"},{"line_number":374,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":375,"context_line":"                        self.client.tenant_id, rbac_policy\u003d-1)"},{"line_number":376,"context_line":"        max_policies \u003d quota[\u0027rbac_policy\u0027]"},{"line_number":377,"context_line":"        self.assertGreater(max_policies, 0)"},{"line_number":378,"context_line":"        net \u003d self.client.create_network("}],"source_content_type":"text/x-python","patch_set":2,"id":"389b6a24_14c5c729","line":375,"range":{"start_line":375,"start_character":36,"end_line":375,"end_character":45},"in_reply_to":"1169f2c9_9fb43ceb","updated":"2023-12-21 13:02:40.000000000","message":"Done","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bea27fdb2a2902f7fd5a04858be639ecaed005e4","unresolved":true,"context_lines":[{"line_number":374,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":375,"context_line":"                        self.client.tenant_id, rbac_policy\u003d-1)"},{"line_number":376,"context_line":"        max_policies \u003d quota[\u0027rbac_policy\u0027]"},{"line_number":377,"context_line":"        self.assertGreater(max_policies, 0)"},{"line_number":378,"context_line":"        net \u003d self.client.create_network("},{"line_number":379,"context_line":"            name\u003ddata_utils.rand_name(\u0027test-network\u0027))[\u0027network\u0027]"},{"line_number":380,"context_line":"        self.addCleanup(self.client.delete_network, net[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"b2a14017_0d011b1a","line":377,"range":{"start_line":377,"start_character":8,"end_line":377,"end_character":43},"updated":"2023-12-21 09:01:14.000000000","message":"Won\u0027t you have the same problem again? If by default we set the quota to -1, won\u0027t this fail?","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":36115,"name":"liwenjian","display_name":"liwenjian","email":"594253850@qq.com","username":"liwenjian"},"change_message_id":"cc668aab8c7952b2f017a92d9db51378628911bf","unresolved":false,"context_lines":[{"line_number":374,"context_line":"        self.addCleanup(self.admin_client.update_quotas,"},{"line_number":375,"context_line":"                        self.client.tenant_id, rbac_policy\u003d-1)"},{"line_number":376,"context_line":"        max_policies \u003d quota[\u0027rbac_policy\u0027]"},{"line_number":377,"context_line":"        self.assertGreater(max_policies, 0)"},{"line_number":378,"context_line":"        net \u003d self.client.create_network("},{"line_number":379,"context_line":"            name\u003ddata_utils.rand_name(\u0027test-network\u0027))[\u0027network\u0027]"},{"line_number":380,"context_line":"        self.addCleanup(self.client.delete_network, net[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"1e25b41b_3edb0fa7","line":377,"range":{"start_line":377,"start_character":8,"end_line":377,"end_character":43},"in_reply_to":"b2a14017_0d011b1a","updated":"2023-12-21 13:02:40.000000000","message":"Done","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bea27fdb2a2902f7fd5a04858be639ecaed005e4","unresolved":true,"context_lines":[{"line_number":380,"context_line":"        self.addCleanup(self.client.delete_network, net[\u0027id\u0027])"},{"line_number":381,"context_line":"        with testtools.ExpectedException(lib_exc.Conflict):"},{"line_number":382,"context_line":"            for i in range(0, max_policies + 1):"},{"line_number":383,"context_line":"                # Using client instead of admin_client"},{"line_number":384,"context_line":"                self.client.create_rbac_policy("},{"line_number":385,"context_line":"                    object_type\u003d\u0027network\u0027, object_id\u003dnet[\u0027id\u0027],"},{"line_number":386,"context_line":"                    action\u003d\u0027access_as_shared\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9b5b5828_83308cf1","line":383,"range":{"start_line":383,"start_character":16,"end_line":383,"end_character":54},"updated":"2023-12-21 09:01:14.000000000","message":"Why?","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"},{"author":{"_account_id":36115,"name":"liwenjian","display_name":"liwenjian","email":"594253850@qq.com","username":"liwenjian"},"change_message_id":"cc668aab8c7952b2f017a92d9db51378628911bf","unresolved":true,"context_lines":[{"line_number":380,"context_line":"        self.addCleanup(self.client.delete_network, net[\u0027id\u0027])"},{"line_number":381,"context_line":"        with testtools.ExpectedException(lib_exc.Conflict):"},{"line_number":382,"context_line":"            for i in range(0, max_policies + 1):"},{"line_number":383,"context_line":"                # Using client instead of admin_client"},{"line_number":384,"context_line":"                self.client.create_rbac_policy("},{"line_number":385,"context_line":"                    object_type\u003d\u0027network\u0027, object_id\u003dnet[\u0027id\u0027],"},{"line_number":386,"context_line":"                    action\u003d\u0027access_as_shared\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"719b384f_c12e5df7","line":383,"range":{"start_line":383,"start_character":16,"end_line":383,"end_character":54},"in_reply_to":"9b5b5828_83308cf1","updated":"2023-12-21 13:02:40.000000000","message":"When creating an RBAC policy using self.admin_client, no expected exception is thrown, which will result in an error.\n\nTraceback (most recent call last):\n  File \"/var/lib/kolla/venv/lib/python3.6/site-packages/tempest/common/utils/__init__.py\", line 89, in wrapper\n    return func(*func_args, **func_kwargs)\n  File \"/var/lib/kolla/venv/lib/python3.6/site-packages/neutron_tempest_plugin/api/admin/test_shared_network_extension.py\", line 387, in test_rbac_policy_quota\n    target_tenant\u003duuidutils.generate_uuid().replace(\u0027-\u0027, \u0027\u0027))\n  File \"/var/lib/kolla/venv/lib/python3.6/site-packages/testtools/testcase.py\", line 1013, in __exit__\n    raise AssertionError(error_msg)\nAssertionError: Conflict not raised.Ran 1 test in 19.950s","commit_id":"9ae7f46f58bc325b22bd0f7327caf78fc67a15c5"}]}