)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"96b337f8fd1dad0c50bc8977d95dd6d1e962d2e6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8d7f1d6b_a6755d31","updated":"2024-03-07 09:25:07.000000000","message":"Thanks Slawek","commit_id":"ec162e0f56588419e3efb7e70eee8b1d826c307b"}],"neutron_tempest_plugin/api/test_qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"656aa84e09b2fe427c3849eb146db035425ddf73","unresolved":true,"context_lines":[{"line_number":703,"context_line":"        QosBandwidthLimitRuleTestJSON.required_extensions +"},{"line_number":704,"context_line":"        [\u0027qos-bw-limit-direction\u0027]"},{"line_number":705,"context_line":"    )"},{"line_number":706,"context_line":"    scenarios \u003d ["},{"line_number":707,"context_line":"        (\u0027ingress\u0027, {\u0027direction\u0027: \u0027ingress\u0027}),"},{"line_number":708,"context_line":"        (\u0027egress\u0027, {\u0027direction\u0027: \u0027egress\u0027}),"},{"line_number":709,"context_line":"    ]"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    @classmethod"},{"line_number":712,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":713,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"95deadee_1e924949","side":"PARENT","line":710,"range":{"start_line":706,"start_character":3,"end_line":710,"end_character":1},"updated":"2024-03-06 11:53:41.000000000","message":"Where are you replacing the scenarios with the ddt decorator?","commit_id":"468deaf6fbc67fa3abf0b49ddbc19f37b7523c11"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"17410133f4415f8d192c19c15c0d117a42be7869","unresolved":true,"context_lines":[{"line_number":703,"context_line":"        QosBandwidthLimitRuleTestJSON.required_extensions +"},{"line_number":704,"context_line":"        [\u0027qos-bw-limit-direction\u0027]"},{"line_number":705,"context_line":"    )"},{"line_number":706,"context_line":"    scenarios \u003d ["},{"line_number":707,"context_line":"        (\u0027ingress\u0027, {\u0027direction\u0027: \u0027ingress\u0027}),"},{"line_number":708,"context_line":"        (\u0027egress\u0027, {\u0027direction\u0027: \u0027egress\u0027}),"},{"line_number":709,"context_line":"    ]"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    @classmethod"},{"line_number":712,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":713,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e29a7607_f34a5284","side":"PARENT","line":710,"range":{"start_line":706,"start_character":3,"end_line":710,"end_character":1},"in_reply_to":"95deadee_1e924949","updated":"2024-03-06 12:11:16.000000000","message":"I am not because it seems that \"self.direction\" is not used anywhere in this class so actually those scenarios were useless and it was running 2 times exactly same test :)","commit_id":"468deaf6fbc67fa3abf0b49ddbc19f37b7523c11"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"d7b76dc3ebbe33b1c7f3ae13457e0ce97c10b7dd","unresolved":true,"context_lines":[{"line_number":703,"context_line":"        QosBandwidthLimitRuleTestJSON.required_extensions +"},{"line_number":704,"context_line":"        [\u0027qos-bw-limit-direction\u0027]"},{"line_number":705,"context_line":"    )"},{"line_number":706,"context_line":"    scenarios \u003d ["},{"line_number":707,"context_line":"        (\u0027ingress\u0027, {\u0027direction\u0027: \u0027ingress\u0027}),"},{"line_number":708,"context_line":"        (\u0027egress\u0027, {\u0027direction\u0027: \u0027egress\u0027}),"},{"line_number":709,"context_line":"    ]"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    @classmethod"},{"line_number":712,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":713,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"dc62fdd2_84a3c4f6","side":"PARENT","line":710,"range":{"start_line":706,"start_character":3,"end_line":710,"end_character":1},"in_reply_to":"96242df6_1cd3053f","updated":"2024-03-06 15:25:30.000000000","message":"yeah, You are right. It\u0027s defined in different class but this one inherits from the one with \"opposite_direction\" attribute.\nI now have changed that.","commit_id":"468deaf6fbc67fa3abf0b49ddbc19f37b7523c11"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b90b0fde5bd5ee6af81922a5d63dd6e1e1175391","unresolved":true,"context_lines":[{"line_number":703,"context_line":"        QosBandwidthLimitRuleTestJSON.required_extensions +"},{"line_number":704,"context_line":"        [\u0027qos-bw-limit-direction\u0027]"},{"line_number":705,"context_line":"    )"},{"line_number":706,"context_line":"    scenarios \u003d ["},{"line_number":707,"context_line":"        (\u0027ingress\u0027, {\u0027direction\u0027: \u0027ingress\u0027}),"},{"line_number":708,"context_line":"        (\u0027egress\u0027, {\u0027direction\u0027: \u0027egress\u0027}),"},{"line_number":709,"context_line":"    ]"},{"line_number":710,"context_line":""},{"line_number":711,"context_line":"    @classmethod"},{"line_number":712,"context_line":"    @base.require_qos_rule_type(qos_consts.RULE_TYPE_BANDWIDTH_LIMIT)"},{"line_number":713,"context_line":"    def resource_setup(cls):"}],"source_content_type":"text/x-python","patch_set":1,"id":"96242df6_1cd3053f","side":"PARENT","line":710,"range":{"start_line":706,"start_character":3,"end_line":710,"end_character":1},"in_reply_to":"e29a7607_f34a5284","updated":"2024-03-06 12:15:57.000000000","message":"We are using it in \"self.opposite_direction\" but maybe we can refactor this single test that uses \"self.opposite_direction\".","commit_id":"468deaf6fbc67fa3abf0b49ddbc19f37b7523c11"}]}