)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1272b2d534bc1b2097177bf8de7caf5e1c2c9ea6","unresolved":true,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that this test will fail, until the Neutron fix for #2058138"},{"line_number":15,"context_line":"is merged."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: #2058138"},{"line_number":18,"context_line":"Change-Id: Id1fa2489170d5cdaebf72c6d3b00818d9fb118fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dc2531d4_f008a98d","line":16,"updated":"2024-03-20 23:31:20.000000000","message":"If you add this here it will include your neutron change and the tests should pass:\n\nDepends-on: https://review.opendev.org/c/openstack/neutron/+/913708","commit_id":"390e8b8031a85b893158ed65bfe89ddd46b2a337"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"cf97a9f9c7497c51b326d96a441ba1ceaf1f6f03","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Note that this test will fail, until the Neutron fix for #2058138"},{"line_number":15,"context_line":"is merged."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Related-Bug: #2058138"},{"line_number":18,"context_line":"Change-Id: Id1fa2489170d5cdaebf72c6d3b00818d9fb118fe"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f98f553_53c9c40a","line":16,"in_reply_to":"dc2531d4_f008a98d","updated":"2024-03-20 23:58:06.000000000","message":"Done","commit_id":"390e8b8031a85b893158ed65bfe89ddd46b2a337"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e114b4a52b0b10a3891666fbd637211518c90f2c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"12c86f4a_eee7d8a1","updated":"2024-03-21 02:07:28.000000000","message":"Obviously the neutron patch will need to be backported, which should address the hybrid-2023.2 job, odd how the hybrid-2023.1 one passed :-/ Similar with the linuxbridge jobs.\n\nLet\u0027s see what things look like after you make the other change I suggested, either we can wait for the backports, or add the failing test to the exclude list for certain branches if necessary.","commit_id":"78dbc24a95daf48604b80141ec10759db07e7bd2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"035d7d74f48bd892702c05fdb9df9949098db581","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a948db3a_3840ef10","updated":"2024-03-22 14:00:40.000000000","message":"I\u0027m also curious how the 2023.* hybrid jobs are passing as those branches don\u0027t have the neutron change.","commit_id":"85d48381940bb5c19399c5e45008900bf54b3fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"651df9b73f956d67f674c7c379a235bc3946f0be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"af35e8a2_d751db6e","updated":"2024-03-30 03:08:03.000000000","message":"I just want to make sure this passes multiple times before approving","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b17f2e96bbcaeb60fa6baff32d1bcba6562d1d72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"31879e17_344e7e0c","updated":"2024-04-16 20:56:43.000000000","message":"Part of me doesn\u0027t want to not have this tested, even though I don\u0027t love the sleep, but it did pass multiple times. We\u0027ll see what others think.","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6d747aba8f73893a91d661701f272f81db3ab359","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"1e336d7d_b95dbe9d","updated":"2024-03-24 17:16:51.000000000","message":"So I hate to say the results here are pretty much as expected. With the change only in master the 2024.1/2023.*/zed branches should be failing.","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c84c48489dce7fc9130fd947a7db14c9c420088f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"cbb9ba13_eceb0fee","updated":"2024-03-30 01:13:16.000000000","message":"recheck all backports have merged, should be green","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0024f144c2ee072f7c5b911dcff9fd480a176d07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"0898349b_96cf64dc","updated":"2024-03-31 22:59:05.000000000","message":"recheck get additional results","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ef95fcf7aa66f57a45c4826de412ad37f979e547","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aa1a933e_b2f94af4","updated":"2024-03-26 17:03:37.000000000","message":"recheck https://review.opendev.org/c/openstack/neutron/+/913809 merged\n\nthis should show the hybrid 2024.1 job pass","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"60cc780ba27ea26743e65509033070b3994939c4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"02881f2a_484074a0","updated":"2024-03-28 20:10:46.000000000","message":"recheck https://review.opendev.org/c/openstack/neutron/+/914217 merged\n\nshould show the 2023.2 jobs passing","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"87efcc19b01b7bc8e5bf08d81411db5dd0e452a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3a1c7f67_6968d4d2","updated":"2024-04-03 00:25:36.000000000","message":"recheck lets test one more time","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ce6b94998ceff3d244dc8f0c15eb524597ff93be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"14d72050_f38a7183","updated":"2024-04-03 15:05:58.000000000","message":"recheck unrelated test failure","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"}],"neutron_tempest_plugin/scenario/test_security_groups.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e114b4a52b0b10a3891666fbd637211518c90f2c","unresolved":true,"context_lines":[{"line_number":786,"context_line":"        self._test_remote_group()"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    @testtools.skipUnless("},{"line_number":789,"context_line":"        CONF.neutron_plugin_options.firewall_driver \u003d\u003d \u0027openvswitch\u0027,"},{"line_number":790,"context_line":"        \"Openvswitch agent is required to run this test\")"},{"line_number":791,"context_line":"    @decorators.idempotent_id(\u0027678dd4c0-2953-4626-b89c-8e7e4110ec4b\u0027)"},{"line_number":792,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"address-group\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"363ec0c9_87906852","side":"PARENT","line":789,"updated":"2024-03-21 02:07:28.000000000","message":"I guess I\u0027m a little surprised OVN doesn\u0027t support this, but looks like you\u0027ll need to change this to be a skipIf:\n\n@testtools.skipIf(\n    CONF.neutron_plugin_options.firewall_driver \u003d\u003d \u0027ovn\u0027,\n    Firewall driver other than \u0027ovn\u0027 is required to run this test\")","commit_id":"bcabf136e59684baf038fd02fc226946c8be63f7"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ddbe429c2563731d5ebd9fca94abcc6e8e161171","unresolved":true,"context_lines":[{"line_number":786,"context_line":"        self._test_remote_group()"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    @testtools.skipUnless("},{"line_number":789,"context_line":"        CONF.neutron_plugin_options.firewall_driver \u003d\u003d \u0027openvswitch\u0027,"},{"line_number":790,"context_line":"        \"Openvswitch agent is required to run this test\")"},{"line_number":791,"context_line":"    @decorators.idempotent_id(\u0027678dd4c0-2953-4626-b89c-8e7e4110ec4b\u0027)"},{"line_number":792,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"address-group\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"6ce7caef_9f34e1d8","side":"PARENT","line":789,"in_reply_to":"363ec0c9_87906852","updated":"2024-03-21 08:30:05.000000000","message":"it seems it is a good candidate for the gaps document\nhttps://docs.openstack.org/neutron/latest/ovn/gaps.html","commit_id":"bcabf136e59684baf038fd02fc226946c8be63f7"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"035d7d74f48bd892702c05fdb9df9949098db581","unresolved":true,"context_lines":[{"line_number":790,"context_line":"        \"Firewall driver other than \u0027ovn\u0027 is required to run this test\")"},{"line_number":791,"context_line":"    @testtools.skipIf("},{"line_number":792,"context_line":"        CONF.neutron_plugin_options.q_agent \u003d\u003d \u0027linuxbridge\u0027,"},{"line_number":793,"context_line":"        \"Agent other than \u0027linuxbridge\u0027 is required to run this test\")"},{"line_number":794,"context_line":"    @decorators.idempotent_id(\u0027678dd4c0-2953-4626-b89c-8e7e4110ec4b\u0027)"},{"line_number":795,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"address-group\", service\u003d\"network\")"},{"line_number":796,"context_line":"    @tempest_utils.requires_ext("}],"source_content_type":"text/x-python","patch_set":5,"id":"5bbee046_a80233e6","line":793,"updated":"2024-03-22 14:00:40.000000000","message":"Why is linuxbridge failing? it should be using the iptables firewall driver, right?","commit_id":"85d48381940bb5c19399c5e45008900bf54b3fb6"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"011d393a6ea2570ede420677be5268c96c09cf2a","unresolved":true,"context_lines":[{"line_number":790,"context_line":"        \"Firewall driver other than \u0027ovn\u0027 is required to run this test\")"},{"line_number":791,"context_line":"    @testtools.skipIf("},{"line_number":792,"context_line":"        CONF.neutron_plugin_options.q_agent \u003d\u003d \u0027linuxbridge\u0027,"},{"line_number":793,"context_line":"        \"Agent other than \u0027linuxbridge\u0027 is required to run this test\")"},{"line_number":794,"context_line":"    @decorators.idempotent_id(\u0027678dd4c0-2953-4626-b89c-8e7e4110ec4b\u0027)"},{"line_number":795,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"address-group\", service\u003d\"network\")"},{"line_number":796,"context_line":"    @tempest_utils.requires_ext("}],"source_content_type":"text/x-python","patch_set":5,"id":"637be20a_4db2be7c","line":793,"in_reply_to":"5bbee046_a80233e6","updated":"2024-03-22 18:07:59.000000000","message":"Absolutely.\nTo be honest, I can\u0027t make sense of some of these test results. Please bear with me, while I experiment.\n\nI wonder whether this is skewed by race conditions, where Tempest makes changes to SGs/AGs on Neutron server, Neutron server would push these out to its agents asynchronously, but Tempest sometimes checks results before requested changes are applied.\n\nSo I guess I\u0027ll experiment with some added time.sleep() next, to see whether that stabilizes the test.","commit_id":"85d48381940bb5c19399c5e45008900bf54b3fb6"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"44f2f888f6a50d20e347ca8444251303c4f373c2","unresolved":false,"context_lines":[{"line_number":790,"context_line":"        \"Firewall driver other than \u0027ovn\u0027 is required to run this test\")"},{"line_number":791,"context_line":"    @testtools.skipIf("},{"line_number":792,"context_line":"        CONF.neutron_plugin_options.q_agent \u003d\u003d \u0027linuxbridge\u0027,"},{"line_number":793,"context_line":"        \"Agent other than \u0027linuxbridge\u0027 is required to run this test\")"},{"line_number":794,"context_line":"    @decorators.idempotent_id(\u0027678dd4c0-2953-4626-b89c-8e7e4110ec4b\u0027)"},{"line_number":795,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"address-group\", service\u003d\"network\")"},{"line_number":796,"context_line":"    @tempest_utils.requires_ext("}],"source_content_type":"text/x-python","patch_set":5,"id":"c863adf7_1ba29a0e","line":793,"in_reply_to":"637be20a_4db2be7c","updated":"2024-03-25 17:58:11.000000000","message":"Race condition in the test - discussed in https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/913850/comment/9ec7426c_1ef4cd8a/","commit_id":"85d48381940bb5c19399c5e45008900bf54b3fb6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"64f466979e806a806183299c47e45ffb3aa99341","unresolved":true,"context_lines":[{"line_number":507,"context_line":"            servers\u003dservers)"},{"line_number":508,"context_line":"        # make sure ICMP connectivity doesn\u0027t work from framework"},{"line_number":509,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":510,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        # Remove the ICMP rule with remote group"},{"line_number":513,"context_line":"        self.client.delete_security_group_rule(remote_sg_rid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"5788cb14_4b470680","line":510,"updated":"2024-03-22 21:02:33.000000000","message":"It\u0027s almost like these ping calls need to use the wait_until_true() logic","commit_id":"19273587f324ce0b6a5ad48476039c87a35d0ee1"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"44f2f888f6a50d20e347ca8444251303c4f373c2","unresolved":false,"context_lines":[{"line_number":507,"context_line":"            servers\u003dservers)"},{"line_number":508,"context_line":"        # make sure ICMP connectivity doesn\u0027t work from framework"},{"line_number":509,"context_line":"        self.ping_ip_address(fips[0][\u0027floating_ip_address\u0027],"},{"line_number":510,"context_line":"                             should_succeed\u003dFalse)"},{"line_number":511,"context_line":""},{"line_number":512,"context_line":"        # Remove the ICMP rule with remote group"},{"line_number":513,"context_line":"        self.client.delete_security_group_rule(remote_sg_rid)"}],"source_content_type":"text/x-python","patch_set":6,"id":"1dc6385a_29b897c7","line":510,"in_reply_to":"5788cb14_4b470680","updated":"2024-03-25 17:58:11.000000000","message":"Discussed in https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/913850/comment/9ec7426c_1ef4cd8a/","commit_id":"19273587f324ce0b6a5ad48476039c87a35d0ee1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6d747aba8f73893a91d661701f272f81db3ab359","unresolved":true,"context_lines":[{"line_number":504,"context_line":"        # check the changed state with the remote address group."},{"line_number":505,"context_line":"        # This reliable reproduces that https://launchpad.net/bugs/2058138"},{"line_number":506,"context_line":"        # is fixed."},{"line_number":507,"context_line":"        time.sleep(3)"},{"line_number":508,"context_line":"        # verify ICMP connectivity between instances still works"},{"line_number":509,"context_line":"        self.check_remote_connectivity("},{"line_number":510,"context_line":"            server_ssh_clients[0], fips[1][\u0027fixed_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ec7426c_1ef4cd8a","line":507,"updated":"2024-03-24 17:16:51.000000000","message":"I will have to think on this and see what other opinions are - sleeps work until the test runs on a really slow host, then fail. I know some of the sfc tests use this instead of a wait_until_true():\n\n   def _wait_for_port_pair_group_status(self, port_pair_group, status):\n        time.sleep(10)\n\nAnd some of the floating IP tests could sleep for up to 2 minutes (see _wait_for_port_detach()) but are looking at API results.\n\nThe only thing we have here is the ping succeeds when it should fail, which is why it could be in a loop, or wait_until_true() type call, that way it might run a few iterations then pass, or a long time and fail (which is fine).","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ef95fcf7aa66f57a45c4826de412ad37f979e547","unresolved":true,"context_lines":[{"line_number":504,"context_line":"        # check the changed state with the remote address group."},{"line_number":505,"context_line":"        # This reliable reproduces that https://launchpad.net/bugs/2058138"},{"line_number":506,"context_line":"        # is fixed."},{"line_number":507,"context_line":"        time.sleep(3)"},{"line_number":508,"context_line":"        # verify ICMP connectivity between instances still works"},{"line_number":509,"context_line":"        self.check_remote_connectivity("},{"line_number":510,"context_line":"            server_ssh_clients[0], fips[1][\u0027fixed_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"9865a619_b290a2c5","line":507,"in_reply_to":"7769ba49_a2cfc37e","updated":"2024-03-26 17:03:37.000000000","message":"Yes, we could do a longer sleep, 3 seconds might be right on the edge.\n\nI see your point about ping_ip_address() and how it could return immediately if the condition is met. We could work around that here with a loop or wait_until_true() which would then obviate the need for a sleep perhaps.\n\nOr like you mention, change the remote connectivity check to loop, I guess it would have the same effect as it should be detecting the rule has been applied or cleared.","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":35931,"name":"Robert Breker","display_name":"Robert Breker","email":"mail@robertbreker.de","username":"rbreker"},"change_message_id":"44f2f888f6a50d20e347ca8444251303c4f373c2","unresolved":true,"context_lines":[{"line_number":504,"context_line":"        # check the changed state with the remote address group."},{"line_number":505,"context_line":"        # This reliable reproduces that https://launchpad.net/bugs/2058138"},{"line_number":506,"context_line":"        # is fixed."},{"line_number":507,"context_line":"        time.sleep(3)"},{"line_number":508,"context_line":"        # verify ICMP connectivity between instances still works"},{"line_number":509,"context_line":"        self.check_remote_connectivity("},{"line_number":510,"context_line":"            server_ssh_clients[0], fips[1][\u0027fixed_ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7769ba49_a2cfc37e","line":507,"in_reply_to":"9ec7426c_1ef4cd8a","updated":"2024-03-25 17:58:11.000000000","message":"Thank you Brian - I really appreciate your guidance!\n\nBoth check_remote_connectivity() and ping_ip_address() already retry for up to 60s in a loop. The challenge in this test is that their condition is met prior to the AG addition and they therefor return instantly, but the rule change propagates with a delay, which breaks the condition seconds after.\n\nI think there are two improvements we can make for slower hosts:\n* Longer sleep 😊\n* We could remove the SG rule, wait for that change to apply using check_remote_connectivity(should_suceed\u003dFalse), and then reapply the SG rule in combination with the AG rule, and wait for check_remote_connectivity(should_suceed\u003dTrue). However there then still is a rare chance that one rule is applied and the other isn\u0027t.","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"734e48b0a3985ef1e9f928f729b1d67d441acb6d","unresolved":true,"context_lines":[{"line_number":983,"context_line":""},{"line_number":984,"context_line":"    @testtools.skipUnless("},{"line_number":985,"context_line":"        CONF.neutron_plugin_options.firewall_driver \u003d\u003d \u0027openvswitch\u0027,"},{"line_number":986,"context_line":"        \"Openvswitch agent is required to run this test\")"},{"line_number":987,"context_line":"    @decorators.idempotent_id(\u00279fae530d-2711-4c61-a4a5-8efe6e58ab14\u0027)"},{"line_number":988,"context_line":"    @tempest_utils.requires_ext(extension\u003d\"address-group\", service\u003d\"network\")"},{"line_number":989,"context_line":"    @tempest_utils.requires_ext("}],"source_content_type":"text/x-python","patch_set":11,"id":"57c51576_6d8accec","line":986,"updated":"2024-05-20 09:48:14.000000000","message":"You should probably change the conditon also here to enable test for the stateless SG too.","commit_id":"212d2cd98a8291f9f2d464d0e03388877a5a37b4"}]}