)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e4b6b1a883fd348e6627077df0422da0e34ffaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b8816fed_642df477","updated":"2024-08-17 21:38:00.000000000","message":"I guess, as expected, this test only passes on the master branch, so we\u0027ll need to wait until the fix is backported to 2023.1 for them all to pass.","commit_id":"14f895fe3eb5cb37e068aea1cb1ef87a7163e3ba"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"028ffe8bc9956c145702b25487153c464aefc0dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"18cf266b_d9a5daa0","in_reply_to":"b8816fed_642df477","updated":"2024-08-22 01:29:06.000000000","message":"I agree with your opinion. Thank you.","commit_id":"14f895fe3eb5cb37e068aea1cb1ef87a7163e3ba"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"bcff4e97b5e17c4406dff348f624813ca5989ba3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"587434d8_338b11ae","updated":"2024-10-31 10:43:48.000000000","message":"recheck\nsince https://review.opendev.org/c/openstack/neutron/+/921909 is merged","commit_id":"6cd2f054f9fde9522098c365828b38aa0dede061"}],"neutron_tempest_plugin/scenario/test_default_security_group_rules.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e4b6b1a883fd348e6627077df0422da0e34ffaa","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setup_clients(cls):"},{"line_number":25,"context_line":"        super(DefaultSecurityGroupRulesTest, cls).setup_clients()"},{"line_number":26,"context_line":"        cls.admin_client \u003d cls.os_admin.network_client"},{"line_number":27,"context_line":"        cls.identity_admin_client \u003d cls.os_admin.projects_client"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"86516d79_0b41f313","line":25,"range":{"start_line":25,"start_character":14,"end_line":25,"end_character":48},"updated":"2024-08-17 21:38:00.000000000","message":"nit: this can just be super().setup_clients()","commit_id":"14f895fe3eb5cb37e068aea1cb1ef87a7163e3ba"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"6b491cc004f97e5cab1ab34f5bb3590a1faad7a9","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @classmethod"},{"line_number":24,"context_line":"    def setup_clients(cls):"},{"line_number":25,"context_line":"        super(DefaultSecurityGroupRulesTest, cls).setup_clients()"},{"line_number":26,"context_line":"        cls.admin_client \u003d cls.os_admin.network_client"},{"line_number":27,"context_line":"        cls.identity_admin_client \u003d cls.os_admin.projects_client"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cce78d4b_9233a095","line":25,"range":{"start_line":25,"start_character":14,"end_line":25,"end_character":48},"in_reply_to":"86516d79_0b41f313","updated":"2024-08-22 15:24:28.000000000","message":"I applied it. Thanks.","commit_id":"14f895fe3eb5cb37e068aea1cb1ef87a7163e3ba"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e4b6b1a883fd348e6627077df0422da0e34ffaa","unresolved":true,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def resource_setup(cls):"},{"line_number":31,"context_line":"        super(DefaultSecurityGroupRulesTest, cls).resource_setup()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @decorators.idempotent_id(\u0027a86b2f20-22ef-4991-adc8-c54981b5fa3a\u0027)"},{"line_number":34,"context_line":"    def test_sg_rule_quota_with_default_sg_rules(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"9bfb9188_1d9be175","line":31,"updated":"2024-08-17 21:38:00.000000000","message":"This method isn\u0027t necessary since it\u0027s just calling super() and does no other operations.","commit_id":"14f895fe3eb5cb37e068aea1cb1ef87a7163e3ba"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"b10e83b1124f9b220a3ec52ffab1a322ed19ea5f","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    @classmethod"},{"line_number":30,"context_line":"    def resource_setup(cls):"},{"line_number":31,"context_line":"        super(DefaultSecurityGroupRulesTest, cls).resource_setup()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @decorators.idempotent_id(\u0027a86b2f20-22ef-4991-adc8-c54981b5fa3a\u0027)"},{"line_number":34,"context_line":"    def test_sg_rule_quota_with_default_sg_rules(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"17b33430_bfd5f5c4","line":31,"in_reply_to":"9bfb9188_1d9be175","updated":"2024-08-22 15:25:00.000000000","message":"I removed it and there was no problem. Thank you.","commit_id":"14f895fe3eb5cb37e068aea1cb1ef87a7163e3ba"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3e4b6b1a883fd348e6627077df0422da0e34ffaa","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # cleanup"},{"line_number":75,"context_line":"        self.admin_client.delete_default_security_group_rule("},{"line_number":76,"context_line":"            created_rule[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"1ecaae7c_6f2c4fde","line":76,"updated":"2024-08-17 21:38:00.000000000","message":"Don\u0027t think this is necessary, should be cleaned-up automatically.","commit_id":"14f895fe3eb5cb37e068aea1cb1ef87a7163e3ba"},{"author":{"_account_id":36716,"name":"Kyuyeong Lee","display_name":"Kyuyeong Lee","email":"kyu0.lee@samsung.com","username":"kyu0"},"change_message_id":"1ab744d8f93474ca77d559b3e78cf0bfc4512e08","unresolved":true,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        # cleanup"},{"line_number":75,"context_line":"        self.admin_client.delete_default_security_group_rule("},{"line_number":76,"context_line":"            created_rule[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"a70b7df9_0233aa38","line":76,"in_reply_to":"1ecaae7c_6f2c4fde","updated":"2024-08-22 15:31:32.000000000","message":"I don\u0027t think it is not necessary.\nI removed it and ran this test several times on my local devstack environment, and the below error occurred because the previously created rule was not cleaned-up automatically.\n\ntempest.lib.exceptions.Conflict: Conflict with state of target resource\nDetails: {\u0027type\u0027: \u0027DefaultSecurityGroupRuleExists\u0027, \u0027message\u0027: \u0027Default Security group rule already exists. Rule id is 5134a25f-355d-479f-bd2e-19df96e8f027.\u0027, \u0027detail\u0027: \u0027\u0027}","commit_id":"14f895fe3eb5cb37e068aea1cb1ef87a7163e3ba"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0c300b28480d0ea467df8dcdd46cdbd09fc7f666","unresolved":true,"context_lines":[{"line_number":17,"context_line":"from neutron_tempest_plugin.scenario import base"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class DefaultSecurityGroupRulesTest(base.BaseTempestTestCase):"},{"line_number":21,"context_line":"    credentials \u003d [\u0027primary\u0027, \u0027admin\u0027]"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba7e4c47_237e2998","line":20,"range":{"start_line":20,"start_character":41,"end_line":20,"end_character":60},"updated":"2025-09-23 21:41:07.000000000","message":"So I think the reason the cleanup didn\u0027t happen is this should be BaseAdminNetworkTest, then credentials and setup_clients() can go away as well, and the cleanup.","commit_id":"e938921e102ca79c2515f5e46c5f0c56c2d2110c"}]}