)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85cdc678562f3dcbddf0359c1fd7a619fe21e42b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"895a3fde_3a42ed9f","updated":"2024-10-01 14:28:32.000000000","message":"I\u0027m not sure this is the right thing to do. You effectively disable the previous walking checks if any other test case happens to delete a resource.\n\nWhat I think should happen is - tests should not walk over random objects in the db, instead they should walk over objects that are under control of the same test case (so they are created and deleted by the test itself), to make sure that each scenario is isolated from any other.","commit_id":"e2dd81b659dc395e9ef5dce2b63cdb45dcaaa32a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4d249a551423e88054aae197eff166f0030cffee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5d3ee076_853b5a24","in_reply_to":"4523233c_3dda9970","updated":"2024-10-04 10:57:38.000000000","message":"I see ,sorry, I skipped this one.\nIf I understand well your comment the _test_resources() call (check) makes it sure that only the resources created by the give test (i.e.: SubnetsSearchCriteriaTest.test_list_pagination_with_href_links) are counted, see the original change from Yatin: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/926201","commit_id":"e2dd81b659dc395e9ef5dce2b63cdb45dcaaa32a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6ab34fec6bd8f29310c2f394691dda1ed40f0033","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6b258821_54dae7bf","in_reply_to":"5d3ee076_853b5a24","updated":"2024-10-04 17:52:02.000000000","message":"This is what I see in the bug report comments:\n\n```\nThe core problem is that the test first build list of items and iterate over the list, but sometimes any item in the list can be deleted by a different test running concurrently and the previous link can no longer be obtained when that happens.\n\n```\n\nThis suggests a race with a different test case. Is the comment invalid?","commit_id":"e2dd81b659dc395e9ef5dce2b63cdb45dcaaa32a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0ae2336c57bc1b092251bfcaa770c5db4543c597","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1f20e3b1_6c58a685","in_reply_to":"6b258821_54dae7bf","updated":"2024-10-17 12:52:48.000000000","message":"I had time to come back to this issue....\nYou are right with the original issue, and for that the easiest and most effective way what I see is to create these resources for each test case not for the test class (i.e.: here https://opendev.org/openstack/neutron-tempest-plugin/src/branch/master/neutron_tempest_plugin/api/test_subnets.py#L26 change resource_Setup to setUp)","commit_id":"e2dd81b659dc395e9ef5dce2b63cdb45dcaaa32a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"fcc7b041985c62d385c8d60575d2d3f5e98711d6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4523233c_3dda9970","in_reply_to":"895a3fde_3a42ed9f","updated":"2024-10-03 20:28:10.000000000","message":"My main contention is about this. This is not addressed. Please reply.","commit_id":"e2dd81b659dc395e9ef5dce2b63cdb45dcaaa32a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"49cf3b8794d7c46f4f42dc558c8830c881be40b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4f92e07b_f3389ddd","updated":"2024-10-18 15:47:36.000000000","message":"As confirmed by the author, this is not the correct path to take. Cases should be better isolated.","commit_id":"bad083c1f9a3bdcc84bc6d02ba65eff2387c10e1"}],"neutron_tempest_plugin/api/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"85cdc678562f3dcbddf0359c1fd7a619fe21e42b","unresolved":true,"context_lines":[{"line_number":1586,"context_line":"        # Now walk backwards and compare results"},{"line_number":1587,"context_line":"        resources2 \u003d []"},{"line_number":1588,"context_line":"        for i in range(niterations):"},{"line_number":1589,"context_line":"            if \u0027previous\u0027 in prev_links:"},{"line_number":1590,"context_line":"                uri \u003d self.get_bare_url(prev_links[\u0027previous\u0027])"},{"line_number":1591,"context_line":"                prev_links, body \u003d self.list_client.get_uri_with_links("},{"line_number":1592,"context_line":"                    self.plural_name, uri"}],"source_content_type":"text/x-python","patch_set":1,"id":"09e07deb_2b3326f8","line":1589,"updated":"2024-10-01 14:28:32.000000000","message":"nit: should you bail out then and not iterate for no reason?","commit_id":"e2dd81b659dc395e9ef5dce2b63cdb45dcaaa32a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"1a5e8f5429e5c729d6afeaa40d0507d0eba169e3","unresolved":true,"context_lines":[{"line_number":1586,"context_line":"        # Now walk backwards and compare results"},{"line_number":1587,"context_line":"        resources2 \u003d []"},{"line_number":1588,"context_line":"        for i in range(niterations):"},{"line_number":1589,"context_line":"            if \u0027previous\u0027 in prev_links:"},{"line_number":1590,"context_line":"                uri \u003d self.get_bare_url(prev_links[\u0027previous\u0027])"},{"line_number":1591,"context_line":"                prev_links, body \u003d self.list_client.get_uri_with_links("},{"line_number":1592,"context_line":"                    self.plural_name, uri"}],"source_content_type":"text/x-python","patch_set":1,"id":"24c278ba_dee2d161","line":1589,"in_reply_to":"09e07deb_2b3326f8","updated":"2024-10-03 10:00:32.000000000","message":"done, thanks","commit_id":"e2dd81b659dc395e9ef5dce2b63cdb45dcaaa32a"}]}