)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1b037fd052df9da3766bd939ae2f0963b0c7362c","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The original test: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/926940"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related Jira ticket: https://issues.redhat.com/browse/OSPRH-13329"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I50cbdc50a6689a7dada10c5a00233afd4ee6c93a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"404630b5_3a6c40b5","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"updated":"2025-02-11 09:55:18.000000000","message":"iirc we don\u0027t state JIRA tickets upstream","commit_id":"17ad44f11d08def222e72c1807011b8aecf8b54a"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"2ad1f122a64fbf374ba53712e0505869bab0ec7c","unresolved":false,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The original test: https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/926940"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related Jira ticket: https://issues.redhat.com/browse/OSPRH-13329"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I50cbdc50a6689a7dada10c5a00233afd4ee6c93a"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"70452ea5_fa736bd5","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":65},"in_reply_to":"404630b5_3a6c40b5","updated":"2025-02-11 13:20:45.000000000","message":"thinking of it again we must use JIRA, BZ is deprecated.","commit_id":"17ad44f11d08def222e72c1807011b8aecf8b54a"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"643593744c59599633543a2c14dbb6c00be877f3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3bbbbe6c_118183f8","updated":"2025-02-18 12:17:33.000000000","message":"LGTM","commit_id":"44da3b7b44f854f71436d211ab3882c604f55d41"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1a5a6902d553f7f26b83b1781c83b9c96a198a6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"c9e88f4c_3f3d32a4","updated":"2025-02-27 10:25:56.000000000","message":"This functionality has been implemented in ML2/OVN during this cycle. Please enable it in [1] for Epoxy only and check again.\n\n[1]https://github.com/openstack/neutron-tempest-plugin/blob/d4c707e68d488885f4164b015d7adc797a151851/zuul.d/master_jobs.yaml#L697","commit_id":"44da3b7b44f854f71436d211ab3882c604f55d41"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"087c87bb1e105df2f00421e1338214f574e0d8e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cba01f3c_4c8b11d5","updated":"2025-02-14 13:33:57.000000000","message":"recheck - failed test tempest.api.compute.servers.test_attach_interfaces.AttachInterfacesTestJSON.test_create_list_show_delete_interfaces_by_fixed_ip tempest.api.compute.servers.test_multiple_create.MultipleCreateTestJSON.test_multiple_create neutron_tempest_plugin.scenario.test_qos.QoSTest.test_attach_previously_used_port_to_new_instance neutron_tempest_plugin.scenario.test_security_groups.StatelessNetworkSecGroupIPv4Test.test_packets_of_any_connection_state_can_reach_dest","commit_id":"44da3b7b44f854f71436d211ab3882c604f55d41"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"d7c3c5fb7a1b5d4e63e24c9c7076d4ca0cb240ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"e24b5c05_bdb3a05e","in_reply_to":"c9e88f4c_3f3d32a4","updated":"2025-02-27 17:47:03.000000000","message":"It seems the nested snat feature requires `ovn_router_indirect_snat\u003dtrue` [1]. When it is missing while `snat_rules_apply_to_nested_networks` is set to true in jobs, the feature gets disabled but is expected to be enabled. This is probably why it shows `AssertionError: False is not true` [2]. Would it be okay to change it back, or is there another way to test it?\n \n[1] https://review.opendev.org/c/openstack/neutron/+/926495\n[2] https://storage.bhs.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_b92/940906/13/check/neutron-tempest-plugin-ovn/b92d481/testr_results.html, https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_59a/940906/13/check/neutron-tempest-plugin-ovn-ubuntu-jammy/59af166/testr_results.html","commit_id":"44da3b7b44f854f71436d211ab3882c604f55d41"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"000463e9263793c6a03d390917d4137482e072d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3d1bd162_048a0769","updated":"2025-02-27 12:21:19.000000000","message":"Same comment as in IRC:\n\u003cralonsoh\u003e rxiao, I never suggested to create a new job. We have too many in n-t-p\n\u003cralonsoh\u003e what we need is to enable this flag for ovn in master and disable it in stable jobs\n\u003cralonsoh\u003e same as you did in PS11 but also adding the needed configuration for the stable jobs","commit_id":"257449cfc2f42fe131bd31d65b826872d36519cc"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"8ac4b32ee9bcb1f6aa2594e985e528e3f2a1e0ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"57596d53_a5f63335","updated":"2025-02-27 15:46:53.000000000","message":"recheck timeout issue","commit_id":"eb0574b5fa7f4c21f413c0d6e87fca2ed8dbf0e3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"9800e8eedf222f2300f3d6418623966c346e6ac0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"7c5979e6_d10de53a","updated":"2025-03-04 07:47:12.000000000","message":"recheck again","commit_id":"e717d27f50270fde272f7a6ee76d9cda3171c622"}],"neutron_tempest_plugin/scenario/test_floatingip.py":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"1b037fd052df9da3766bd939ae2f0963b0c7362c","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u0027b911b124-b6cb-449d-83d9-b34f3665741d\u0027)"},{"line_number":205,"context_line":"    @utils.requires_ext(extension\u003d\u0027extraroute\u0027, service\u003d\u0027network\u0027)"},{"line_number":206,"context_line":"    @testtools.skipUnless("},{"line_number":207,"context_line":"        CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks,"},{"line_number":208,"context_line":"        \"Backend doesn\u0027t enable nested SNAT.\")"},{"line_number":209,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":210,"context_line":"        \"\"\"Check connectivity to an external IP from a nested network.\"\"\""},{"line_number":211,"context_line":"        gateway_external_ip \u003d self._get_external_gateway()"}],"source_content_type":"text/x-python","patch_set":4,"id":"567a01e2_758e3346","side":"PARENT","line":208,"range":{"start_line":206,"start_character":1,"end_line":208,"end_character":46},"updated":"2025-02-11 09:55:18.000000000","message":"I think @ccamposr@redhat.com meant for adding extra testing after removing skip check, so test will execute when both feature enabled/disabled, and make a negative test when disabled iiuc - testing no connectivity when disabled.","commit_id":"5697d2d4bdc3df6362a56183038d370985091772"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"087c87bb1e105df2f00421e1338214f574e0d8e4","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u0027b911b124-b6cb-449d-83d9-b34f3665741d\u0027)"},{"line_number":205,"context_line":"    @utils.requires_ext(extension\u003d\u0027extraroute\u0027, service\u003d\u0027network\u0027)"},{"line_number":206,"context_line":"    @testtools.skipUnless("},{"line_number":207,"context_line":"        CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks,"},{"line_number":208,"context_line":"        \"Backend doesn\u0027t enable nested SNAT.\")"},{"line_number":209,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":210,"context_line":"        \"\"\"Check connectivity to an external IP from a nested network.\"\"\""},{"line_number":211,"context_line":"        gateway_external_ip \u003d self._get_external_gateway()"}],"source_content_type":"text/x-python","patch_set":4,"id":"889c8236_99863bca","side":"PARENT","line":208,"range":{"start_line":206,"start_character":1,"end_line":208,"end_character":46},"in_reply_to":"4be544b1_88314500","updated":"2025-02-14 13:33:57.000000000","message":"Acknowledged","commit_id":"5697d2d4bdc3df6362a56183038d370985091772"},{"author":{"_account_id":29088,"name":"Candido Campos Rivas","email":"ccamposr@redhat.com","username":"ccamposr"},"change_message_id":"8c954d989ad8cbb8df00331d5451969689156d7c","unresolved":true,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    @decorators.idempotent_id(\u0027b911b124-b6cb-449d-83d9-b34f3665741d\u0027)"},{"line_number":205,"context_line":"    @utils.requires_ext(extension\u003d\u0027extraroute\u0027, service\u003d\u0027network\u0027)"},{"line_number":206,"context_line":"    @testtools.skipUnless("},{"line_number":207,"context_line":"        CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks,"},{"line_number":208,"context_line":"        \"Backend doesn\u0027t enable nested SNAT.\")"},{"line_number":209,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":210,"context_line":"        \"\"\"Check connectivity to an external IP from a nested network.\"\"\""},{"line_number":211,"context_line":"        gateway_external_ip \u003d self._get_external_gateway()"}],"source_content_type":"text/x-python","patch_set":4,"id":"4be544b1_88314500","side":"PARENT","line":208,"range":{"start_line":206,"start_character":1,"end_line":208,"end_character":46},"in_reply_to":"567a01e2_758e3346","updated":"2025-02-11 15:43:15.000000000","message":"yes, theb we test the 2 behaviors with the same test","commit_id":"5697d2d4bdc3df6362a56183038d370985091772"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"9b5e6625a00fc3050e8ca8ae3c7f1838fd286861","unresolved":true,"context_lines":[{"line_number":242,"context_line":"        src_server \u003d self._create_server(create_floating_ip\u003dFalse,"},{"line_number":243,"context_line":"                                         network\u003dnetwork)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        # Validate that it can access external gw ip (via nested snat)"},{"line_number":246,"context_line":"        src_server_ip \u003d src_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":247,"context_line":"        ssh_client \u003d ssh.Client(src_server_ip,"},{"line_number":248,"context_line":"                                CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":6,"id":"8da28d25_53f62381","line":245,"range":{"start_line":245,"start_character":10,"end_line":245,"end_character":70},"updated":"2025-02-12 08:51:04.000000000","message":"nit: all looks good, only please update this comment too.","commit_id":"822df2920ec838504d92945cd746778d0c6b4fdb"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"087c87bb1e105df2f00421e1338214f574e0d8e4","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        src_server \u003d self._create_server(create_floating_ip\u003dFalse,"},{"line_number":243,"context_line":"                                         network\u003dnetwork)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"        # Validate that it can access external gw ip (via nested snat)"},{"line_number":246,"context_line":"        src_server_ip \u003d src_server[\u0027port\u0027][\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":247,"context_line":"        ssh_client \u003d ssh.Client(src_server_ip,"},{"line_number":248,"context_line":"                                CONF.validation.image_ssh_user,"}],"source_content_type":"text/x-python","patch_set":6,"id":"b21ff752_f09e37c4","line":245,"range":{"start_line":245,"start_character":10,"end_line":245,"end_character":70},"in_reply_to":"8da28d25_53f62381","updated":"2025-02-14 13:33:57.000000000","message":"Acknowledged","commit_id":"822df2920ec838504d92945cd746778d0c6b4fdb"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"f9c6a802f56c15873e9f4dc1d8454104a415daa6","unresolved":true,"context_lines":[{"line_number":248,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":249,"context_line":"                                pkey\u003dself.keypair[\u0027private_key\u0027],"},{"line_number":250,"context_line":"                                proxy_client\u003dproxy_client)"},{"line_number":251,"context_line":"        if CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks:"},{"line_number":252,"context_line":"            self.check_remote_connectivity(ssh_client,"},{"line_number":253,"context_line":"                                       gateway_external_ip,"},{"line_number":254,"context_line":"                                       servers\u003d[proxy, src_server])"}],"source_content_type":"text/x-python","patch_set":7,"id":"e3b23417_55eb95c4","line":251,"range":{"start_line":251,"start_character":11,"end_line":251,"end_character":74},"updated":"2025-02-13 08:52:58.000000000","message":"*Since whitebox patch was destined to spare conf*:\n\nIf the plan is still to use this test method in whitebox plugin [1] to additionally fetch configuration automatically (as planned originally), then currently this configuration will need to be maintained in CI also for whitebox.\n\nPossible solution I was thinking about is:\n1) Add extra method like `test_\u003cname\u003e` but named `_test_\u003cname\u003e` and move all test method content in it.\nsince unittest (what tempest is based on) executes test on each method starting with \"test\", and also doesn\u0027t take parameters iirc.\n2) make the `_test_\u003cname\u003e` (from section 1) take argument for instance `feature_enabled_bool`, which in this patch would pass it `CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks`.\n3) After this patch merged, then whitebox patch [1] (inheriting same test class) can fetch configuration in automatic way and pass it for `_test_\u003cname\u003e` as parameter and spare conf in CI.\n\nIt can also be done in a separate patch or not, but just notice that current state will not work for the purpose of patch [1].\n\n[1] https://review.opendev.org/c/x/whitebox-neutron-tempest-plugin/+/940908","commit_id":"dc5a7c5857afbc1a413327d78395bbdb34892ece"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"087c87bb1e105df2f00421e1338214f574e0d8e4","unresolved":false,"context_lines":[{"line_number":248,"context_line":"                                CONF.validation.image_ssh_user,"},{"line_number":249,"context_line":"                                pkey\u003dself.keypair[\u0027private_key\u0027],"},{"line_number":250,"context_line":"                                proxy_client\u003dproxy_client)"},{"line_number":251,"context_line":"        if CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks:"},{"line_number":252,"context_line":"            self.check_remote_connectivity(ssh_client,"},{"line_number":253,"context_line":"                                       gateway_external_ip,"},{"line_number":254,"context_line":"                                       servers\u003d[proxy, src_server])"}],"source_content_type":"text/x-python","patch_set":7,"id":"6f41ff7f_b42712d3","line":251,"range":{"start_line":251,"start_character":11,"end_line":251,"end_character":74},"in_reply_to":"e3b23417_55eb95c4","updated":"2025-02-14 13:33:57.000000000","message":"Acknowledged","commit_id":"dc5a7c5857afbc1a413327d78395bbdb34892ece"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"f39e3ea77ed46a41be23efaa48166f8c422a91c7","unresolved":true,"context_lines":[{"line_number":250,"context_line":"                                proxy_client\u003dproxy_client)"},{"line_number":251,"context_line":"        if CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks:"},{"line_number":252,"context_line":"            self.check_remote_connectivity(ssh_client,"},{"line_number":253,"context_line":"                                       gateway_external_ip,"},{"line_number":254,"context_line":"                                       servers\u003d[proxy, src_server])"},{"line_number":255,"context_line":"        else:"},{"line_number":256,"context_line":"            self.check_remote_connectivity(ssh_client,"}],"source_content_type":"text/x-python","patch_set":7,"id":"783886fb_55c7497e","line":253,"range":{"start_line":253,"start_character":39,"end_line":253,"end_character":59},"updated":"2025-02-12 13:53:33.000000000","message":"Please fix the indentation.","commit_id":"dc5a7c5857afbc1a413327d78395bbdb34892ece"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"087c87bb1e105df2f00421e1338214f574e0d8e4","unresolved":false,"context_lines":[{"line_number":250,"context_line":"                                proxy_client\u003dproxy_client)"},{"line_number":251,"context_line":"        if CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks:"},{"line_number":252,"context_line":"            self.check_remote_connectivity(ssh_client,"},{"line_number":253,"context_line":"                                       gateway_external_ip,"},{"line_number":254,"context_line":"                                       servers\u003d[proxy, src_server])"},{"line_number":255,"context_line":"        else:"},{"line_number":256,"context_line":"            self.check_remote_connectivity(ssh_client,"}],"source_content_type":"text/x-python","patch_set":7,"id":"87ceac29_72880b4e","line":253,"range":{"start_line":253,"start_character":39,"end_line":253,"end_character":59},"in_reply_to":"783886fb_55c7497e","updated":"2025-02-14 13:33:57.000000000","message":"Acknowledged","commit_id":"dc5a7c5857afbc1a413327d78395bbdb34892ece"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"20501bed8f4003fdbd19fc8e84ae3f4dfc9f7190","unresolved":true,"context_lines":[{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @decorators.idempotent_id(\u0027b911b124-b6cb-449d-83d9-b34f3665741d\u0027)"},{"line_number":260,"context_line":"    @utils.requires_ext(extension\u003d\u0027extraroute\u0027, service\u003d\u0027network\u0027)"},{"line_number":261,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":262,"context_line":"        feature_enabled_bool \u003d ("},{"line_number":263,"context_line":"            CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks"},{"line_number":264,"context_line":"        )"}],"source_content_type":"text/x-python","patch_set":13,"id":"aeef01f6_8696cbd2","line":261,"updated":"2025-02-28 23:06:41.000000000","message":"The test is failing in ML2/OVN. Or the test is incorrectly implemented or the functionality is not working (or maybe is incorrectly configured).","commit_id":"eb0574b5fa7f4c21f413c0d6e87fca2ed8dbf0e3"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0f6392826ec295c7a0f50a372f09df439b83bf83","unresolved":true,"context_lines":[{"line_number":254,"context_line":"            self.check_remote_connectivity(ssh_client,"},{"line_number":255,"context_line":"                                           gateway_external_ip,"},{"line_number":256,"context_line":"                                           should_succeed\u003dFalse,"},{"line_number":257,"context_line":"                                           servers\u003d[proxy, src_server])"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"    @decorators.idempotent_id(\u0027b911b124-b6cb-449d-83d9-b34f3665741d\u0027)"},{"line_number":260,"context_line":"    @utils.requires_ext(extension\u003d\u0027extraroute\u0027, service\u003d\u0027network\u0027)"}],"source_content_type":"text/x-python","patch_set":18,"id":"4a92e51d_1962d9ed","line":257,"updated":"2025-03-07 09:35:22.000000000","message":"you could do it without if...else like:\n\n    self.check_remote_connectivity(ssh_client,\n                                   gateway_external_ip,\n                                   should_succeed\u003dfeature_enabled_bool,\n                                   servers\u003d[proxy, src_server])","commit_id":"dddfe614d687ac862cda642cb3b82e91d33c223b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"0f6392826ec295c7a0f50a372f09df439b83bf83","unresolved":true,"context_lines":[{"line_number":259,"context_line":"    @decorators.idempotent_id(\u0027b911b124-b6cb-449d-83d9-b34f3665741d\u0027)"},{"line_number":260,"context_line":"    @utils.requires_ext(extension\u003d\u0027extraroute\u0027, service\u003d\u0027network\u0027)"},{"line_number":261,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":262,"context_line":"        feature_enabled_bool \u003d ("},{"line_number":263,"context_line":"            CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks"},{"line_number":264,"context_line":"        )"},{"line_number":265,"context_line":"        self._test_nested_snat_external_ip(feature_enabled_bool)"}],"source_content_type":"text/x-python","patch_set":18,"id":"74a7a72b_7f2e30d2","line":262,"updated":"2025-03-07 09:35:22.000000000","message":"what is the reason of having this addional parameter? Can\u0027t you simply use ``CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks`` inside the _test_nested_snat_external_ip() method?","commit_id":"dddfe614d687ac862cda642cb3b82e91d33c223b"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"9e366cfb2d2cd0da933f391fd34c48f9c88a3cf4","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    @decorators.idempotent_id(\u0027b911b124-b6cb-449d-83d9-b34f3665741d\u0027)"},{"line_number":260,"context_line":"    @utils.requires_ext(extension\u003d\u0027extraroute\u0027, service\u003d\u0027network\u0027)"},{"line_number":261,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":262,"context_line":"        feature_enabled_bool \u003d ("},{"line_number":263,"context_line":"            CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks"},{"line_number":264,"context_line":"        )"},{"line_number":265,"context_line":"        self._test_nested_snat_external_ip(feature_enabled_bool)"}],"source_content_type":"text/x-python","patch_set":18,"id":"cff70bfe_6e8a3a5a","line":262,"in_reply_to":"74a7a72b_7f2e30d2","updated":"2025-03-07 09:46:11.000000000","message":"The parameter is also used in whitebox to spare the configruation: https://review.opendev.org/c/x/whitebox-neutron-tempest-plugin/+/940908","commit_id":"dddfe614d687ac862cda642cb3b82e91d33c223b"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"123ec9da52867a348dccc641b531b8bf2d2ada17","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    @decorators.idempotent_id(\u0027b911b124-b6cb-449d-83d9-b34f3665741d\u0027)"},{"line_number":260,"context_line":"    @utils.requires_ext(extension\u003d\u0027extraroute\u0027, service\u003d\u0027network\u0027)"},{"line_number":261,"context_line":"    def test_nested_snat_external_ip(self):"},{"line_number":262,"context_line":"        feature_enabled_bool \u003d ("},{"line_number":263,"context_line":"            CONF.neutron_plugin_options.snat_rules_apply_to_nested_networks"},{"line_number":264,"context_line":"        )"},{"line_number":265,"context_line":"        self._test_nested_snat_external_ip(feature_enabled_bool)"}],"source_content_type":"text/x-python","patch_set":18,"id":"fa6cf7cd_742af3c0","line":262,"in_reply_to":"cff70bfe_6e8a3a5a","updated":"2025-03-07 14:02:17.000000000","message":"ok","commit_id":"dddfe614d687ac862cda642cb3b82e91d33c223b"}],"zuul.d/master_jobs.yaml":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"88d90b0f20e82368368191eb9374bcae4b2054ef","unresolved":true,"context_lines":[{"line_number":691,"context_line":"              available_type_drivers: local,flat,vlan,geneve"},{"line_number":692,"context_line":"              is_igmp_snooping_enabled: True"},{"line_number":693,"context_line":"              firewall_driver: ovn"},{"line_number":694,"context_line":"              snat_rules_apply_to_nested_networks: true"},{"line_number":695,"context_line":"      zuul_copy_output:"},{"line_number":696,"context_line":"        \u0027{{ devstack_base_dir }}/data/ovs\u0027: \u0027logs\u0027"},{"line_number":697,"context_line":"        \u0027{{ devstack_base_dir }}/data/ovn\u0027: \u0027logs\u0027"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"f95afc59_774ac25f","line":694,"range":{"start_line":694,"start_character":51,"end_line":694,"end_character":55},"updated":"2025-02-27 11:10:33.000000000","message":"This will break all stable branches jobs","commit_id":"92a81f88e1c6acd8210df1c03c704a2cf4d75fe9"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"b65c7bf533b19d33fbc06a36cfb2f50e458ed1f2","unresolved":true,"context_lines":[{"line_number":691,"context_line":"              available_type_drivers: local,flat,vlan,geneve"},{"line_number":692,"context_line":"              is_igmp_snooping_enabled: True"},{"line_number":693,"context_line":"              firewall_driver: ovn"},{"line_number":694,"context_line":"              snat_rules_apply_to_nested_networks: true"},{"line_number":695,"context_line":"      zuul_copy_output:"},{"line_number":696,"context_line":"        \u0027{{ devstack_base_dir }}/data/ovs\u0027: \u0027logs\u0027"},{"line_number":697,"context_line":"        \u0027{{ devstack_base_dir }}/data/ovn\u0027: \u0027logs\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"31d2f0fc_e651b8df","line":694,"range":{"start_line":694,"start_character":14,"end_line":694,"end_character":49},"updated":"2025-02-28 23:09:01.000000000","message":"The config option is named ``ovn_router_indirect_snat`` [1]\n\n[1]https://review.opendev.org/c/openstack/neutron/+/926495/6/neutron/conf/plugins/ml2/drivers/ovn/ovn_conf.py#232","commit_id":"eb0574b5fa7f4c21f413c0d6e87fca2ed8dbf0e3"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"6a7af430220ba6585501470b28ca44fdeff9a345","unresolved":true,"context_lines":[{"line_number":691,"context_line":"              available_type_drivers: local,flat,vlan,geneve"},{"line_number":692,"context_line":"              is_igmp_snooping_enabled: True"},{"line_number":693,"context_line":"              firewall_driver: ovn"},{"line_number":694,"context_line":"              snat_rules_apply_to_nested_networks: true"},{"line_number":695,"context_line":"      zuul_copy_output:"},{"line_number":696,"context_line":"        \u0027{{ devstack_base_dir }}/data/ovs\u0027: \u0027logs\u0027"},{"line_number":697,"context_line":"        \u0027{{ devstack_base_dir }}/data/ovn\u0027: \u0027logs\u0027"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"359173e3_94342927","line":694,"range":{"start_line":694,"start_character":14,"end_line":694,"end_character":49},"in_reply_to":"31d2f0fc_e651b8df","updated":"2025-02-28 23:14:47.000000000","message":"Sorry, what I mean is that this n-t-p plugin option is correct but is missing the Neutron config option ``ovn_router_indirect_snat\u003dTrue``, that by default is False. So under the ``NEUTRON_CORE_PLUGIN_CONF`` section, it is needed:\n```\n/$NEUTRON_CORE_PLUGIN_CONF:\n  ovn:\n    ovn_router_indirect_snat: true\n```","commit_id":"eb0574b5fa7f4c21f413c0d6e87fca2ed8dbf0e3"}]}