)]}'
{"neutron_tempest_plugin/fwaas/scenario/test_fwaas_v2.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"af8fe921280e0582c757e81b8f055b28227b6e4d","unresolved":true,"context_lines":[{"line_number":138,"context_line":"            subnet_namestart \u003d \u0027subnet-%s\u0027 % namestart_prefix"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            network_namestart \u003d \u0027network-smoke-\u0027"},{"line_number":141,"context_line":"            subnet_namestart \u003d \u0027subnet-smoke\u0027"},{"line_number":142,"context_line":"        network \u003d self.create_network(namestart\u003dnetwork_namestart)"},{"line_number":143,"context_line":"        subnet \u003d self.create_subnet("},{"line_number":144,"context_line":"            network\u003dnetwork, namestart\u003dsubnet_namestart)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1cbac51a_e766359f","line":141,"updated":"2026-03-11 13:16:00.000000000","message":"nitty nit: you missed \"-\" in the prefix here\n\nAlso you could do something like:\n\n    def _create_network_subnet(self, prefix\u003d\"smoke-\"):\n        network_prefix \u003d \"network-%s\" % prefix\n        subnet_prefix \u003d \"subnet-%s\" % prefix","commit_id":"480505f9add46f8de378c4589a9c6cd74c750638"},{"author":{"_account_id":34777,"name":"Fiorella Yanac","email":"fyanac@redhat.com","username":"fyanac"},"change_message_id":"5c48f9f3b77709f06a81bb097a5e4baa4e84295a","unresolved":false,"context_lines":[{"line_number":138,"context_line":"            subnet_namestart \u003d \u0027subnet-%s\u0027 % namestart_prefix"},{"line_number":139,"context_line":"        else:"},{"line_number":140,"context_line":"            network_namestart \u003d \u0027network-smoke-\u0027"},{"line_number":141,"context_line":"            subnet_namestart \u003d \u0027subnet-smoke\u0027"},{"line_number":142,"context_line":"        network \u003d self.create_network(namestart\u003dnetwork_namestart)"},{"line_number":143,"context_line":"        subnet \u003d self.create_subnet("},{"line_number":144,"context_line":"            network\u003dnetwork, namestart\u003dsubnet_namestart)"}],"source_content_type":"text/x-python","patch_set":4,"id":"47a07279_bd8fca46","line":141,"in_reply_to":"1cbac51a_e766359f","updated":"2026-03-11 16:02:36.000000000","message":"Done","commit_id":"480505f9add46f8de378c4589a9c6cd74c750638"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"af8fe921280e0582c757e81b8f055b28227b6e4d","unresolved":true,"context_lines":[{"line_number":352,"context_line":"        router_port_id \u003d resp[\u0027port_id\u0027]"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        security_group \u003d self.create_security_group("},{"line_number":355,"context_line":"            namestart\u003d\u0027secgroup-fwaas-ssh-fip\u0027)"},{"line_number":356,"context_line":"        server, keys \u003d self._create_server("},{"line_number":357,"context_line":"            network, security_group\u003dsecurity_group)"},{"line_number":358,"context_line":"        floating_ip \u003d self.create_floating_ip(server, pub_network_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9916b051_e7a7ad51","line":355,"updated":"2026-03-11 13:16:00.000000000","message":"In case of OVN backend this may be a bit problematic as by default SG is stateful and ACLs created by FWaaS are stateless. This may cause issues like e.g. conntrack \"leakeage\", see: https://issues.redhat.com/browse/FDP-3282 for more details.\n\nSo I would advice to either disable port security on the VM port in this case or create stateless SG","commit_id":"480505f9add46f8de378c4589a9c6cd74c750638"},{"author":{"_account_id":34777,"name":"Fiorella Yanac","email":"fyanac@redhat.com","username":"fyanac"},"change_message_id":"f58cf473b111ad199cb2e25bf471720bf4aff7cc","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        router_port_id \u003d resp[\u0027port_id\u0027]"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        security_group \u003d self.create_security_group("},{"line_number":355,"context_line":"            namestart\u003d\u0027secgroup-fwaas-ssh-fip\u0027)"},{"line_number":356,"context_line":"        server, keys \u003d self._create_server("},{"line_number":357,"context_line":"            network, security_group\u003dsecurity_group)"},{"line_number":358,"context_line":"        floating_ip \u003d self.create_floating_ip(server, pub_network_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9c41a1c1_bf25de2d","line":355,"in_reply_to":"2d020e83_6ed8a9e5","updated":"2026-03-11 16:02:50.000000000","message":"Done","commit_id":"480505f9add46f8de378c4589a9c6cd74c750638"},{"author":{"_account_id":34777,"name":"Fiorella Yanac","email":"fyanac@redhat.com","username":"fyanac"},"change_message_id":"5c48f9f3b77709f06a81bb097a5e4baa4e84295a","unresolved":true,"context_lines":[{"line_number":352,"context_line":"        router_port_id \u003d resp[\u0027port_id\u0027]"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"        security_group \u003d self.create_security_group("},{"line_number":355,"context_line":"            namestart\u003d\u0027secgroup-fwaas-ssh-fip\u0027)"},{"line_number":356,"context_line":"        server, keys \u003d self._create_server("},{"line_number":357,"context_line":"            network, security_group\u003dsecurity_group)"},{"line_number":358,"context_line":"        floating_ip \u003d self.create_floating_ip(server, pub_network_id)"}],"source_content_type":"text/x-python","patch_set":4,"id":"2d020e83_6ed8a9e5","line":355,"in_reply_to":"9916b051_e7a7ad51","updated":"2026-03-11 16:02:36.000000000","message":"Ok, I\u0027ve set port_security_enabled\u003dFalse in the network","commit_id":"480505f9add46f8de378c4589a9c6cd74c750638"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"af8fe921280e0582c757e81b8f055b28227b6e4d","unresolved":true,"context_lines":[{"line_number":409,"context_line":"        self.insert_firewall_rule_in_policy_and_wait("},{"line_number":410,"context_line":"            firewall_group_id\u003dfw_group[\u0027id\u0027],"},{"line_number":411,"context_line":"            firewall_rule_id\u003dfw_allow_ssh_rule[\u0027id\u0027],"},{"line_number":412,"context_line":"            firewall_policy_id\u003dfw_policy[\u0027id\u0027])"},{"line_number":413,"context_line":"        LOG.debug(\u0027Added allow SSH rule to ingress policy\u0027)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        self.check_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"e8c93e15_53630481","line":412,"updated":"2026-03-11 13:16:00.000000000","message":"with OVN driver this actually only works because SG which VM port is using is stateful (see my comment above). So please add rule for the egress traffic as well when backend is OVN. Similar things are already done in this file e.g. in lines 298 to 310","commit_id":"480505f9add46f8de378c4589a9c6cd74c750638"},{"author":{"_account_id":34777,"name":"Fiorella Yanac","email":"fyanac@redhat.com","username":"fyanac"},"change_message_id":"f58cf473b111ad199cb2e25bf471720bf4aff7cc","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        self.insert_firewall_rule_in_policy_and_wait("},{"line_number":410,"context_line":"            firewall_group_id\u003dfw_group[\u0027id\u0027],"},{"line_number":411,"context_line":"            firewall_rule_id\u003dfw_allow_ssh_rule[\u0027id\u0027],"},{"line_number":412,"context_line":"            firewall_policy_id\u003dfw_policy[\u0027id\u0027])"},{"line_number":413,"context_line":"        LOG.debug(\u0027Added allow SSH rule to ingress policy\u0027)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        self.check_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"9989e41b_78ada775","line":412,"in_reply_to":"a6c9bc24_bfe4a200","updated":"2026-03-11 16:02:50.000000000","message":"Done","commit_id":"480505f9add46f8de378c4589a9c6cd74c750638"},{"author":{"_account_id":34777,"name":"Fiorella Yanac","email":"fyanac@redhat.com","username":"fyanac"},"change_message_id":"5c48f9f3b77709f06a81bb097a5e4baa4e84295a","unresolved":true,"context_lines":[{"line_number":409,"context_line":"        self.insert_firewall_rule_in_policy_and_wait("},{"line_number":410,"context_line":"            firewall_group_id\u003dfw_group[\u0027id\u0027],"},{"line_number":411,"context_line":"            firewall_rule_id\u003dfw_allow_ssh_rule[\u0027id\u0027],"},{"line_number":412,"context_line":"            firewall_policy_id\u003dfw_policy[\u0027id\u0027])"},{"line_number":413,"context_line":"        LOG.debug(\u0027Added allow SSH rule to ingress policy\u0027)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"        self.check_connectivity("}],"source_content_type":"text/x-python","patch_set":4,"id":"a6c9bc24_bfe4a200","line":412,"in_reply_to":"e8c93e15_53630481","updated":"2026-03-11 16:02:36.000000000","message":"Ok, thank you. I\u0027ve added the egress rule.","commit_id":"480505f9add46f8de378c4589a9c6cd74c750638"}]}