)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"a50f2cadf81377a249e47e0715c56e0364c4ee88","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9170e7d7_ad58174d","updated":"2026-04-15 14:12:10.000000000","message":"recheck neutron-tempest-plugin-ovn-ubuntu-jammy-2025-1","commit_id":"4f992bc48da075ac0bb6a24e11decb46b747e237"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"7ddb30e2314bbcd2af866ce8cbf843137100e760","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"c1f5dc07_d4d8cc93","updated":"2026-04-21 14:36:15.000000000","message":"-1 mainly because of the `create_server` comment.","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"490d8b1d6e056bd44aefd550343b6fe67ee54b71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"06d2e851_6a866e51","updated":"2026-04-19 13:52:46.000000000","message":"recheck","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"654f8ae85626b3499a7c7968a66221b0e18d1910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e1189c25_03d69ead","updated":"2026-04-19 12:10:59.000000000","message":"recheck RETRY_LIMIT","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"d08183cc39c68e0ff018964784a25aeef3718289","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"41898bc7_a878fce3","updated":"2026-04-17 14:28:42.000000000","message":"recheck unrelated failures","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"bfd213050a45740dea2064078d95d851e682530e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6d483a9e_68e31388","updated":"2026-04-19 10:42:14.000000000","message":"recheck unrelated failures","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"3eebc9582f667942396481e07eb4b4e8be70ccb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"8c79792e_0f67aee6","updated":"2026-04-28 20:32:29.000000000","message":"recheck","commit_id":"42d0035c9e3cff8d38cffb2b044e85d3214dc796"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"8d9fa58ec0b41bc137241940248101a392240666","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"39f677c9_dd30dbfe","updated":"2026-05-06 13:46:44.000000000","message":"recheck","commit_id":"1794e07ce55224561c516e7890aa3f03193382a0"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"fab4f585664d5897739d5a52a23ef78b327441bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f717adb2_10937910","updated":"2026-04-29 08:32:58.000000000","message":"recheck","commit_id":"1794e07ce55224561c516e7890aa3f03193382a0"}],"neutron_tempest_plugin/scenario/test_allowed_address_pairs.py":[{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"e2ffc1de60c78e65b04ac3edd7a3aff57f15948a","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Create security group with admin privileges"},{"line_number":38,"context_line":"        cls.secgroup \u003d cls.create_security_group("},{"line_number":39,"context_line":"            name\u003ddata_utils.rand_name(\u0027secgroup\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Execute funcs to achieve ssh and ICMP capabilities"},{"line_number":42,"context_line":"        cls.create_loginable_secgroup_rule(secgroup_id\u003dcls.secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f61fcb5_85ece5ff","line":39,"range":{"start_line":38,"start_character":8,"end_line":39,"end_character":50},"updated":"2026-04-15 10:41:08.000000000","message":"Hi!! o/ Just trying to understand:\n\nIs this security group actually created with admin privileges? there is no explicit client\u003dcls.os_admin.network_client set as argument in create_security_group and BaseTempestTestCase seems to inherit from BaseNetworkTest (Not BaseAdminNetworkTest), which seems to be using primary (see declaration of client [0] and definition of it [1]) and not admin credentials by default.\n\n[0] https://opendev.org/openstack/neutron-tempest-plugin/src/commit/823b1a05bf53715a9d353818c6c6987f1e20d5dd/neutron_tempest_plugin/api/base.py#L948\n[1] https://opendev.org/openstack/neutron-tempest-plugin/src/commit/823b1a05bf53715a9d353818c6c6987f1e20d5dd/neutron_tempest_plugin/api/base.py#L107","commit_id":"9b35863d0b08880173010c84fc11e94b1f354583"},{"author":{"_account_id":32586,"name":"Elvira García Ruiz","display_name":"Elvira","email":"egarciar@redhat.com","username":"elvira"},"change_message_id":"8675955c67f96fa3cbfb966c550f2694536fc05e","unresolved":true,"context_lines":[{"line_number":35,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Create security group with admin privileges"},{"line_number":38,"context_line":"        cls.secgroup \u003d cls.create_security_group("},{"line_number":39,"context_line":"            name\u003ddata_utils.rand_name(\u0027secgroup\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Execute funcs to achieve ssh and ICMP capabilities"},{"line_number":42,"context_line":"        cls.create_loginable_secgroup_rule(secgroup_id\u003dcls.secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"cd2d1685_2b6e66a3","line":39,"range":{"start_line":38,"start_character":8,"end_line":39,"end_character":50},"in_reply_to":"7f61fcb5_85ece5ff","updated":"2026-04-15 11:05:05.000000000","message":"(typo on url: On [0] above I mentioned like 948 but I wanted to mean L954, my bad)","commit_id":"9b35863d0b08880173010c84fc11e94b1f354583"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"8c6d2fbf78ba04f905c3beb6dda684f14a361fdd","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        cls.keypair \u003d cls.create_keypair()"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        # Create security group with admin privileges"},{"line_number":38,"context_line":"        cls.secgroup \u003d cls.create_security_group("},{"line_number":39,"context_line":"            name\u003ddata_utils.rand_name(\u0027secgroup\u0027))"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        # Execute funcs to achieve ssh and ICMP capabilities"},{"line_number":42,"context_line":"        cls.create_loginable_secgroup_rule(secgroup_id\u003dcls.secgroup[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"af102676_83fc62c0","line":39,"range":{"start_line":38,"start_character":8,"end_line":39,"end_character":50},"in_reply_to":"cd2d1685_2b6e66a3","updated":"2026-04-15 11:30:31.000000000","message":"Thanks for catching it, removed the comment","commit_id":"9b35863d0b08880173010c84fc11e94b1f354583"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"7ddb30e2314bbcd2af866ce8cbf843137100e760","unresolved":true,"context_lines":[{"line_number":40,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":41,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_server_on_port(self, port):"},{"line_number":44,"context_line":"        server \u003d self.create_server("},{"line_number":45,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"},{"line_number":46,"context_line":"            image_ref\u003dCONF.compute.image_ref,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bd04718b_9df986f4","line":43,"updated":"2026-04-21 14:36:15.000000000","message":"I think this method is redundant. You could just call `self.create_server` from lines 71 and 72.\nAt least, `create_server` already calls both `wait_for_server_active` and `wait_for_guest_os_ready`:\nhttps://opendev.org/openstack/neutron-tempest-plugin/src/branch/master/neutron_tempest_plugin/scenario/base.py#L151-L152","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":37280,"name":"Renjing Xiao","display_name":"Renjing Xiao","email":"rxiao@redhat.com","username":"rxiao"},"change_message_id":"fab4f585664d5897739d5a52a23ef78b327441bc","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":41,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_server_on_port(self, port):"},{"line_number":44,"context_line":"        server \u003d self.create_server("},{"line_number":45,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"},{"line_number":46,"context_line":"            image_ref\u003dCONF.compute.image_ref,"}],"source_content_type":"text/x-python","patch_set":3,"id":"79c3b6fa_cc764f85","line":43,"in_reply_to":"bd04718b_9df986f4","updated":"2026-04-29 08:32:58.000000000","message":"Acknowledged","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"48a9ebe0a0de33a88f37bdd00dd406e97eede87b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        cls.router \u003d cls.create_router_by_client()"},{"line_number":41,"context_line":"        cls.create_router_interface(cls.router[\u0027id\u0027], cls.subnet[\u0027id\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def _create_server_on_port(self, port):"},{"line_number":44,"context_line":"        server \u003d self.create_server("},{"line_number":45,"context_line":"            flavor_ref\u003dCONF.compute.flavor_ref,"},{"line_number":46,"context_line":"            image_ref\u003dCONF.compute.image_ref,"}],"source_content_type":"text/x-python","patch_set":3,"id":"21c3bd84_367f879f","line":43,"in_reply_to":"bd04718b_9df986f4","updated":"2026-05-06 16:15:15.000000000","message":"Done","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"7ddb30e2314bbcd2af866ce8cbf843137100e760","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        server_2 \u003d self._create_server_on_port(port_2)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        ssh_client \u003d self._get_ssh_client(port_1)"},{"line_number":75,"context_line":"        self.check_remote_connectivity("},{"line_number":76,"context_line":"            ssh_client,"},{"line_number":77,"context_line":"            port_2[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":78,"context_line":"            servers\u003d[server_1, server_2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"2987c6db_9978c44c","line":75,"updated":"2026-04-21 14:36:15.000000000","message":"IIUC, this test checks that port creation using the same subnet within AAP works fine, which would cover the bug it tries to cover [1], but it does not really check connectivity using any IP address from the configured AAP.\nIf you want to test that, the test should be a bit more complex. \nYou can look at the WNTP tests that use this method [2] (they don\u0027t cover this bug, because they don\u0027t set the port\u0027s AAP to its subnet CIDR).\nBut the changes to test this with NTP could be too much for covering this bug.\nI\u0027m not sure, I just wanted to share my thoughts :)\n\n[1] https://bugs.launchpad.net/neutron/+bug/2131928\n[2] https://opendev.org/x/whitebox-neutron-tempest-plugin/src/branch/master/whitebox_neutron_tempest_plugin/tests/scenario/test_dvr_ovn.py#L772","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"bdc1e2b66bbfd4674d32e80b3395547ed7f5415f","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        server_2 \u003d self._create_server_on_port(port_2)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        ssh_client \u003d self._get_ssh_client(port_1)"},{"line_number":75,"context_line":"        self.check_remote_connectivity("},{"line_number":76,"context_line":"            ssh_client,"},{"line_number":77,"context_line":"            port_2[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027],"},{"line_number":78,"context_line":"            servers\u003d[server_1, server_2])"}],"source_content_type":"text/x-python","patch_set":3,"id":"8db58e2d_5d08f768","line":75,"in_reply_to":"2987c6db_9978c44c","updated":"2026-04-21 14:40:40.000000000","message":"Replace:\nBut the changes to test this with NTP could be too much for covering this bug.\nWith:\nBut the changes to test this with NTP could be too much for covering AAP connectivity.","commit_id":"0fc707e6ec6b05daf11ca5050fb9afd499726c47"}]}