)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"4856dca5362dbab64bb0e0315e4c77222178182d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68774ceb_6fff5d11","updated":"2026-07-20 09:42:16.000000000","message":"Hi Edu, just writing here about what we chatted for the record and possible feedback from more peers.\n\nAs we chatted already, how about exposing configuration for CI such as `is_bgp_setup` (or any name) and then according to related condition, setting router creation with EVPN VNI, and its interface to subnet with `advertise_host`, for the commonly shared resources defined in base classes and base.py for many tests\n(it may simplify the testing and stating differences every time we want to test EVPN or not).\n\nMaybe we could have methods relevant, whether `ping_ip_address`, `check_connectivity`, `check_remote_connectivity` adjusted according to same `is_bgp_setup` condition so each test file adjusts will be kept minimal\n(they may not need changes but only used as examples for common checks in many tests).","commit_id":"85b2258db2b0f1a12e506069ea0646b3ba8da102"},{"author":{"_account_id":33341,"name":"Maor Blaustein","email":"mblue@redhat.com","username":"blue"},"change_message_id":"73519e4015c252e25fee08629495fdf9c0c0f769","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d9f30c29_7fd81509","updated":"2026-07-24 10:18:24.000000000","message":"Fine by me, thank you for these changes.\nI can explore it later as a seperate effort, should be a standalone patch since could affect substantial amount of tests from NTP.","commit_id":"60ece33977211debd77ff564581f561430bef86d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"de514c5c3a46c234754a4c1360838f81b8da6fb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5923cc28_5e33956c","updated":"2026-07-24 11:59:15.000000000","message":"The code LGTM","commit_id":"60ece33977211debd77ff564581f561430bef86d"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"f4d0609b3d3cd16ea8b1d5a7ba6c28c65db19925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d78f7840_9a0a7674","updated":"2026-07-23 12:43:40.000000000","message":"recheck neutron-tempest-plugin-openvswitch-2025-1","commit_id":"60ece33977211debd77ff564581f561430bef86d"}],"neutron_tempest_plugin/scenario/test_evpn.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"de514c5c3a46c234754a4c1360838f81b8da6fb5","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @decorators.idempotent_id(\u0027b2c3d4e5-f6a7-8901-bcde-f12345678901\u0027)"},{"line_number":95,"context_line":"    def test_evpn_server_connectivity_stop_start(self):"},{"line_number":96,"context_line":"        server, _, private_ip \u003d self._create_evpn_server()"},{"line_number":97,"context_line":"        self._check_evpn_connectivity(private_ip)"},{"line_number":98,"context_line":"        self.os_primary.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":99,"context_line":"        self.wait_for_server_status(server, \u0027SHUTOFF\u0027)"},{"line_number":100,"context_line":"        self.ping_ip_address(private_ip, should_succeed\u003dFalse)"},{"line_number":101,"context_line":"        self.os_primary.servers_client.start_server(server[\u0027id\u0027])"},{"line_number":102,"context_line":"        self.wait_for_server_active(server)"},{"line_number":103,"context_line":"        self._check_evpn_connectivity(private_ip)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @decorators.idempotent_id(\u0027c3d4e5f6-a7b8-9012-cdef-123456789012\u0027)"},{"line_number":106,"context_line":"    def test_evpn_server_connectivity_reboot(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5ee226de_9ec60264","line":103,"range":{"start_line":96,"start_character":0,"end_line":103,"end_character":49},"updated":"2026-07-24 11:59:15.000000000","message":"No action required: There are multiple tests that have the same pattern and can be generalized:\n```\ndef _test_evpn_server_connectivity_action_helper(self, action, return_action, expected_state):\n        server, _, private_ip \u003d self._create_evpn_server()\n        self._check_evpn_connectivity(private_ip)\n        action(server[\u0027id\u0027])\n        self.wait_for_server_status(server, expected_state)\n        self.ping_ip_address(private_ip, should_succeed\u003dFalse)\n        return_action(server[\u0027id\u0027])\n        self.wait_for_server_active(server)\n        self._check_evpn_connectivity(private_ip)\n        \ndef test_evpn_server_connectivity_stop_start(self):\n    self._test_evpn_server_connectivity_action_helper(\n        action\u003dself.os_primary.servers_client.stop_server,\n        return_action\u003dself.os_primary.servers_client.start_server,\n        expected_state\u003d\u0027SHUTOFF\u0027)\n        \ndef test_evpn_server_connectivity_pause_unpause(self):\n    self._test_evpn_server_connectivity_action_helper(\n        action\u003dself.os_primary.servers_client.pause_server,\n        return_action\u003dself.os_primary.servers_client.unpause_server,\n        expected_state\u003d\u0027PAUSED\u0027)\n```","commit_id":"60ece33977211debd77ff564581f561430bef86d"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"1ca0847ad949c1b2a7a20d88a9056ddabc1d29fe","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    @decorators.idempotent_id(\u0027b2c3d4e5-f6a7-8901-bcde-f12345678901\u0027)"},{"line_number":95,"context_line":"    def test_evpn_server_connectivity_stop_start(self):"},{"line_number":96,"context_line":"        server, _, private_ip \u003d self._create_evpn_server()"},{"line_number":97,"context_line":"        self._check_evpn_connectivity(private_ip)"},{"line_number":98,"context_line":"        self.os_primary.servers_client.stop_server(server[\u0027id\u0027])"},{"line_number":99,"context_line":"        self.wait_for_server_status(server, \u0027SHUTOFF\u0027)"},{"line_number":100,"context_line":"        self.ping_ip_address(private_ip, should_succeed\u003dFalse)"},{"line_number":101,"context_line":"        self.os_primary.servers_client.start_server(server[\u0027id\u0027])"},{"line_number":102,"context_line":"        self.wait_for_server_active(server)"},{"line_number":103,"context_line":"        self._check_evpn_connectivity(private_ip)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    @decorators.idempotent_id(\u0027c3d4e5f6-a7b8-9012-cdef-123456789012\u0027)"},{"line_number":106,"context_line":"    def test_evpn_server_connectivity_reboot(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"df69f424_2b10daf6","line":103,"range":{"start_line":96,"start_character":0,"end_line":103,"end_character":49},"in_reply_to":"5ee226de_9ec60264","updated":"2026-07-24 13:06:34.000000000","message":"Done","commit_id":"60ece33977211debd77ff564581f561430bef86d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"de514c5c3a46c234754a4c1360838f81b8da6fb5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"be02acf8_c200ffed","line":195,"updated":"2026-07-24 11:59:15.000000000","message":"An idea for another easy test - reuse the private IP.\n\n - create a server\n - check the private IP can be reached\n - delete the server\n - create another server with the same IP\n - check the private IP can be reached","commit_id":"60ece33977211debd77ff564581f561430bef86d"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"1ca0847ad949c1b2a7a20d88a9056ddabc1d29fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"666be28d_ec606493","line":195,"in_reply_to":"be02acf8_c200ffed","updated":"2026-07-24 13:06:34.000000000","message":"done with test_evpn_server_reuse_port","commit_id":"60ece33977211debd77ff564581f561430bef86d"}]}