)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4add3eeb1cb778a776f38d700d7f806d6eec1a74","unresolved":true,"context_lines":[{"line_number":14,"context_line":"expecting it to fail."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Assisted-By: Claude Opus 4.6 High"},{"line_number":17,"context_line":"Related-Bug: #2144617"},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/998677"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I287f2246cbf3288ad607e55e02574db52869e323"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c927ec3d_f7aea8f9","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":21},"updated":"2026-07-29 15:13:15.000000000","message":"Wrong bug - should be 2161353","commit_id":"427da208b47889a5c3c2c0c08a504a50d84f0f04"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5c19184cf844b01221a4b5bfe0fe070ac94d087","unresolved":false,"context_lines":[{"line_number":14,"context_line":"expecting it to fail."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Assisted-By: Claude Opus 4.6 High"},{"line_number":17,"context_line":"Related-Bug: #2144617"},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/neutron/+/998677"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I287f2246cbf3288ad607e55e02574db52869e323"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b23046a6_0d3b7bd9","line":17,"range":{"start_line":17,"start_character":14,"end_line":17,"end_character":21},"in_reply_to":"c927ec3d_f7aea8f9","updated":"2026-08-17 17:03:27.000000000","message":"Done","commit_id":"427da208b47889a5c3c2c0c08a504a50d84f0f04"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"f184dd9312196a7d79b24be5728e7bcc5f54c697","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75cbf3e0_084248ba","updated":"2026-08-18 11:02:47.000000000","message":"Apart from the nit comment on the cleanups, the patch looks good to me.","commit_id":"427da208b47889a5c3c2c0c08a504a50d84f0f04"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"13250811f211d9776877412cb6047b275fc9ebb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2a59b424_53a76946","updated":"2026-08-17 11:53:41.000000000","message":"check experimental","commit_id":"427da208b47889a5c3c2c0c08a504a50d84f0f04"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"1bca160a4fc36f43b5c14a361ce44ea2a2254ed7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"53a6c30f_22c611fe","updated":"2026-08-17 17:03:47.000000000","message":"check experimental","commit_id":"dd808a1a23d79b616f422324830665327fcbaeac"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"2768905ffb59d8ae4d8dc7b05df8cdb506e8a1be","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5dcd4619_582496ac","updated":"2026-09-08 20:45:40.000000000","message":"recheck neutron-tempest-plugin-ovn-ubuntu-jammy-2025-1","commit_id":"06969e19b8bd5aa0bdc72134869bdf4c6a97223a"}],"neutron_tempest_plugin/scenario/test_ovn_bgp.py":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"f184dd9312196a7d79b24be5728e7bcc5f54c697","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        subnet \u003d self.create_subnet(network)"},{"line_number":44,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":45,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":46,"context_line":"        self.addCleanup(self.client.delete_router, router[\u0027id\u0027])"},{"line_number":47,"context_line":"        self.addCleanup("},{"line_number":48,"context_line":"            self.client.update_router, router[\u0027id\u0027],"},{"line_number":49,"context_line":"            external_gateway_info\u003d{})"}],"source_content_type":"text/x-python","patch_set":1,"id":"042f9bbe_d08a3904","line":46,"updated":"2026-08-18 11:02:47.000000000","message":"I have the impression that all these cleanups are redundant because `create_router_by_client` ends up calling `_create_router_with_client` from the `BaseNetworkTest` class, which adds the created router to the `cls.routers` list (line 650 from [1]) and that will make `resource_cleanup` call `cls.delete_router` for it (line 209 from [1]).\n\nBut I may be missing something, so I\u0027ll check the test logs with [2].\n\n\n[1] https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/api/base.py#L650\n[2] https://review.opendev.org/c/openstack/neutron/+/1001108","commit_id":"427da208b47889a5c3c2c0c08a504a50d84f0f04"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"7cd6f1fc0c2e1edbac38fbfcf1f2b5ae36d98592","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        subnet \u003d self.create_subnet(network)"},{"line_number":44,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":45,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":46,"context_line":"        self.addCleanup(self.client.delete_router, router[\u0027id\u0027])"},{"line_number":47,"context_line":"        self.addCleanup("},{"line_number":48,"context_line":"            self.client.update_router, router[\u0027id\u0027],"},{"line_number":49,"context_line":"            external_gateway_info\u003d{})"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a91f974_0c965535","line":46,"in_reply_to":"042f9bbe_d08a3904","updated":"2026-09-07 12:58:55.000000000","message":"I have reviewed tempest.log from [1] and I can confirm these cleanups are not needed, they are managed by the (grand) parent\u0027s class resource_cleanup [2].\nThat method removes subnets from the router and deletes the router, so these cleanups are redundant.\n\nApart from that, the test passes, so once these cleanups are removed, the patch LGTM.\n\n[1] https://zuul.opendev.org/t/openstack/build/40a5c116a0cf42ac8b966d7281568f1c\n[2] https://github.com/openstack/neutron-tempest-plugin/blob/master/neutron_tempest_plugin/api/base.py#L209","commit_id":"427da208b47889a5c3c2c0c08a504a50d84f0f04"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"879f981916b51a6d5e156f4352681d2f0cd9c84f","unresolved":true,"context_lines":[{"line_number":43,"context_line":"        subnet \u003d self.create_subnet(network)"},{"line_number":44,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":45,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":46,"context_line":"        self.addCleanup(self.client.delete_router, router[\u0027id\u0027])"},{"line_number":47,"context_line":"        self.addCleanup("},{"line_number":48,"context_line":"            self.client.update_router, router[\u0027id\u0027],"},{"line_number":49,"context_line":"            external_gateway_info\u003d{})"}],"source_content_type":"text/x-python","patch_set":1,"id":"bd5723fa_5ec10ad4","line":46,"in_reply_to":"5a91f974_0c965535","updated":"2026-09-07 13:06:50.000000000","message":"+1 to Eduardo\u0027s comment\n\nThe router cleanup (admin and non-admin) was fixed by Eduardo in https://review.opendev.org/c/openstack/neutron-tempest-plugin/+/1000968","commit_id":"427da208b47889a5c3c2c0c08a504a50d84f0f04"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e6977526b96a28c7e35a0191590a566a8be1f61f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        subnet \u003d self.create_subnet(network)"},{"line_number":44,"context_line":"        router \u003d self.create_router_by_client("},{"line_number":45,"context_line":"            external_network_id\u003dCONF.network.public_network_id)"},{"line_number":46,"context_line":"        self.addCleanup(self.client.delete_router, router[\u0027id\u0027])"},{"line_number":47,"context_line":"        self.addCleanup("},{"line_number":48,"context_line":"            self.client.update_router, router[\u0027id\u0027],"},{"line_number":49,"context_line":"            external_gateway_info\u003d{})"}],"source_content_type":"text/x-python","patch_set":1,"id":"71e2667b_e37a3499","line":46,"in_reply_to":"bd5723fa_5ec10ad4","updated":"2026-09-08 17:37:16.000000000","message":"Done","commit_id":"427da208b47889a5c3c2c0c08a504a50d84f0f04"}]}