)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b3402a3e7c4fd265cda9fbebf32f09a195dacd3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"84c8af7b_2408c779","updated":"2026-10-01 01:27:13.000000000","message":"Will need https://review.opendev.org/c/openstack/neutron-vpnaas/+/1008162 to merge first","commit_id":"ddf656a9cd948e147842943505f6d8b20f8fe706"}],"neutron_vpnaas/tests/unit/services/vpn/device_drivers/test_ipsec.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"511dff2b7214a6462229ccc531b88266987f9989","unresolved":true,"context_lines":[{"line_number":1202,"context_line":"            self.conf.libreswan.ipsec_secret_template, self.vpnservice)"},{"line_number":1203,"context_line":"        self.check_config_file(expected, actual)"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"    def test_peer_id_config_injection_is_rejected(self):"},{"line_number":1206,"context_line":"        \"\"\"A crafted peer_id must not inject ipsec.conf directives."},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        Regression test for bug 2143775: local_id/peer_id are rendered"}],"source_content_type":"text/x-python","patch_set":2,"id":"d700c82e_28018c2d","line":1205,"updated":"2026-10-02 09:47:27.000000000","message":"These tests are executed only for LibreSwan.\n\nOne recommendation could be to create a testing mixing, something like this, to execute it within all drivers (libreswan, swan+stroke, swan+swanctl):\n```\nclass IpsecIdInjectionMixin:\n    \"\"\"Requires: self.process, self.vpnservice, and a template via hook.\"\"\"\n    def _id_injection_config_template(self):\n        return self.ipsec_template  # override in swanctl class\n    def test_peer_id_config_injection_is_rejected(self):\n        ...\n        actual \u003d self.process._gen_config_content(\n            self._id_injection_config_template(), self.process.vpnservice)\n        ...\n\n\nclass TestLibreSwanConfigGeneration(IpsecIdInjectionMixin, BaseIPsecDeviceDriver):\n    ...\n\n\nclass IPsecStrongswanConfigGeneration(IpsecIdInjectionMixin, BaseIPsecDeviceDriver):\n    ...\n\n\nclass TestSwanctlConfigGeneration(IpsecIdInjectionMixin, test_ipsec.BaseIPsecDeviceDriver):\n    def _id_injection_config_template(self):\n        return self.swanctl_template\n```","commit_id":"84883f5e94671dc7bf0104e4d0506647a068914e"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d4e3b44af567af95660abd21b901f78d100c4b6e","unresolved":false,"context_lines":[{"line_number":1202,"context_line":"            self.conf.libreswan.ipsec_secret_template, self.vpnservice)"},{"line_number":1203,"context_line":"        self.check_config_file(expected, actual)"},{"line_number":1204,"context_line":""},{"line_number":1205,"context_line":"    def test_peer_id_config_injection_is_rejected(self):"},{"line_number":1206,"context_line":"        \"\"\"A crafted peer_id must not inject ipsec.conf directives."},{"line_number":1207,"context_line":""},{"line_number":1208,"context_line":"        Regression test for bug 2143775: local_id/peer_id are rendered"}],"source_content_type":"text/x-python","patch_set":2,"id":"46df93d9_bcff14cd","line":1205,"in_reply_to":"d700c82e_28018c2d","updated":"2026-10-02 20:24:36.000000000","message":"Done","commit_id":"84883f5e94671dc7bf0104e4d0506647a068914e"}]}