)]}'
{"neutron_vpnaas/db/vpn/vpn_models.py":[{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"7f4927e811c9e649db2a2c0116c57e6625fe1542","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    psk \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":106,"context_line":"    dpd_action \u003d sa.Column(sa.Enum(\"hold\", \"clear\","},{"line_number":107,"context_line":"                                   \"restart\", \"disabled\","},{"line_number":108,"context_line":"                                   \"restart-by-peer\", name\u003d\"vpn_dpd_actions\"),"},{"line_number":109,"context_line":"                           nullable\u003dFalse)"},{"line_number":110,"context_line":"    dpd_interval \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":111,"context_line":"    dpd_timeout \u003d sa.Column(sa.Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"edda46a8_8ab91d3e","side":"PARENT","line":108,"updated":"2024-01-19 16:12:17.000000000","message":"I don\u0027t think removing it here is enough. Maybe there should be a DB migration too. And it should be removed from the API definition in neutron-lib (neutron_lib/api/definitions/vpn.py VPN_SUPPORTED_DPD_ACTIONS).","commit_id":"256464aea691f8b4957ba668a117963353f34e4c"},{"author":{"_account_id":28619,"name":"Dmitriy Rabotyagov","email":"noonedeadpunk@gmail.com","username":"noonedeadpunk"},"change_message_id":"7a9ac9b7fdc436d6671dcd80baa282e3beed438d","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    psk \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":106,"context_line":"    dpd_action \u003d sa.Column(sa.Enum(\"hold\", \"clear\","},{"line_number":107,"context_line":"                                   \"restart\", \"disabled\","},{"line_number":108,"context_line":"                                   \"restart-by-peer\", name\u003d\"vpn_dpd_actions\"),"},{"line_number":109,"context_line":"                           nullable\u003dFalse)"},{"line_number":110,"context_line":"    dpd_interval \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":111,"context_line":"    dpd_timeout \u003d sa.Column(sa.Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"21926aa9_b771418d","side":"PARENT","line":108,"in_reply_to":"d6792ada_cb0c10fc","updated":"2024-02-07 12:20:27.000000000","message":"Frankly speaking, I\u0027m not sure at all how to generate db migration here, as there\u0027s no alembic.ini withing the project defined, which I\u0027d expect to be present...\n\nI\u0027ve proposed patch to neutron-lib though: https://review.opendev.org/c/openstack/neutron-lib/+/908301","commit_id":"256464aea691f8b4957ba668a117963353f34e4c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"911104565965c743101f9199aefdbf87959c7719","unresolved":true,"context_lines":[{"line_number":105,"context_line":"    psk \u003d sa.Column(sa.String(255), nullable\u003dFalse)"},{"line_number":106,"context_line":"    dpd_action \u003d sa.Column(sa.Enum(\"hold\", \"clear\","},{"line_number":107,"context_line":"                                   \"restart\", \"disabled\","},{"line_number":108,"context_line":"                                   \"restart-by-peer\", name\u003d\"vpn_dpd_actions\"),"},{"line_number":109,"context_line":"                           nullable\u003dFalse)"},{"line_number":110,"context_line":"    dpd_interval \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":111,"context_line":"    dpd_timeout \u003d sa.Column(sa.Integer, nullable\u003dFalse)"}],"source_content_type":"text/x-python","patch_set":2,"id":"d6792ada_cb0c10fc","side":"PARENT","line":108,"in_reply_to":"edda46a8_8ab91d3e","updated":"2024-01-24 16:23:08.000000000","message":"+1\nhttps://opendev.org/openstack/neutron-lib/src/branch/master/neutron_lib/api/definitions/vpn.py#L93 should be removed than","commit_id":"256464aea691f8b4957ba668a117963353f34e4c"}]}