)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"fbe4f4760c7b000a767d4351f2452284be375be1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"77764ca8_8122edd6","updated":"2024-03-12 13:20:15.000000000","message":"I would like an agreement on this with the team, I will bring this topic to the team or the drivers meeting","commit_id":"41cd075ebc90b33b584129002d1f16590df49244"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"e85a725686b6829a27e4e61313085831b9fa7925","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e50b9b75_8eae4d7c","in_reply_to":"77764ca8_8122edd6","updated":"2024-03-18 12:21:38.000000000","message":"Awesome, thanks!\n\nIf I may gently point you to the ML thread on moderizing the Python stack: https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/4V63CHMZ4GPC4IYN7JCJPVKHLZAHN5BL/\n\nHaving types in Python opens so many opportunities to catch nasty runtime bugs in CI via static analysis (e.g. https://mypy-lang.org/). See e.g. https://review.opendev.org/c/openstack/cinder/+/909689 where typing was actually added to find a particular bug.\n\nTypes also help new contributors as it lowers the bar to add your feature to an existing code base.","commit_id":"41cd075ebc90b33b584129002d1f16590df49244"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"accf0b6d716fbbd378244ae0da75f7b3ed0f207c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1bfaab48_0ec613ff","in_reply_to":"e50b9b75_8eae4d7c","updated":"2024-03-18 12:47:07.000000000","message":"There was a short discussion during last team meeting:\nhttps://meetings.opendev.org/meetings/networking/2024/networking.2024-03-12-14.00.log.html#l-61\n\nWe agreed to go to details on the coming PTG, so be prepared and check when the etherpad and schedule is out :-)","commit_id":"41cd075ebc90b33b584129002d1f16590df49244"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2352ef7e976fbfed11c0217fd13697115e17c9a0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d63b6618_0f727448","updated":"2024-04-18 09:18:50.000000000","message":"let\u0027s wait for zuul","commit_id":"f63f99d822670da792050c2660dd5bf87798ed2a"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6ff8efed827702d1cfe51c64400354e87c7158bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f9b5e57a_5e59ccab","updated":"2024-05-03 07:39:00.000000000","message":"ovn job seems to be failing due to this change, see the q-svc log:\nhttps://0755be101755fc07a36f-af919829f86b35e971243ef9572b928e.ssl.cf2.rackcdn.com/911412/8/check/neutron-tempest-plugin-vpnaas-ovn/fbeff2e/controller/logs/screen-q-svc.txt","commit_id":"0f84e3a7db1a220c5835a8501f23a25c873d15fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d3fa81cf7cd6490f39b18e506e1025832ddbe7f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"ad98ab75_0e6ec343","in_reply_to":"427dbed2_eecd492e","updated":"2024-06-05 08:17:47.000000000","message":"Could you please rebase it please?","commit_id":"0f84e3a7db1a220c5835a8501f23a25c873d15fe"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"5dd395535f4bcc70ed6581213882c2f64829ae1c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"427dbed2_eecd492e","in_reply_to":"f9b5e57a_5e59ccab","updated":"2024-05-03 11:13:07.000000000","message":"Thanks for the hint to solve the issue with ovn","commit_id":"0f84e3a7db1a220c5835a8501f23a25c873d15fe"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"8960bcff7d5920ada79f68d410d391d24e2b69a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2cfff6f9_ed47e49d","updated":"2024-06-05 08:24:18.000000000","message":"in the meantime the precommit setup was merged: https://review.opendev.org/c/openstack/neutron-vpnaas/+/917410\nIn a follow-up patch or as part of the rebase could you please add precommit config for type annotations check?","commit_id":"20f76140bc3ba435034b92aa233feae5cff878bd"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"462401c5ecea47b5149068dfd83d48ebb5503132","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e23b9f63_4cade365","in_reply_to":"2cfff6f9_ed47e49d","updated":"2024-06-06 11:14:13.000000000","message":"Thanks for the hint. I have rebased to the current master and added/uncomment the precommit hook. As I have none experience with precommit can you or someone validate that the precommit is working?\ntox with all the checks of mypy and pylint are working  but the pre-commit hook does not catch any changed files to run the pylint or mypy checks","commit_id":"20f76140bc3ba435034b92aa233feae5cff878bd"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6830876b8ebcfe2325a05880bfe2008e33fea148","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5955e4d9_53660913","in_reply_to":"e23b9f63_4cade365","updated":"2024-06-07 07:42:56.000000000","message":"works, thanks. The issue is that both pylint and mypy fails for me with neutron and neutron-lib import errors. I tried to add both as additional_dependencies but that is not enough it seems.\nPrecommit hook basically is a hook script installed in the .git/hooks folder, the way I started to use:\n$ pip install --user pre-commit\n$ cd neutron-vpnaas\n$ pre-commit install --allow-missing-config\n$ git add \u003cmy changes\u003e; git commit","commit_id":"20f76140bc3ba435034b92aa233feae5cff878bd"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"16991a0dab9ee76b82a8464d9ac99ce5ec3f7ac2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7734d3f2_f600ca15","updated":"2024-06-24 10:11:07.000000000","message":"Sorry for the late response.\nI have adjusted the pre-commit configuration to work with pylint and mypy. This required a mypy.ini file. Some of the required dependencies do not have types and need to be excluded from the check. Please let me know if it works for you and what needs to be changed.","commit_id":"b164904d41899e257711bd44297b0d532e32f091"}],"tox.ini":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"3a2d53e383b9280e731d98e3d09af7f449fba30a","unresolved":true,"context_lines":[{"line_number":156,"context_line":"[testenv:genpolicy]"},{"line_number":157,"context_line":"commands \u003d oslopolicy-sample-generator --config-file\u003detc/oslo-policy-generator/policy.conf"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"[testenv:mypy]"},{"line_number":160,"context_line":"description \u003d"},{"line_number":161,"context_line":"  Run type checks."},{"line_number":162,"context_line":"deps \u003d {[testenv]deps}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"aa64a632_15d15ef5","line":159,"range":{"start_line":159,"start_character":9,"end_line":159,"end_character":10},"updated":"2024-04-10 14:55:28.000000000","message":"if we have annotations, couldn\u0027t it easier to just call this from pep8 target?\n{[testenv:mypy]commands} under pep8 commands?","commit_id":"c5af9ad32323e4a3387cfe81484d666e01dbccd0"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"4ff5c576ba791c4ea03f9401b7d19f1fa43fe756","unresolved":true,"context_lines":[{"line_number":156,"context_line":"[testenv:genpolicy]"},{"line_number":157,"context_line":"commands \u003d oslopolicy-sample-generator --config-file\u003detc/oslo-policy-generator/policy.conf"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"[testenv:mypy]"},{"line_number":160,"context_line":"description \u003d"},{"line_number":161,"context_line":"  Run type checks."},{"line_number":162,"context_line":"deps \u003d {[testenv]deps}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1deeca37_685687ec","line":159,"range":{"start_line":159,"start_character":9,"end_line":159,"end_character":10},"in_reply_to":"1e774b94_23c10eb5","updated":"2024-04-18 10:24:08.000000000","message":"Is there a known issue with zuul/tox when installing rootwrap","commit_id":"c5af9ad32323e4a3387cfe81484d666e01dbccd0"},{"author":{"_account_id":34149,"name":"Niklas Schwarz","email":"niklas.schwarz@inovex.de","username":"nschwarz"},"change_message_id":"ca551a45fbe94e0607b72a1dd675564542f1c33e","unresolved":true,"context_lines":[{"line_number":156,"context_line":"[testenv:genpolicy]"},{"line_number":157,"context_line":"commands \u003d oslopolicy-sample-generator --config-file\u003detc/oslo-policy-generator/policy.conf"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"[testenv:mypy]"},{"line_number":160,"context_line":"description \u003d"},{"line_number":161,"context_line":"  Run type checks."},{"line_number":162,"context_line":"deps \u003d {[testenv]deps}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"bb0ed187_940cfa3a","line":159,"range":{"start_line":159,"start_character":9,"end_line":159,"end_character":10},"in_reply_to":"aa64a632_15d15ef5","updated":"2024-04-18 07:55:23.000000000","message":"I have added mypy as a last step to the pep8-step. Let me knwo if this is a valid solution for you","commit_id":"c5af9ad32323e4a3387cfe81484d666e01dbccd0"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2352ef7e976fbfed11c0217fd13697115e17c9a0","unresolved":true,"context_lines":[{"line_number":156,"context_line":"[testenv:genpolicy]"},{"line_number":157,"context_line":"commands \u003d oslopolicy-sample-generator --config-file\u003detc/oslo-policy-generator/policy.conf"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"[testenv:mypy]"},{"line_number":160,"context_line":"description \u003d"},{"line_number":161,"context_line":"  Run type checks."},{"line_number":162,"context_line":"deps \u003d {[testenv]deps}"}],"source_content_type":"text/x-properties","patch_set":3,"id":"1e774b94_23c10eb5","line":159,"range":{"start_line":159,"start_character":9,"end_line":159,"end_character":10},"in_reply_to":"bb0ed187_940cfa3a","updated":"2024-04-18 09:18:50.000000000","message":"thanks","commit_id":"c5af9ad32323e4a3387cfe81484d666e01dbccd0"}]}