)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31976,"name":"Bodo Petermann","email":"b.petermann@syseleven.de","username":"bpetermann"},"change_message_id":"4c1950a805b27628120a0a91a8cd10eee8165afa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"438ba50a_2fef32ac","updated":"2025-11-05 12:56:55.000000000","message":"To me the change looks fine. Originally I worked around the problem of the base class destroy_process calling `_update_nat` by overriding `_update_nat` with an empty function. Nowadays it\u0027s not `_update_nat` anymore but `remove_nat_rules` which is not overridden.\nMaybe your approach of not calling the base class `destroy_process` is better.","commit_id":"8709d29ccbdbc263c8e52451ce2b59f6cae847c7"}],"neutron_vpnaas/services/vpn/device_drivers/ovn_ipsec.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1a6f039e1e85762a7b1f30671230857d242cae9e","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        # the swan."},{"line_number":285,"context_line":"        if self.nsmgr.exists(namespace) and process_id not in self.processes:"},{"line_number":286,"context_line":"            self.ensure_process(process_id)"},{"line_number":287,"context_line":"        if process_id in self.processes:"},{"line_number":288,"context_line":"            process \u003d self.processes[process_id]"},{"line_number":289,"context_line":"            process.disable()"},{"line_number":290,"context_line":"            del self.processes[process_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"d206b532_7c16c38a","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":40},"updated":"2025-10-13 08:38:55.000000000","message":"We already have a method that should be called during the destroy process, that is `IPsecDriver.destroy_process`. Instead of changing the logic and not calling it, change the `ovn_ipsec.IPsecDriver.destroy_process` implementation overwriting the method implemented in the base class.","commit_id":"8709d29ccbdbc263c8e52451ce2b59f6cae847c7"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"e5e1809fc48f8bf154e8b1e207a9dc248e2da5cd","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        # the swan."},{"line_number":285,"context_line":"        if self.nsmgr.exists(namespace) and process_id not in self.processes:"},{"line_number":286,"context_line":"            self.ensure_process(process_id)"},{"line_number":287,"context_line":"        if process_id in self.processes:"},{"line_number":288,"context_line":"            process \u003d self.processes[process_id]"},{"line_number":289,"context_line":"            process.disable()"},{"line_number":290,"context_line":"            del self.processes[process_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"b34b7b05_d22c6b5f","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":40},"in_reply_to":"06fe52c0_afb1416c","updated":"2025-10-29 18:18:33.000000000","message":"@ralonsoh@redhat.com any feedback on this?","commit_id":"8709d29ccbdbc263c8e52451ce2b59f6cae847c7"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"d126ad20ad13a695bc95ec18de4cd6f5d42ab9f0","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        # the swan."},{"line_number":285,"context_line":"        if self.nsmgr.exists(namespace) and process_id not in self.processes:"},{"line_number":286,"context_line":"            self.ensure_process(process_id)"},{"line_number":287,"context_line":"        if process_id in self.processes:"},{"line_number":288,"context_line":"            process \u003d self.processes[process_id]"},{"line_number":289,"context_line":"            process.disable()"},{"line_number":290,"context_line":"            del self.processes[process_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"85056b7f_0bb711bd","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":40},"in_reply_to":"26564da1_5a678a4e","updated":"2026-01-06 10:18:57.000000000","message":"@ralonsoh@redhat.com can we get some feedback here please?\nIt would be very nice to get ovn vpnaas to work again upstream.","commit_id":"8709d29ccbdbc263c8e52451ce2b59f6cae847c7"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"f226c1efa39aec0fd0c667f3309b057f49880507","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        # the swan."},{"line_number":285,"context_line":"        if self.nsmgr.exists(namespace) and process_id not in self.processes:"},{"line_number":286,"context_line":"            self.ensure_process(process_id)"},{"line_number":287,"context_line":"        if process_id in self.processes:"},{"line_number":288,"context_line":"            process \u003d self.processes[process_id]"},{"line_number":289,"context_line":"            process.disable()"},{"line_number":290,"context_line":"            del self.processes[process_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"85f7e97f_2e74d2b7","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":40},"in_reply_to":"85056b7f_0bb711bd","updated":"2026-06-05 06:08:01.000000000","message":"Still waiting for feedback 🫤","commit_id":"8709d29ccbdbc263c8e52451ce2b59f6cae847c7"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"313fc2b89b739314134c349d83f7533999c053d3","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        # the swan."},{"line_number":285,"context_line":"        if self.nsmgr.exists(namespace) and process_id not in self.processes:"},{"line_number":286,"context_line":"            self.ensure_process(process_id)"},{"line_number":287,"context_line":"        if process_id in self.processes:"},{"line_number":288,"context_line":"            process \u003d self.processes[process_id]"},{"line_number":289,"context_line":"            process.disable()"},{"line_number":290,"context_line":"            del self.processes[process_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"26564da1_5a678a4e","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":40},"in_reply_to":"b34b7b05_d22c6b5f","updated":"2025-11-24 10:34:44.000000000","message":"Or do you mean you want to override `remove_nat_rules` with `pass`in the ovn implementation?","commit_id":"8709d29ccbdbc263c8e52451ce2b59f6cae847c7"},{"author":{"_account_id":34380,"name":"Maximilian Stinsky","email":"maximilian@stinsky.com","username":"mstinsky"},"change_message_id":"42df99bbfdee4cf243e632c28468f430544b93e7","unresolved":true,"context_lines":[{"line_number":284,"context_line":"        # the swan."},{"line_number":285,"context_line":"        if self.nsmgr.exists(namespace) and process_id not in self.processes:"},{"line_number":286,"context_line":"            self.ensure_process(process_id)"},{"line_number":287,"context_line":"        if process_id in self.processes:"},{"line_number":288,"context_line":"            process \u003d self.processes[process_id]"},{"line_number":289,"context_line":"            process.disable()"},{"line_number":290,"context_line":"            del self.processes[process_id]"}],"source_content_type":"text/x-python","patch_set":2,"id":"06fe52c0_afb1416c","line":287,"range":{"start_line":287,"start_character":8,"end_line":287,"end_character":40},"in_reply_to":"d206b532_7c16c38a","updated":"2025-10-13 08:53:10.000000000","message":"Maybe I am missing something here?\nWhat you are saying is what we are doing here or not?\nWe are in the `ovn_ipsec.OvnIPsecDriver.destroy_process` function which overrides the `ipsec.IPsecDriver.destroy_process`. But at the moment the `ovn_ipsec.OvnIPsecDriver.destroy_process` makes a call to the base class which we cannot do, therefore I remove the call to the base class and add the logic directly into the ovn implementation.","commit_id":"8709d29ccbdbc263c8e52451ce2b59f6cae847c7"}]}