)]}'
{"etc/neutron.conf":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"33ce0d2556629fc8a11ded69a4dd80bb04bc2ece","unresolved":false,"context_lines":[{"line_number":119,"context_line":"#allowed_rpc_exception_modules\u003doslo.messaging.exceptions,nova.exception,cinder.exception,exceptions"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":122,"context_line":"#qpid_hostname\u003dlocalhost"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Qpid broker port. (integer value)"},{"line_number":125,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_808aefbc","line":122,"updated":"2014-06-20 01:58:21.000000000","message":"Safer to use 127.0.0.1 instead?","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537f3b2bba73a2a6cd86b8042ae75f823e6d1430","unresolved":false,"context_lines":[{"line_number":119,"context_line":"#allowed_rpc_exception_modules\u003doslo.messaging.exceptions,nova.exception,cinder.exception,exceptions"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":122,"context_line":"#qpid_hostname\u003dlocalhost"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Qpid broker port. (integer value)"},{"line_number":125,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_db55c1c2","line":122,"in_reply_to":"1ae5cdf2_808aefbc","updated":"2014-06-20 07:27:56.000000000","message":"These are defaults from oslo.messaging. If you think they are not safe in some way, I think you\u0027re better fix it in oslo.messaging.","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7ed1015c65a20df05134b87323148c567a316203","unresolved":false,"context_lines":[{"line_number":119,"context_line":"#allowed_rpc_exception_modules\u003doslo.messaging.exceptions,nova.exception,cinder.exception,exceptions"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":122,"context_line":"#qpid_hostname\u003dlocalhost"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"# Qpid broker port. (integer value)"},{"line_number":125,"context_line":"#qpid_port\u003d5672"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_7cd4911f","line":122,"in_reply_to":"1ae5cdf2_db55c1c2","updated":"2014-06-20 18:43:33.000000000","message":"I\u0027ve discussed the matter with oslo devs, and there is no clear view on why we need to change that.","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"33ce0d2556629fc8a11ded69a4dd80bb04bc2ece","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":178,"context_line":"# (string value)"},{"line_number":179,"context_line":"#rabbit_host\u003dlocalhost"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":182,"context_line":"# (integer value)"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_a0852bae","line":179,"updated":"2014-06-20 01:58:21.000000000","message":"Safer to use 127.0.0.1 instead?","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537f3b2bba73a2a6cd86b8042ae75f823e6d1430","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"# The RabbitMQ broker address where a single node is used."},{"line_number":178,"context_line":"# (string value)"},{"line_number":179,"context_line":"#rabbit_host\u003dlocalhost"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"# The RabbitMQ broker port where a single node is used."},{"line_number":182,"context_line":"# (integer value)"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_fb58bdfa","line":179,"in_reply_to":"1ae5cdf2_a0852bae","updated":"2014-06-20 07:27:56.000000000","message":"Same.","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"33ce0d2556629fc8a11ded69a4dd80bb04bc2ece","unresolved":false,"context_lines":[{"line_number":244,"context_line":"# Name of this node. Must be a valid hostname, FQDN, or IP"},{"line_number":245,"context_line":"# address. Must match \"host\" option, if running Nova. (string"},{"line_number":246,"context_line":"# value)"},{"line_number":247,"context_line":"#rpc_zmq_host\u003doslo"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Seconds to wait before a cast expires (TTL). Only supported"},{"line_number":250,"context_line":"# by impl_zmq. (integer value)"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_60a08342","line":247,"updated":"2014-06-20 01:58:21.000000000","message":"Use 127.0.0.1 instead?","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537f3b2bba73a2a6cd86b8042ae75f823e6d1430","unresolved":false,"context_lines":[{"line_number":244,"context_line":"# Name of this node. Must be a valid hostname, FQDN, or IP"},{"line_number":245,"context_line":"# address. Must match \"host\" option, if running Nova. (string"},{"line_number":246,"context_line":"# value)"},{"line_number":247,"context_line":"#rpc_zmq_host\u003doslo"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"# Seconds to wait before a cast expires (TTL). Only supported"},{"line_number":250,"context_line":"# by impl_zmq. (integer value)"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_1b73a980","line":247,"in_reply_to":"1ae5cdf2_60a08342","updated":"2014-06-20 07:27:56.000000000","message":"Same.","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"33ce0d2556629fc8a11ded69a4dd80bb04bc2ece","unresolved":false,"context_lines":[{"line_number":257,"context_line":"#matchmaker_heartbeat_ttl\u003d600"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Host to locate redis. (string value)"},{"line_number":260,"context_line":"#host\u003d127.0.0.1"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# Use this port to connect to redis host. (integer value)"},{"line_number":263,"context_line":"#port\u003d6379"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_a0736be5","line":260,"updated":"2014-06-20 01:58:21.000000000","message":"I wonder why the oslo.messaging doesn\u0027t consistently use 127.0.0.1 as the default for host\u003d configs? (Not really relevant to this review.)","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7ed1015c65a20df05134b87323148c567a316203","unresolved":false,"context_lines":[{"line_number":257,"context_line":"#matchmaker_heartbeat_ttl\u003d600"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Host to locate redis. (string value)"},{"line_number":260,"context_line":"#host\u003d127.0.0.1"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# Use this port to connect to redis host. (integer value)"},{"line_number":263,"context_line":"#port\u003d6379"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_fce7c10f","line":260,"in_reply_to":"1ae5cdf2_3bf5c5ca","updated":"2014-06-20 18:43:33.000000000","message":"The bug with \u0027host\u0027 config not getting to specific section [matchmaker_redis] is a bug in oslo.messaging handled by I1e8e746cde4627ddf79632ce8255e268de8bd3c3. I\u0027ll update it manually to have correct section.","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537f3b2bba73a2a6cd86b8042ae75f823e6d1430","unresolved":false,"context_lines":[{"line_number":257,"context_line":"#matchmaker_heartbeat_ttl\u003d600"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"# Host to locate redis. (string value)"},{"line_number":260,"context_line":"#host\u003d127.0.0.1"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"# Use this port to connect to redis host. (integer value)"},{"line_number":263,"context_line":"#port\u003d6379"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_3bf5c5ca","line":260,"in_reply_to":"1ae5cdf2_a0736be5","updated":"2014-06-20 07:27:56.000000000","message":"I\u0027ll ask oslo guys. Another weird thing is that they define \u0027host\u0027 in DEFAULT section using such a generic name for Redis specific setting. I would think that smth like \u0027redis_host\u0027 would be more appropriate. I\u0027ll raise those questions and update here.","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"537f3b2bba73a2a6cd86b8042ae75f823e6d1430","unresolved":false,"context_lines":[{"line_number":294,"context_line":"#control_exchange\u003dopenstack"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"[matchmaker_ring]"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"#"},{"line_number":300,"context_line":"# Options defined in oslo.messaging"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_1b21e94c","line":297,"updated":"2014-06-20 07:27:56.000000000","message":"I guess this is an issue (we rewrite section from DEFAULT to matchmaker_ring for all consequent settings. I\u0027ll move the section below to avoid that.","commit_id":"67a8fcbcd06ee7557969a87b9deab4c947cccc1a"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7861062b6c86450fefe470c81b88ab4ba65ce17a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"# qpid_tcp_nodelay \u003d True"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"# ZMQ"},{"line_number":179,"context_line":"# rpc_backend\u003dneutron.openstack.common.rpc.impl_zmq"},{"line_number":180,"context_line":"# ZeroMQ bind address. Should be a wildcard (*), an ethernet interface, or IP."},{"line_number":181,"context_line":"# The \"host\" option should point or resolve to this address."},{"line_number":182,"context_line":"# rpc_zmq_bind_address \u003d *"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_fe9fcbff","side":"PARENT","line":179,"updated":"2014-06-20 08:25:20.000000000","message":"will these old values for rpc backend still work after port to oslo.messaging?","commit_id":"03c6ce147160e5bf2edcf06bdced26310b280493"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1cd22b1b5895c74dcc0c5e1d33831e6bbf70efa3","unresolved":false,"context_lines":[{"line_number":176,"context_line":"# qpid_tcp_nodelay \u003d True"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"# ZMQ"},{"line_number":179,"context_line":"# rpc_backend\u003dneutron.openstack.common.rpc.impl_zmq"},{"line_number":180,"context_line":"# ZeroMQ bind address. Should be a wildcard (*), an ethernet interface, or IP."},{"line_number":181,"context_line":"# The \"host\" option should point or resolve to this address."},{"line_number":182,"context_line":"# rpc_zmq_bind_address \u003d *"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_5c43553e","side":"PARENT","line":179,"in_reply_to":"1ae5cdf2_fe9fcbff","updated":"2014-06-20 18:41:29.000000000","message":"They will. We have special code in neutron/common/rpc.py to do so.","commit_id":"03c6ce147160e5bf2edcf06bdced26310b280493"},{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"7861062b6c86450fefe470c81b88ab4ba65ce17a","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"# Modules of exceptions that are permitted to be recreated"},{"line_number":243,"context_line":"# upon receiving exception data from an rpc call. (list value)"},{"line_number":244,"context_line":"#allowed_rpc_exception_modules\u003doslo.messaging.exceptions,nova.exception,cinder.exception,exceptions"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":247,"context_line":"#qpid_hostname\u003dlocalhost"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_fe6d0b04","line":244,"updated":"2014-06-20 08:25:20.000000000","message":"should neutron.openstack.common.exceptions be in this list?","commit_id":"2e263fb6e70e128decbe5f61f8f550a41c758607"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1cd22b1b5895c74dcc0c5e1d33831e6bbf70efa3","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"# Modules of exceptions that are permitted to be recreated"},{"line_number":243,"context_line":"# upon receiving exception data from an rpc call. (list value)"},{"line_number":244,"context_line":"#allowed_rpc_exception_modules\u003doslo.messaging.exceptions,nova.exception,cinder.exception,exceptions"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"# Qpid broker hostname. (string value)"},{"line_number":247,"context_line":"#qpid_hostname\u003dlocalhost"}],"source_content_type":"text/plain","patch_set":7,"id":"1ae5cdf2_9c307d9f","line":244,"in_reply_to":"1ae5cdf2_fe6d0b04","updated":"2014-06-20 18:41:29.000000000","message":"Really, it\u0027s unused and removed as of Ibb30709e5a3a08573fc1975fab80498a27b5ef0f in trunk. I\u0027ll remove it here.","commit_id":"2e263fb6e70e128decbe5f61f8f550a41c758607"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"10c13fec50f4c3d2d552a7f17619b587164ff350","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"# Use durable queues in amqp. (boolean value)"},{"line_number":233,"context_line":"# Deprecated group/name - [DEFAULT]/rabbit_durable_queues"},{"line_number":234,"context_line":"#amqp_durable_queues\u003dfalse"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"# Auto-delete queues in amqp. (boolean value)"},{"line_number":237,"context_line":"#amqp_auto_delete\u003dfalse"}],"source_content_type":"text/plain","patch_set":8,"id":"1ae5cdf2_57a92bdc","line":234,"updated":"2014-06-24 05:13:41.000000000","message":"All of the commented out options in this file include a space after the # and before the option name.  Could you fix these since you\u0027ll have to rebase this patch to a new parent?  (Jenkins failed the dependency due to a merge conflict recently introduced)","commit_id":"ad529f4639672111c2b233d549a4bf329a4cffb2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"54a6c114a534cb464c7f3f34c86dbc7a8b6f5601","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"# Use durable queues in amqp. (boolean value)"},{"line_number":233,"context_line":"# Deprecated group/name - [DEFAULT]/rabbit_durable_queues"},{"line_number":234,"context_line":"#amqp_durable_queues\u003dfalse"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"# Auto-delete queues in amqp. (boolean value)"},{"line_number":237,"context_line":"#amqp_auto_delete\u003dfalse"}],"source_content_type":"text/plain","patch_set":8,"id":"1ae5cdf2_1ae7c347","line":234,"in_reply_to":"1ae5cdf2_57a92bdc","updated":"2014-06-24 08:43:16.000000000","message":"I think we should not make those changes. This is how generator works. If we don\u0027t like it, we should fix it for generator first.\n\nI don\u0027t think it\u0027s worth any change though. In the end, I hope we\u0027ll migrate to autogenerated neutron.conf in the future, and there won\u0027t be any need for manual updates of the file.","commit_id":"ad529f4639672111c2b233d549a4bf329a4cffb2"}]}