)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"e4933c6dc92c5473b8e5e1e35ccc3f35292aedab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0c861f98_cb3ba464","updated":"2026-09-08 19:45:40.000000000","message":"I\u0027ve addressed @hjensas@redhat.com feedback and rebased.","commit_id":"1be186fd4360a550c533ec7c040ba845abbb0bea"},{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6a2c2a3b1c15e3bb20cb446ef07cad393ec1403b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9caee97d_c3722ab3","updated":"2026-08-24 20:56:26.000000000","message":"Of the two, I prefer this one.","commit_id":"1be186fd4360a550c533ec7c040ba845abbb0bea"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"dfdfe5d15143aa22c5a9c52a5fed4f5b995b8ffb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f98499af_a0bffe9e","updated":"2026-09-02 20:20:19.000000000","message":"The code make sense to me and I agree with overall implementation. But I feel like there was some reason why the original implementation had 1to1 VNI and VLAN mapping. I need to dig that up","commit_id":"1be186fd4360a550c533ec7c040ba845abbb0bea"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"0a88ff7efdc26a50d20bbb765abd400c0dad0faf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"67da1f1c_bbee94da","in_reply_to":"f98499af_a0bffe9e","updated":"2026-09-02 20:27:44.000000000","message":"So I\u0027m still leaving the OVN side 1:1. The 1:1 makes sense for purely overlay networks that are uniform and not segmented at all. But the review goal was to have this be capable of being a generic VNI/VLAN allocator and for the data center model we\u0027d need it not to be. This would allow networking-cisco and other out of tree ML2 mechanisms not make these custom tables. I\u0027ve also got my FRR approach partitioned by AZ so that\u0027s another multi. By having this API be generic like that it would bring us closer in tree. And the hope is that the general use cases are better tested and we bring more out of tree folks out of the wood work.","commit_id":"1be186fd4360a550c533ec7c040ba845abbb0bea"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"13c81c5e94bbb0686923fb466ad286a90b9870b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3e4c8126_32992cbb","updated":"2026-09-10 14:51:02.000000000","message":"Makes sense as long as the current EVPN VLAN-VNI physnet associating `physnet\u003d\u0027ovn-evpn\u0027` is kept.","commit_id":"5774a392898dd54ec3776eb7cb44e6eb154beb6b"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"bfd28ac61371aceec3876664fd30a264d38f8ccf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce4cd591_9881ef80","updated":"2026-09-08 22:46:36.000000000","message":"recheck node failed to install a package","commit_id":"5774a392898dd54ec3776eb7cb44e6eb154beb6b"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"84ff96018406fe1bac03e6144c97e41c06638795","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"99648d70_0a6e3466","updated":"2026-09-09 02:55:08.000000000","message":"recheck node issues","commit_id":"5774a392898dd54ec3776eb7cb44e6eb154beb6b"}],"neutron/db/evpn_db.py":[{"author":{"_account_id":24245,"name":"Harald Jensås","email":"hjensas@redhat.com","username":"harald.jensas"},"change_message_id":"6a2c2a3b1c15e3bb20cb446ef07cad393ec1403b","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# The VNI is unique across the whole fabric while the VLAN is only unique"},{"line_number":29,"context_line":"# on a single physical network, so they are separate pools. EVPN L3 has a"},{"line_number":30,"context_line":"# single scope for each today, hence the identical physnets."},{"line_number":31,"context_line":"_EVPN_VNI_RANGE \u003d vni_vlan_allocator.ScopedRange("},{"line_number":32,"context_line":"    1, n_const.MAX_VXLAN_VNI, \u0027ovn-evpn\u0027)"},{"line_number":33,"context_line":"_EVPN_VLAN_RANGE \u003d vni_vlan_allocator.ScopedRange("},{"line_number":34,"context_line":"    n_const.MIN_VLAN_TAG, n_const.MAX_VLAN_TAG, \u0027ovn-evpn\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class EVPNDbHelper:"}],"source_content_type":"text/x-python","patch_set":1,"id":"4d628fb4_df08080b","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":59},"updated":"2026-08-24 20:56:26.000000000","message":"I think using keyword args (min_val\u003d, max_val\u003d, physnet\u003d) here make this code a bit more clear.","commit_id":"1be186fd4360a550c533ec7c040ba845abbb0bea"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"4dd89c7b86240d6f9de0e0012b341fb4f4688502","unresolved":true,"context_lines":[{"line_number":28,"context_line":"# The VNI is unique across the whole fabric while the VLAN is only unique"},{"line_number":29,"context_line":"# on a single physical network, so they are separate pools. EVPN L3 has a"},{"line_number":30,"context_line":"# single scope for each today, hence the identical physnets."},{"line_number":31,"context_line":"_EVPN_VNI_RANGE \u003d vni_vlan_allocator.ScopedRange("},{"line_number":32,"context_line":"    1, n_const.MAX_VXLAN_VNI, \u0027ovn-evpn\u0027)"},{"line_number":33,"context_line":"_EVPN_VLAN_RANGE \u003d vni_vlan_allocator.ScopedRange("},{"line_number":34,"context_line":"    n_const.MIN_VLAN_TAG, n_const.MAX_VLAN_TAG, \u0027ovn-evpn\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class EVPNDbHelper:"}],"source_content_type":"text/x-python","patch_set":1,"id":"b27467c9_bde6b863","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":59},"in_reply_to":"4d628fb4_df08080b","updated":"2026-09-01 14:06:53.000000000","message":"Can do. I\u0027ll also clean up the commit message a bit. I\u0027ll wait to get some feedback from others to reduce the cycles.","commit_id":"1be186fd4360a550c533ec7c040ba845abbb0bea"},{"author":{"_account_id":5890,"name":"Doug Goldstein","email":"cardoe@cardoe.com","username":"cardoe"},"change_message_id":"e4933c6dc92c5473b8e5e1e35ccc3f35292aedab","unresolved":false,"context_lines":[{"line_number":28,"context_line":"# The VNI is unique across the whole fabric while the VLAN is only unique"},{"line_number":29,"context_line":"# on a single physical network, so they are separate pools. EVPN L3 has a"},{"line_number":30,"context_line":"# single scope for each today, hence the identical physnets."},{"line_number":31,"context_line":"_EVPN_VNI_RANGE \u003d vni_vlan_allocator.ScopedRange("},{"line_number":32,"context_line":"    1, n_const.MAX_VXLAN_VNI, \u0027ovn-evpn\u0027)"},{"line_number":33,"context_line":"_EVPN_VLAN_RANGE \u003d vni_vlan_allocator.ScopedRange("},{"line_number":34,"context_line":"    n_const.MIN_VLAN_TAG, n_const.MAX_VLAN_TAG, \u0027ovn-evpn\u0027)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class EVPNDbHelper:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3ed277a8_dab04993","line":34,"range":{"start_line":31,"start_character":0,"end_line":34,"end_character":59},"in_reply_to":"b27467c9_bde6b863","updated":"2026-09-08 19:45:40.000000000","message":"Done","commit_id":"1be186fd4360a550c533ec7c040ba845abbb0bea"}]}
