)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"change_message_id":"02b06dfa1ac3b6390689d95e42ad8c533e270107","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"725dbb2f_9ea6c3a5","updated":"2026-08-17 08:57:58.000000000","message":"see comment, I think there is some side effect and the line can just go","commit_id":"416e28b0022de611c40f42f3fea188bd5da000a6"}],"neutron/agent/linux/external_process.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"fa1d97ae15fb6e12822b3715d68236ab6d42c37f","unresolved":false,"context_lines":[{"line_number":160,"context_line":"    def disable(self, sig\u003d\u00279\u0027, get_stop_command\u003dNone, delete_pid_file\u003dTrue):"},{"line_number":161,"context_line":"        pid \u003d self.pid"},{"line_number":162,"context_line":"        # SIGKILL should always remove the pid file, but only when the signal"},{"line_number":163,"context_line":"        # is actually used to stop the process (not with a custom stop command)."},{"line_number":164,"context_line":"        delete_pid_file \u003d (delete_pid_file or"},{"line_number":165,"context_line":"                           (sig \u003d\u003d \u00279\u0027 and not get_stop_command))"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"98232e55_d8ddee0b","line":163,"updated":"2026-08-14 20:42:38.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"416e28b0022de611c40f42f3fea188bd5da000a6"},{"author":{"_account_id":36266,"name":"Florian Streibelt","display_name":"Florian Streibelt","email":"florian.streibelt@sap.com","username":"fstreibelt","status":"working at SAP SE"},"change_message_id":"02b06dfa1ac3b6390689d95e42ad8c533e270107","unresolved":true,"context_lines":[{"line_number":162,"context_line":"        # SIGKILL should always remove the pid file, but only when the signal"},{"line_number":163,"context_line":"        # is actually used to stop the process (not with a custom stop command)."},{"line_number":164,"context_line":"        delete_pid_file \u003d (delete_pid_file or"},{"line_number":165,"context_line":"                           (sig \u003d\u003d \u00279\u0027 and not get_stop_command))"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"        if self.active:"},{"line_number":168,"context_line":"            if get_stop_command:"}],"source_content_type":"text/x-python","patch_set":1,"id":"a8fd290a_f706a4fc","line":165,"updated":"2026-08-17 08:57:58.000000000","message":"This would fix my issue but has side effects. \nIf people are using a stop command and rely on this code to remove the pid file, this will now stop happening. I see the possibility that people even adapted their stop command in a way to keep the pid file because neutron is removing it anyway. This could have some impact on those use cases. But I do not know how common that is. \nBut as I mentioned in the bug report, I think the whole line 164 can be removed without change in functionality. The default for delete_pid_file is True, and the method would then work as I would expect it to do. Keep the file only if the caller requests it to keep it. \nInternally it is called with delete_pid_file\u003dFalse where we only want to reload, so that is safe.","commit_id":"416e28b0022de611c40f42f3fea188bd5da000a6"}]}