)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"4006df1adfdba020a2c32054e32ade4242040333","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"00cbf27b_66da85c7","updated":"2026-08-24 22:55:34.000000000","message":"check experimental","commit_id":"c3be919fd220406d459ec3b719580fe5dad19b62"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f4fd5fbd8f0f922df43b1811f3d9733342241824","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1189a95d_3ca04f93","updated":"2026-08-25 15:57:31.000000000","message":"check experimental","commit_id":"464836da39e7a13dff9e518d39fdbbd1f5d8233a"}],"roles/leaf/templates/frr.conf.j2":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"711f4d5fdc660828e57c39b3abe22b624a02a94f","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"router bgp {{ bgp_as }}"},{"line_number":17,"context_line":"{% if bgp_router_id %}"},{"line_number":18,"context_line":"  bgp router-id {{ bgp_router_id }}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":"  bgp log-neighbor-changes"},{"line_number":21,"context_line":"  bgp graceful-shutdown"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"647338e0_0269a5cf","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":32},"updated":"2026-08-25 07:31:29.000000000","message":"Different router-id values should be allowed for the different leafs.","commit_id":"c3be919fd220406d459ec3b719580fe5dad19b62"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fafd634309c60ebee1c72e1db9bad1667c82f411","unresolved":true,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"router bgp {{ bgp_as }}"},{"line_number":17,"context_line":"{% if bgp_router_id %}"},{"line_number":18,"context_line":"  bgp router-id {{ bgp_router_id }}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":"  bgp log-neighbor-changes"},{"line_number":21,"context_line":"  bgp graceful-shutdown"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"ccf6e456_46957506","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":32},"in_reply_to":"647338e0_0269a5cf","updated":"2026-08-25 12:40:31.000000000","message":"that\u0027s what this does, no? You set_fact bgp_router_id for the hosts or use inventory variable","commit_id":"c3be919fd220406d459ec3b719580fe5dad19b62"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"8d763cc4eb152af0e5b8629c7e318ead62bdb1ca","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"router bgp {{ bgp_as }}"},{"line_number":17,"context_line":"{% if bgp_router_id %}"},{"line_number":18,"context_line":"  bgp router-id {{ bgp_router_id }}"},{"line_number":19,"context_line":"{% endif %}"},{"line_number":20,"context_line":"  bgp log-neighbor-changes"},{"line_number":21,"context_line":"  bgp graceful-shutdown"}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"6071d373_4d3afd47","line":18,"range":{"start_line":18,"start_character":19,"end_line":18,"end_character":32},"in_reply_to":"ccf6e456_46957506","updated":"2026-08-25 13:00:33.000000000","message":"ok, I guess this could be done with set_fact per host or group-vars per host as well.","commit_id":"c3be919fd220406d459ec3b719580fe5dad19b62"}],"roles/spine/defaults/main.yml":[{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"711f4d5fdc660828e57c39b3abe22b624a02a94f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c9262b86_83393d8c","updated":"2026-08-25 07:31:29.000000000","message":"Would it make sense to configure, for example, one `bgp_as` value for the leafs and a different one for the spines? Same with other variables.\nIn that case, we\u0027d need to use different variables, such as `leaf_bgp_as` and `spine_bgp_as`.","commit_id":"c3be919fd220406d459ec3b719580fe5dad19b62"},{"author":{"_account_id":31291,"name":"Eduardo Olivares","email":"eolivare@redhat.com","username":"eolivare"},"change_message_id":"8d763cc4eb152af0e5b8629c7e318ead62bdb1ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de39d555_91b36216","in_reply_to":"40a7c26a_85bf7dc5","updated":"2026-08-25 13:00:33.000000000","message":"I was thinking how to configure different values for the leafs and spines within a zuul job. It could be done using `group-vars` with different values. So, this should be fine.","commit_id":"c3be919fd220406d459ec3b719580fe5dad19b62"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fafd634309c60ebee1c72e1db9bad1667c82f411","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"40a7c26a_85bf7dc5","in_reply_to":"c9262b86_83393d8c","updated":"2026-08-25 12:40:31.000000000","message":"you mean to do it functionally or you want me to change the name of the variables?","commit_id":"c3be919fd220406d459ec3b719580fe5dad19b62"}]}
