)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e3811dd2eff410829820c0780dac402af021feb7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Handle frrDriver and SVD exceptions"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds exeception handling to nl_dispatcher and FSM."},{"line_number":10,"context_line":"Before this patch, an unhandled exception would bubble up to the"},{"line_number":11,"context_line":"_dispatcher_loop where the process would exit"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1dd71aa7_6dadae05","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":27},"updated":"2026-09-02 22:21:11.000000000","message":"Nit: exception","commit_id":"968047ea8afa765822466f93c92bf094393fb034"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e3811dd2eff410829820c0780dac402af021feb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c11880cf_817d83c3","updated":"2026-09-02 22:21:11.000000000","message":"LGTM","commit_id":"968047ea8afa765822466f93c92bf094393fb034"}],"neutron/agent/ovn/extensions/evpn/fsm.py":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"c1cf49802363027d4f188f57a8f2083f3ba5fcd8","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _unadvertise(self, evpn):"},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            self._svd.del_vni(evpn.vni, evpn.vid)"},{"line_number":131,"context_line":"            self._driver.delete_router(evpn.vrf, evpn.vni)"},{"line_number":132,"context_line":"        except _PROVISIONING_ERRORS:"},{"line_number":133,"context_line":"            LOG.exception(\"Failed to unadvertise EVPN VRF %s\", evpn.vrf)"},{"line_number":134,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"c0ce8901_561fb80b","line":131,"range":{"start_line":130,"start_character":0,"end_line":131,"end_character":58},"updated":"2026-09-02 13:56:30.000000000","message":"Just a heads up. I am working on a separate patch where I am improving this code. The issue here is that if `del_vni` raises, then the `delete_router` will not be called. This will leave orphaned vrf configuration inside frr.conf","commit_id":"968047ea8afa765822466f93c92bf094393fb034"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9bca4a77e8e52fe1c995e7c02c0db64ae448dc09","unresolved":true,"context_lines":[{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def _unadvertise(self, evpn):"},{"line_number":129,"context_line":"        try:"},{"line_number":130,"context_line":"            self._svd.del_vni(evpn.vni, evpn.vid)"},{"line_number":131,"context_line":"            self._driver.delete_router(evpn.vrf, evpn.vni)"},{"line_number":132,"context_line":"        except _PROVISIONING_ERRORS:"},{"line_number":133,"context_line":"            LOG.exception(\"Failed to unadvertise EVPN VRF %s\", evpn.vrf)"},{"line_number":134,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"8c33112d_352585a5","line":131,"range":{"start_line":130,"start_character":0,"end_line":131,"end_character":58},"in_reply_to":"c0ce8901_561fb80b","updated":"2026-09-03 00:30:09.000000000","message":"Ok, I\u0027m assuming you will address this in the follow up patch","commit_id":"968047ea8afa765822466f93c92bf094393fb034"}]}
