)]}'
{"neutron/services/pvlan/drivers/ovn/driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6f251e94b06d3033bb326706bec4a4df5aea555","unresolved":false,"context_lines":[{"line_number":13,"context_line":"import functools"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import tenacity"},{"line_number":16,"context_line":"from neutron_lib.callbacks import events"},{"line_number":17,"context_line":"from neutron_lib.callbacks import registry"},{"line_number":18,"context_line":"from neutron_lib.callbacks import resources"},{"line_number":19,"context_line":"from neutron_lib.services.pvlan import constants as pvlan_const"}],"source_content_type":"text/x-python","patch_set":1,"id":"8bc172c2_0c13ce36","line":16,"updated":"2026-09-01 10:47:14.000000000","message":"pep8: H306: imports not in alphabetical order (tenacity, neutron_lib.callbacks.events)","commit_id":"d627b0dbd553a37313f1c91e4e8ac0f197ce30e5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ce824b564b383417746a4333125223a6ba140cac","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        return tenacity.retry("},{"line_number":52,"context_line":"            wait\u003dtenacity.wait_exponential("},{"line_number":53,"context_line":"                max\u003dovn_conf.get_ovn_ovsdb_retry_max_interval()),"},{"line_number":54,"context_line":"            stop\u003dtenacity.stop_after_delay("},{"line_number":55,"context_line":"                ovn_conf.get_ovn_ovsdb_timeout()),"},{"line_number":56,"context_line":"            reraise\u003dFalse,"},{"line_number":57,"context_line":"            retry_error_callback\u003d_log_pvlan_pg_drop_init_failure)("}],"source_content_type":"text/x-python","patch_set":2,"id":"febf9375_d17bb516","line":54,"updated":"2026-09-01 17:35:29.000000000","message":"what happens after the `stop` reaches the timeout?","commit_id":"dc318c33e5e68ce0e6b61cc8e358336768644f9a"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"fed52ab8f756315a1ff58b91de2c3c33815f32c7","unresolved":true,"context_lines":[{"line_number":56,"context_line":"            reraise\u003dFalse,"},{"line_number":57,"context_line":"            retry_error_callback\u003d_log_pvlan_pg_drop_init_failure)("},{"line_number":58,"context_line":"                func)(*args, **kwargs)"},{"line_number":59,"context_line":"    return wrapper"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@_pvlan_pg_drop_init_retry"}],"source_content_type":"text/x-python","patch_set":2,"id":"c9d86c49_2e75a83d","line":59,"updated":"2026-09-01 14:59:48.000000000","message":"is this extra decorator needed really, can\u0027t we simply decorate with `tenacity.retry` function `_run_pvlan_pg_drop_transaction`?","commit_id":"dc318c33e5e68ce0e6b61cc8e358336768644f9a"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"619b9cc17b2bde04b3f6a6650d90c06cedd0633e","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            reraise\u003dFalse,"},{"line_number":57,"context_line":"            retry_error_callback\u003d_log_pvlan_pg_drop_init_failure)("},{"line_number":58,"context_line":"                func)(*args, **kwargs)"},{"line_number":59,"context_line":"    return wrapper"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"@_pvlan_pg_drop_init_retry"}],"source_content_type":"text/x-python","patch_set":2,"id":"faeb894f_aacadb34","line":59,"in_reply_to":"c9d86c49_2e75a83d","updated":"2026-09-01 15:54:57.000000000","message":"No because we can\u0027t make a call to `ovn_conf.get_ovn_ovsdb_retry_max_interval()` or `ovn_conf.get_ovn_ovsdb_timeout()` in the decorator definition. This is the same as in https://github.com/openstack/neutron/blob/455e70ae0992b32bf1bfc8eca874087f32b9cf32/neutron/common/ovn/utils.py#L1028-L1031\n\nIf you call directly this method in the decorator method, the Neutron API won\u0027t start.","commit_id":"dc318c33e5e68ce0e6b61cc8e358336768644f9a"}],"neutron/tests/unit/services/pvlan/drivers/ovn/test_driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"f6f251e94b06d3033bb326706bec4a4df5aea555","unresolved":false,"context_lines":[{"line_number":16,"context_line":"from unittest import mock"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import tenacity"},{"line_number":19,"context_line":"from neutron_lib.callbacks import events"},{"line_number":20,"context_line":"from neutron_lib.callbacks import resources"},{"line_number":21,"context_line":"from neutron_lib.services.pvlan import constants as pvlan_const"},{"line_number":22,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"81078bcd_2a026321","line":19,"updated":"2026-09-01 10:47:14.000000000","message":"pep8: H306: imports not in alphabetical order (tenacity, neutron_lib.callbacks.events)","commit_id":"d627b0dbd553a37313f1c91e4e8ac0f197ce30e5"}]}