)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"099fe3f547b7f52c45878143fa2bef2049f3d125","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"f6a53466_5254ea19","updated":"2026-11-14 20:21:43.000000000","message":"recheck mirror issues","commit_id":"d60631bc847d11adfdbd26e8bf5a63307b597af1"},{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"e75e49f73840ebef012b97ff15e739adc61dd240","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d55c17fd_e63f40ab","updated":"2026-11-19 11:05:00.000000000","message":"I tested PS10 in a three-chassis BGP lab. All three FIPs kept responding during the rolling upgrade and after I disabled DHCP on the external subnet. I confirmed that OVN removed the subnet’s DHCP_Options row and that the interconnect port had the expected gateway.\n\nI did reproduce the startup issue from the inline comment. With the same pre-upgrade state, the parent kept the gateway and PS10 cleared it until backfill ran. That caused no ICMP loss in this lab. I’d still keep this at −1 until full sync preserves the existing gateway through the transition and the concurrent update and repair issues in the inline comments are addressed.","commit_id":"842f5c3de3a45846b1d3dc949ef40c8962baeb76"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/maintenance.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"10946f200f8350ea0e15109606b77cf3f10032db","unresolved":true,"context_lines":[{"line_number":532,"context_line":"            try:"},{"line_number":533,"context_line":"                if row.resource_type \u003d\u003d ovn_const.TYPE_SUBNETS:"},{"line_number":534,"context_line":"                    self._ovn_client.delete_subnet(admin_context,"},{"line_number":535,"context_line":"                                                   row.resource_uuid)"},{"line_number":536,"context_line":"                elif row.resource_type \u003d\u003d ovn_const.TYPE_SEGMENTS:"},{"line_number":537,"context_line":"                    self._fix_delete_segment(admin_context, row)"},{"line_number":538,"context_line":"                elif row.resource_type \u003d\u003d ovn_const.TYPE_PORTS:"}],"source_content_type":"text/x-python","patch_set":3,"id":"78634206_76ab4c9f","line":535,"updated":"2026-09-20 17:23:05.000000000","message":"If the plugin failed to delete the subnet during the API call and the maintenance task detects it, it will leave the GW IP on the LS set.\n\nI also think we should have a one time method that\u0027s executed once Neutron starts and updates the existing LSs with their GW IPs.","commit_id":"16242aa3ea640577ad5dce5ee62cebbdb791d2e4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b654262ba7d616835fb857237d7e70d66177632b","unresolved":true,"context_lines":[{"line_number":532,"context_line":"            try:"},{"line_number":533,"context_line":"                if row.resource_type \u003d\u003d ovn_const.TYPE_SUBNETS:"},{"line_number":534,"context_line":"                    self._ovn_client.delete_subnet(admin_context,"},{"line_number":535,"context_line":"                                                   row.resource_uuid)"},{"line_number":536,"context_line":"                elif row.resource_type \u003d\u003d ovn_const.TYPE_SEGMENTS:"},{"line_number":537,"context_line":"                    self._fix_delete_segment(admin_context, row)"},{"line_number":538,"context_line":"                elif row.resource_type \u003d\u003d ovn_const.TYPE_PORTS:"}],"source_content_type":"text/x-python","patch_set":3,"id":"d138807e_edde159f","line":535,"in_reply_to":"78634206_76ab4c9f","updated":"2026-09-22 03:26:56.000000000","message":"Sure can work on that too.","commit_id":"16242aa3ea640577ad5dce5ee62cebbdb791d2e4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5b8a14f0e60c41ea212d935fc1cf0a45c88236f6","unresolved":false,"context_lines":[{"line_number":532,"context_line":"            try:"},{"line_number":533,"context_line":"                if row.resource_type \u003d\u003d ovn_const.TYPE_SUBNETS:"},{"line_number":534,"context_line":"                    self._ovn_client.delete_subnet(admin_context,"},{"line_number":535,"context_line":"                                                   row.resource_uuid)"},{"line_number":536,"context_line":"                elif row.resource_type \u003d\u003d ovn_const.TYPE_SEGMENTS:"},{"line_number":537,"context_line":"                    self._fix_delete_segment(admin_context, row)"},{"line_number":538,"context_line":"                elif row.resource_type \u003d\u003d ovn_const.TYPE_PORTS:"}],"source_content_type":"text/x-python","patch_set":3,"id":"fe51f7a1_16343d20","line":535,"in_reply_to":"d138807e_edde159f","updated":"2026-11-13 23:54:25.000000000","message":"Done","commit_id":"16242aa3ea640577ad5dce5ee62cebbdb791d2e4"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6b290382324d304c8eae4c67d86e9decac2b35ce","unresolved":true,"context_lines":[{"line_number":2982,"context_line":"                # updated, the DHPC options register has not been created."},{"line_number":2983,"context_line":"                self._add_subnet_dhcp_options(context, subnet, network)"},{"line_number":2984,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":2985,"context_line":"            self._update_ls_subnet_gateway_ips(context, network, txn)"},{"line_number":2986,"context_line":"        db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":2987,"context_line":""},{"line_number":2988,"context_line":"    def _modify_subnet_dhcp_options(self, context, subnet, ovn_subnet, network,"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a47ee9e_281b7a3a","line":2985,"updated":"2026-09-18 21:20:31.000000000","message":"Not sure if we should create a single transaction here for _add_subnet_dhcp_options() and this call ?","commit_id":"8cf36ff0aa81c5ec76d55ce6abc3b25afdba6a41"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b654262ba7d616835fb857237d7e70d66177632b","unresolved":false,"context_lines":[{"line_number":2982,"context_line":"                # updated, the DHPC options register has not been created."},{"line_number":2983,"context_line":"                self._add_subnet_dhcp_options(context, subnet, network)"},{"line_number":2984,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":2985,"context_line":"            self._update_ls_subnet_gateway_ips(context, network, txn)"},{"line_number":2986,"context_line":"        db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":2987,"context_line":""},{"line_number":2988,"context_line":"    def _modify_subnet_dhcp_options(self, context, subnet, ovn_subnet, network,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fd6a390e_3da4010a","line":2985,"in_reply_to":"7a47ee9e_281b7a3a","updated":"2026-09-22 03:26:56.000000000","message":"Gonna leave this one alone","commit_id":"8cf36ff0aa81c5ec76d55ce6abc3b25afdba6a41"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"10946f200f8350ea0e15109606b77cf3f10032db","unresolved":true,"context_lines":[{"line_number":3017,"context_line":"        if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":3018,"context_line":"            db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":3019,"context_line":""},{"line_number":3020,"context_line":"    def delete_subnet(self, context, subnet_id, network_id\u003dNone):"},{"line_number":3021,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":3022,"context_line":"            self._remove_subnet_dhcp_options(subnet_id, txn)"},{"line_number":3023,"context_line":"            if network_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"ef8ac561_a55e13d8","line":3020,"range":{"start_line":3020,"start_character":48,"end_line":3020,"end_character":63},"updated":"2026-09-20 17:23:05.000000000","message":"This should be a mandatory parameter","commit_id":"16242aa3ea640577ad5dce5ee62cebbdb791d2e4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b654262ba7d616835fb857237d7e70d66177632b","unresolved":false,"context_lines":[{"line_number":3017,"context_line":"        if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":3018,"context_line":"            db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":3019,"context_line":""},{"line_number":3020,"context_line":"    def delete_subnet(self, context, subnet_id, network_id\u003dNone):"},{"line_number":3021,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":3022,"context_line":"            self._remove_subnet_dhcp_options(subnet_id, txn)"},{"line_number":3023,"context_line":"            if network_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5c8f3bbb_7f4957f8","line":3020,"range":{"start_line":3020,"start_character":48,"end_line":3020,"end_character":63},"in_reply_to":"ef8ac561_a55e13d8","updated":"2026-09-22 03:26:56.000000000","message":"Done","commit_id":"16242aa3ea640577ad5dce5ee62cebbdb791d2e4"},{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"9d96e60c696e7d7612d9735be3a4615eb7bcfe39","unresolved":true,"context_lines":[{"line_number":3028,"context_line":"                # updated, the DHPC options register has not been created."},{"line_number":3029,"context_line":"                self._add_subnet_dhcp_options(context, subnet, network)"},{"line_number":3030,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":3031,"context_line":"            self._update_ls_subnet_gateway_ips(context, network, txn)"},{"line_number":3032,"context_line":"        db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":3033,"context_line":""},{"line_number":3034,"context_line":"    def _modify_subnet_dhcp_options(self, context, subnet, ovn_subnet, network,"}],"source_content_type":"text/x-python","patch_set":5,"id":"cb1588ab_9cba1dba","line":3031,"range":{"start_line":3031,"start_character":17,"end_line":3031,"end_character":46},"updated":"2026-11-09 13:28:18.000000000","message":"We also need an event handler for changes to this external ID. `ProviderSwitchEvent` only handles switch creation/deletion, and the gateway events still watch `DHCP_Options`. If a DHCP-disabled subnet is created after the provider switch has been reconciled, nothing updates the interconnect LRP, so its `networks` stays empty. Gateway changes and the backfill task have the same issue.","commit_id":"a7bd5a2c8775fd558849015519df2f3153a7ba46"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5b8a14f0e60c41ea212d935fc1cf0a45c88236f6","unresolved":false,"context_lines":[{"line_number":3028,"context_line":"                # updated, the DHPC options register has not been created."},{"line_number":3029,"context_line":"                self._add_subnet_dhcp_options(context, subnet, network)"},{"line_number":3030,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":3031,"context_line":"            self._update_ls_subnet_gateway_ips(context, network, txn)"},{"line_number":3032,"context_line":"        db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":3033,"context_line":""},{"line_number":3034,"context_line":"    def _modify_subnet_dhcp_options(self, context, subnet, ovn_subnet, network,"}],"source_content_type":"text/x-python","patch_set":5,"id":"82cf19b0_2e91a135","line":3031,"range":{"start_line":3031,"start_character":17,"end_line":3031,"end_character":46},"in_reply_to":"cb1588ab_9cba1dba","updated":"2026-11-13 23:54:25.000000000","message":"Done","commit_id":"a7bd5a2c8775fd558849015519df2f3153a7ba46"},{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"9d96e60c696e7d7612d9735be3a4615eb7bcfe39","unresolved":true,"context_lines":[{"line_number":3063,"context_line":"        if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":3064,"context_line":"            db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":3065,"context_line":""},{"line_number":3066,"context_line":"    def delete_subnet(self, context, subnet_id, network_id):"},{"line_number":3067,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":3068,"context_line":"            self._remove_subnet_dhcp_options(subnet_id, txn)"},{"line_number":3069,"context_line":"            if network_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"b02dd43e_1641df65","line":3066,"updated":"2026-11-09 13:28:18.000000000","message":"There\u0027s another caller in `check_for_inconsistencies()` (maintenance.py:540) that still passes only the context and subnet ID. Making `network_id` mandatory here causes every deletion retry to raise `TypeError`, leaving the DHCP options and revision record behind. We need to update that path too, including how it finds the network ID once the subnet is gone.","commit_id":"a7bd5a2c8775fd558849015519df2f3153a7ba46"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5b8a14f0e60c41ea212d935fc1cf0a45c88236f6","unresolved":false,"context_lines":[{"line_number":3063,"context_line":"        if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":3064,"context_line":"            db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":3065,"context_line":""},{"line_number":3066,"context_line":"    def delete_subnet(self, context, subnet_id, network_id):"},{"line_number":3067,"context_line":"        with self._nb_idl.transaction(check_error\u003dTrue) as txn:"},{"line_number":3068,"context_line":"            self._remove_subnet_dhcp_options(subnet_id, txn)"},{"line_number":3069,"context_line":"            if network_id:"}],"source_content_type":"text/x-python","patch_set":5,"id":"c6a1d2fa_861f90eb","line":3066,"in_reply_to":"b02dd43e_1641df65","updated":"2026-11-13 23:54:25.000000000","message":"Done","commit_id":"a7bd5a2c8775fd558849015519df2f3153a7ba46"},{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"e75e49f73840ebef012b97ff15e739adc61dd240","unresolved":true,"context_lines":[{"line_number":3006,"context_line":"            return"},{"line_number":3007,"context_line":""},{"line_number":3008,"context_line":"        ls_name \u003d utils.ovn_name(network[\u0027id\u0027])"},{"line_number":3009,"context_line":"        value \u003d self._get_ls_gateway_ips_value(context, network[\u0027id\u0027])"},{"line_number":3010,"context_line":"        if value:"},{"line_number":3011,"context_line":"            txn.add(self._nb_idl.db_set("},{"line_number":3012,"context_line":"                \u0027Logical_Switch\u0027, ls_name,"}],"source_content_type":"text/x-python","patch_set":10,"id":"6d87e83c_741af627","line":3009,"updated":"2026-11-19 11:05:00.000000000","message":"This can lose a gateway when two subnet operations overlap on the same network. I queued a write with one gateway, committed a newer write with both gateways, then let the first write finish. The switch went back to one gateway. The subnet revision check can’t catch this because the two writes concern different subnets. Can we serialize the read and write per network, or store the gateways by subnet ID?","commit_id":"842f5c3de3a45846b1d3dc949ef40c8962baeb76"},{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"e75e49f73840ebef012b97ff15e739adc61dd240","unresolved":true,"context_lines":[{"line_number":3063,"context_line":"        if check_rev_cmd.result \u003d\u003d ovn_const.TXN_COMMITTED:"},{"line_number":3064,"context_line":"            db_rev.bump_revision(context, subnet, ovn_const.TYPE_SUBNETS)"},{"line_number":3065,"context_line":""},{"line_number":3066,"context_line":"    def delete_subnet(self, context, subnet_id, network_id\u003dNone):"},{"line_number":3067,"context_line":"        if not network_id:"},{"line_number":3068,"context_line":"            # The maintenance task retries deletions after the subnet is"},{"line_number":3069,"context_line":"            # gone from the Neutron DB, so recover the network ID from the"}],"source_content_type":"text/x-python","patch_set":10,"id":"d7b71415_fbfcce20","line":3066,"updated":"2026-11-19 11:05:00.000000000","message":"If the OVN write fails after a DHCP-disabled subnet is deleted from Neutron, maintenance retries with just the subnet UUID. There’s no DHCP_Options row to recover the network ID from. I checked that the retry reaches revision cleanup and leaves the old gateway on the switch. Can we keep enough information to find the switch on retry, or have maintenance reconcile stale gateway entries?","commit_id":"842f5c3de3a45846b1d3dc949ef40c8962baeb76"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_db_sync.py":[{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"e75e49f73840ebef012b97ff15e739adc61dd240","unresolved":true,"context_lines":[{"line_number":1517,"context_line":""},{"line_number":1518,"context_line":"        ports_need_sync_dhcp_opts \u003d []"},{"line_number":1519,"context_line":"        lswitches \u003d self.ovn_nb_api.get_all_logical_switches_with_ports()"},{"line_number":1520,"context_line":"        ls_gateway_ips \u003d {ls[\u0027name\u0027]: ls.get(\u0027subnet_gateway_ips\u0027, \u0027\u0027)"},{"line_number":1521,"context_line":"                          for ls in lswitches}"},{"line_number":1522,"context_line":"        del_lswitchs_list \u003d []"},{"line_number":1523,"context_line":"        del_lports_list \u003d []"}],"source_content_type":"text/x-python","patch_set":10,"id":"0f39c037_234c1df6","line":1520,"updated":"2026-11-19 11:05:00.000000000","message":"This snapshot misses any switches recreated later in the same repair pass. I ran repair with an existing subnet and a missing switch. The switch came back without the gateway external ID. Can we populate it when recreating the switch or refresh the switch list before syncing the gateways?","commit_id":"842f5c3de3a45846b1d3dc949ef40c8962baeb76"}],"neutron/services/bgp/commands.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"709f794faf77b19a5abe26dd09a941e25965c228","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    though the subnet has a perfectly valid configured gateway_ip. Fall"},{"line_number":112,"context_line":"    back to asking Neutron directly for such subnets."},{"line_number":113,"context_line":"    \"\"\""},{"line_number":114,"context_line":"    core_plugin \u003d directory.get_plugin()"},{"line_number":115,"context_line":"    if core_plugin is None:"},{"line_number":116,"context_line":"        return []"},{"line_number":117,"context_line":"    admin_context \u003d n_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"d2e09804_89cb100a","line":114,"updated":"2026-09-16 23:57:03.000000000","message":"This creates a dependency of the service plugin on the core plugin. I\u0027m not strictly against it but I tried to keep it simple and consider OVN database the source of truth for the service plugin.\n\nI understand the requirement to enable DHCP on an external subnet is clumsy but with BGP there is no real \"external\" network but rather an \"underlay\" fabric.\n\nWe can discuss it if would be cleaner system design-wise to let the OVN mech driver store the gateway ip somewhere to external_ids - either the router connected to the external network or the logical switch representing the external network.\n\nWhat do you think?","commit_id":"59394c22a7091d15c9431118d3787511f506e6f9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6b290382324d304c8eae4c67d86e9decac2b35ce","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    though the subnet has a perfectly valid configured gateway_ip. Fall"},{"line_number":112,"context_line":"    back to asking Neutron directly for such subnets."},{"line_number":113,"context_line":"    \"\"\""},{"line_number":114,"context_line":"    core_plugin \u003d directory.get_plugin()"},{"line_number":115,"context_line":"    if core_plugin is None:"},{"line_number":116,"context_line":"        return []"},{"line_number":117,"context_line":"    admin_context \u003d n_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"6c9b6d13_47af6534","line":114,"in_reply_to":"201e68f6_6dc37857","updated":"2026-09-18 21:20:31.000000000","message":"Done","commit_id":"59394c22a7091d15c9431118d3787511f506e6f9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"1cf0a3404b0c35e3bc7420ce501f247522150438","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    though the subnet has a perfectly valid configured gateway_ip. Fall"},{"line_number":112,"context_line":"    back to asking Neutron directly for such subnets."},{"line_number":113,"context_line":"    \"\"\""},{"line_number":114,"context_line":"    core_plugin \u003d directory.get_plugin()"},{"line_number":115,"context_line":"    if core_plugin is None:"},{"line_number":116,"context_line":"        return []"},{"line_number":117,"context_line":"    admin_context \u003d n_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"201e68f6_6dc37857","line":114,"in_reply_to":"d2e09804_89cb100a","updated":"2026-09-17 15:27:24.000000000","message":"Yes, I\u0027d be fine with some other way, just let Claude run with this.","commit_id":"59394c22a7091d15c9431118d3787511f506e6f9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ae1343d5a362ee693c0654109bb1b4b86ec244f8","unresolved":true,"context_lines":[{"line_number":87,"context_line":"    for dhcp_opt in nb_idl.tables[\u0027DHCP_Options\u0027].rows.values():"},{"line_number":88,"context_line":"        if dhcp_opt.external_ids.get("},{"line_number":89,"context_line":"                ovn_const.OVN_NETWORK_ID_EXT_ID_KEY) \u003d\u003d n_net_id:"},{"line_number":90,"context_line":"            yield dhcp_opt"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def _get_gw_ips_from_ls_external_ids(switch):"}],"source_content_type":"text/x-python","patch_set":2,"id":"8312be0b_4fc63ff1","line":90,"updated":"2026-09-18 21:12:08.000000000","message":"Technically I guess we could get rid of this if we always have the gateway_ips present?","commit_id":"8cf36ff0aa81c5ec76d55ce6abc3b25afdba6a41"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b654262ba7d616835fb857237d7e70d66177632b","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    for dhcp_opt in nb_idl.tables[\u0027DHCP_Options\u0027].rows.values():"},{"line_number":88,"context_line":"        if dhcp_opt.external_ids.get("},{"line_number":89,"context_line":"                ovn_const.OVN_NETWORK_ID_EXT_ID_KEY) \u003d\u003d n_net_id:"},{"line_number":90,"context_line":"            yield dhcp_opt"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"def _get_gw_ips_from_ls_external_ids(switch):"}],"source_content_type":"text/x-python","patch_set":2,"id":"f75d9d78_4b9505dd","line":90,"in_reply_to":"8312be0b_4fc63ff1","updated":"2026-09-22 03:26:56.000000000","message":"Done","commit_id":"8cf36ff0aa81c5ec76d55ce6abc3b25afdba6a41"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"10946f200f8350ea0e15109606b77cf3f10032db","unresolved":true,"context_lines":[{"line_number":119,"context_line":"        gw_ip for dhcp_opt in _get_switch_dhcp_options(nb_idl, switch)"},{"line_number":120,"context_line":"        if (gw_ip :\u003d helpers.get_gw_ip_from_dhcp_options("},{"line_number":121,"context_line":"            dhcp_opt)) is not None]"},{"line_number":122,"context_line":"    if not gw_ips:"},{"line_number":123,"context_line":"        gw_ips \u003d _get_gw_ips_from_ls_external_ids(switch)"},{"line_number":124,"context_line":"    LOG.debug(\"For logical switch %s, found gateway IPs: %s\","},{"line_number":125,"context_line":"              switch.name, gw_ips)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3e2333f4_ce2d711f","line":122,"updated":"2026-09-20 17:23:05.000000000","message":"I\u0027d not make it more complex with the fallback but rather rely on that the data are set in the LS. Meaning the LS ext_ids will always be the source of truth.","commit_id":"16242aa3ea640577ad5dce5ee62cebbdb791d2e4"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"eca3fa6def83ae1bd6d117fd58c939f91a768380","unresolved":false,"context_lines":[{"line_number":119,"context_line":"        gw_ip for dhcp_opt in _get_switch_dhcp_options(nb_idl, switch)"},{"line_number":120,"context_line":"        if (gw_ip :\u003d helpers.get_gw_ip_from_dhcp_options("},{"line_number":121,"context_line":"            dhcp_opt)) is not None]"},{"line_number":122,"context_line":"    if not gw_ips:"},{"line_number":123,"context_line":"        gw_ips \u003d _get_gw_ips_from_ls_external_ids(switch)"},{"line_number":124,"context_line":"    LOG.debug(\"For logical switch %s, found gateway IPs: %s\","},{"line_number":125,"context_line":"              switch.name, gw_ips)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dcabd508_d9f9a859","line":122,"in_reply_to":"3e2333f4_ce2d711f","updated":"2026-11-18 23:37:40.000000000","message":"Done","commit_id":"16242aa3ea640577ad5dce5ee62cebbdb791d2e4"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"660fc633a63a7086c1ed04025c9e464f9882d409","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        ovn_const.OVN_SUBNET_GATEWAY_IPS_EXT_ID_KEY)"},{"line_number":105,"context_line":"    if not gw_ips:"},{"line_number":106,"context_line":"        return []"},{"line_number":107,"context_line":"    return [gw_ip for gw_ip in value.split(\u0027,\u0027) if gw_ip]"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"def _get_gw_ips_for_switch(nb_idl, switch):"}],"source_content_type":"text/x-python","patch_set":9,"id":"27d8f731_d0a1ad03","line":107,"updated":"2026-11-19 01:28:56.000000000","message":"pep8: F821 undefined name \u0027value\u0027","commit_id":"d9952f9f41d0b5f0fb12fe6fc50dcd40bcbd49d4"},{"author":{"_account_id":35761,"name":"Guillaume Boutry","display_name":"gboutry","email":"guillaume.boutry@canonical.com","username":"gboutry"},"change_message_id":"e75e49f73840ebef012b97ff15e739adc61dd240","unresolved":true,"context_lines":[{"line_number":100,"context_line":"    \"\u003cgateway_ip\u003e/\u003cprefixlen\u003e\" entries. This is the only source of"},{"line_number":101,"context_line":"    gateway IPs for the BGP service plugin."},{"line_number":102,"context_line":"    \"\"\""},{"line_number":103,"context_line":"    gw_ips \u003d switch.external_ids.get("},{"line_number":104,"context_line":"        ovn_const.OVN_SUBNET_GATEWAY_IPS_EXT_ID_KEY)"},{"line_number":105,"context_line":"    if not gw_ips:"},{"line_number":106,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":10,"id":"768effee_54a5b576","line":103,"updated":"2026-11-19 11:05:00.000000000","message":"Can we preserve the existing interconnect networks until the gateway backfill runs? I started with a working LRP and DHCP_Options but no new external ID. Running full sync first preserved 172.20.20.1/24 on the parent commit and cleared it on this patch set. That leaves a window where forwarding can break during upgrade.","commit_id":"842f5c3de3a45846b1d3dc949ef40c8962baeb76"}],"neutron/tests/unit/services/bgp/test_commands.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"20efb744a58b0c443498ca0ad58564e486c6e8b2","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    nb_idl \u003d mock.Mock()"},{"line_number":41,"context_line":"    nb_idl.tables \u003d {"},{"line_number":42,"context_line":"        \u0027DHCP_Options\u0027: mock.Mock("},{"line_number":43,"context_line":"            rows\u003d{i: opt for i, opt in enumerate(dhcp_options)}),"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"    return nb_idl"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"6c9d015d_b6081b5b","line":43,"updated":"2026-09-17 00:32:23.000000000","message":"pep8: R1721: Unnecessary use of a comprehension, use dict(enumerate(dhcp_options)) instead. (unnecessary-comprehension)","commit_id":"59394c22a7091d15c9431118d3787511f506e6f9"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4c7967ba7dd7f1c55d2640ca3319e7f6d51dbcdc","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    nb_idl \u003d mock.Mock()"},{"line_number":45,"context_line":"    nb_idl.tables \u003d {"},{"line_number":46,"context_line":"        \u0027DHCP_Options\u0027: mock.Mock("},{"line_number":47,"context_line":"            rows\u003d{i: opt for i, opt in enumerate(dhcp_options)}),"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"    return nb_idl"},{"line_number":50,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"237008c9_bba2189f","line":47,"updated":"2026-09-18 23:20:02.000000000","message":"pep8: R1721: Unnecessary use of a comprehension, use dict(enumerate(dhcp_options)) instead. (unnecessary-comprehension)","commit_id":"8cf36ff0aa81c5ec76d55ce6abc3b25afdba6a41"}]}
