)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86c5479b030ac3293879ee58206ca7523954dc37","unresolved":true,"context_lines":[{"line_number":14,"context_line":"for storage, management or tenant L2 purposes: there was no way to"},{"line_number":15,"context_line":"deploy such a setup with the BGP service plugin enabled."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Add a new ``bgp:provider_physnet`` option naming the physical network"},{"line_number":18,"context_line":"that carries the BGP fabric.  When it is set:"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* Only the flat provider network on that physical network is used by"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"824745d3_b1c32f58","line":17,"range":{"start_line":17,"start_character":35,"end_line":17,"end_character":41},"updated":"2026-10-15 06:41:07.000000000","message":"`configuration option`, just to make clear what this parameter is","commit_id":"ced1afb5ce656f953c12a2d5c7c2eae4f52cc606"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86c5479b030ac3293879ee58206ca7523954dc37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"68fe1299_98ccdcdf","updated":"2026-10-15 06:41:07.000000000","message":"-1 in particular for the missing event that is not in this code branch. Please rebase and refactor the events module.","commit_id":"ced1afb5ce656f953c12a2d5c7c2eae4f52cc606"}],"doc/source/admin/ovn/bgp.rst":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86c5479b030ac3293879ee58206ca7523954dc37","unresolved":true,"context_lines":[{"line_number":90,"context_line":".. warning::"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   VLAN provider networks are not supported when the BGP service plugin"},{"line_number":93,"context_line":"   is enabled and the bgp:provider_physnet option is not configured."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"When ``bgp:provider_physnet`` is set to a physical network name, the"},{"line_number":96,"context_line":"restriction is relaxed:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"97b2a594_3f3498f0","line":93,"range":{"start_line":93,"start_character":22,"end_line":93,"end_character":42},"updated":"2026-10-15 06:41:07.000000000","message":"```\n``bgp:provider_physnet``\n```","commit_id":"ced1afb5ce656f953c12a2d5c7c2eae4f52cc606"}],"neutron/services/bgp/commands.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86c5479b030ac3293879ee58206ca7523954dc37","unresolved":true,"context_lines":[{"line_number":65,"context_line":"    return nb_idl.lookup(\u0027Logical_Router\u0027, constants.MAIN_ROUTER_NAME)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"def _get_switch_physnet(switch):"},{"line_number":69,"context_line":"    \"\"\"Return the physical network name of a logical switch.\"\"\""},{"line_number":70,"context_line":"    return switch.external_ids.get(ovn_const.OVN_PHYSNET_EXT_ID_KEY)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2fe3dc69_d338ce36","line":68,"range":{"start_line":68,"start_character":4,"end_line":68,"end_character":23},"updated":"2026-10-15 06:41:07.000000000","message":"nit: I wouldn\u0027t implement this method.","commit_id":"ced1afb5ce656f953c12a2d5c7c2eae4f52cc606"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86c5479b030ac3293879ee58206ca7523954dc37","unresolved":true,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"def _flat_switches(nb_idl):"},{"line_number":97,"context_line":"    \"\"\"Return every flat provider switch currently in the NB database.\"\"\""},{"line_number":98,"context_line":"    return ["},{"line_number":99,"context_line":"        s for s in nb_idl.tables[\u0027Logical_Switch\u0027].rows.values()"},{"line_number":100,"context_line":"        if hasattr(s, \u0027external_ids\u0027) and s.external_ids.get("}],"source_content_type":"text/x-python","patch_set":2,"id":"b4e7ae7d_84c71cf4","line":97,"range":{"start_line":97,"start_character":34,"end_line":97,"end_character":40},"updated":"2026-10-15 06:41:07.000000000","message":"In Neutron we identify this as Logical_Switch (same as in OVN). Please rename this to Logical_Switch or LS. Same for the method names.","commit_id":"ced1afb5ce656f953c12a2d5c7c2eae4f52cc606"}],"neutron/services/bgp/events.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86c5479b030ac3293879ee58206ca7523954dc37","unresolved":true,"context_lines":[{"line_number":107,"context_line":"    def match_fn(self, event, row, old):"},{"line_number":108,"context_line":"        if not super().match_fn(event, row, old):"},{"line_number":109,"context_line":"            return False"},{"line_number":110,"context_line":"        return commands._is_bgp_provider_switch(row)"},{"line_number":111,"context_line":""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"class GatewayIPEvent(BGPReconcilerResourceEvent):"}],"source_content_type":"text/x-python","patch_set":2,"id":"2ffe8d83_be91484f","line":110,"range":{"start_line":110,"start_character":24,"end_line":110,"end_character":47},"updated":"2026-10-15 06:41:07.000000000","message":"If `_is_bgp_provider_switch` is used outside the class, it should be public.","commit_id":"ced1afb5ce656f953c12a2d5c7c2eae4f52cc606"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"86c5479b030ac3293879ee58206ca7523954dc37","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4c0ec782_2f2f0597","line":190,"updated":"2026-10-15 06:41:07.000000000","message":"You need to rebase this patch on top of `I0bda646d0a5b198e4e1b1e15d8e51539d13f0f53`, that is in master now. There are new events that need to be handled too.","commit_id":"ced1afb5ce656f953c12a2d5c7c2eae4f52cc606"}]}