)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"56cd3a4c8b3630d035b6dc1a064221c8be4cb907","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Doug Wiegley \u003cdougw@a10networks.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2014-06-19 12:09:09 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LBaaS new object model no-op driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint LBaaS Driver Interface changes for new object model"},{"line_number":10,"context_line":"Change-Id: I39dccb93c6f9bd3264afbf0acc55a56fc6fd05a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"1ae5cdf2_cf5d124a","line":7,"updated":"2014-06-19 17:56:18.000000000","message":"s/no-op/logging no-op/","commit_id":"98b220841c2e9f51df6e55372a4ab32df3896cdb"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"c9c362d68edffa554ef48df4838482ed89cf48a7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LBaaS new object model logging no-op driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint LBaaS Driver Interface changes for new object model"},{"line_number":10,"context_line":"Change-Id: I39dccb93c6f9bd3264afbf0acc55a56fc6fd05a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"1ae5cdf2_0a9abe61","line":9,"updated":"2014-06-26 04:25:32.000000000","message":"this should be:\nImplements: bp/lbaas-objmodel-driver-changes","commit_id":"b47e3fc28be071d14ce7e517d6fbdc25b523877d"},{"author":{"_account_id":8446,"name":"Evgeny Fedoruk","email":"evgenyf@radware.com","username":"evgenyfedoruk"},"change_message_id":"c3fc384c0c4136962bacee1d69e21285de7a2d19","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"LBaaS new object model logging no-op driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: bp/lbaas-objmodel-driver-changes"},{"line_number":10,"context_line":"Change-Id: I39dccb93c6f9bd3264afbf0acc55a56fc6fd05a1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"baada198_29b1b9f8","line":9,"updated":"2014-07-01 12:54:47.000000000","message":"It should be:\n\nImplements: blueprint lbaas-objmodel-driver-changes","commit_id":"53617ccf47c08f05fc27578a59d1b3e4b3a8488a"}],"etc/neutron.conf":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"2510e67e769d709977b0955bf780c34760398b3a","unresolved":false,"context_lines":[{"line_number":477,"context_line":"# service_provider\u003dVPN:cisco:neutron.services.vpn.service_drivers.cisco_ipsec.CiscoCsrIPsecVPNDriver:default"},{"line_number":478,"context_line":"# Uncomment the line below to use Embrane heleos as Load Balancer service provider."},{"line_number":479,"context_line":"# service_provider\u003dLOADBALANCER:Embrane:neutron.services.loadbalancer.drivers.embrane.driver.EmbraneLbaas:default"},{"line_number":480,"context_line":"# Uncomment the following line to test the LBaaS v2 api without a real backend"},{"line_number":481,"context_line":"# service_provider \u003d LOADBALANCER:Noop:neutron.services.loadbalancer.drivers.noop.driver.NoopLoadBalancerDriver:default"}],"source_content_type":"text/plain","patch_set":4,"id":"1ae5cdf2_c35d0a4a","line":480,"updated":"2014-06-19 04:13:46.000000000","message":"why to add it here at all?\nAbout a yeah ago we had a discussion on noop drivers and decided not to expose it to users/deployers","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"8e166c8d9edbb4d663dfcb64ac6e61383af7109c","unresolved":false,"context_lines":[{"line_number":477,"context_line":"# service_provider\u003dVPN:cisco:neutron.services.vpn.service_drivers.cisco_ipsec.CiscoCsrIPsecVPNDriver:default"},{"line_number":478,"context_line":"# Uncomment the line below to use Embrane heleos as Load Balancer service provider."},{"line_number":479,"context_line":"# service_provider\u003dLOADBALANCER:Embrane:neutron.services.loadbalancer.drivers.embrane.driver.EmbraneLbaas:default"},{"line_number":480,"context_line":"# Uncomment the following line to test the LBaaS v2 api without a real backend"},{"line_number":481,"context_line":"# service_provider \u003d LOADBALANCER:Noop:neutron.services.loadbalancer.drivers.noop.driver.NoopLoadBalancerDriver:default"}],"source_content_type":"text/plain","patch_set":4,"id":"1ae5cdf2_3e4de172","line":480,"in_reply_to":"1ae5cdf2_c35d0a4a","updated":"2014-06-19 04:21:02.000000000","message":"Since the driver\u0027s primary purpose is to aid in adding all the new lbaas code, I put this here to make it easy for the team to turn it on.  There are two spots that I have to edit in the driver once Brandon makes his first commit, so I can always yank this out then, if we don\u0027t want it to hit Juno.\n\nDo you happen to have a link, or know closely when, the discussion happened?  As an administrator, I find no-op\u0027s pretty useful for narrowing down problem areas, so I\u0027m interested in what was discussed.","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"56cd3a4c8b3630d035b6dc1a064221c8be4cb907","unresolved":false,"context_lines":[{"line_number":477,"context_line":"# service_provider\u003dVPN:cisco:neutron.services.vpn.service_drivers.cisco_ipsec.CiscoCsrIPsecVPNDriver:default"},{"line_number":478,"context_line":"# Uncomment the line below to use Embrane heleos as Load Balancer service provider."},{"line_number":479,"context_line":"# service_provider\u003dLOADBALANCER:Embrane:neutron.services.loadbalancer.drivers.embrane.driver.EmbraneLbaas:default"},{"line_number":480,"context_line":"# Uncomment the following line to test the LBaaS v2 api without a real backend"},{"line_number":481,"context_line":"# service_provider \u003d LOADBALANCER:LoggingNoop:neutron.services.loadbalancer.drivers.logging_noop.driver.LoggingNoopLoadBalancerDriver:default"}],"source_content_type":"text/plain","patch_set":6,"id":"1ae5cdf2_0f029a0b","line":480,"updated":"2014-06-19 17:56:18.000000000","message":"nit: s/api/API/","commit_id":"98b220841c2e9f51df6e55372a4ab32df3896cdb"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7de28c926e612c2c49b3bacea657310db5c15f6c","unresolved":false,"context_lines":[{"line_number":477,"context_line":"# service_provider\u003dVPN:cisco:neutron.services.vpn.service_drivers.cisco_ipsec.CiscoCsrIPsecVPNDriver:default"},{"line_number":478,"context_line":"# Uncomment the line below to use Embrane heleos as Load Balancer service provider."},{"line_number":479,"context_line":"# service_provider\u003dLOADBALANCER:Embrane:neutron.services.loadbalancer.drivers.embrane.driver.EmbraneLbaas:default"},{"line_number":480,"context_line":"# Uncomment the following line to test the LBaaS v2 API without a real backend"},{"line_number":481,"context_line":"# service_provider \u003d LOADBALANCER:LoggingNoop:neutron.services.loadbalancer.drivers.logging_noop.driver.LoggingNoopLoadBalancerDriver:default"}],"source_content_type":"text/plain","patch_set":15,"id":"1ae5cdf2_e5cc53be","line":480,"updated":"2014-06-23 20:07:28.000000000","message":"This comment makes it sound like the logging nooop driver is a real backend.  I know its a nit, but that could be confusing.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"58576a63aec256c9dc64485cda2bf4b3119e52b0","unresolved":false,"context_lines":[{"line_number":477,"context_line":"# service_provider\u003dVPN:cisco:neutron.services.vpn.service_drivers.cisco_ipsec.CiscoCsrIPsecVPNDriver:default"},{"line_number":478,"context_line":"# Uncomment the line below to use Embrane heleos as Load Balancer service provider."},{"line_number":479,"context_line":"# service_provider\u003dLOADBALANCER:Embrane:neutron.services.loadbalancer.drivers.embrane.driver.EmbraneLbaas:default"},{"line_number":480,"context_line":"# Uncomment the following line to test the LBaaS v2 API without a real backend"},{"line_number":481,"context_line":"# service_provider \u003d LOADBALANCER:LoggingNoop:neutron.services.loadbalancer.drivers.logging_noop.driver.LoggingNoopLoadBalancerDriver:default"}],"source_content_type":"text/plain","patch_set":15,"id":"1ae5cdf2_c8b842ca","line":480,"in_reply_to":"1ae5cdf2_e5cc53be","updated":"2014-06-24 01:10:35.000000000","message":"Actually, I don\u0027t get that impression: The comment leads me to believe it is *not* a real back-end.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"}],"neutron/services/loadbalancer/drivers/abstract_driver.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"2510e67e769d709977b0955bf780c34760398b3a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.plugins.common import constants"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class NotImplementedManager(object):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create(self, context, obj):"},{"line_number":29,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_237a2eba","line":26,"updated":"2014-06-19 04:13:46.000000000","message":"why is this needed at all?","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"8e166c8d9edbb4d663dfcb64ac6e61383af7109c","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.plugins.common import constants"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class NotImplementedManager(object):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def create(self, context, obj):"},{"line_number":29,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_0302920b","line":26,"in_reply_to":"1ae5cdf2_237a2eba","updated":"2014-06-19 04:21:02.000000000","message":"It causes the drivers that derive from LBAstractDriver to explode if they forget to implement one of the handlers.","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"},{"author":{"_account_id":6447,"name":"Avishay Balderman","email":"avishayb@radware.com","username":"avishayb"},"change_message_id":"11962b0c032b2e07dbc0bc56d0a85d036583b8a6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":51,"context_line":"class LBBaseManager(object):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, driver):"},{"line_number":54,"context_line":"        self.driver \u003d driver"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_755e9aea","line":53,"updated":"2014-06-19 12:29:37.000000000","message":"Can you please explain why we moved into a CRUD based driver model with declaring the operations: create_this, delete_that,etc","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d9b36e5f58aff9437db8e1109dbd5c87133381a0","unresolved":false,"context_lines":[{"line_number":50,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":51,"context_line":"class LBBaseManager(object):"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def __init__(self, driver):"},{"line_number":54,"context_line":"        self.driver \u003d driver"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":4,"id":"1ae5cdf2_9bf35572","line":53,"in_reply_to":"1ae5cdf2_755e9aea","updated":"2014-06-19 13:47:16.000000000","message":"Hi Avishay, thanks for the question.  While discussing the blueprint at the current meetup, it was pointed out that since we\u0027re destructively changing the driver interface, we had the opportunity to change it from a flat interface to something more heirarchical, since some of the neutron plugins were getting rather cumbersome.\n\nThis current interface lets you more easily move different pieces into different modules.  All of the logical entry points are the same.  And the CRUD-ness of it is coincidence; other methods can go in the handler classes, we just only have CUD + stats right now.  Here\u0027s a link to the earlier version of the blueprint for this driver change, which had the flatter interface:\n\nhttps://review.openstack.org/#/c/100690/6/specs/juno/lbaas-objmodel-driver-changes.rst,unified","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"56cd3a4c8b3630d035b6dc1a064221c8be4cb907","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Avishay Balderman, Radware"},{"line_number":18,"context_line":"# @author: Doug Wiegley (irc dougwig), A10 Networks"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import abc"},{"line_number":21,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_e32aea7c","line":18,"updated":"2014-06-19 17:56:18.000000000","message":"I don\u0027t see irc handle anywhere else in the source tree.","commit_id":"98b220841c2e9f51df6e55372a4ab32df3896cdb"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"56cd3a4c8b3630d035b6dc1a064221c8be4cb907","unresolved":false,"context_lines":[{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":84,"context_line":"class LoadBalancerAbstractDriver(object):"},{"line_number":85,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    The configuration elements (Vip,Member,etc) are the dicts that"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ae5cdf2_e3782a91","line":84,"updated":"2014-06-19 17:56:18.000000000","message":"Can we log a warning whenever this class is extended?","commit_id":"98b220841c2e9f51df6e55372a4ab32df3896cdb"},{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"f94096e639d3d954a61100cead89616d5e22f751","unresolved":false,"context_lines":[{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":84,"context_line":"class LoadBalancerAbstractDriver(object):"},{"line_number":85,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    The configuration elements (Vip,Member,etc) are the dicts that"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_83d8461f","line":84,"updated":"2014-06-19 18:07:24.000000000","message":"Can we log a warning when this class is extended?","commit_id":"4ce8c5b57ab1185e300bb45cdf042087bec44abf"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"56b5da96a1c625b4f140be1e351d6cf68b95bb5c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":84,"context_line":"class LoadBalancerAbstractDriver(object):"},{"line_number":85,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    The configuration elements (Vip,Member,etc) are the dicts that"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_26586030","line":84,"in_reply_to":"1ae5cdf2_834686be","updated":"2014-06-19 18:20:15.000000000","message":"Lets do this after this merges and the new API/object model code lands. Likely around Juno-3.","commit_id":"4ce8c5b57ab1185e300bb45cdf042087bec44abf"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"7727d2766cad00a7ec9324ee3e07b91c20d43aa8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"#"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":84,"context_line":"class LoadBalancerAbstractDriver(object):"},{"line_number":85,"context_line":"    \"\"\"Abstract lbaas driver that expose ~same API as lbaas plugin."},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    The configuration elements (Vip,Member,etc) are the dicts that"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ae5cdf2_834686be","line":84,"in_reply_to":"1ae5cdf2_83d8461f","updated":"2014-06-19 18:09:21.000000000","message":"+1 to what Dustin said.","commit_id":"4ce8c5b57ab1185e300bb45cdf042087bec44abf"},{"author":{"_account_id":9461,"name":"Vijay Kumar Venkatachalam","email":"vijay.venkatachalam@citrix.com","username":"vijayvenkatachalam"},"change_message_id":"7c1467413c11d69d9bb3519c32d12943190490e9","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Avishay Balderman, Radware"},{"line_number":18,"context_line":"# @author: Doug Wiegley, A10 Networks"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import abc"},{"line_number":21,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_dca3a0af","line":18,"updated":"2014-06-24 04:32:02.000000000","message":"Quoting Armando Migliaccio here: \"I appreciate these lines might be added automatically by some editors...I personally find them superfluous because authors can be tracked differently. Also, this do not pay justice to other people who contribute to this file in the future and forget to add themselves to the list. Please, consider removing it.\"","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d9a18223ff9a75fc7da6790608f351058410b300","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# @author: Avishay Balderman, Radware"},{"line_number":18,"context_line":"# @author: Doug Wiegley, A10 Networks"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import abc"},{"line_number":21,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_5cf2309c","line":18,"in_reply_to":"1ae5cdf2_dca3a0af","updated":"2014-06-24 04:39:32.000000000","message":"Ok.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":9461,"name":"Vijay Kumar Venkatachalam","email":"vijay.venkatachalam@citrix.com","username":"vijayvenkatachalam"},"change_message_id":"7c1467413c11d69d9bb3519c32d12943190490e9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.plugins.common import constants"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class NotImplementedManager(object):"},{"line_number":27,"context_line":"    \"\"\"Helper class to make any subclass of LBAbstractDriver explode if it"},{"line_number":28,"context_line":"    is missing any of the required object managers."},{"line_number":29,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_bcb7b4f7","line":26,"updated":"2014-06-24 04:32:02.000000000","message":"NotImplementedManager should derive from LBBaseManager? And moved down?","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d9a18223ff9a75fc7da6790608f351058410b300","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.plugins.common import constants"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class NotImplementedManager(object):"},{"line_number":27,"context_line":"    \"\"\"Helper class to make any subclass of LBAbstractDriver explode if it"},{"line_number":28,"context_line":"    is missing any of the required object managers."},{"line_number":29,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_bc2894ef","line":26,"in_reply_to":"1ae5cdf2_bcb7b4f7","updated":"2014-06-24 04:39:32.000000000","message":"No, NotImplementedManager exists to cause the Driver to explode if it\u0027s defined incorrectly.  It does not inherit, and must come before the driver.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7de28c926e612c2c49b3bacea657310db5c15f6c","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def failed(self, context, model, model_id):"},{"line_number":92,"context_line":"        self.driver.plugin.update_status(context, model, model_id,"},{"line_number":93,"context_line":"                                         constants.ERROR)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_bb234857","line":93,"updated":"2014-06-23 20:07:28.000000000","message":"I don\u0027t think these methods make sense for the manager.  I think the plugin can expose update_entity_status methods for each one that has a status and the driver can call that.  Or just leave it up to the driver to call driver.plugin.update_status whenever needed.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"58576a63aec256c9dc64485cda2bf4b3119e52b0","unresolved":false,"context_lines":[{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def failed(self, context, model, model_id):"},{"line_number":92,"context_line":"        self.driver.plugin.update_status(context, model, model_id,"},{"line_number":93,"context_line":"                                         constants.ERROR)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_68748efe","line":93,"in_reply_to":"1ae5cdf2_bb234857","updated":"2014-06-24 01:10:35.000000000","message":"Per the IRC conversation, I think the general opinion was that people wanted helpers, as it gets us closer to cleaning up the interface with Neutron (ie. helpers could eventually just make API calls to Neutron, and other code wouldn\u0027t need updating).\n\nI could totally have missed the context of that conversation, though: I\u0027m not sure we were talking about status helpers at the time.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"}],"neutron/services/loadbalancer/drivers/driver_base.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"417732b5a233df7331c7879342841c9086373145","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class NotImplementedManager(object):"},{"line_number":20,"context_line":"    \"\"\"Helper class to make any subclass of LBAbstractDriver explode if it"},{"line_number":21,"context_line":"    is missing any of the required object managers."},{"line_number":22,"context_line":"    \"\"\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"baada198_08deb33f","line":20,"updated":"2014-07-01 10:53:07.000000000","message":"Did you mean they should subclass LoadBalancerBaseDriver here?","commit_id":"53617ccf47c08f05fc27578a59d1b3e4b3a8488a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"417732b5a233df7331c7879342841c9086373145","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"class LoadBalancerBaseDriver(object):"},{"line_number":35,"context_line":"    \"\"\"LBaaSv2 object model drivers should subclass LBAbstractDriver, and"},{"line_number":36,"context_line":"    initialize the following manager classes to create, update, and delete"},{"line_number":37,"context_line":"    the various load balancer objects."},{"line_number":38,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":18,"id":"baada198_881ac315","line":35,"updated":"2014-07-01 10:53:07.000000000","message":"Same here.","commit_id":"53617ccf47c08f05fc27578a59d1b3e4b3a8488a"}],"neutron/services/loadbalancer/drivers/driver_mixins.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"9119059c74ada0fd4d1b2336b062dc89f93eb96d","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class BaseHealthMonitorStatusUpdateMixin(object):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def active(self, context, health_monitor_id, pool_id):"},{"line_number":76,"context_line":"        self.driver.plugin.update_pool_health_monitor(context,"},{"line_number":77,"context_line":"                                                      health_monitor_id,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_b29d010d","line":74,"updated":"2014-06-24 18:09:14.000000000","message":"I\u0027m wondering if we want every entity to have a status field.  Since an entity that exists without a link to a load balancer is just a database entry, the status would always be ACTIVE until a load balancer is actually provisioned using that entity.  When some of these entities become shareable we\u0027ll end up encountering issues where an entity failed to provision for one load balancer but provisioned correctly for another.  If the status just bubbled up to the load balancer and the load balancer status reflected the status of any of its children and it woudl not allow updates when it is in a non-ACTIVE status, I think this would be best.","commit_id":"b47e3fc28be071d14ce7e517d6fbdc25b523877d"},{"author":{"_account_id":10850,"name":"German Eichberger","email":"german.eichberger@gmail.com","username":"german"},"change_message_id":"c39b03c0f3fc371aa0b3a24ea1912b19c8f4c7c6","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"class BaseHealthMonitorStatusUpdateMixin(object):"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def active(self, context, health_monitor_id, pool_id):"},{"line_number":76,"context_line":"        self.driver.plugin.update_pool_health_monitor(context,"},{"line_number":77,"context_line":"                                                      health_monitor_id,"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ae5cdf2_ab002c01","line":74,"in_reply_to":"1ae5cdf2_b29d010d","updated":"2014-06-24 19:11:16.000000000","message":"1) The status of a non provisioned entity should be \"BUILDING\" or so... to indicate it\u0027s not active.\n\n2) There was a discussion to distinguish between Operational Status and Status.\n\n3) Mark McClain said that the LB\u0027s status should be derived in Horizon by \"averaging\" the status of all sub-components\n\nIn my opinion it is important for a user to see with one glance what the status of his load balancer is with the ability to drill down.\n\nAlso I am a bit worried about the architecture where the driver pushes the status. In general a pull model (aka a way for us to query the individual driver) allows more control and is therefore more scalable by adjusting the poll interval...","commit_id":"b47e3fc28be071d14ce7e517d6fbdc25b523877d"}],"neutron/services/loadbalancer/drivers/logging_noop/driver.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7de28c926e612c2c49b3bacea657310db5c15f6c","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, driver):"},{"line_number":74,"context_line":"        super(LoggingNoopLoadBalancerManager, self).__init__(driver)"},{"line_number":75,"context_line":"        self.model \u003d None  # TODO(dougw), use lb_db.LoadBalancer when v2 lbaas"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def refresh(self, context, lb_obj, force\u003dFalse):"},{"line_number":78,"context_line":"        # This is intended to trigger the backend to check and repair"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_dbb654f9","line":75,"updated":"2014-06-23 20:07:28.000000000","message":"This TODO can be done as part of the object model refactor implemenation.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"c0b6bdb258a5376bc35812127e5083eec627b347","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    def __init__(self, driver):"},{"line_number":74,"context_line":"        super(LoggingNoopLoadBalancerManager, self).__init__(driver)"},{"line_number":75,"context_line":"        self.model \u003d None  # TODO(dougw), use lb_db.LoadBalancer when v2 lbaas"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def refresh(self, context, lb_obj, force\u003dFalse):"},{"line_number":78,"context_line":"        # This is intended to trigger the backend to check and repair"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_61f9094e","line":75,"in_reply_to":"1ae5cdf2_dbb654f9","updated":"2014-06-24 03:47:36.000000000","message":"I was hoping you\u0027d notice that.  :-)","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"7de28c926e612c2c49b3bacea657310db5c15f6c","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        super(LoggingNoopLoadBalancerManager, self).__init__(driver)"},{"line_number":75,"context_line":"        self.model \u003d None  # TODO(dougw), use lb_db.LoadBalancer when v2 lbaas"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def refresh(self, context, lb_obj, force\u003dFalse):"},{"line_number":78,"context_line":"        # This is intended to trigger the backend to check and repair"},{"line_number":79,"context_line":"        # the state of this load balancer and all of its dependent objects"},{"line_number":80,"context_line":"        LOG.debug(\"LB pool refresh %s, force\u003d%s\", lb_obj.id, force)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_3b9c986a","line":77,"updated":"2014-06-23 20:07:28.000000000","message":"Does every LoadBalancerManager ever created need to implement this method and the stats method? If so I would suggest creating an intermediate BaseLoadBalancerManager class.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":11685,"name":"Stephen Balukoff","email":"stephen@balukoff.com","username":"sbalukoff"},"change_message_id":"58576a63aec256c9dc64485cda2bf4b3119e52b0","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        super(LoggingNoopLoadBalancerManager, self).__init__(driver)"},{"line_number":75,"context_line":"        self.model \u003d None  # TODO(dougw), use lb_db.LoadBalancer when v2 lbaas"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def refresh(self, context, lb_obj, force\u003dFalse):"},{"line_number":78,"context_line":"        # This is intended to trigger the backend to check and repair"},{"line_number":79,"context_line":"        # the state of this load balancer and all of its dependent objects"},{"line_number":80,"context_line":"        LOG.debug(\"LB pool refresh %s, force\u003d%s\", lb_obj.id, force)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_e857be58","line":77,"in_reply_to":"1ae5cdf2_3b9c986a","updated":"2014-06-24 01:10:35.000000000","message":"Presumably, yes. So yes, good suggestion. :)","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"c0b6bdb258a5376bc35812127e5083eec627b347","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        super(LoggingNoopLoadBalancerManager, self).__init__(driver)"},{"line_number":75,"context_line":"        self.model \u003d None  # TODO(dougw), use lb_db.LoadBalancer when v2 lbaas"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def refresh(self, context, lb_obj, force\u003dFalse):"},{"line_number":78,"context_line":"        # This is intended to trigger the backend to check and repair"},{"line_number":79,"context_line":"        # the state of this load balancer and all of its dependent objects"},{"line_number":80,"context_line":"        LOG.debug(\"LB pool refresh %s, force\u003d%s\", lb_obj.id, force)"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_c1973dea","line":77,"in_reply_to":"1ae5cdf2_e857be58","updated":"2014-06-24 03:47:36.000000000","message":"Yep, thanks.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":9461,"name":"Vijay Kumar Venkatachalam","email":"vijay.venkatachalam@citrix.com","username":"vijayvenkatachalam"},"change_message_id":"7c1467413c11d69d9bb3519c32d12943190490e9","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def stats(self, context, lb_obj):"},{"line_number":83,"context_line":"        LOG.debug(\"LB stats %s\", lb_obj.id)"},{"line_number":84,"context_line":"        return {"},{"line_number":85,"context_line":"            \"bytes_in\": 0,"},{"line_number":86,"context_line":"            \"bytes_out\": 0,"},{"line_number":87,"context_line":"            \"active_connections\": 0,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_9c703842","line":84,"updated":"2014-06-24 04:32:02.000000000","message":"The stats can be part of the listener manager, there are no connections to the \"IP\" of the loadbalancer.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"d9a18223ff9a75fc7da6790608f351058410b300","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def stats(self, context, lb_obj):"},{"line_number":83,"context_line":"        LOG.debug(\"LB stats %s\", lb_obj.id)"},{"line_number":84,"context_line":"        return {"},{"line_number":85,"context_line":"            \"bytes_in\": 0,"},{"line_number":86,"context_line":"            \"bytes_out\": 0,"},{"line_number":87,"context_line":"            \"active_connections\": 0,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ae5cdf2_7c460cc2","line":84,"in_reply_to":"1ae5cdf2_9c703842","updated":"2014-06-24 04:39:32.000000000","message":"Indeed, the interface is flexible enough to add that later, but it wasn\u0027t coming in this pass.","commit_id":"a30c6c1cb3d0d15e83a25874012657165ffc78a1"}],"neutron/services/loadbalancer/drivers/noop/__init__.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"2510e67e769d709977b0955bf780c34760398b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ae5cdf2_037d32b2","updated":"2014-06-19 04:13:46.000000000","message":"per latest policies: no code \u003d\u003d empty file, so copyright header should be removed and file should be left empty","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"8e166c8d9edbb4d663dfcb64ac6e61383af7109c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ae5cdf2_3effa102","in_reply_to":"1ae5cdf2_037d32b2","updated":"2014-06-19 04:21:02.000000000","message":"Ahh, ok, thanks.  Do you have a link to the policy?","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"}],"neutron/tests/unit/services/loadbalancer/drivers/logging_noop/test_logging_noop_driver.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"417732b5a233df7331c7879342841c9086373145","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def patch_manager(func):"},{"line_number":30,"context_line":"    @mock.patch(log_path)"},{"line_number":31,"context_line":"    def wrapper(*args):"},{"line_number":32,"context_line":"        log_mock \u003d args[-1]"},{"line_number":33,"context_line":"        manager_test \u003d args[0]"},{"line_number":34,"context_line":"        model \u003d args[1]"},{"line_number":35,"context_line":"        parent \u003d manager_test.parent"}],"source_content_type":"text/x-python","patch_set":18,"id":"baada198_68748fcf","line":32,"updated":"2014-07-01 10:53:07.000000000","message":"log_mock \u003d args.pop()","commit_id":"53617ccf47c08f05fc27578a59d1b3e4b3a8488a"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"6240dbafe6c5881272c1ee1257d4793426980519","unresolved":false,"context_lines":[{"line_number":29,"context_line":"def patch_manager(func):"},{"line_number":30,"context_line":"    @mock.patch(log_path)"},{"line_number":31,"context_line":"    def wrapper(*args):"},{"line_number":32,"context_line":"        log_mock \u003d args[-1]"},{"line_number":33,"context_line":"        manager_test \u003d args[0]"},{"line_number":34,"context_line":"        model \u003d args[1]"},{"line_number":35,"context_line":"        parent \u003d manager_test.parent"}],"source_content_type":"text/x-python","patch_set":18,"id":"baada198_57368ae8","line":32,"in_reply_to":"baada198_68748fcf","updated":"2014-07-09 03:54:26.000000000","message":"Good idea, I\u0027ll fix on the next change.","commit_id":"53617ccf47c08f05fc27578a59d1b3e4b3a8488a"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"417732b5a233df7331c7879342841c9086373145","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        driver \u003d parent.driver"},{"line_number":37,"context_line":"        driver.plugin.reset_mock()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        func(*args[:-1])"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        s \u003d str(log_mock.mock_calls[0])"},{"line_number":42,"context_line":"        parent.assertEqual(s[:11], \"call.debug(\")"}],"source_content_type":"text/x-python","patch_set":18,"id":"baada198_a87ea7ac","line":39,"updated":"2014-07-01 10:53:07.000000000","message":"func(*args)","commit_id":"53617ccf47c08f05fc27578a59d1b3e4b3a8488a"}],"neutron/tests/unit/services/loadbalancer/drivers/noop/__init__.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"2510e67e769d709977b0955bf780c34760398b3a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ae5cdf2_634fd692","updated":"2014-06-19 04:13:46.000000000","message":"same as in other __init__.py","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"},{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"8e166c8d9edbb4d663dfcb64ac6e61383af7109c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1ae5cdf2_de0f9d2c","in_reply_to":"1ae5cdf2_634fd692","updated":"2014-06-19 04:21:02.000000000","message":"Understood.","commit_id":"7e7e23fad1ce38eee5ccb5080fbf85d50b3ed565"}]}
