)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b78b01e5b6f3846fb0263f2b3e2dfb09a09ac299","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c060f86d_3d1de2b6","updated":"2026-10-21 17:24:47.000000000","message":"Thanks for the patch - I think it makes sense to distinguish local GW with evpn gateway. This is a soft -1 to discuss how we want to treat the option.","commit_id":"26fd507f6ece26b1cbe05ed010659cae48ad9ff2"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"1efeae52ebbba587a4778c6553ff9a40b516a748","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"28adb6e7_be3ecd5e","in_reply_to":"c060f86d_3d1de2b6","updated":"2026-10-22 15:12:31.000000000","message":"Thanks for the review. Patch set 3 follows both points, see the inline reply.","commit_id":"26fd507f6ece26b1cbe05ed010659cae48ad9ff2"},{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"4951d6f1fc2fb2bb71ecc4eea7686be97b778855","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d8bcf696_7008b6f6","updated":"2026-11-13 21:30:40.000000000","message":"Thanks for this change, we\u0027re interested in it: being able to choose which gateway chassis host EVPN routers is useful for us.\n\nIt appears the proposed change would only apply when chassis are picked: when the router gets its VNI, and when the db sync repairs it.\nAdding or removing enable-chassis-as-evpn-gw on a node afterwards changes nothing: existing evpn-hcg-* groups keep their members.\n\nWe would like the evpn plugin to react to Chassis updates, as handle_ha_chassis_group_changes() does for the neutron-* groups.\nRemoving enable-chassis-as-evpn-gw from a node would then remove it from every evpn-hcg-* within its AZs, and adding it would add it.\nThat would give a clean maintenance procedure: remove the option, let the EVPN routers move, then work on the node.","commit_id":"db47d2a02f69400b98647aba993cae90df043cbe"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/impl_idl_ovn.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b78b01e5b6f3846fb0263f2b3e2dfb09a09ac299","unresolved":true,"context_lines":[{"line_number":1114,"context_line":"        return self._filter_chassis_by_az("},{"line_number":1115,"context_line":"            [ch for ch in chassis if utils.is_gateway_chassis(ch)], az_hints)"},{"line_number":1116,"context_line":""},{"line_number":1117,"context_line":"    def get_evpn_gateway_chassis_with_az_filter(self, az_hints\u003dNone):"},{"line_number":1118,"context_line":"        chassis \u003d self.chassis_list().execute(check_error\u003dTrue)"},{"line_number":1119,"context_line":"        if any(utils.is_evpn_gateway_chassis(ch) for ch in chassis):"},{"line_number":1120,"context_line":"            eligible \u003d [ch for ch in chassis"},{"line_number":1121,"context_line":"                        if utils.is_gateway_chassis(ch) and"},{"line_number":1122,"context_line":"                        utils.is_evpn_gateway_chassis(ch)]"},{"line_number":1123,"context_line":"        else:"},{"line_number":1124,"context_line":"            eligible \u003d [ch for ch in chassis if utils.is_gateway_chassis(ch)]"},{"line_number":1125,"context_line":"        return self._filter_chassis_by_az(eligible, az_hints)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    def get_all_chassis(self, chassis_type\u003dNone):"},{"line_number":1128,"context_line":"        # TODO(azbiswas): Use chassis_type as input once the compute type"}],"source_content_type":"text/x-python","patch_set":2,"id":"bfde5fd9_062dde77","line":1125,"range":{"start_line":1117,"start_character":0,"end_line":1125,"end_character":61},"updated":"2026-10-21 17:24:47.000000000","message":"I\u0027d like to discuss the complexity and the logic of this.\n\nThe logic: I think it will be better to enforce the `enable-chassis-as-evpn-gw` and document the upgrade impact. The option can be set pre-upgrade and after new bits are started, it will use the new option. There can be a weird state when come controllers running Neutron are old and some are new but that happens with the proposed code as well.\n\nThe complexity: At scale, the code possibly checks all compute nodes and then iterates over the same compute nodes again. If we want to keep the two-fold solution, I think it can be done with a single loop.","commit_id":"26fd507f6ece26b1cbe05ed010659cae48ad9ff2"},{"author":{"_account_id":39426,"name":"fivetime","display_name":"fivetime","email":"td@fivetime.ltd","username":"fivetime"},"change_message_id":"1efeae52ebbba587a4778c6553ff9a40b516a748","unresolved":false,"context_lines":[{"line_number":1122,"context_line":"                        utils.is_evpn_gateway_chassis(ch)]"},{"line_number":1123,"context_line":"        else:"},{"line_number":1124,"context_line":"            eligible \u003d [ch for ch in chassis if utils.is_gateway_chassis(ch)]"},{"line_number":1125,"context_line":"        return self._filter_chassis_by_az(eligible, az_hints)"},{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"    def get_all_chassis(self, chassis_type\u003dNone):"},{"line_number":1128,"context_line":"        # TODO(azbiswas): Use chassis_type as input once the compute type"}],"source_content_type":"text/x-python","patch_set":2,"id":"12719458_c47eb30a","line":1125,"in_reply_to":"bfde5fd9_062dde77","updated":"2026-10-22 15:12:31.000000000","message":"Agreed on both. Patch set 3:\n\n- enforces the option: only gateway chassis that also set enable-chassis-as-evpn-gw are eligible, with no fallback to every gateway chassis;\n- selects them in a single pass over the chassis;\n- adds an upgrade section to the release note: set the option on the EVPN gateways before upgrading the Neutron servers. Existing EVPN routers keep their HA chassis group; a router created, or repaired by the sync, while no chassis is marked gets no chassis, and the plugin\u0027s warning now names the option;\n- adds a functional test for the case where no chassis is marked, and updates the docs and the unit test.","commit_id":"26fd507f6ece26b1cbe05ed010659cae48ad9ff2"}],"neutron/services/evpn/db_sync.py":[{"author":{"_account_id":7156,"name":"Mathieu Gagné","email":"mgagne@calavera.ca","username":"mgagne"},"change_message_id":"4951d6f1fc2fb2bb71ecc4eea7686be97b778855","unresolved":true,"context_lines":[{"line_number":229,"context_line":"            lsp_name \u003d evpn_helpers.evpn_lsp_name(router_id, vni)"},{"line_number":230,"context_line":"            if any(name in missing"},{"line_number":231,"context_line":"                   for name, missing in ((ls_name, missing_ls),"},{"line_number":232,"context_line":"                                         (hcg_name, missing_hcg),"},{"line_number":233,"context_line":"                                         (lrp_name, missing_lrp),"},{"line_number":234,"context_line":"                                         (lsp_name, missing_lsp))):"},{"line_number":235,"context_line":"                routers_to_repair.add(router_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"681a6592_c484fa2a","line":232,"updated":"2026-11-13 21:30:40.000000000","message":"The doc says a router created while no chassis sets the option is hosted once a chassis is marked and the sync repairs it.\nThe sync only repairs routers with a missing object, so it never repairs this one, and it stays unhosted.","commit_id":"db47d2a02f69400b98647aba993cae90df043cbe"}]}
