)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89d37fb3d46808dc379f75690c4c0618247526a3","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Port-binding event matching holds the SB connection lock. Looking up"},{"line_number":10,"context_line":"an NB logical switch port there can deadlock with gateway scheduling,"},{"line_number":11,"context_line":"which holds the NB lock while reading SB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Move the NB lookup and enabled/up checks to the queued event handler."},{"line_number":14,"context_line":"Keep chassis and migration filters in ``match_fn()``. Add a real-OVN"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ef1f654c_a03e0eae","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":23},"updated":"2026-10-22 08:51:31.000000000","message":"I would mention the ovsdbapp patch that added this lookup lock: https://review.opendev.org/c/openstack/ovsdbapp/+/745746","commit_id":"503be4a2094dfc887b5f0f64af020446d37ad61d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c74cb5298f280f874d659331773b8d7a5ebd38de","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Port-binding event matching holds the SB connection lock. Looking up"},{"line_number":10,"context_line":"an NB logical switch port there can deadlock with gateway scheduling,"},{"line_number":11,"context_line":"which holds the NB lock while reading SB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Move the NB lookup and enabled/up checks to the queued event handler."},{"line_number":14,"context_line":"Keep chassis and migration filters in ``match_fn()``. Add a real-OVN"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0243c855_fb4569e4","line":11,"range":{"start_line":11,"start_character":16,"end_line":11,"end_character":23},"in_reply_to":"ef1f654c_a03e0eae","updated":"2026-10-22 10:29:00.000000000","message":"Done","commit_id":"503be4a2094dfc887b5f0f64af020446d37ad61d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89d37fb3d46808dc379f75690c4c0618247526a3","unresolved":true,"context_lines":[{"line_number":10,"context_line":"an NB logical switch port there can deadlock with gateway scheduling,"},{"line_number":11,"context_line":"which holds the NB lock while reading SB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Move the NB lookup and enabled/up checks to the queued event handler."},{"line_number":14,"context_line":"Keep chassis and migration filters in ``match_fn()``. Add a real-OVN"},{"line_number":15,"context_line":"regression that holds NB during a chassis update and requires SB reads"},{"line_number":16,"context_line":"to complete, plus coverage for a port deleted before event processing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"503b672b_79a410d3","line":13,"updated":"2026-10-22 08:51:31.000000000","message":"In this patch you are avoiding the NB lookup in a SB event. But you are not fixing the SB lookup (chassis list) in the NB event.","commit_id":"503be4a2094dfc887b5f0f64af020446d37ad61d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c74cb5298f280f874d659331773b8d7a5ebd38de","unresolved":false,"context_lines":[{"line_number":10,"context_line":"an NB logical switch port there can deadlock with gateway scheduling,"},{"line_number":11,"context_line":"which holds the NB lock while reading SB."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Move the NB lookup and enabled/up checks to the queued event handler."},{"line_number":14,"context_line":"Keep chassis and migration filters in ``match_fn()``. Add a real-OVN"},{"line_number":15,"context_line":"regression that holds NB during a chassis update and requires SB reads"},{"line_number":16,"context_line":"to complete, plus coverage for a port deleted before event processing."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4bc2d8fa_d8140837","line":13,"in_reply_to":"503b672b_79a410d3","updated":"2026-10-22 10:29:00.000000000","message":"Done","commit_id":"503be4a2094dfc887b5f0f64af020446d37ad61d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89d37fb3d46808dc379f75690c4c0618247526a3","unresolved":true,"context_lines":[{"line_number":15,"context_line":"regression that holds NB during a chassis update and requires SB reads"},{"line_number":16,"context_line":"to complete, plus coverage for a port deleted before event processing."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related: https://review.opendev.org/c/openstack/neutron/+/993909"},{"line_number":19,"context_line":"Closes-Bug: #2095566"},{"line_number":20,"context_line":"Generated-By: Codex GPT-6"},{"line_number":21,"context_line":"Assisted-By: GPT-6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"af8738d6_57a7ce8c","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":64},"updated":"2026-10-22 08:51:31.000000000","message":"I won\u0027t add this comment here","commit_id":"503be4a2094dfc887b5f0f64af020446d37ad61d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c74cb5298f280f874d659331773b8d7a5ebd38de","unresolved":false,"context_lines":[{"line_number":15,"context_line":"regression that holds NB during a chassis update and requires SB reads"},{"line_number":16,"context_line":"to complete, plus coverage for a port deleted before event processing."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Related: https://review.opendev.org/c/openstack/neutron/+/993909"},{"line_number":19,"context_line":"Closes-Bug: #2095566"},{"line_number":20,"context_line":"Generated-By: Codex GPT-6"},{"line_number":21,"context_line":"Assisted-By: GPT-6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"06f3dddf_0f7c05b0","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":64},"in_reply_to":"af8738d6_57a7ce8c","updated":"2026-10-22 10:29:00.000000000","message":"Done","commit_id":"503be4a2094dfc887b5f0f64af020446d37ad61d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c74cb5298f280f874d659331773b8d7a5ebd38de","unresolved":true,"context_lines":[{"line_number":24,"context_line":"[1] https://review.opendev.org/c/openstack/ovsdbapp/+/745746"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #2095566"},{"line_number":27,"context_line":"Generated-By: Codex GPT-6"},{"line_number":28,"context_line":"Signed-off-by: Adam Harwell \u003cflux.adam@gmail.com\u003e"},{"line_number":29,"context_line":"Change-Id: I6e479127634702e4f84daba0926ab2b02ed3b3ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1598666f_b496cffc","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":12},"updated":"2026-10-22 10:29:00.000000000","message":"`Assisted-By`, this is the tag that must be used for OpenStack patches","commit_id":"7fb34265edb3db7a831aebc4bf5a750a2f80ca13"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"078c399ea9dac609acb4fb239607f836f92bfd89","unresolved":true,"context_lines":[{"line_number":24,"context_line":"[1] https://review.opendev.org/c/openstack/ovsdbapp/+/745746"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #2095566"},{"line_number":27,"context_line":"Generated-By: Codex GPT-6"},{"line_number":28,"context_line":"Signed-off-by: Adam Harwell \u003cflux.adam@gmail.com\u003e"},{"line_number":29,"context_line":"Change-Id: I6e479127634702e4f84daba0926ab2b02ed3b3ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dc29ecbf_63c3e227","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":12},"in_reply_to":"1598666f_b496cffc","updated":"2026-10-22 14:47:26.000000000","message":"Ah, they changed it again since I looked last I guess…\n \n\u003e We recommend using “Assisted-By” moving forward, though “Generated-By” is still approved in this policy, and may be found in the commit history of some OpenInfra projects\n\nStill technically valid, but I’ll change it if I do another patchset, unless you’d prefer I do one just for the commit message? I guess it isn’t that big a deal, I just try not to waste Zuul nodes.","commit_id":"7fb34265edb3db7a831aebc4bf5a750a2f80ca13"},{"author":{"_account_id":10273,"name":"Adam Harwell","email":"flux.adam@gmail.com","username":"rm_you"},"change_message_id":"5ba391a5fb28050c572e09ab6df014f8bf693c14","unresolved":false,"context_lines":[{"line_number":24,"context_line":"[1] https://review.opendev.org/c/openstack/ovsdbapp/+/745746"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"Closes-Bug: #2095566"},{"line_number":27,"context_line":"Generated-By: Codex GPT-6"},{"line_number":28,"context_line":"Signed-off-by: Adam Harwell \u003cflux.adam@gmail.com\u003e"},{"line_number":29,"context_line":"Change-Id: I6e479127634702e4f84daba0926ab2b02ed3b3ef"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d22e6bea_39adfcab","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":12},"in_reply_to":"dc29ecbf_63c3e227","updated":"2026-10-27 20:51:37.000000000","message":"Updated it, why not 😅","commit_id":"7fb34265edb3db7a831aebc4bf5a750a2f80ca13"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"89d37fb3d46808dc379f75690c4c0618247526a3","unresolved":true,"context_lines":[{"line_number":361,"context_line":"        # notification thread to avoid deadlocking with NB transactions"},{"line_number":362,"context_line":"        # that read SB while scheduling gateway chassis."},{"line_number":363,"context_line":"        try:"},{"line_number":364,"context_line":"            lsp \u003d self.driver.nb_ovn.lookup(\u0027Logical_Switch_Port\u0027,"},{"line_number":365,"context_line":"                                            row.logical_port)"},{"line_number":366,"context_line":"        except idlutils.RowNotFound:"},{"line_number":367,"context_line":"            LOG.warning(\"Logical Switch Port %(port)s not found for \""}],"source_content_type":"text/x-python","patch_set":1,"id":"b15f85f4_84361529","line":364,"range":{"start_line":364,"start_character":37,"end_line":364,"end_character":43},"updated":"2026-10-22 08:51:31.000000000","message":"I would also implement a dirty lookup in ovsdbapp, that doesn\u0027t require a lock. But this implementation should be blessed by Terry","commit_id":"503be4a2094dfc887b5f0f64af020446d37ad61d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"48874d4d137f2b3b2eeef4dbb39aa5ecf2220da7","unresolved":true,"context_lines":[{"line_number":361,"context_line":"        # notification thread to avoid deadlocking with NB transactions"},{"line_number":362,"context_line":"        # that read SB while scheduling gateway chassis."},{"line_number":363,"context_line":"        try:"},{"line_number":364,"context_line":"            lsp \u003d self.driver.nb_ovn.lookup(\u0027Logical_Switch_Port\u0027,"},{"line_number":365,"context_line":"                                            row.logical_port)"},{"line_number":366,"context_line":"        except idlutils.RowNotFound:"},{"line_number":367,"context_line":"            LOG.warning(\"Logical Switch Port %(port)s not found for \""}],"source_content_type":"text/x-python","patch_set":1,"id":"4bdf15ef_a1537a65","line":364,"range":{"start_line":364,"start_character":37,"end_line":364,"end_character":43},"in_reply_to":"b15f85f4_84361529","updated":"2026-10-22 09:10:20.000000000","message":"Ok, I was mixing DB locks with connections locks. This is the second (`self.lock \u003d threading.RLock()`)\n\nSo executing the NB lookup here, outside the SB connection lock (because we are in the notify_loop thread), makes sense and unravels the possible cross lock","commit_id":"503be4a2094dfc887b5f0f64af020446d37ad61d"}]}
