)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3f15fcc076e9f23aedc8be8063cfc5a57f8b01cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b475c8ef_c810de48","updated":"2026-11-11 12:23:53.000000000","message":"The bug is legit and the code looks almost fine.\n\nPlease create a LP bug (https://bugs.launchpad.net/neutron) in order to document this issue.","commit_id":"f80f731401b7aaf2cf282bd8f5a7d523f59415ec"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovsdb_monitor.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3f15fcc076e9f23aedc8be8063cfc5a57f8b01cd","unresolved":true,"context_lines":[{"line_number":895,"context_line":"    def __init__(self, driver):"},{"line_number":896,"context_line":"        self.driver \u003d driver"},{"line_number":897,"context_line":"        table \u003d \u0027Load_Balancer\u0027"},{"line_number":898,"context_line":"        events \u003d (self.ROW_CREATE, self.ROW_DELETE)"},{"line_number":899,"context_line":"        super().__init__(events, table, None)"},{"line_number":900,"context_line":"        self.event_name \u003d \u0027PortForwardingLBAddDeleteEvent\u0027"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7953b48a_7fcef922","line":898,"range":{"start_line":898,"start_character":18,"end_line":898,"end_character":50},"updated":"2026-11-11 12:23:53.000000000","message":"What if the LB is updated, adding or deleting a VIP?","commit_id":"f80f731401b7aaf2cf282bd8f5a7d523f59415ec"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0baac794f75b2fbd23ff8fb6262cadcb2215fc7e","unresolved":true,"context_lines":[{"line_number":895,"context_line":"    def __init__(self, driver):"},{"line_number":896,"context_line":"        self.driver \u003d driver"},{"line_number":897,"context_line":"        table \u003d \u0027Load_Balancer\u0027"},{"line_number":898,"context_line":"        events \u003d (self.ROW_CREATE, self.ROW_DELETE)"},{"line_number":899,"context_line":"        super().__init__(events, table, None)"},{"line_number":900,"context_line":"        self.event_name \u003d \u0027PortForwardingLBAddDeleteEvent\u0027"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"f709dec8_cffa8fe9","line":898,"range":{"start_line":898,"start_character":18,"end_line":898,"end_character":50},"in_reply_to":"7953b48a_7fcef922","updated":"2026-11-11 18:40:18.000000000","message":"Port forwarding LBs are created per FIP and protocol, and all their VIPs are \u003cFIP\u003e:\u003cexternal_port\u003e, so they share the same IP address.The LB row is created with the first port forwarding and deleted by lb_del when the last VIP is removed...Adding or removing a VIP only changes the port.\n\nThe IP address and the MAC answering for it (the router gateway port MAC) stay the same, so there is nothing new to clean.\n\nFIPAddDeleteEvent handles NAT updates only when external_mac changes. For port forwarding VIPs the equivalent is a change of the gateway port, which is covered by LogicalRouterGatewayPortDeleteEvent.\n\nPlease, mark as resolved if it is OK.","commit_id":"f80f731401b7aaf2cf282bd8f5a7d523f59415ec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"c41dacc9d4933e9043de55c1ffd1f0cce1702a1e","unresolved":false,"context_lines":[{"line_number":895,"context_line":"    def __init__(self, driver):"},{"line_number":896,"context_line":"        self.driver \u003d driver"},{"line_number":897,"context_line":"        table \u003d \u0027Load_Balancer\u0027"},{"line_number":898,"context_line":"        events \u003d (self.ROW_CREATE, self.ROW_DELETE)"},{"line_number":899,"context_line":"        super().__init__(events, table, None)"},{"line_number":900,"context_line":"        self.event_name \u003d \u0027PortForwardingLBAddDeleteEvent\u0027"},{"line_number":901,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4c9982e4_230b6cfc","line":898,"range":{"start_line":898,"start_character":18,"end_line":898,"end_character":50},"in_reply_to":"f709dec8_cffa8fe9","updated":"2026-11-12 12:24:53.000000000","message":"Done","commit_id":"f80f731401b7aaf2cf282bd8f5a7d523f59415ec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3f15fcc076e9f23aedc8be8063cfc5a57f8b01cd","unresolved":true,"context_lines":[{"line_number":897,"context_line":"        table \u003d \u0027Load_Balancer\u0027"},{"line_number":898,"context_line":"        events \u003d (self.ROW_CREATE, self.ROW_DELETE)"},{"line_number":899,"context_line":"        super().__init__(events, table, None)"},{"line_number":900,"context_line":"        self.event_name \u003d \u0027PortForwardingLBAddDeleteEvent\u0027"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    def match_fn(self, event, row, old\u003dNone):"},{"line_number":903,"context_line":"        return (row.external_ids.get(ovn_const.OVN_DEVICE_OWNER_EXT_ID_KEY) \u003d\u003d"},{"line_number":904,"context_line":"                pf_const.PORT_FORWARDING_PLUGIN)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff6208ff_d2812b69","line":901,"range":{"start_line":900,"start_character":8,"end_line":901,"end_character":1},"updated":"2026-11-11 12:23:53.000000000","message":"This is no longer needed, the event name will adopt, by default, the class name.","commit_id":"f80f731401b7aaf2cf282bd8f5a7d523f59415ec"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0baac794f75b2fbd23ff8fb6262cadcb2215fc7e","unresolved":false,"context_lines":[{"line_number":897,"context_line":"        table \u003d \u0027Load_Balancer\u0027"},{"line_number":898,"context_line":"        events \u003d (self.ROW_CREATE, self.ROW_DELETE)"},{"line_number":899,"context_line":"        super().__init__(events, table, None)"},{"line_number":900,"context_line":"        self.event_name \u003d \u0027PortForwardingLBAddDeleteEvent\u0027"},{"line_number":901,"context_line":""},{"line_number":902,"context_line":"    def match_fn(self, event, row, old\u003dNone):"},{"line_number":903,"context_line":"        return (row.external_ids.get(ovn_const.OVN_DEVICE_OWNER_EXT_ID_KEY) \u003d\u003d"},{"line_number":904,"context_line":"                pf_const.PORT_FORWARDING_PLUGIN)"}],"source_content_type":"text/x-python","patch_set":2,"id":"61b1dd9a_f2a5846b","line":901,"range":{"start_line":900,"start_character":8,"end_line":901,"end_character":1},"in_reply_to":"ff6208ff_d2812b69","updated":"2026-11-11 18:40:18.000000000","message":"Done","commit_id":"f80f731401b7aaf2cf282bd8f5a7d523f59415ec"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"3f15fcc076e9f23aedc8be8063cfc5a57f8b01cd","unresolved":true,"context_lines":[{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    @staticmethod"},{"line_number":907,"context_line":"    def _vip_address(vip):"},{"line_number":908,"context_line":"        # A VIP is \"IPv4:port\", \"[IPv6]:port\" or an address alone."},{"line_number":909,"context_line":"        if vip.startswith(\u0027[\u0027):"},{"line_number":910,"context_line":"            return vip[1:vip.index(\u0027]\u0027)]"},{"line_number":911,"context_line":"        if vip.count(\u0027:\u0027) \u003d\u003d 1:"},{"line_number":912,"context_line":"            return vip.split(\u0027:\u0027)[0]"},{"line_number":913,"context_line":"        return vip"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"    def run(self, event, row, old):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb78e4f_62bb17bd","line":912,"range":{"start_line":908,"start_character":8,"end_line":912,"end_character":36},"updated":"2026-11-11 12:23:53.000000000","message":"There is a more robust way to do this using netaddr:\n```\nip \u003d netaddr.IPAddress(vip.rsplit(\u0027:\u0027, 1)[0].strip(\u0027[]\u0027))\n```","commit_id":"f80f731401b7aaf2cf282bd8f5a7d523f59415ec"},{"author":{"_account_id":27339,"name":"Michal Arbet","email":"michal.arbet@ultimum.io","username":"michalarbet"},"change_message_id":"0baac794f75b2fbd23ff8fb6262cadcb2215fc7e","unresolved":false,"context_lines":[{"line_number":905,"context_line":""},{"line_number":906,"context_line":"    @staticmethod"},{"line_number":907,"context_line":"    def _vip_address(vip):"},{"line_number":908,"context_line":"        # A VIP is \"IPv4:port\", \"[IPv6]:port\" or an address alone."},{"line_number":909,"context_line":"        if vip.startswith(\u0027[\u0027):"},{"line_number":910,"context_line":"            return vip[1:vip.index(\u0027]\u0027)]"},{"line_number":911,"context_line":"        if vip.count(\u0027:\u0027) \u003d\u003d 1:"},{"line_number":912,"context_line":"            return vip.split(\u0027:\u0027)[0]"},{"line_number":913,"context_line":"        return vip"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"    def run(self, event, row, old):"}],"source_content_type":"text/x-python","patch_set":2,"id":"35aaeb15_463313f8","line":912,"range":{"start_line":908,"start_character":8,"end_line":912,"end_character":36},"in_reply_to":"ffb78e4f_62bb17bd","updated":"2026-11-11 18:40:18.000000000","message":"Done","commit_id":"f80f731401b7aaf2cf282bd8f5a7d523f59415ec"}]}
