)]}'
{"neutron/agent/ovn/agent/ovsdb.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44f1be160602acfb54ed5dbc4287024ef4384a66","unresolved":true,"context_lines":[{"line_number":157,"context_line":"def get_port_qos(nb_idl, port_id):"},{"line_number":158,"context_line":"    \"\"\"Retrieve the QoS egress max-bw and min-bw values (in kbps) of a LSP"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    Depending on the network type (tunnelled or not), the max-bw value can be"},{"line_number":161,"context_line":"    defined in a QoS register (tunnelled network) or in the LSP.options"},{"line_number":162,"context_line":"    (physical network)."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    There could be max-bw rules ingress (to-lport) and egress (from-lport);"},{"line_number":165,"context_line":"    this method is only returning the egress one. The min-bw rule is only"}],"source_content_type":"text/x-python","patch_set":4,"id":"dcf69e68_7670c8a2","side":"PARENT","line":162,"range":{"start_line":160,"start_character":4,"end_line":162,"end_character":23},"updated":"2026-11-16 09:34:29.000000000","message":"Why removing this explanation? That informs better about which one is needed","commit_id":"20ce30595fac726ca6793252cffe62400a2855ee"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cc28ac685ef9daa1d345aa1f2c9fe2ddb8370226","unresolved":true,"context_lines":[{"line_number":157,"context_line":"def get_port_qos(nb_idl, port_id):"},{"line_number":158,"context_line":"    \"\"\"Retrieve the QoS egress max-bw and min-bw values (in kbps) of a LSP"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"    Depending on the network type (tunnelled or not), the max-bw value can be"},{"line_number":161,"context_line":"    defined in a QoS register (tunnelled network) or in the LSP.options"},{"line_number":162,"context_line":"    (physical network)."},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    There could be max-bw rules ingress (to-lport) and egress (from-lport);"},{"line_number":165,"context_line":"    this method is only returning the egress one. The min-bw rule is only"}],"source_content_type":"text/x-python","patch_set":4,"id":"cb90d703_eb4be37e","side":"PARENT","line":162,"range":{"start_line":160,"start_character":4,"end_line":162,"end_character":23},"in_reply_to":"dcf69e68_7670c8a2","updated":"2026-11-18 01:10:38.000000000","message":"You are right. I restored it to its original form","commit_id":"20ce30595fac726ca6793252cffe62400a2855ee"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44f1be160602acfb54ed5dbc4287024ef4384a66","unresolved":true,"context_lines":[{"line_number":176,"context_line":"                lsp.external_ids[ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY])"},{"line_number":177,"context_line":"    ls \u003d nb_idl.lookup(\u0027Logical_Switch\u0027, net_name)"},{"line_number":178,"context_line":"    for qos_rule in ls.qos_rules:"},{"line_number":179,"context_line":"        if (qos_rule.direction !\u003d \u0027from-lport\u0027 or"},{"line_number":180,"context_line":"                qos_rule.external_ids.get(ovn_const.OVN_PORT_EXT_ID_KEY) !\u003d"},{"line_number":181,"context_line":"                port_id or \u0027rate\u0027 not in qos_rule.bandwidth):"},{"line_number":182,"context_line":"            continue"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        max_kbps \u003d int(qos_rule.bandwidth[\u0027rate\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"0df56f5f_efbd6bec","line":181,"range":{"start_line":179,"start_character":9,"end_line":181,"end_character":61},"updated":"2026-11-16 09:34:29.000000000","message":"Can you explain a bit this change?","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cc28ac685ef9daa1d345aa1f2c9fe2ddb8370226","unresolved":true,"context_lines":[{"line_number":176,"context_line":"                lsp.external_ids[ovn_const.OVN_NETWORK_NAME_EXT_ID_KEY])"},{"line_number":177,"context_line":"    ls \u003d nb_idl.lookup(\u0027Logical_Switch\u0027, net_name)"},{"line_number":178,"context_line":"    for qos_rule in ls.qos_rules:"},{"line_number":179,"context_line":"        if (qos_rule.direction !\u003d \u0027from-lport\u0027 or"},{"line_number":180,"context_line":"                qos_rule.external_ids.get(ovn_const.OVN_PORT_EXT_ID_KEY) !\u003d"},{"line_number":181,"context_line":"                port_id or \u0027rate\u0027 not in qos_rule.bandwidth):"},{"line_number":182,"context_line":"            continue"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        max_kbps \u003d int(qos_rule.bandwidth[\u0027rate\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"b0cccf21_6bb364e4","line":181,"range":{"start_line":179,"start_character":9,"end_line":181,"end_character":61},"in_reply_to":"0df56f5f_efbd6bec","updated":"2026-11-18 01:10:38.000000000","message":"I let my agent include in this patch a fix to what I believe is a bug independent of this change. I removed this fix from this patch, filed a LP bug (https://bugs.launchpad.net/neutron/+bug/2174790) and proposed a separate fix (https://review.opendev.org/c/openstack/neutron/+/1016175) that can be evaluated by you and others on its own merits.","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44f1be160602acfb54ed5dbc4287024ef4384a66","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                port_id or \u0027rate\u0027 not in qos_rule.bandwidth):"},{"line_number":182,"context_line":"            continue"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        max_kbps \u003d int(qos_rule.bandwidth[\u0027rate\u0027])"},{"line_number":185,"context_line":"        break"},{"line_number":186,"context_line":"    else:"},{"line_number":187,"context_line":"        # The \"qos_max_rate\" is stored in bits/s"}],"source_content_type":"text/x-python","patch_set":4,"id":"681c00b5_a8fd40fe","line":184,"range":{"start_line":184,"start_character":18,"end_line":184,"end_character":50},"updated":"2026-11-16 09:34:29.000000000","message":"Why this change?","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cc28ac685ef9daa1d345aa1f2c9fe2ddb8370226","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                port_id or \u0027rate\u0027 not in qos_rule.bandwidth):"},{"line_number":182,"context_line":"            continue"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        max_kbps \u003d int(qos_rule.bandwidth[\u0027rate\u0027])"},{"line_number":185,"context_line":"        break"},{"line_number":186,"context_line":"    else:"},{"line_number":187,"context_line":"        # The \"qos_max_rate\" is stored in bits/s"}],"source_content_type":"text/x-python","patch_set":4,"id":"22f3cf15_275b19d6","line":184,"range":{"start_line":184,"start_character":18,"end_line":184,"end_character":50},"in_reply_to":"681c00b5_a8fd40fe","updated":"2026-11-18 01:10:38.000000000","message":"same response as above","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/qos.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44f1be160602acfb54ed5dbc4287024ef4384a66","unresolved":true,"context_lines":[{"line_number":417,"context_line":"            if qos_policy_id \u003d\u003d original_qos_policy_id:"},{"line_number":418,"context_line":"                return  # No QoS policy change"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        if lswitch_name is None and not utils.network_needs_lswitch("},{"line_number":421,"context_line":"                context, network_id\u003dport[\u0027network_id\u0027]):"},{"line_number":422,"context_line":"            ovn_port \u003d self.nb_idl.lookup("},{"line_number":423,"context_line":"                \u0027Logical_Switch_Port\u0027, port[\u0027id\u0027], default\u003dNone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"30b9df2d_a24d3993","line":420,"range":{"start_line":420,"start_character":8,"end_line":420,"end_character":67},"updated":"2026-11-16 09:34:29.000000000","message":"Is it possible another combination? Why I mean: if the port belongs to a segmented network (`network_needs_lswitch` will return False), the `lswitch_name` will be false too.","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cc28ac685ef9daa1d345aa1f2c9fe2ddb8370226","unresolved":true,"context_lines":[{"line_number":417,"context_line":"            if qos_policy_id \u003d\u003d original_qos_policy_id:"},{"line_number":418,"context_line":"                return  # No QoS policy change"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"        if lswitch_name is None and not utils.network_needs_lswitch("},{"line_number":421,"context_line":"                context, network_id\u003dport[\u0027network_id\u0027]):"},{"line_number":422,"context_line":"            ovn_port \u003d self.nb_idl.lookup("},{"line_number":423,"context_line":"                \u0027Logical_Switch_Port\u0027, port[\u0027id\u0027], default\u003dNone)"}],"source_content_type":"text/x-python","patch_set":4,"id":"72c9e039_c6c08c60","line":420,"range":{"start_line":420,"start_character":8,"end_line":420,"end_character":67},"in_reply_to":"30b9df2d_a24d3993","updated":"2026-11-18 01:10:38.000000000","message":"Yes, we need both checks","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44f1be160602acfb54ed5dbc4287024ef4384a66","unresolved":true,"context_lines":[{"line_number":593,"context_line":"            for network_id in bound_networks:"},{"line_number":594,"context_line":"                network \u003d self._plugin.get_network("},{"line_number":595,"context_line":"                    context.elevated(), network_id)"},{"line_number":596,"context_line":"                network[\u0027qos_policy_id\u0027] \u003d policy.id"},{"line_number":597,"context_line":"                if utils.network_needs_lswitch(context, network\u003dnetwork):"},{"line_number":598,"context_line":"                    ls \u003d self.nb_idl.ls_get("},{"line_number":599,"context_line":"                        utils.ovn_name(network_id)).execute(check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"64692c6b_6f46ff44","line":596,"range":{"start_line":596,"start_character":16,"end_line":596,"end_character":52},"updated":"2026-11-16 09:34:29.000000000","message":"This is not the place to update the Neutron DB, that must be done before calling the OVN QoS extension.","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cc28ac685ef9daa1d345aa1f2c9fe2ddb8370226","unresolved":true,"context_lines":[{"line_number":593,"context_line":"            for network_id in bound_networks:"},{"line_number":594,"context_line":"                network \u003d self._plugin.get_network("},{"line_number":595,"context_line":"                    context.elevated(), network_id)"},{"line_number":596,"context_line":"                network[\u0027qos_policy_id\u0027] \u003d policy.id"},{"line_number":597,"context_line":"                if utils.network_needs_lswitch(context, network\u003dnetwork):"},{"line_number":598,"context_line":"                    ls \u003d self.nb_idl.ls_get("},{"line_number":599,"context_line":"                        utils.ovn_name(network_id)).execute(check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3c60fe5b_17035882","line":596,"range":{"start_line":596,"start_character":16,"end_line":596,"end_character":52},"in_reply_to":"64692c6b_6f46ff44","updated":"2026-11-18 01:10:38.000000000","message":"That was unnecessary. Removed","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"}],"neutron/plugins/ml2/drivers/ovn/mech_driver/ovsdb/ovn_client.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"44f1be160602acfb54ed5dbc4287024ef4384a66","unresolved":true,"context_lines":[{"line_number":922,"context_line":""},{"line_number":923,"context_line":"            self._qos_driver.update_port("},{"line_number":924,"context_line":"                context, txn, port, port_object, reset\u003dport_object is None,"},{"line_number":925,"context_line":"                lswitch_name\u003dls_name)"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"            if self.is_dns_required_for_port(port):"},{"line_number":928,"context_line":"                self.add_txns_to_sync_port_dns_records("}],"source_content_type":"text/x-python","patch_set":4,"id":"3ef4e48b_aab10de1","line":925,"range":{"start_line":925,"start_character":16,"end_line":925,"end_character":28},"updated":"2026-11-16 09:34:29.000000000","message":"nit: Why using a different var name?","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"cc28ac685ef9daa1d345aa1f2c9fe2ddb8370226","unresolved":true,"context_lines":[{"line_number":922,"context_line":""},{"line_number":923,"context_line":"            self._qos_driver.update_port("},{"line_number":924,"context_line":"                context, txn, port, port_object, reset\u003dport_object is None,"},{"line_number":925,"context_line":"                lswitch_name\u003dls_name)"},{"line_number":926,"context_line":""},{"line_number":927,"context_line":"            if self.is_dns_required_for_port(port):"},{"line_number":928,"context_line":"                self.add_txns_to_sync_port_dns_records("}],"source_content_type":"text/x-python","patch_set":4,"id":"245b4745_d43f0555","line":925,"range":{"start_line":925,"start_character":16,"end_line":925,"end_character":28},"in_reply_to":"3ef4e48b_aab10de1","updated":"2026-11-18 01:10:38.000000000","message":"Lines 918 to 921 were added in a previous patch, so ls_name could be passed below to add_txns_to_sync_port_dns_records.","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"}],"neutron/tests/functional/plugins/ml2/drivers/ovn/mech_driver/ovsdb/extensions/test_qos.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9fb04aed82a2854229fd87e5bcc55cae3375fb0c","unresolved":false,"context_lines":[{"line_number":331,"context_line":"            self.assertIn(port[\u0027id\u0027], [lsp.name for lsp in ls.ports])"},{"line_number":332,"context_line":"            rules \u003d ["},{"line_number":333,"context_line":"                {\u0027direction\u0027: rule.direction, \u0027match\u0027: rule.match,"},{"line_number":334,"context_line":"                 \u0027bandwidth\u0027: dict(rule.bandwidth), \u0027action\u0027: dict(rule.action),"},{"line_number":335,"context_line":"                 \u0027external_ids\u0027: dict(rule.external_ids)}"},{"line_number":336,"context_line":"                for rule in ls.qos_rules"},{"line_number":337,"context_line":"                if rule.external_ids.get(ovn_const.OVN_PORT_EXT_ID_KEY) \u003d\u003d"}],"source_content_type":"text/x-python","patch_set":1,"id":"3dcd1079_dd48186d","line":334,"updated":"2026-11-12 01:55:58.000000000","message":"pep8: E501 line too long (80 \u003e 79 characters)","commit_id":"eb2f3732e1a1077a312e6f8d169b2b9521a493d4"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_client.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"9fb04aed82a2854229fd87e5bcc55cae3375fb0c","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"            lswitch_name\u003dovn_utils.ovn_name(port[\u0027network_id\u0027]))"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    @mock.patch.object(db_rev, \u0027bump_revision\u0027)"},{"line_number":1063,"context_line":"    @mock.patch.object(ovn_utils, \u0027ovs_persist_uuid_supported\u0027, return_value\u003dTrue)"},{"line_number":1064,"context_line":"    @mock.patch.object(ovn_utils, \u0027network_needs_lswitch\u0027, return_value\u003dFalse)"},{"line_number":1065,"context_line":"    @mock.patch.object(ml2_db, \u0027get_binding_level_objs\u0027)"},{"line_number":1066,"context_line":"    def test_create_port_recovers_segment(self, mock_levels, mock_needs_ls,"}],"source_content_type":"text/x-python","patch_set":1,"id":"c301adc2_104a556c","line":1063,"updated":"2026-11-12 01:55:58.000000000","message":"pep8: E501 line too long (82 \u003e 79 characters)","commit_id":"eb2f3732e1a1077a312e6f8d169b2b9521a493d4"}],"neutron/tests/unit/plugins/ml2/drivers/ovn/mech_driver/ovsdb/test_ovn_db_sync.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"4373c87db442a6fc5a6f474dbd9e6ce28bd09215","unresolved":false,"context_lines":[{"line_number":2041,"context_line":"        self.get_network.assert_called_once_with(self.context, \u0027net-1\u0027)"},{"line_number":2042,"context_line":"        self.assertEqual(3, self.client.get_port_dns_records.call_count)"},{"line_number":2043,"context_line":"        self.nb_api.lookup.assert_not_called()"},{"line_number":2044,"context_line":"        self.nb_api.get_all_logical_switches_with_ports.assert_called_once_with()"},{"line_number":2045,"context_line":""},{"line_number":2046,"context_line":"    def test_missing_segment_external_id_uses_switch_membership(self):"},{"line_number":2047,"context_line":"        self.get_ports.return_value \u003d self.ports[:1]"}],"source_content_type":"text/x-python","patch_set":4,"id":"e86b2b82_df7afcd7","line":2044,"updated":"2026-11-14 03:18:45.000000000","message":"pep8: E501 line too long (81 \u003e 79 characters)","commit_id":"f735ab50bc263422e412ddf2fcf610896d16a60f"}]}
