)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7f06c8ec1d908492066941ffb7cb98437ce16191","unresolved":true,"context_lines":[{"line_number":15,"context_line":"In case of the indirect Floating IP, there is no such one router. User"},{"line_number":16,"context_line":"can manually set `router_id` for FIP and that should be used also for"},{"line_number":17,"context_line":"FIP Port Forwarding."},{"line_number":18,"context_line":"With this patch FIP PF plugin first checkes if FIP already have"},{"line_number":19,"context_line":"`router_id` set and if yes, will simply use that one."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Additionally this patch updates and fixes functional test:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bcd3b384_ad7dd850","line":18,"range":{"start_line":18,"start_character":36,"end_line":18,"end_character":43},"updated":"2026-11-17 11:10:18.000000000","message":"checks","commit_id":"0bf3e4fd618224a4296bb84e828a188b81f5e7bd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"722283c5aa545394e8cecdd0f2c9ff8cbf128a44","unresolved":false,"context_lines":[{"line_number":15,"context_line":"In case of the indirect Floating IP, there is no such one router. User"},{"line_number":16,"context_line":"can manually set `router_id` for FIP and that should be used also for"},{"line_number":17,"context_line":"FIP Port Forwarding."},{"line_number":18,"context_line":"With this patch FIP PF plugin first checkes if FIP already have"},{"line_number":19,"context_line":"`router_id` set and if yes, will simply use that one."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Additionally this patch updates and fixes functional test:"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a37a49b9_96b08c87","line":18,"range":{"start_line":18,"start_character":36,"end_line":18,"end_character":43},"in_reply_to":"bcd3b384_ad7dd850","updated":"2026-11-18 10:11:31.000000000","message":"Done","commit_id":"0bf3e4fd618224a4296bb84e828a188b81f5e7bd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7f06c8ec1d908492066941ffb7cb98437ce16191","unresolved":true,"context_lines":[{"line_number":23,"context_line":"previously intended to check if Conflict will be returned in two cases:"},{"line_number":24,"context_line":"1. update floating IP PF to be associated with Neutron port connected to"},{"line_number":25,"context_line":"   the network without direct connection with external network"},{"line_number":26,"context_line":"   in single router - that check is now removed as it is not longer the"},{"line_number":27,"context_line":"   case with the usage of \"indirect floating IP\" for PF,"},{"line_number":28,"context_line":"2. update floating IP with same attributes (internal, external port as"},{"line_number":29,"context_line":"   FIP PF already existing) - this check was actually broken before as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"d25d4ce7_54b758ab","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":60},"updated":"2026-11-17 11:10:18.000000000","message":"no","commit_id":"0bf3e4fd618224a4296bb84e828a188b81f5e7bd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"722283c5aa545394e8cecdd0f2c9ff8cbf128a44","unresolved":false,"context_lines":[{"line_number":23,"context_line":"previously intended to check if Conflict will be returned in two cases:"},{"line_number":24,"context_line":"1. update floating IP PF to be associated with Neutron port connected to"},{"line_number":25,"context_line":"   the network without direct connection with external network"},{"line_number":26,"context_line":"   in single router - that check is now removed as it is not longer the"},{"line_number":27,"context_line":"   case with the usage of \"indirect floating IP\" for PF,"},{"line_number":28,"context_line":"2. update floating IP with same attributes (internal, external port as"},{"line_number":29,"context_line":"   FIP PF already existing) - this check was actually broken before as"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a8832241_7f5b9881","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":60},"in_reply_to":"d25d4ce7_54b758ab","updated":"2026-11-18 10:11:31.000000000","message":"Done","commit_id":"0bf3e4fd618224a4296bb84e828a188b81f5e7bd"}],"neutron/services/portforwarding/pf_plugin.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"7f06c8ec1d908492066941ffb7cb98437ce16191","unresolved":true,"context_lines":[{"line_number":280,"context_line":"    def _find_a_router_for_fip_port_forwarding("},{"line_number":281,"context_line":"            self, context, pf_dict, fip_obj):"},{"line_number":282,"context_line":"        if fip_obj.router_id:"},{"line_number":283,"context_line":"            # There is no need to validate it, it was already validated when"},{"line_number":284,"context_line":"            # when router_id was set for Floating IP address, now we can"},{"line_number":285,"context_line":"            # trust it"},{"line_number":286,"context_line":"            return fip_obj.router_id"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5ef130c8_53ad1d49","line":284,"range":{"start_line":283,"start_character":72,"end_line":284,"end_character":18},"updated":"2026-11-17 11:10:18.000000000","message":"nit: remove one `when`","commit_id":"0bf3e4fd618224a4296bb84e828a188b81f5e7bd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"722283c5aa545394e8cecdd0f2c9ff8cbf128a44","unresolved":false,"context_lines":[{"line_number":280,"context_line":"    def _find_a_router_for_fip_port_forwarding("},{"line_number":281,"context_line":"            self, context, pf_dict, fip_obj):"},{"line_number":282,"context_line":"        if fip_obj.router_id:"},{"line_number":283,"context_line":"            # There is no need to validate it, it was already validated when"},{"line_number":284,"context_line":"            # when router_id was set for Floating IP address, now we can"},{"line_number":285,"context_line":"            # trust it"},{"line_number":286,"context_line":"            return fip_obj.router_id"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"230e01cc_7857d7f1","line":284,"range":{"start_line":283,"start_character":72,"end_line":284,"end_character":18},"in_reply_to":"5ef130c8_53ad1d49","updated":"2026-11-18 10:11:31.000000000","message":"Done","commit_id":"0bf3e4fd618224a4296bb84e828a188b81f5e7bd"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"35ee0878502f907e66ca4c56cb1b21e23e6176ee","unresolved":true,"context_lines":[{"line_number":285,"context_line":"            # trust it"},{"line_number":286,"context_line":"            return fip_obj.router_id"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        internal_port_id \u003d pf_dict[\u0027internal_port_id\u0027]"},{"line_number":289,"context_line":"        internal_port \u003d self.core_plugin.get_port(context, internal_port_id)"},{"line_number":290,"context_line":"        v4_fixed_ips \u003d [fixed_ip for fixed_ip in internal_port[\u0027fixed_ips\u0027]"},{"line_number":291,"context_line":"                        if (netaddr.IPNetwork(fixed_ip[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"9de1ec27_fc7de771","line":288,"updated":"2026-11-17 11:16:21.000000000","message":"Actually I have concerns about this patch.\n\n_find_a_router_for_fip_port_forwarding() is not only a router lookup. Before calling get_router_for_floatingip() it also:\n1) Defaults internal_ip_address to the port\u0027s first IPv4 when omitted (internal_ip_address is optional in the API — allow_post: True with no required: True)\n2) Validates that a user-supplied internal_ip_address actually belongs to the internal port (via _get_internal_ip_subnet())\n\nThe patch returns before any of that, and the early return is hit in the common case, not just the indirect-FIP case: any FIP that already has one PF has router_id set (it is set at first PF create, line 379–382). Concrete regressions:\n* Second PF create without internal_ip_address (worked before, defaults to the port\u0027s IP): pf.PortForwarding(context, **port_forwarding) is now created with the field missing; the DB column is nullable\u003dFalse (neutron/db/models/port_forwarding.py:52), so this ends in an unhandled IntegrityError / HTTP 500 instead of a defaulted 400-free create.\n* PF update changing internal_port_id without internal_ip_address (worked before — the defaulting populated pf_dict before the port_forwarding.get(\u0027internal_ip_address\u0027) block at lines 431–442): the old IP is now reused for the new port and _check_port_forwarding_update() fails with the confusing \"The internal IP does not correspond to an address on the internal port\" error.\n* Bogus internal_ip_address is no longer rejected when the FIP has a router_id: a PF pointing at an IP the internal port doesn\u0027t own gets stored, and the OVN driver programs an LB backend (driver.py:60–63) to a nonexistent address.","commit_id":"0bf3e4fd618224a4296bb84e828a188b81f5e7bd"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"722283c5aa545394e8cecdd0f2c9ff8cbf128a44","unresolved":false,"context_lines":[{"line_number":285,"context_line":"            # trust it"},{"line_number":286,"context_line":"            return fip_obj.router_id"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        internal_port_id \u003d pf_dict[\u0027internal_port_id\u0027]"},{"line_number":289,"context_line":"        internal_port \u003d self.core_plugin.get_port(context, internal_port_id)"},{"line_number":290,"context_line":"        v4_fixed_ips \u003d [fixed_ip for fixed_ip in internal_port[\u0027fixed_ips\u0027]"},{"line_number":291,"context_line":"                        if (netaddr.IPNetwork(fixed_ip[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7849e557_1a1ca4d5","line":288,"in_reply_to":"9de1ec27_fc7de771","updated":"2026-11-18 10:11:31.000000000","message":"good catch :) I\u0027ve refactored it now so that there is separate method to validate internal ip and port and other to just find router_id for FIP PF.","commit_id":"0bf3e4fd618224a4296bb84e828a188b81f5e7bd"}]}
