)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6a180c661db0e33c828e26b44a7082a2a0f1ed13","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bb612f96_7823aa54","updated":"2026-11-16 15:09:49.000000000","message":"This is a small -1 because of the \"get distributed method\" that appears to be not needed.","commit_id":"2389e8763955edc79bf1a414afcaf017fcb2ef10"}],"neutron/db/evpn_db.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6a180c661db0e33c828e26b44a7082a2a0f1ed13","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":125,"context_line":"    @db_api.CONTEXT_READER"},{"line_number":126,"context_line":"    def get_distributed_for_router(self, context, router_id):"},{"line_number":127,"context_line":"        \"\"\"Return whether a router\u0027s EVPN instance uses distributed routing."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param context: Neutron request context"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c995220_5f91a56f","line":126,"updated":"2026-11-16 15:09:49.000000000","message":"Is this used anywhere in the prod code?","commit_id":"2389e8763955edc79bf1a414afcaf017fcb2ef10"},{"author":{"_account_id":38298,"name":"Helen Chen","display_name":"Helen Chen","email":"ichen@redhat.com","username":"ingwherchen"},"change_message_id":"9baebcc2a58d26d0fa676020b8cc305ed54bd391","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":125,"context_line":"    @db_api.CONTEXT_READER"},{"line_number":126,"context_line":"    def get_distributed_for_router(self, context, router_id):"},{"line_number":127,"context_line":"        \"\"\"Return whether a router\u0027s EVPN instance uses distributed routing."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param context: Neutron request context"}],"source_content_type":"text/x-python","patch_set":1,"id":"723fc088_c3f5f091","line":126,"in_reply_to":"59dd8088_49f6e306","updated":"2026-11-20 14:56:40.000000000","message":"Would get_distributed_router() , or something to that effect, be useful?\n\nThis proposed patch, https://review.opendev.org/c/openstack/neutron/+/1016682 , might be able to take advantage of something like get_distributed_router().","commit_id":"2389e8763955edc79bf1a414afcaf017fcb2ef10"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"163e789221638aa2b30fa6a31bb501542438ce68","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":125,"context_line":"    @db_api.CONTEXT_READER"},{"line_number":126,"context_line":"    def get_distributed_for_router(self, context, router_id):"},{"line_number":127,"context_line":"        \"\"\"Return whether a router\u0027s EVPN instance uses distributed routing."},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        :param context: Neutron request context"}],"source_content_type":"text/x-python","patch_set":1,"id":"59dd8088_49f6e306","line":126,"in_reply_to":"7c995220_5f91a56f","updated":"2026-11-16 15:30:31.000000000","message":"At this point, I don\u0027t think anything uses anything in this patch. 😀 I\u0027m fine removing it if it doesn\u0027t become useful. But there\u0027s also no real driving reason to merge this before there is something building off of it that is ready to merge.","commit_id":"2389e8763955edc79bf1a414afcaf017fcb2ef10"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"505c64f91cbd19b0af9a74f06ac62dc27d786666","unresolved":false,"context_lines":[{"line_number":270,"context_line":"        ).join("},{"line_number":271,"context_line":"            evpn_models.EVPNNetwork,"},{"line_number":272,"context_line":"        ).all()"},{"line_number":273,"context_line":"        return {port_id: router_id for port_id, router_id in ports}"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    @db_api.retry_if_session_inactive()"},{"line_number":276,"context_line":"    @db_api.CONTEXT_READER"}],"source_content_type":"text/x-python","patch_set":2,"id":"0e480981_14f63e7a","line":273,"updated":"2026-11-20 17:54:45.000000000","message":"pep8: R1721: Unnecessary use of a comprehension, use dict(ports) instead. (unnecessary-comprehension)","commit_id":"8fbc4c18136f5db1431bc3f163d634d2c82ad2f2"}],"neutron/db/models/evpn.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6a180c661db0e33c828e26b44a7082a2a0f1ed13","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    removes this instance. RESTRICT on router_id prevents router"},{"line_number":29,"context_line":"    deletion while an EVPN instance exists - user must explicitly"},{"line_number":30,"context_line":"    remove the VNI first."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    ``distributed`` records whether the instance uses distributed routing"},{"line_number":33,"context_line":"    (a VxLAN tunnel endpoint on every compute node) rather than"},{"line_number":34,"context_line":"    centralized routing (a single endpoint on a gateway chassis). The"},{"line_number":35,"context_line":"    server default is False because every row that predates this column"},{"line_number":36,"context_line":"    was created before distributed routing existed, and so is"},{"line_number":37,"context_line":"    centralized - the API-level default is policy and belongs in the API"},{"line_number":38,"context_line":"    definition."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    __tablename__ \u003d \u0027evpn_l3_instances\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"ada35745_b2e874c9","line":38,"range":{"start_line":31,"start_character":0,"end_line":38,"end_character":15},"updated":"2026-11-16 15:09:49.000000000","message":"is this needed? :)","commit_id":"2389e8763955edc79bf1a414afcaf017fcb2ef10"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"163e789221638aa2b30fa6a31bb501542438ce68","unresolved":true,"context_lines":[{"line_number":28,"context_line":"    removes this instance. RESTRICT on router_id prevents router"},{"line_number":29,"context_line":"    deletion while an EVPN instance exists - user must explicitly"},{"line_number":30,"context_line":"    remove the VNI first."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    ``distributed`` records whether the instance uses distributed routing"},{"line_number":33,"context_line":"    (a VxLAN tunnel endpoint on every compute node) rather than"},{"line_number":34,"context_line":"    centralized routing (a single endpoint on a gateway chassis). The"},{"line_number":35,"context_line":"    server default is False because every row that predates this column"},{"line_number":36,"context_line":"    was created before distributed routing existed, and so is"},{"line_number":37,"context_line":"    centralized - the API-level default is policy and belongs in the API"},{"line_number":38,"context_line":"    definition."},{"line_number":39,"context_line":"    \"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    __tablename__ \u003d \u0027evpn_l3_instances\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"2010b4b3_6b254df4","line":38,"range":{"start_line":31,"start_character":0,"end_line":38,"end_character":15},"in_reply_to":"ada35745_b2e874c9","updated":"2026-11-16 15:30:31.000000000","message":"I guess it depends on how familiar people are with server_default. I remembered that we had talked about maybe once distributed support existed, that centralized had no real benefits--so maybe the default would change (or centralized could be removed or something). So this was just \"this is just for forward migration, not a statement about what the API default should be\".","commit_id":"2389e8763955edc79bf1a414afcaf017fcb2ef10"}]}
