)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"674658b1718bd2e36254d12f2bd0587d36fa26ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"2093881e_25e6921e","updated":"2026-11-19 02:23:02.000000000","message":"We missed this when implementing type-5 patches. \nhttps://opendev.org/openstack/neutron/src/branch/master/neutron/agent/ovn/extensions/evpn/events.py#L43-L46","commit_id":"90f8c2045fbc44ee7aecfe7e0c7008a4bd8255f7"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a6a020f6c030a30f164d122d9167152bacaf2113","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"593a22b7_779c316f","updated":"2026-11-20 15:39:21.000000000","message":"-1 just for the module import side-effect, otherwise LGTM","commit_id":"4c154774a67a43609b864b3bde98269b20509dcf"}],"neutron/conf/services/evpn.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a6a020f6c030a30f164d122d9167152bacaf2113","unresolved":true,"context_lines":[{"line_number":40,"context_line":"    for item in ranges:"},{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            minimum, maximum \u003d (int(value) for value in item.split(\u0027:\u0027))"},{"line_number":43,"context_line":"        except (ValueError, TypeError):"},{"line_number":44,"context_line":"            raise ValueError(_(\"Invalid EVPN VNI range %r: expected min:max\")"},{"line_number":45,"context_line":"                             % item)"},{"line_number":46,"context_line":"        if not 1 \u003c\u003d minimum \u003c\u003d maximum \u003c\u003d constants.MAX_VXLAN_VNI:"}],"source_content_type":"text/x-python","patch_set":4,"id":"ae1f8973_c9d69902","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":37},"updated":"2026-11-20 15:39:21.000000000","message":"Where is the `TypeError` coming from?","commit_id":"4c154774a67a43609b864b3bde98269b20509dcf"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"f0e4b15aaebfbbf0a37409f6a13331d4743a51b5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    for item in ranges:"},{"line_number":41,"context_line":"        try:"},{"line_number":42,"context_line":"            minimum, maximum \u003d (int(value) for value in item.split(\u0027:\u0027))"},{"line_number":43,"context_line":"        except (ValueError, TypeError):"},{"line_number":44,"context_line":"            raise ValueError(_(\"Invalid EVPN VNI range %r: expected min:max\")"},{"line_number":45,"context_line":"                             % item)"},{"line_number":46,"context_line":"        if not 1 \u003c\u003d minimum \u003c\u003d maximum \u003c\u003d constants.MAX_VXLAN_VNI:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fc939bb6_f7e02606","line":43,"range":{"start_line":43,"start_character":28,"end_line":43,"end_character":37},"in_reply_to":"ae1f8973_c9d69902","updated":"2026-11-20 20:23:19.000000000","message":"Done","commit_id":"4c154774a67a43609b864b3bde98269b20509dcf"}],"neutron/db/evpn_db.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a6a020f6c030a30f164d122d9167152bacaf2113","unresolved":true,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"evpn_config.register_opts()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# The VNI is unique across the whole fabric while the VLAN is only unique"},{"line_number":35,"context_line":"# on a single physical network, so they are separate pools. EVPN L3 has a"}],"source_content_type":"text/x-python","patch_set":4,"id":"2eb12f1b_0a8aa050","line":32,"updated":"2026-11-20 15:39:21.000000000","message":"this must not be on the module level since it causes a side-effect of registering on import already.","commit_id":"4c154774a67a43609b864b3bde98269b20509dcf"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"f0e4b15aaebfbbf0a37409f6a13331d4743a51b5","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"evpn_config.register_opts()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"# The VNI is unique across the whole fabric while the VLAN is only unique"},{"line_number":35,"context_line":"# on a single physical network, so they are separate pools. EVPN L3 has a"}],"source_content_type":"text/x-python","patch_set":4,"id":"c5ba66ac_3af29560","line":32,"in_reply_to":"2eb12f1b_0a8aa050","updated":"2026-11-20 20:23:19.000000000","message":"Done","commit_id":"4c154774a67a43609b864b3bde98269b20509dcf"}],"neutron/tests/unit/conf/services/test_evpn.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a6a020f6c030a30f164d122d9167152bacaf2113","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class EVPNConfigTestCase(base.BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_missing_ranges_in_config_file_uses_full_range(self):"},{"line_number":26,"context_line":"        config_file \u003d self.get_temp_file_path(\u0027neutron.conf\u0027)"},{"line_number":27,"context_line":"        for content in (\u0027[DEFAULT]\\n\u0027, \u0027[evpn]\\n\u0027):"},{"line_number":28,"context_line":"            with self.subTest(content\u003dcontent):"},{"line_number":29,"context_line":"                with open(config_file, \u0027w\u0027) as stream:"},{"line_number":30,"context_line":"                    stream.write(content)"},{"line_number":31,"context_line":"                conf \u003d cfg.ConfigOpts()"},{"line_number":32,"context_line":"                evpn.register_opts(conf)"},{"line_number":33,"context_line":"                conf([], default_config_files\u003d[config_file])"},{"line_number":34,"context_line":"                self.assertEqual("},{"line_number":35,"context_line":"                    [(1, constants.MAX_VXLAN_VNI)],"},{"line_number":36,"context_line":"                    evpn.parse_vni_ranges(conf.evpn.evpn_vni_auto_ranges))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_empty_ranges_disable_automatic_allocation(self):"},{"line_number":39,"context_line":"        self.assertEqual([], evpn.parse_vni_ranges([]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"25202d44_375aeccc","line":36,"range":{"start_line":25,"start_character":0,"end_line":36,"end_character":74},"updated":"2026-11-20 15:39:21.000000000","message":"Isn\u0027t this testing mostly that the oslo_config works?","commit_id":"4c154774a67a43609b864b3bde98269b20509dcf"},{"author":{"_account_id":34271,"name":"Miro Tomaska","display_name":"Miro Tomaska","email":"mtomaska@redhat.com","username":"mtomaska"},"change_message_id":"f0e4b15aaebfbbf0a37409f6a13331d4743a51b5","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class EVPNConfigTestCase(base.BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_missing_ranges_in_config_file_uses_full_range(self):"},{"line_number":26,"context_line":"        config_file \u003d self.get_temp_file_path(\u0027neutron.conf\u0027)"},{"line_number":27,"context_line":"        for content in (\u0027[DEFAULT]\\n\u0027, \u0027[evpn]\\n\u0027):"},{"line_number":28,"context_line":"            with self.subTest(content\u003dcontent):"},{"line_number":29,"context_line":"                with open(config_file, \u0027w\u0027) as stream:"},{"line_number":30,"context_line":"                    stream.write(content)"},{"line_number":31,"context_line":"                conf \u003d cfg.ConfigOpts()"},{"line_number":32,"context_line":"                evpn.register_opts(conf)"},{"line_number":33,"context_line":"                conf([], default_config_files\u003d[config_file])"},{"line_number":34,"context_line":"                self.assertEqual("},{"line_number":35,"context_line":"                    [(1, constants.MAX_VXLAN_VNI)],"},{"line_number":36,"context_line":"                    evpn.parse_vni_ranges(conf.evpn.evpn_vni_auto_ranges))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_empty_ranges_disable_automatic_allocation(self):"},{"line_number":39,"context_line":"        self.assertEqual([], evpn.parse_vni_ranges([]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a848d8e_86e11e13","line":36,"range":{"start_line":25,"start_character":0,"end_line":36,"end_character":74},"in_reply_to":"25202d44_375aeccc","updated":"2026-11-20 20:23:19.000000000","message":"yep, I was wondering about value of this unit test. I\u0027ll just remove it.","commit_id":"4c154774a67a43609b864b3bde98269b20509dcf"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"85d8be25fb7536590f9c7500f5eaffe034a78db0","unresolved":true,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class EVPNConfigTestCase(base.BaseTestCase):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def test_missing_ranges_in_config_file_uses_full_range(self):"},{"line_number":26,"context_line":"        config_file \u003d self.get_temp_file_path(\u0027neutron.conf\u0027)"},{"line_number":27,"context_line":"        for content in (\u0027[DEFAULT]\\n\u0027, \u0027[evpn]\\n\u0027):"},{"line_number":28,"context_line":"            with self.subTest(content\u003dcontent):"},{"line_number":29,"context_line":"                with open(config_file, \u0027w\u0027) as stream:"},{"line_number":30,"context_line":"                    stream.write(content)"},{"line_number":31,"context_line":"                conf \u003d cfg.ConfigOpts()"},{"line_number":32,"context_line":"                evpn.register_opts(conf)"},{"line_number":33,"context_line":"                conf([], default_config_files\u003d[config_file])"},{"line_number":34,"context_line":"                self.assertEqual("},{"line_number":35,"context_line":"                    [(1, constants.MAX_VXLAN_VNI)],"},{"line_number":36,"context_line":"                    evpn.parse_vni_ranges(conf.evpn.evpn_vni_auto_ranges))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_empty_ranges_disable_automatic_allocation(self):"},{"line_number":39,"context_line":"        self.assertEqual([], evpn.parse_vni_ranges([]))"}],"source_content_type":"text/x-python","patch_set":4,"id":"f92c68b8_955547e5","line":36,"range":{"start_line":25,"start_character":0,"end_line":36,"end_character":74},"in_reply_to":"7a848d8e_86e11e13","updated":"2026-11-20 20:31:43.000000000","message":"I think the rest of the tests were good, it tested the `parse_vni_ranges` that is in Neutron. I just highlighted this one method.","commit_id":"4c154774a67a43609b864b3bde98269b20509dcf"}]}
