)]}'
{"etc/neutron/plugins/ml2/ml2_conf_huawei.ini":[{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"91490c726a4f5171e87d015891eca38def2d19cd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# (StrOpt) NOS IP address. This is required field. If not set, all"},{"line_number":6,"context_line":"#          communications to Huawei NOS will fail"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"nos_host \u003d 128.100.1.7"},{"line_number":9,"context_line":"# Example: nos_host \u003d 128.100.1.7"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# (IntOpt) NOS service port. This is required field."}],"source_content_type":"text/x-properties","patch_set":2,"id":"baada198_97bff0fa","line":8,"updated":"2014-07-03 02:47:36.000000000","message":"Should this be commented out ?","commit_id":"9d9bc3cf55a6d614928cd42f3e614f1ff0f92ef5"},{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"91490c726a4f5171e87d015891eca38def2d19cd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# (IntOpt) NOS service port. This is required field."},{"line_number":12,"context_line":"#          if not set, all communications to Huawei NOS will fail."},{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":"nos_port \u003d 8080"},{"line_number":15,"context_line":"# Example: nos_port \u003d 8080"},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":"# (StrOpt) NOS service user name. This is required field."}],"source_content_type":"text/x-properties","patch_set":2,"id":"baada198_d73888a2","line":14,"updated":"2014-07-03 02:47:36.000000000","message":"Same as above","commit_id":"9d9bc3cf55a6d614928cd42f3e614f1ff0f92ef5"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Defines configuration options specific for Huawei ML2 Mechanism driver"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[ml2_Huawei]"},{"line_number":5,"context_line":"# (StrOpt) NOS IP address. This is required field. If not set, all"},{"line_number":6,"context_line":"#          communications to Huawei NOS will fail"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-properties","patch_set":3,"id":"baada198_da7c08b8","line":4,"updated":"2014-07-03 22:08:03.000000000","message":"https://review.openstack.org/#/c/92396/8 was just merged. That patch to Oslo config introduces the IP address option. Hopefully an Oslo config release that includes that patch will be released soon - I suspect before this patch could be merged.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"56b50f0c2ff41c70053d25faa3dd165dad77006b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Defines configuration options specific for Huawei ML2 Mechanism driver"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[ml2_Huawei]"},{"line_number":5,"context_line":"# (StrOpt) NOS IP address. This is required field. If not set, all"},{"line_number":6,"context_line":"#          communications to Huawei NOS will fail"},{"line_number":7,"context_line":"#"}],"source_content_type":"text/x-properties","patch_set":3,"id":"baada198_1dd8e81c","line":4,"in_reply_to":"baada198_da7c08b8","updated":"2014-07-22 04:17:29.000000000","message":"Keep in mind and update to IPOpt later, the oslo.config library has not been updated yet, which fails our unit test.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"0a2b527540e3044a0dc28e0f003db8d103f818c4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# Example: nos_username \u003d admin"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# (StrOpt) NOS command API password. This is required field."},{"line_number":24,"context_line":"#          if not set, all communications to Arista NOS will fail."},{"line_number":25,"context_line":"#"},{"line_number":26,"context_line":"# nos_password \u003d"},{"line_number":27,"context_line":"# Example: nos_password \u003d my_password"}],"source_content_type":"text/x-properties","patch_set":3,"id":"baada198_b3a484a6","line":24,"updated":"2014-07-15 13:54:25.000000000","message":"just want to know Arista NOS \u003d above Huawei NOS ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"10af4a564f13311fc285cee84835c7138062cf23","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#          communications to Huawei NOS will fail"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# nos_host \u003d 128.100.1.7"},{"line_number":9,"context_line":"# Example: nos_host \u003d 128.100.1.7"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# (IntOpt) NOS service port. This is required field."},{"line_number":12,"context_line":"#          if not set, all communications to Huawei NOS will fail."}],"source_content_type":"text/x-properties","patch_set":10,"id":"1abeadc6_3de70a42","line":9,"updated":"2014-08-26 16:09:32.000000000","message":"the layout is not the same as the ones in other config files\n\n\nml2_huawei?","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"febbdb4576b2fe930d45e66d31f2d2341ad3bab0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"#          communications to Huawei NOS will fail"},{"line_number":7,"context_line":"#"},{"line_number":8,"context_line":"# nos_host \u003d 128.100.1.7"},{"line_number":9,"context_line":"# Example: nos_host \u003d 128.100.1.7"},{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# (IntOpt) NOS service port. This is required field."},{"line_number":12,"context_line":"#          if not set, all communications to Huawei NOS will fail."}],"source_content_type":"text/x-properties","patch_set":10,"id":"1abeadc6_a1c83975","line":9,"in_reply_to":"1abeadc6_3de70a42","updated":"2014-08-27 09:01:35.000000000","message":"+1,","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"}],"neutron/plugins/ml2/drivers/huawei/README":[{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"230967a65e87d9f53f30e0b536c228084a9e990d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Huawei ML2 mechanism driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Introduction"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1abeadc6_ea638a3f","line":2,"updated":"2014-08-22 06:20:44.000000000","message":"Can you move this documentation to Openstack Wiki or some other place, so that it can be updated at ease. Put a pointer here to that External link.","commit_id":"97239e77514419ac7fc868f91cf8ebe4ab67026a"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"5ab5e33194a521c1856621bcf3c2416573f5dc5f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Huawei ML2 mechanism driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Introduction"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"1abeadc6_40245a0c","line":2,"in_reply_to":"1abeadc6_ea638a3f","updated":"2014-08-22 10:23:02.000000000","message":"done, link to a wiki page","commit_id":"97239e77514419ac7fc868f91cf8ebe4ab67026a"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"b225ef817d6b7a5a25a170fa303b57c0233ffb43","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Huawei ML2 mechanism driver works with Huawei SDN controller."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"For more details on how to use it please refer to the following page:"},{"line_number":6,"context_line":"https://wiki.openstack.org/wiki/Huawei-Neutron"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_15eb7578","line":6,"updated":"2014-08-22 16:08:13.000000000","message":"Can you give a more readable/appropriate name to the wiki page. Here the README explains Huawei ML2 Mechanism Driver.","commit_id":"26e6d5f18773ce8a82c099ed90b7bd9dd185db08"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"ee910b89e399a48f4526e692d21161379fc84cf5","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Huawei ML2 mechanism driver works with Huawei SDN controller."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"For more details on how to use it please refer to the following page:"},{"line_number":6,"context_line":"https://wiki.openstack.org/wiki/Huawei-Neutron"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_e50a9826","line":6,"in_reply_to":"1abeadc6_15eb7578","updated":"2014-08-25 11:58:41.000000000","message":"We would like to use this page as the entry of Huawei neutron related material and present the introduction of Huawei ML2 MD in one of its section.","commit_id":"26e6d5f18773ce8a82c099ed90b7bd9dd185db08"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"f84f2977ceb73d1cb1933fcaf8e53775769e3654","unresolved":false,"context_lines":[{"line_number":3,"context_line":"Huawei ML2 mechanism driver works with Huawei SDN controller."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"For more details on how to use it please refer to the following page:"},{"line_number":6,"context_line":"https://wiki.openstack.org/wiki/Huawei-Neutron"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"1abeadc6_79646d49","line":6,"in_reply_to":"1abeadc6_e50a9826","updated":"2014-08-25 13:23:42.000000000","message":"It would be confusing then. You may have many contribution to neuton, having each contribution a separate page would make the users simple to understand the usage and configuration. If you combine all into one page, then it would be confusing.","commit_id":"26e6d5f18773ce8a82c099ed90b7bd9dd185db08"}],"neutron/plugins/ml2/drivers/huawei/clients.py":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"036b7e14e1883a2b96abba10827f1d9a7b47d153","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":"# @author: mayu, Huawei tech, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"A client for Huawei sdn controller."}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_865a6f4e","line":16,"updated":"2014-07-02 20:13:53.000000000","message":"it says Huawei here and big switch in first line ?","commit_id":"bc725caf82d50a88500a9662c844e15fc48512e3"},{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"036b7e14e1883a2b96abba10827f1d9a7b47d153","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        if self.auth:"},{"line_number":112,"context_line":"            headers[\u0027Authorization\u0027] \u003d self.auth"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        LOG.debug(_(\"ServerProxy: server\u003d%(server)s, port\u003d%(port)d, \""},{"line_number":115,"context_line":"                    \"ssl\u003d%(ssl)r, action\u003d%(action)s\"),"},{"line_number":116,"context_line":"                  {\u0027server\u0027: self.server, \u0027port\u0027: self.port, \u0027ssl\u0027: self.ssl,"},{"line_number":117,"context_line":"                   \u0027action\u0027: action})"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_2614434d","line":114,"updated":"2014-07-02 20:13:53.000000000","message":"no debug translations (bug/1317851)","commit_id":"bc725caf82d50a88500a9662c844e15fc48512e3"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"6c2d05e39d23345cde713ad7d82ef9c7d95ec94b","unresolved":false,"context_lines":[{"line_number":111,"context_line":"        if self.auth:"},{"line_number":112,"context_line":"            headers[\u0027Authorization\u0027] \u003d self.auth"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"        LOG.debug(_(\"ServerProxy: server\u003d%(server)s, port\u003d%(port)d, \""},{"line_number":115,"context_line":"                    \"ssl\u003d%(ssl)r, action\u003d%(action)s\"),"},{"line_number":116,"context_line":"                  {\u0027server\u0027: self.server, \u0027port\u0027: self.port, \u0027ssl\u0027: self.ssl,"},{"line_number":117,"context_line":"                   \u0027action\u0027: action})"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_b4e31232","line":114,"in_reply_to":"baada198_2614434d","updated":"2014-07-03 01:36:18.000000000","message":"fixed in next patch set","commit_id":"bc725caf82d50a88500a9662c844e15fc48512e3"},{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"036b7e14e1883a2b96abba10827f1d9a7b47d153","unresolved":false,"context_lines":[{"line_number":115,"context_line":"                    \"ssl\u003d%(ssl)r, action\u003d%(action)s\"),"},{"line_number":116,"context_line":"                  {\u0027server\u0027: self.server, \u0027port\u0027: self.port, \u0027ssl\u0027: self.ssl,"},{"line_number":117,"context_line":"                   \u0027action\u0027: action})"},{"line_number":118,"context_line":"        LOG.debug(_(\"ServerProxy: resource\u003d%(resource)s, data\u003d%(data)r, \""},{"line_number":119,"context_line":"                    \"headers\u003d%(headers)r\"),"},{"line_number":120,"context_line":"                  {\u0027resource\u0027: resource, \u0027data\u0027: data, \u0027headers\u0027: headers})"},{"line_number":121,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_46177751","line":118,"updated":"2014-07-02 20:13:53.000000000","message":"same","commit_id":"bc725caf82d50a88500a9662c844e15fc48512e3"},{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"036b7e14e1883a2b96abba10827f1d9a7b47d153","unresolved":false,"context_lines":[{"line_number":152,"context_line":"                      {\u0027action\u0027: action, \u0027e\u0027: e})"},{"line_number":153,"context_line":"            ret \u003d 0, None, None, None"},{"line_number":154,"context_line":"        conn.close()"},{"line_number":155,"context_line":"        LOG.debug(_(\"ServerProxy: status\u003d%(status)d, reason\u003d%(reason)r, \""},{"line_number":156,"context_line":"                    \"ret\u003d%(ret)s, data\u003d%(data)r\"), {\u0027status\u0027: ret[0],"},{"line_number":157,"context_line":"                                                    \u0027reason\u0027: ret[1],"},{"line_number":158,"context_line":"                                                    \u0027ret\u0027: ret[2],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_c602a70a","line":155,"updated":"2014-07-02 20:13:53.000000000","message":"same.","commit_id":"bc725caf82d50a88500a9662c844e15fc48512e3"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"baada198_155571fa","updated":"2014-07-03 22:08:03.000000000","message":"2014, in all files.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"f0ee34f9c0f81125ab35bce87865a0b5f5f67430","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"restproxy_opts \u003d ["},{"line_number":38,"context_line":"    cfg.StrOpt(\u0027servers\u0027, default\u003d\u0027localhost:8800\u0027,"},{"line_number":39,"context_line":"               help\u003d_(\"A comma separated server and port number \")),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027server_auth\u0027, default\u003d\u0027username:password\u0027, secret\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_08800c45","line":37,"updated":"2014-07-03 14:46:00.000000000","message":"Is this used anywhere in the code ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                 504, 505]"},{"line_number":68,"context_line":"SYNTAX_ERROR_MESSAGE \u003d _(\u0027Syntax error in server config file, aborting plugin\u0027)"},{"line_number":69,"context_line":"BASE_URI \u003d \u0027/networkService/v1.1\u0027"},{"line_number":70,"context_line":"ORCHESTRATION_SERVICE_ID \u003d \u0027Neutron v2.0\u0027"},{"line_number":71,"context_line":"METADATA_SERVER_IP \u003d \u0027169.254.169.254\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_9540a135","line":70,"updated":"2014-07-03 22:08:03.000000000","message":"This variable is unused?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":70,"context_line":"ORCHESTRATION_SERVICE_ID \u003d \u0027Neutron v2.0\u0027"},{"line_number":71,"context_line":"METADATA_SERVER_IP \u003d \u0027169.254.169.254\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class RemoteRestError(exceptions.NeutronException):"},{"line_number":75,"context_line":"    def __init__(self, message):"},{"line_number":76,"context_line":"        if message is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_95c34188","line":73,"updated":"2014-07-03 22:08:03.000000000","message":"Why are some of the exceptions defined here and some elsewhere?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"0a2b527540e3044a0dc28e0f003db8d103f818c4","unresolved":false,"context_lines":[{"line_number":73,"context_line":""},{"line_number":74,"context_line":"class RemoteRestError(exceptions.NeutronException):"},{"line_number":75,"context_line":"    def __init__(self, message):"},{"line_number":76,"context_line":"        if message is None:"},{"line_number":77,"context_line":"            message \u003d \"None\""},{"line_number":78,"context_line":"        self.message \u003d _(\"Error in REST call to remote network \""},{"line_number":79,"context_line":"                         \"controller\") + \": \" + message"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_33331415","line":76,"updated":"2014-07-15 13:54:25.000000000","message":"message \u003d message or \u0027None\u0027 ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"c60538cb57b0ecfa2765e0e5db41ec559b52db10","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if message is None:"},{"line_number":77,"context_line":"            message \u003d \"None\""},{"line_number":78,"context_line":"        self.message \u003d _(\"Error in REST call to remote network \""},{"line_number":79,"context_line":"                         \"controller\") + \": \" + message"},{"line_number":80,"context_line":"        super(RemoteRestError, self).__init__()"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_44f2e106","line":79,"updated":"2014-07-03 20:31:14.000000000","message":"\"controller : \"","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"c60538cb57b0ecfa2765e0e5db41ec559b52db10","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        uri \u003d self.base_uri + resource"},{"line_number":103,"context_line":"        body \u003d json.dumps(data)"},{"line_number":104,"context_line":"        if not headers:"},{"line_number":105,"context_line":"            headers \u003d {}"},{"line_number":106,"context_line":"        headers[\u0027Content-type\u0027] \u003d \u0027application/json\u0027"},{"line_number":107,"context_line":"        headers[\u0027Accept\u0027] \u003d \u0027application/json\u0027"},{"line_number":108,"context_line":"        headers[\u0027NeutronProxy-Agent\u0027] \u003d self.name"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_64f7e5f5","line":105,"updated":"2014-07-03 20:31:14.000000000","message":"headers \u003d headers or {}","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"ced38156cd75cfd79f19b87d24f5570b834941b2","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                  {\u0027resource\u0027: resource, \u0027data\u0027: data, \u0027headers\u0027: headers})"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"        conn \u003d None"},{"line_number":123,"context_line":"        if self.ssl:"},{"line_number":124,"context_line":"            conn \u003d httplib.HTTPSConnection("},{"line_number":125,"context_line":"                self.server, self.port, timeout\u003dself.timeout)"},{"line_number":126,"context_line":"            if conn is None:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_10dbbf50","line":123,"updated":"2014-07-03 22:39:26.000000000","message":"Please use the \u0027requests\u0027 library to get rid of all of this HTTP related code. You can take a look at how the ODL mechanism driver does it.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":170,"context_line":"        self.auth \u003d auth"},{"line_number":171,"context_line":"        self.ssl \u003d ssl"},{"line_number":172,"context_line":"        self.neutron_id \u003d neutron_id"},{"line_number":173,"context_line":"        self.servers \u003d []"},{"line_number":174,"context_line":"        self.servers.append(self.server_proxy_for(server, port))"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"    def server_proxy_for(self, server, port):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7574ed67","line":173,"updated":"2014-07-03 22:08:03.000000000","message":"It seems like this idea of multiple servers is never used? The conf files allow the admin to define only one server, and only one instance of SdnClient is ever created. I think the self.servers list could be simplified into a single self.server? If you enable the definition of multiple servers at a later time you could come back and refactor this code.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"c60538cb57b0ecfa2765e0e5db41ec559b52db10","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        errstr \u003d _(\"Unable to update remote network: %s\")"},{"line_number":255,"context_line":"        self.rest_action(\u0027PUT\u0027, resource, data, errstr)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def rest_delete_network(self, tenant_id, net_id):"},{"line_number":258,"context_line":"        resource \u003d NETWORKS_PATH % (tenant_id, net_id)"},{"line_number":259,"context_line":"        errstr \u003d _(\"Unable to update remote network: %s\")"},{"line_number":260,"context_line":"        self.rest_action(\u0027DELETE\u0027, resource, errstr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_448101fa","line":257,"updated":"2014-07-03 20:31:14.000000000","message":"The rest_delete_* could be combined into one method like rest_delete_resource(self, tenant_id, resource_id). Similarly for  update and create operations.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"56b50f0c2ff41c70053d25faa3dd165dad77006b","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        errstr \u003d _(\"Unable to update remote network: %s\")"},{"line_number":255,"context_line":"        self.rest_action(\u0027PUT\u0027, resource, data, errstr)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def rest_delete_network(self, tenant_id, net_id):"},{"line_number":258,"context_line":"        resource \u003d NETWORKS_PATH % (tenant_id, net_id)"},{"line_number":259,"context_line":"        errstr \u003d _(\"Unable to update remote network: %s\")"},{"line_number":260,"context_line":"        self.rest_action(\u0027DELETE\u0027, resource, errstr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_3d468ca7","line":257,"in_reply_to":"baada198_15349191","updated":"2014-07-22 04:17:29.000000000","message":"The parameters are different. rest_delete_network requires net_id, while rest_delete_port requires both network_id and port_id. I think it\u0027s fine to leave them as different methods.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        errstr \u003d _(\"Unable to update remote network: %s\")"},{"line_number":255,"context_line":"        self.rest_action(\u0027PUT\u0027, resource, data, errstr)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def rest_delete_network(self, tenant_id, net_id):"},{"line_number":258,"context_line":"        resource \u003d NETWORKS_PATH % (tenant_id, net_id)"},{"line_number":259,"context_line":"        errstr \u003d _(\"Unable to update remote network: %s\")"},{"line_number":260,"context_line":"        self.rest_action(\u0027DELETE\u0027, resource, errstr)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_15349191","line":257,"in_reply_to":"baada198_448101fa","updated":"2014-07-03 22:08:03.000000000","message":"+1","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        they already do not exist on the backend."},{"line_number":173,"context_line":"        \"\"\""},{"line_number":174,"context_line":"        if not ignore_codes and action \u003d\u003d \u0027DELETE\u0027:"},{"line_number":175,"context_line":"            ignore_codes \u003d [404]"},{"line_number":176,"context_line":"        resp \u003d self.rest_call(action, resource, data, headers, ignore_codes)"},{"line_number":177,"context_line":"        if self.server_failure(resp, ignore_codes):"},{"line_number":178,"context_line":"            LOG.error(_(\"NeutronRestProxyV2: \") + errstr, resp[2])"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_318e5733","line":175,"updated":"2014-07-23 12:21:05.000000000","message":"use literal from requests, instead of magic number.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"1b0ce1128bd46b4644d4678e0cb082222d39c990","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                          \"%(resource)s\"),"},{"line_number":183,"context_line":"                        {\u0027code\u0027: resp[2], \u0027action\u0027: action,"},{"line_number":184,"context_line":"                         \u0027resource\u0027: resource})"},{"line_number":185,"context_line":"        return resp"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def rest_create_network(self, tenant_id, network):"},{"line_number":188,"context_line":"        resource \u003d NET_RESOURCE_PATH % tenant_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_eb3807d6","line":185,"updated":"2014-07-25 18:53:29.000000000","message":"why this? resp not used in callers.","commit_id":"2758c32515c04c4965f816aa3596ee573abb2029"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"f113305c18b332ee59ca09f05524b13b86f95333","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                          \"%(resource)s\"),"},{"line_number":183,"context_line":"                        {\u0027code\u0027: resp[2], \u0027action\u0027: action,"},{"line_number":184,"context_line":"                         \u0027resource\u0027: resource})"},{"line_number":185,"context_line":"        return resp"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    def rest_create_network(self, tenant_id, network):"},{"line_number":188,"context_line":"        resource \u003d NET_RESOURCE_PATH % tenant_id"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_15914c52","line":185,"in_reply_to":"baada198_eb3807d6","updated":"2014-08-19 09:20:27.000000000","message":"done, remove \"return resp\"","commit_id":"2758c32515c04c4965f816aa3596ee573abb2029"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"230967a65e87d9f53f30e0b536c228084a9e990d","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def rest_action(self, action, resource, data\u003d\u0027\u0027, errstr\u003d\u0027%s\u0027,"},{"line_number":165,"context_line":"                    ignore_codes\u003d[], headers\u003dNone):"},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        Wrapper function for rest_call."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        It verifies success and raises a RemoteRestError on failure"},{"line_number":170,"context_line":"        with a provided error string. By default, 404 errors on DELETE"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_eacaaa19","line":167,"updated":"2014-08-22 06:20:44.000000000","message":"This should be like,\n\n\"\"\" Wrapper function fro rest_call.","commit_id":"97239e77514419ac7fc868f91cf8ebe4ab67026a"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"5ab5e33194a521c1856621bcf3c2416573f5dc5f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"    def rest_action(self, action, resource, data\u003d\u0027\u0027, errstr\u003d\u0027%s\u0027,"},{"line_number":165,"context_line":"                    ignore_codes\u003d[], headers\u003dNone):"},{"line_number":166,"context_line":"        \"\"\""},{"line_number":167,"context_line":"        Wrapper function for rest_call."},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"        It verifies success and raises a RemoteRestError on failure"},{"line_number":170,"context_line":"        with a provided error string. By default, 404 errors on DELETE"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_0086e2da","line":167,"in_reply_to":"1abeadc6_eacaaa19","updated":"2014-08-22 10:23:02.000000000","message":"done","commit_id":"97239e77514419ac7fc868f91cf8ebe4ab67026a"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"11e1268a1fdcbb1f242c1d578984ef5c85d51427","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            r.raise_for_status()"},{"line_number":91,"context_line":"        except requests.exceptions.RequestException as e:"},{"line_number":92,"context_line":"            LOG.error(_(\u0027ServerProxy: %(action)s failure, %(e)r\u0027),"},{"line_number":93,"context_line":"                      {\u0027action\u0027: action, \u0027e\u0027: e})"},{"line_number":94,"context_line":"            return 0, None, None, None"},{"line_number":95,"context_line":"        respstr \u003d r.text"},{"line_number":96,"context_line":"        respdata \u003d respstr"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_3812cf62","line":93,"updated":"2014-08-26 07:15:27.000000000","message":"_LE () here too","commit_id":"5942c30b380bc0fcbe44dd9e8c47d2338d5f3fa9"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"11e1268a1fdcbb1f242c1d578984ef5c85d51427","unresolved":false,"context_lines":[{"line_number":156,"context_line":"            LOG.error(_(\"ServerProxy: Error details: status\u003d%(status)d, \""},{"line_number":157,"context_line":"                        \"reason\u003d%(reason)r, ret\u003d%(ret)s, data\u003d%(data)r\"),"},{"line_number":158,"context_line":"                      {\u0027status\u0027: ret[0], \u0027reason\u0027: ret[1], \u0027ret\u0027: ret[2],"},{"line_number":159,"context_line":"                       \u0027data\u0027: ret[3]})"},{"line_number":160,"context_line":"            self.server.failed \u003d True"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        return (0, None, None, None)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_58178b51","line":159,"updated":"2014-08-26 07:15:27.000000000","message":"_LE(), here too ditto for all LOG.error here.","commit_id":"5942c30b380bc0fcbe44dd9e8c47d2338d5f3fa9"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"11e1268a1fdcbb1f242c1d578984ef5c85d51427","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                          \"code %(code)s on %(action)s action to resource \""},{"line_number":181,"context_line":"                          \"%(resource)s\"),"},{"line_number":182,"context_line":"                        {\u0027code\u0027: resp[2], \u0027action\u0027: action,"},{"line_number":183,"context_line":"                         \u0027resource\u0027: resource})"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    def rest_create_network(self, tenant_id, network):"},{"line_number":186,"context_line":"        resource \u003d NET_RESOURCE_PATH % tenant_id"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_780b672b","line":183,"updated":"2014-08-26 07:15:27.000000000","message":"_LW()","commit_id":"5942c30b380bc0fcbe44dd9e8c47d2338d5f3fa9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"10af4a564f13311fc285cee84835c7138062cf23","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import base64"},{"line_number":19,"context_line":"import requests"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# from oslo.config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.common import utils"},{"line_number":24,"context_line":"from neutron.openstack.common.gettextutils import _LE"}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_fdc3d287","line":21,"updated":"2014-08-26 16:09:32.000000000","message":"line to remove","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"10af4a564f13311fc285cee84835c7138062cf23","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        Note: We assume 301-303 is a failure, and try the next server in"},{"line_number":134,"context_line":"        the server pool."},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        return (resp[0] in FAILURE_CODES and resp[0] not in ignore_codes)"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    def action_success(self, resp):"},{"line_number":139,"context_line":"        \"\"\"Defining success codes as required."}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_bd587afb","line":136,"updated":"2014-08-26 16:09:32.000000000","message":"() are not required","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"10af4a564f13311fc285cee84835c7138062cf23","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                       \u0027data\u0027: ret[3]})"},{"line_number":162,"context_line":"            self.server.failed \u003d True"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        return (0, None, None, None)"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def rest_action(self, action, resource, data\u003d\u0027\u0027, errstr\u003d\u0027%s\u0027,"},{"line_number":167,"context_line":"                    ignore_codes\u003d[], headers\u003dNone):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_3d6c6a9c","line":164,"updated":"2014-08-26 16:09:32.000000000","message":"itto","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"10af4a564f13311fc285cee84835c7138062cf23","unresolved":false,"context_lines":[{"line_number":222,"context_line":"                            remote_interface_id):"},{"line_number":223,"context_line":"        if port[\"mac_address\"] is not None:"},{"line_number":224,"context_line":"            resource \u003d ATTACHMENT_PATH % (tenant_id, net_id, port[\"id\"])"},{"line_number":225,"context_line":"            data \u003d {\"attachment\":"},{"line_number":226,"context_line":"                    {"},{"line_number":227,"context_line":"                        \"id\": remote_interface_id,"},{"line_number":228,"context_line":"                        \"mac\": port[\"mac_address\"]"}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_bd26ba66","line":225,"updated":"2014-08-26 16:09:32.000000000","message":"indentation in the dict seems incorrect","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"12ae704eed5ef1d7f5abecc14b64264fd182183b","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"\"\"\"A client for Huawei sdn controller.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import base64"},{"line_number":19,"context_line":"import requests"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.common import utils"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_7a4ebac2","line":18,"updated":"2014-08-27 14:55:06.000000000","message":"nit: insert a line between those 2 imports\n http://docs.openstack.org/developer/hacking/#import-order-template","commit_id":"eb027339c9f16b680e13440afd6747524530a4d4"}],"neutron/plugins/ml2/drivers/huawei/config.py":[{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"f0ee34f9c0f81125ab35bce87865a0b5f5f67430","unresolved":false,"context_lines":[{"line_number":50,"context_line":"                   \u0027Huawei sdn controller service port. It is required field.\u0027"},{"line_number":51,"context_line":"                   \u0027If not set, all communications to Huawei sdn controller\u0027"},{"line_number":52,"context_line":"                   \u0027will fail\u0027)),"},{"line_number":53,"context_line":"    cfg.IntOpt(\u0027sync_interval\u0027,"},{"line_number":54,"context_line":"               default\u003d180,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Sync interval in seconds between Neutron plugin and\u0027"},{"line_number":56,"context_line":"                      \u0027sdn controller. This interval defines how often the\u0027"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_456cad35","line":53,"updated":"2014-07-03 14:46:00.000000000","message":"Is this required if there is no sync mechanism ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a7d655a62afdc1c6f811150245ff35f011c7d684","unresolved":false,"context_lines":[{"line_number":20,"context_line":"driver. The nos_username, nos_password, nos_host, and nos_port are"},{"line_number":21,"context_line":"required options."},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_41d43a1f","line":23,"updated":"2014-07-22 05:51:30.000000000","message":"Rather than a separate file, you can push this code into the mechanism driver codebase. can you give a try.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"3f34e8769050fdda4c6f6a195023cd39023a23d4","unresolved":false,"context_lines":[{"line_number":20,"context_line":"driver. The nos_username, nos_password, nos_host, and nos_port are"},{"line_number":21,"context_line":"required options."},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from oslo.config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_7c05ea13","line":23,"in_reply_to":"baada198_41d43a1f","updated":"2014-07-24 09:54:46.000000000","message":"Since we will add new feature to this driver later and maybe new configuration option will be added, I think it\u0027s fine to leave them in a separate file.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    cfg.StrOpt(\u0027nos_username\u0027,"},{"line_number":29,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":30,"context_line":"               help\u003d_("},{"line_number":31,"context_line":"                   \u0027Username for Huawei sdn controller. It is required field.\u0027"},{"line_number":32,"context_line":"                   \u0027if not set, all communications to Huawei sdn controller\u0027"},{"line_number":33,"context_line":"                   \u0027will fail\u0027)),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027nos_password\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_113dd32c","line":31,"updated":"2014-07-23 12:21:05.000000000","message":"space after period at end of line.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":29,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":30,"context_line":"               help\u003d_("},{"line_number":31,"context_line":"                   \u0027Username for Huawei sdn controller. It is required field.\u0027"},{"line_number":32,"context_line":"                   \u0027if not set, all communications to Huawei sdn controller\u0027"},{"line_number":33,"context_line":"                   \u0027will fail\u0027)),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027nos_password\u0027,"},{"line_number":35,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_3138173b","line":32,"updated":"2014-07-23 12:21:05.000000000","message":"if -\u003e If. Add space at end of string.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":36,"context_line":"               secret\u003dTrue,"},{"line_number":37,"context_line":"               help\u003d_("},{"line_number":38,"context_line":"                   \u0027Password for Huawei sdn controller. It is required field.\u0027"},{"line_number":39,"context_line":"                   \u0027if not set, all communications to Huawei sdn controller\u0027"},{"line_number":40,"context_line":"                   \u0027will fail\u0027)),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027nos_host\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_71428fac","line":38,"updated":"2014-07-23 12:21:05.000000000","message":"Space after last period.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":36,"context_line":"               secret\u003dTrue,"},{"line_number":37,"context_line":"               help\u003d_("},{"line_number":38,"context_line":"                   \u0027Password for Huawei sdn controller. It is required field.\u0027"},{"line_number":39,"context_line":"                   \u0027if not set, all communications to Huawei sdn controller\u0027"},{"line_number":40,"context_line":"                   \u0027will fail\u0027)),"},{"line_number":41,"context_line":"    cfg.StrOpt(\u0027nos_host\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_d10a7b78","line":39,"updated":"2014-07-23 12:21:05.000000000","message":"if -\u003e If, and space and end of string.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    cfg.StrOpt(\u0027nos_host\u0027,"},{"line_number":42,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":43,"context_line":"               help\u003d_("},{"line_number":44,"context_line":"                   \u0027Huawei sdn controller IP address. It is required field.\u0027"},{"line_number":45,"context_line":"                   \u0027If not set, all communications to Huawei sdn controller\u0027"},{"line_number":46,"context_line":"                   \u0027will fail\u0027)),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027nos_port\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_91772308","line":44,"updated":"2014-07-23 12:21:05.000000000","message":"Ditto on this one.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    cfg.IntOpt(\u0027nos_port\u0027,"},{"line_number":48,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":49,"context_line":"               help\u003d_("},{"line_number":50,"context_line":"                   \u0027Huawei sdn controller service port. It is required field.\u0027"},{"line_number":51,"context_line":"                   \u0027If not set, all communications to Huawei sdn controller\u0027"},{"line_number":52,"context_line":"                   \u0027will fail\u0027))"},{"line_number":53,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_b17a67ee","line":50,"updated":"2014-07-23 12:21:05.000000000","message":"Ditto","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"b225ef817d6b7a5a25a170fa303b57c0233ffb43","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo.config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Huawei_DRIVER_OPTS \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027nos_username\u0027,"},{"line_number":29,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":30,"context_line":"               help\u003d_("}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_1547f577","line":27,"updated":"2014-08-22 16:08:13.000000000","message":"Just for similarity, can we have this \tHuawei_DRIVER_OPTS as \tHUAWEI_DRIVER_OPTS.","commit_id":"26e6d5f18773ce8a82c099ed90b7bd9dd185db08"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"ee910b89e399a48f4526e692d21161379fc84cf5","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from oslo.config import cfg"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Huawei_DRIVER_OPTS \u003d ["},{"line_number":28,"context_line":"    cfg.StrOpt(\u0027nos_username\u0027,"},{"line_number":29,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":30,"context_line":"               help\u003d_("}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_68fe5d07","line":27,"in_reply_to":"1abeadc6_1547f577","updated":"2014-08-25 11:58:41.000000000","message":"done","commit_id":"26e6d5f18773ce8a82c099ed90b7bd9dd185db08"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"10af4a564f13311fc285cee84835c7138062cf23","unresolved":false,"context_lines":[{"line_number":52,"context_line":"                   \u0027will fail\u0027))"},{"line_number":53,"context_line":"]"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"cfg.CONF.register_opts(HUAWEI_DRIVER_OPTS, \"ml2_Huawei\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_ddae1698","line":55,"updated":"2014-08-26 16:09:32.000000000","message":"ml2_huawei?","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"12ae704eed5ef1d7f5abecc14b64264fd182183b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"                   \u0027If not set, all communications to Huawei sdn controller \u0027"},{"line_number":46,"context_line":"                   \u0027will fail\u0027)),"},{"line_number":47,"context_line":"    cfg.IntOpt(\u0027nos_port\u0027,"},{"line_number":48,"context_line":"               default\u003d\u0027\u0027,"},{"line_number":49,"context_line":"               help\u003d_("},{"line_number":50,"context_line":"                   \u0027Huawei sdn controller service port. It is required field. \u0027"},{"line_number":51,"context_line":"                   \u0027If not set, all communications to Huawei sdn controller \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_7d6234d9","line":48,"updated":"2014-08-27 14:55:06.000000000","message":"Shouldn\u0027t default for IntOpt be int ?","commit_id":"eb027339c9f16b680e13440afd6747524530a4d4"}],"neutron/plugins/ml2/drivers/huawei/exceptions.py":[{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"e0174cef541eb94826cadd0a874e349fe4350dd8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Exceptions used by Arista ML2 Mechanism Driver.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import exceptions"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_178da731","line":17,"updated":"2014-07-02 21:30:16.000000000","message":"Fix the typo (Huawei and not Arista)","commit_id":"bc725caf82d50a88500a9662c844e15fc48512e3"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"0a2b527540e3044a0dc28e0f003db8d103f818c4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_93a06043","line":1,"updated":"2014-07-15 13:54:25.000000000","message":"2013 -\u003e 2014","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a7d655a62afdc1c6f811150245ff35f011c7d684","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Exceptions used by Huawei ML2 Mechanism Driver.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import exceptions"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_a76e06c6","line":17,"updated":"2014-07-22 05:51:30.000000000","message":"you may have this simple code base too into the MD codebase.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"3f34e8769050fdda4c6f6a195023cd39023a23d4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Exceptions used by Huawei ML2 Mechanism Driver.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron.common import exceptions"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_d72def90","line":17,"in_reply_to":"baada198_a76e06c6","updated":"2014-07-24 09:54:46.000000000","message":"Same reason as config.py, we would like to keep this file since new exception may be added in our later driver update.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    def __init__(self, message):"},{"line_number":28,"context_line":"        message \u003d message or \"None\""},{"line_number":29,"context_line":"        self.message \u003d _(\"Error in REST call to remote network \""},{"line_number":30,"context_line":"                         \"controller: \") + message"},{"line_number":31,"context_line":"        super(RemoteRestError, self).__init__()"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_91c5630c","line":30,"updated":"2014-07-23 12:21:05.000000000","message":"I\u0027d use the following, so that message is also processed for i18n:\n    \"controller: %s\") % message","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"}],"neutron/plugins/ml2/drivers/huawei/mech_huawei.py":[{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"e0174cef541eb94826cadd0a874e349fe4350dd8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class HuaweiDriver(driver_api.MechanismDriver):"},{"line_number":40,"context_line":"    \"\"\"Ml2 Mechanism driver for Huawei networking hardware."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    Remebers all networks and VMs that are provisioned on Arista Hardware."},{"line_number":43,"context_line":"    Does not send network provisioning request if the network has already been"},{"line_number":44,"context_line":"    provisioned before for the given port."},{"line_number":45,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_d7eecfb3","line":42,"updated":"2014-07-02 21:30:16.000000000","message":"Change Arista to Huawei","commit_id":"bc725caf82d50a88500a9662c844e15fc48512e3"},{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"91490c726a4f5171e87d015891eca38def2d19cd","unresolved":false,"context_lines":[{"line_number":39,"context_line":"class HuaweiDriver(driver_api.MechanismDriver):"},{"line_number":40,"context_line":"    \"\"\"Ml2 Mechanism driver for Huawei networking hardware."},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    Remebers all networks and VMs that are provisioned on Huawei Hardware."},{"line_number":43,"context_line":"    Does not send network provisioning request if the network has already been"},{"line_number":44,"context_line":"    provisioned before for the given port."},{"line_number":45,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f7e10cd1","line":42,"updated":"2014-07-03 02:47:36.000000000","message":"Is this comment relevant here ? Don\u0027t see any db save operation in the file","commit_id":"9d9bc3cf55a6d614928cd42f3e614f1ff0f92ef5"},{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"078d5b253726376badfba0bebc98c96005a790b8","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            raise ml2_exc.HuaweiDriverError("},{"line_number":271,"context_line":"                method\u003d\"delete_subnet_postcommit\")"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def _synchronization_thread(self):"},{"line_number":274,"context_line":"        with self.sdn_sync_lock:"},{"line_number":275,"context_line":"            self.sdn.synchronize()"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_63ab7ed6","line":273,"updated":"2014-07-03 05:31:20.000000000","message":"Where is the function invoked for the first time ?","commit_id":"9d9bc3cf55a6d614928cd42f3e614f1ff0f92ef5"},{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"fd1fca7834eedbcf1a6208bdaf239b6cc81ba460","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def _synchronization_thread(self):"},{"line_number":274,"context_line":"        with self.sdn_sync_lock:"},{"line_number":275,"context_line":"            self.sdn.synchronize()"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"        self.timer \u003d threading.Timer(self.sync_timeout,"},{"line_number":278,"context_line":"                                     self._synchronization_thread)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_c805497b","line":275,"updated":"2014-07-03 05:10:28.000000000","message":"Where is self.sdn defined ?","commit_id":"9d9bc3cf55a6d614928cd42f3e614f1ff0f92ef5"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_b5c20532","line":1,"updated":"2014-07-03 22:08:03.000000000","message":"Inconsistent copyright holders. Some files use the foundation and others Huawei.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":11,"context_line":"# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or"},{"line_number":12,"context_line":"# implied."},{"line_number":13,"context_line":"# See the License for the specific language governing permissions and"},{"line_number":14,"context_line":"# limitations under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import copy"},{"line_number":17,"context_line":"import threading"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d5bf79a8","line":14,"updated":"2014-07-03 22:08:03.000000000","message":"Other files list the authors.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"SDN_UNREACHABLE_MSG \u003d \"Unable to reach sdn\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_150c91a4","line":35,"updated":"2014-07-03 22:08:03.000000000","message":"Since this error is displayed in the log, could it be a tad more verbose?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"56b50f0c2ff41c70053d25faa3dd165dad77006b","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"SDN_UNREACHABLE_MSG \u003d \"Unable to reach sdn\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_872ae97b","line":35,"in_reply_to":"baada198_150c91a4","updated":"2014-07-22 04:17:29.000000000","message":"This driver uses a client to send requests, and the detailed error message will be logged by the client.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"0a2b527540e3044a0dc28e0f003db8d103f818c4","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    \"\"\"Ml2 Mechanism driver for Huawei networking hardware.\"\"\""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        confg \u003d cfg.CONF.ml2_Huawei"},{"line_number":44,"context_line":"        self.segmentation_type \u003d constants.TYPE_VXLAN"},{"line_number":45,"context_line":"        self.db_base_plugin_v2 \u003d db_base_plugin_v2.NeutronDbPluginV2()"},{"line_number":46,"context_line":"        self.external_net_db \u003d external_net_db.External_net_db_mixin()"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_280722cb","line":43,"updated":"2014-07-15 13:54:25.000000000","message":"confg -\u003e config ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"0a2b527540e3044a0dc28e0f003db8d103f818c4","unresolved":false,"context_lines":[{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def __init__(self):"},{"line_number":43,"context_line":"        confg \u003d cfg.CONF.ml2_Huawei"},{"line_number":44,"context_line":"        self.segmentation_type \u003d constants.TYPE_VXLAN"},{"line_number":45,"context_line":"        self.db_base_plugin_v2 \u003d db_base_plugin_v2.NeutronDbPluginV2()"},{"line_number":46,"context_line":"        self.external_net_db \u003d external_net_db.External_net_db_mixin()"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_68c83aa8","line":44,"updated":"2014-07-15 13:54:25.000000000","message":"what\u0027s this variable, where to use it ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"f0ee34f9c0f81125ab35bce87865a0b5f5f67430","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self.external_net_db \u003d external_net_db.External_net_db_mixin()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        self.cxt \u003d qcontext.get_admin_context()"},{"line_number":49,"context_line":"        self.sdn_sync_lock \u003d threading.Lock()"},{"line_number":50,"context_line":"        self.client_sdn \u003d clients.SdnClient(confg.nos_host, confg.nos_port)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def initialize(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_45ae6de7","line":49,"updated":"2014-07-03 14:46:00.000000000","message":"Is the lock required if there is no sync mechanism ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"f0ee34f9c0f81125ab35bce87865a0b5f5f67430","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.sdn_sync_lock \u003d threading.Lock()"},{"line_number":50,"context_line":"        self.client_sdn \u003d clients.SdnClient(confg.nos_host, confg.nos_port)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def initialize(self):"},{"line_number":53,"context_line":"        LOG.info(_(\"huawei driver instance build...\"))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def create_network_postcommit(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8815fce6","line":52,"updated":"2014-07-03 14:46:00.000000000","message":"Where is initialize() called ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"56b50f0c2ff41c70053d25faa3dd165dad77006b","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        self.sdn_sync_lock \u003d threading.Lock()"},{"line_number":50,"context_line":"        self.client_sdn \u003d clients.SdnClient(confg.nos_host, confg.nos_port)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def initialize(self):"},{"line_number":53,"context_line":"        LOG.info(_(\"huawei driver instance build...\"))"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def create_network_postcommit(self, context):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_4788d16a","line":52,"in_reply_to":"baada198_8815fce6","updated":"2014-07-22 04:17:29.000000000","message":"This method is called by the mechanism manager.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"0a2b527540e3044a0dc28e0f003db8d103f818c4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def create_network_postcommit(self, context):"},{"line_number":56,"context_line":"        \"\"\"Provision the network on the Huawei Hardware.\"\"\""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        LOG.info(_(\"enter HuaweiDriver:create_network_postcommit()\"))"},{"line_number":59,"context_line":"        network \u003d context.current"},{"line_number":60,"context_line":"        network_id \u003d network[\u0027id\u0027]"},{"line_number":61,"context_line":"        tenant_id \u003d network[\u0027tenant_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a8d252fd","line":58,"updated":"2014-07-15 13:54:25.000000000","message":"looks strange, pls remove this line","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":2711,"name":"Zhang Hua","display_name":"Zhang Hua","email":"joshua.zhang@canonical.com","username":"zhhuabj"},"change_message_id":"0a2b527540e3044a0dc28e0f003db8d103f818c4","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                self.client_sdn.rest_create_network(tenant_id,"},{"line_number":72,"context_line":"                                                    mapped_network)"},{"line_number":73,"context_line":"            except clients.RemoteRestError:"},{"line_number":74,"context_line":"                LOG.error(SDN_UNREACHABLE_MSG)"},{"line_number":75,"context_line":"                raise ml2_exc.HuaweiDriverError("},{"line_number":76,"context_line":"                    method\u003d\"create_network_postcommit\")"},{"line_number":77,"context_line":"            msg \u003d _(\u0027Network %s is created\u0027) % network_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_7b21e29c","line":74,"updated":"2014-07-15 13:54:25.000000000","message":"why don\u0027t we log the detail RemoteRestError exception ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"56b50f0c2ff41c70053d25faa3dd165dad77006b","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                self.client_sdn.rest_create_network(tenant_id,"},{"line_number":72,"context_line":"                                                    mapped_network)"},{"line_number":73,"context_line":"            except clients.RemoteRestError:"},{"line_number":74,"context_line":"                LOG.error(SDN_UNREACHABLE_MSG)"},{"line_number":75,"context_line":"                raise ml2_exc.HuaweiDriverError("},{"line_number":76,"context_line":"                    method\u003d\"create_network_postcommit\")"},{"line_number":77,"context_line":"            msg \u003d _(\u0027Network %s is created\u0027) % network_id"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_5dbd0067","line":74,"in_reply_to":"baada198_7b21e29c","updated":"2014-07-22 04:17:29.000000000","message":"Detailed message will be logged by the client.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"55c4e65b26d13d5217d2a42b92005d022c72d699","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            msg \u003d _(\u0027Network %s is created\u0027) % network_id"},{"line_number":78,"context_line":"            LOG.info(msg)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def update_network_precommit(self, context):"},{"line_number":81,"context_line":"        \"\"\"At the moment we only support network name change"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        Any other change in network is not supported at this time."}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_d5c3f954","line":80,"updated":"2014-07-03 22:08:03.000000000","message":"What\u0027s the point of this code? Why not just implement postcommit? Does the log message actually have any value, especially considering that this is a precommit that is not guaranteed to succeed?\n\nSame comment for update_port_precommit.","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":9380,"name":"Sayaji Patil","email":"sayaji15@gmail.com","username":"Sayaji"},"change_message_id":"f0ee34f9c0f81125ab35bce87865a0b5f5f67430","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        with self.sdn_sync_lock:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"            # Succeed deleting network in case sdn is not accessible."},{"line_number":121,"context_line":"            # sdn state will be updated by sync thread once sdn gets"},{"line_number":122,"context_line":"            # alive."},{"line_number":123,"context_line":"            try:"},{"line_number":124,"context_line":"                self.client_sdn.rest_delete_network(tenant_id, network_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_e556a1cd","line":121,"updated":"2014-07-03 14:46:00.000000000","message":"Is the comment required ?","commit_id":"973ee355f91674aaa0b78ae08fe1d97d491fe0a1"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class HuaweiDriver(driver_api.MechanismDriver):"},{"line_number":38,"context_line":"    \"\"\"Ml2 Mechanism driver for Huawei networking hardware.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def __init__(self):"},{"line_number":41,"context_line":"        config \u003d cfg.CONF.ml2_Huawei"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_f1d21fd0","line":38,"updated":"2014-07-23 12:21:05.000000000","message":"nit: PEP257 blank line before docstring for a class.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        try:"},{"line_number":60,"context_line":"            mapped_network \u003d self._get_mapped_network_with_subnets("},{"line_number":61,"context_line":"                network)"},{"line_number":62,"context_line":"            LOG.info(_(\"mapped_network \u003d %(map_net)s\"),"},{"line_number":63,"context_line":"                     {\"map_net\": mapped_network})"},{"line_number":64,"context_line":"            # create network on the network controller"},{"line_number":65,"context_line":"            self.client_sdn.rest_create_network(tenant_id,"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_51faeb43","line":62,"updated":"2014-07-23 12:21:05.000000000","message":"You don\u0027t need dict for single format argument. Can just use %s and value","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            # create network on the network controller"},{"line_number":65,"context_line":"            self.client_sdn.rest_create_network(tenant_id,"},{"line_number":66,"context_line":"                                                mapped_network)"},{"line_number":67,"context_line":"        except ml2_exc.RemoteRestError:"},{"line_number":68,"context_line":"            LOG.error(SDN_UNREACHABLE_MSG)"},{"line_number":69,"context_line":"            raise ml2_exc.HuaweiDriverError("},{"line_number":70,"context_line":"                method\u003d\"create_network_postcommit\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ec21689f","line":67,"updated":"2014-07-23 12:21:05.000000000","message":"On all the exception clauses in this file, where you are catching one exception and raising another, use excutils save_and_reraise_exception()","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        LOG.info(msg)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def update_network_postcommit(self, context):"},{"line_number":75,"context_line":"        \"\"\"At the moment we only support network name change"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        If network name is changed, a new network create request is"},{"line_number":78,"context_line":"        sent to the sdn controller."}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_f145bf6f","line":75,"updated":"2014-07-23 12:21:05.000000000","message":"Nit: summary line for docstring should summarize the purpose of the function (and end in a period).","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":88,"context_line":"                raise ml2_exc.HuaweiDriverError("},{"line_number":89,"context_line":"                    method\u003d\"update_network_postcommit\")"},{"line_number":90,"context_line":"            msg \u003d _(\u0027Network %s is updated\u0027) % network_id"},{"line_number":91,"context_line":"            LOG.info(msg)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def delete_network_postcommit(self, context):"},{"line_number":94,"context_line":"        \"\"\"Send network delete request to sdn controller.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_4c1b3473","line":91,"updated":"2014-07-23 12:21:05.000000000","message":"Nit: You could remove L83, and combine L90-91:\n    LOG.info(_(\u0027Network %s is updated\u0027), new_network[\u0027id\u0027])","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":121,"context_line":"            try:"},{"line_number":122,"context_line":"                self.client_sdn.rest_create_port(net, port)"},{"line_number":123,"context_line":"            except ml2_exc.RemoteRestError:"},{"line_number":124,"context_line":"                LOG.error(_(\"create port %(port)s on controller failed,\""},{"line_number":125,"context_line":"                            \"reason:%(reason)s\"),"},{"line_number":126,"context_line":"                          {\"port\": port[\u0027id\u0027], \"reason\": SDN_UNREACHABLE_MSG})"},{"line_number":127,"context_line":"                raise ml2_exc.HuaweiDriverError("}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ac4e906c","line":124,"updated":"2014-07-23 12:21:05.000000000","message":"space after comma?","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":173,"context_line":"    def create_subnet_postcommit(self, context):"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        subnet \u003d context.current"},{"line_number":176,"context_line":"        net_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":177,"context_line":"        context \u003d qcontext.get_admin_context()"},{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            orig_net \u003d self.db_base_plugin_v2.get_network(context, net_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_6ce0f826","line":176,"updated":"2014-07-23 12:21:05.000000000","message":"subnet is only used to get net_id, could combine and remove the subnet temp variable.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        subnet \u003d context.current"},{"line_number":176,"context_line":"        net_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":177,"context_line":"        context \u003d qcontext.get_admin_context()"},{"line_number":178,"context_line":"        try:"},{"line_number":179,"context_line":"            orig_net \u003d self.db_base_plugin_v2.get_network(context, net_id)"},{"line_number":180,"context_line":"            # update network on network controller"},{"line_number":181,"context_line":"            self._send_update_network(orig_net, context)"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_6c89d86e","line":178,"updated":"2014-07-23 12:21:05.000000000","message":"Code in L178-185 is the same in other functions (along with L175-176 too maybe?).  Consider a helper function that is called that does this functionality (passing method string), to reduce duplication.\n\n    def update_network_on_network_controller(self, context, net_id, method):\n        try:\n            ...\n        except ml2_exc.RemoteRestError:\n            ...\n\n    def create_subnet_postcommit(self, context):\n        net_id \u003d context.current[\u0027network_id\u0027]\n        context \u003d qcontext.get_admin_context()\n        self.update_network_on_network_controller(context, net_id, \u0027create_subnet_postcommit\u0027)\n\n     def update_subnet_postcommit(self, context):\n        net_id \u003d context.current[\u0027network_id\u0027]\n        self.update_network_on_network_controller(context, net_id, \u0027update_subnet_postcommit\u0027)","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":218,"context_line":"        subnets \u003d self._get_all_subnets_json_for_network(network[\u0027id\u0027],"},{"line_number":219,"context_line":"                                                         context)"},{"line_number":220,"context_line":"        network[\u0027subnets\u0027] \u003d subnets"},{"line_number":221,"context_line":"        for subnet in (subnets or []):"},{"line_number":222,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"},{"line_number":223,"context_line":"                # FIX: For backward compatibility with wire protocol"},{"line_number":224,"context_line":"                network[\u0027gateway\u0027] \u003d subnet[\u0027gateway_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2ce0c0f7","line":221,"updated":"2014-07-23 12:21:05.000000000","message":"don\u0027t need \u0027or []\u0027 as _get_all_subnets_json_for_network() will return empty list, if no subnets.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        network[\u0027subnets\u0027] \u003d subnets"},{"line_number":221,"context_line":"        for subnet in (subnets or []):"},{"line_number":222,"context_line":"            if subnet[\u0027gateway_ip\u0027]:"},{"line_number":223,"context_line":"                # FIX: For backward compatibility with wire protocol"},{"line_number":224,"context_line":"                network[\u0027gateway\u0027] \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":225,"context_line":"                break"},{"line_number":226,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ccb2e405","line":223,"updated":"2014-07-23 12:21:05.000000000","message":"FIX -\u003e TODO(username): Fix for backward compatibility with wire protocol?","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":223,"context_line":"                # FIX: For backward compatibility with wire protocol"},{"line_number":224,"context_line":"                network[\u0027gateway\u0027] \u003d subnet[\u0027gateway_ip\u0027]"},{"line_number":225,"context_line":"                break"},{"line_number":226,"context_line":"            else:"},{"line_number":227,"context_line":"                network[\u0027gateway\u0027] \u003d \u0027\u0027"},{"line_number":228,"context_line":"        network["},{"line_number":229,"context_line":"            external_net.EXTERNAL] \u003d self.external_net_db.network_is_external("}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_0ca13c95","line":226,"updated":"2014-07-23 12:21:05.000000000","message":"Could set network[\u0027gateway\u0027] to \u0027\u0027 before loop and then skip else clause, rather than setting it to \u0027\u0027 for each pass through loop (until gateway found).","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a7d655a62afdc1c6f811150245ff35f011c7d684","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            del resource[\u0027status\u0027]"},{"line_number":240,"context_line":"        return resource"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def _get_all_subnets_json_for_network(self, net_id, context\u003dNone):"},{"line_number":243,"context_line":"        if context is None:"},{"line_number":244,"context_line":"            context \u003d qcontext.get_admin_context()"},{"line_number":245,"context_line":"            # start a sub-transaction to avoid breaking parent transactions"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_67d4ee46","line":242,"updated":"2014-07-22 05:51:30.000000000","message":"you may want to write the comments for each function to detail the task it is doing.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":239,"context_line":"            del resource[\u0027status\u0027]"},{"line_number":240,"context_line":"        return resource"},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def _get_all_subnets_json_for_network(self, net_id, context\u003dNone):"},{"line_number":243,"context_line":"        if context is None:"},{"line_number":244,"context_line":"            context \u003d qcontext.get_admin_context()"},{"line_number":245,"context_line":"            # start a sub-transaction to avoid breaking parent transactions"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_ccae6481","line":242,"in_reply_to":"baada198_67d4ee46","updated":"2014-07-23 12:21:05.000000000","message":"+1 especially for public functions.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"1b0ce1128bd46b4644d4678e0cb082222d39c990","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                    method\u003d\"create_network_postcommit\")"},{"line_number":72,"context_line":"        LOG.info(_(\u0027Network %s is created\u0027) % network_id)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def update_network_postcommit(self, context):"},{"line_number":75,"context_line":"        \"\"\"Send network update request to sdn controller.\"\"\""},{"line_number":76,"context_line":"        new_network \u003d context.current"},{"line_number":77,"context_line":"        orig_network \u003d context.original"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_ebc80758","line":74,"updated":"2014-07-25 18:53:29.000000000","message":"For updates that are not supported this quietly does not do anything. This would mean the Neutron db will get updated and the controller will be out of sync and there is not even a log indicating this. Would you not want to prevent this by failing/raising in the pre commit operation?","commit_id":"2758c32515c04c4965f816aa3596ee573abb2029"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"1b0ce1128bd46b4644d4678e0cb082222d39c990","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                               \"reason\": SDN_UNREACHABLE_MSG})"},{"line_number":141,"context_line":"                    raise ml2_exc.HuaweiDriverError("},{"line_number":142,"context_line":"                        method\u003d\"create_port_postcommit\")"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def delete_port_postcommit(self, context):"},{"line_number":145,"context_line":"        \"\"\"unPlug a physical host from a network.\"\"\""},{"line_number":146,"context_line":"        port \u003d context.current"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_abe28fd1","line":143,"updated":"2014-07-25 18:53:29.000000000","message":"No support for update port? Is this because you do not allow it? If that is the case then the comment above would apply here as well. This will also lead to a number of tempest api tests failing.","commit_id":"2758c32515c04c4965f816aa3596ee573abb2029"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"f113305c18b332ee59ca09f05524b13b86f95333","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                               \"reason\": SDN_UNREACHABLE_MSG})"},{"line_number":141,"context_line":"                    raise ml2_exc.HuaweiDriverError("},{"line_number":142,"context_line":"                        method\u003d\"create_port_postcommit\")"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def delete_port_postcommit(self, context):"},{"line_number":145,"context_line":"        \"\"\"unPlug a physical host from a network.\"\"\""},{"line_number":146,"context_line":"        port \u003d context.current"}],"source_content_type":"text/x-python","patch_set":6,"id":"1abeadc6_55c4a45e","line":143,"in_reply_to":"baada198_abe28fd1","updated":"2014-08-19 09:20:27.000000000","message":"Our driver doesn\u0027t support port updating currently. As you say, raising exception will lead to tempest tests failing, so we leave update_port_pre/postcommit unimplemented, like other ml2 driver: mechanism_brocade, mechanism_arista.","commit_id":"2758c32515c04c4965f816aa3596ee573abb2029"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"230967a65e87d9f53f30e0b536c228084a9e990d","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    LOG.error(SDN_UNREACHABLE_MSG)"},{"line_number":84,"context_line":"                    raise ml2_exc.HuaweiDriverError("},{"line_number":85,"context_line":"                        method\u003d\"update_network_postcommit\")"},{"line_number":86,"context_line":"            LOG.info(_(\u0027Network %s is updated\u0027) % new_network[\u0027id\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def delete_network_postcommit(self, context):"},{"line_number":89,"context_line":"        \"\"\"Send network delete request to sdn controller.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_aafb5245","line":86,"updated":"2014-08-22 06:20:44.000000000","message":"I think, its LOG.debug rather than info. Its providing more info for debugging.  Can you verify this once.","commit_id":"97239e77514419ac7fc868f91cf8ebe4ab67026a"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"5ab5e33194a521c1856621bcf3c2416573f5dc5f","unresolved":false,"context_lines":[{"line_number":83,"context_line":"                    LOG.error(SDN_UNREACHABLE_MSG)"},{"line_number":84,"context_line":"                    raise ml2_exc.HuaweiDriverError("},{"line_number":85,"context_line":"                        method\u003d\"update_network_postcommit\")"},{"line_number":86,"context_line":"            LOG.info(_(\u0027Network %s is updated\u0027) % new_network[\u0027id\u0027])"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def delete_network_postcommit(self, context):"},{"line_number":89,"context_line":"        \"\"\"Send network delete request to sdn controller.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_8043d2ad","line":86,"in_reply_to":"1abeadc6_aafb5245","updated":"2014-08-22 10:23:02.000000000","message":"If something wrong happens, the above LOG.error will give enough debugging information, so I think it\u0027s fine to use LOG.info here.","commit_id":"97239e77514419ac7fc868f91cf8ebe4ab67026a"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"230967a65e87d9f53f30e0b536c228084a9e990d","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                    LOG.error(_(\"plug interface %(id)s to server \""},{"line_number":138,"context_line":"                                \"%(device)s failed,reason:%(reason)s\"),"},{"line_number":139,"context_line":"                              {\"id\": port[\u0027id\u0027], \"device\": device_id,"},{"line_number":140,"context_line":"                               \"reason\": SDN_UNREACHABLE_MSG})"},{"line_number":141,"context_line":"                    raise ml2_exc.HuaweiDriverError("},{"line_number":142,"context_line":"                        method\u003d\"create_port_postcommit\")"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_6ab3fa97","line":140,"updated":"2014-08-22 06:20:44.000000000","message":"Can you use _LE here like, LOG.error(_LE()).","commit_id":"97239e77514419ac7fc868f91cf8ebe4ab67026a"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"5ab5e33194a521c1856621bcf3c2416573f5dc5f","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                    LOG.error(_(\"plug interface %(id)s to server \""},{"line_number":138,"context_line":"                                \"%(device)s failed,reason:%(reason)s\"),"},{"line_number":139,"context_line":"                              {\"id\": port[\u0027id\u0027], \"device\": device_id,"},{"line_number":140,"context_line":"                               \"reason\": SDN_UNREACHABLE_MSG})"},{"line_number":141,"context_line":"                    raise ml2_exc.HuaweiDriverError("},{"line_number":142,"context_line":"                        method\u003d\"create_port_postcommit\")"},{"line_number":143,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_40cffa55","line":140,"in_reply_to":"1abeadc6_6ab3fa97","updated":"2014-08-22 10:23:02.000000000","message":"done","commit_id":"97239e77514419ac7fc868f91cf8ebe4ab67026a"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"b225ef817d6b7a5a25a170fa303b57c0233ffb43","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                                mapped_network)"},{"line_number":68,"context_line":"        except ml2_exc.RemoteRestError:"},{"line_number":69,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":70,"context_line":"                LOG.error(SDN_UNREACHABLE_MSG)"},{"line_number":71,"context_line":"                raise ml2_exc.HuaweiDriverError("},{"line_number":72,"context_line":"                    method\u003d\"create_network_postcommit\")"},{"line_number":73,"context_line":"        LOG.info(_(\u0027Network %s is created\u0027) % network_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_d0058b11","line":70,"updated":"2014-08-22 16:08:13.000000000","message":"check with LOG.error(_LE(SDN_UNREACHABLE_MSG)) ?\ncheck all other error logs.","commit_id":"26e6d5f18773ce8a82c099ed90b7bd9dd185db08"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"ee910b89e399a48f4526e692d21161379fc84cf5","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                                                mapped_network)"},{"line_number":68,"context_line":"        except ml2_exc.RemoteRestError:"},{"line_number":69,"context_line":"            with excutils.save_and_reraise_exception(reraise\u003dFalse):"},{"line_number":70,"context_line":"                LOG.error(SDN_UNREACHABLE_MSG)"},{"line_number":71,"context_line":"                raise ml2_exc.HuaweiDriverError("},{"line_number":72,"context_line":"                    method\u003d\"create_network_postcommit\")"},{"line_number":73,"context_line":"        LOG.info(_(\u0027Network %s is created\u0027) % network_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"1abeadc6_a86dd5ce","line":70,"in_reply_to":"1abeadc6_d0058b11","updated":"2014-08-25 11:58:41.000000000","message":"It seems that pep8 check will raise \u0027H701  Empty localization string\u0027 when using \u0027_LE(SDN_UNREACHABLE_MSG)\u0027","commit_id":"26e6d5f18773ce8a82c099ed90b7bd9dd185db08"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"84978cd9678d86bcd1cfd6b6ed7b2cd424a6db57","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"SDN_UNREACHABLE_MSG \u003d \"Unable to reach SDN\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"class HuaweiDriver(driver_api.MechanismDriver):"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_4c943f44","line":36,"updated":"2014-08-25 21:46:30.000000000","message":"Need i18n for this message, used in log.","commit_id":"5942c30b380bc0fcbe44dd9e8c47d2338d5f3fa9"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"84978cd9678d86bcd1cfd6b6ed7b2cd424a6db57","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        try:"},{"line_number":62,"context_line":"            mapped_network \u003d self._get_mapped_network_with_subnets("},{"line_number":63,"context_line":"                network)"},{"line_number":64,"context_line":"            LOG.info(_(\"mapped_network \u003d %s\") % mapped_network)"},{"line_number":65,"context_line":"            # create network on the network controller"},{"line_number":66,"context_line":"            self.client_sdn.rest_create_network(tenant_id,"},{"line_number":67,"context_line":"                                                mapped_network)"}],"source_content_type":"text/x-python","patch_set":9,"id":"1abeadc6_cca04fa8","line":64,"updated":"2014-08-25 21:46:30.000000000","message":"nit: If you\u0027re energetic, you can use _LI() logs (like done for error logs). Or you can defer to a separate bug fix.","commit_id":"5942c30b380bc0fcbe44dd9e8c47d2338d5f3fa9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"10af4a564f13311fc285cee84835c7138062cf23","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"SDN_UNREACHABLE_MSG \u003d _LE(\"Unable to reach SDN\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class HuaweiDriver(driver_api.MechanismDriver):"}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_bd995a70","line":37,"updated":"2014-08-26 16:09:32.000000000","message":"it should be _() \n\nhttp://docs.openstack.org/developer/oslo.i18n/guidelines.html","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"},{"author":{"_account_id":1923,"name":"Mohammad Banikazemi","email":"mbanikazemi@gmail.com","username":"mb-s"},"change_message_id":"d40d9fad4f1f2ff11f4f829073b54496363e0ee2","unresolved":false,"context_lines":[{"line_number":37,"context_line":"SDN_UNREACHABLE_MSG \u003d _LE(\"Unable to reach SDN\")"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class HuaweiDriver(driver_api.MechanismDriver):"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    \"\"\"Ml2 Mechanism driver for Huawei networking hardware.\"\"\""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1abeadc6_96eb9877","line":40,"updated":"2014-08-26 19:50:25.000000000","message":"update_port_*commit are not defined here. Even if updating ports is not supported you may want to enforce that here.","commit_id":"a6331c77e8ccaf5a0923a13d9dc2b424a1061eb1"}],"neutron/tests/unit/ml2/drivers/test_huawei_mech.py":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"036b7e14e1883a2b96abba10827f1d9a7b47d153","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"# Copyright (c) 2013 OpenStack Foundation"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_26ea8375","line":1,"updated":"2014-07-02 20:13:53.000000000","message":"no editor config (bug/1229324)","commit_id":"bc725caf82d50a88500a9662c844e15fc48512e3"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a7d655a62afdc1c6f811150245ff35f011c7d684","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.plugins.ml2.drivers.huawei import mech_huawei as huawei"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.tests import base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class HuaweiDriverTestCase(base.BaseTestCase):"},{"line_number":25,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_7e9c7b0e","line":22,"updated":"2014-07-22 05:51:30.000000000","message":"You may need to configure the ML2 with this MD and also push the Driver specific configuration for testing.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class HuaweiDriverTestCase(base.BaseTestCase):"},{"line_number":25,"context_line":"    \"\"\""},{"line_number":26,"context_line":"        Test case for Huawei Ml2 driver"},{"line_number":27,"context_line":"    \"\"\""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_6cd478e9","line":25,"updated":"2014-07-23 12:21:05.000000000","message":"Nit: PEP257 class docstring - blank line before, summary text with period at end of line and on same line as triple quotes.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a7d655a62afdc1c6f811150245ff35f011c7d684","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(HuaweiDriverTestCase, self).setUp()"},{"line_number":31,"context_line":"        self.drv \u003d huawei.HuaweiDriver()"},{"line_number":32,"context_line":"        self.drv.client_sdn \u003d mock.MagicMock()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_create_network_on_valid_config(self):"},{"line_number":35,"context_line":"        tenant_id \u003d \"tenant-1\""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_be6d3334","line":32,"updated":"2014-07-22 05:51:30.000000000","message":"self.drv.client_sdn \u003d mock.Mock()\n\nuse Mock rather than magicMock.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        self.drv.client_sdn \u003d mock.MagicMock()"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def test_create_network_on_valid_config(self):"},{"line_number":35,"context_line":"        tenant_id \u003d \"tenant-1\""},{"line_number":36,"context_line":"        network_id \u003d \"net-1\""},{"line_number":37,"context_line":"        segmentation_id \u003d 10001"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_2c660056","line":35,"updated":"2014-07-23 12:21:05.000000000","message":"Consider taking some of the common code to setup the tests and put in a helper function or in setUp() to reduce duplication and allow the test to focus on what is being tested and not the infra to setup the test case.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"f869acc0f24cbf5cb9476864ba04f366ba864536","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        self.drv._get_mapped_network_with_subnets \u003d mock.MagicMock()"},{"line_number":49,"context_line":"        self.drv._get_mapped_network_with_subnets.return_value \u003d net_info"},{"line_number":50,"context_line":"        self.drv.create_network_postcommit(network_context)"},{"line_number":51,"context_line":"        self.drv.client_sdn.rest_create_network. \\"},{"line_number":52,"context_line":"            assert_called_once_with(tenant_id, net_info)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def test_create_network_on_controller_fail(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_cc0ae478","line":51,"updated":"2014-07-23 12:21:05.000000000","message":"Eliminate all backslashes in file and use parens instead to continue lines.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a7d655a62afdc1c6f811150245ff35f011c7d684","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            .RemoteRestError(\"controller unreachable\")"},{"line_number":73,"context_line":"        self.assertRaises(ml2_exc.HuaweiDriverError,"},{"line_number":74,"context_line":"                          self.drv.create_network_postcommit,"},{"line_number":75,"context_line":"                          network_context)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_update_network_on_valid_info(self):"},{"line_number":78,"context_line":"        original_network \u003d {\"id\": \"net-1\","}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_e71b9e19","line":75,"updated":"2014-07-22 05:51:30.000000000","message":"I think, you may merge \u0027test_create_network_on_valid_config\u0027 and  \u0027test_create_network_on_controller_fail\u0027 into a single def. the same for all.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":8646,"name":"yangxurong","email":"yangxurong@huawei.com","username":"yangxurong"},"change_message_id":"3f34e8769050fdda4c6f6a195023cd39023a23d4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            .RemoteRestError(\"controller unreachable\")"},{"line_number":73,"context_line":"        self.assertRaises(ml2_exc.HuaweiDriverError,"},{"line_number":74,"context_line":"                          self.drv.create_network_postcommit,"},{"line_number":75,"context_line":"                          network_context)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def test_update_network_on_valid_info(self):"},{"line_number":78,"context_line":"        original_network \u003d {\"id\": \"net-1\","}],"source_content_type":"text/x-python","patch_set":5,"id":"baada198_9dbbbce3","line":75,"in_reply_to":"baada198_e71b9e19","updated":"2014-07-24 09:54:46.000000000","message":"These two methods are testing different cases, one successes and one fails with exception, so I think we should leave them as two different methods.","commit_id":"a35eb08730d44d63b2b58d1c8143c54a08a5192d"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"12ae704eed5ef1d7f5abecc14b64264fd182183b","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        self.segmentation_id \u003d 10001"},{"line_number":35,"context_line":"        self.vm_id \u003d \"vm-1\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def set_test_create_delete_network_common_value(self):"},{"line_number":38,"context_line":"        self.network_context \u003d self._get_network_context(self.tenant_id,"},{"line_number":39,"context_line":"                                                         self.network_id,"},{"line_number":40,"context_line":"                                                         self.segmentation_id)"}],"source_content_type":"text/x-python","patch_set":11,"id":"1abeadc6_7d9314fa","line":37,"updated":"2014-08-27 14:55:06.000000000","message":"nit: add leading _ for these set... methods","commit_id":"eb027339c9f16b680e13440afd6747524530a4d4"}]}
