)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"a2ff16221674de30ee3b716806472d5a9f5e9cdd","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-07-08 11:10:43 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Security groups extension for PLUMgrid plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint plumgrid-plugin-security-groups"},{"line_number":10,"context_line":"Change-Id: I23fea3fe6c3abbe310e883e00706b93863db3bfb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_f3cc208d","line":8,"updated":"2014-07-08 18:28:07.000000000","message":"You need to include a detailed explanation of the code in this patch:\nhttps://wiki.openstack.org/wiki/GerritWorkflow","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"6c24c06ebd18b47dfad2e757960e7b7e6ea6bb1a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2014-07-08 11:10:43 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Security groups extension for PLUMgrid plugin"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Implements: blueprint plumgrid-plugin-security-groups"},{"line_number":10,"context_line":"Change-Id: I23fea3fe6c3abbe310e883e00706b93863db3bfb"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"baada198_932f64f6","line":8,"in_reply_to":"baada198_f3cc208d","updated":"2014-07-08 18:38:24.000000000","message":"Thanks for pointing out. I will add this in the next patch.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"}],"neutron/plugins/plumgrid/__init__.py":[{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"76e095ace1ab682b9da99c6268491fa174ba2bff","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 PLUMgrid, Inc. All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_acaf692a","side":"PARENT","line":3,"updated":"2014-07-10 10:17:42.000000000","message":"I\u0027m a bit confused about this removing copy writing from __init__ files there. This does not mentioned in commit message. Add information about it or split it into a separate change as this have nothing in common with \u0027Security groups extension for PLUMgrid plugin\u0027. Also this is already done in this change https://review.openstack.org/99578.","commit_id":"4ce655ae22c671553726fda6a0828248359c69f2"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"62b25d654a3970b5371a9ea33def4a3dd1a73b3a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 PLUMgrid, Inc. All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b677a43a","side":"PARENT","line":3,"in_reply_to":"baada198_acaf692a","updated":"2014-07-10 16:44:59.000000000","message":"Please see comments on patchset1. pritesh pointed out in the patchset 1 about this so I had to clean up all the files affecting plugin. Similarly for the log.debug change as you may see that too.","commit_id":"4ce655ae22c671553726fda6a0828248359c69f2"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"80f10b76f29fe2cbc5974fef35dab1d6068a4669","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 PLUMgrid, Inc. All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d6f25899","side":"PARENT","line":3,"in_reply_to":"baada198_b677a43a","updated":"2014-07-10 16:47:10.000000000","message":"Since mark already has a changeset for this. it\u0027s safe to not handle them in this commit then.","commit_id":"4ce655ae22c671553726fda6a0828248359c69f2"},{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"9350feeff9b37a3c0e5f6a86f7d8652f9d58d31d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 PLUMgrid, Inc. All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d15502c7","side":"PARENT","line":3,"in_reply_to":"baada198_b677a43a","updated":"2014-07-10 17:29:37.000000000","message":"just to be clear, i pointed out the one added by this patch, not the others in plugin as they are already being taken care of by mark.","commit_id":"4ce655ae22c671553726fda6a0828248359c69f2"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"8f1a9a98ab408aaeda54881f72c99b9cd38b1c7d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 PLUMgrid, Inc. All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_266e0302","side":"PARENT","line":3,"in_reply_to":"baada198_d15502c7","updated":"2014-07-10 18:06:58.000000000","message":"Understood. Addressed comments from both of you now :)","commit_id":"4ce655ae22c671553726fda6a0828248359c69f2"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"eb6a5cfeb218f0ed842dcc60d7407e545b13925f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 PLUMgrid, Inc. All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"},{"line_number":6,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_967700d4","side":"PARENT","line":3,"in_reply_to":"baada198_d6f25899","updated":"2014-07-10 16:53:00.000000000","message":"Done","commit_id":"4ce655ae22c671553726fda6a0828248359c69f2"}],"neutron/plugins/plumgrid/drivers/fake_plumlib.py":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"2956d01ded5c87a97c40b0e3bcef194d5a7a642b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":16,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.extensions import providernet as provider"},{"line_number":19,"context_line":"from neutron.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_336bf886","line":16,"updated":"2014-07-08 18:26:26.000000000","message":"unnecessary, git takes care of this.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"3949bc14cc4909d4708f9bb3f63f094ed7ac6978","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":16,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.extensions import providernet as provider"},{"line_number":19,"context_line":"from neutron.openstack.common import log as logging"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_04ab0cd7","line":16,"in_reply_to":"baada198_336bf886","updated":"2014-07-08 19:51:05.000000000","message":"Done","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"}],"neutron/plugins/plumgrid/drivers/plumlib.py":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"2956d01ded5c87a97c40b0e3bcef194d5a7a642b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":16,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Neutron Plug-in for PLUMgrid Virtual Networking Infrastructure (VNI)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_330218b5","line":16,"updated":"2014-07-08 18:26:26.000000000","message":"same.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"3949bc14cc4909d4708f9bb3f63f094ed7ac6978","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":16,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Neutron Plug-in for PLUMgrid Virtual Networking Infrastructure (VNI)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_84863c64","line":16,"in_reply_to":"baada198_330218b5","updated":"2014-07-08 19:51:05.000000000","message":"Done","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"}],"neutron/plugins/plumgrid/plumgrid_plugin/plumgrid_plugin.py":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"2956d01ded5c87a97c40b0e3bcef194d5a7a642b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":16,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Neutron Plug-in for PLUMgrid Virtual Networking Infrastructure (VNI)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_933044a0","line":16,"updated":"2014-07-08 18:26:26.000000000","message":"same.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"3949bc14cc4909d4708f9bb3f63f094ed7ac6978","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":16,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Neutron Plug-in for PLUMgrid Virtual Networking Infrastructure (VNI)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_a47b407a","line":16,"in_reply_to":"baada198_933044a0","updated":"2014-07-08 19:51:05.000000000","message":"Done","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"a2ff16221674de30ee3b716806472d5a9f5e9cdd","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                              portbindings_db.PortBindingMixin,"},{"line_number":67,"context_line":"                              securitygroups_db.SecurityGroupDbMixin):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    supported_extension_aliases \u003d [\"binding\","},{"line_number":70,"context_line":"                                   \"external-net\","},{"line_number":71,"context_line":"                                   \"provider\","},{"line_number":72,"context_line":"                                   \"quotas\","}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_339e9864","line":69,"updated":"2014-07-08 18:28:07.000000000","message":"any reason why you don\u0027t add more extensions in one line?","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"6c24c06ebd18b47dfad2e757960e7b7e6ea6bb1a","unresolved":false,"context_lines":[{"line_number":66,"context_line":"                              portbindings_db.PortBindingMixin,"},{"line_number":67,"context_line":"                              securitygroups_db.SecurityGroupDbMixin):"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    supported_extension_aliases \u003d [\"binding\","},{"line_number":70,"context_line":"                                   \"external-net\","},{"line_number":71,"context_line":"                                   \"provider\","},{"line_number":72,"context_line":"                                   \"quotas\","}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_937da4ea","line":69,"in_reply_to":"baada198_339e9864","updated":"2014-07-08 18:38:24.000000000","message":"Only for better readability :)","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"2956d01ded5c87a97c40b0e3bcef194d5a7a642b","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"        Create a new security group, including the default security group"},{"line_number":602,"context_line":"        \"\"\""},{"line_number":603,"context_line":"        LOG.debug(_(\"Neutron PLUMgrid Director: create_security_group()\""},{"line_number":604,"context_line":"                    \" called\"))"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_73b9f0eb","line":603,"updated":"2014-07-08 18:26:26.000000000","message":"no i18n translation, check bug/1317851","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"6c24c06ebd18b47dfad2e757960e7b7e6ea6bb1a","unresolved":false,"context_lines":[{"line_number":600,"context_line":""},{"line_number":601,"context_line":"        Create a new security group, including the default security group"},{"line_number":602,"context_line":"        \"\"\""},{"line_number":603,"context_line":"        LOG.debug(_(\"Neutron PLUMgrid Director: create_security_group()\""},{"line_number":604,"context_line":"                    \" called\"))"},{"line_number":605,"context_line":""},{"line_number":606,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f3d980f5","line":603,"in_reply_to":"baada198_73b9f0eb","updated":"2014-07-08 18:38:24.000000000","message":"Thanks for pointing out. I wasn\u0027t aware of it. I will address this in the next patch.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"2956d01ded5c87a97c40b0e3bcef194d5a7a642b","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                          self).create_security_group(context, security_group,"},{"line_number":616,"context_line":"                                                      default_sg)"},{"line_number":617,"context_line":"            try:"},{"line_number":618,"context_line":"                LOG.debug(_(\"PLUMgrid Library: create_security_group()\""},{"line_number":619,"context_line":"                            \" called\"))"},{"line_number":620,"context_line":"                self._plumlib.create_security_group(sg_db)"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f3e5000b","line":618,"updated":"2014-07-08 18:26:26.000000000","message":"same and other places in file.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"3949bc14cc4909d4708f9bb3f63f094ed7ac6978","unresolved":false,"context_lines":[{"line_number":615,"context_line":"                          self).create_security_group(context, security_group,"},{"line_number":616,"context_line":"                                                      default_sg)"},{"line_number":617,"context_line":"            try:"},{"line_number":618,"context_line":"                LOG.debug(_(\"PLUMgrid Library: create_security_group()\""},{"line_number":619,"context_line":"                            \" called\"))"},{"line_number":620,"context_line":"                self._plumlib.create_security_group(sg_db)"},{"line_number":621,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_64e84817","line":618,"in_reply_to":"baada198_f3e5000b","updated":"2014-07-08 19:51:05.000000000","message":"Done","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0958b541897c1a836dc8b1d072b005be519914fa","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        super(NeutronPluginPLUMgridV2, self).__init__()"},{"line_number":78,"context_line":"        self.plumgrid_init()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        LOG.debug(\u0027Neutron PLUMgrid Director: Neutron server with \u0027"},{"line_number":81,"context_line":"                  \u0027PLUMgrid Plugin has started\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def plumgrid_init(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_dab424f4","line":80,"updated":"2014-07-11 06:33:06.000000000","message":"Would be better if you had broken up this commit into two with these changes in their own commit.","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"1c6ef446ae01a0e8362266f04f154839cb63d0d1","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        super(NeutronPluginPLUMgridV2, self).__init__()"},{"line_number":78,"context_line":"        self.plumgrid_init()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        LOG.debug(\u0027Neutron PLUMgrid Director: Neutron server with \u0027"},{"line_number":81,"context_line":"                  \u0027PLUMgrid Plugin has started\u0027)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def plumgrid_init(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_6480bebf","line":80,"in_reply_to":"baada198_dab424f4","updated":"2014-07-11 21:36:39.000000000","message":"Agree. I will keep that in mind from next time on. :)","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0958b541897c1a836dc8b1d072b005be519914fa","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            try:"},{"line_number":613,"context_line":"                LOG.debug(\"PLUMgrid Library: create_security_group()\""},{"line_number":614,"context_line":"                          \" called\")"},{"line_number":615,"context_line":"                self._plumlib.create_security_group(sg_db)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"            except Exception as err_message:"},{"line_number":618,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_da20a49d","line":615,"updated":"2014-07-11 06:33:06.000000000","message":"It\u0027s interesting that you don\u0027t need to store an id in the neutron database, is the plumgrid api structured so that the id can come from an external source or ??","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"1c6ef446ae01a0e8362266f04f154839cb63d0d1","unresolved":false,"context_lines":[{"line_number":612,"context_line":"            try:"},{"line_number":613,"context_line":"                LOG.debug(\"PLUMgrid Library: create_security_group()\""},{"line_number":614,"context_line":"                          \" called\")"},{"line_number":615,"context_line":"                self._plumlib.create_security_group(sg_db)"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"            except Exception as err_message:"},{"line_number":618,"context_line":"                raise plum_excep.PLUMgridException(err_msg\u003derr_message)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_64e51ea3","line":615,"in_reply_to":"baada198_da20a49d","updated":"2014-07-11 21:36:39.000000000","message":"Contents of sg_db are sufficient for backend and id is part of sg_db.","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0958b541897c1a836dc8b1d072b005be519914fa","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, sg_rules)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":700,"context_line":"            self._ensure_default_security_group(context, tenant_id)"},{"line_number":701,"context_line":"            sg_id \u003d self._validate_security_group_rules("},{"line_number":702,"context_line":"                context, security_group_rule)"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_da0fc4df","line":700,"updated":"2014-07-11 06:33:06.000000000","message":"I\u0027m honored that this code is cased of the nvp plugin code but while removing this I realized we don\u0027t need to make this call here see:   https://review.openstack.org/106284","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"1c6ef446ae01a0e8362266f04f154839cb63d0d1","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, sg_rules)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":700,"context_line":"            self._ensure_default_security_group(context, tenant_id)"},{"line_number":701,"context_line":"            sg_id \u003d self._validate_security_group_rules("},{"line_number":702,"context_line":"                context, security_group_rule)"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c4ffca32","line":700,"in_reply_to":"baada198_a4f8167d","updated":"2014-07-11 21:36:39.000000000","message":"Thanks for pointing out. I will take care of it in the next patch.","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"678b367df2cbb25f695c4785c18e924db3efa98f","unresolved":false,"context_lines":[{"line_number":697,"context_line":"        tenant_id \u003d self._get_tenant_id_for_create(context, sg_rules)"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":700,"context_line":"            self._ensure_default_security_group(context, tenant_id)"},{"line_number":701,"context_line":"            sg_id \u003d self._validate_security_group_rules("},{"line_number":702,"context_line":"                context, security_group_rule)"},{"line_number":703,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_a4f8167d","line":700,"in_reply_to":"baada198_da0fc4df","updated":"2014-07-11 21:23:37.000000000","message":"*based, *reviewing","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0958b541897c1a836dc8b1d072b005be519914fa","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        LOG.debug(\"Neutron PLUMgrid Director: delete_security_group_rule()\""},{"line_number":735,"context_line":"                  \" called\")"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        sgr \u003d (super(NeutronPluginPLUMgridV2,"},{"line_number":738,"context_line":"                     self).get_security_group_rule(context, sgr_id))"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        if not sgr:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_1a205c48","line":737,"updated":"2014-07-11 06:33:06.000000000","message":"nit: would be nice to be consistant with your naming here you use sgr but everywhere else: security_group","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"1c6ef446ae01a0e8362266f04f154839cb63d0d1","unresolved":false,"context_lines":[{"line_number":734,"context_line":"        LOG.debug(\"Neutron PLUMgrid Director: delete_security_group_rule()\""},{"line_number":735,"context_line":"                  \" called\")"},{"line_number":736,"context_line":""},{"line_number":737,"context_line":"        sgr \u003d (super(NeutronPluginPLUMgridV2,"},{"line_number":738,"context_line":"                     self).get_security_group_rule(context, sgr_id))"},{"line_number":739,"context_line":""},{"line_number":740,"context_line":"        if not sgr:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_c486eab8","line":737,"in_reply_to":"baada198_1a205c48","updated":"2014-07-11 21:36:39.000000000","message":"Oh I see your point. Actually it is consistent with the caller name. So sgr for get_security_group_rule and security_group for get_security_group. Please let me know if that\u0027s okay with you.","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"0958b541897c1a836dc8b1d072b005be519914fa","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        # no need to check for their validity"},{"line_number":808,"context_line":"        return pools"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"    def _validate_security_group_rules(self, context, rules):"},{"line_number":811,"context_line":"        return super(NeutronPluginPLUMgridV2,"},{"line_number":812,"context_line":"                     self)._validate_security_group_rules(context, rules)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_9ad38c37","line":810,"updated":"2014-07-11 06:33:06.000000000","message":"This can be removed.","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"8cc0e76e42cd48fd4cf8f1fb58ac8c81bcb61783","unresolved":false,"context_lines":[{"line_number":807,"context_line":"        # no need to check for their validity"},{"line_number":808,"context_line":"        return pools"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"    def _validate_security_group_rules(self, context, rules):"},{"line_number":811,"context_line":"        return super(NeutronPluginPLUMgridV2,"},{"line_number":812,"context_line":"                     self)._validate_security_group_rules(context, rules)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_47a1fcf6","line":810,"in_reply_to":"baada198_9ad38c37","updated":"2014-07-11 21:46:42.000000000","message":"Done","commit_id":"7e53cad40ddffe35926ba7a81dc50d597ea1cbe7"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"f24e2e0ee14e5910d22c8b56722796f3e1b87730","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                context, port_db, port_data[sec_grp.SECURITYGROUPS])"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            self._process_portbindings_create_and_update(context,"},{"line_number":209,"context_line":"                                                         port_data, port_db)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            device_id \u003d port_db[\"device_id\"]"},{"line_number":212,"context_line":"            if port_db[\"device_owner\"] \u003d\u003d constants.DEVICE_OWNER_ROUTER_GW:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_13564606","line":209,"updated":"2014-07-14 09:50:58.000000000","message":"is this port binding stuff related?","commit_id":"c4648bc1b320a191c9d913e6a4931285ee8d7a9a"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"e6943a3823952cec67309255bc555f72f0939519","unresolved":false,"context_lines":[{"line_number":206,"context_line":"                context, port_db, port_data[sec_grp.SECURITYGROUPS])"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            self._process_portbindings_create_and_update(context,"},{"line_number":209,"context_line":"                                                         port_data, port_db)"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"            device_id \u003d port_db[\"device_id\"]"},{"line_number":212,"context_line":"            if port_db[\"device_owner\"] \u003d\u003d constants.DEVICE_OWNER_ROUTER_GW:"}],"source_content_type":"text/x-python","patch_set":6,"id":"baada198_2b9823bf","line":209,"in_reply_to":"baada198_13564606","updated":"2014-07-14 17:06:48.000000000","message":"Yes. Binding host has value after introduction of security groups.","commit_id":"c4648bc1b320a191c9d913e6a4931285ee8d7a9a"}],"neutron/tests/unit/plumgrid/extensions/__init__.py":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"2956d01ded5c87a97c40b0e3bcef194d5a7a642b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_13919452","line":15,"updated":"2014-07-08 18:26:26.000000000","message":"check http://docs.openstack.org/developer/hacking/  H104, nothing in empty files.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"6c24c06ebd18b47dfad2e757960e7b7e6ea6bb1a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_53e14c99","line":15,"in_reply_to":"baada198_13919452","updated":"2014-07-08 18:38:24.000000000","message":"Will remove the contents and also all the other files for PLUMgrid plugin to address this as other inits still have contents. This is a very helpful review. Thanks.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"}],"neutron/tests/unit/plumgrid/test_plumgrid_plugin.py":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"2956d01ded5c87a97c40b0e3bcef194d5a7a642b","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":16,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Test cases for  Neutron PLUMgrid Plug-in"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_539b0c72","line":16,"updated":"2014-07-08 18:26:26.000000000","message":"same.","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"},{"author":{"_account_id":8279,"name":"Fawad Khaliq","email":"fawadkq@gmail.com","username":"fawadkhaliq"},"change_message_id":"3949bc14cc4909d4708f9bb3f63f094ed7ac6978","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# @author: Edgar Magana, emagana@plumgrid.com, PLUMgrid, Inc."},{"line_number":16,"context_line":"# @author: Fawad Khaliq, fawad@plumgrid.com, PLUMgrid, Inc."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":"Test cases for  Neutron PLUMgrid Plug-in"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_04922c9f","line":16,"in_reply_to":"baada198_539b0c72","updated":"2014-07-08 19:51:05.000000000","message":"Done","commit_id":"340c7073c806b9a115ac913b82229f131ca2669e"}]}
