)]}'
{"neutron/plugins/cisco/n1kv/n1kv_neutron_plugin.py":[{"author":{"_account_id":5892,"name":"pritesh","email":"pritesh@romana.io","username":"pritkoth"},"change_message_id":"714253e6979c5252f34ac8e102d56304a91b7005","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"            # the network_binding record is deleted via cascade from"},{"line_number":1051,"context_line":"            # the network record, so explicit removal is not necessary"},{"line_number":1052,"context_line":"        self._send_delete_network_request(context, network)"},{"line_number":1053,"context_line":"        LOG.debug(_(\"Deleted network: %s\"), id)"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def _delete_network_db(self, context, id):"},{"line_number":1056,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_58f17269","line":1053,"updated":"2014-07-15 21:00:25.000000000","message":"nit: if re spinning, then no debug translations, bug/1317851","commit_id":"d383075b44e0ce4f6c065c144aed692ad165acb2"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"dd2f091304f6782dcbad9b1245163f2e1ccf2c2b","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"            # the network_binding record is deleted via cascade from"},{"line_number":1051,"context_line":"            # the network record, so explicit removal is not necessary"},{"line_number":1052,"context_line":"        self._send_delete_network_request(context, network)"},{"line_number":1053,"context_line":"        LOG.debug(_(\"Deleted network: %s\"), id)"},{"line_number":1054,"context_line":""},{"line_number":1055,"context_line":"    def _delete_network_db(self, context, id):"},{"line_number":1056,"context_line":"        session \u003d context.session"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_f34ee7c1","line":1053,"in_reply_to":"baada198_58f17269","updated":"2014-07-15 21:15:15.000000000","message":"Done","commit_id":"d383075b44e0ce4f6c065c144aed692ad165acb2"}],"neutron/tests/unit/cisco/n1kv/test_n1kv_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1a0289a01a36e87d309337de976b0c8d09f2c681","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        db_session \u003d db.get_session()"},{"line_number":630,"context_line":"        profile_obj \u003d self._make_test_policy_profile(name\u003d\u0027test_profile\u0027)"},{"line_number":631,"context_line":"        with self.network() as network:"},{"line_number":632,"context_line":"            client_patch \u003d mock.patch(n1kv_client.__name__ + \".Client\","},{"line_number":633,"context_line":"                                      new\u003dfake_client."},{"line_number":634,"context_line":"                                      TestClientInvalidResponse)"},{"line_number":635,"context_line":"            client_patch.start()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_3e8e1428","line":632,"updated":"2014-07-17 14:27:45.000000000","message":"It seems like all the test use the same mock. Could you place this in setUp(), or does it need to be created/started at this point (doesn\u0027t seem to need to be).  Would remove a bunch of duplication, if possible.","commit_id":"114da799e703b9f4174a06eb865b2fbde7118c10"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"9762d1c5ddd47fe52f7db917c98c2971856ace60","unresolved":false,"context_lines":[{"line_number":629,"context_line":"        db_session \u003d db.get_session()"},{"line_number":630,"context_line":"        profile_obj \u003d self._make_test_policy_profile(name\u003d\u0027test_profile\u0027)"},{"line_number":631,"context_line":"        with self.network() as network:"},{"line_number":632,"context_line":"            client_patch \u003d mock.patch(n1kv_client.__name__ + \".Client\","},{"line_number":633,"context_line":"                                      new\u003dfake_client."},{"line_number":634,"context_line":"                                      TestClientInvalidResponse)"},{"line_number":635,"context_line":"            client_patch.start()"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_17bda7d7","line":632,"in_reply_to":"baada198_3e8e1428","updated":"2014-07-17 18:50:29.000000000","message":"This mock is used only in cases where we need to mock an Invalid Response from the VSM. So that we can test failure and rollback cases.","commit_id":"114da799e703b9f4174a06eb865b2fbde7118c10"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"112351f6c380d03c8710b941b7eac5ac363b55b0","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                              db_session,"},{"line_number":644,"context_line":"                              profile_obj.id,"},{"line_number":645,"context_line":"                              network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":646,"context_line":"            client_patch.stop()"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_create_next_port_rollback_vmnetwork_count(self):"},{"line_number":649,"context_line":"        \"\"\"Test whether VMNetwork count if port create fails on VSM.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_1a39753f","line":646,"updated":"2014-07-17 02:53:11.000000000","message":"is explicit stop necessary?","commit_id":"114da799e703b9f4174a06eb865b2fbde7118c10"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"f18430dae68eba511d65c5efd54cb363a19bf8fc","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                              db_session,"},{"line_number":644,"context_line":"                              profile_obj.id,"},{"line_number":645,"context_line":"                              network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":646,"context_line":"            client_patch.stop()"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_create_next_port_rollback_vmnetwork_count(self):"},{"line_number":649,"context_line":"        \"\"\"Test whether VMNetwork count if port create fails on VSM.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_d351110f","line":646,"in_reply_to":"baada198_17a4c7b7","updated":"2014-07-21 20:58:22.000000000","message":"Added a comment to explain explicit  stop requirement","commit_id":"114da799e703b9f4174a06eb865b2fbde7118c10"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"1a0289a01a36e87d309337de976b0c8d09f2c681","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                              db_session,"},{"line_number":644,"context_line":"                              profile_obj.id,"},{"line_number":645,"context_line":"                              network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":646,"context_line":"            client_patch.stop()"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_create_next_port_rollback_vmnetwork_count(self):"},{"line_number":649,"context_line":"        \"\"\"Test whether VMNetwork count if port create fails on VSM.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_9edf203a","line":646,"in_reply_to":"baada198_1a39753f","updated":"2014-07-17 14:27:45.000000000","message":"No, it can be removed from L625, 646, 668. The base test class will stop all mocks.","commit_id":"114da799e703b9f4174a06eb865b2fbde7118c10"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"9762d1c5ddd47fe52f7db917c98c2971856ace60","unresolved":false,"context_lines":[{"line_number":643,"context_line":"                              db_session,"},{"line_number":644,"context_line":"                              profile_obj.id,"},{"line_number":645,"context_line":"                              network[\u0027network\u0027][\u0027id\u0027])"},{"line_number":646,"context_line":"            client_patch.stop()"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"    def test_create_next_port_rollback_vmnetwork_count(self):"},{"line_number":649,"context_line":"        \"\"\"Test whether VMNetwork count if port create fails on VSM.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_17a4c7b7","line":646,"in_reply_to":"baada198_9edf203a","updated":"2014-07-17 18:50:29.000000000","message":"An explicit stop is necessary here since this mock will return invalid response from the controller. We dont want the network clean up to be failed by the controller.","commit_id":"114da799e703b9f4174a06eb865b2fbde7118c10"}]}