)]}'
{"neutron/api/v2/resource.py":[{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"166ca7a918eafb6cc243be5541d78d7b07b85cd3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        args.pop(\u0027controller\u0027, None)"},{"line_number":73,"context_line":"        fmt \u003d args.pop(\u0027format\u0027, None)"},{"line_number":74,"context_line":"        if fmt and fmt not in format_types:"},{"line_number":75,"context_line":"            raise webob.exc.HTTPNotFound(_(\"Format \u0027%s\u0027 not supported\") % fmt)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        action \u003d args.pop(\u0027action\u0027, None)"},{"line_number":78,"context_line":"        content_type \u003d format_types.get(fmt,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_76364fb6","line":75,"updated":"2014-09-08 11:54:29.000000000","message":"_LE ?","commit_id":"75f1dd8a53a6de97a18d42797517a7a242066fc0"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"b1cf5e9d60eaa77bf97fec109cac1e4eb3d2a5b2","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        args.pop(\u0027controller\u0027, None)"},{"line_number":73,"context_line":"        fmt \u003d args.pop(\u0027format\u0027, None)"},{"line_number":74,"context_line":"        if fmt and fmt not in format_types:"},{"line_number":75,"context_line":"            raise webob.exc.HTTPNotFound(_(\"Format \u0027%s\u0027 not supported\") % fmt)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        action \u003d args.pop(\u0027action\u0027, None)"},{"line_number":78,"context_line":"        content_type \u003d format_types.get(fmt,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_91e1fdd2","line":75,"in_reply_to":"fa98f980_76364fb6","updated":"2014-09-08 12:36:44.000000000","message":"no, _LE should be used only in LOG.exception/error calls[1]\n\n\n[1] http://docs.openstack.org/developer/oslo.i18n/guidelines.html#choosing-a-marker-function","commit_id":"75f1dd8a53a6de97a18d42797517a7a242066fc0"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"053642a588ec197b101b10629d4caf93bbd2c798","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        args.pop(\u0027controller\u0027, None)"},{"line_number":73,"context_line":"        fmt \u003d args.pop(\u0027format\u0027, None)"},{"line_number":74,"context_line":"        if fmt and fmt not in format_types:"},{"line_number":75,"context_line":"            raise webob.exc.HTTPNotFound(_(\"Format \u0027%s\u0027 not supported\") % fmt)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        action \u003d args.pop(\u0027action\u0027, None)"},{"line_number":78,"context_line":"        content_type \u003d format_types.get(fmt,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_314db1c5","line":75,"in_reply_to":"fa98f980_91e1fdd2","updated":"2014-09-08 12:43:23.000000000","message":"Oh yes, my bad - for some reason I remembered it wrong after reading mentioned doc some time ago.","commit_id":"75f1dd8a53a6de97a18d42797517a7a242066fc0"}],"neutron/tests/unit/test_l3_plugin.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7d565d69174194df7a73e8c940dabb0c3e5c8146","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"class L3NatExtensionTestCase(test_api_v2_extension.ExtensionTestCase):"},{"line_number":77,"context_line":"    fmt \u003d \u0027json\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    def setUp(self):"},{"line_number":80,"context_line":"        super(L3NatExtensionTestCase, self).setUp()"},{"line_number":81,"context_line":"        self._setUpExtension("}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0a3b123a","line":78,"updated":"2014-07-29 16:13:32.000000000","message":"You should add a test in test_api_v2_resource not in test_l3_plugin.","commit_id":"47aaed19622e55c34792a98f4078997c81a546f9"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"7d565d69174194df7a73e8c940dabb0c3e5c8146","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                            self.serialize(data),"},{"line_number":97,"context_line":"                            content_type\u003d\u0027application/%s\u0027 % self.fmt,"},{"line_number":98,"context_line":"                            expect_errors\u003dTrue)"},{"line_number":99,"context_line":"        self.assertEqual(res.status_int, exc.HTTPNotFound.code)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_router_create(self):"},{"line_number":102,"context_line":"        router_id \u003d _uuid()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_0acdd25e","line":99,"updated":"2014-07-29 16:13:32.000000000","message":"it should be:\n\n self.assertEqual(expected, observed)\n\nnot the opposite.","commit_id":"47aaed19622e55c34792a98f4078997c81a546f9"}]}
