)]}'
{"README":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"-------------------------------------------------------------------------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"To build debs: (Note: For now, requires rpmbuild and alien; Tested on Ubuntu)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"\tpython setup.py build deb"},{"line_number":44,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAACX%2F%2F6Vc%3D","line":41,"updated":"2011-10-26 21:37:20.000000000","message":"We no longer require those :) Just the standard debian packaging tools.","commit_id":"6bebd770212abef9ba2fc12af66be8fadd5f59f1"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"-------------------------------------------------------------------------------"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"To build debs: (Note: For now, requires rpmbuild and alien; Tested on Ubuntu)"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"\tpython setup.py build deb"},{"line_number":44,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":4,"id":"AAAACX%2F%2F6Js%3D","line":41,"in_reply_to":"AAAACX%2F%2F6Vc%3D","updated":"2011-10-27 17:56:50.000000000","message":"Good call; Removing this note.","commit_id":"6bebd770212abef9ba2fc12af66be8fadd5f59f1"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  bin/quantum-server      #Server"},{"line_number":60,"context_line":"  bin/quantum             #CLI"},{"line_number":61,"context_line":"  python run_tests.py     #Tests"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# -- Installing from the source code"},{"line_number":64,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5d4%3D","line":61,"updated":"2011-11-01 22:32:13.000000000","message":"This should be run_tests.sh as that also runs pep8","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"  bin/quantum-server      #Server"},{"line_number":60,"context_line":"  bin/quantum             #CLI"},{"line_number":61,"context_line":"  python run_tests.py     #Tests"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"# -- Installing from the source code"},{"line_number":64,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F4eg%3D","line":61,"in_reply_to":"AAAACX%2F%2F5d4%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"bin/quantum":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"import os"},{"line_number":3,"context_line":"import sys"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"wd \u003d os.getcwd()"},{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5eQ%3D","line":3,"updated":"2011-11-03 00:34:16.000000000","message":"probably want a license here, right?","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/usr/bin/env python"},{"line_number":2,"context_line":"import os"},{"line_number":3,"context_line":"import sys"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"wd \u003d os.getcwd()"},{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F4ec%3D","line":3,"in_reply_to":"AAAACX%2F%2F5eQ%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"wd \u003d os.getcwd()"},{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"},{"line_number":7,"context_line":"                \u0027plugins/cisco-plugin\u0027, \u0027plugins/openvswitch\u0027]:"},{"line_number":8,"context_line":"    sys.path.append(os.path.join(wd, project, \u0027lib\u0027))"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from quantum.cli import main as cli"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5eU%3D","line":7,"updated":"2011-11-03 00:34:16.000000000","message":"Can you add a comment about why it is necessary to put all of these elements in the path for the cli?  \n\nIf we keep the plugin directories in the path, could we just automatically list each sub-dir of plugins and add them automatically?  Otherwise, a drop-in plugin won\u0027t work anymore.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"wd \u003d os.getcwd()"},{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"},{"line_number":7,"context_line":"                \u0027plugins/cisco-plugin\u0027, \u0027plugins/openvswitch\u0027]:"},{"line_number":8,"context_line":"    sys.path.append(os.path.join(wd, project, \u0027lib\u0027))"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from quantum.cli import main as cli"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F4eM%3D","line":7,"in_reply_to":"AAAACX%2F%2F5eU%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":"wd \u003d os.getcwd()"},{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"},{"line_number":7,"context_line":"                \u0027plugins/cisco-plugin\u0027, \u0027plugins/openvswitch\u0027]:"},{"line_number":8,"context_line":"    sys.path.append(os.path.join(wd, project, \u0027lib\u0027))"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from quantum.cli import main as cli"},{"line_number":11,"context_line":"cli()"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5d0%3D","line":8,"updated":"2011-11-01 22:32:13.000000000","message":"These couple lines are duplicated in a lot of places.. if we add more modules we\u0027re going to have to modify all those places?  Would be nice to have this in a module so that we can just \"import module; append_module_dirs()\" or something.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":5,"context_line":"wd \u003d os.getcwd()"},{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"},{"line_number":7,"context_line":"                \u0027plugins/cisco-plugin\u0027, \u0027plugins/openvswitch\u0027]:"},{"line_number":8,"context_line":"    sys.path.append(os.path.join(wd, project, \u0027lib\u0027))"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from quantum.cli import main as cli"},{"line_number":11,"context_line":"cli()"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5Ps%3D","line":8,"in_reply_to":"AAAACX%2F%2F5d0%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"},{"line_number":7,"context_line":"                \u0027plugins/cisco-plugin\u0027, \u0027plugins/openvswitch\u0027]:"},{"line_number":8,"context_line":"    sys.path.append(os.path.join(wd, project, \u0027lib\u0027))"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from quantum.cli import main as cli"},{"line_number":11,"context_line":"cli()"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5eM%3D","line":9,"updated":"2011-11-03 00:34:16.000000000","message":"Is there a reason for not doing the \u0027possible_topdir\u0027 check anymore?  Seems like a good check, unless I am missing something.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"},{"line_number":7,"context_line":"                \u0027plugins/cisco-plugin\u0027, \u0027plugins/openvswitch\u0027]:"},{"line_number":8,"context_line":"    sys.path.append(os.path.join(wd, project, \u0027lib\u0027))"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from quantum.cli import main as cli"},{"line_number":11,"context_line":"cli()"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F4eU%3D","line":9,"in_reply_to":"AAAACX%2F%2F5eM%3D","updated":"2011-11-04 21:00:08.000000000","message":"I don\u0027t think it\u0027s necessary anymore, since the topdir is no longer the package root.  I can add one in if it\u0027s used somewhere now (or should be) and I\u0027m missing it.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"bin/quantum-server":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"wd \u003d os.getcwd()"},{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"},{"line_number":7,"context_line":"                \u0027plugins/cisco-plugin\u0027, \u0027plugins/openvswitch\u0027]:"},{"line_number":8,"context_line":"    sys.path.append(os.path.join(wd, project, \u0027lib\u0027))"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from quantum.server import main as server"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5eI%3D","line":7,"updated":"2011-11-03 00:34:16.000000000","message":"Same comments here as with bin/quantum.  License, possible_topdir, and supporting drop-in plugins.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":4,"context_line":""},{"line_number":5,"context_line":"wd \u003d os.getcwd()"},{"line_number":6,"context_line":"for project in [\u0027common\u0027, \u0027server\u0027, \u0027client\u0027, \u0027plugins/sample-plugin\u0027,"},{"line_number":7,"context_line":"                \u0027plugins/cisco-plugin\u0027, \u0027plugins/openvswitch\u0027]:"},{"line_number":8,"context_line":"    sys.path.append(os.path.join(wd, project, \u0027lib\u0027))"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"from quantum.server import main as server"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F4d4%3D","line":7,"in_reply_to":"AAAACX%2F%2F5eI%3D","updated":"2011-11-04 21:00:08.000000000","message":"Everything is fixed except the possible_topdir issue, which I can fix if we decide we need to.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"client/debian/changelog":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"quantum-client (0.1-1) unstable; urgency\u003dlow"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * source package automatically created by stdeb 0.6.0+git"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" -- unknown \u003cunknown@unknown\u003e  Fri, 30 Sep 2011 16:37:40 -0700"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F46U%3D","line":2,"updated":"2011-11-03 00:34:16.000000000","message":"is this supposed to be checked in? \n\nIf so, why is version 0.1-1? Or is that something else?\n\nI suspect if this stays in the source tree and acts as the official changelog for the debian packages, we should put something more useful here.  Perhaps we should have a platform-agnostic changelog that is used to generate this file?","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"quantum-client (0.1-1) unstable; urgency\u003dlow"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * source package automatically created by stdeb 0.6.0+git"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" -- unknown \u003cunknown@unknown\u003e  Fri, 30 Sep 2011 16:37:40 -0700"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F40g%3D","line":2,"in_reply_to":"AAAACX%2F%2F46U%3D","updated":"2011-11-03 04:33:58.000000000","message":"Yeah, it is supposed to be checked in.  That\u0027s a good idea -- we could generate one from something at the toplevel.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"client/debian/files":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"quantum-client_0.1-1_all.deb python optional"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F46I%3D","line":1,"updated":"2011-11-03 00:34:16.000000000","message":"same comment about version here.  I\u0027m guessing this is auto-generated from a version stored somewhere?","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"quantum-client_0.1-1_all.deb python optional"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F40U%3D","line":1,"in_reply_to":"AAAACX%2F%2F46I%3D","updated":"2011-11-03 04:33:58.000000000","message":"I think this file doesn\u0027t need to be checked in","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"client/debian/rules":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":3,"context_line":"# This file was automatically generated by stdeb 0.6.0+git at"},{"line_number":4,"context_line":"# Fri, 30 Sep 2011 16:37:40 -0700"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"%:"},{"line_number":7,"context_line":"\tdh $@ --with python2 --buildsystem\u003dpython_distutils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F46E%3D","line":6,"updated":"2011-11-03 00:34:16.000000000","message":"if this file is auto-generated by the build, seems like it shouldn\u0027t be checked in?","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":3,"context_line":"# This file was automatically generated by stdeb 0.6.0+git at"},{"line_number":4,"context_line":"# Fri, 30 Sep 2011 16:37:40 -0700"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"%:"},{"line_number":7,"context_line":"\tdh $@ --with python2 --buildsystem\u003dpython_distutils"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F40Y%3D","line":6,"in_reply_to":"AAAACX%2F%2F46E%3D","updated":"2011-11-03 04:33:58.000000000","message":"The file was auto-generated by a tool used to generate the whole debian directory -- this one needs to stay checked in (it\u0027s the makefile for the debian package) that calls dh to do magic.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"client/setup.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-client\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027Netstack\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F46A%3D","line":10,"updated":"2011-11-03 00:34:16.000000000","message":"ah, here is the version.  we should update this to be something like 2012.1-dev, which represents a development drop on the way to the essex 2012.1 release.  When we build packages for specific releases/milestones, I guess we\u0027ll have to tweak this.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-client\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027Netstack\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4ds%3D","line":10,"in_reply_to":"AAAACX%2F%2F46A%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-client\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027Netstack\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F40Q%3D","line":10,"in_reply_to":"AAAACX%2F%2F46A%3D","updated":"2011-11-03 04:33:58.000000000","message":"Yeah.. that\u0027s going to be a pain.  We\u0027re going to have to tweak the version in each of the setup.py files.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"common/README":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -- Welcome!"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  You have come across a cloud computing network fabric controller.  It has"},{"line_number":4,"context_line":"  identified itself as \"Quantum.\"  It aims to tame your (cloud) networking!"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5dw%3D","line":1,"updated":"2011-11-01 22:32:13.000000000","message":"We\u0027ve now got the README in two places.. I\u0027d suggest changing this one to have only quantum-common details and leave the top-level one as is.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -- Welcome!"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  You have come across a cloud computing network fabric controller.  It has"},{"line_number":4,"context_line":"  identified itself as \"Quantum.\"  It aims to tame your (cloud) networking!"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F458%3D","line":1,"in_reply_to":"AAAACX%2F%2F5dw%3D","updated":"2011-11-03 00:34:16.000000000","message":"+1","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# -- Welcome!"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  You have come across a cloud computing network fabric controller.  It has"},{"line_number":4,"context_line":"  identified itself as \"Quantum.\"  It aims to tame your (cloud) networking!"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F4dk%3D","line":1,"in_reply_to":"AAAACX%2F%2F5dw%3D","updated":"2011-11-04 21:00:08.000000000","message":"None of the other packages have specific READMEs.  Should I just remove this one, or add READMEs for client and server too?","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"common/debian/changelog":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"quantum-common (0.1-1) unstable; urgency\u003dlow"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * source package automatically created by stdeb 0.6.0+git"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" -- Brad Hall \u003cbrad@nicira.com\u003e  Fri, 30 Sep 2011 17:42:57 -0700"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F454%3D","line":3,"updated":"2011-11-03 00:34:16.000000000","message":"same comments apply here as with client/debian/*","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"common/debian/control":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Package: quantum-common"},{"line_number":9,"context_line":"Architecture: all"},{"line_number":10,"context_line":"Depends: ${misc:Depends}, ${python:Depends}"},{"line_number":11,"context_line":"Description: Common functionalities for Quantum"},{"line_number":12,"context_line":" Common functionalities for Quantum"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F5ds%3D","line":10,"updated":"2011-11-01 22:32:13.000000000","message":"I\u0027m not suggesting you do this for this review but we need to have the same dependencies here that we have in setup.py (but specified as debian/ubuntu packages).  Maintaining two of these lists is going to be a pain..","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"common/lib/quantum/common/serializer.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"from xml.dom import minidom"},{"line_number":2,"context_line":"import webob.exc"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"from quantum.common import utils"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F450%3D","line":2,"updated":"2011-11-03 00:34:16.000000000","message":"I\u0027m assuming the code here is unmodified from its previous version and am not reviewing.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":1,"context_line":"from xml.dom import minidom"},{"line_number":2,"context_line":"import webob.exc"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"from quantum.common import utils"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dg%3D","line":2,"in_reply_to":"AAAACX%2F%2F450%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"common/lib/quantum/common/utils.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011, Nicira Networks, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45w%3D","line":1,"updated":"2011-11-03 00:34:16.000000000","message":"again, assuming this is just copied code. Let me know if it is otherwise.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011, Nicira Networks, Inc."},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dc%3D","line":1,"in_reply_to":"AAAACX%2F%2F45w%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"common/setup.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    from setuptools import setup, find_packages"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-common\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://github.com/openstack/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6sc%3D","line":9,"updated":"2011-10-25 20:54:50.000000000","message":"Should we point this to the launchpad page?","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027Netstack\u0027"},{"line_number":14,"context_line":"AuthorEmail\u003d\u0027\u0027"},{"line_number":15,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":16,"context_line":"Summary\u003d\u0027Common functionalities for Quantum\u0027"},{"line_number":17,"context_line":"ShortDescription\u003dSummary"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6sY%3D","line":14,"updated":"2011-10-25 20:54:50.000000000","message":"Probably want to point this to the netstack mailing list","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    namespace_packages \u003d [\u0027quantum\u0027],"},{"line_number":62,"context_line":"    entry_points\u003d{"},{"line_number":63,"context_line":"        \u0027console_scripts\u0027 : ["},{"line_number":64,"context_line":"            \u0027quantum-tests \u003d quantum.run_tests:main\u0027"},{"line_number":65,"context_line":"        ]"},{"line_number":66,"context_line":"    },"},{"line_number":67,"context_line":")"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6sk%3D","line":64,"updated":"2011-10-25 20:54:50.000000000","message":"This seems like extra work -- making it so that the tests can be run from an installed package.  I see the tests as just something the developer runs out of the source tree, not something we ship with the package.  But, I guess if its already done we might as well leave it.","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-common\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027Netstack\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45o%3D","line":10,"updated":"2011-11-03 00:34:16.000000000","message":"same version comment before","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-common\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027Netstack\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dY%3D","line":10,"in_reply_to":"AAAACX%2F%2F45o%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0027nose\u0027,"},{"line_number":24,"context_line":"    \u0027Paste\u0027,"},{"line_number":25,"context_line":"    \u0027PasteDeploy\u0027,"},{"line_number":26,"context_line":"    \u0027pep8\u003e\u003d0.5.0\u0027,"},{"line_number":27,"context_line":"    \u0027python-gflags\u0027,"},{"line_number":28,"context_line":"    \u0027simplejson\u0027,"},{"line_number":29,"context_line":"    \u0027sqlalchemy\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45s%3D","line":26,"updated":"2011-11-03 00:34:16.000000000","message":"I think we should specify 0.6.1 here, since that is what our build server uses.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    \u0027nose\u0027,"},{"line_number":24,"context_line":"    \u0027Paste\u0027,"},{"line_number":25,"context_line":"    \u0027PasteDeploy\u0027,"},{"line_number":26,"context_line":"    \u0027pep8\u003e\u003d0.5.0\u0027,"},{"line_number":27,"context_line":"    \u0027python-gflags\u0027,"},{"line_number":28,"context_line":"    \u0027simplejson\u0027,"},{"line_number":29,"context_line":"    \u0027sqlalchemy\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dU%3D","line":26,"in_reply_to":"AAAACX%2F%2F45s%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"plugins/cisco-plugin/debian/changelog":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"quantum-cisco-plugin (0.1-1) unstable; urgency\u003dlow"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * source package automatically created by stdeb 0.6.0+git"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" -- unknown \u003cunknown@unknown\u003e  Fri, 30 Sep 2011 16:37:40 -0700"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F45k%3D","line":4,"updated":"2011-11-03 00:34:16.000000000","message":"same comments as other debian dirs","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"plugins/cisco-plugin/debian/control":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Source: quantum-cisco-plugin"},{"line_number":2,"context_line":"Maintainer: Brad Hall \u003cbrad@nicira.com\u003e"},{"line_number":3,"context_line":"Section: python"},{"line_number":4,"context_line":"Priority: optional"},{"line_number":5,"context_line":"Build-Depends: python-setuptools (\u003e\u003d 0.6b3), python (\u003e\u003d 2.6.6-3), debhelper (\u003e\u003d 7.4.3)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAACX%2F%2F6sU%3D","line":2,"updated":"2011-10-25 20:54:50.000000000","message":"Whoops.. we should change all these to netstack.  Sorry, I should\u0027ve done that before I sent the patch.","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"}],"plugins/cisco-plugin/debian/patches/debian-changes-0.1-1":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Description: Upstream changes introduced in version 0.1-1"},{"line_number":2,"context_line":" This patch has been created by dpkg-source during the package build."},{"line_number":3,"context_line":" Here\u0027s the last changelog entry, hopefully it gives details on why"},{"line_number":4,"context_line":" those changes were made:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAACX%2F%2F6sA%3D","line":1,"updated":"2011-10-25 20:54:50.000000000","message":"I didn\u0027t mean to sent the patches files along.. we should remove the patches directories -- we don\u0027t need them.","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"}],"plugins/cisco-plugin/setup.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"DataFiles \u003d ["},{"line_number":36,"context_line":"        (\u0027/etc/quantum/plugins/cisco\u0027,"},{"line_number":37,"context_line":"\t[\u0027etc/credentials.ini\u0027,\u0027etc/l2network_plugin.ini\u0027,\u0027etc/nexus.ini\u0027,"},{"line_number":38,"context_line":"    \u0027etc/ucs.ini\u0027, \u0027etc/plugins.ini\u0027, \u0027etc/db_conn.ini\u0027])"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6r8%3D","line":37,"updated":"2011-10-25 20:54:50.000000000","message":"oops.. tab here.  should be spaces","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"}],"plugins/openvswitch-plugin/lib/quantum/plugins/openvswitch/ovs_quantum_plugin.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":29,"context_line":"import quantum.db.api as db"},{"line_number":30,"context_line":"import ovs_db"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF_FILE \u003d \"/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG.basicConfig(level\u003dLOG.WARN)"},{"line_number":35,"context_line":"LOG.getLogger(\"ovs_quantum_plugin\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F5S8%3D","line":32,"updated":"2011-11-01 22:32:13.000000000","message":"This breaks find_config() below  .. it needs to just contain the filename.  find_config() can be changed to take a list of paths I guess.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":29,"context_line":"import quantum.db.api as db"},{"line_number":30,"context_line":"import ovs_db"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"CONF_FILE \u003d \"/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG.basicConfig(level\u003dLOG.WARN)"},{"line_number":35,"context_line":"LOG.getLogger(\"ovs_quantum_plugin\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4es%3D","line":32,"in_reply_to":"AAAACX%2F%2F5S8%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"plugins/openvswitch-plugin/setup.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"DataFiles \u003d ["},{"line_number":36,"context_line":"        (\u0027/etc/quantum/plugins/openvswitch\u0027,"},{"line_number":37,"context_line":"\t[\u0027etc/ovs_quantum_plugin.ini\u0027])"},{"line_number":38,"context_line":"]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"setup("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rw%3D","line":37,"updated":"2011-10-25 20:54:50.000000000","message":"tab here, should be spaces","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-openvswitch-plugin\u0027"},{"line_number":9,"context_line":"ProjecUrl\u003d\"\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45g%3D","line":10,"updated":"2011-11-03 00:34:16.000000000","message":"version again","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-openvswitch-plugin\u0027"},{"line_number":9,"context_line":"ProjecUrl\u003d\"\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dQ%3D","line":10,"in_reply_to":"AAAACX%2F%2F45g%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027\u0027"},{"line_number":14,"context_line":"AuthorEmail\u003d\u0027\u0027"},{"line_number":15,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":16,"context_line":"Summary\u003d\u0027OpenVSwitch plugin for Quantum\u0027"},{"line_number":17,"context_line":"ShortDescription\u003dSummary"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45c%3D","line":14,"updated":"2011-11-03 00:34:16.000000000","message":"Let\u0027s put Author\u003d\"Open vSwitch Team\"\nand AuthorEmail\u003d\"discuss.openvswitch.org\"","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027\u0027"},{"line_number":14,"context_line":"AuthorEmail\u003d\u0027\u0027"},{"line_number":15,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":16,"context_line":"Summary\u003d\u0027OpenVSwitch plugin for Quantum\u0027"},{"line_number":17,"context_line":"ShortDescription\u003dSummary"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dM%3D","line":14,"in_reply_to":"AAAACX%2F%2F45c%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done (using discuss@openvswitch.org)","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"plugins/sample-plugin/setup.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-sample-plugin\u0027"},{"line_number":9,"context_line":"ProjecUrl\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027Netstack\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45U%3D","line":10,"updated":"2011-11-03 00:34:16.000000000","message":"version","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum-sample-plugin\u0027"},{"line_number":9,"context_line":"ProjecUrl\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"# Change as required"},{"line_number":13,"context_line":"Author\u003d\u0027Netstack\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dI%3D","line":10,"in_reply_to":"AAAACX%2F%2F45U%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"quantum/setup.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    from setuptools import setup, find_packages"},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://github.com/openstack/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"Author\u003d\u0027Tyler Smith\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rs%3D","line":9,"updated":"2011-10-25 20:54:50.000000000","message":"should probably change to the launchpad page","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Url\u003d\"https://github.com/openstack/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"Author\u003d\u0027Tyler Smith\u0027"},{"line_number":13,"context_line":"AuthorEmail\u003d\u0027tylesmit@cisco.com\u0027"},{"line_number":14,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":15,"context_line":"Summary\u003d\u0027A virtual network manager\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6ro%3D","line":12,"updated":"2011-10-25 20:54:50.000000000","message":"netstack","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"Author\u003d\u0027Tyler Smith\u0027"},{"line_number":13,"context_line":"AuthorEmail\u003d\u0027tylesmit@cisco.com\u0027"},{"line_number":14,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":15,"context_line":"Summary\u003d\u0027A virtual network manager\u0027"},{"line_number":16,"context_line":"ShortDescription\u003dSummary"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rk%3D","line":13,"updated":"2011-10-25 20:54:50.000000000","message":"mailing list","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"Author\u003d\u0027Netstack\u0027"},{"line_number":13,"context_line":"AuthorEmail\u003d\u0027netstack@lists.launchpad.net\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45Y%3D","line":10,"updated":"2011-11-03 00:34:16.000000000","message":"version again","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Name\u003d\u0027quantum\u0027"},{"line_number":9,"context_line":"Url\u003d\"https://launchpad.net/quantum\""},{"line_number":10,"context_line":"Version\u003d\u00270.1\u0027"},{"line_number":11,"context_line":"License\u003d\u0027Apache License 2.0\u0027"},{"line_number":12,"context_line":"Author\u003d\u0027Netstack\u0027"},{"line_number":13,"context_line":"AuthorEmail\u003d\u0027netstack@lists.launchpad.net\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dA%3D","line":10,"in_reply_to":"AAAACX%2F%2F45Y%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":12,"context_line":"Author\u003d\u0027Netstack\u0027"},{"line_number":13,"context_line":"AuthorEmail\u003d\u0027netstack@lists.launchpad.net\u0027"},{"line_number":14,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":15,"context_line":"Summary\u003d\u0027A virtual network manager\u0027"},{"line_number":16,"context_line":"ShortDescription\u003dSummary"},{"line_number":17,"context_line":"Description\u003dSummary"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F5TA%3D","line":15,"updated":"2011-11-01 22:32:13.000000000","message":"I think we should take the summary from the original setup.py in the root of the tree.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Author\u003d\u0027Netstack\u0027"},{"line_number":13,"context_line":"AuthorEmail\u003d\u0027netstack@lists.launchpad.net\u0027"},{"line_number":14,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":15,"context_line":"Summary\u003d\u0027A virtual network manager\u0027"},{"line_number":16,"context_line":"ShortDescription\u003dSummary"},{"line_number":17,"context_line":"Description\u003dSummary"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4dE%3D","line":15,"in_reply_to":"AAAACX%2F%2F5TA%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"server/debian/changelog":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"quantum-server (0.1-1) unstable; urgency\u003dlow"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"  * source package automatically created by stdeb 0.6.0+git"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":" -- Brad Hall \u003cbrad@nicira.com\u003e  Fri, 30 Sep 2011 17:43:48 -0700"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"AAAACX%2F%2F45Q%3D","line":4,"updated":"2011-11-03 00:34:16.000000000","message":"same comments as other debian/* dir changes","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"server/lib/quantum/manager.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"from quantum.common import utils"},{"line_number":33,"context_line":"from quantum.common.config import find_config_file"},{"line_number":34,"context_line":"from quantum.common.exceptions import ClassNotFound"},{"line_number":35,"context_line":"from quantum_plugin_base import QuantumPluginBase"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"LOG \u003d logging.getLogger(\u0027quantum.manager\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rg%3D","line":34,"updated":"2011-10-25 20:54:50.000000000","message":"I don\u0027t see where this is used in this file","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":70,"context_line":"            plugin_klass \u003d utils.import_class(options[\u0027plugin_provider\u0027])"},{"line_number":71,"context_line":"        except ClassNotFound:"},{"line_number":72,"context_line":"            raise Exception(\"Plugin not found.  You can install the \" \\"},{"line_number":73,"context_line":"                            \"plugin with pip install quantum-sample-plugin\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if not issubclass(plugin_klass, QuantumPluginBase):"},{"line_number":76,"context_line":"            raise Exception(\"Configured Quantum plug-in \" \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45M%3D","line":73,"updated":"2011-11-03 00:34:16.000000000","message":"Given that most people will want to be using a plugin that actually does something, maybe say:\n\nPlugin not found.  You can install a plugin with: pip install \u003cplugin-name\u003e \n\nExample: pip install quantum-sample-plugin","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":70,"context_line":"            plugin_klass \u003d utils.import_class(options[\u0027plugin_provider\u0027])"},{"line_number":71,"context_line":"        except ClassNotFound:"},{"line_number":72,"context_line":"            raise Exception(\"Plugin not found.  You can install the \" \\"},{"line_number":73,"context_line":"                            \"plugin with pip install quantum-sample-plugin\")"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if not issubclass(plugin_klass, QuantumPluginBase):"},{"line_number":76,"context_line":"            raise Exception(\"Configured Quantum plug-in \" \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4c8%3D","line":73,"in_reply_to":"AAAACX%2F%2F45M%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"server/lib/quantum/tests/tests/unit/extensions/foxinsocks.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# Copyright 2011 OpenStack LLC."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F40I%3D","line":1,"updated":"2011-11-03 04:33:58.000000000","message":"General comment: this, and a few others ended up as being \"Added\" files .. which means we just lost their history.  We should\u0027ve used git mv to move them so that git retains their history.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"server/setup.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":37,"context_line":"config_path \u003d \u0027/etc/quantum/\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"relative_locations \u003d [\u0027--user\u0027, \u0027--virtualenv\u0027, \u0027--venv\u0027]"},{"line_number":40,"context_line":"if [x for x in relative_locations if x in relative_locations]:"},{"line_number":41,"context_line":"    config_path \u003d \u0027etc/quantum/\u0027"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"DataFiles \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rU%3D","line":40,"updated":"2011-10-25 20:54:50.000000000","message":"I don\u0027t understand what this is trying to do","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"DataFiles \u003d ["},{"line_number":44,"context_line":"        (config_path,"},{"line_number":45,"context_line":"\t[\u0027etc/quantum.conf\u0027,\u0027etc/quantum.conf.sample\u0027,"},{"line_number":46,"context_line":"\t\u0027etc/quantum.conf.test\u0027, \u0027etc/plugins.ini\u0027])"},{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rc%3D","line":45,"updated":"2011-10-25 20:54:50.000000000","message":"tabs here.. should be spaces","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":46,"context_line":"\t\u0027etc/quantum.conf.test\u0027, \u0027etc/plugins.ini\u0027])"},{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"                                                                              "},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"setup("},{"line_number":52,"context_line":"    name\u003dName,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rY%3D","line":49,"updated":"2011-10-25 20:54:50.000000000","message":"ack.. whitespace :)","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"Author\u003d\u0027Netstatck\u0027"},{"line_number":16,"context_line":"AuthorEmail\u003d\u0027netstack@lists.launchpad.net\u0027"},{"line_number":17,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":18,"context_line":"Summary\u003d\u0027Common functionalities for Quantum\u0027"},{"line_number":19,"context_line":"ShortDescription\u003dSummary"},{"line_number":20,"context_line":"Description\u003dSummary"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F46c%3D","line":18,"updated":"2011-11-02 23:19:13.000000000","message":"This should talk about the Quantum server instead","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Author\u003d\u0027Netstatck\u0027"},{"line_number":16,"context_line":"AuthorEmail\u003d\u0027netstack@lists.launchpad.net\u0027"},{"line_number":17,"context_line":"Maintainer\u003d\u0027\u0027"},{"line_number":18,"context_line":"Summary\u003d\u0027Common functionalities for Quantum\u0027"},{"line_number":19,"context_line":"ShortDescription\u003dSummary"},{"line_number":20,"context_line":"Description\u003dSummary"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4c4%3D","line":18,"in_reply_to":"AAAACX%2F%2F46c%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"    namespace_packages \u003d [\u0027quantum\u0027],"},{"line_number":67,"context_line":"    entry_points\u003d{"},{"line_number":68,"context_line":"        \u0027console_scripts\u0027 : ["},{"line_number":69,"context_line":"            \u0027quantum-server \u003d quantum.server:main\u0027"},{"line_number":70,"context_line":"        ]"},{"line_number":71,"context_line":"    },"},{"line_number":72,"context_line":")"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4z8%3D","line":69,"updated":"2011-11-03 04:35:01.000000000","message":"I\u0027m not sure how to make this do the right thing but it is putting quantum-server in /usr/bin.  quantum-server should be in /usr/sbin and quantum should be in /usr/bin.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"setup.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def build_packages(options, args\u003dNone):"},{"line_number":88,"context_line":"    \"\"\"Build RPM and/or deb packages\"\"\""},{"line_number":89,"context_line":"    # If we weren\u0027t given a package type, default to rpm"},{"line_number":90,"context_line":"    if not args:"},{"line_number":91,"context_line":"        print \"To build packages you must specifiy either \u0027rpm\u0027, \" \\"},{"line_number":92,"context_line":"              \"\u0027deb\u0027, or \u0027all\u0027\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F45E%3D","line":89,"updated":"2011-11-03 00:34:16.000000000","message":"doesn\u0027t look like we actually default to rpm.\n\nI actually think that is the right decision, but we should probably remove the comment.","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"},{"author":{"_account_id":1549,"name":"Tyler Smith","email":"tylesmit@cisco.com","username":"tylesmit"},"change_message_id":"63be6fe953d3f5de8d2514b28c016596882f5296","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"def build_packages(options, args\u003dNone):"},{"line_number":88,"context_line":"    \"\"\"Build RPM and/or deb packages\"\"\""},{"line_number":89,"context_line":"    # If we weren\u0027t given a package type, default to rpm"},{"line_number":90,"context_line":"    if not args:"},{"line_number":91,"context_line":"        print \"To build packages you must specifiy either \u0027rpm\u0027, \" \\"},{"line_number":92,"context_line":"              \"\u0027deb\u0027, or \u0027all\u0027\""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAACX%2F%2F4c0%3D","line":89,"in_reply_to":"AAAACX%2F%2F45E%3D","updated":"2011-11-04 21:00:08.000000000","message":"Done","commit_id":"e2e18e6c8f978878cdf20a17db245d745ceb8376"}],"tools/install_venv.py":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    print \u0027done.\u0027"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def create_virtualenv(venv\u003dVENV, no_pip\u003dFalse):"},{"line_number":74,"context_line":"    \"\"\"Creates the virtual environment and installs PIP only into the"},{"line_number":75,"context_line":"    virtual environment"},{"line_number":76,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rM%3D","line":73,"updated":"2011-10-25 20:54:50.000000000","message":"I\u0027d suggest changing this to \"install_pip\" to make it clearer","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"},{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    print \u0027done.\u0027"},{"line_number":83,"context_line":"    print \u0027Installing pip in virtualenv...\u0027,"},{"line_number":84,"context_line":"    if not no_pip and \\"},{"line_number":85,"context_line":"                run_command([\u0027tools/with_venv.sh\u0027, \u0027easy_install\u0027, \u0027pip\u0027]):"},{"line_number":86,"context_line":"        die(\"Failed to install pip.\")"},{"line_number":87,"context_line":"    print \u0027done.\u0027"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAACX%2F%2F6rQ%3D","line":85,"updated":"2011-10-25 20:54:50.000000000","message":"Don\u0027t you want \"if not no_pip and not run_command():\"?","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"}],"tools/pip-requires":[{"author":{"_account_id":233,"name":"Brad Hall","email":"brad@nicira.com","username":"bgh"},"change_message_id":"93841cc55d0d9db2ad1efa89aadf80743c3fb384","unresolved":false,"context_lines":[{"line_number":1,"context_line":"coverage"},{"line_number":2,"context_line":"eventlet\u003e\u003d0.9.12"},{"line_number":3,"context_line":"Routes\u003e\u003d1.12.3"},{"line_number":4,"context_line":"Cheetah\u003e\u003d2.0.1"},{"line_number":5,"context_line":"nose"},{"line_number":6,"context_line":"nosexcover"},{"line_number":7,"context_line":"Paste"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAACX%2F%2F6rE%3D","line":4,"updated":"2011-10-25 20:54:50.000000000","message":"Do we still need this?  Maybe an artifact of the merge but I thought we weren\u0027t using cheetah anymore.  (I could be wrong :))","commit_id":"f7f748efe7f60d91177fed98d62aeee4171937aa"}]}