)]}'
{"neutron/tests/functional/agent/linux/base.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"0def61ec892bbf4a8c86ed5ecf16bd997b9efc38","unresolved":false,"context_lines":[{"line_number":87,"context_line":"            self.ip_netns.delete(self.namespace)"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        self.addCleanup(destroy_namespace)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def check_ns_command(self, cmd, error_text, skip_msg):"},{"line_number":92,"context_line":"        try:"},{"line_number":93,"context_line":"            self.ip_netns.execute(cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6ba42da3","line":90,"updated":"2014-07-31 20:38:43.000000000","message":"Regarding self.ip_netns and this function: I see that you\u0027re using it when started radvd. This approach doesn\u0027t actually give you test isolation, because if you start a process in a namespace and delete the namespace, the process will still live on, unlike devices / iptable rules and the like which do get cleaned up when their namespace is deleted.","commit_id":"9604a6ff5124065474e068f8faef2b6d31f1db37"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        super(BaseNamespaceLinuxTestCase, self).setUp()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"        # Create the net namespace"},{"line_number":79,"context_line":"        self.namespace \u003d str(uuid.uuid4())"},{"line_number":80,"context_line":"        self.root_wrapper \u003d ip_lib.IPWrapper(self.root_helper, self.namespace)"},{"line_number":81,"context_line":"        self.ip_wrapper \u003d self.root_wrapper.ensure_namespace(self.namespace)"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_b96377dc","line":79,"updated":"2014-08-24 21:50:14.000000000","message":"I think this base class might be more reusable if the namespace addition were refactored into a method and called in setUp() and check_ns_command took a namespace object as a parameter so that it could be used against arbitrary namespaces rather than only one.","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"}],"neutron/tests/functional/agent/linux/test_radvd.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e31120da9ab1c20fdad5b58eacbeb7d9dd7e4410","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baada198_4920fc48","updated":"2014-07-28 07:51:14.000000000","message":"Hmm I think I\u0027d remember you on my team :)","commit_id":"9604a6ff5124065474e068f8faef2b6d31f1db37"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"f65c8f059eef657b18ac9a6bf2914fde9775bfd6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baada198_0cc52b3c","in_reply_to":"baada198_4920fc48","updated":"2014-07-28 11:47:18.000000000","message":"Heh, :) Oops. I think I copied something from Maru when I started this file and forgot to change this part.","commit_id":"9604a6ff5124065474e068f8faef2b6d31f1db37"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"0def61ec892bbf4a8c86ed5ecf16bd997b9efc38","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _check_test_requirements(self):"},{"line_number":52,"context_line":"        self.check_sudo_enabled()"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        # Check that radvd is installed"},{"line_number":55,"context_line":"        self.check_command([\u0027which\u0027, \u0027radvd\u0027],"},{"line_number":56,"context_line":"                           \u0027Exit code: 1\u0027, \u0027radvd is not installed\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_eb0e7de3","line":53,"updated":"2014-07-31 20:38:43.000000000","message":"Wouldn\u0027t it be better to add radvd as a devstack dependency? You could add it as a test only dependency. You could then remove this check, and the check_command function.","commit_id":"9604a6ff5124065474e068f8faef2b6d31f1db37"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"0def61ec892bbf4a8c86ed5ecf16bd997b9efc38","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        conf_str \u003d ra.default_fmt % \u0027lo\u0027"},{"line_number":61,"context_line":"        with open(conf_file, \u0027w\u0027) as text_file:"},{"line_number":62,"context_line":"            text_file.write(\u0027%s\u0027 % conf_str)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"        # Check that we can run radvd in our namespace"},{"line_number":65,"context_line":"        self.check_ns_command([\u0027radvd\u0027, \u0027--nodaemon\u0027, \u0027--configtest\u0027,"},{"line_number":66,"context_line":"                               \u0027--config\u003d%s\u0027 % conf_file],"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_abd64525","line":63,"updated":"2014-07-31 20:38:43.000000000","message":"Again, instead of silently skipping tests we should be failing the job and fixing the gate configuration.","commit_id":"9604a6ff5124065474e068f8faef2b6d31f1db37"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"0def61ec892bbf4a8c86ed5ecf16bd997b9efc38","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def test_radvd_start_stop_ipv4(self):"},{"line_number":108,"context_line":"        self._start_radvd(ip_version\u003d4)"},{"line_number":109,"context_line":"        self.assertFalse(self.radvd.active)"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    # TODO(HenryG): add some more advanced tests, like maybe enable some"},{"line_number":112,"context_line":"    # local interfaces in the namespace and use radvdump to check for RAs?"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6bbfcdca","line":110,"updated":"2014-07-31 20:38:43.000000000","message":"This is the first test I was looking for. This would be testing that radvd is started correctly, and that the configuration used is sane.","commit_id":"9604a6ff5124065474e068f8faef2b6d31f1db37"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_19738bb5","line":1,"updated":"2014-08-24 21:50:14.000000000","message":"As per Assaf\u0027s comment...","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":33,"context_line":"from neutron.tests.unit import test_l3_agent as test_l3"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"def _uuid():"},{"line_number":37,"context_line":"    return str(uuid.uuid4())"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_b90e1731","line":36,"updated":"2014-08-24 21:50:14.000000000","message":"This function would appear to duplicate neutron.openstack.common.uuidutils.generate_uuid()","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    return str(uuid.uuid4())"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"def _device(port_id):"},{"line_number":41,"context_line":"    return \"port-%s\" % port_id"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_563a32e8","line":40,"updated":"2014-08-24 21:50:14.000000000","message":"It seems strange to see a function for a one-liner that is used only once.","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def setUp(self):"},{"line_number":47,"context_line":"        super(BaseRadvdTest, self).setUp()"},{"line_number":48,"context_line":"        self._check_test_requirements()"},{"line_number":49,"context_line":"        self.ensure_rootwrap()"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def _check_test_requirements(self):"},{"line_number":52,"context_line":"        self.check_sudo_enabled()"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_364e9697","line":49,"updated":"2014-08-24 21:50:14.000000000","message":"As per my comment regarding the need for the ensure_rootwrap() method, I don\u0027t think this line is necessary.","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.radvd \u003d None"},{"line_number":77,"context_line":"        self.addCleanup(self._stop_radvd)"},{"line_number":78,"context_line":"        # Process manager for checking state"},{"line_number":79,"context_line":"        self.radvd \u003d external_process.ProcessManager(cfg.CONF,"},{"line_number":80,"context_line":"                                                     self.router_id,"},{"line_number":81,"context_line":"                                                     self.root_helper,"},{"line_number":82,"context_line":"                                                     self.namespace,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_d67f22aa","line":79,"updated":"2014-08-24 21:50:14.000000000","message":"I see that it is necessary given the current design to manually construct the ProcessManager instance to check the status of the radvd process, but I think that suggests that the design of the ra module is flawed.  What do you think about refactoring the ra module so that it can inspect it\u0027s own state rather than building that functionality here?","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"1b753950ef6fdb079aa50b03348f54ec46ee8638","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.radvd \u003d None"},{"line_number":77,"context_line":"        self.addCleanup(self._stop_radvd)"},{"line_number":78,"context_line":"        # Process manager for checking state"},{"line_number":79,"context_line":"        self.radvd \u003d external_process.ProcessManager(cfg.CONF,"},{"line_number":80,"context_line":"                                                     self.router_id,"},{"line_number":81,"context_line":"                                                     self.root_helper,"},{"line_number":82,"context_line":"                                                     self.namespace,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_4dbe1dd6","line":79,"in_reply_to":"1abeadc6_d67f22aa","updated":"2014-08-25 04:37:01.000000000","message":"I think refactoring is a good idea and I am willing to do it. I will get in touch with you to discuss the specifics.","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":96,"context_line":"        self._start_radvd(ip_version\u003d6)"},{"line_number":97,"context_line":"        self.assertTrue(self.radvd.active)"},{"line_number":98,"context_line":"        self._stop_radvd()"},{"line_number":99,"context_line":"        self.assertFalse(self.radvd.active)"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def test_radvd_start_stop_ipv6_slaac(self):"},{"line_number":102,"context_line":"        self._start_radvd(ip_version\u003d6, ra_mode\u003dconstants.IPV6_SLAAC)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_5956e307","line":99,"updated":"2014-08-24 21:50:14.000000000","message":"I think the logical place for this assertion and the one on line 105 is in _stop_radvd()","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        self._stop_radvd()"},{"line_number":105,"context_line":"        self.assertFalse(self.radvd.active)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_radvd_start_stop_ipv4(self):"},{"line_number":108,"context_line":"        self._start_radvd(ip_version\u003d4)"},{"line_number":109,"context_line":"        self.assertFalse(self.radvd.active)"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_b93c57c1","line":107,"updated":"2014-08-24 21:50:14.000000000","message":"I\u0027m not sure it makes sense to have to check this in a functional test.  I can see the point of validating that radvd can be started and stopped successfully, and in validating that the configuration achieves the desired outcome, but the logic of how to treat ports configured only for ipv4 would seem to be better suited to a unit test.","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"}],"neutron/tests/functional/base.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"e96ecafd39cf9b17049db05441bdfb9bfa1c5ad7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        if not self.sudo_enabled:"},{"line_number":57,"context_line":"            self.skipTest(\u0027testing with sudo is not enabled\u0027)"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def ensure_rootwrap(self):"},{"line_number":60,"context_line":"        \"\"\""},{"line_number":61,"context_line":"        This is for tests that require a nested invocation that has"},{"line_number":62,"context_line":"        to be emulated by double sudo if rootwrap is not configured."}],"source_content_type":"text/x-python","patch_set":2,"id":"1abeadc6_b68466b2","line":59,"updated":"2014-08-24 21:50:14.000000000","message":"I\u0027m not sure I see the need for this check for management of an radvd process.  neutron.agent.linux.ra uses neutron.agent.linux.external_process.ProcessManager, which manages the spawned pid explicitly in a file.  Only processes spawned with neutron.agent.linux.async_process, which determines the spawned pid by inspection, need to worry about the invocation chain.","commit_id":"cb8511f3e4137b7a2d82928991b141b97f524df0"}]}
