)]}'
{"neutron/plugins/cisco/db/n1kv_db_v2.py":[{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a4c9ea6b8b66c452da181c903c8393974ce6d769","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    # Sort the range to ensure min, max is in order"},{"line_number":329,"context_line":"    seg_min, seg_max \u003d sorted("},{"line_number":330,"context_line":"        int(i) for i in network_profile.segment_range.split(\u0027-\u0027))"},{"line_number":331,"context_line":"    LOG.debug(_(\"seg_min %(seg_min)s, seg_max %(seg_max)s\"),"},{"line_number":332,"context_line":"              {\u0027seg_min\u0027: seg_min, \u0027seg_max\u0027: seg_max})"},{"line_number":333,"context_line":"    return seg_min, seg_max"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_50afdedf","line":331,"updated":"2014-08-11 05:54:51.000000000","message":"Here too, _() is not required for LOG.debug now.","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"af4eeddb04b8f2ac1d07f304e7913d796a100d11","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    # Sort the range to ensure min, max is in order"},{"line_number":329,"context_line":"    seg_min, seg_max \u003d sorted("},{"line_number":330,"context_line":"        int(i) for i in network_profile.segment_range.split(\u0027-\u0027))"},{"line_number":331,"context_line":"    LOG.debug(_(\"seg_min %(seg_min)s, seg_max %(seg_max)s\"),"},{"line_number":332,"context_line":"              {\u0027seg_min\u0027: seg_min, \u0027seg_max\u0027: seg_max})"},{"line_number":333,"context_line":"    return seg_min, seg_max"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_90d5f61c","line":331,"in_reply_to":"baada198_10456614","updated":"2014-08-11 05:59:43.000000000","message":"okay","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"7ff1fcaca71594814da2e1bf230c974516fcd974","unresolved":false,"context_lines":[{"line_number":328,"context_line":"    # Sort the range to ensure min, max is in order"},{"line_number":329,"context_line":"    seg_min, seg_max \u003d sorted("},{"line_number":330,"context_line":"        int(i) for i in network_profile.segment_range.split(\u0027-\u0027))"},{"line_number":331,"context_line":"    LOG.debug(_(\"seg_min %(seg_min)s, seg_max %(seg_max)s\"),"},{"line_number":332,"context_line":"              {\u0027seg_min\u0027: seg_min, \u0027seg_max\u0027: seg_max})"},{"line_number":333,"context_line":"    return seg_min, seg_max"},{"line_number":334,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_10456614","line":331,"in_reply_to":"baada198_50afdedf","updated":"2014-08-11 05:58:09.000000000","message":"It is proposed for the stable branch, so the comment is not valid. We don\u0027t change the released code.","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a4c9ea6b8b66c452da181c903c8393974ce6d769","unresolved":false,"context_lines":[{"line_number":558,"context_line":"                    raise n_exc.VlanIdInUse(vlan_id\u003dvlan_id,"},{"line_number":559,"context_line":"                                            physical_network\u003dphysical_network)"},{"line_number":560,"context_line":"            LOG.debug(_(\"Reserving specific vlan %(vlan)s on physical \""},{"line_number":561,"context_line":"                        \"network %(network)s from pool\"),"},{"line_number":562,"context_line":"                      {\"vlan\": vlan_id, \"network\": physical_network})"},{"line_number":563,"context_line":"            alloc.allocated \u003d True"},{"line_number":564,"context_line":"            db_session.add(alloc)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_f092b29e","line":561,"updated":"2014-08-11 05:54:51.000000000","message":"Here too. For all the LOG.debug messages.","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a4c9ea6b8b66c452da181c903c8393974ce6d769","unresolved":false,"context_lines":[{"line_number":583,"context_line":"            alloc.allocated \u003d False"},{"line_number":584,"context_line":"        except exc.NoResultFound:"},{"line_number":585,"context_line":"            LOG.warning(_(\"vlan_id %(vlan)s on physical network %(network)s \""},{"line_number":586,"context_line":"                          \"not found\"),"},{"line_number":587,"context_line":"                        {\"vlan\": vlan_id, \"network\": physical_network})"},{"line_number":588,"context_line":""},{"line_number":589,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_90d25659","line":586,"updated":"2014-08-11 05:54:51.000000000","message":"Use LOG.warn(_LW(),) here. \n\nFor _LW , use \u003d\u003e from neutron.openstack.common.gettextutils import _LW","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a4c9ea6b8b66c452da181c903c8393974ce6d769","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                     filter_by(vxlan_id\u003dvxlan_id)."},{"line_number":659,"context_line":"                     one())"},{"line_number":660,"context_line":"            alloc.allocated \u003d False"},{"line_number":661,"context_line":"        except exc.NoResultFound:"},{"line_number":662,"context_line":"            LOG.warning(_(\"vxlan_id %s not found\"), vxlan_id)"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_b0c3da8a","line":661,"updated":"2014-08-11 05:54:51.000000000","message":"Here too and all LOGging.","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"}],"neutron/plugins/cisco/n1kv/n1kv_neutron_plugin.py":[{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"claudiu.belu@canonical.com","username":"claudiub"},"change_message_id":"e659b6be5406cfa2ddf8f5413e713e3f11e0e3d9","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                msg \u003d _(\"Cannot delete network \u0027%s\u0027 that is a member of a \""},{"line_number":1051,"context_line":"                        \"multi-segment network\") % network[\u0027name\u0027]"},{"line_number":1052,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":1053,"context_line":"            self._delete_network_db(context, id)"},{"line_number":1054,"context_line":"            # the network_binding record is deleted via cascade from"},{"line_number":1055,"context_line":"            # the network record, so explicit removal is not necessary"},{"line_number":1056,"context_line":"        self._send_delete_network_request(context, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_1c3e95b9","line":1053,"updated":"2014-08-08 10:31:30.000000000","message":"why the difference between the master patch and icehouse patch? Here is self._delete_network_db and on master it is _delete_port_db.","commit_id":"a79f61e4e213208b16b118b679e8cb0bb833833e"},{"author":{"_account_id":10114,"name":"Sitaram Dontu","email":"sdontu@hotmail.com","username":"dontu"},"change_message_id":"a90928458bc4b1d13a5bd1fc7dd27d1cb0feeb64","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                msg \u003d _(\"Cannot delete network \u0027%s\u0027 that is a member of a \""},{"line_number":1051,"context_line":"                        \"multi-segment network\") % network[\u0027name\u0027]"},{"line_number":1052,"context_line":"                raise n_exc.InvalidInput(error_message\u003dmsg)"},{"line_number":1053,"context_line":"            self._delete_network_db(context, id)"},{"line_number":1054,"context_line":"            # the network_binding record is deleted via cascade from"},{"line_number":1055,"context_line":"            # the network record, so explicit removal is not necessary"},{"line_number":1056,"context_line":"        self._send_delete_network_request(context, network)"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_e5fe7638","line":1053,"in_reply_to":"baada198_1c3e95b9","updated":"2014-08-11 05:35:12.000000000","message":"I see the same calls on both master and here..  i.e. self._delete_network_db. Pls correct me if I missing it..","commit_id":"a79f61e4e213208b16b118b679e8cb0bb833833e"},{"author":{"_account_id":8645,"name":"Trinath Somanchi","email":"trinath.somanchi@freescale.com","username":"trinaths"},"change_message_id":"a4c9ea6b8b66c452da181c903c8393974ce6d769","unresolved":false,"context_lines":[{"line_number":1330,"context_line":"        :param context: neutron api request context"},{"line_number":1331,"context_line":"        :param id: UUID representing subnet to delete"},{"line_number":1332,"context_line":"        :returns: deleted subnet object"},{"line_number":1333,"context_line":"        \"\"\""},{"line_number":1334,"context_line":"        LOG.debug(_(\u0027Delete subnet: %s\u0027), id)"},{"line_number":1335,"context_line":"        subnet \u003d self.get_subnet(context, id)"},{"line_number":1336,"context_line":"        self._send_delete_subnet_request(context, subnet)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_30442a47","line":1333,"updated":"2014-08-11 05:54:51.000000000","message":"Now, debug messages don\u0027t need a  _( just LOG.debug(\u0027   \u0027). Change for all the debug messages in the file","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"}],"neutron/tests/unit/cisco/n1kv/test_n1kv_plugin.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3692ade9210004fb8e4f975edc1a8073fac6b07f","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        self.new_create_request(\u0027network_profiles\u0027, net_p_dict)"},{"line_number":565,"context_line":"        bindings \u003d (db_session.query(n1kv_models_v2.ProfileBinding).filter_by("},{"line_number":566,"context_line":"                    profile_type\u003d\"network\"))"},{"line_number":567,"context_line":"        self.assertEqual(bindings.count(), 0)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"class TestN1kvBasicGet(test_plugin.TestBasicGet,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_1994a734","line":567,"updated":"2014-08-11 12:39:49.000000000","message":"nit: put expected value first.","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"},{"author":{"_account_id":10114,"name":"Sitaram Dontu","email":"sdontu@hotmail.com","username":"dontu"},"change_message_id":"ef471e802bcd58c422588dcd889abce39a32907b","unresolved":false,"context_lines":[{"line_number":564,"context_line":"        self.new_create_request(\u0027network_profiles\u0027, net_p_dict)"},{"line_number":565,"context_line":"        bindings \u003d (db_session.query(n1kv_models_v2.ProfileBinding).filter_by("},{"line_number":566,"context_line":"                    profile_type\u003d\"network\"))"},{"line_number":567,"context_line":"        self.assertEqual(bindings.count(), 0)"},{"line_number":568,"context_line":""},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"class TestN1kvBasicGet(test_plugin.TestBasicGet,"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_29e668af","line":567,"in_reply_to":"baada198_1994a734","updated":"2014-08-11 22:10:30.000000000","message":"Paul - looks like I am not allowed to make changes in a cherry-pick to stable branch..","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"3692ade9210004fb8e4f975edc1a8073fac6b07f","unresolved":false,"context_lines":[{"line_number":646,"context_line":"            port_req \u003d self.new_create_request(\u0027ports\u0027, data)"},{"line_number":647,"context_line":"            res \u003d port_req.get_response(self.api)"},{"line_number":648,"context_line":"            self.assertEqual(res.status_int, 500)"},{"line_number":649,"context_line":"            client_patch.stop()"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def test_create_first_port_rollback_vmnetwork(self):"},{"line_number":652,"context_line":"        \"\"\"Test whether VMNetwork is cleaned up if port create fails on VSM.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_79ca0347","line":649,"updated":"2014-08-11 12:39:49.000000000","message":"Really should put self.addCleanup(client_patch.stop) on L 643, so that an assert failure will not prevent patch from stopping (lternative is to start the patch in setup and I\u0027ll get stopped automatically.\n\nHere and in several other UTs.","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"},{"author":{"_account_id":7018,"name":"Abhishek Raut","email":"rauta@vmware.com","username":"abhiraut"},"change_message_id":"c5916d23f932d3fd09f38e6757f2544c2d62d7c1","unresolved":false,"context_lines":[{"line_number":646,"context_line":"            port_req \u003d self.new_create_request(\u0027ports\u0027, data)"},{"line_number":647,"context_line":"            res \u003d port_req.get_response(self.api)"},{"line_number":648,"context_line":"            self.assertEqual(res.status_int, 500)"},{"line_number":649,"context_line":"            client_patch.stop()"},{"line_number":650,"context_line":""},{"line_number":651,"context_line":"    def test_create_first_port_rollback_vmnetwork(self):"},{"line_number":652,"context_line":"        \"\"\"Test whether VMNetwork is cleaned up if port create fails on VSM.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_cb3887a1","line":649,"in_reply_to":"baada198_79ca0347","updated":"2014-08-11 19:01:24.000000000","message":"Maybe we need to do this in the master branch. But since this is proposed for a stable branch, we should ideally not be modifying the patch.","commit_id":"a872143bb0585b6bef13eebbe9ab4c23d48ecfa1"}]}