)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Implements agent for Quantum Networking testing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This agent client plug it self for the each network."},{"line_number":10,"context_line":"Then try to ping each fixed_ips."},{"line_number":11,"context_line":"Implements blueprint test-agent"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"AAAALH%2F%2Fil4%3D","line":9,"updated":"2012-09-02 11:28:34.000000000","message":"\"plug it self for the each\" \u003d\u003e \"plugs itself into each\"","commit_id":"0ee00e48a7977ece8091735511143e60cd0f76b1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":7,"context_line":"Implements agent for Quantum Networking testing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This agent client plug it self for the each network."},{"line_number":10,"context_line":"Then try to ping each fixed_ips."},{"line_number":11,"context_line":"Implements blueprint test-agent"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3908e37401272e9e091ceae66e72cfcdd13b7898"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":23,"id":"AAAALH%2F%2Fil0%3D","line":10,"updated":"2012-09-02 11:28:34.000000000","message":"try \u003d\u003e tries","commit_id":"0ee00e48a7977ece8091735511143e60cd0f76b1"}],"quantum/agent/test-agent.py":[{"author":{"_account_id":1731,"name":"Yusuke Muraoka","email":"yusuke@nttmcl.com","username":"yusuke"},"change_message_id":"e008307ada9e51dd720a51afd489ac95f4290d9d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"LOG.setLevel(logging.WARN)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def env(key, default\u003dNone):"},{"line_number":42,"context_line":"    return os.environ.get(key, default)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fyns%3D","line":41,"updated":"2012-08-12 02:58:16.000000000","message":"dangling code.","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":38,"context_line":"LOG.setLevel(logging.WARN)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def env(key, default\u003dNone):"},{"line_number":42,"context_line":"    return os.environ.get(key, default)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FykQ%3D","line":41,"in_reply_to":"AAAALH%2F%2Fyns%3D","updated":"2012-08-12 05:27:39.000000000","message":"Done","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":1731,"name":"Yusuke Muraoka","email":"yusuke@nttmcl.com","username":"yusuke"},"change_message_id":"e008307ada9e51dd720a51afd489ac95f4290d9d","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        LOG.info(\"Ping OK to %s in %s\" % (ip_address, network_id))"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_connection(self, network):"},{"line_number":93,"context_line":"        port \u003d self._create_port(network)"},{"line_number":94,"context_line":"        self.setup(network, port)"},{"line_number":95,"context_line":"        quantum_client \u003d self.get_quantum_client()"},{"line_number":96,"context_line":"        ports \u003d quantum_client.list_ports(network_id\u003dnetwork.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FyoU%3D","line":93,"updated":"2012-08-12 02:58:16.000000000","message":"Need comment why creating port here.","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        LOG.info(\"Ping OK to %s in %s\" % (ip_address, network_id))"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_connection(self, network):"},{"line_number":93,"context_line":"        port \u003d self._create_port(network)"},{"line_number":94,"context_line":"        self.setup(network, port)"},{"line_number":95,"context_line":"        quantum_client \u003d self.get_quantum_client()"},{"line_number":96,"context_line":"        ports \u003d quantum_client.list_ports(network_id\u003dnetwork.id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FykM%3D","line":93,"in_reply_to":"AAAALH%2F%2FyoU%3D","updated":"2012-08-12 05:27:39.000000000","message":"Done","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":1731,"name":"Yusuke Muraoka","email":"yusuke@nttmcl.com","username":"yusuke"},"change_message_id":"e008307ada9e51dd720a51afd489ac95f4290d9d","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            for fixed_ips in port_dict[\u0027fixed_ips\u0027]:"},{"line_number":99,"context_line":"                ip_address \u003d fixed_ips[\u0027ip_address\u0027]"},{"line_number":100,"context_line":"                self.ping(network.id, ip_address)"},{"line_number":101,"context_line":"        self.destroy(port)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_connection_all_network(self):"},{"line_number":104,"context_line":"        for network_in_db in self.db.networks.all():"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fynw%3D","line":101,"updated":"2012-08-12 02:58:16.000000000","message":"Releasing the resource \"port\" must be executed after pinging.\nUse try - except statement.","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            for fixed_ips in port_dict[\u0027fixed_ips\u0027]:"},{"line_number":99,"context_line":"                ip_address \u003d fixed_ips[\u0027ip_address\u0027]"},{"line_number":100,"context_line":"                self.ping(network.id, ip_address)"},{"line_number":101,"context_line":"        self.destroy(port)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def test_connection_all_network(self):"},{"line_number":104,"context_line":"        for network_in_db in self.db.networks.all():"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fyjk%3D","line":101,"in_reply_to":"AAAALH%2F%2Fynw%3D","updated":"2012-08-12 05:27:39.000000000","message":"Done","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":1731,"name":"Yusuke Muraoka","email":"yusuke@nttmcl.com","username":"yusuke"},"change_message_id":"e008307ada9e51dd720a51afd489ac95f4290d9d","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def __init__(self, conf):"},{"line_number":112,"context_line":"        self.conf \u003d conf"},{"line_number":113,"context_line":"        self.fault \u003d False"},{"line_number":114,"context_line":"        self.db \u003d sqlsoup.SqlSoup(self.conf.db_connection)"},{"line_number":115,"context_line":"        LOG.info(\"Connecting to database \\\"%s\\\" on %s\" %"},{"line_number":116,"context_line":"                 (self.db.engine.url.database,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fyn0%3D","line":113,"updated":"2012-08-12 02:58:16.000000000","message":"Nobody update the fault. So everytime success.","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def __init__(self, conf):"},{"line_number":112,"context_line":"        self.conf \u003d conf"},{"line_number":113,"context_line":"        self.fault \u003d False"},{"line_number":114,"context_line":"        self.db \u003d sqlsoup.SqlSoup(self.conf.db_connection)"},{"line_number":115,"context_line":"        LOG.info(\"Connecting to database \\\"%s\\\" on %s\" %"},{"line_number":116,"context_line":"                 (self.db.engine.url.database,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FykE%3D","line":113,"in_reply_to":"AAAALH%2F%2Fyn0%3D","updated":"2012-08-12 05:27:39.000000000","message":"Done","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":1731,"name":"Yusuke Muraoka","email":"yusuke@nttmcl.com","username":"yusuke"},"change_message_id":"e008307ada9e51dd720a51afd489ac95f4290d9d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            tenant_id\u003dnetwork.tenant_id,"},{"line_number":143,"context_line":"            fixed_ips\u003d[dict(subnet_id\u003ds.id) for s in network.subnets]))"},{"line_number":144,"context_line":"        port_dict \u003d quantum.create_port(body)[\u0027port\u0027]"},{"line_number":145,"context_line":"        self.db.commit()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        port \u003d AugmentingWrapper("},{"line_number":148,"context_line":"            self.db.ports.filter_by(id\u003dport_dict[\u0027id\u0027]).one(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fyoc%3D","line":145,"updated":"2012-08-12 02:58:16.000000000","message":"Commit without comment here seem like normal commit.\nBut I see you\u0027d reset in-memory db cache to refresh ports.\n\nPlease comment or use appropriate method.\n\nAnyway, why you directly access to the quantum db?\nPublic API is enough for this situation.","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            tenant_id\u003dnetwork.tenant_id,"},{"line_number":143,"context_line":"            fixed_ips\u003d[dict(subnet_id\u003ds.id) for s in network.subnets]))"},{"line_number":144,"context_line":"        port_dict \u003d quantum.create_port(body)[\u0027port\u0027]"},{"line_number":145,"context_line":"        self.db.commit()"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        port \u003d AugmentingWrapper("},{"line_number":148,"context_line":"            self.db.ports.filter_by(id\u003dport_dict[\u0027id\u0027]).one(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fyi8%3D","line":145,"in_reply_to":"AAAALH%2F%2Fyoc%3D","updated":"2012-08-12 05:27:39.000000000","message":"This is needed because I\u0027m using DHCP-agent code who use DB. But DHCP-agent will be updated to RPC. So after that I will fix this issue.","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":1731,"name":"Yusuke Muraoka","email":"yusuke@nttmcl.com","username":"yusuke"},"change_message_id":"e008307ada9e51dd720a51afd489ac95f4290d9d","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    test_agent.test_connection_all_network()"},{"line_number":223,"context_line":"    if not test_agent.is_success():"},{"line_number":224,"context_line":"        LOG.error(\u0027some error occured. Failed to check\u0027)"},{"line_number":225,"context_line":"        sys.exit(errno.EACCES)"},{"line_number":226,"context_line":"    end_time \u003d datetime.datetime.now()"},{"line_number":227,"context_line":"    proc_time \u003d end_time - start_time"},{"line_number":228,"context_line":"    print \"Test success (%d sec)\" % (proc_time.seconds)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2Fyo4%3D","line":225,"updated":"2012-08-12 02:58:16.000000000","message":"bad err code.\n\u003e EACCES Permission denied (POSIX.1)\n\nAnd multiple sys.exit is generally something wrong.","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":222,"context_line":"    test_agent.test_connection_all_network()"},{"line_number":223,"context_line":"    if not test_agent.is_success():"},{"line_number":224,"context_line":"        LOG.error(\u0027some error occured. Failed to check\u0027)"},{"line_number":225,"context_line":"        sys.exit(errno.EACCES)"},{"line_number":226,"context_line":"    end_time \u003d datetime.datetime.now()"},{"line_number":227,"context_line":"    proc_time \u003d end_time - start_time"},{"line_number":228,"context_line":"    print \"Test success (%d sec)\" % (proc_time.seconds)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAALH%2F%2FyjA%3D","line":225,"in_reply_to":"AAAALH%2F%2Fyo4%3D","updated":"2012-08-12 05:27:39.000000000","message":"Done","commit_id":"f5e8b101dc1bcc6753fd010c24d42fd3d14d38bc"}],"quantum/debug/README":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"probe-create \u003cnet-id\u003e  Create probe - create port and interface,   then plug it"},{"line_number":7,"context_line":"probe-delete \u003cport-id\u003e  Delete probe - delete port then uplug"},{"line_number":8,"context_line":"probe-exec \u003cport-id\u003e \u0027command\u0027    Exec commands on the namespace of the probe"},{"line_number":9,"context_line":"probe-list     List probes"},{"line_number":10,"context_line":"probe-clear    Clear All probes"},{"line_number":11,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAALH%2F%2Fr2Q%3D","line":8,"updated":"2012-08-20 18:45:40.000000000","message":"which port-id is this?  is this an ID returned by probe-create?  Could be more clear.  Might make more sense to just have it identify the network-id you\u0027re looking to probe.  Not sure exactly what you\u0027re going for here.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":5,"context_line":""},{"line_number":6,"context_line":"probe-create \u003cnet-id\u003e  Create probe - create port and interface,   then plug it"},{"line_number":7,"context_line":"probe-delete \u003cport-id\u003e  Delete probe - delete port then uplug"},{"line_number":8,"context_line":"probe-exec \u003cport-id\u003e \u0027command\u0027    Exec commands on the namespace of the probe"},{"line_number":9,"context_line":"probe-list     List probes"},{"line_number":10,"context_line":"probe-clear    Clear All probes"},{"line_number":11,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":10,"id":"AAAALH%2F%2Frrw%3D","line":8,"in_reply_to":"AAAALH%2F%2Fr2Q%3D","updated":"2012-08-20 21:04:00.000000000","message":"I updated readme.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Debug Helper Scirpt for Quantum"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- Usage"},{"line_number":4,"context_line":"python debug/shell.py commands"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2Fmcg%3D","line":1,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Scirpt \u003d\u003e Script","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Debug Helper Scirpt for Quantum"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- Usage"},{"line_number":4,"context_line":"python debug/shell.py commands"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmR4%3D","line":1,"in_reply_to":"AAAALH%2F%2Fmcg%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":3,"context_line":"- Usage"},{"line_number":4,"context_line":"python debug/shell.py commands"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"probe-create \u003cnet-id\u003e  Create probe port - create port and interface,   then plug it"},{"line_number":7,"context_line":"  This commands returns a port id of a probe port. A probe port is a port which is used to test."},{"line_number":8,"context_line":"  The port id is probe id."},{"line_number":9,"context_line":"  We can have multiple probe in a network, in order to check connectibility between ports."}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2Fmcc%3D","line":6,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only)\n,     then plug it \u003d\u003e , then plug it in.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":3,"context_line":"- Usage"},{"line_number":4,"context_line":"python debug/shell.py commands"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"probe-create \u003cnet-id\u003e  Create probe port - create port and interface,   then plug it"},{"line_number":7,"context_line":"  This commands returns a port id of a probe port. A probe port is a port which is used to test."},{"line_number":8,"context_line":"  The port id is probe id."},{"line_number":9,"context_line":"  We can have multiple probe in a network, in order to check connectibility between ports."}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmR0%3D","line":6,"in_reply_to":"AAAALH%2F%2Fmcc%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"probe-clear    Clear All probes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ping-all \u003cnetwork_id\u003e (optional)"},{"line_number":20,"context_line":"         ping-all is all-in-one command for ping all fixed ip in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if neededa."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use command of quantum"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmcY%3D","line":20,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only)\n\nfor ping all fixed ip \u003d\u003e to ping all fixed ip\u0027s\n\nin all network \u003d\u003e in all networks","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"probe-clear    Clear All probes"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ping-all \u003cnetwork_id\u003e (optional)"},{"line_number":20,"context_line":"         ping-all is all-in-one command for ping all fixed ip in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if neededa."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use command of quantum"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmRw%3D","line":20,"in_reply_to":"AAAALH%2F%2FmcY%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ping-all \u003cnetwork_id\u003e (optional)"},{"line_number":20,"context_line":"         ping-all is all-in-one command for ping all fixed ip in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if neededa."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use command of quantum"},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmcU%3D","line":21,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only)\n\nthe command \u003d\u003e the command, a\n\nneededa \u003d\u003e needed","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"ping-all \u003cnetwork_id\u003e (optional)"},{"line_number":20,"context_line":"         ping-all is all-in-one command for ping all fixed ip in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if neededa."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use command of quantum"},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmRs%3D","line":21,"in_reply_to":"AAAALH%2F%2FmcU%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"         ping-all is all-in-one command for ping all fixed ip in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if neededa."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use command of quantum"},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmcM%3D","line":23,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only)\n\nuse command of quantum \u003d\u003e use all the commands of quantum.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"         ping-all is all-in-one command for ping all fixed ip in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if neededa."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use command of quantum"},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmRo%3D","line":23,"in_reply_to":"AAAALH%2F%2FmcM%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Debug Helper Script for Quantum"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- Usage"},{"line_number":4,"context_line":"python debug/shell.py commands"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"probe-create \u003cnet-id\u003e  Create probe port - create port and interface, then plug it in."},{"line_number":7,"context_line":"  This commands returns a port id of a probe port. A probe port is a port which is used to test."}],"source_content_type":"application/octet-stream","patch_set":19,"id":"AAAALH%2F%2FkQI%3D","line":4,"updated":"2012-08-31 01:21:28.000000000","message":"this README should be update to use the quantum-debug syntax.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"Debug Helper Script for Quantum"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"- Usage"},{"line_number":4,"context_line":"python debug/shell.py commands"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"probe-create \u003cnet-id\u003e  Create probe port - create port and interface, then plug it in."},{"line_number":7,"context_line":"  This commands returns a port id of a probe port. A probe port is a port which is used to test."}],"source_content_type":"application/octet-stream","patch_set":19,"id":"AAAALH%2F%2Fj5c%3D","line":4,"in_reply_to":"AAAALH%2F%2FkQI%3D","updated":"2012-08-31 01:31:08.000000000","message":"I got it.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":8,"context_line":"  The port id is probe id."},{"line_number":9,"context_line":"  We can have multiple probe in a network, in order to check connectibility between ports."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  python debug/shell.py port-exec probe_id_1 \u0027nc -l 192.168.100.3 22\u0027"},{"line_number":12,"context_line":"  python debug/shell.py port-exec probe_id_2 \u0027nc -vz 192.168.100.3 22\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"probe-delete \u003cport-id\u003e  Delete probe - delete port then uplug"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"AAAALH%2F%2FkJw%3D","line":11,"updated":"2012-08-31 01:21:28.000000000","message":"these commands seem incorrect, as it seems like --config-file is now needed.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":8,"context_line":"  The port id is probe id."},{"line_number":9,"context_line":"  We can have multiple probe in a network, in order to check connectibility between ports."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"  python debug/shell.py port-exec probe_id_1 \u0027nc -l 192.168.100.3 22\u0027"},{"line_number":12,"context_line":"  python debug/shell.py port-exec probe_id_2 \u0027nc -vz 192.168.100.3 22\u0027"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"probe-delete \u003cport-id\u003e  Delete probe - delete port then uplug"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"AAAALH%2F%2Fj5Y%3D","line":11,"in_reply_to":"AAAALH%2F%2FkJw%3D","updated":"2012-08-31 01:31:08.000000000","message":"--config-file could be specified on ENV variables.\nI\u0027ll add this notion.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"         ping-all is all-in-one command to ping all fixed ip\u0027s in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if needed."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use all the commands of quantum"},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"AAAALH%2F%2FkKo%3D","line":23,"updated":"2012-08-31 01:21:28.000000000","message":"Is there a godo reason for doing this? why not just have someone use the normal quantum client?  Its a dependency, so it seems like it would always be installed.  \n\nI\u0027d prefer to avoid having two ways to create a network, one with quantum-debug and one with quantum.  These commands will get up on the internet, and probably confuse people.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"         ping-all is all-in-one command to ping all fixed ip\u0027s in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if needed."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use all the commands of quantum"},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"AAAALH%2F%2Fj0Q%3D","line":23,"in_reply_to":"AAAALH%2F%2Fj5I%3D","updated":"2012-08-31 03:56:14.000000000","message":"ok, sounds reasonable.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"         ping-all is all-in-one command to ping all fixed ip\u0027s in all network or a specified network."},{"line_number":21,"context_line":"         In the command probe is automatically created if needed."},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"debug/shell.py extends the shell of quantumclient,  so you can use all the commands of quantum"},{"line_number":24,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":19,"id":"AAAALH%2F%2Fj5I%3D","line":23,"in_reply_to":"AAAALH%2F%2FkKo%3D","updated":"2012-08-31 01:31:08.000000000","message":"There are two reason.\nreason1:  In quantum shell mode, it is very useful to run quantum command. we should type net-list to get network id to probe.\nreason2:  code is very small if I extends quantumclient shell.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":13,"context_line":"probe-create \u003cnet-id\u003e  Create probe port - create port and interface, then plug it in."},{"line_number":14,"context_line":"  This commands returns a port id of a probe port. A probe port is a port which is used to test."},{"line_number":15,"context_line":"  The port id is probe id."},{"line_number":16,"context_line":"  We can have multiple probe in a network, in order to check connectibility between ports."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  quantum-debug port-exec probe_id_1 \u0027nc -l 192.168.100.3 22\u0027"},{"line_number":19,"context_line":"  quantum-debug port-exec probe_id_2 \u0027nc -vz 192.168.100.3 22\u0027"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"AAAALH%2F%2FjA8%3D","line":16,"updated":"2012-08-31 19:47:53.000000000","message":"multiple port -\u003e multiple ports\nconnectibility -\u003e connectivity","commit_id":"dc6212cc41692afb6dd96f578f612999ea3fadbb"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"  The port id is probe id."},{"line_number":16,"context_line":"  We can have multiple probe in a network, in order to check connectibility between ports."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  quantum-debug port-exec probe_id_1 \u0027nc -l 192.168.100.3 22\u0027"},{"line_number":19,"context_line":"  quantum-debug port-exec probe_id_2 \u0027nc -vz 192.168.100.3 22\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"probe-delete \u003cport-id\u003e  Delete probe - delete port then uplug"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"AAAALH%2F%2FjA4%3D","line":18,"updated":"2012-08-31 19:47:53.000000000","message":"The command name is \"probe-exec\" not port-exec","commit_id":"dc6212cc41692afb6dd96f578f612999ea3fadbb"},{"author":{"_account_id":490,"name":"Sumit Naiksatam","email":"sumitnaiksatam@gmail.com","username":"snaiksat"},"unresolved":false,"context_lines":[{"line_number":16,"context_line":"  We can have multiple probe in a network, in order to check connectibility between ports."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"  quantum-debug port-exec probe_id_1 \u0027nc -l 192.168.100.3 22\u0027"},{"line_number":19,"context_line":"  quantum-debug port-exec probe_id_2 \u0027nc -vz 192.168.100.3 22\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"probe-delete \u003cport-id\u003e  Delete probe - delete port then uplug"},{"line_number":22,"context_line":"probe-exec \u003cport-id\u003e \u0027command\u0027    Exec commands on the namespace of the probe"}],"source_content_type":"application/octet-stream","patch_set":21,"id":"AAAALH%2F%2FjA0%3D","line":19,"updated":"2012-08-31 19:47:53.000000000","message":"I tried this with IP addresses within the subnet, but I got netns errors with IP address creation. Are there any constraints on what IP addresses can be chosen?","commit_id":"dc6212cc41692afb6dd96f578f612999ea3fadbb"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":23,"context_line":"probe-list     List probes"},{"line_number":24,"context_line":"probe-clear    Clear All probes"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ping-all \u003cnetwork_id\u003e (optional)"},{"line_number":27,"context_line":"         ping-all is all-in-one command to ping all fixed ip\u0027s in all network or a specified network."},{"line_number":28,"context_line":"         In the command probe is automatically created if needed."},{"line_number":29,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":22,"id":"AAAALH%2F%2FioM%3D","line":26,"updated":"2012-09-01 23:25:50.000000000","message":"Looks like you must pass --id to ping-all.  Why is network_id not a positional optional arg?","commit_id":"4163e87d683c2ef74fc5eaa4630e7cd81f3f86cf"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":19,"context_line":"  quantum-debug probe-exec probe_id_2 \u0027nc -vz 192.168.100.4 22\u0027"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"probe-delete \u003cport-id\u003e  Delete probe - delete port then uplug"},{"line_number":22,"context_line":"probe-exec \u003cport-id\u003e \u0027command\u0027    Exec commands on the namespace of the probe"},{"line_number":23,"context_line":"probe-list     List probes"},{"line_number":24,"context_line":"probe-clear    Clear All probes"},{"line_number":25,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":24,"id":"AAAALH%2F%2FiiM%3D","line":22,"updated":"2012-09-03 00:22:30.000000000","message":"We need to document that the commands need to be self terminating (ie \u0027tcpdump -vv -n\u0027 or \u0027ping specific_ip_addr\u0027 is invalid).  A trickier problem to solve which can be done in another patch is whether we should stream stdin/stdout so that interactive commands can be exec\u0027d within a network via this interface.","commit_id":"2c8493aeb7528083cf23f9fe328505b1bccd0fd2"}],"quantum/debug/commands.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class ClearProbe(ProbeCommand):"},{"line_number":111,"context_line":"    \"\"\"Clear All probe"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ClearProbe\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fr2E%3D","line":111,"updated":"2012-08-20 18:45:40.000000000","message":"s","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"class ClearProbe(ProbeCommand):"},{"line_number":111,"context_line":"    \"\"\"Clear All probe"},{"line_number":112,"context_line":"    \"\"\""},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ClearProbe\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Frrc%3D","line":111,"in_reply_to":"AAAALH%2F%2Fr2E%3D","updated":"2012-08-20 21:04:00.000000000","message":"Done","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":131,"context_line":"        parser \u003d super(ExecProbe, self).get_parser(prog_name)"},{"line_number":132,"context_line":"        parser.add_argument("},{"line_number":133,"context_line":"            \u0027id\u0027, metavar\u003d\u0027port_id\u0027,"},{"line_number":134,"context_line":"            help\u003d\u0027ID of probe port to delete\u0027)"},{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027command\u0027, metavar\u003d\u0027command\u0027,"},{"line_number":137,"context_line":"            help\u003d\u0027Command to execute\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fr2A%3D","line":134,"updated":"2012-08-20 18:45:40.000000000","message":"wrong help text.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        parser \u003d super(ExecProbe, self).get_parser(prog_name)"},{"line_number":132,"context_line":"        parser.add_argument("},{"line_number":133,"context_line":"            \u0027id\u0027, metavar\u003d\u0027port_id\u0027,"},{"line_number":134,"context_line":"            help\u003d\u0027ID of probe port to delete\u0027)"},{"line_number":135,"context_line":"        parser.add_argument("},{"line_number":136,"context_line":"            \u0027command\u0027, metavar\u003d\u0027command\u0027,"},{"line_number":137,"context_line":"            help\u003d\u0027Command to execute\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Frrk%3D","line":134,"in_reply_to":"AAAALH%2F%2Fr2A%3D","updated":"2012-08-20 21:04:00.000000000","message":"Done","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class PingAll(ProbeCommand):"},{"line_number":149,"context_line":"    \"\"\"Ping all fixed_ip"},{"line_number":150,"context_line":"    \"\"\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ExecProbe\u0027)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fr2M%3D","line":150,"updated":"2012-08-20 18:45:40.000000000","message":"i think style guidelines suggest bringing end-quotes up if text is only a single line.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"class PingAll(ProbeCommand):"},{"line_number":149,"context_line":"    \"\"\"Ping all fixed_ip"},{"line_number":150,"context_line":"    \"\"\""},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.ExecProbe\u0027)"},{"line_number":153,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Frro%3D","line":150,"in_reply_to":"AAAALH%2F%2Fr2M%3D","updated":"2012-08-20 21:04:00.000000000","message":"Done","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--id\u0027, metavar\u003d\u0027network_id\u0027,"},{"line_number":162,"context_line":"            default\u003dNone,"},{"line_number":163,"context_line":"            help\u003d\u0027ID of network\u0027)"},{"line_number":164,"context_line":"        return parser"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def run(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fr1w%3D","line":163,"updated":"2012-08-20 18:45:40.000000000","message":"it seems inconsistent that you pass in the port-id to exec an operation within a network/subnet\u0027s namespace, but the network-id when wanting to ping all hosts.   Is there a way to make this more consistent?","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":160,"context_line":"        parser.add_argument("},{"line_number":161,"context_line":"            \u0027--id\u0027, metavar\u003d\u0027network_id\u0027,"},{"line_number":162,"context_line":"            default\u003dNone,"},{"line_number":163,"context_line":"            help\u003d\u0027ID of network\u0027)"},{"line_number":164,"context_line":"        return parser"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def run(self, parsed_args):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2FrrY%3D","line":163,"in_reply_to":"AAAALH%2F%2Fr1w%3D","updated":"2012-08-20 21:04:00.000000000","message":"We can have multiple prove port. So port_id is needed for port exec command.\n\nping-all is kind of all-in-one simple test command.\nping-all is command for ping all fixed ip in all network or a specified network. In the command probe is automatically created if needed.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":25,"context_line":"def _format_fixed_ips(port):"},{"line_number":26,"context_line":"    try:"},{"line_number":27,"context_line":"        return \u0027\\n\u0027.join([utils.dumps(ip) for ip in port[\u0027fixed_ips\u0027]])"},{"line_number":28,"context_line":"    except Exception:"},{"line_number":29,"context_line":"        return \u0027\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmcI%3D","line":28,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider providing more explicit error handling, or at least logging the exception at the debug level.  Blanket suppression of a raised exception can make it difficult to debug otherwise simple problems in production and testing.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"def _format_fixed_ips(port):"},{"line_number":26,"context_line":"    try:"},{"line_number":27,"context_line":"        return \u0027\\n\u0027.join([utils.dumps(ip) for ip in port[\u0027fixed_ips\u0027]])"},{"line_number":28,"context_line":"    except Exception:"},{"line_number":29,"context_line":"        return \u0027\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmRg%3D","line":28,"in_reply_to":"AAAALH%2F%2FmcI%3D","updated":"2012-08-28 18:39:45.000000000","message":"Hi This code is copied from quantumclient. In stead of fixing it here, I just import this method from quantumclient.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CreateProbe(ProbeCommand):"},{"line_number":46,"context_line":"    \"\"\"Create probe - create port and interface,  then plug it"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.CreateProbe\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2Fmbo%3D","line":46,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider following HACKING.rst guidelines for docstring formatting.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"class CreateProbe(ProbeCommand):"},{"line_number":46,"context_line":"    \"\"\"Create probe - create port and interface,  then plug it"},{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    log \u003d logging.getLogger(__name__ + \u0027.CreateProbe\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmRE%3D","line":46,"in_reply_to":"AAAALH%2F%2Fmbo%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def get_data(self, parsed_args):"},{"line_number":100,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":101,"context_line":"        info \u003d debug_agent.list_probes()"},{"line_number":102,"context_line":"        _columns \u003d len(info) \u003e 0 and sorted(info[0].keys()) or []"},{"line_number":103,"context_line":"        return (_columns, (utils.get_item_properties("},{"line_number":104,"context_line":"            s, _columns, formatters\u003dself._formatters, )"},{"line_number":105,"context_line":"            for s in info), )"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2Fmbw%3D","line":102,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider using Python \u003e 2.5\u0027s ternary operator, e.g.:\n\n_columns \u003d sorted(info[0].keys()) if len(info) \u003e 0 else []","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":99,"context_line":"    def get_data(self, parsed_args):"},{"line_number":100,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":101,"context_line":"        info \u003d debug_agent.list_probes()"},{"line_number":102,"context_line":"        _columns \u003d len(info) \u003e 0 and sorted(info[0].keys()) or []"},{"line_number":103,"context_line":"        return (_columns, (utils.get_item_properties("},{"line_number":104,"context_line":"            s, _columns, formatters\u003dself._formatters, )"},{"line_number":105,"context_line":"            for s in info), )"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmQ4%3D","line":102,"in_reply_to":"AAAALH%2F%2Fmbw%3D","updated":"2012-08-28 18:39:45.000000000","message":"I used same style of qunatumclient here. So I wanna fix this point , after fixing quantumclient.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":101,"context_line":"        info \u003d debug_agent.list_probes()"},{"line_number":102,"context_line":"        _columns \u003d len(info) \u003e 0 and sorted(info[0].keys()) or []"},{"line_number":103,"context_line":"        return (_columns, (utils.get_item_properties("},{"line_number":104,"context_line":"            s, _columns, formatters\u003dself._formatters, )"},{"line_number":105,"context_line":"            for s in info), )"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2Fmbs%3D","line":103,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider creating the property array as a separate statement for clarity.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":100,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":101,"context_line":"        info \u003d debug_agent.list_probes()"},{"line_number":102,"context_line":"        _columns \u003d len(info) \u003e 0 and sorted(info[0].keys()) or []"},{"line_number":103,"context_line":"        return (_columns, (utils.get_item_properties("},{"line_number":104,"context_line":"            s, _columns, formatters\u003dself._formatters, )"},{"line_number":105,"context_line":"            for s in info), )"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmQ0%3D","line":103,"in_reply_to":"AAAALH%2F%2Fmbs%3D","updated":"2012-08-28 18:39:45.000000000","message":"I used same style of qunatumclient here. So I wanna fix this point , after fixing quantumclient.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cliff import lister"},{"line_number":21,"context_line":"from quantumclient.common import utils"},{"line_number":22,"context_line":"from quantumclient.quantum.v2_0 import QuantumCommand"},{"line_number":23,"context_line":"from quantumclient.quantum.v2_0.port import _format_fixed_ips"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmGU%3D","line":21,"updated":"2012-08-28 21:56:37.000000000","message":"pep8: this should be a blank line before this line.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cliff import lister"},{"line_number":21,"context_line":"from quantumclient.common import utils"},{"line_number":22,"context_line":"from quantumclient.quantum.v2_0 import QuantumCommand"},{"line_number":23,"context_line":"from quantumclient.quantum.v2_0.port import _format_fixed_ips"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7o%3D","line":21,"in_reply_to":"AAAALH%2F%2FmGU%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def run(self, parsed_args):"},{"line_number":33,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":34,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":35,"context_line":"            _(\u0027Unimplemented commands\u0027))"},{"line_number":36,"context_line":"        return"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmGQ%3D","line":34,"updated":"2012-08-28 21:56:37.000000000","message":"self.app.stdout.write(_(\u0027Unimplemented commands\u0027) + \u0027\\n\u0027)","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def run(self, parsed_args):"},{"line_number":33,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":34,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":35,"context_line":"            _(\u0027Unimplemented commands\u0027))"},{"line_number":36,"context_line":"        return"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7k%3D","line":34,"in_reply_to":"AAAALH%2F%2FmGQ%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":53,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":54,"context_line":"        port \u003d debug_agent.create_probe(parsed_args.id)"},{"line_number":55,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":56,"context_line":"            _(\u0027Probe created : %(probe)s\u0027) %"},{"line_number":57,"context_line":"            {\u0027probe\u0027: port.id})"},{"line_number":58,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmGM%3D","line":55,"updated":"2012-08-28 21:56:37.000000000","message":"Same as above.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":53,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":54,"context_line":"        port \u003d debug_agent.create_probe(parsed_args.id)"},{"line_number":55,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":56,"context_line":"            _(\u0027Probe created : %(probe)s\u0027) %"},{"line_number":57,"context_line":"            {\u0027probe\u0027: port.id})"},{"line_number":58,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7Y%3D","line":55,"in_reply_to":"AAAALH%2F%2FmGM%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":54,"context_line":"        port \u003d debug_agent.create_probe(parsed_args.id)"},{"line_number":55,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":56,"context_line":"            _(\u0027Probe created : %(probe)s\u0027) %"},{"line_number":57,"context_line":"            {\u0027probe\u0027: port.id})"},{"line_number":58,"context_line":"        return"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmGA%3D","line":56,"updated":"2012-08-28 21:56:37.000000000","message":"Why are you making a dictionary?  Consider:\n_(\u0027New probe created. Probe id: %s)\u0027) % port.id","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":53,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":54,"context_line":"        port \u003d debug_agent.create_probe(parsed_args.id)"},{"line_number":55,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":56,"context_line":"            _(\u0027Probe created : %(probe)s\u0027) %"},{"line_number":57,"context_line":"            {\u0027probe\u0027: port.id})"},{"line_number":58,"context_line":"        return"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7c%3D","line":56,"in_reply_to":"AAAALH%2F%2FmGA%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":76,"context_line":"        debug_agent.delete_probe(parsed_args.id)"},{"line_number":77,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":78,"context_line":"            _(\u0027Probe %(id)s deleted\u0027) %"},{"line_number":79,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":80,"context_line":"        return"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmGE%3D","line":78,"updated":"2012-08-28 21:56:37.000000000","message":"_(\u0027Probe %s deleted\u0027) % parsed_args.id","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":75,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":76,"context_line":"        debug_agent.delete_probe(parsed_args.id)"},{"line_number":77,"context_line":"        print \u003e\u003eself.app.stdout, ("},{"line_number":78,"context_line":"            _(\u0027Probe %(id)s deleted\u0027) %"},{"line_number":79,"context_line":"            {\u0027id\u0027: parsed_args.id})"},{"line_number":80,"context_line":"        return"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7U%3D","line":78,"in_reply_to":"AAAALH%2F%2FmGE%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def get_data(self, parsed_args):"},{"line_number":93,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":94,"context_line":"        info \u003d debug_agent.list_probes()"},{"line_number":95,"context_line":"        _columns \u003d len(info) \u003e 0 and sorted(info[0].keys()) or []"},{"line_number":96,"context_line":"        return (_columns, (utils.get_item_properties("},{"line_number":97,"context_line":"            s, _columns, formatters\u003dself._formatters, )"},{"line_number":98,"context_line":"            for s in info), )"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmF0%3D","line":95,"updated":"2012-08-28 21:56:37.000000000","message":"columns is local to the method, so no reason to prefix it with an underscore.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":92,"context_line":"    def get_data(self, parsed_args):"},{"line_number":93,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":94,"context_line":"        info \u003d debug_agent.list_probes()"},{"line_number":95,"context_line":"        _columns \u003d len(info) \u003e 0 and sorted(info[0].keys()) or []"},{"line_number":96,"context_line":"        return (_columns, (utils.get_item_properties("},{"line_number":97,"context_line":"            s, _columns, formatters\u003dself._formatters, )"},{"line_number":98,"context_line":"            for s in info), )"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7Q%3D","line":95,"in_reply_to":"AAAALH%2F%2FmF0%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":132,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":133,"context_line":"        result \u003d debug_agent.exec_command(parsed_args.id, parsed_args.command)"},{"line_number":134,"context_line":"        print \u003e\u003eself.app.stdout, (result)"},{"line_number":135,"context_line":"        return"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class PingAll(ProbeCommand):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmFg%3D","line":135,"updated":"2012-08-28 21:56:37.000000000","message":"No need for a return here.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":132,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":133,"context_line":"        result \u003d debug_agent.exec_command(parsed_args.id, parsed_args.command)"},{"line_number":134,"context_line":"        print \u003e\u003eself.app.stdout, (result)"},{"line_number":135,"context_line":"        return"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"class PingAll(ProbeCommand):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7M%3D","line":135,"in_reply_to":"AAAALH%2F%2FmFg%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        result \u003d debug_agent.ping_all(parsed_args.id,"},{"line_number":160,"context_line":"                                      timeout\u003dparsed_args.timeout)"},{"line_number":161,"context_line":"        print \u003e\u003eself.app.stdout, (result)"},{"line_number":162,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmFc%3D","line":162,"updated":"2012-08-28 21:56:37.000000000","message":"Same as above.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":159,"context_line":"        result \u003d debug_agent.ping_all(parsed_args.id,"},{"line_number":160,"context_line":"                                      timeout\u003dparsed_args.timeout)"},{"line_number":161,"context_line":"        print \u003e\u003eself.app.stdout, (result)"},{"line_number":162,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7I%3D","line":162,"in_reply_to":"AAAALH%2F%2FmFc%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def run(self, parsed_args):"},{"line_number":34,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":35,"context_line":"        print \u003e\u003eself.app.stdout, (_(\u0027Unimplemented commands\\n\u0027))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class CreateProbe(ProbeCommand):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2FlpE%3D","line":35,"updated":"2012-08-29 11:55:27.000000000","message":"I\u0027m not sure this change matches what Mark was asking for.  It looked to me that the use of print should be replaced with a call to self.app.stdout.write(), and that the newline should appear outside of the gettext call since it doesn\u0027t need to be part of any translation. i.e.\n\nprint \u003e\u003eself.app.stdout, (_(\u0027Unimplemented commands\u0027))\n\nbecomes:\n\nself.app.stdout.write(_(\u0027Unimplemented commands\u0027) + \u0027\\n\u0027)\n\nThis comment would presumably apply to all instances of print redirection in this module.\n\nMark, can you please confirm?","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def run(self, parsed_args):"},{"line_number":34,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":35,"context_line":"        print \u003e\u003eself.app.stdout, (_(\u0027Unimplemented commands\\n\u0027))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class CreateProbe(ProbeCommand):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2Flkg%3D","line":35,"in_reply_to":"AAAALH%2F%2FlpE%3D","updated":"2012-08-29 14:02:48.000000000","message":"I tested. As you said, \\n is not needed. so I removed \\n","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def run(self, parsed_args):"},{"line_number":34,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":35,"context_line":"        print \u003e\u003eself.app.stdout, (_(\u0027Unimplemented commands\u0027))"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"class CreateProbe(ProbeCommand):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAALH%2F%2Flgg%3D","line":35,"updated":"2012-08-29 15:07:21.000000000","message":"I apologize for being unclear.  I think Mark was asking for a switch from this:\n\nprint \u003e\u003eself.app.stdout, (_(\u0027Unimplemented commands\u0027))\n\nto this:\n\nself.app.stdout.write(_(\u0027Unimplemented commands\u0027) + \u0027\\n\u0027)\n\nThis newline is required for the call to write(), since unlike print it does not add one automatically.\n\nDoes that make sense?","commit_id":"b8d66e645d5bd2af3f4dc23838cbc8424ec319cc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    distributed under the License is distributed on an \"AS IS\" BASIS,  WITHOUT"},{"line_number":15,"context_line":"#    WARRANTIES OR CONDITIONS OF ANY KIND,  either express or implied. See the"},{"line_number":16,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":"import logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from cliff import lister"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAALH%2F%2Filw%3D","line":17,"updated":"2012-09-02 11:28:34.000000000","message":"new line","commit_id":"0ee00e48a7977ece8091735511143e60cd0f76b1"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":102,"context_line":"        self.log.debug(\u0027run(%s)\u0027 % parsed_args)"},{"line_number":103,"context_line":"        debug_agent \u003d self.get_debug_agent()"},{"line_number":104,"context_line":"        debug_agent.clear_probe()"},{"line_number":105,"context_line":"        self.app.stdout.write(_(\u0027All Probe deleted \u0027) + \u0027\\n\u0027)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"class ExecProbe(ProbeCommand):"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAALH%2F%2Fh3o%3D","line":105,"updated":"2012-09-04 05:23:16.000000000","message":"_(\u0027All probes deleted.\u0027)","commit_id":"a014f9e79f2599efc0855c0d224dbc82a2dd22ae"}],"quantum/debug/debug_agent.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import sys"},{"line_number":24,"context_line":"import socket"},{"line_number":25,"context_line":"import logging"},{"line_number":26,"context_line":"import netaddr"},{"line_number":27,"context_line":"from sqlalchemy.ext import sqlsoup"},{"line_number":28,"context_line":"from subprocess import call"},{"line_number":29,"context_line":"from quantum.agent.linux import interface"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2Fmbk%3D","line":26,"updated":"2012-08-28 14:46:30.000000000","message":"HACKING - please follow the guidelines for import ordering and separation between stdlib, 3rd party, and project imports.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"import sys"},{"line_number":24,"context_line":"import socket"},{"line_number":25,"context_line":"import logging"},{"line_number":26,"context_line":"import netaddr"},{"line_number":27,"context_line":"from sqlalchemy.ext import sqlsoup"},{"line_number":28,"context_line":"from subprocess import call"},{"line_number":29,"context_line":"from quantum.agent.linux import interface"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmQM%3D","line":26,"in_reply_to":"AAAALH%2F%2Fmbk%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            ip_cidr \u003d \u0027%s/%s\u0027 % (fixed_ip.ip_address, net.prefixlen)"},{"line_number":85,"context_line":"            ip_cidrs.append(ip_cidr)"},{"line_number":86,"context_line":"        self.driver.init_l3(interface_name, ip_cidrs, namespace\u003dport.id)"},{"line_number":87,"context_line":"        return    port"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _get_subnet(self, subnet_id):"},{"line_number":90,"context_line":"        quantum \u003d self.client"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2Fmbc%3D","line":87,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider following PEP8 style guidelines:\n\nreturn     port \u003d\u003e return port","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":84,"context_line":"            ip_cidr \u003d \u0027%s/%s\u0027 % (fixed_ip.ip_address, net.prefixlen)"},{"line_number":85,"context_line":"            ip_cidrs.append(ip_cidr)"},{"line_number":86,"context_line":"        self.driver.init_l3(interface_name, ip_cidrs, namespace\u003dport.id)"},{"line_number":87,"context_line":"        return    port"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"    def _get_subnet(self, subnet_id):"},{"line_number":90,"context_line":"        quantum \u003d self.client"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmQI%3D","line":87,"in_reply_to":"AAAALH%2F%2Fmbc%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        quantum \u003d self.client"},{"line_number":96,"context_line":"        network_dict \u003d quantum.show_network(network_id)[\u0027network\u0027]"},{"line_number":97,"context_line":"        network \u003d DictModel(network_dict)"},{"line_number":98,"context_line":"        obj_subnet \u003d []"},{"line_number":99,"context_line":"        for s_id in network.subnets:"},{"line_number":100,"context_line":"            obj_subnet.append(self._get_subnet(s_id))"},{"line_number":101,"context_line":"        network.subnets \u003d obj_subnet"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmbY%3D","line":98,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider using a list comprehension to replace lines 98-101:\n\nnetwork.subnets \u003d [self._get_subnets(s_id) for x in network.subnets]","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":95,"context_line":"        quantum \u003d self.client"},{"line_number":96,"context_line":"        network_dict \u003d quantum.show_network(network_id)[\u0027network\u0027]"},{"line_number":97,"context_line":"        network \u003d DictModel(network_dict)"},{"line_number":98,"context_line":"        obj_subnet \u003d []"},{"line_number":99,"context_line":"        for s_id in network.subnets:"},{"line_number":100,"context_line":"            obj_subnet.append(self._get_subnet(s_id))"},{"line_number":101,"context_line":"        network.subnets \u003d obj_subnet"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmQA%3D","line":98,"in_reply_to":"AAAALH%2F%2FmbY%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":141,"context_line":"        quantum \u003d self.client"},{"line_number":142,"context_line":"        ports \u003d quantum.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"},{"line_number":143,"context_line":"        info \u003d ports[\u0027ports\u0027]"},{"line_number":144,"context_line":"        if len(info) \u003e 0:"},{"line_number":145,"context_line":"            return DictModel(info[0])"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            return self.create_probe(network_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmbM%3D","line":144,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider using implicit boolean conversion:\n\nbool(len(info) \u003e 0) \u003d\u003d bool(info)","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":141,"context_line":"        quantum \u003d self.client"},{"line_number":142,"context_line":"        ports \u003d quantum.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"},{"line_number":143,"context_line":"        info \u003d ports[\u0027ports\u0027]"},{"line_number":144,"context_line":"        if len(info) \u003e 0:"},{"line_number":145,"context_line":"            return DictModel(info[0])"},{"line_number":146,"context_line":"        else:"},{"line_number":147,"context_line":"            return self.create_probe(network_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmPw%3D","line":144,"in_reply_to":"AAAALH%2F%2FmbM%3D","updated":"2012-08-28 18:39:45.000000000","message":"I used ports.get(\u0027ports\u0027, []) here","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":24,"context_line":"import socket"},{"line_number":25,"context_line":"import sys"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from sqlalchemy.ext import sqlsoup"},{"line_number":28,"context_line":"from subprocess import call"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from quantum.agent.common import config"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmFE%3D","line":27,"updated":"2012-08-28 21:56:37.000000000","message":"Unused import","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":24,"context_line":"import socket"},{"line_number":25,"context_line":"import sys"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from sqlalchemy.ext import sqlsoup"},{"line_number":28,"context_line":"from subprocess import call"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from quantum.agent.common import config"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7E%3D","line":27,"in_reply_to":"AAAALH%2F%2FmFE%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":25,"context_line":"import sys"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from sqlalchemy.ext import sqlsoup"},{"line_number":28,"context_line":"from subprocess import call"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from quantum.agent.common import config"},{"line_number":31,"context_line":"from quantum.agent.dhcp_agent import DictModel"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmFI%3D","line":28,"updated":"2012-08-28 21:56:37.000000000","message":"Unused import","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"import sys"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from sqlalchemy.ext import sqlsoup"},{"line_number":28,"context_line":"from subprocess import call"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from quantum.agent.common import config"},{"line_number":31,"context_line":"from quantum.agent.dhcp_agent import DictModel"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl7A%3D","line":28,"in_reply_to":"AAAALH%2F%2FmFI%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.driver \u003d driver"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def create_probe(self, network_id):"},{"line_number":67,"context_line":"        quantum \u003d self.client"},{"line_number":68,"context_line":"        network \u003d self._get_network(network_id)"},{"line_number":69,"context_line":"        port \u003d self._create_port(network)"},{"line_number":70,"context_line":"        port.network \u003d network"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmEo%3D","line":67,"updated":"2012-08-28 21:56:37.000000000","message":"This line is unused.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.driver \u003d driver"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def create_probe(self, network_id):"},{"line_number":67,"context_line":"        quantum \u003d self.client"},{"line_number":68,"context_line":"        network \u003d self._get_network(network_id)"},{"line_number":69,"context_line":"        port \u003d self._create_port(network)"},{"line_number":70,"context_line":"        port.network \u003d network"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl68%3D","line":67,"in_reply_to":"AAAALH%2F%2FmEo%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _get_subnet(self, subnet_id):"},{"line_number":91,"context_line":"        quantum \u003d self.client"},{"line_number":92,"context_line":"        subnet_dict \u003d quantum.show_subnet(subnet_id)[\u0027subnet\u0027]"},{"line_number":93,"context_line":"        return DictModel(subnet_dict)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_network(self, network_id):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmDY%3D","line":92,"updated":"2012-08-28 21:56:37.000000000","message":"The assignment of self.client to quantum is confusing.  Why not just use self.client.show_subnet(subnet_id)[\u0027subnet\u0027]?","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _get_subnet(self, subnet_id):"},{"line_number":91,"context_line":"        quantum \u003d self.client"},{"line_number":92,"context_line":"        subnet_dict \u003d quantum.show_subnet(subnet_id)[\u0027subnet\u0027]"},{"line_number":93,"context_line":"        return DictModel(subnet_dict)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_network(self, network_id):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl64%3D","line":92,"in_reply_to":"AAAALH%2F%2FmDY%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_network(self, network_id):"},{"line_number":96,"context_line":"        quantum \u003d self.client"},{"line_number":97,"context_line":"        network_dict \u003d quantum.show_network(network_id)[\u0027network\u0027]"},{"line_number":98,"context_line":"        network \u003d DictModel(network_dict)"},{"line_number":99,"context_line":"        obj_subnet \u003d [self._get_subnet(s_id) for s_id in network.subnets]"},{"line_number":100,"context_line":"        network.subnets \u003d obj_subnet"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmDU%3D","line":97,"updated":"2012-08-28 21:56:37.000000000","message":"Same as above","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_network(self, network_id):"},{"line_number":96,"context_line":"        quantum \u003d self.client"},{"line_number":97,"context_line":"        network_dict \u003d quantum.show_network(network_id)[\u0027network\u0027]"},{"line_number":98,"context_line":"        network \u003d DictModel(network_dict)"},{"line_number":99,"context_line":"        obj_subnet \u003d [self._get_subnet(s_id) for s_id in network.subnets]"},{"line_number":100,"context_line":"        network.subnets \u003d obj_subnet"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl60%3D","line":97,"in_reply_to":"AAAALH%2F%2FmDU%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def clear_probe(self):"},{"line_number":104,"context_line":"        quantum \u003d self.client"},{"line_number":105,"context_line":"        ports \u003d quantum.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"},{"line_number":106,"context_line":"        info \u003d ports[\u0027ports\u0027]"},{"line_number":107,"context_line":"        for port in info:"},{"line_number":108,"context_line":"            self.delete_probe(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmDM%3D","line":105,"updated":"2012-08-28 21:56:37.000000000","message":"Same as above","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def clear_probe(self):"},{"line_number":104,"context_line":"        quantum \u003d self.client"},{"line_number":105,"context_line":"        ports \u003d quantum.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"},{"line_number":106,"context_line":"        info \u003d ports[\u0027ports\u0027]"},{"line_number":107,"context_line":"        for port in info:"},{"line_number":108,"context_line":"            self.delete_probe(port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6w%3D","line":105,"in_reply_to":"AAAALH%2F%2FmDM%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def delete_probe(self, port_id):"},{"line_number":111,"context_line":"        quantum \u003d self.client"},{"line_number":112,"context_line":"        port \u003d DictModel(quantum.show_port(port_id)[\u0027port\u0027])"},{"line_number":113,"context_line":"        self.driver.unplug(self.get_interface_name(port))"},{"line_number":114,"context_line":"        namespace \u003d port.id"},{"line_number":115,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmDI%3D","line":112,"updated":"2012-08-28 21:56:37.000000000","message":"Same as above","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def delete_probe(self, port_id):"},{"line_number":111,"context_line":"        quantum \u003d self.client"},{"line_number":112,"context_line":"        port \u003d DictModel(quantum.show_port(port_id)[\u0027port\u0027])"},{"line_number":113,"context_line":"        self.driver.unplug(self.get_interface_name(port))"},{"line_number":114,"context_line":"        namespace \u003d port.id"},{"line_number":115,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6s%3D","line":112,"in_reply_to":"AAAALH%2F%2FmDI%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.driver.unplug(self.get_interface_name(port))"},{"line_number":114,"context_line":"        namespace \u003d port.id"},{"line_number":115,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":116,"context_line":"        if ip.netns.exists(namespace):"},{"line_number":117,"context_line":"            namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":118,"context_line":"            namespace.netns.delete(port.id)"},{"line_number":119,"context_line":"        quantum.delete_port(port.id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmEg%3D","line":116,"updated":"2012-08-28 21:56:37.000000000","message":"How do you know the namespace is empty?","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self.driver.unplug(self.get_interface_name(port))"},{"line_number":114,"context_line":"        namespace \u003d port.id"},{"line_number":115,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":116,"context_line":"        if ip.netns.exists(namespace):"},{"line_number":117,"context_line":"            namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":118,"context_line":"            namespace.netns.delete(port.id)"},{"line_number":119,"context_line":"        quantum.delete_port(port.id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6o%3D","line":116,"in_reply_to":"AAAALH%2F%2FmEg%3D","updated":"2012-08-29 04:46:11.000000000","message":"May I ask more detail?","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        quantum \u003d self.client"},{"line_number":134,"context_line":"        port \u003d DictModel(quantum.show_port(port_id)[\u0027port\u0027])"},{"line_number":135,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":136,"context_line":"        namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":137,"context_line":"        return namespace.netns.execute(command.split(\u0027 \u0027))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def ensure_probe(self, network_id):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmEU%3D","line":136,"updated":"2012-08-28 21:56:37.000000000","message":"Why have use_namespaces as configuration option if you\u0027re going to ignore it?","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":133,"context_line":"        quantum \u003d self.client"},{"line_number":134,"context_line":"        port \u003d DictModel(quantum.show_port(port_id)[\u0027port\u0027])"},{"line_number":135,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":136,"context_line":"        namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":137,"context_line":"        return namespace.netns.execute(command.split(\u0027 \u0027))"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def ensure_probe(self, network_id):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl1g%3D","line":136,"in_reply_to":"AAAALH%2F%2FmEU%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        quantum \u003d self.client"},{"line_number":141,"context_line":"        ports \u003d quantum.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"},{"line_number":142,"context_line":"        info \u003d ports.get(\u0027ports\u0027, [])"},{"line_number":143,"context_line":"        if len(info) \u003e 0:"},{"line_number":144,"context_line":"            return DictModel(info[0])"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            return self.create_probe(network_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmCo%3D","line":143,"updated":"2012-08-28 21:56:37.000000000","message":"if info:\n\nis the same as \nlen(info) \u003e 0","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":140,"context_line":"        quantum \u003d self.client"},{"line_number":141,"context_line":"        ports \u003d quantum.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"},{"line_number":142,"context_line":"        info \u003d ports.get(\u0027ports\u0027, [])"},{"line_number":143,"context_line":"        if len(info) \u003e 0:"},{"line_number":144,"context_line":"            return DictModel(info[0])"},{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            return self.create_probe(network_id)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6k%3D","line":143,"in_reply_to":"AAAALH%2F%2FmCo%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            return self.create_probe(network_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def ping_all(self, network_id, timeout\u003d1):"},{"line_number":149,"context_line":"        quantum \u003d self.client"},{"line_number":150,"context_line":"        if network_id:"},{"line_number":151,"context_line":"            ports \u003d quantum.list_ports(network_id\u003dnetwork_id)[\u0027ports\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmCg%3D","line":148,"updated":"2012-08-28 21:56:37.000000000","message":"Consider network_id\u003dNone, so that it is apparent the value is optional.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":145,"context_line":"        else:"},{"line_number":146,"context_line":"            return self.create_probe(network_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def ping_all(self, network_id, timeout\u003d1):"},{"line_number":149,"context_line":"        quantum \u003d self.client"},{"line_number":150,"context_line":"        if network_id:"},{"line_number":151,"context_line":"            ports \u003d quantum.list_ports(network_id\u003dnetwork_id)[\u0027ports\u0027]"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6c%3D","line":148,"in_reply_to":"AAAALH%2F%2FmCg%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":146,"context_line":"            return self.create_probe(network_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def ping_all(self, network_id, timeout\u003d1):"},{"line_number":149,"context_line":"        quantum \u003d self.client"},{"line_number":150,"context_line":"        if network_id:"},{"line_number":151,"context_line":"            ports \u003d quantum.list_ports(network_id\u003dnetwork_id)[\u0027ports\u0027]"},{"line_number":152,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmC0%3D","line":149,"updated":"2012-08-28 21:56:37.000000000","message":"Same as above","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":146,"context_line":"            return self.create_probe(network_id)"},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def ping_all(self, network_id, timeout\u003d1):"},{"line_number":149,"context_line":"        quantum \u003d self.client"},{"line_number":150,"context_line":"        if network_id:"},{"line_number":151,"context_line":"            ports \u003d quantum.list_ports(network_id\u003dnetwork_id)[\u0027ports\u0027]"},{"line_number":152,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6g%3D","line":149,"in_reply_to":"AAAALH%2F%2FmC0%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":158,"context_line":"                address \u003d fixed_ip[\u0027ip_address\u0027]"},{"line_number":159,"context_line":"                result +\u003d self.exec_command(probe.id,"},{"line_number":160,"context_line":"                                            \u0027ping -c 1 -w %s %s\u0027 % (timeout,"},{"line_number":161,"context_line":"                                                                    address))"},{"line_number":162,"context_line":"        return result"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmDw%3D","line":160,"updated":"2012-08-28 21:56:37.000000000","message":"You need to take into account which IP version is in use, so that you can call ping/ping6 appropriately.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"            for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":158,"context_line":"                address \u003d fixed_ip[\u0027ip_address\u0027]"},{"line_number":159,"context_line":"                result +\u003d self.exec_command(probe.id,"},{"line_number":160,"context_line":"                                            \u0027ping -c 1 -w %s %s\u0027 % (timeout,"},{"line_number":161,"context_line":"                                                                    address))"},{"line_number":162,"context_line":"        return result"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl1c%3D","line":160,"in_reply_to":"AAAALH%2F%2FmDw%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return result"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _create_port(self, network):"},{"line_number":165,"context_line":"        quantum \u003d self.client"},{"line_number":166,"context_line":"        body \u003d dict(port\u003ddict("},{"line_number":167,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":168,"context_line":"            network_id\u003dnetwork.id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmCw%3D","line":165,"updated":"2012-08-28 21:56:37.000000000","message":"Same as above","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":162,"context_line":"        return result"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _create_port(self, network):"},{"line_number":165,"context_line":"        quantum \u003d self.client"},{"line_number":166,"context_line":"        body \u003d dict(port\u003ddict("},{"line_number":167,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":168,"context_line":"            network_id\u003dnetwork.id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6Y%3D","line":165,"in_reply_to":"AAAALH%2F%2FmCw%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        body \u003d dict(port\u003ddict("},{"line_number":167,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":168,"context_line":"            network_id\u003dnetwork.id,"},{"line_number":169,"context_line":"            device_id\u003d\u0027%s\u0027 % socket.gethostname(),"},{"line_number":170,"context_line":"            device_owner\u003dDEVICE_OWNER_PROBE,"},{"line_number":171,"context_line":"            tenant_id\u003dnetwork.tenant_id,"},{"line_number":172,"context_line":"            fixed_ips\u003d[dict(subnet_id\u003ds.id) for s in network.subnets]))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmEw%3D","line":169,"updated":"2012-08-28 21:56:37.000000000","message":"This method for generating a device means that all instances of the debug shell on a host will have the same id. Is this your intent?","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":166,"context_line":"        body \u003d dict(port\u003ddict("},{"line_number":167,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":168,"context_line":"            network_id\u003dnetwork.id,"},{"line_number":169,"context_line":"            device_id\u003d\u0027%s\u0027 % socket.gethostname(),"},{"line_number":170,"context_line":"            device_owner\u003dDEVICE_OWNER_PROBE,"},{"line_number":171,"context_line":"            tenant_id\u003dnetwork.tenant_id,"},{"line_number":172,"context_line":"            fixed_ips\u003d[dict(subnet_id\u003ds.id) for s in network.subnets]))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6U%3D","line":169,"in_reply_to":"AAAALH%2F%2FmEw%3D","updated":"2012-08-29 04:46:11.000000000","message":"Yes. The use of device id on probe port is to identify host. \nThis is useful when we test quantum in multi node setup.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":27,"context_line":"from quantum.agent.common import config"},{"line_number":28,"context_line":"from quantum.agent.dhcp_agent import DictModel"},{"line_number":29,"context_line":"from quantum.agent.linux import interface"},{"line_number":30,"context_line":"from quantum.agent.linux import utils"},{"line_number":31,"context_line":"from quantum.agent.linux import ip_lib"},{"line_number":32,"context_line":"from quantum.openstack.common import cfg"},{"line_number":33,"context_line":"from quantum.openstack.common import importutils"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2Flo4%3D","line":30,"updated":"2012-08-29 11:55:27.000000000","message":"Please review the HACKING.rst (in the root of the repo) guidelines on import ordering. \n\nThis import should appear after the next line according the the ordering convention.","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":27,"context_line":"from quantum.agent.common import config"},{"line_number":28,"context_line":"from quantum.agent.dhcp_agent import DictModel"},{"line_number":29,"context_line":"from quantum.agent.linux import interface"},{"line_number":30,"context_line":"from quantum.agent.linux import utils"},{"line_number":31,"context_line":"from quantum.agent.linux import ip_lib"},{"line_number":32,"context_line":"from quantum.openstack.common import cfg"},{"line_number":33,"context_line":"from quantum.openstack.common import importutils"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2FlmI%3D","line":30,"in_reply_to":"AAAALH%2F%2Flo4%3D","updated":"2012-08-29 14:02:48.000000000","message":"Sorry again, Fixed this","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"            namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":131,"context_line":"            return namespace.netns.execute(command.split(\u0027 \u0027))"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            return utils.execute(command.split(\u0027 \u0027))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def ensure_probe(self, network_id):"},{"line_number":136,"context_line":"        ports \u003d self.client.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2Flow%3D","line":133,"updated":"2012-08-29 11:55:27.000000000","message":"(Suggestion only) Consider omitting the parameter to split() since \u0027 \u0027 is the default.\n\ncommand.split() \u003d\u003d command.split(\u0027 \u0027)","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":130,"context_line":"            namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":131,"context_line":"            return namespace.netns.execute(command.split(\u0027 \u0027))"},{"line_number":132,"context_line":"        else:"},{"line_number":133,"context_line":"            return utils.execute(command.split(\u0027 \u0027))"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def ensure_probe(self, network_id):"},{"line_number":136,"context_line":"        ports \u003d self.client.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2FlmA%3D","line":133,"in_reply_to":"AAAALH%2F%2Flow%3D","updated":"2012-08-29 14:02:48.000000000","message":"Done","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            namespace \u003d port.id"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if ip_lib.device_exists(interface_name,"},{"line_number":74,"context_line":"                                self.conf.root_helper, port.id):"},{"line_number":75,"context_line":"            LOG.debug(_(\u0027Reusing existing device: %s.\u0027) % interface_name)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            self.driver.plug(network.id,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlWk%3D","line":74,"updated":"2012-08-29 17:46:47.000000000","message":"should be namespace not port.id here","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":71,"context_line":"            namespace \u003d port.id"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if ip_lib.device_exists(interface_name,"},{"line_number":74,"context_line":"                                self.conf.root_helper, port.id):"},{"line_number":75,"context_line":"            LOG.debug(_(\u0027Reusing existing device: %s.\u0027) % interface_name)"},{"line_number":76,"context_line":"        else:"},{"line_number":77,"context_line":"            self.driver.plug(network.id,"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlSQ%3D","line":74,"in_reply_to":"AAAALH%2F%2FlWk%3D","updated":"2012-08-29 21:59:21.000000000","message":"Done","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        port \u003d DictModel(self.client.show_port(port_id)[\u0027port\u0027])"},{"line_number":110,"context_line":"        self.driver.unplug(self.get_interface_name(port))"},{"line_number":111,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":112,"context_line":"        if self.conf.use_namespaces and ip.netns.exists(port.id):"},{"line_number":113,"context_line":"            namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":114,"context_line":"            namespace.netns.delete(port.id)"},{"line_number":115,"context_line":"        self.client.delete_port(port.id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlWc%3D","line":112,"updated":"2012-08-29 17:46:47.000000000","message":"You must delete the device before deleting the namespace.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":109,"context_line":"        port \u003d DictModel(self.client.show_port(port_id)[\u0027port\u0027])"},{"line_number":110,"context_line":"        self.driver.unplug(self.get_interface_name(port))"},{"line_number":111,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":112,"context_line":"        if self.conf.use_namespaces and ip.netns.exists(port.id):"},{"line_number":113,"context_line":"            namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":114,"context_line":"            namespace.netns.delete(port.id)"},{"line_number":115,"context_line":"        self.client.delete_port(port.id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlRo%3D","line":112,"in_reply_to":"AAAALH%2F%2FlWc%3D","updated":"2012-08-29 21:59:21.000000000","message":"Unplug will delete the device.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            namespace.netns.delete(port.id)"},{"line_number":115,"context_line":"        self.client.delete_port(port.id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_interface_name(self, port):"},{"line_number":118,"context_line":"        return self.driver.get_device_name(port)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def list_probes(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlVw%3D","line":117,"updated":"2012-08-29 17:46:47.000000000","message":"Why are you wrapping get_device_name here? There\u0027s no additional work being done and the only callers of this method are internal to the class.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":114,"context_line":"            namespace.netns.delete(port.id)"},{"line_number":115,"context_line":"        self.client.delete_port(port.id)"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def get_interface_name(self, port):"},{"line_number":118,"context_line":"        return self.driver.get_device_name(port)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    def list_probes(self):"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlR8%3D","line":117,"in_reply_to":"AAAALH%2F%2FlVw%3D","updated":"2012-08-29 21:59:21.000000000","message":"Done","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":130,"context_line":"        if self.conf.use_namespaces:"},{"line_number":131,"context_line":"            namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":132,"context_line":"            return namespace.netns.execute(command.split())"},{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            return utils.execute(command.split())"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlV8%3D","line":132,"updated":"2012-08-29 17:46:47.000000000","message":"command.split will not properly split the command in all cases. You need to use shlex.split() from the stdlib.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":129,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":130,"context_line":"        if self.conf.use_namespaces:"},{"line_number":131,"context_line":"            namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":132,"context_line":"            return namespace.netns.execute(command.split())"},{"line_number":133,"context_line":"        else:"},{"line_number":134,"context_line":"            return utils.execute(command.split())"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlSA%3D","line":132,"in_reply_to":"AAAALH%2F%2FlV8%3D","updated":"2012-08-29 21:59:21.000000000","message":"Ah This command is cool! I fixed this.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            return utils.execute(command.split())"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def ensure_probe(self, network_id):"},{"line_number":137,"context_line":"        ports \u003d self.client.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"},{"line_number":138,"context_line":"        info \u003d ports.get(\u0027ports\u0027, [])"},{"line_number":139,"context_line":"        if info:"},{"line_number":140,"context_line":"            return DictModel(info[0])"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlTM%3D","line":137,"updated":"2012-08-29 17:46:47.000000000","message":"If you run the probe on multiple machines, this command will return the first probe in the result set even though it doesn\u0027t match the network_id.  Additionally, this command will return probe ports that are in use on other hosts, because it does not match on device_id.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":134,"context_line":"            return utils.execute(command.split())"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def ensure_probe(self, network_id):"},{"line_number":137,"context_line":"        ports \u003d self.client.list_ports(device_owner\u003dDEVICE_OWNER_PROBE)"},{"line_number":138,"context_line":"        info \u003d ports.get(\u0027ports\u0027, [])"},{"line_number":139,"context_line":"        if info:"},{"line_number":140,"context_line":"            return DictModel(info[0])"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlRE%3D","line":137,"in_reply_to":"AAAALH%2F%2FlTM%3D","updated":"2012-08-29 21:59:21.000000000","message":"Done","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class QuantumDebugAgent():"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    OPTS \u003d ["},{"line_number":47,"context_line":"        cfg.StrOpt(\u0027root_helper\u0027, default\u003d\u0027sudo\u0027),"},{"line_number":48,"context_line":"        # Needed for drivers"},{"line_number":49,"context_line":"        cfg.StrOpt(\u0027admin_user\u0027),"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAALH%2F%2Fj4s%3D","line":46,"updated":"2012-08-31 01:39:35.000000000","message":"the output of commands seem to always have verbose or debug set, even when the ini I pass in have them set to False.  This makes the output almost unreadable, and very hard to parse programmatically.  \n\ni think you\u0027re missing a call to: \n\n    config.setup_logging(cfg.CONF)\n\nwhere you register your opts, but I don\u0027t see where you\u0027 are doing that.   See the dhcp_agent.py for an example.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class QuantumDebugAgent():"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    OPTS \u003d ["},{"line_number":47,"context_line":"        cfg.StrOpt(\u0027root_helper\u0027, default\u003d\u0027sudo\u0027),"},{"line_number":48,"context_line":"        # Needed for drivers"},{"line_number":49,"context_line":"        cfg.StrOpt(\u0027admin_user\u0027),"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAALH%2F%2Fj24%3D","line":46,"in_reply_to":"AAAALH%2F%2Fj4s%3D","updated":"2012-08-31 03:07:15.000000000","message":"Done","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":86,"context_line":"            net \u003d netaddr.IPNetwork(subnet.cidr)"},{"line_number":87,"context_line":"            ip_cidr \u003d \u0027%s/%s\u0027 % (fixed_ip.ip_address, net.prefixlen)"},{"line_number":88,"context_line":"            ip_cidrs.append(ip_cidr)"},{"line_number":89,"context_line":"        self.driver.init_l3(interface_name, ip_cidrs, namespace\u003dnamespace)"},{"line_number":90,"context_line":"        return port"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _get_subnet(self, subnet_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAALH%2F%2Fj5Q%3D","line":89,"updated":"2012-08-31 01:39:35.000000000","message":"we should also add a route to this network\u0027s default gateway, if the gateway is specified.  Otherwise this probe cannot ping off the local network.  \n\nAnother option would be to have DHCP enabled, in which case we could just run a dhcpclient.  That seems a bit more complicated, but would also get more advanced routing config, dns, etc.\n\nI don\u0027t see this as a blocking issue though.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":86,"context_line":"            net \u003d netaddr.IPNetwork(subnet.cidr)"},{"line_number":87,"context_line":"            ip_cidr \u003d \u0027%s/%s\u0027 % (fixed_ip.ip_address, net.prefixlen)"},{"line_number":88,"context_line":"            ip_cidrs.append(ip_cidr)"},{"line_number":89,"context_line":"        self.driver.init_l3(interface_name, ip_cidrs, namespace\u003dnamespace)"},{"line_number":90,"context_line":"        return port"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _get_subnet(self, subnet_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAALH%2F%2Fj2k%3D","line":89,"in_reply_to":"AAAALH%2F%2Fj5Q%3D","updated":"2012-08-31 03:07:15.000000000","message":"Good point!\nI wanna add dhcp way. However test may takes time to do that. \nso I wanna do it in different patch. For now we can add default gw by command.","commit_id":"77f4e2231a4f6e6b4aaa37b43c5abe02ccacae17"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":35,"context_line":"from quantum.openstack.common import importutils"},{"line_number":36,"context_line":"from quantumclient.v2_0 import client"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"logging.basicConfig()"},{"line_number":39,"context_line":"LOG \u003d logging.getLogger(\u0027test-agent\u0027)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"DEVICE_OWNER_PROBE \u003d \u0027network:probe\u0027"}],"source_content_type":"text/x-python","patch_set":22,"id":"AAAALH%2F%2FioI%3D","line":38,"updated":"2012-09-01 23:25:50.000000000","message":"This line is causing verbose\u003dfalse, debug\u003dfalse in the config file to be ignored.  The logging is setup shell.py not sure why this is needed.","commit_id":"4163e87d683c2ef74fc5eaa4630e7cd81f3f86cf"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"unresolved":false,"context_lines":[{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class QuantumDebugAgent():"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    OPTS \u003d ["},{"line_number":46,"context_line":"        cfg.StrOpt(\u0027root_helper\u0027, default\u003d\u0027sudo\u0027),"},{"line_number":47,"context_line":"        # Needed for drivers"},{"line_number":48,"context_line":"        cfg.StrOpt(\u0027admin_user\u0027),"}],"source_content_type":"text/x-python","patch_set":23,"id":"AAAALH%2F%2Fils%3D","line":45,"updated":"2012-09-02 11:28:34.000000000","message":"It seems that only the root helper and the use_namespaces are used by this code. The comment here implies that the rest are used by the drivers. Is this correct?","commit_id":"0ee00e48a7977ece8091735511143e60cd0f76b1"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        interface_name \u003d self.driver.get_device_name(port)"},{"line_number":69,"context_line":"        namespace \u003d None"},{"line_number":70,"context_line":"        if self.conf.use_namespaces:"},{"line_number":71,"context_line":"            namespace \u003d port.id"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        if ip_lib.device_exists(interface_name,"},{"line_number":74,"context_line":"                                self.conf.root_helper, namespace):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAALH%2F%2FiiU%3D","line":71,"updated":"2012-09-03 00:22:30.000000000","message":"I\u0027d like to see the namespace mangled similar to the dhcp and l3 mangling.  Maybe qprobe-\u003cport.id\u003e?","commit_id":"2c8493aeb7528083cf23f9fe328505b1bccd0fd2"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":116,"context_line":"        namespace \u003d self._get_namespace(port)"},{"line_number":117,"context_line":"        if self.conf.use_namespaces and ip.netns.exists(namespace):"},{"line_number":118,"context_line":"            namespace \u003d ip.ensure_namespace(namespace)"},{"line_number":119,"context_line":"            namespace.netns.delete(namespace)"},{"line_number":120,"context_line":"        self.client.delete_port(port.id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def list_probes(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAALH%2F%2FiP8%3D","line":119,"updated":"2012-09-03 14:59:24.000000000","message":"delete_probe() did not work. ip.ensure_namespace() returns IPWrapper class, but netns.delete takes a name of namespace to delete.\n\nAfter I changed the code L.118-119 to the following, I got it work.\n  ip.netns.delete(namespace)\n\nSince we check if the namespace exists, I think ensure_namespace() is unnecessary.","commit_id":"9dde0e48aac68114ef5b2914a2c510ff7bf8ca7f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":116,"context_line":"        namespace \u003d self._get_namespace(port)"},{"line_number":117,"context_line":"        if self.conf.use_namespaces and ip.netns.exists(namespace):"},{"line_number":118,"context_line":"            namespace \u003d ip.ensure_namespace(namespace)"},{"line_number":119,"context_line":"            namespace.netns.delete(namespace)"},{"line_number":120,"context_line":"        self.client.delete_port(port.id)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"    def list_probes(self):"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAALH%2F%2FiN0%3D","line":119,"in_reply_to":"AAAALH%2F%2FiP8%3D","updated":"2012-09-03 15:55:19.000000000","message":"Thank you for your pointing this.\nI found device is not deleted because I din\u0027t pass namespace to unplug.","commit_id":"9dde0e48aac68114ef5b2914a2c510ff7bf8ca7f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":132,"context_line":"        namespace \u003d self._get_namespace(port)"},{"line_number":133,"context_line":"        if self.conf.use_namespaces:"},{"line_number":134,"context_line":"            if not command:"},{"line_number":135,"context_line":"                return \"sudo ip netns exec %s\" % self._get_namespace(port)"},{"line_number":136,"context_line":"            namespace \u003d ip.ensure_namespace(namespace)"},{"line_number":137,"context_line":"            return namespace.netns.execute(shlex.split(command))"},{"line_number":138,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAALH%2F%2FiPM%3D","line":135,"updated":"2012-09-03 14:59:24.000000000","message":"your comment on patch set 24 says \"i\u0027ll modify probe-exec command to show ip netns exec command if no command specified\". Do you plan to modify it?","commit_id":"9dde0e48aac68114ef5b2914a2c510ff7bf8ca7f"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":132,"context_line":"        namespace \u003d self._get_namespace(port)"},{"line_number":133,"context_line":"        if self.conf.use_namespaces:"},{"line_number":134,"context_line":"            if not command:"},{"line_number":135,"context_line":"                return \"sudo ip netns exec %s\" % self._get_namespace(port)"},{"line_number":136,"context_line":"            namespace \u003d ip.ensure_namespace(namespace)"},{"line_number":137,"context_line":"            return namespace.netns.execute(shlex.split(command))"},{"line_number":138,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAALH%2F%2FiNw%3D","line":135,"in_reply_to":"AAAALH%2F%2FiPM%3D","updated":"2012-09-03 15:55:19.000000000","message":"This code is my intent. so user can do `quantum-debug probe-exec \u003cport-id\u003e` ssh","commit_id":"9dde0e48aac68114ef5b2914a2c510ff7bf8ca7f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":51,"context_line":"        cfg.StrOpt(\u0027auth_url\u0027),"},{"line_number":52,"context_line":"        cfg.StrOpt(\u0027auth_strategy\u0027, default\u003d\u0027keystone\u0027),"},{"line_number":53,"context_line":"        cfg.StrOpt(\u0027auth_region\u0027),"},{"line_number":54,"context_line":"        cfg.StrOpt(\u0027use_namespaces\u0027, default\u003dTrue),"},{"line_number":55,"context_line":"        cfg.StrOpt(\u0027interface_driver\u0027,"},{"line_number":56,"context_line":"                   help\u003d\"The driver used to manage the virtual interface.\")"},{"line_number":57,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAALH%2F%2FiCc%3D","line":54,"updated":"2012-09-03 21:25:24.000000000","message":"Should be BoolOpt","commit_id":"f5d870e52dd985a6c3dc5d69054ed5ffd213259e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"unresolved":false,"context_lines":[{"line_number":150,"context_line":"        else:"},{"line_number":151,"context_line":"            return self.create_probe(network_id)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def ping_all(self, network_id\u003dNone, timeout\u003d1):"},{"line_number":154,"context_line":"        if network_id:"},{"line_number":155,"context_line":"            ports \u003d self.client.list_ports(network_id\u003dnetwork_id)[\u0027ports\u0027]"},{"line_number":156,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":28,"id":"AAAALH%2F%2FhyE%3D","line":153,"updated":"2012-09-04 09:57:09.000000000","message":"(Minor issue)\nThe output of the first ping-all and the second or later ping-all differ.\nIn the second or later ping-all, ping to probe itself is done, but not in the first time, since a probe is not created yet when retrieving a port list. It is a little tricky that the output changes.\n\n---------- #1 ----------\nPING 192.168.50.2 (192.168.50.2) 56(84) bytes of data.\n64 bytes from 192.168.50.2: icmp_req\u003d1 ttl\u003d64 time\u003d50.5 ms\n\n--- 192.168.50.2 ping statistics ---\n1 packets transmitted, 1 received, 0% packet loss, time 0ms\nrtt min/avg/max/mdev \u003d 50.565/50.565/50.565/0.000 ms\n\n---------- #2 ----------\nPING 192.168.50.2 (192.168.50.2) 56(84) bytes of data.\n64 bytes from 192.168.50.2: icmp_req\u003d1 ttl\u003d64 time\u003d0.055 ms\n\n--- 192.168.50.2 ping statistics ---\n1 packets transmitted, 1 received, 0% packet loss, time 0ms\nrtt min/avg/max/mdev \u003d 0.055/0.055/0.055/0.000 ms\nPING 192.168.50.3 (192.168.50.3) 56(84) bytes of data.\n64 bytes from 192.168.50.3: icmp_req\u003d1 ttl\u003d64 time\u003d0.045 ms\n\n--- 192.168.50.3 ping statistics ---\n1 packets transmitted, 1 received, 0% packet loss, time 0ms\nrtt min/avg/max/mdev \u003d 0.045/0.045/0.045/0.000 ms","commit_id":"f1e4b973f096becc738ea3052e99b8e70a47aa6c"}],"quantum/debug/shell.py":[{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027quantum.debug.commands.ExecProbe\u0027),"},{"line_number":40,"context_line":"    \u0027ping-all\u0027: utils.import_class("},{"line_number":41,"context_line":"        \u0027quantum.debug.commands.PingAll\u0027),"},{"line_number":42,"context_line":"#TODO(nati)  ping, netcat , nmap, bench"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":"COMMANDS \u003d {\u00272.0\u0027: COMMAND_V2}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fr1s%3D","line":42,"updated":"2012-08-20 18:45:40.000000000","message":"needed if we have the generic exec capability?","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \u0027quantum.debug.commands.ExecProbe\u0027),"},{"line_number":40,"context_line":"    \u0027ping-all\u0027: utils.import_class("},{"line_number":41,"context_line":"        \u0027quantum.debug.commands.PingAll\u0027),"},{"line_number":42,"context_line":"#TODO(nati)  ping, netcat , nmap, bench"},{"line_number":43,"context_line":"}"},{"line_number":44,"context_line":"COMMANDS \u003d {\u00272.0\u0027: COMMAND_V2}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2FrrA%3D","line":42,"in_reply_to":"AAAALH%2F%2Fr1s%3D","updated":"2012-08-20 21:04:00.000000000","message":"IMO, these command support will help developers.\nFor example , we can design ping automatically create two probe port. ( same as netcat )","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import itertools"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"import quantum.debug.commands"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantumclient.common import exceptions as exc"},{"line_number":24,"context_line":"from quantumclient.shell import QuantumShell, QUANTUM_API_VERSION, env"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmbI%3D","line":21,"updated":"2012-08-28 14:46:30.000000000","message":"HACKING - please follow the guidelines for import ordering and separation between stdlib, 3rd party, and project imports.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import itertools"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"import quantum.debug.commands"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantumclient.common import exceptions as exc"},{"line_number":24,"context_line":"from quantumclient.shell import QuantumShell, QUANTUM_API_VERSION, env"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmPs%3D","line":21,"in_reply_to":"AAAALH%2F%2FmbI%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class QuantumDebugShell(QuantumShell):"},{"line_number":50,"context_line":"    def __init__(self, apiversion):"},{"line_number":51,"context_line":"        super(QuantumDebugShell, self).__init__(apiversion)"},{"line_number":52,"context_line":"        for k, v in COMMANDS[apiversion].items():"},{"line_number":53,"context_line":"            self.command_manager.add_command(k, v)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2Fma8%3D","line":50,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider following the convention of using underscore separated variable names, e.g. api_version","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class QuantumDebugShell(QuantumShell):"},{"line_number":50,"context_line":"    def __init__(self, apiversion):"},{"line_number":51,"context_line":"        super(QuantumDebugShell, self).__init__(apiversion)"},{"line_number":52,"context_line":"        for k, v in COMMANDS[apiversion].items():"},{"line_number":53,"context_line":"            self.command_manager.add_command(k, v)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmPg%3D","line":50,"in_reply_to":"AAAALH%2F%2Fma8%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        super(QuantumDebugShell, self).initialize_app(argv)"},{"line_number":67,"context_line":"        if not self.options.config_file:"},{"line_number":68,"context_line":"            raise exc.CommandError("},{"line_number":69,"context_line":"                \"You must provide a config file for bridge\""},{"line_number":70,"context_line":"                \" either --config-file or env[TEST_CONFIG_FILE]\")"},{"line_number":71,"context_line":"        client \u003d self.client_manager.quantum"},{"line_number":72,"context_line":"        cfg.CONF.register_opts(interface.OPTS)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2Fma4%3D","line":69,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) bridge \u003d\u003e bridge -","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":66,"context_line":"        super(QuantumDebugShell, self).initialize_app(argv)"},{"line_number":67,"context_line":"        if not self.options.config_file:"},{"line_number":68,"context_line":"            raise exc.CommandError("},{"line_number":69,"context_line":"                \"You must provide a config file for bridge\""},{"line_number":70,"context_line":"                \" either --config-file or env[TEST_CONFIG_FILE]\")"},{"line_number":71,"context_line":"        client \u003d self.client_manager.quantum"},{"line_number":72,"context_line":"        cfg.CONF.register_opts(interface.OPTS)"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmPY%3D","line":69,"in_reply_to":"AAAALH%2F%2Fma4%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import itertools"},{"line_number":20,"context_line":"import quantum.debug.commands"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantum.agent.linux import interface"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHA%3D","line":20,"updated":"2012-08-28 21:56:37.000000000","message":"PEP 8 This import is in the wrong place.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":17,"context_line":"#    under the License."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import itertools"},{"line_number":20,"context_line":"import quantum.debug.commands"},{"line_number":21,"context_line":"import sys"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from quantum.agent.linux import interface"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6Q%3D","line":20,"in_reply_to":"AAAALH%2F%2FmHA%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            description, version)"},{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027--config-file\u0027,"},{"line_number":60,"context_line":"            default\u003denv(\u0027TEST_CONFIG_FILE\u0027),"},{"line_number":61,"context_line":"            help\u003d\u0027Config file for interface driver \u0027"},{"line_number":62,"context_line":"            \u0027(you can use /etc/quantum/dhcp_agent.ini)\u0027)"},{"line_number":63,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHw%3D","line":60,"updated":"2012-08-28 21:56:37.000000000","message":"Why are you defaulting to the value of a configuration variable.  What is the value is wrong?","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":57,"context_line":"            description, version)"},{"line_number":58,"context_line":"        parser.add_argument("},{"line_number":59,"context_line":"            \u0027--config-file\u0027,"},{"line_number":60,"context_line":"            default\u003denv(\u0027TEST_CONFIG_FILE\u0027),"},{"line_number":61,"context_line":"            help\u003d\u0027Config file for interface driver \u0027"},{"line_number":62,"context_line":"            \u0027(you can use /etc/quantum/dhcp_agent.ini)\u0027)"},{"line_number":63,"context_line":"        return parser"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6M%3D","line":60,"in_reply_to":"AAAALH%2F%2FmHw%3D","updated":"2012-08-29 04:46:11.000000000","message":"I wanna make shorten this command. So it takes environment variable as default.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \u0027--config-file\u0027,"},{"line_number":60,"context_line":"            default\u003denv(\u0027TEST_CONFIG_FILE\u0027),"},{"line_number":61,"context_line":"            help\u003d\u0027Config file for interface driver \u0027"},{"line_number":62,"context_line":"            \u0027(you can use /etc/quantum/dhcp_agent.ini)\u0027)"},{"line_number":63,"context_line":"        return parser"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def initialize_app(self, argv):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHo%3D","line":62,"updated":"2012-08-28 21:56:37.000000000","message":"Is this always a valid location?  I think we should the message more general.  \n\n\"You may also use either the l3_agent.ini or the dhcp_agent.ini\"","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":59,"context_line":"            \u0027--config-file\u0027,"},{"line_number":60,"context_line":"            default\u003denv(\u0027TEST_CONFIG_FILE\u0027),"},{"line_number":61,"context_line":"            help\u003d\u0027Config file for interface driver \u0027"},{"line_number":62,"context_line":"            \u0027(you can use /etc/quantum/dhcp_agent.ini)\u0027)"},{"line_number":63,"context_line":"        return parser"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def initialize_app(self, argv):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6E%3D","line":62,"in_reply_to":"AAAALH%2F%2FmHo%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.debug_agent \u003d QuantumDebugAgent(cfg.CONF, client, driver)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHI%3D","line":79,"updated":"2012-08-28 21:56:37.000000000","message":"Setting the default value to an instance variable is not a good idea.  Just default to the empty list. (argv\u003d[])","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.debug_agent \u003d QuantumDebugAgent(cfg.CONF, client, driver)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl5k%3D","line":79,"in_reply_to":"AAAALH%2F%2FmBM%3D","updated":"2012-08-29 04:46:11.000000000","message":"Hi Maru I choosed .run(argv or sys.argv[1:]) way.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.debug_agent \u003d QuantumDebugAgent(cfg.CONF, client, driver)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl6A%3D","line":79,"in_reply_to":"AAAALH%2F%2FmHI%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":76,"context_line":"        self.debug_agent \u003d QuantumDebugAgent(cfg.CONF, client, driver)"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmBM%3D","line":79,"in_reply_to":"AAAALH%2F%2FmHI%3D","updated":"2012-08-28 22:16:28.000000000","message":"I\u0027ll second Mark\u0027s recommendation, though please avoid using mutable default values (e.g. [], {}, etc).  Suggest:\n\ndef main(argv\u003dNone):\n  if argv is None:\n    argv \u003d sys.argv[1:]","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"},{"line_number":83,"context_line":"        return QuantumDebugShell(QUANTUM_API_VERSION).run(argv)"},{"line_number":84,"context_line":"    except exc.QuantumClientException:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHc%3D","line":81,"updated":"2012-08-28 21:56:37.000000000","message":"You should avoid monkey patching the standard library unless you have good reason to do so.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"},{"line_number":83,"context_line":"        return QuantumDebugShell(QUANTUM_API_VERSION).run(argv)"},{"line_number":84,"context_line":"    except exc.QuantumClientException:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl50%3D","line":81,"in_reply_to":"AAAALH%2F%2FmHc%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":79,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"},{"line_number":83,"context_line":"        return QuantumDebugShell(QUANTUM_API_VERSION).run(argv)"},{"line_number":84,"context_line":"    except exc.QuantumClientException:"},{"line_number":85,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHE%3D","line":82,"updated":"2012-08-28 21:56:37.000000000","message":"itertool_compressdef does not exist in the current namespace.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":79,"context_line":"def main(argv\u003dsys.argv[1:]):"},{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"},{"line_number":83,"context_line":"        return QuantumDebugShell(QUANTUM_API_VERSION).run(argv)"},{"line_number":84,"context_line":"    except exc.QuantumClientException:"},{"line_number":85,"context_line":"        return 1"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl5w%3D","line":82,"in_reply_to":"AAAALH%2F%2FmHE%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"},{"line_number":83,"context_line":"        return QuantumDebugShell(QUANTUM_API_VERSION).run(argv)"},{"line_number":84,"context_line":"    except exc.QuantumClientException:"},{"line_number":85,"context_line":"        return 1"},{"line_number":86,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHQ%3D","line":83,"updated":"2012-08-28 21:56:37.000000000","message":"return QuantumDebugShell(QUANTUM_API_VERSION).run(argv or sys.argv[1:])","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":80,"context_line":"    try:"},{"line_number":81,"context_line":"        if not getattr(itertools, \u0027compress\u0027, None):"},{"line_number":82,"context_line":"            setattr(itertools, \u0027compress\u0027, itertools_compressdef)"},{"line_number":83,"context_line":"        return QuantumDebugShell(QUANTUM_API_VERSION).run(argv)"},{"line_number":84,"context_line":"    except exc.QuantumClientException:"},{"line_number":85,"context_line":"        return 1"},{"line_number":86,"context_line":"    except Exception as e:"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl5o%3D","line":83,"in_reply_to":"AAAALH%2F%2FmHQ%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    except exc.QuantumClientException:"},{"line_number":85,"context_line":"        return 1"},{"line_number":86,"context_line":"    except Exception as e:"},{"line_number":87,"context_line":"        print e"},{"line_number":88,"context_line":"        return 1"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHM%3D","line":87,"updated":"2012-08-28 21:56:37.000000000","message":"Print sends the output to stdout, this should go to stderr.  Also, is it your intent to truncate the traceback to just one line?","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":84,"context_line":"    except exc.QuantumClientException:"},{"line_number":85,"context_line":"        return 1"},{"line_number":86,"context_line":"    except Exception as e:"},{"line_number":87,"context_line":"        print e"},{"line_number":88,"context_line":"        return 1"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl5s%3D","line":87,"in_reply_to":"AAAALH%2F%2FmHM%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":92,"context_line":"    sys.exit(main(sys.argv[1:]))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmHU%3D","line":92,"updated":"2012-08-28 21:56:37.000000000","message":"You\u0027re passing in the default value, why just rely on the method\u0027s default?","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"if __name__ \u003d\u003d \"__main__\":"},{"line_number":92,"context_line":"    sys.exit(main(sys.argv[1:]))"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl5g%3D","line":92,"in_reply_to":"AAAALH%2F%2FmHU%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"            default\u003denv(\u0027TEST_CONFIG_FILE\u0027),"},{"line_number":61,"context_line":"            help\u003d\u0027Config file for interface driver \u0027"},{"line_number":62,"context_line":"            \u0027(You may also use either the \u0027"},{"line_number":63,"context_line":"            \u0027l3_agent.ini or the dhcp_agent.ini)\u0027)"},{"line_number":64,"context_line":"        return parser"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def initialize_app(self, argv):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2Flos%3D","line":63,"updated":"2012-08-29 11:55:27.000000000","message":"(Suggestion only) Consider aligning the opening quotes of all 3 lines of this string definition for readability.","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":60,"context_line":"            default\u003denv(\u0027TEST_CONFIG_FILE\u0027),"},{"line_number":61,"context_line":"            help\u003d\u0027Config file for interface driver \u0027"},{"line_number":62,"context_line":"            \u0027(You may also use either the \u0027"},{"line_number":63,"context_line":"            \u0027l3_agent.ini or the dhcp_agent.ini)\u0027)"},{"line_number":64,"context_line":"        return parser"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    def initialize_app(self, argv):"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2Fllk%3D","line":63,"in_reply_to":"AAAALH%2F%2Flos%3D","updated":"2012-08-29 14:02:48.000000000","message":"Done","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.debug_agent \u003d QuantumDebugAgent(cfg.CONF, client, driver)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def main(argv\u003d[]):"},{"line_number":81,"context_line":"    return QuantumDebugShell(QUANTUM_API_VERSION).run(argv or sys.argv[1:])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2Flog%3D","line":80,"updated":"2012-08-29 11:55:27.000000000","message":"Please change the default value for argv to be non-mutable.  See the following link as to why:  \n\nhttp://stackoverflow.com/questions/1132941/least-astonishment-in-python-the-mutable-default-argument","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":77,"context_line":"        self.debug_agent \u003d QuantumDebugAgent(cfg.CONF, client, driver)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def main(argv\u003d[]):"},{"line_number":81,"context_line":"    return QuantumDebugShell(QUANTUM_API_VERSION).run(argv or sys.argv[1:])"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"if __name__ \u003d\u003d \"__main__\":"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2FllY%3D","line":80,"in_reply_to":"AAAALH%2F%2Flog%3D","updated":"2012-08-29 14:02:48.000000000","message":"Done","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"}],"quantum/debug/test_agent.py":[{"author":{"_account_id":1731,"name":"Yusuke Muraoka","email":"yusuke@nttmcl.com","username":"yusuke"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/python"},{"line_number":2,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"# Copyright 2012,  Nachi Ueno,  NTT MCL,  Inc."}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fsds%3D","line":1,"updated":"2012-08-18 22:37:14.000000000","message":"The shebang is invalid for almost linux.\nThe name test_agent.py might be collected by a smart test runner, and confused. Because of the prefix \"test_\". However I have no idea. :-p","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":28,"context_line":"from subprocess import call"},{"line_number":29,"context_line":"from quantum.agent.linux import interface"},{"line_number":30,"context_line":"from quantum.agent.common import config"},{"line_number":31,"context_line":"from quantum.agent.dhcp_agent import DictModel"},{"line_number":32,"context_line":"from quantumclient.v2_0 import client"},{"line_number":33,"context_line":"from quantum.openstack.common import importutils"},{"line_number":34,"context_line":"from quantum.openstack.common import cfg"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Frzw%3D","line":31,"updated":"2012-08-20 18:45:40.000000000","message":"wrote an email about this and CC\u0027d you.  I\u0027m not sure there\u0027s a point in using DictModel widely (though get_device_name) seems to require it for now, though I\u0027d like to see that change.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from subprocess import call"},{"line_number":29,"context_line":"from quantum.agent.linux import interface"},{"line_number":30,"context_line":"from quantum.agent.common import config"},{"line_number":31,"context_line":"from quantum.agent.dhcp_agent import DictModel"},{"line_number":32,"context_line":"from quantumclient.v2_0 import client"},{"line_number":33,"context_line":"from quantum.openstack.common import importutils"},{"line_number":34,"context_line":"from quantum.openstack.common import cfg"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Frq8%3D","line":31,"in_reply_to":"AAAALH%2F%2Frzw%3D","updated":"2012-08-20 21:04:00.000000000","message":"I can do both way. (Change it in this patch or fix later.)  plug or unplug is also depends on DictModel.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":"        conf([\u0027--config-file\u0027, config_file])"},{"line_number":63,"context_line":"        config.setup_logging(conf)"},{"line_number":64,"context_line":"        self.conf \u003d conf"},{"line_number":65,"context_line":"        interface_driver \u003d conf.interface_driver"},{"line_number":66,"context_line":"        self.client \u003d client"},{"line_number":67,"context_line":"        self.driver \u003d importutils.import_object(interface_driver, conf)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fr1Y%3D","line":65,"updated":"2012-08-20 18:45:40.000000000","message":"can be merged with line below","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        conf([\u0027--config-file\u0027, config_file])"},{"line_number":63,"context_line":"        config.setup_logging(conf)"},{"line_number":64,"context_line":"        self.conf \u003d conf"},{"line_number":65,"context_line":"        interface_driver \u003d conf.interface_driver"},{"line_number":66,"context_line":"        self.client \u003d client"},{"line_number":67,"context_line":"        self.driver \u003d importutils.import_object(interface_driver, conf)"},{"line_number":68,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Frq4%3D","line":65,"in_reply_to":"AAAALH%2F%2Fr1Y%3D","updated":"2012-08-20 21:04:00.000000000","message":"Done","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":116,"context_line":"        quantum \u003d self.get_quantum_client()"},{"line_number":117,"context_line":"        port \u003d DictModel(quantum.show_port(port_id)[\u0027port\u0027])"},{"line_number":118,"context_line":"        self.driver.unplug(self.get_interface_name(port))"},{"line_number":119,"context_line":"        namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":120,"context_line":"        namespace.netns.delete()"},{"line_number":121,"context_line":"        quantum.delete_port(port.id)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Frzk%3D","line":119,"updated":"2012-08-20 18:45:40.000000000","message":"this will create the namespace if it doesn\u0027t exist already.  instead, just use exists() to test if the namespace exists, deleting it if it does.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        quantum \u003d self.get_quantum_client()"},{"line_number":117,"context_line":"        port \u003d DictModel(quantum.show_port(port_id)[\u0027port\u0027])"},{"line_number":118,"context_line":"        self.driver.unplug(self.get_interface_name(port))"},{"line_number":119,"context_line":"        namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":120,"context_line":"        namespace.netns.delete()"},{"line_number":121,"context_line":"        quantum.delete_port(port.id)"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2FrqY%3D","line":119,"in_reply_to":"AAAALH%2F%2Frzk%3D","updated":"2012-08-20 21:04:00.000000000","message":"Done","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":132,"context_line":"        return info"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"    def exec_command(self, port_id, command):"},{"line_number":135,"context_line":"        quantum \u003d self.get_quantum_client()"},{"line_number":136,"context_line":"        port \u003d DictModel(quantum.show_port(port_id)[\u0027port\u0027])"},{"line_number":137,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":138,"context_line":"        namespace \u003d ip.ensure_namespace(port.id)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fry0%3D","line":135,"updated":"2012-08-20 18:45:40.000000000","message":"we should have a nice error message if the port exists.  \n\nwe should also check that this is a valid probe port (rather than just some other port-id in the system).","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":136,"context_line":"        port \u003d DictModel(quantum.show_port(port_id)[\u0027port\u0027])"},{"line_number":137,"context_line":"        ip \u003d ip_lib.IPWrapper(self.conf.root_helper)"},{"line_number":138,"context_line":"        namespace \u003d ip.ensure_namespace(port.id)"},{"line_number":139,"context_line":"        return namespace.netns.execute(command.split(\u0027 \u0027))"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def get_probe(self, network_id):"},{"line_number":142,"context_line":"        quantum \u003d self.get_quantum_client()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Frz0%3D","line":139,"updated":"2012-08-20 18:45:40.000000000","message":"can we actually preserve this as an array coming all the way from the external CLI?  I\u0027m wondering how robust doing a \"split\" is in the face of more complex shell formatting.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":155,"context_line":"            ports \u003d quantum.list_ports()[\u0027ports\u0027]"},{"line_number":156,"context_line":"        result \u003d \"\""},{"line_number":157,"context_line":"        for port in ports:"},{"line_number":158,"context_line":"            probe \u003d self.get_probe(port[\u0027network_id\u0027])"},{"line_number":159,"context_line":"            for fixed_ip in port[\u0027fixed_ips\u0027]:"},{"line_number":160,"context_line":"                address \u003d fixed_ip[\u0027ip_address\u0027]"},{"line_number":161,"context_line":"                result +\u003d self.exec_command(probe.id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fry8%3D","line":158,"updated":"2012-08-20 18:45:40.000000000","message":"Odd that for ping_all we implicitly create a probe ports, but for exec_command we do not.  This should be consistent.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":164,"context_line":"        return result"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def get_quantum_client(self):"},{"line_number":167,"context_line":"        return self.client"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    def _create_port(self, network):"},{"line_number":170,"context_line":"        quantum \u003d self.get_quantum_client()"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2Fryo%3D","line":167,"updated":"2012-08-20 18:45:40.000000000","message":"method name is longer than method content.  can probably eliminate, unless I\u0027m missing something :)","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":172,"context_line":"        body \u003d dict(port\u003ddict("},{"line_number":173,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":174,"context_line":"            network_id\u003dnetwork.id,"},{"line_number":175,"context_line":"            device_id\u003d\u0027probe\u0027,"},{"line_number":176,"context_line":"            device_owner\u003d\u0027probe:%s\u0027 % socket.gethostname(),"},{"line_number":177,"context_line":"            tenant_id\u003dnetwork.tenant_id,"},{"line_number":178,"context_line":"            fixed_ips\u003d[dict(subnet_id\u003ds.id) for s in network.subnets]))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2FryA%3D","line":175,"updated":"2012-08-20 18:45:40.000000000","message":"should probably be a uuid now, based on past discussions, but i agree that there\u0027s not really much useful to put here.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":172,"context_line":"        body \u003d dict(port\u003ddict("},{"line_number":173,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":174,"context_line":"            network_id\u003dnetwork.id,"},{"line_number":175,"context_line":"            device_id\u003d\u0027probe\u0027,"},{"line_number":176,"context_line":"            device_owner\u003d\u0027probe:%s\u0027 % socket.gethostname(),"},{"line_number":177,"context_line":"            tenant_id\u003dnetwork.tenant_id,"},{"line_number":178,"context_line":"            fixed_ips\u003d[dict(subnet_id\u003ds.id) for s in network.subnets]))"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2FrqM%3D","line":175,"in_reply_to":"AAAALH%2F%2FryA%3D","updated":"2012-08-20 21:04:00.000000000","message":"I put hostname here instead of using uuid.\n# This may help we are using debug command in multiple host.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":173,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":174,"context_line":"            network_id\u003dnetwork.id,"},{"line_number":175,"context_line":"            device_id\u003d\u0027probe\u0027,"},{"line_number":176,"context_line":"            device_owner\u003d\u0027probe:%s\u0027 % socket.gethostname(),"},{"line_number":177,"context_line":"            tenant_id\u003dnetwork.tenant_id,"},{"line_number":178,"context_line":"            fixed_ips\u003d[dict(subnet_id\u003ds.id) for s in network.subnets]))"},{"line_number":179,"context_line":"        port_dict \u003d quantum.create_port(body)[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2FryE%3D","line":176,"updated":"2012-08-20 18:45:40.000000000","message":"we should try to follow the convention of \u003cservice\u003e:\u003cuse\u003e, so something like \u0027network:probe\u0027.","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"change_message_id":"71c28e141b95c38462166faeaa0528b56b32c285","unresolved":false,"context_lines":[{"line_number":173,"context_line":"            admin_state_up\u003dTrue,"},{"line_number":174,"context_line":"            network_id\u003dnetwork.id,"},{"line_number":175,"context_line":"            device_id\u003d\u0027probe\u0027,"},{"line_number":176,"context_line":"            device_owner\u003d\u0027probe:%s\u0027 % socket.gethostname(),"},{"line_number":177,"context_line":"            tenant_id\u003dnetwork.tenant_id,"},{"line_number":178,"context_line":"            fixed_ips\u003d[dict(subnet_id\u003ds.id) for s in network.subnets]))"},{"line_number":179,"context_line":"        port_dict \u003d quantum.create_port(body)[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAALH%2F%2FrqI%3D","line":176,"in_reply_to":"AAAALH%2F%2FryE%3D","updated":"2012-08-20 21:04:00.000000000","message":"Done","commit_id":"7b7bcdfcc314edaf22d081ce5d44d9abf2caacd2"}],"quantum/tests/unit/metaplugin/fake_plugin.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from quantum.common.utils import find_config_file"},{"line_number":19,"context_line":"from quantum.db import api as db"},{"line_number":20,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":21,"context_line":"from quantum.db import l3_db"},{"line_number":22,"context_line":"from quantum.db import models_v2"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlUo%3D","line":21,"updated":"2012-08-29 17:46:47.000000000","message":"Why are you making changes to this file?  The changes are outside the scope of the bug.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"from quantum.common.utils import find_config_file"},{"line_number":19,"context_line":"from quantum.db import api as db"},{"line_number":20,"context_line":"from quantum.db import db_base_plugin_v2"},{"line_number":21,"context_line":"from quantum.db import l3_db"},{"line_number":22,"context_line":"from quantum.db import models_v2"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlQ8%3D","line":21,"in_reply_to":"AAAALH%2F%2FlUo%3D","updated":"2012-08-29 21:59:21.000000000","message":"Wooops, sorry this is by mistake.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"}],"quantum/tests/unit/test_debug_agent.py":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import uuid"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":"import socket"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"import unittest2 as unittest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.agent.common import config"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2Fma0%3D","line":21,"updated":"2012-08-28 14:46:30.000000000","message":"HACKING - please follow the guidelines for import ordering and separation between stdlib, 3rd party, and project imports.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"import uuid"},{"line_number":19,"context_line":"import sys"},{"line_number":20,"context_line":"import socket"},{"line_number":21,"context_line":"import mock"},{"line_number":22,"context_line":"import unittest2 as unittest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.agent.common import config"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmPU%3D","line":21,"in_reply_to":"AAAALH%2F%2Fma0%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        cfg.CONF(args\u003dsys.argv, project\u003d\u0027quantum\u0027)"},{"line_number":44,"context_line":"        cfg.CONF.root_helper \u003d \u0027sudo\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.device_exists_p \u003d mock.patch("},{"line_number":47,"context_line":"            \u0027quantum.agent.linux.ip_lib.device_exists\u0027)"},{"line_number":48,"context_line":"        self.device_exists \u003d self.device_exists_p.start()"},{"line_number":49,"context_line":"        self.namespace_exists_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmaE%3D","line":46,"updated":"2012-08-28 14:46:30.000000000","message":"(Suggestion only) Consider setting the required version of mock to 1.0 (mock\u003e\u003d1.0) in test-requires and using unittest2\u0027s addCleanup functionality to simplify patch removal.  Then patch creation can be as simple as:\n\nself.addCleanup(mock.patch.stopall)\nmock.patch(\u0027function1\u0027)\nmock.patch(\u0027function2\u0027)\n\nNo need to hold on to a patch reference, and no need to execute patch.stop() for each patch on tearDown.\n\nEven if the global stopall() function is undesirable due to cross-module patching, the following is still possible:\n\np \u003d mock.patch(\u0027function1\u0027)\np.start()\nself.addCleanup(p.stop)\n\nThe advantage of this method is that an exception in setup will prevent tearDown from running, but any functions registered with addCleanup will still work correctly.\n\nSee: http://www.voidspace.org.uk/python/mock/patch.html#patch-methods-start-and-stop\nhttp://twitter.com/voidspace/status/223826375478489088","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"        cfg.CONF(args\u003dsys.argv, project\u003d\u0027quantum\u0027)"},{"line_number":44,"context_line":"        cfg.CONF.root_helper \u003d \u0027sudo\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        self.device_exists_p \u003d mock.patch("},{"line_number":47,"context_line":"            \u0027quantum.agent.linux.ip_lib.device_exists\u0027)"},{"line_number":48,"context_line":"        self.device_exists \u003d self.device_exists_p.start()"},{"line_number":49,"context_line":"        self.namespace_exists_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAALH%2F%2FmOM%3D","line":46,"in_reply_to":"AAAALH%2F%2FmaE%3D","updated":"2012-08-28 18:39:45.000000000","message":"Cool! I used this function.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import socket"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"import unittest2 as unittest"},{"line_number":22,"context_line":"import uuid"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.agent.common import config"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmBI%3D","line":21,"updated":"2012-08-28 22:16:28.000000000","message":"unittest2 is a 3rd party library, please order accordingly.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import socket"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"import unittest2 as unittest"},{"line_number":22,"context_line":"import uuid"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from quantum.agent.common import config"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl5Q%3D","line":21,"in_reply_to":"AAAALH%2F%2FmBI%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                                 client_inst,"},{"line_number":105,"context_line":"                                                 mock_driver)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def tearDown(self):"},{"line_number":108,"context_line":"        pass"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_create_probe(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2FmIY%3D","line":107,"updated":"2012-08-28 21:56:37.000000000","message":"This is extra code.  No need to have it if it does not do anything.","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":104,"context_line":"                                                 client_inst,"},{"line_number":105,"context_line":"                                                 mock_driver)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def tearDown(self):"},{"line_number":108,"context_line":"        pass"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_create_probe(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAALH%2F%2Fl5M%3D","line":107,"in_reply_to":"AAAALH%2F%2FmIY%3D","updated":"2012-08-29 04:46:11.000000000","message":"Done","commit_id":"39be913f4b5c5d1bcd696677e19ed6a97bcd47af"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"from quantum.agent.common import config"},{"line_number":26,"context_line":"from quantum.agent.linux import interface"},{"line_number":27,"context_line":"from quantum.common import exceptions"},{"line_number":28,"context_line":"from quantum.agent.linux import utils"},{"line_number":29,"context_line":"from quantum.debug import commands"},{"line_number":30,"context_line":"from quantum.debug import debug_agent"},{"line_number":31,"context_line":"from quantum.debug.debug_agent import DEVICE_OWNER_PROBE, QuantumDebugAgent"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2Floc%3D","line":28,"updated":"2012-08-29 11:55:27.000000000","message":"HACKING - This import needs to be moved to follow line 26.","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":25,"context_line":"from quantum.agent.common import config"},{"line_number":26,"context_line":"from quantum.agent.linux import interface"},{"line_number":27,"context_line":"from quantum.common import exceptions"},{"line_number":28,"context_line":"from quantum.agent.linux import utils"},{"line_number":29,"context_line":"from quantum.debug import commands"},{"line_number":30,"context_line":"from quantum.debug import debug_agent"},{"line_number":31,"context_line":"from quantum.debug.debug_agent import DEVICE_OWNER_PROBE, QuantumDebugAgent"}],"source_content_type":"text/x-python","patch_set":16,"id":"AAAALH%2F%2FllQ%3D","line":28,"in_reply_to":"AAAALH%2F%2Floc%3D","updated":"2012-08-29 14:02:48.000000000","message":"Done","commit_id":"89048c6f6235d4dafd698b5599525b5b9438d6be"},{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":16,"context_line":"#    under the License."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":"import socket"},{"line_number":20,"context_line":"import sys"},{"line_number":21,"context_line":"import uuid"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAALH%2F%2Flew%3D","line":18,"updated":"2012-08-29 15:07:21.000000000","message":"HACKING - mock is a 3rd party library.","commit_id":"b8d66e645d5bd2af3f4dc23838cbc8424ec319cc"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012, Nachi Ueno, NTT MCL, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlUE%3D","line":1,"updated":"2012-08-29 17:46:47.000000000","message":"This file should probably be renamed test_debug_commands.  It doesn\u0027t actually test any of the agent methods directly.  Additionally, you need to add tests to fully test ensure_probe.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":1,"context_line":"# vim: tabstop\u003d4 shiftwidth\u003d4 softtabstop\u003d4"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Copyright 2012, Nachi Ueno, NTT MCL, Inc."},{"line_number":4,"context_line":"# All Rights Reserved."}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2Fk%2Bg%3D","line":1,"in_reply_to":"AAAALH%2F%2FlUE%3D","updated":"2012-08-29 21:59:21.000000000","message":"Done","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        device_exists_p \u003d mock.patch("},{"line_number":49,"context_line":"            \u0027quantum.agent.linux.ip_lib.device_exists\u0027)"},{"line_number":50,"context_line":"        device_exists_p.start()"},{"line_number":51,"context_line":"        namespace_exists_p \u003d mock.patch("},{"line_number":52,"context_line":"            \u0027quantum.agent.linux.ip_lib.IpNetnsCommand.exists\u0027)"},{"line_number":53,"context_line":"        namespace_exists_p.start()"},{"line_number":54,"context_line":"        namespace_delete_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlUU%3D","line":51,"updated":"2012-08-29 17:46:47.000000000","message":"You setup specific mocks, but you never actually change/check the values. You might consider consolidating into one mock for \u0027quantum.agent.linux.ip_lib.IpNetnsCommand\u0027 as a whole.","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":"        device_exists_p \u003d mock.patch("},{"line_number":49,"context_line":"            \u0027quantum.agent.linux.ip_lib.device_exists\u0027)"},{"line_number":50,"context_line":"        device_exists_p.start()"},{"line_number":51,"context_line":"        namespace_exists_p \u003d mock.patch("},{"line_number":52,"context_line":"            \u0027quantum.agent.linux.ip_lib.IpNetnsCommand.exists\u0027)"},{"line_number":53,"context_line":"        namespace_exists_p.start()"},{"line_number":54,"context_line":"        namespace_delete_p \u003d mock.patch("}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlLI%3D","line":51,"in_reply_to":"AAAALH%2F%2FlUU%3D","updated":"2012-08-29 21:59:21.000000000","message":"Done","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        client_cls.return_value \u003d client_inst"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        fake_network \u003d {\u0027network\u0027: {\u0027flavor:id\u0027: \u0027fake1\u0027,"},{"line_number":75,"context_line":"                                    \u0027id\u0027: \u0027fake\u0027,"},{"line_number":76,"context_line":"                                    \u0027tenant_id\u0027: \u0027fake\u0027,"},{"line_number":77,"context_line":"                                    \u0027subnets\u0027: [\u0027fake\u0027]}}"},{"line_number":78,"context_line":"        fake_port \u003d {\u0027port\u0027:"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlSw%3D","line":75,"updated":"2012-08-29 17:46:47.000000000","message":"Consider making the id unique for each resource.  It\u0027s easy to pass the wrong resource and pass assertions since they all have \u0027fake\u0027 as an id.  (i.e. netid, subnetid, portid).","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":"        client_cls.return_value \u003d client_inst"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        fake_network \u003d {\u0027network\u0027: {\u0027flavor:id\u0027: \u0027fake1\u0027,"},{"line_number":75,"context_line":"                                    \u0027id\u0027: \u0027fake\u0027,"},{"line_number":76,"context_line":"                                    \u0027tenant_id\u0027: \u0027fake\u0027,"},{"line_number":77,"context_line":"                                    \u0027subnets\u0027: [\u0027fake\u0027]}}"},{"line_number":78,"context_line":"        fake_port \u003d {\u0027port\u0027:"}],"source_content_type":"text/x-python","patch_set":18,"id":"AAAALH%2F%2FlJs%3D","line":75,"in_reply_to":"AAAALH%2F%2FlSw%3D","updated":"2012-08-29 21:59:21.000000000","message":"Done","commit_id":"4b10ce63e07426b41ac6ba6ecfb17100e06c217e"}],"quantum/tests/unit/test_debug_commands.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"d35e63f74822511adf0548e8728f97e612635953","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                # In order to test ensure_port, return []"},{"line_number":200,"context_line":"                return {\u0027ports\u0027: []}"},{"line_number":201,"context_line":"            return fake_ports"},{"line_number":202,"context_line":"        self.client.list_ports \u003d fake_port_list"},{"line_number":203,"context_line":"        cmd \u003d commands.PingAll(self.app, None)"},{"line_number":204,"context_line":"        cmd_parser \u003d cmd.get_parser(\u0027ping_all\u0027)"},{"line_number":205,"context_line":"        args \u003d []"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAALH%2F%2Fj1E%3D","line":202,"updated":"2012-08-31 06:13:45.000000000","message":"Consider using mock.patch.object here instead of overwriting the method directly.  Mock ensures that you\u0027re overwriting an attribute defined on the class and you can ensure the mock was called.","commit_id":"bd17e2e0544d20b18eb4147af5170f2ad9cc2292"},{"author":{"_account_id":447,"name":"dan wendlandt","email":"dan@nicira.com","username":"danwent"},"unresolved":false,"context_lines":[{"line_number":199,"context_line":"                # In order to test ensure_port, return []"},{"line_number":200,"context_line":"                return {\u0027ports\u0027: []}"},{"line_number":201,"context_line":"            return fake_ports"},{"line_number":202,"context_line":"        self.client.list_ports \u003d fake_port_list"},{"line_number":203,"context_line":"        cmd \u003d commands.PingAll(self.app, None)"},{"line_number":204,"context_line":"        cmd_parser \u003d cmd.get_parser(\u0027ping_all\u0027)"},{"line_number":205,"context_line":"        args \u003d []"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAALH%2F%2FjoY%3D","line":202,"in_reply_to":"AAAALH%2F%2Fj1E%3D","updated":"2012-08-31 11:43:41.000000000","message":"agreed.  This probably isn\u0027t a blocker to merging this for Folsom, but using mock is definitely the right thing to do here.  You can look at many other tests in quantum for examples of how to do this.","commit_id":"bd17e2e0544d20b18eb4147af5170f2ad9cc2292"}],"tools/test-requires":[{"author":{"_account_id":2035,"name":"Maru Newby","email":"marun@redhat.com","username":"maru"},"change_message_id":"acc4484ae14599fd82b27c6e72f35ceafa80a57f","unresolved":false,"context_lines":[{"line_number":10,"context_line":"sphinx\u003e\u003d1.1.2"},{"line_number":11,"context_line":"unittest2"},{"line_number":12,"context_line":"webtest\u003d\u003d1.3.3"},{"line_number":13,"context_line":"cliff"},{"line_number":14,"context_line":"# Packages for the Cisco Plugin"},{"line_number":15,"context_line":"###############################"},{"line_number":16,"context_line":"configobj"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmaA%3D","line":13,"updated":"2012-08-28 14:46:30.000000000","message":"Please add in alphabetical order.","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"sphinx\u003e\u003d1.1.2"},{"line_number":11,"context_line":"unittest2"},{"line_number":12,"context_line":"webtest\u003d\u003d1.3.3"},{"line_number":13,"context_line":"cliff"},{"line_number":14,"context_line":"# Packages for the Cisco Plugin"},{"line_number":15,"context_line":"###############################"},{"line_number":16,"context_line":"configobj"}],"source_content_type":"application/octet-stream","patch_set":13,"id":"AAAALH%2F%2FmPQ%3D","line":13,"in_reply_to":"AAAALH%2F%2FmaA%3D","updated":"2012-08-28 18:39:45.000000000","message":"Done","commit_id":"0f5a0cd4363c9fe914861c89453565664cfa0aea"}]}
