)]}'
{"neutron/extensions/providernet.py":[{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"c6c4561e6e479a34fbb5d90e0f2c78cde0d41ada","unresolved":false,"context_lines":[{"line_number":23,"context_line":"SEGMENTATION_ID \u003d \u0027provider:segmentation_id\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def convert_to_int(data):"},{"line_number":27,"context_line":"    try:"},{"line_number":28,"context_line":"        return int(data)"},{"line_number":29,"context_line":"    except (ValueError, TypeError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_45a5fb46","line":26,"updated":"2014-08-05 21:46:00.000000000","message":"why did you copy-paste convert_to_int instead of using attributes.convert_to_int ?","commit_id":"3d5ae4f3c8a15e90423e858af3e9d89d72b84df3"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"2b8a6a48490fd3ec15a48a4bf2c12cf99fcf12e5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"SEGMENTATION_ID \u003d \u0027provider:segmentation_id\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"def convert_to_int(data):"},{"line_number":27,"context_line":"    try:"},{"line_number":28,"context_line":"        return int(data)"},{"line_number":29,"context_line":"    except (ValueError, TypeError):"}],"source_content_type":"text/x-python","patch_set":2,"id":"baada198_e35e00e8","line":26,"in_reply_to":"baada198_45a5fb46","updated":"2014-08-06 03:47:41.000000000","message":"Done","commit_id":"3d5ae4f3c8a15e90423e858af3e9d89d72b84df3"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dec662d0fb97088d187707abe2a2b90f068bfb36","unresolved":false,"context_lines":[{"line_number":22,"context_line":"PHYSICAL_NETWORK \u003d \u0027provider:physical_network\u0027"},{"line_number":23,"context_line":"SEGMENTATION_ID \u003d \u0027provider:segmentation_id\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":27,"context_line":"    \u0027networks\u0027: {"},{"line_number":28,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_58bbc40f","line":25,"updated":"2014-08-08 04:50:25.000000000","message":"This shouldn\u0027t be done in this patch.","commit_id":"24c9aa2185a636db06019f55964e24342223b62f"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"65fe3d9411be1fc8afc9d56da7171a846b8b5571","unresolved":false,"context_lines":[{"line_number":22,"context_line":"PHYSICAL_NETWORK \u003d \u0027provider:physical_network\u0027"},{"line_number":23,"context_line":"SEGMENTATION_ID \u003d \u0027provider:segmentation_id\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"EXTENDED_ATTRIBUTES_2_0 \u003d {"},{"line_number":27,"context_line":"    \u0027networks\u0027: {"},{"line_number":28,"context_line":"        NETWORK_TYPE: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":4,"id":"baada198_986d5c6a","line":25,"in_reply_to":"baada198_58bbc40f","updated":"2014-08-08 05:02:11.000000000","message":"Done","commit_id":"24c9aa2185a636db06019f55964e24342223b62f"}],"neutron/tests/unit/test_extension_pnet.py":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"4e1ea7e914cad18cf8d0e688e739efa61ab08fe4","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        ctx.tenant_id \u003d \u0027an_admin\u0027"},{"line_number":153,"context_line":"        bad_data \u003d {pnet.SEGMENTATION_ID: \"abc\"}"},{"line_number":154,"context_line":"        err \u003d self._post_network_with_bad_provider_attrs(ctx, bad_data, True)"},{"line_number":155,"context_line":"        self.assertEqual(err[0].status_int, 400)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_network_update_with_provider_attrs(self):"},{"line_number":158,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_6ed3d037","line":155,"updated":"2014-08-05 14:57:13.000000000","message":"Please use status code definition: web_exc.HTTPBadRequest.code instead of 400.\n\nPlus, expected value is supposed to be the first argument. Whether it is not the case for this  file, it is still preferable that you stick to right way of doing it.","commit_id":"0062e5dc4df24bb4811dd2aa520af419d4012c21"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"2b535e84684ef1f083372d913f12fd5428554883","unresolved":false,"context_lines":[{"line_number":152,"context_line":"        ctx.tenant_id \u003d \u0027an_admin\u0027"},{"line_number":153,"context_line":"        bad_data \u003d {pnet.SEGMENTATION_ID: \"abc\"}"},{"line_number":154,"context_line":"        err \u003d self._post_network_with_bad_provider_attrs(ctx, bad_data, True)"},{"line_number":155,"context_line":"        self.assertEqual(err[0].status_int, 400)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_network_update_with_provider_attrs(self):"},{"line_number":158,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"baada198_10a8aa20","line":155,"in_reply_to":"baada198_6ed3d037","updated":"2014-08-06 06:33:53.000000000","message":"Done","commit_id":"0062e5dc4df24bb4811dd2aa520af419d4012c21"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"eafc008e6f85a34946a2c472988ccc6556534e0a","unresolved":false,"context_lines":[{"line_number":122,"context_line":"                            expect_errors\u003dexpect_errors)"},{"line_number":123,"context_line":"        return res, data"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    def _post_network_with_bad_provider_attrs(self, ctx, bad_data,"},{"line_number":126,"context_line":"                                              expect_errors\u003dFalse):"},{"line_number":127,"context_line":"        data \u003d self._prepare_net_data()"},{"line_number":128,"context_line":"        data.update(bad_data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_2ff376a1","line":125,"updated":"2014-08-06 08:31:55.000000000","message":"Do we need both _post_network_with_provider_attrs and post_network_with_bad_provider_attrs? \n\nI would prefer you extend _post_network_with_provider_attrs to support extra data","commit_id":"3fe535540fc1bdc6dacf8863d813bb7e373cba9b"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"eafc008e6f85a34946a2c472988ccc6556534e0a","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":152,"context_line":"        ctx.tenant_id \u003d \u0027an_admin\u0027"},{"line_number":153,"context_line":"        bad_data \u003d {pnet.SEGMENTATION_ID: \"abc\"}"},{"line_number":154,"context_line":"        err \u003d self._post_network_with_bad_provider_attrs(ctx, bad_data, True)"},{"line_number":155,"context_line":"        self.assertEqual(web_exc.HTTPBadRequest.code, err[0].status_int)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_network_update_with_provider_attrs(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_8fa562a1","line":154,"updated":"2014-08-06 08:31:55.000000000","message":"please do not use err to store _post... result as err commonly refers to an exception.\n\n  res, _1 \u003d ...\n\nseems cleaner.","commit_id":"3fe535540fc1bdc6dacf8863d813bb7e373cba9b"},{"author":{"_account_id":9775,"name":"Sudipta Biswas","email":"sbiswas7@in.ibm.com","username":"sudswas"},"change_message_id":"a6ee741aaabfc8f2e2582bc1143e7b9638159ec3","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        ctx \u003d context.get_admin_context()"},{"line_number":152,"context_line":"        ctx.tenant_id \u003d \u0027an_admin\u0027"},{"line_number":153,"context_line":"        bad_data \u003d {pnet.SEGMENTATION_ID: \"abc\"}"},{"line_number":154,"context_line":"        err \u003d self._post_network_with_bad_provider_attrs(ctx, bad_data, True)"},{"line_number":155,"context_line":"        self.assertEqual(web_exc.HTTPBadRequest.code, err[0].status_int)"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def test_network_update_with_provider_attrs(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"baada198_0ad220d1","line":154,"in_reply_to":"baada198_8fa562a1","updated":"2014-08-06 09:05:17.000000000","message":"Done","commit_id":"3fe535540fc1bdc6dacf8863d813bb7e373cba9b"}]}