)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7293,"name":"Elena Ezhova","email":"ezhovaelena19@gmail.com","username":"elena"},"change_message_id":"5546fbe96325b8e3f1ab4a5dbb990d46970b9e32","unresolved":false,"context_lines":[{"line_number":12,"context_line":"address."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1864c0882cda7eddc9ced519ed3f96c91b2b63f3"},{"line_number":15,"context_line":"Closes-Bug: 1341268"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da9df570_d031bea3","line":15,"updated":"2014-09-22 14:44:11.000000000","message":"The convention is Closes-Bug: #1341268","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ee6e7671631e4c0b2b822e83730639d4e0aca2a2","unresolved":false,"context_lines":[{"line_number":12,"context_line":"address."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1864c0882cda7eddc9ced519ed3f96c91b2b63f3"},{"line_number":15,"context_line":"Closes-Bug: 1341268"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"da9df570_56f5c681","line":15,"in_reply_to":"da9df570_d031bea3","updated":"2014-09-22 16:06:51.000000000","message":"Done","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"84dc05ca4ebfa4e5bbd70c4ed688947fb77d26ed","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the new mac address so the NIC can be guaranteed to retain the same IP"},{"line_number":12,"context_line":"address."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1864c0882cda7eddc9ced519ed3f96c91b2b63f3"},{"line_number":15,"context_line":"Closes-Bug: #1341268"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"baa201ad_39c46591","line":14,"updated":"2014-10-14 12:27:43.000000000","message":"I think that this requires a DocImpact flag. It is a change in the user facing API.","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the new mac address so the NIC can be guaranteed to retain the same IP"},{"line_number":12,"context_line":"address."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1864c0882cda7eddc9ced519ed3f96c91b2b63f3"},{"line_number":15,"context_line":"Closes-Bug: #1341268"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":15,"id":"9aa7fdbe_52125263","line":14,"in_reply_to":"baa201ad_39c46591","updated":"2014-10-18 01:17:33.000000000","message":"Done","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"6d8bc305c6a4047a5798eb06935cdf750c1723a8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1341268"},{"line_number":19,"context_line":"Partially-implements: blueprint allow-mac-to-be-updated"},{"line_number":20,"context_line":"DocImpact: minor port update api change"},{"line_number":21,"context_line":"Change-Id: I1864c0882cda7eddc9ced519ed3f96c91b2b63f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"5a890539_87b3fe98","line":20,"updated":"2014-11-24 12:32:54.000000000","message":"you should add APIImpact flag to the commit message","commit_id":"53f751dbb3ac0668448190b360cf9d2ca2590f30"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"9b1c0e04b55eee8f31c03671030962a34e91a82e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Closes-Bug: #1341268"},{"line_number":19,"context_line":"Partially-implements: blueprint allow-mac-to-be-updated"},{"line_number":20,"context_line":"DocImpact: minor port update api change"},{"line_number":21,"context_line":"Change-Id: I1864c0882cda7eddc9ced519ed3f96c91b2b63f3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":24,"id":"5a890539_714b1987","line":20,"in_reply_to":"5a890539_87b3fe98","updated":"2014-11-24 23:40:02.000000000","message":"Done","commit_id":"53f751dbb3ac0668448190b360cf9d2ca2590f30"}],"neutron/api/v2/attributes.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                           \u0027default\u0027: True,"},{"line_number":659,"context_line":"                           \u0027convert_to\u0027: convert_to_boolean,"},{"line_number":660,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":661,"context_line":"        \u0027mac_address\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":662,"context_line":"                        \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":663,"context_line":"                        \u0027validate\u0027: {\u0027type:mac_address\u0027: None},"},{"line_number":664,"context_line":"                        \u0027enforce_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_cf76923f","line":661,"updated":"2014-09-16 15:29:25.000000000","message":"this is changing the API. But I guess the fact that we are still backwards compatible is OK.","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":658,"context_line":"                           \u0027default\u0027: True,"},{"line_number":659,"context_line":"                           \u0027convert_to\u0027: convert_to_boolean,"},{"line_number":660,"context_line":"                           \u0027is_visible\u0027: True},"},{"line_number":661,"context_line":"        \u0027mac_address\u0027: {\u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":662,"context_line":"                        \u0027default\u0027: ATTR_NOT_SPECIFIED,"},{"line_number":663,"context_line":"                        \u0027validate\u0027: {\u0027type:mac_address\u0027: None},"},{"line_number":664,"context_line":"                        \u0027enforce_policy\u0027: True,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_4f1b8280","line":661,"in_reply_to":"fa98f980_cf76923f","updated":"2014-09-18 06:30:19.000000000","message":"yes, that\u0027s the entire issue!","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"}],"neutron/common/exceptions.py":[{"author":{"_account_id":6502,"name":"Andrey Epifanov","email":"aepifanov@mirantis.com","username":"aepifanov"},"change_message_id":"dc253e021f6473fb563d9b17caff1265c4225448","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"class PortBound(InUse):"},{"line_number":132,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":133,"context_line":"                \"port must not be bound, port use: %(vif_type)s\")"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class MacAddressInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_a484485e","line":133,"updated":"2014-10-17 11:59:24.000000000","message":"Could you please add dot at the EOM.","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"class PortBound(InUse):"},{"line_number":132,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":133,"context_line":"                \"port must not be bound, port use: %(vif_type)s\")"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class MacAddressInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_3294ee36","line":133,"in_reply_to":"baa201ad_a484485e","updated":"2014-10-18 01:17:33.000000000","message":"Done","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":6502,"name":"Andrey Epifanov","email":"aepifanov@mirantis.com","username":"aepifanov"},"change_message_id":"dc253e021f6473fb563d9b17caff1265c4225448","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class UnsupportedPortDeviceOwner(BadRequest):"},{"line_number":216,"context_line":"    message \u003d _(\"Operation %(op)s is not supported for device_owner \""},{"line_number":217,"context_line":"                \"%(device_owner)s on port %(port_id)s\")"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"class OverlappingAllocationPools(Conflict):"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_c4878c5f","line":217,"updated":"2014-10-17 11:59:24.000000000","message":"Same comment as L133","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":214,"context_line":""},{"line_number":215,"context_line":"class UnsupportedPortDeviceOwner(BadRequest):"},{"line_number":216,"context_line":"    message \u003d _(\"Operation %(op)s is not supported for device_owner \""},{"line_number":217,"context_line":"                \"%(device_owner)s on port %(port_id)s\")"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"class OverlappingAllocationPools(Conflict):"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_5299726d","line":217,"in_reply_to":"baa201ad_c4878c5f","updated":"2014-10-18 01:17:33.000000000","message":"Done","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"7d1fea9140d5c131feecc816821f18278b62e942","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"class PortBound(InUse):"},{"line_number":132,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":133,"context_line":"                \"port must not be bound, port use: %(vif_type)s.\")"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class MacAddressInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_58029fb4","line":133,"updated":"2014-10-27 17:17:39.000000000","message":"\u0027port use: \u003ctype\u003e\u0027 seems grammatically incorrect to me.\n\nMaybe \u0027port type is: %s\u0027?","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7aa18b2358b3ef6205913c9fdfb75e7b6fd724ab","unresolved":false,"context_lines":[{"line_number":130,"context_line":""},{"line_number":131,"context_line":"class PortBound(InUse):"},{"line_number":132,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":133,"context_line":"                \"port must not be bound, port use: %(vif_type)s.\")"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"class MacAddressInUse(InUse):"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_3bc0392a","line":133,"in_reply_to":"9aa7fdbe_58029fb4","updated":"2014-11-19 01:12:26.000000000","message":"Done","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c0cdd251e291aa5732fdb4b63637ea58e371f83b","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    message \u003d _(\"The allocation pool %(pool)s is not valid.\")"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"class UnsupportedPortDeviceOwner(BadRequest):"},{"line_number":213,"context_line":"    message \u003d _(\"Operation %(op)s is not supported for device_owner \""},{"line_number":214,"context_line":"                \"%(device_owner)s on port %(port_id)s.\")"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a961159_3af448ce","line":212,"updated":"2014-12-18 17:58:20.000000000","message":"I don\u0027t trunk bad request is appropriate here, 400 is for an input error. Whereas here the error has more to do with the state of the resource. Perhaps \u0027Conflict\u0027 would be more appropriate. Let\u0027s get someone else to chime in.","commit_id":"78f59a5378b7c0646af45d7e045f6de913d1a466"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"41f76f00366375ec4edbb5dcdf9a9cd63a4c8e11","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    message \u003d _(\"The allocation pool %(pool)s is not valid.\")"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"class UnsupportedPortDeviceOwner(BadRequest):"},{"line_number":213,"context_line":"    message \u003d _(\"Operation %(op)s is not supported for device_owner \""},{"line_number":214,"context_line":"                \"%(device_owner)s on port %(port_id)s.\")"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"3a961159_6d49aa30","line":212,"in_reply_to":"3a961159_3af448ce","updated":"2014-12-19 07:23:24.000000000","message":"Yeah, \u0027Conflict\u0027 does seem better.  Not sure who would be good to help with this.  Maybe Edgar?  I\u0027ll change to conflict for now.","commit_id":"78f59a5378b7c0646af45d7e045f6de913d1a466"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"4dc0e41bffbdd171cde2dc831c7b8d06c3a99315","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                \"device %(device_id)s.\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class PortBound(InUse):"},{"line_number":128,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":129,"context_line":"                \"port must not be bound, port type: %(vif_type)s, \""},{"line_number":130,"context_line":"                \"old_mac %(old_mac)s, new_mac %(new_mac)s\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"3a961159_96a1c297","line":127,"updated":"2014-12-31 11:01:18.000000000","message":"Why do we need a new exception? It seems we can use PortInUse exception","commit_id":"1c54393b85d82d8697bad1aeacdc5523d8c0a31b"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ec22e10ca77c9174a2c0aaa9f270ddd823f58fab","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                \"device %(device_id)s.\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class PortBound(InUse):"},{"line_number":128,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":129,"context_line":"                \"port must not be bound, port type: %(vif_type)s, \""},{"line_number":130,"context_line":"                \"old_mac %(old_mac)s, new_mac %(new_mac)s\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"1a930d6b_a0716079","line":127,"in_reply_to":"3a961159_177e6ce4","updated":"2015-01-21 00:41:18.000000000","message":"Cedric and I had an offline conversation about this where I agreed that in principle, the exceptions related the same problem, an already used port.  However, I\u0027ve changed my mind about this.\n\nUnfortunately, in order to provide helpful error messages for users, I now think we need both exceptions.  PortInUse is used when adding an interface to a router and must log device_id and net_id, while PortBound is used in ml2/plugin.py when the back-end has brought up the port and must log binding.vif_type.  I think there are differences here because a router port is quite different from other ports as regards how we know it\u0027s in use, because how it is placed in use is different.  If router ports used the portbindings extension like other ports, this issue would probably not exist.\n\nBTW, there is also an L3PortInUse exception, which is thrown if an l3 port being deleted has fixed_ips.\n\nBottom line, I feel that no single exception suffices given the existing code paths for making a port \"in use\".","commit_id":"1c54393b85d82d8697bad1aeacdc5523d8c0a31b"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"06406a0db61173191464e1df4fa2e4a875f28950","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                \"device %(device_id)s.\")"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class PortBound(InUse):"},{"line_number":128,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":129,"context_line":"                \"port must not be bound, port type: %(vif_type)s, \""},{"line_number":130,"context_line":"                \"old_mac %(old_mac)s, new_mac %(new_mac)s\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"3a961159_177e6ce4","line":127,"in_reply_to":"3a961159_96a1c297","updated":"2015-01-14 22:33:05.000000000","message":"Sorry it took so long to reply (my extended vacation).\n\nI believe that device_id is assigned in the api, so at least for a while, it can be assigned to an unbound port.  I think it\u0027s also theoretically possible to bind a port without a device_id, though I don\u0027t know if any back-ends support that.  So I separated the 2 concepts.\n\nI\u0027m ok removing this and using PortInUse if that\u0027s an unnecessary distinction.","commit_id":"1c54393b85d82d8697bad1aeacdc5523d8c0a31b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"ed39198754501961ccb9c4179681f795309fd582","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class PortBound(InUse):"},{"line_number":128,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":129,"context_line":"                \"port must not be bound, port type: %(vif_type)s, \""},{"line_number":130,"context_line":"                \"old_mac %(old_mac)s, new_mac %(new_mac)s\")"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3a961159_df8524d0","line":129,"updated":"2014-12-31 06:02:55.000000000","message":"Nit: I think \"port already bound,\" sounds better.","commit_id":"1c54393b85d82d8697bad1aeacdc5523d8c0a31b"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"06406a0db61173191464e1df4fa2e4a875f28950","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"class PortBound(InUse):"},{"line_number":128,"context_line":"    message \u003d _(\"Unable to complete operation on port %(port_id)s, \""},{"line_number":129,"context_line":"                \"port must not be bound, port type: %(vif_type)s, \""},{"line_number":130,"context_line":"                \"old_mac %(old_mac)s, new_mac %(new_mac)s\")"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3a961159_7753306c","line":129,"in_reply_to":"3a961159_df8524d0","updated":"2015-01-14 22:33:05.000000000","message":"Done","commit_id":"1c54393b85d82d8697bad1aeacdc5523d8c0a31b"}],"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"dba169f89ef3f5858fa9f57b127f3dfddf66348b","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1355,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1356,"context_line":"                        device_owner\u003dcurrent_device_owner)"},{"line_number":1357,"context_line":"                if port[\u0027status\u0027] \u003d\u003d constants.PORT_STATUS_ACTIVE:"},{"line_number":1358,"context_line":"                    raise n_exc.StateInvalid(port_state\u003dport[\u0027status\u0027])"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"            # Check if the IPs need to be updated"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa98f980_d2bc8409","line":1357,"updated":"2014-09-06 12:39:32.000000000","message":"This checks if port is operational , but not if it\u0027s plugged. I think that with regards to ml2 plugin, you can verify binding:vif_type value. If the value is not set or it\u0027s binding_failed, this means that port is not bound.","commit_id":"0c52a5e7a39c17398765570d222c4d90d86e0ec5"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"858f0c86e095661eb3613ee6926ff7279b659d92","unresolved":false,"context_lines":[{"line_number":1354,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1355,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1356,"context_line":"                        device_owner\u003dcurrent_device_owner)"},{"line_number":1357,"context_line":"                if port[\u0027status\u0027] \u003d\u003d constants.PORT_STATUS_ACTIVE:"},{"line_number":1358,"context_line":"                    raise n_exc.StateInvalid(port_state\u003dport[\u0027status\u0027])"},{"line_number":1359,"context_line":""},{"line_number":1360,"context_line":"            # Check if the IPs need to be updated"}],"source_content_type":"text/x-python","patch_set":5,"id":"baa201ad_755fba0f","line":1357,"in_reply_to":"fa98f980_d2bc8409","updated":"2014-11-19 01:12:07.000000000","message":"Done","commit_id":"0c52a5e7a39c17398765570d222c4d90d86e0ec5"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"                if not NeutronDbPluginV2._check_unique_mac(context, network_id,"},{"line_number":1351,"context_line":"                                                           mac):"},{"line_number":1352,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dmac)"},{"line_number":1353,"context_line":"                if not current_device_owner.startswith(\u0027compute:\u0027):"},{"line_number":1354,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1355,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1356,"context_line":"                        device_owner\u003dcurrent_device_owner)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_aff5ce85","line":1353,"updated":"2014-09-16 15:29:25.000000000","message":"why do we want to limit this to the compute nodes?\n\ni will give an example say I am running a DHCP agent in a VMware env. The MAC address on that env for traffic to be sent by the VM should be 00:56:.... At the moment we are unable to set the MAC when a subnet is created. So for this case it might be good to enable one to be able to update that mac (just a thought)","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":1350,"context_line":"                if not NeutronDbPluginV2._check_unique_mac(context, network_id,"},{"line_number":1351,"context_line":"                                                           mac):"},{"line_number":1352,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dmac)"},{"line_number":1353,"context_line":"                if not current_device_owner.startswith(\u0027compute:\u0027):"},{"line_number":1354,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1355,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1356,"context_line":"                        device_owner\u003dcurrent_device_owner)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_92b751f5","line":1353,"in_reply_to":"fa98f980_aff5ce85","updated":"2014-09-18 06:30:19.000000000","message":"Sorry, I\u0027m not completely understanding the situation (don\u0027t know the VMware env very well).  If the desire is simply to be able to change the mac of the interface the DHCP server listens on, then sure, I agree it would be useful.  But I wanted to limit the scope of the fix to address the bug.  If you think a case can be made I\u0027ll start working on it, but I\u0027d prefer to get this merged first, then another review for DHCP.  Sound OK?","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"a422332522e4c076c2164c67ccf31bff948c25d2","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"                if not NeutronDbPluginV2._check_unique_mac(context, network_id,"},{"line_number":1372,"context_line":"                                                           mac):"},{"line_number":1373,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dmac)"},{"line_number":1374,"context_line":"                if not current_device_owner.startswith(\u0027compute:\u0027):"},{"line_number":1375,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1376,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1377,"context_line":"                        device_owner\u003dcurrent_device_owner)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baa201ad_80be02fe","line":1374,"updated":"2014-09-30 07:59:00.000000000","message":"For the unbound port, the device_owner field is not set yet. I would suggest to allow mac update for this case as well.","commit_id":"e03d9325e5f7f4cac5cc57cae29f7fbe923ceb5d"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1bd69e5cd84b3f0589a90f21bf26751ecaa32020","unresolved":false,"context_lines":[{"line_number":1371,"context_line":"                if not NeutronDbPluginV2._check_unique_mac(context, network_id,"},{"line_number":1372,"context_line":"                                                           mac):"},{"line_number":1373,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dmac)"},{"line_number":1374,"context_line":"                if not current_device_owner.startswith(\u0027compute:\u0027):"},{"line_number":1375,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1376,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1377,"context_line":"                        device_owner\u003dcurrent_device_owner)"}],"source_content_type":"text/x-python","patch_set":11,"id":"baa201ad_93cdd368","line":1374,"in_reply_to":"baa201ad_80be02fe","updated":"2014-10-07 19:13:06.000000000","message":"Done","commit_id":"e03d9325e5f7f4cac5cc57cae29f7fbe923ceb5d"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"84dc05ca4ebfa4e5bbd70c4ed688947fb77d26ed","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1377,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1378,"context_line":"                        device_owner\u003dcurrent_device_owner)"},{"line_number":1379,"context_line":"                if port[\u0027status\u0027] \u003d\u003d constants.PORT_STATUS_ACTIVE:"},{"line_number":1380,"context_line":"                    raise n_exc.StateInvalid(port_state\u003dport[\u0027status\u0027])"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"            # Check if the IPs need to be updated"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_b95e95e7","line":1379,"updated":"2014-10-14 12:27:43.000000000","message":"there may be some drivers that the port is always active. why do we need this test?","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":1376,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1377,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1378,"context_line":"                        device_owner\u003dcurrent_device_owner)"},{"line_number":1379,"context_line":"                if port[\u0027status\u0027] \u003d\u003d constants.PORT_STATUS_ACTIVE:"},{"line_number":1380,"context_line":"                    raise n_exc.StateInvalid(port_state\u003dport[\u0027status\u0027])"},{"line_number":1381,"context_line":""},{"line_number":1382,"context_line":"            # Check if the IPs need to be updated"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_122b6aec","line":1379,"in_reply_to":"baa201ad_b95e95e7","updated":"2014-10-18 01:17:33.000000000","message":"yep, I think the individual plugins can deal with this.  Removed.","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a0cbe99464c1dc74486d0bab128fda291e0dac7f","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"                if not NeutronDbPluginV2._check_unique_mac(context, network_id,"},{"line_number":1397,"context_line":"                                                           mac):"},{"line_number":1398,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dmac)"},{"line_number":1399,"context_line":"                if (current_device_owner and"},{"line_number":1400,"context_line":"                    not current_device_owner.startswith(\u0027compute:\u0027)):"},{"line_number":1401,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1402,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_db0e0432","line":1399,"updated":"2014-10-22 08:00:30.000000000","message":"When owner \u003d \u0027\u0027 (empty string), is it allowed to change mac address?","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"fa10865c58dddc90a89339b8962c842005c3075e","unresolved":false,"context_lines":[{"line_number":1396,"context_line":"                if not NeutronDbPluginV2._check_unique_mac(context, network_id,"},{"line_number":1397,"context_line":"                                                           mac):"},{"line_number":1398,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dmac)"},{"line_number":1399,"context_line":"                if (current_device_owner and"},{"line_number":1400,"context_line":"                    not current_device_owner.startswith(\u0027compute:\u0027)):"},{"line_number":1401,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1402,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_3e3d22bc","line":1399,"in_reply_to":"9aa7fdbe_db0e0432","updated":"2014-10-23 00:53:47.000000000","message":"Yes, I believe that is safe, since the port is unused if that is true.  Am I missing something?","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"7d1fea9140d5c131feecc816821f18278b62e942","unresolved":false,"context_lines":[{"line_number":1390,"context_line":"                    context, p, port[\u0027tenant_id\u0027], port)"},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"            network_id \u003d port[\u0027network_id\u0027]"},{"line_number":1393,"context_line":"            mac \u003d p.get(\u0027mac_address\u0027)"},{"line_number":1394,"context_line":"            if mac and mac !\u003d port[\u0027mac_address\u0027]:"},{"line_number":1395,"context_line":"                # Ensure that the mac on the network is unique"},{"line_number":1396,"context_line":"                if not NeutronDbPluginV2._check_unique_mac(context, network_id,"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_982fa73e","line":1393,"updated":"2014-10-27 17:17:39.000000000","message":"nit: rename \u0027mac\u0027 to \u0027new_mac\u0027 (as opposed to \u0027old_mac\u0027)? not a must..","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7aa18b2358b3ef6205913c9fdfb75e7b6fd724ab","unresolved":false,"context_lines":[{"line_number":1390,"context_line":"                    context, p, port[\u0027tenant_id\u0027], port)"},{"line_number":1391,"context_line":""},{"line_number":1392,"context_line":"            network_id \u003d port[\u0027network_id\u0027]"},{"line_number":1393,"context_line":"            mac \u003d p.get(\u0027mac_address\u0027)"},{"line_number":1394,"context_line":"            if mac and mac !\u003d port[\u0027mac_address\u0027]:"},{"line_number":1395,"context_line":"                # Ensure that the mac on the network is unique"},{"line_number":1396,"context_line":"                if not NeutronDbPluginV2._check_unique_mac(context, network_id,"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_fb2151fd","line":1393,"in_reply_to":"9aa7fdbe_982fa73e","updated":"2014-11-19 01:12:26.000000000","message":"Done","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"6d8bc305c6a4047a5798eb06935cdf750c1723a8","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"                                                           new_mac):"},{"line_number":1407,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dnew_mac)"},{"line_number":1408,"context_line":"                if (current_device_owner and"},{"line_number":1409,"context_line":"                    not current_device_owner.startswith(\u0027compute:\u0027)):"},{"line_number":1410,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1411,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1412,"context_line":"                        device_owner\u003dcurrent_device_owner)"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a890539_36143ae8","line":1409,"updated":"2014-11-24 12:32:54.000000000","message":"i would prefer you use the condition:\n\n  current_device_owner and device_owner.startswith(\u0027network:\u0027)\n\nbecause we should not consider nova to be the only one to use neutron.","commit_id":"53f751dbb3ac0668448190b360cf9d2ca2590f30"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"43550c60958690c0eb3a699c54f010bcf44e1e1c","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"                                                           new_mac):"},{"line_number":1407,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dnew_mac)"},{"line_number":1408,"context_line":"                if (current_device_owner and"},{"line_number":1409,"context_line":"                    not current_device_owner.startswith(\u0027compute:\u0027)):"},{"line_number":1410,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1411,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1412,"context_line":"                        device_owner\u003dcurrent_device_owner)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a961159_58e8a316","line":1409,"in_reply_to":"3a961159_4230bb07","updated":"2014-12-16 08:28:09.000000000","message":"When i see such condition, i am asking myself why we should limit such feature to compute ports instead of limiting it to non-neutron ports.\n\nBut my main concern is that neutron as a service should avoid as much as possible to assume how it will be used: looking for \u0027compute:\u0027 implies an assumption on how neutron will be used where looking for \u0027network:\u0027 does not.\n\nFinally could we ensure nova will use only \"compute:.*\" pattern?","commit_id":"53f751dbb3ac0668448190b360cf9d2ca2590f30"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"9b1c0e04b55eee8f31c03671030962a34e91a82e","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"                                                           new_mac):"},{"line_number":1407,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dnew_mac)"},{"line_number":1408,"context_line":"                if (current_device_owner and"},{"line_number":1409,"context_line":"                    not current_device_owner.startswith(\u0027compute:\u0027)):"},{"line_number":1410,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1411,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1412,"context_line":"                        device_owner\u003dcurrent_device_owner)"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a890539_d1b20de4","line":1409,"in_reply_to":"5a890539_36143ae8","updated":"2014-11-24 23:40:02.000000000","message":"Done","commit_id":"53f751dbb3ac0668448190b360cf9d2ca2590f30"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"5f9a3be8e98ce57ae3c2a0f6cf0e0fa99d545d37","unresolved":false,"context_lines":[{"line_number":1406,"context_line":"                                                           new_mac):"},{"line_number":1407,"context_line":"                    raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dnew_mac)"},{"line_number":1408,"context_line":"                if (current_device_owner and"},{"line_number":1409,"context_line":"                    not current_device_owner.startswith(\u0027compute:\u0027)):"},{"line_number":1410,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1411,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1412,"context_line":"                        device_owner\u003dcurrent_device_owner)"}],"source_content_type":"text/x-python","patch_set":24,"id":"3a961159_4230bb07","line":1409,"in_reply_to":"5a890539_d1b20de4","updated":"2014-12-16 00:30:49.000000000","message":"Cedric, I\u0027m having second thoughts about this one.  If we limit to compute, then it will be straightforward to add the appropriate testing.  We can always add other scenarios later, with the required testing.  Also, the approved spec is pretty clear about compute only.\n\nWhat do you think?","commit_id":"53f751dbb3ac0668448190b360cf9d2ca2590f30"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"170555a2d22ab902ab906ed01b77a05b3f2b8f98","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"                if (current_device_owner and"},{"line_number":1409,"context_line":"                    current_device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1410,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1411,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1412,"context_line":"                        device_owner\u003dcurrent_device_owner)"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"            # Check if the IPs need to be updated"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_b47932fe","line":1411,"updated":"2014-12-18 16:07:33.000000000","message":"this should be translated. that is op\u003d_(\"mac address update)\nthat can be done in another patch set","commit_id":"5bbe84cab7466c12b7deefc9669eb11775d75713"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"eb88c61a5db812a99994b53688c42df2edfd696c","unresolved":false,"context_lines":[{"line_number":1408,"context_line":"                if (current_device_owner and"},{"line_number":1409,"context_line":"                    current_device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1410,"context_line":"                    raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1411,"context_line":"                        op\u003d\"mac address update\", port_id\u003did,"},{"line_number":1412,"context_line":"                        device_owner\u003dcurrent_device_owner)"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"            # Check if the IPs need to be updated"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_6f4e17c3","line":1411,"in_reply_to":"3a961159_b47932fe","updated":"2014-12-18 16:34:25.000000000","message":"Done","commit_id":"5bbe84cab7466c12b7deefc9669eb11775d75713"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c0cdd251e291aa5732fdb4b63637ea58e371f83b","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"                self._enforce_device_owner_not_router_intf_or_device_id("},{"line_number":1396,"context_line":"                    context, p, port[\u0027tenant_id\u0027], port)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"            network_id \u003d port[\u0027network_id\u0027]"},{"line_number":1399,"context_line":"            new_mac \u003d p.get(\u0027mac_address\u0027)"},{"line_number":1400,"context_line":"            if new_mac and new_mac !\u003d port[\u0027mac_address\u0027]:"},{"line_number":1401,"context_line":"                # Ensure that the mac on the network is unique"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a961159_fae000fc","line":1398,"updated":"2014-12-18 17:58:20.000000000","message":"let\u0027s avoid duplicating code or making methods even longer than what they already are: please consider moving this logic/refactor this method so that this addition is easier to test, read and maintain","commit_id":"78f59a5378b7c0646af45d7e045f6de913d1a466"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"41f76f00366375ec4edbb5dcdf9a9cd63a4c8e11","unresolved":false,"context_lines":[{"line_number":1395,"context_line":"                self._enforce_device_owner_not_router_intf_or_device_id("},{"line_number":1396,"context_line":"                    context, p, port[\u0027tenant_id\u0027], port)"},{"line_number":1397,"context_line":""},{"line_number":1398,"context_line":"            network_id \u003d port[\u0027network_id\u0027]"},{"line_number":1399,"context_line":"            new_mac \u003d p.get(\u0027mac_address\u0027)"},{"line_number":1400,"context_line":"            if new_mac and new_mac !\u003d port[\u0027mac_address\u0027]:"},{"line_number":1401,"context_line":"                # Ensure that the mac on the network is unique"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a961159_8d48965d","line":1398,"in_reply_to":"3a961159_fae000fc","updated":"2014-12-19 07:23:24.000000000","message":"ok, just moved the logic.","commit_id":"78f59a5378b7c0646af45d7e045f6de913d1a466"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"5c6068a2b9cd008019f067d04cc3d28a4c48574e","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"        return self._get_collection_count(context, models_v2.Subnet,"},{"line_number":1277,"context_line":"                                          filters\u003dfilters)"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    def _enforce_unique_mac(self, context, network_id, mac):"},{"line_number":1280,"context_line":"        # Ensure that the mac on the network is unique"},{"line_number":1281,"context_line":"        if not NeutronDbPluginV2._check_unique_mac(context, network_id, mac):"},{"line_number":1282,"context_line":"            raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dmac)"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a930d6b_9b07fbc9","line":1279,"updated":"2015-01-23 18:48:47.000000000","message":"mac uniqueness per network is now ensured by a db unique constraint[1].\n\n[1] https://review.openstack.org/146404","commit_id":"54c1d245d91210715dd173fd19b5bb2db3b5ca40"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1b23d93ae356cbefddc07deac9a0a9718f172929","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"        return self._get_collection_count(context, models_v2.Subnet,"},{"line_number":1277,"context_line":"                                          filters\u003dfilters)"},{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    def _enforce_unique_mac(self, context, network_id, mac):"},{"line_number":1280,"context_line":"        # Ensure that the mac on the network is unique"},{"line_number":1281,"context_line":"        if not NeutronDbPluginV2._check_unique_mac(context, network_id, mac):"},{"line_number":1282,"context_line":"            raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dmac)"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a930d6b_48284786","line":1279,"in_reply_to":"1a930d6b_9b07fbc9","updated":"2015-01-26 10:31:27.000000000","message":"Cedric, I\u0027m having some trouble removing this test without having problems with \u0027a nested rollback call\u0027.  Could I get some of your time to help me understand what is going on and how to handle the DBDuplicateEntry exception properly in the update case?","commit_id":"54c1d245d91210715dd173fd19b5bb2db3b5ca40"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b8dbf370345d5e464629ef055e617a3b189ca89b","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return utils.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @staticmethod"},{"line_number":128,"context_line":"    def _check_unique_mac(context, network_id, mac_address):"},{"line_number":129,"context_line":"        mac_qry \u003d context.session.query(models_v2.Port)"},{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            mac_qry.filter_by(network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_f476c505","line":128,"updated":"2015-01-27 22:27:01.000000000","message":"This method is never used.","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7ec2207f0aefb7fc0862b30abfb456a7298a2d22","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        return utils.get_random_mac(cfg.CONF.base_mac.split(\u0027:\u0027))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @staticmethod"},{"line_number":128,"context_line":"    def _check_unique_mac(context, network_id, mac_address):"},{"line_number":129,"context_line":"        mac_qry \u003d context.session.query(models_v2.Port)"},{"line_number":130,"context_line":"        try:"},{"line_number":131,"context_line":"            mac_qry.filter_by(network_id\u003dnetwork_id,"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_2f2fdbf7","line":128,"in_reply_to":"fa81d914_f476c505","updated":"2015-01-29 06:46:43.000000000","message":"Done","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"52d786e6e705a36450599dcc6f3b404c47e04f67","unresolved":false,"context_lines":[{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1280,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1281,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1282,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"},{"line_number":1283,"context_line":"                device_owner\u003ddevice_owner)"},{"line_number":1284,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_810149b1","line":1281,"updated":"2015-01-30 05:02:23.000000000","message":"question, why is this limitation neccesary?, is there a good reason?.\nIn some network configurations I would have found beneficial being able\nto change a network device port (router) to match an specific provided virtual\nmac address.\n\nI understand such change may need to be propagated to the routers, but,\nthat could be done as a follow up.","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"a5004cfd6fcf922dd60e5dd7be658bf38cd81f8b","unresolved":false,"context_lines":[{"line_number":1278,"context_line":""},{"line_number":1279,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1280,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1281,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1282,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"},{"line_number":1283,"context_line":"                device_owner\u003ddevice_owner)"},{"line_number":1284,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_b5e2072d","line":1281,"in_reply_to":"fa81d914_810149b1","updated":"2015-01-30 08:04:01.000000000","message":"The only reason was to limit the scope of this patch, which matches the scope of the spec, which is what I thought was important to cover at the time.  If you have other use cases, and I think Gary did as well, maybe we could have a quick discussion.","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":8124,"name":"cbrandily","email":"zzelle@gmail.com","username":"cbrandily"},"change_message_id":"8a13100048b4474e019d3600bea14fdbb5820008","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"            # Remove all attributes in p which are not in the port DB model"},{"line_number":1406,"context_line":"            # and then update the port"},{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                port.update(self._filter_non_model_columns(p, models_v2.Port))"},{"line_number":1409,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":1410,"context_line":"                raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dnew_mac)"},{"line_number":1411,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_b756b6d0","line":1408,"updated":"2015-01-29 13:06:13.000000000","message":"DBDuplicateEntry is not raised when port.update is called but when the transaction is commited (done during with context __exit__).\n\nSo the try/except must embed the with context (L1366) or  context.session.flush must be called after port.update.","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"6555b280dbb207df2b3a7348176b2ccd0e0432ac","unresolved":false,"context_lines":[{"line_number":1405,"context_line":"            # Remove all attributes in p which are not in the port DB model"},{"line_number":1406,"context_line":"            # and then update the port"},{"line_number":1407,"context_line":"            try:"},{"line_number":1408,"context_line":"                port.update(self._filter_non_model_columns(p, models_v2.Port))"},{"line_number":1409,"context_line":"            except db_exc.DBDuplicateEntry:"},{"line_number":1410,"context_line":"                raise n_exc.MacAddressInUse(net_id\u003dnetwork_id, mac\u003dnew_mac)"},{"line_number":1411,"context_line":""}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_c8b1aee2","line":1408,"in_reply_to":"fa81d914_b756b6d0","updated":"2015-01-29 23:03:34.000000000","message":"Done","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"1562ba014ceed432f1ecc9966225438a37c95bc6","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"                                          filters\u003dfilters)"},{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1280,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1281,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"},{"line_number":1282,"context_line":"                device_owner\u003ddevice_owner)"}],"source_content_type":"text/x-python","patch_set":38,"id":"da86d52c_0bc40b3f","line":1279,"updated":"2015-02-01 05:08:48.000000000","message":"I think this guards against any port updates which would affect the L3 agent.","commit_id":"cf99eb988e05c56d3842ac388dfe9ada5aa8af86"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"b6a403768f37a3e371e4c2013ad6471b1e4b55f7","unresolved":false,"context_lines":[{"line_number":1276,"context_line":"                                          filters\u003dfilters)"},{"line_number":1277,"context_line":""},{"line_number":1278,"context_line":"    def _check_mac_addr_update(self, context, port, new_mac, device_owner):"},{"line_number":1279,"context_line":"        if (device_owner and device_owner.startswith(\u0027network:\u0027)):"},{"line_number":1280,"context_line":"            raise n_exc.UnsupportedPortDeviceOwner("},{"line_number":1281,"context_line":"                op\u003d_(\"mac address update\"), port_id\u003did,"},{"line_number":1282,"context_line":"                device_owner\u003ddevice_owner)"}],"source_content_type":"text/x-python","patch_set":38,"id":"da86d52c_1a60c531","line":1279,"in_reply_to":"da86d52c_0bc40b3f","updated":"2015-02-02 09:32:38.000000000","message":"correct.","commit_id":"cf99eb988e05c56d3842ac388dfe9ada5aa8af86"}],"neutron/plugins/ml2/drivers/brocade/mechanism_brocade.py":[{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"fb42235dd26db4e502e5caa69b7587eba3ff019d","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                                   \"update_port_postcommit\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        LOG.info("},{"line_number":370,"context_line":"            _(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":371,"context_line":"              \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s\"),"},{"line_number":372,"context_line":"            {\u0027port_id\u0027: port_id,"},{"line_number":373,"context_line":"             \u0027network_id\u0027: network_id, \u0027tenant_id\u0027: tenant_id})"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_eeab4387","line":370,"updated":"2014-09-01 10:34:58.000000000","message":"nit: _LI","commit_id":"aa2d9e47aed3370316f100f0a38606684eef707e"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"8ba8443fb89116a192f643087263c2adfbc1b9f5","unresolved":false,"context_lines":[{"line_number":367,"context_line":"                                   \"update_port_postcommit\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        LOG.info("},{"line_number":370,"context_line":"            _(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":371,"context_line":"              \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s\"),"},{"line_number":372,"context_line":"            {\u0027port_id\u0027: port_id,"},{"line_number":373,"context_line":"             \u0027network_id\u0027: network_id, \u0027tenant_id\u0027: tenant_id})"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_cca79c09","line":370,"in_reply_to":"fa98f980_eeab4387","updated":"2014-09-05 20:52:01.000000000","message":"Done","commit_id":"aa2d9e47aed3370316f100f0a38606684eef707e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            raise Exception("},{"line_number":152,"context_line":"                _(\"Brocade Mechanism: create_network_precommit failed\"))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        LOG.info(_LI(\"create network (precommit): %(network_id)s \""},{"line_number":155,"context_line":"                     \"of network type \u003d %(network_type)s \""},{"line_number":156,"context_line":"                     \"with vlan \u003d %(vlan_id)s \""},{"line_number":157,"context_line":"                     \"for tenant %(tenant_id)s\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_0f1b3acb","line":154,"updated":"2014-09-16 15:29:25.000000000","message":"this is not related to this patch set","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":151,"context_line":"            raise Exception("},{"line_number":152,"context_line":"                _(\"Brocade Mechanism: create_network_precommit failed\"))"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        LOG.info(_LI(\"create network (precommit): %(network_id)s \""},{"line_number":155,"context_line":"                     \"of network type \u003d %(network_type)s \""},{"line_number":156,"context_line":"                     \"with vlan \u003d %(vlan_id)s \""},{"line_number":157,"context_line":"                     \"for tenant %(tenant_id)s\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_d2f2b99a","line":154,"in_reply_to":"fa98f980_0f1b3acb","updated":"2014-09-18 06:30:19.000000000","message":"question: Is the reason for not making the file consistent that we\u0027re late in the release now, or is it general policy to be strict about only fixing what the bug complains about?\n\nDone.","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            raise Exception("},{"line_number":189,"context_line":"                _(\"Brocade Mechanism: create_network_postcommmit failed\"))"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        LOG.info(_LI(\"created network (postcommit): %(network_id)s\""},{"line_number":192,"context_line":"                     \" of network type \u003d %(network_type)s\""},{"line_number":193,"context_line":"                     \" with vlan \u003d %(vlan_id)s\""},{"line_number":194,"context_line":"                     \" for tenant %(tenant_id)s\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_2f771e0a","line":191,"updated":"2014-09-16 15:29:25.000000000","message":"ditto","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":188,"context_line":"            raise Exception("},{"line_number":189,"context_line":"                _(\"Brocade Mechanism: create_network_postcommmit failed\"))"},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"        LOG.info(_LI(\"created network (postcommit): %(network_id)s\""},{"line_number":192,"context_line":"                     \" of network type \u003d %(network_type)s\""},{"line_number":193,"context_line":"                     \" with vlan \u003d %(vlan_id)s\""},{"line_number":194,"context_line":"                     \" for tenant %(tenant_id)s\"),"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_928671da","line":191,"in_reply_to":"fa98f980_2f771e0a","updated":"2014-09-18 06:30:19.000000000","message":"Done","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            raise Exception("},{"line_number":218,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        LOG.info(_LI(\"delete network (precommit): %(network_id)s\""},{"line_number":221,"context_line":"                     \" with vlan \u003d %(vlan_id)s\""},{"line_number":222,"context_line":"                     \" for tenant %(tenant_id)s\"),"},{"line_number":223,"context_line":"                 {\u0027network_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_6f8126c3","line":220,"updated":"2014-09-16 15:29:25.000000000","message":"ditto","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            raise Exception("},{"line_number":218,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"        LOG.info(_LI(\"delete network (precommit): %(network_id)s\""},{"line_number":221,"context_line":"                     \" with vlan \u003d %(vlan_id)s\""},{"line_number":222,"context_line":"                     \" for tenant %(tenant_id)s\"),"},{"line_number":223,"context_line":"                 {\u0027network_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_d24e39c2","line":220,"in_reply_to":"fa98f980_6f8126c3","updated":"2014-09-18 06:30:19.000000000","message":"Done","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                _(\"Brocade switch exception, \""},{"line_number":247,"context_line":"                  \"delete_network_postcommit failed\"))"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        LOG.info(_LI(\"delete network (postcommit): %(network_id)s\""},{"line_number":250,"context_line":"                     \" with vlan \u003d %(vlan_id)s\""},{"line_number":251,"context_line":"                     \" for tenant %(tenant_id)s\"),"},{"line_number":252,"context_line":"                 {\u0027network_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_ef743600","line":249,"updated":"2014-09-16 15:29:25.000000000","message":"ditto","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                _(\"Brocade switch exception, \""},{"line_number":247,"context_line":"                  \"delete_network_postcommit failed\"))"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"        LOG.info(_LI(\"delete network (postcommit): %(network_id)s\""},{"line_number":250,"context_line":"                     \" with vlan \u003d %(vlan_id)s\""},{"line_number":251,"context_line":"                     \" for tenant %(tenant_id)s\"),"},{"line_number":252,"context_line":"                 {\u0027network_id\u0027: network_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_726bcdf1","line":249,"in_reply_to":"fa98f980_ef743600","updated":"2014-09-18 06:30:19.000000000","message":"Done","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                                   \"create_port_postcommit\")"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        LOG.info("},{"line_number":305,"context_line":"            _LI(\"created port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":306,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s\"),"},{"line_number":307,"context_line":"            {\u0027port_id\u0027: port_id,"},{"line_number":308,"context_line":"             \u0027network_id\u0027: network_id, \u0027tenant_id\u0027: tenant_id})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_0f725a11","line":305,"updated":"2014-09-16 15:29:25.000000000","message":"ditto","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":302,"context_line":"                                   \"create_port_postcommit\")"},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"        LOG.info("},{"line_number":305,"context_line":"            _LI(\"created port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":306,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s\"),"},{"line_number":307,"context_line":"            {\u0027port_id\u0027: port_id,"},{"line_number":308,"context_line":"             \u0027network_id\u0027: network_id, \u0027tenant_id\u0027: tenant_id})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_32614512","line":305,"in_reply_to":"fa98f980_0f725a11","updated":"2014-09-18 06:30:19.000000000","message":"Done","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        LOG.info("},{"line_number":371,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":372,"context_line":"              \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s\"),"},{"line_number":373,"context_line":"            {\u0027port_id\u0027: port_id,"},{"line_number":374,"context_line":"             \u0027network_id\u0027: network_id, \u0027tenant_id\u0027: tenant_id})"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_2f5e3e7a","line":372,"updated":"2014-09-16 15:29:25.000000000","message":"indentation","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":369,"context_line":""},{"line_number":370,"context_line":"        LOG.info("},{"line_number":371,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":372,"context_line":"              \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s\"),"},{"line_number":373,"context_line":"            {\u0027port_id\u0027: port_id,"},{"line_number":374,"context_line":"             \u0027network_id\u0027: network_id, \u0027tenant_id\u0027: tenant_id})"},{"line_number":375,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_f2a7bd4e","line":372,"in_reply_to":"fa98f980_2f5e3e7a","updated":"2014-09-18 06:30:19.000000000","message":"Done","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                                                  mac)"},{"line_number":412,"context_line":"        except Exception:"},{"line_number":413,"context_line":"            LOG.exception("},{"line_number":414,"context_line":"                _(\"Brocade NOS driver: failed to associate mac %s\")"},{"line_number":415,"context_line":"                % interface_mac)"},{"line_number":416,"context_line":"            raise Exception("},{"line_number":417,"context_line":"                _(\"Brocade switch exception: %s failed\") % op)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_4fcaa21b","line":414,"updated":"2014-09-16 15:29:25.000000000","message":"please use a , instead of %","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":411,"context_line":"                                                  mac)"},{"line_number":412,"context_line":"        except Exception:"},{"line_number":413,"context_line":"            LOG.exception("},{"line_number":414,"context_line":"                _(\"Brocade NOS driver: failed to associate mac %s\")"},{"line_number":415,"context_line":"                % interface_mac)"},{"line_number":416,"context_line":"            raise Exception("},{"line_number":417,"context_line":"                _(\"Brocade switch exception: %s failed\") % op)"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_b2ad3535","line":414,"in_reply_to":"fa98f980_4fcaa21b","updated":"2014-09-18 06:30:19.000000000","message":"Done","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                mac)"},{"line_number":433,"context_line":"        except Exception:"},{"line_number":434,"context_line":"            LOG.exception("},{"line_number":435,"context_line":"                _(\"Brocade NOS driver: failed to dissociate MAC %s\") %"},{"line_number":436,"context_line":"                interface_mac)"},{"line_number":437,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"},{"line_number":438,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_eff9964f","line":435,"updated":"2014-09-16 15:29:25.000000000","message":"ditto , instead of % LOG.info(_(.... %s), str)","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                mac)"},{"line_number":433,"context_line":"        except Exception:"},{"line_number":434,"context_line":"            LOG.exception("},{"line_number":435,"context_line":"                _(\"Brocade NOS driver: failed to dissociate MAC %s\") %"},{"line_number":436,"context_line":"                interface_mac)"},{"line_number":437,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"},{"line_number":438,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_92b9117c","line":435,"in_reply_to":"fa98f980_eff9964f","updated":"2014-09-18 06:30:19.000000000","message":"Done","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8cab7186b7af3237c54e2a0e0277273204b9a5e2","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    def update_port_postcommit(self, mech_context):"},{"line_number":350,"context_line":"        \"\"\"If mac changes, update association to network.\"\"\""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        LOG.debug(_(\"update_port_postcommit: called\"))"},{"line_number":353,"context_line":"        port \u003d mech_context.current"},{"line_number":354,"context_line":"        old_port \u003d mech_context.original"},{"line_number":355,"context_line":"        if port[\u0027mac_address\u0027] \u003d\u003d old_port[\u0027mac_address\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_f2888bc8","line":352,"updated":"2014-09-22 13:38:57.000000000","message":"nit: could remove i18n from debug log.","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ee6e7671631e4c0b2b822e83730639d4e0aca2a2","unresolved":false,"context_lines":[{"line_number":349,"context_line":"    def update_port_postcommit(self, mech_context):"},{"line_number":350,"context_line":"        \"\"\"If mac changes, update association to network.\"\"\""},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"        LOG.debug(_(\"update_port_postcommit: called\"))"},{"line_number":353,"context_line":"        port \u003d mech_context.current"},{"line_number":354,"context_line":"        old_port \u003d mech_context.original"},{"line_number":355,"context_line":"        if port[\u0027mac_address\u0027] \u003d\u003d old_port[\u0027mac_address\u0027]:"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_937e60ad","line":352,"in_reply_to":"da9df570_f2888bc8","updated":"2014-09-22 16:06:51.000000000","message":"Done","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8cab7186b7af3237c54e2a0e0277273204b9a5e2","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                                                  mac)"},{"line_number":411,"context_line":"        except Exception:"},{"line_number":412,"context_line":"            LOG.exception("},{"line_number":413,"context_line":"                _(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":414,"context_line":"                interface_mac)"},{"line_number":415,"context_line":"            raise Exception("},{"line_number":416,"context_line":"                _(\"Brocade switch exception: %s failed\") % op)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_52a7974f","line":413,"updated":"2014-09-22 13:38:57.000000000","message":"Should use _LE hint here.","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ee6e7671631e4c0b2b822e83730639d4e0aca2a2","unresolved":false,"context_lines":[{"line_number":410,"context_line":"                                                  mac)"},{"line_number":411,"context_line":"        except Exception:"},{"line_number":412,"context_line":"            LOG.exception("},{"line_number":413,"context_line":"                _(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":414,"context_line":"                interface_mac)"},{"line_number":415,"context_line":"            raise Exception("},{"line_number":416,"context_line":"                _(\"Brocade switch exception: %s failed\") % op)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_73581c57","line":413,"in_reply_to":"da9df570_52a7974f","updated":"2014-09-22 16:06:51.000000000","message":"Done","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8cab7186b7af3237c54e2a0e0277273204b9a5e2","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                mac)"},{"line_number":432,"context_line":"        except Exception:"},{"line_number":433,"context_line":"            LOG.exception("},{"line_number":434,"context_line":"                _(\"Brocade NOS driver: failed to dissociate MAC %s\"),"},{"line_number":435,"context_line":"                interface_mac)"},{"line_number":436,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_5203170f","line":434,"updated":"2014-09-22 13:38:57.000000000","message":"Ditto","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ee6e7671631e4c0b2b822e83730639d4e0aca2a2","unresolved":false,"context_lines":[{"line_number":431,"context_line":"                mac)"},{"line_number":432,"context_line":"        except Exception:"},{"line_number":433,"context_line":"            LOG.exception("},{"line_number":434,"context_line":"                _(\"Brocade NOS driver: failed to dissociate MAC %s\"),"},{"line_number":435,"context_line":"                interface_mac)"},{"line_number":436,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"},{"line_number":437,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_9355801f","line":434,"in_reply_to":"da9df570_5203170f","updated":"2014-09-22 16:06:51.000000000","message":"Done","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bf66d1c351cd4145e9b21f11df6f5490f8b988d2","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                                                  mac)"},{"line_number":408,"context_line":"        except Exception:"},{"line_number":409,"context_line":"            LOG.exception("},{"line_number":410,"context_line":"                _(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":411,"context_line":"                interface_mac)"},{"line_number":412,"context_line":"            raise Exception("},{"line_number":413,"context_line":"                _LE(\"Brocade switch exception: %s failed\") % op)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da9df570_afcccc36","line":410,"updated":"2014-09-22 20:48:42.000000000","message":"Sorry, I wasn\u0027t really clear. Should have _LE() hint on the log message, but use the _() for the actual exception on L413.\n\nSee:  http://docs.openstack.org/developer/oslo.i18n/guidelines.html#log-translation","commit_id":"c86aa65c2baac7767187c4aba68f420c11c25e10"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"2c6e42cca3479d2cdd66c95224edc435b891ec80","unresolved":false,"context_lines":[{"line_number":407,"context_line":"                                                  mac)"},{"line_number":408,"context_line":"        except Exception:"},{"line_number":409,"context_line":"            LOG.exception("},{"line_number":410,"context_line":"                _(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":411,"context_line":"                interface_mac)"},{"line_number":412,"context_line":"            raise Exception("},{"line_number":413,"context_line":"                _LE(\"Brocade switch exception: %s failed\") % op)"}],"source_content_type":"text/x-python","patch_set":9,"id":"da9df570_d5450718","line":410,"in_reply_to":"da9df570_afcccc36","updated":"2014-09-23 19:40:32.000000000","message":"Ugh.  Guess I need new glasses.\n\nDone.","commit_id":"c86aa65c2baac7767187c4aba68f420c11c25e10"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bf66d1c351cd4145e9b21f11df6f5490f8b988d2","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                mac)"},{"line_number":429,"context_line":"        except Exception:"},{"line_number":430,"context_line":"            LOG.exception("},{"line_number":431,"context_line":"                _LE(\"Brocade NOS driver: failed to dissociate MAC %s\"),"},{"line_number":432,"context_line":"                interface_mac)"},{"line_number":433,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da9df570_cfd110cf","line":431,"updated":"2014-09-22 20:48:42.000000000","message":"This one is right.","commit_id":"c86aa65c2baac7767187c4aba68f420c11c25e10"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"2c6e42cca3479d2cdd66c95224edc435b891ec80","unresolved":false,"context_lines":[{"line_number":428,"context_line":"                mac)"},{"line_number":429,"context_line":"        except Exception:"},{"line_number":430,"context_line":"            LOG.exception("},{"line_number":431,"context_line":"                _LE(\"Brocade NOS driver: failed to dissociate MAC %s\"),"},{"line_number":432,"context_line":"                interface_mac)"},{"line_number":433,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"da9df570_ba91479c","line":431,"in_reply_to":"da9df570_cfd110cf","updated":"2014-09-23 19:40:32.000000000","message":"I still need new glasses.","commit_id":"c86aa65c2baac7767187c4aba68f420c11c25e10"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"84dc05ca4ebfa4e5bbd70c4ed688947fb77d26ed","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            raise Exception("},{"line_number":215,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        LOG.info(_(\"delete network (precommit): %(network_id)s\""},{"line_number":218,"context_line":"            \" with vlan \u003d %(vlan_id)s for tenant %(tenant_id)s\"),"},{"line_number":219,"context_line":"                 {\u0027network_id\u0027: network_id,"},{"line_number":220,"context_line":"                  \u0027vlan_id\u0027: vlan_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_d908b9db","line":217,"updated":"2014-10-14 12:27:43.000000000","message":"this should have _LI","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            raise Exception("},{"line_number":215,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        LOG.info(_(\"delete network (precommit): %(network_id)s\""},{"line_number":218,"context_line":"            \" with vlan \u003d %(vlan_id)s for tenant %(tenant_id)s\"),"},{"line_number":219,"context_line":"                 {\u0027network_id\u0027: network_id,"},{"line_number":220,"context_line":"                  \u0027vlan_id\u0027: vlan_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_12952ae4","line":217,"in_reply_to":"baa201ad_96512f32","updated":"2014-10-18 01:17:33.000000000","message":"My own preference is to make changes like this to entire files I touch, but I\u0027ve received complaints about doing this, so I\u0027m now reluctant to do so.","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"7da87a480fd7834b05c54d6528e1228a266cacdc","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            raise Exception("},{"line_number":215,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        LOG.info(_(\"delete network (precommit): %(network_id)s\""},{"line_number":218,"context_line":"            \" with vlan \u003d %(vlan_id)s for tenant %(tenant_id)s\"),"},{"line_number":219,"context_line":"                 {\u0027network_id\u0027: network_id,"},{"line_number":220,"context_line":"                  \u0027vlan_id\u0027: vlan_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_96512f32","line":217,"in_reply_to":"baa201ad_d908b9db","updated":"2014-10-17 17:46:12.000000000","message":"Hi Garyk,\n\nI could see that many reviewers are suggesting to use _LI  but at the same time don\u0027t you think it should be a seperate effort all together in all the neutron files to replace LOG.info(_(\"  \")  with LOG.info(_LI( \"  \").  \n\nsame case applies  to _LW , _LE\n\nBy doing some places in a file doesn\u0027t looks good.\n\nPlease share your thoughts !","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            raise Exception("},{"line_number":215,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        LOG.info(_(\"delete network (precommit): %(network_id)s\""},{"line_number":218,"context_line":"            \" with vlan \u003d %(vlan_id)s for tenant %(tenant_id)s\"),"},{"line_number":219,"context_line":"                 {\u0027network_id\u0027: network_id,"},{"line_number":220,"context_line":"                  \u0027vlan_id\u0027: vlan_id,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_d292c2f5","line":217,"in_reply_to":"baa201ad_d908b9db","updated":"2014-10-18 01:17:33.000000000","message":"I didn\u0027t need to change this at all, so I\u0027ve reverted to original.","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":6502,"name":"Andrey Epifanov","email":"aepifanov@mirantis.com","username":"aepifanov"},"change_message_id":"dc253e021f6473fb563d9b17caff1265c4225448","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        LOG.info(_(\"delete network (precommit): %(network_id)s\""},{"line_number":218,"context_line":"            \" with vlan \u003d %(vlan_id)s for tenant %(tenant_id)s\"),"},{"line_number":219,"context_line":"                 {\u0027network_id\u0027: network_id,"},{"line_number":220,"context_line":"                  \u0027vlan_id\u0027: vlan_id,"},{"line_number":221,"context_line":"                  \u0027tenant_id\u0027: tenant_id})"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_84fca4b6","line":218,"updated":"2014-10-17 11:59:24.000000000","message":"Dot at the EOM","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"84dc05ca4ebfa4e5bbd70c4ed688947fb77d26ed","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        LOG.info(_(\"delete network (precommit): %(network_id)s\""},{"line_number":218,"context_line":"            \" with vlan \u003d %(vlan_id)s for tenant %(tenant_id)s\"),"},{"line_number":219,"context_line":"                 {\u0027network_id\u0027: network_id,"},{"line_number":220,"context_line":"                  \u0027vlan_id\u0027: vlan_id,"},{"line_number":221,"context_line":"                  \u0027tenant_id\u0027: tenant_id})"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_796c2d9d","line":218,"updated":"2014-10-14 12:27:43.000000000","message":"indentation is dodgy","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        LOG.info(_(\"delete network (precommit): %(network_id)s\""},{"line_number":218,"context_line":"            \" with vlan \u003d %(vlan_id)s for tenant %(tenant_id)s\"),"},{"line_number":219,"context_line":"                 {\u0027network_id\u0027: network_id,"},{"line_number":220,"context_line":"                  \u0027vlan_id\u0027: vlan_id,"},{"line_number":221,"context_line":"                  \u0027tenant_id\u0027: tenant_id})"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_12636a1b","line":218,"in_reply_to":"baa201ad_796c2d9d","updated":"2014-10-18 01:17:33.000000000","message":"reverted","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                _(\"Brocade Mechanism: delete_network_precommit failed\"))"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"        LOG.info(_(\"delete network (precommit): %(network_id)s\""},{"line_number":218,"context_line":"            \" with vlan \u003d %(vlan_id)s for tenant %(tenant_id)s\"),"},{"line_number":219,"context_line":"                 {\u0027network_id\u0027: network_id,"},{"line_number":220,"context_line":"                  \u0027vlan_id\u0027: vlan_id,"},{"line_number":221,"context_line":"                  \u0027tenant_id\u0027: tenant_id})"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_32686ef5","line":218,"in_reply_to":"baa201ad_84fca4b6","updated":"2014-10-18 01:17:33.000000000","message":"reverted change","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":6502,"name":"Andrey Epifanov","email":"aepifanov@mirantis.com","username":"aepifanov"},"change_message_id":"dc253e021f6473fb563d9b17caff1265c4225448","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        LOG.info("},{"line_number":367,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":368,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s\"),"},{"line_number":369,"context_line":"            {\u0027port_id\u0027: port_id,"},{"line_number":370,"context_line":"             \u0027network_id\u0027: network_id, \u0027tenant_id\u0027: tenant_id})"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_a42e0841","line":368,"updated":"2014-10-17 11:59:24.000000000","message":"Dot at the EOM","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        LOG.info("},{"line_number":367,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":368,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s\"),"},{"line_number":369,"context_line":"            {\u0027port_id\u0027: port_id,"},{"line_number":370,"context_line":"             \u0027network_id\u0027: network_id, \u0027tenant_id\u0027: tenant_id})"},{"line_number":371,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_92767ad7","line":368,"in_reply_to":"baa201ad_a42e0841","updated":"2014-10-18 01:17:33.000000000","message":"Done","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"170555a2d22ab902ab906ed01b77a05b3f2b8f98","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self._associate_mac_to_net(context, network_id, port[\u0027mac_address\u0027],"},{"line_number":367,"context_line":"                                   \"update_port_postcommit\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        LOG.info("},{"line_number":370,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":371,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s.\"),"},{"line_number":372,"context_line":"            {\u0027port_id\u0027: port_id,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_f4e81a7e","line":369,"updated":"2014-12-18 16:07:33.000000000","message":"i think that we should leave this as a log debug","commit_id":"5bbe84cab7466c12b7deefc9669eb11775d75713"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"f870baadb9e22dc5fd2dd310650ab604a38daf0f","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self._associate_mac_to_net(context, network_id, port[\u0027mac_address\u0027],"},{"line_number":367,"context_line":"                                   \"update_port_postcommit\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        LOG.info("},{"line_number":370,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":371,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s.\"),"},{"line_number":372,"context_line":"            {\u0027port_id\u0027: port_id,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_e1fe9b6a","line":369,"in_reply_to":"3a961159_ef83e7c9","updated":"2014-12-18 16:53:08.000000000","message":"I agree with Gary I should have been debug, however I will lean towards consistency hence log.info is correct. Operator should look for this info (create/delete/update) all in the same log file.","commit_id":"5bbe84cab7466c12b7deefc9669eb11775d75713"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"eb88c61a5db812a99994b53688c42df2edfd696c","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self._associate_mac_to_net(context, network_id, port[\u0027mac_address\u0027],"},{"line_number":367,"context_line":"                                   \"update_port_postcommit\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        LOG.info("},{"line_number":370,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":371,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s.\"),"},{"line_number":372,"context_line":"            {\u0027port_id\u0027: port_id,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_ef83e7c9","line":369,"in_reply_to":"3a961159_f4e81a7e","updated":"2014-12-18 16:34:25.000000000","message":"well, that would leave it inconsistent with create/delete port.  Maybe I\u0027ll let Shiv make the call on this?","commit_id":"5bbe84cab7466c12b7deefc9669eb11775d75713"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c5df7e6ced539a08f2f5a0f2d89a5bc0a93db338","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def _associate_mac_to_net(self, context, network_id, interface_mac, op):"},{"line_number":400,"context_line":"        network \u003d brocade_db.get_network(context, network_id)"},{"line_number":401,"context_line":"        vlan_id \u003d network[\u0027vlan\u0027]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # convert mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":404,"context_line":"        mac \u003d self.mac_reformat_62to34(interface_mac)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_15278ab7","line":401,"updated":"2015-01-22 17:48:04.000000000","message":"nit: probably there\u0027s no need of defining \u0027vlan_id\u0027 since it\u0027s used only once","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"392edd12c76162e9c841d3c9623879ed9653e8a8","unresolved":false,"context_lines":[{"line_number":398,"context_line":""},{"line_number":399,"context_line":"    def _associate_mac_to_net(self, context, network_id, interface_mac, op):"},{"line_number":400,"context_line":"        network \u003d brocade_db.get_network(context, network_id)"},{"line_number":401,"context_line":"        vlan_id \u003d network[\u0027vlan\u0027]"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        # convert mac format: xx:xx:xx:xx:xx:xx -\u003e xxxx.xxxx.xxxx"},{"line_number":404,"context_line":"        mac \u003d self.mac_reformat_62to34(interface_mac)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_52d75b23","line":401,"in_reply_to":"1a930d6b_15278ab7","updated":"2015-01-22 23:30:24.000000000","message":"As you probably noticed, this code was just moved from its original location to allow its use in multiple places.  I\u0027d prefer to avoid any refactoring not really needed for the bp.  If you have a strong feeling about this, let\u0027s discuss, maybe with Shiv Harris, to ensure that anything else I do is desired by folks who support the Brocade solution.","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c5df7e6ced539a08f2f5a0f2d89a5bc0a93db338","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                                  self._switch[\u0027password\u0027],"},{"line_number":409,"context_line":"                                                  vlan_id,"},{"line_number":410,"context_line":"                                                  mac)"},{"line_number":411,"context_line":"        except Exception:"},{"line_number":412,"context_line":"            LOG.exception("},{"line_number":413,"context_line":"                _LE(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":414,"context_line":"                interface_mac)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_11087f2c","line":411,"updated":"2015-01-22 17:48:04.000000000","message":"consider replacing lines 412- 415 with:\n\nwith excutils.save_and_reraise_exception():\n    LOG.exception(\n        _LE(\"Brocade NOS driver: failed to associate mac %s\"),\n        interface_mac)","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"392edd12c76162e9c841d3c9623879ed9653e8a8","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                                  self._switch[\u0027password\u0027],"},{"line_number":409,"context_line":"                                                  vlan_id,"},{"line_number":410,"context_line":"                                                  mac)"},{"line_number":411,"context_line":"        except Exception:"},{"line_number":412,"context_line":"            LOG.exception("},{"line_number":413,"context_line":"                _LE(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":414,"context_line":"                interface_mac)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_f2f127ce","line":411,"in_reply_to":"1a930d6b_11087f2c","updated":"2015-01-22 23:30:24.000000000","message":"see response at line 401","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c5df7e6ced539a08f2f5a0f2d89a5bc0a93db338","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                vlan_id,"},{"line_number":431,"context_line":"                mac)"},{"line_number":432,"context_line":"        except Exception:"},{"line_number":433,"context_line":"            LOG.exception("},{"line_number":434,"context_line":"                _LE(\"Brocade NOS driver: failed to dissociate MAC %s\"),"},{"line_number":435,"context_line":"                interface_mac)"},{"line_number":436,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_5102070c","line":433,"updated":"2015-01-22 17:48:04.000000000","message":"ditto","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"392edd12c76162e9c841d3c9623879ed9653e8a8","unresolved":false,"context_lines":[{"line_number":430,"context_line":"                vlan_id,"},{"line_number":431,"context_line":"                mac)"},{"line_number":432,"context_line":"        except Exception:"},{"line_number":433,"context_line":"            LOG.exception("},{"line_number":434,"context_line":"                _LE(\"Brocade NOS driver: failed to dissociate MAC %s\"),"},{"line_number":435,"context_line":"                interface_mac)"},{"line_number":436,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_32bbafe6","line":433,"in_reply_to":"1a930d6b_5102070c","updated":"2015-01-22 23:30:24.000000000","message":"see response at line 401","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a4a4c64bf90cd3e6d0a2ff9b6667edb0891beb3b","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                                  self._switch[\u0027password\u0027],"},{"line_number":409,"context_line":"                                                  vlan_id,"},{"line_number":410,"context_line":"                                                  mac)"},{"line_number":411,"context_line":"        except Exception:"},{"line_number":412,"context_line":"            LOG.exception("},{"line_number":413,"context_line":"                _LE(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":414,"context_line":"                interface_mac)"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa81d914_59e8af7c","line":411,"updated":"2015-01-27 20:47:23.000000000","message":"why are we not raising the same exception here?","commit_id":"e781f5f64b3910b7ffa936d9ce27e2696cf094bc"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c01cc03ef566ef1cede98e15c0587deb5896ed37","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                                                  self._switch[\u0027password\u0027],"},{"line_number":409,"context_line":"                                                  vlan_id,"},{"line_number":410,"context_line":"                                                  mac)"},{"line_number":411,"context_line":"        except Exception:"},{"line_number":412,"context_line":"            LOG.exception("},{"line_number":413,"context_line":"                _LE(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":414,"context_line":"                interface_mac)"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa81d914_c5c8c224","line":411,"in_reply_to":"fa81d914_59e8af7c","updated":"2015-01-29 23:04:07.000000000","message":"Done","commit_id":"e781f5f64b3910b7ffa936d9ce27e2696cf094bc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a4a4c64bf90cd3e6d0a2ff9b6667edb0891beb3b","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            LOG.exception("},{"line_number":413,"context_line":"                _LE(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":414,"context_line":"                interface_mac)"},{"line_number":415,"context_line":"            raise Exception("},{"line_number":416,"context_line":"                _(\"Brocade switch exception: %s failed\") % op)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _dissociate_mac_from_net(self, context, network_id, interface_mac, op):"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa81d914_399a1b15","line":415,"updated":"2015-01-27 20:47:23.000000000","message":"if we do raise an exception here, let it at least be a neutron one","commit_id":"e781f5f64b3910b7ffa936d9ce27e2696cf094bc"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c01cc03ef566ef1cede98e15c0587deb5896ed37","unresolved":false,"context_lines":[{"line_number":412,"context_line":"            LOG.exception("},{"line_number":413,"context_line":"                _LE(\"Brocade NOS driver: failed to associate mac %s\"),"},{"line_number":414,"context_line":"                interface_mac)"},{"line_number":415,"context_line":"            raise Exception("},{"line_number":416,"context_line":"                _(\"Brocade switch exception: %s failed\") % op)"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"    def _dissociate_mac_from_net(self, context, network_id, interface_mac, op):"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa81d914_05d3bad6","line":415,"in_reply_to":"fa81d914_399a1b15","updated":"2015-01-29 23:04:07.000000000","message":"removed","commit_id":"e781f5f64b3910b7ffa936d9ce27e2696cf094bc"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"a4a4c64bf90cd3e6d0a2ff9b6667edb0891beb3b","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            LOG.exception("},{"line_number":434,"context_line":"                _LE(\"Brocade NOS driver: failed to dissociate MAC %s\"),"},{"line_number":435,"context_line":"                interface_mac)"},{"line_number":436,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @staticmethod"},{"line_number":439,"context_line":"    def mac_reformat_62to34(interface_mac):"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa81d914_79a49357","line":436,"updated":"2015-01-27 20:47:23.000000000","message":"same point here","commit_id":"e781f5f64b3910b7ffa936d9ce27e2696cf094bc"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c01cc03ef566ef1cede98e15c0587deb5896ed37","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            LOG.exception("},{"line_number":434,"context_line":"                _LE(\"Brocade NOS driver: failed to dissociate MAC %s\"),"},{"line_number":435,"context_line":"                interface_mac)"},{"line_number":436,"context_line":"            raise Exception(_(\"Brocade switch exception, %s failed\") % op)"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    @staticmethod"},{"line_number":439,"context_line":"    def mac_reformat_62to34(interface_mac):"}],"source_content_type":"text/x-python","patch_set":36,"id":"fa81d914_45dcd2e4","line":436,"in_reply_to":"fa81d914_79a49357","updated":"2015-01-29 23:04:07.000000000","message":"Done","commit_id":"e781f5f64b3910b7ffa936d9ce27e2696cf094bc"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"52d786e6e705a36450599dcc6f3b404c47e04f67","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self._associate_mac_to_net(context, network_id, port[\u0027mac_address\u0027],"},{"line_number":367,"context_line":"                                   \"update_port_postcommit\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        LOG.info("},{"line_number":370,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":371,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s.\"),"},{"line_number":372,"context_line":"            {\u0027port_id\u0027: port_id,"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_a1fe4dac","line":369,"updated":"2015-01-30 05:02:23.000000000","message":"This sounds more like DEBUG thank INFO. Any good reason to log this?","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"e97840408682306e975f688156b47c3dabaa2f8a","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        self._associate_mac_to_net(context, network_id, port[\u0027mac_address\u0027],"},{"line_number":367,"context_line":"                                   \"update_port_postcommit\")"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"        LOG.info("},{"line_number":370,"context_line":"            _LI(\"update port (postcommit): port_id\u003d%(port_id)s\""},{"line_number":371,"context_line":"                \" network_id\u003d%(network_id)s tenant_id\u003d%(tenant_id)s.\"),"},{"line_number":372,"context_line":"            {\u0027port_id\u0027: port_id,"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_7a7f9eab","line":369,"in_reply_to":"fa81d914_a1fe4dac","updated":"2015-01-30 07:47:55.000000000","message":"Sorry about the number of patchsets.  This was already discussed in patchset  26.  We decided to keep it consistent with the create and delete operations, which were not touched by this patch.","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"}],"neutron/plugins/ml2/drivers/l2pop/mech_driver.py":[{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"57d55187cd4faa4478773e886a665f2532772acd","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"},{"line_number":118,"context_line":"        if diff_ips or (port[\u0027mac_address\u0027] !\u003d orig[\u0027mac_address\u0027]):"},{"line_number":119,"context_line":"            self._fixed_ips_changed(context, orig, port, diff_ips)"},{"line_number":120,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":121,"context_line":"            if context.status \u003d\u003d const.PORT_STATUS_ACTIVE:"},{"line_number":122,"context_line":"                self._update_port_up(context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_15b9802e","line":119,"updated":"2014-09-01 06:21:58.000000000","message":"_fixed_ips_changed expects non-None diff_ips.","commit_id":"aa2d9e47aed3370316f100f0a38606684eef707e"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"8ba8443fb89116a192f643087263c2adfbc1b9f5","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"},{"line_number":118,"context_line":"        if diff_ips or (port[\u0027mac_address\u0027] !\u003d orig[\u0027mac_address\u0027]):"},{"line_number":119,"context_line":"            self._fixed_ips_changed(context, orig, port, diff_ips)"},{"line_number":120,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":121,"context_line":"            if context.status \u003d\u003d const.PORT_STATUS_ACTIVE:"},{"line_number":122,"context_line":"                self._update_port_up(context)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_cc7ebc69","line":119,"in_reply_to":"fa98f980_15b9802e","updated":"2014-09-05 20:52:01.000000000","message":"Ugh.  I\u0027m not sure how I convinced myself that this was going to work.\n\nAdded l2pop unit test and fixed.","commit_id":"aa2d9e47aed3370316f100f0a38606684eef707e"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        port_mac_ip \u003d [[port[\u0027mac_address\u0027], ip] for ip in port_ips]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        ports \u003d {}"},{"line_number":104,"context_line":"        upd_fdb_entries \u003d {port[\u0027network_id\u0027]: {agent_ip: ports}}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if orig_mac_ip:"},{"line_number":107,"context_line":"            ports[\u0027before\u0027] \u003d orig_mac_ip"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_cf83f2a7","line":104,"updated":"2014-09-16 15:29:25.000000000","message":"why not {agent_ip: {}}","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        port_mac_ip \u003d [[port[\u0027mac_address\u0027], ip] for ip in port_ips]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        ports \u003d {}"},{"line_number":104,"context_line":"        upd_fdb_entries \u003d {port[\u0027network_id\u0027]: {agent_ip: ports}}"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if orig_mac_ip:"},{"line_number":107,"context_line":"            ports[\u0027before\u0027] \u003d orig_mac_ip"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_ed343ee1","line":104,"in_reply_to":"fa98f980_cf83f2a7","updated":"2014-09-18 06:30:19.000000000","message":"I was tempted, but then the changes to ports below would not go into upd_fdb_entries as intended.","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"f4b77deacaea9bb2946903d8596895b7c9a7f889","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            port_chg_ips \u003d port_ips.difference(orig_ips)"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            orig_chg_ips \u003d orig_ips"},{"line_number":64,"context_line":"            port_chg_ips \u003d port_ips"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if orig_chg_ips or port_chg_ips:"},{"line_number":67,"context_line":"            return orig_chg_ips, port_chg_ips"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_deb9d2ea","line":64,"updated":"2014-10-20 14:43:03.000000000","message":"If its a mac address only change, we should return diff_ips to be empty, instead of returning the original sets here, since that will preserve existing behaviour.\r\n\r\nAlso, are we planning to allow via this patch, both mac-address and fixed-ip to be updated in a single neutron port-update command?","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"fa10865c58dddc90a89339b8962c842005c3075e","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            port_chg_ips \u003d port_ips.difference(orig_ips)"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            orig_chg_ips \u003d orig_ips"},{"line_number":64,"context_line":"            port_chg_ips \u003d port_ips"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if orig_chg_ips or port_chg_ips:"},{"line_number":67,"context_line":"            return orig_chg_ips, port_chg_ips"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_be64b249","line":64,"in_reply_to":"9aa7fdbe_b0909bed","updated":"2014-10-23 00:53:47.000000000","message":"Vivekanandan and Paul, I agree with your points, although I don\u0027t see a regression here.  I will refactor in the next patchset.","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bb9c86073a70f93e0dc129ddfaa16137feaac2ed","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            port_chg_ips \u003d port_ips.difference(orig_ips)"},{"line_number":62,"context_line":"        else:"},{"line_number":63,"context_line":"            orig_chg_ips \u003d orig_ips"},{"line_number":64,"context_line":"            port_chg_ips \u003d port_ips"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if orig_chg_ips or port_chg_ips:"},{"line_number":67,"context_line":"            return orig_chg_ips, port_chg_ips"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_b0909bed","line":64,"in_reply_to":"9aa7fdbe_deb9d2ea","updated":"2014-10-21 12:59:09.000000000","message":"Good points.  It does seem like _get_diff_ips is trying to do two things. For an IP change, provide diffs (added/removed). For a MAC change, provide all the IPs so that _fixed_ips_changed has IPs to process.\n\nRecommend changing so that this has a single role (determining IP differences), and consider modifying _fixed_ips_changed, to handle the case of mac changing (and both changing, if that is possible).\n\nAnother thought would be to have this method determine the \"affected\" ports (rename the method), which could be all ports for a MAC changes, or the added/delete ports for an IP change. Then _fixed_ips_changed would have a list of ports to use on L82-83?","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"f4b77deacaea9bb2946903d8596895b7c9a7f889","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        port_mac_ip \u003d [[port[\u0027mac_address\u0027], ip] for ip in port_ips]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        ports \u003d {}"},{"line_number":86,"context_line":"        upd_fdb_entries \u003d {port[\u0027network_id\u0027]: {agent_ip: ports}}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        if orig_mac_ip:"},{"line_number":89,"context_line":"            ports[\u0027before\u0027] \u003d orig_mac_ip"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_9e090a98","line":86,"updated":"2014-10-20 14:43:03.000000000","message":"Is this change necessary for this patch?  We see its just refactoring existing code.","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"fa10865c58dddc90a89339b8962c842005c3075e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        port_mac_ip \u003d [[port[\u0027mac_address\u0027], ip] for ip in port_ips]"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        ports \u003d {}"},{"line_number":86,"context_line":"        upd_fdb_entries \u003d {port[\u0027network_id\u0027]: {agent_ip: ports}}"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        if orig_mac_ip:"},{"line_number":89,"context_line":"            ports[\u0027before\u0027] \u003d orig_mac_ip"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_be9f52b3","line":86,"in_reply_to":"9aa7fdbe_9e090a98","updated":"2014-10-23 00:53:47.000000000","message":"I took me longer to decipher the original form than I thought it should, so since my change depends on this code, I decided to make it more readable.  Since this is no longer a bug fix, maybe that\u0027s OK?  I\u0027m OK reverting back, if you prefer.  It may not be so easy to land a separate review with just this change....","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a0cbe99464c1dc74486d0bab128fda291e0dac7f","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        orig \u003d context.original"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"},{"line_number":104,"context_line":"        if diff_ips or (port[\u0027mac_address\u0027] !\u003d orig[\u0027mac_address\u0027]):"},{"line_number":105,"context_line":"            self._fixed_ips_changed(context, orig, port, diff_ips)"},{"line_number":106,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":107,"context_line":"            if context.status \u003d\u003d const.PORT_STATUS_ACTIVE:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_1b688c86","line":104,"updated":"2014-10-22 08:00:30.000000000","message":"Is mac address change case handled by line 63, 64?\nOnly one of this line or line 63, 64 is needed.","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"fa10865c58dddc90a89339b8962c842005c3075e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        orig \u003d context.original"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"},{"line_number":104,"context_line":"        if diff_ips or (port[\u0027mac_address\u0027] !\u003d orig[\u0027mac_address\u0027]):"},{"line_number":105,"context_line":"            self._fixed_ips_changed(context, orig, port, diff_ips)"},{"line_number":106,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":107,"context_line":"            if context.status \u003d\u003d const.PORT_STATUS_ACTIVE:"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_deffb665","line":104,"in_reply_to":"9aa7fdbe_1b688c86","updated":"2014-10-23 00:53:47.000000000","message":"True as long as there are fixed_ips.ip_address.  But refactoring per above comments will address this regardless.","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"ceee7f0c09ed0583f2c7bc3e634201bc65d4231b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        orig_ips \u003d set([ip[\u0027ip_address\u0027] for ip in orig[\u0027fixed_ips\u0027]])"},{"line_number":56,"context_line":"        port_ips \u003d set([ip[\u0027ip_address\u0027] for ip in port[\u0027fixed_ips\u0027]])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # if mac has changed, all map-ip mappings change, otherwise"},{"line_number":59,"context_line":"        # check if an ip has been added or removed"},{"line_number":60,"context_line":"        if port[\u0027mac_address\u0027] \u003d\u003d orig[\u0027mac_address\u0027]:"},{"line_number":61,"context_line":"            orig_chg_ips \u003d orig_ips.difference(port_ips)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_2a46934f","line":58,"updated":"2014-10-24 15:08:06.000000000","message":"nit: would be nice if the if clause on L60 mapped to the comment ordering (comment -\u003e if not equal, code -\u003e tests if equal). A real nit for sure :)","commit_id":"4de9fab1e64ef421de9b237149cdc1a46776d4b8"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"d794cb9aa42c172ea8f02c43902ba2c405a4412f","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        orig_ips \u003d set([ip[\u0027ip_address\u0027] for ip in orig[\u0027fixed_ips\u0027]])"},{"line_number":56,"context_line":"        port_ips \u003d set([ip[\u0027ip_address\u0027] for ip in port[\u0027fixed_ips\u0027]])"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        # if mac has changed, all map-ip mappings change, otherwise"},{"line_number":59,"context_line":"        # check if an ip has been added or removed"},{"line_number":60,"context_line":"        if port[\u0027mac_address\u0027] \u003d\u003d orig[\u0027mac_address\u0027]:"},{"line_number":61,"context_line":"            orig_chg_ips \u003d orig_ips.difference(port_ips)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_6f97b6ec","line":58,"in_reply_to":"9aa7fdbe_2a46934f","updated":"2014-10-26 00:32:04.000000000","message":"Done","commit_id":"4de9fab1e64ef421de9b237149cdc1a46776d4b8"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d5ff49e3cb8044704fecd03a18dd5bc80057889","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        port_ips \u003d set([ip[\u0027ip_address\u0027] for ip in port[\u0027fixed_ips\u0027]])"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"        # if no mac change, check if an ip has been added or removed"},{"line_number":61,"context_line":"        # if mac has changed, all mac-ip mappings change"},{"line_number":62,"context_line":"        if port[\u0027mac_address\u0027] \u003d\u003d orig[\u0027mac_address\u0027]:"},{"line_number":63,"context_line":"            orig_chg_ips \u003d orig_ips.difference(port_ips)"},{"line_number":64,"context_line":"            port_chg_ips \u003d port_ips.difference(orig_ips)"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a961159_8d9096ee","line":61,"updated":"2014-12-19 07:53:02.000000000","message":"it would be simpler to generate two lists of PortInfo and then make a diff of them.","commit_id":"b5193a1da7796675621deeee000ad277dea67637"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"6d5ff49e3cb8044704fecd03a18dd5bc80057889","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            orig_chg_ips \u003d orig_ips"},{"line_number":67,"context_line":"            port_chg_ips \u003d port_ips"},{"line_number":68,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"},{"line_number":69,"context_line":"                                          ip_address\u003dip)"},{"line_number":70,"context_line":"                       for ip in orig_chg_ips]"},{"line_number":71,"context_line":"        port_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"3a961159_cd961ef0","line":68,"updated":"2014-12-19 07:53:02.000000000","message":"shouldn\u0027t this be orig[\u0027mac_address\u0027] ?","commit_id":"b5193a1da7796675621deeee000ad277dea67637"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"cbe95882038efad2e8d0518a6de132db495ba937","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            orig_chg_ips \u003d orig_ips"},{"line_number":67,"context_line":"            port_chg_ips \u003d port_ips"},{"line_number":68,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"},{"line_number":69,"context_line":"                                          ip_address\u003dip)"},{"line_number":70,"context_line":"                       for ip in orig_chg_ips]"},{"line_number":71,"context_line":"        port_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":28,"id":"1a930d6b_009074eb","line":68,"in_reply_to":"3a961159_cd961ef0","updated":"2015-01-21 00:45:14.000000000","message":"I\u0027m working on a test to detect this issue.","commit_id":"b5193a1da7796675621deeee000ad277dea67637"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c1366345aa09b6e24c090e7af34edc2cec3978d8","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            orig_chg_ips \u003d orig_ips"},{"line_number":67,"context_line":"            port_chg_ips \u003d port_ips"},{"line_number":68,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"},{"line_number":69,"context_line":"                                          ip_address\u003dip)"},{"line_number":70,"context_line":"                       for ip in orig_chg_ips]"},{"line_number":71,"context_line":"        port_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_77abbb89","line":68,"updated":"2015-01-21 02:09:15.000000000","message":"orig[\u0027mac_address\u0027] instead of port?","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"8bf1608b58d10007761e2f75ffa1634edb1e6001","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        else:"},{"line_number":66,"context_line":"            orig_chg_ips \u003d orig_ips"},{"line_number":67,"context_line":"            port_chg_ips \u003d port_ips"},{"line_number":68,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"},{"line_number":69,"context_line":"                                          ip_address\u003dip)"},{"line_number":70,"context_line":"                       for ip in orig_chg_ips]"},{"line_number":71,"context_line":"        port_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_d1b437d3","line":68,"in_reply_to":"1a930d6b_77abbb89","updated":"2015-01-22 18:05:47.000000000","message":"Yamahata, thanks for mentioning this issue again in this patchset.\n\nIn trying to write a unit test to detect this bug (also found by Yamamoto in patchset 28), I discovered that mac_address changes do not require this code change because the port must not be bound, so the _get_port_infos() call at line 85 returns nothing and _update_mac_ip_mapping() returns at line 88.\n\nSince these changes don\u0027t seem necessary and I don\u0027t see a way to test them anyway, the next patchset will remove all changes currently in this file, and just add a check to throw and exception if mac_address change makes it past the return statement.","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"c5df7e6ced539a08f2f5a0f2d89a5bc0a93db338","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        port \u003d context.current"},{"line_number":107,"context_line":"        orig \u003d context.original"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        map_change \u003d self._get_mac_ip_mapping_change(orig, port)"},{"line_number":110,"context_line":"        if map_change:"},{"line_number":111,"context_line":"            self._update_mac_ip_mapping(context, orig, port, map_change)"},{"line_number":112,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_f5675eb5","line":109,"updated":"2015-01-22 17:48:04.000000000","message":"nit: consider renaming map_change -\u003e mac_ip_map_change","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ff9ef3b40457c1752918abc48d048498f8f81ad3","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        port \u003d context.current"},{"line_number":107,"context_line":"        orig \u003d context.original"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        map_change \u003d self._get_mac_ip_mapping_change(orig, port)"},{"line_number":110,"context_line":"        if map_change:"},{"line_number":111,"context_line":"            self._update_mac_ip_mapping(context, orig, port, map_change)"},{"line_number":112,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"}],"source_content_type":"text/x-python","patch_set":31,"id":"1a930d6b_573bcd9b","line":109,"in_reply_to":"1a930d6b_f5675eb5","updated":"2015-01-22 22:51:33.000000000","message":"removed all these changes for now.  Will consider your suggestion if they come back.","commit_id":"260f5eb09440ac1029ba96ed6dc39f8f3a9ae020"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"3284136f1acadda9fc658f6730af806852298960","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not port_infos:"},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":"        if orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027]:"},{"line_number":80,"context_line":"            raise ml2_exc.MechansimDriverError(method\u003d\u0027_fixed_ips_changed\u0027)"},{"line_number":81,"context_line":"        agent, agent_host, agent_ip, segment, port_fdb_entries \u003d port_infos"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a930d6b_ff2c4bae","line":80,"updated":"2015-01-26 09:27:46.000000000","message":"i can\u0027t think of a way to trigger this right now.","commit_id":"54c1d245d91210715dd173fd19b5bb2db3b5ca40"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"b45060211fe6f82df2518bdde9a6dae8667cbb97","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not port_infos:"},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":"        if orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027]:"},{"line_number":80,"context_line":"            raise ml2_exc.MechansimDriverError(method\u003d\u0027_fixed_ips_changed\u0027)"},{"line_number":81,"context_line":"        agent, agent_host, agent_ip, segment, port_fdb_entries \u003d port_infos"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a930d6b_b1a82a8e","line":80,"in_reply_to":"1a930d6b_42df480d","updated":"2015-01-26 15:27:06.000000000","message":"This could be triggered if the update of the port concerns both IP and MAC, and if the port is not ACTIVE. But I don\u0027t think it\u0027s relevant to send fdb messages for a port that is not ACTIVE. hence I proposed this patch : \n\nhttps://review.openstack.org/#/c/150045/\n\nHowever a double check is painless, but it would be better to do it directly in update_port_postcommit()","commit_id":"54c1d245d91210715dd173fd19b5bb2db3b5ca40"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"68977834d65a5572bdabac67ffc345576a9dbdb2","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not port_infos:"},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":"        if orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027]:"},{"line_number":80,"context_line":"            raise ml2_exc.MechansimDriverError(method\u003d\u0027_fixed_ips_changed\u0027)"},{"line_number":81,"context_line":"        agent, agent_host, agent_ip, segment, port_fdb_entries \u003d port_infos"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a930d6b_82f74cd2","line":80,"in_reply_to":"1a930d6b_b1a82a8e","updated":"2015-01-27 01:33:59.000000000","message":"I wrote a unit test to update both mac and ip of a non-ACTIVE, unbound port, and it passed.  So I still believe that the code returns at line 78 when the port is not bound.  This is because there is no bound_segment (line 164).\n\nIf the relationship between port_infos being found and either port not being bound or port not being ACTIVE changes in the future, this test will be helpful.","commit_id":"54c1d245d91210715dd173fd19b5bb2db3b5ca40"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"8f9f2bff1e7285d43f85f98bb250a389751ebf14","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not port_infos:"},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":"        if orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027]:"},{"line_number":80,"context_line":"            raise ml2_exc.MechansimDriverError(method\u003d\u0027_fixed_ips_changed\u0027)"},{"line_number":81,"context_line":"        agent, agent_host, agent_ip, segment, port_fdb_entries \u003d port_infos"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a930d6b_42df480d","line":80,"in_reply_to":"1a930d6b_ff2c4bae","updated":"2015-01-26 09:47:46.000000000","message":"Thanks for looking, Yamamoto.","commit_id":"54c1d245d91210715dd173fd19b5bb2db3b5ca40"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"b45060211fe6f82df2518bdde9a6dae8667cbb97","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        orig \u003d context.original"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"},{"line_number":109,"context_line":"        if diff_ips:"},{"line_number":110,"context_line":"            self._fixed_ips_changed(context, orig, port, diff_ips)"},{"line_number":111,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":112,"context_line":"            if context.status \u003d\u003d const.PORT_STATUS_ACTIVE:"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a930d6b_11d3be04","line":109,"updated":"2015-01-26 15:27:06.000000000","message":"if context.status \u003d\u003d const.PORT_STATUS_ACTIVE : \n    if orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027]:\n        LOG.WARNING(\"unable to modify the mac of the ACTIVE port port_id)\n        raise ml2_exc.MechansimDriverError(method\u003d\u0027update_port_postcommit\u0027)","commit_id":"54c1d245d91210715dd173fd19b5bb2db3b5ca40"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"68977834d65a5572bdabac67ffc345576a9dbdb2","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        orig \u003d context.original"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"},{"line_number":109,"context_line":"        if diff_ips:"},{"line_number":110,"context_line":"            self._fixed_ips_changed(context, orig, port, diff_ips)"},{"line_number":111,"context_line":"        if port[\u0027device_owner\u0027] \u003d\u003d const.DEVICE_OWNER_DVR_INTERFACE:"},{"line_number":112,"context_line":"            if context.status \u003d\u003d const.PORT_STATUS_ACTIVE:"}],"source_content_type":"text/x-python","patch_set":34,"id":"1a930d6b_ed92c14a","line":109,"in_reply_to":"1a930d6b_11d3be04","updated":"2015-01-27 01:33:59.000000000","message":"Done","commit_id":"54c1d245d91210715dd173fd19b5bb2db3b5ca40"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"bdf86a468fe0acc701faa7a3e235d3d26924fea9","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not port_infos:"},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":"        if orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027]:"},{"line_number":80,"context_line":"            raise ml2_exc.MechansimDriverError(method\u003d\u0027_fixed_ips_changed\u0027)"},{"line_number":81,"context_line":"        agent, agent_host, agent_ip, segment, port_fdb_entries \u003d port_infos"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_8968fcf6","line":80,"updated":"2015-01-28 09:34:17.000000000","message":"this check is not useful anymore, it is done in update_port_postcommit()","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7ec2207f0aefb7fc0862b30abfb456a7298a2d22","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        if not port_infos:"},{"line_number":78,"context_line":"            return"},{"line_number":79,"context_line":"        if orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027]:"},{"line_number":80,"context_line":"            raise ml2_exc.MechansimDriverError(method\u003d\u0027_fixed_ips_changed\u0027)"},{"line_number":81,"context_line":"        agent, agent_host, agent_ip, segment, port_fdb_entries \u003d port_infos"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        orig_mac_ip \u003d [l2pop_rpc.PortInfo(mac_address\u003dport[\u0027mac_address\u0027],"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_cf480a8a","line":80,"in_reply_to":"fa81d914_8968fcf6","updated":"2015-01-29 06:46:43.000000000","message":"done","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"bdf86a468fe0acc701faa7a3e235d3d26924fea9","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        orig \u003d context.original"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"},{"line_number":109,"context_line":"        if diff_ips:"},{"line_number":110,"context_line":"            if (orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027] and"},{"line_number":111,"context_line":"                context.status \u003d\u003d const.PORT_STATUS_ACTIVE):"},{"line_number":112,"context_line":"                LOG.warning(_LW(\"unable to modify mac_address of ACTIVE port \""}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_e976d8d7","line":109,"updated":"2015-01-28 09:34:17.000000000","message":"the lines below should be written outside of the if statement, and I think before the if statement.\nIt is a double check, considering this check is already done by ML2, but we can keep it anyway.","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7ec2207f0aefb7fc0862b30abfb456a7298a2d22","unresolved":false,"context_lines":[{"line_number":106,"context_line":"        orig \u003d context.original"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        diff_ips \u003d self._get_diff_ips(orig, port)"},{"line_number":109,"context_line":"        if diff_ips:"},{"line_number":110,"context_line":"            if (orig[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027] and"},{"line_number":111,"context_line":"                context.status \u003d\u003d const.PORT_STATUS_ACTIVE):"},{"line_number":112,"context_line":"                LOG.warning(_LW(\"unable to modify mac_address of ACTIVE port \""}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_afe91682","line":109,"in_reply_to":"fa81d914_e976d8d7","updated":"2015-01-29 06:46:43.000000000","message":"the ml2 check is based on portbinding.vif_type.  I prefer these kinds of double checks in case relationships change in the future and to detect windows where the expected relationship is not true.\n\nDone","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"}],"neutron/plugins/ml2/plugin.py":[{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f29bb40dc898498cafeb6648806f701f3dbe8fed","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        if (orig_port and"},{"line_number":169,"context_line":"            orig_port[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027] and"},{"line_number":170,"context_line":"            binding.vif_type !\u003d portbindings.VIF_TYPE_BINDING_FAILED):"},{"line_number":171,"context_line":"            raise exc.PortBound(port_id\u003dorig_port[\u0027id\u0027],"},{"line_number":172,"context_line":"                                vif_type\u003dbinding.vif_type)"},{"line_number":173,"context_line":"        host \u003d attrs and attrs.get(portbindings.HOST_ID)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_5fc16ee3","line":170,"updated":"2014-09-21 17:53:53.000000000","message":"I think it should include also portbindings.VIF_TYPE_UNBOUND","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ee6e7671631e4c0b2b822e83730639d4e0aca2a2","unresolved":false,"context_lines":[{"line_number":167,"context_line":""},{"line_number":168,"context_line":"        if (orig_port and"},{"line_number":169,"context_line":"            orig_port[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027] and"},{"line_number":170,"context_line":"            binding.vif_type !\u003d portbindings.VIF_TYPE_BINDING_FAILED):"},{"line_number":171,"context_line":"            raise exc.PortBound(port_id\u003dorig_port[\u0027id\u0027],"},{"line_number":172,"context_line":"                                vif_type\u003dbinding.vif_type)"},{"line_number":173,"context_line":"        host \u003d attrs and attrs.get(portbindings.HOST_ID)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_566f8692","line":170,"in_reply_to":"da9df570_5fc16ee3","updated":"2014-09-22 16:06:51.000000000","message":"Done","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"7d1fea9140d5c131feecc816821f18278b62e942","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        if (orig_port and"},{"line_number":189,"context_line":"            orig_port[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027] and"},{"line_number":190,"context_line":"            binding.vif_type not in unplugged_types):"},{"line_number":191,"context_line":"            LOG.debug(\"old mac %(old_mac)s, new mac %(new_mac)s\","},{"line_number":192,"context_line":"                      {\u0027old_mac\u0027: orig_port[\u0027mac_address\u0027],"},{"line_number":193,"context_line":"                       \u0027new_mac\u0027: port[\u0027mac_address\u0027]})"},{"line_number":194,"context_line":"            raise exc.PortBound(port_id\u003dorig_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_f8119304","line":191,"updated":"2014-10-27 17:17:39.000000000","message":"This debug message seems a bit disconnected from the exception (when probably this data will be needed most of the cases where the exception is raised).\n\nWhy not add both mac addresses to the PortBound exception, and construct one big error?","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7aa18b2358b3ef6205913c9fdfb75e7b6fd724ab","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        if (orig_port and"},{"line_number":189,"context_line":"            orig_port[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027] and"},{"line_number":190,"context_line":"            binding.vif_type not in unplugged_types):"},{"line_number":191,"context_line":"            LOG.debug(\"old mac %(old_mac)s, new mac %(new_mac)s\","},{"line_number":192,"context_line":"                      {\u0027old_mac\u0027: orig_port[\u0027mac_address\u0027],"},{"line_number":193,"context_line":"                       \u0027new_mac\u0027: port[\u0027mac_address\u0027]})"},{"line_number":194,"context_line":"            raise exc.PortBound(port_id\u003dorig_port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_9b9e8d06","line":191,"in_reply_to":"9aa7fdbe_f8119304","updated":"2014-11-19 01:12:26.000000000","message":"Done","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"7d1fea9140d5c131feecc816821f18278b62e942","unresolved":false,"context_lines":[{"line_number":834,"context_line":"    def update_port(self, context, id, port):"},{"line_number":835,"context_line":"        attrs \u003d port[\u0027port\u0027]"},{"line_number":836,"context_line":"        need_port_update_notify \u003d False"},{"line_number":837,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":838,"context_line":"            service_constants.L3_ROUTER_NAT)"},{"line_number":839,"context_line":"        is_dvr_enabled \u003d utils.is_extension_supported("},{"line_number":840,"context_line":"            l3plugin, const.L3_DISTRIBUTED_EXT_ALIAS)"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_38707b71","line":837,"updated":"2014-10-27 17:17:39.000000000","message":"nit: maybe \"l3_plugin\"? not a must.","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7aa18b2358b3ef6205913c9fdfb75e7b6fd724ab","unresolved":false,"context_lines":[{"line_number":834,"context_line":"    def update_port(self, context, id, port):"},{"line_number":835,"context_line":"        attrs \u003d port[\u0027port\u0027]"},{"line_number":836,"context_line":"        need_port_update_notify \u003d False"},{"line_number":837,"context_line":"        l3plugin \u003d manager.NeutronManager.get_service_plugins().get("},{"line_number":838,"context_line":"            service_constants.L3_ROUTER_NAT)"},{"line_number":839,"context_line":"        is_dvr_enabled \u003d utils.is_extension_supported("},{"line_number":840,"context_line":"            l3plugin, const.L3_DISTRIBUTED_EXT_ALIAS)"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_3b8f59ce","line":837,"in_reply_to":"9aa7fdbe_38707b71","updated":"2014-11-19 01:12:26.000000000","message":"would create inconsistencies in this file, so rather not right now.","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"7d1fea9140d5c131feecc816821f18278b62e942","unresolved":false,"context_lines":[{"line_number":855,"context_line":"                                                              port)"},{"line_number":856,"context_line":"            self.extension_manager.process_update_port(session, attrs,"},{"line_number":857,"context_line":"                                                       original_port)"},{"line_number":858,"context_line":"            mac_addr_updated \u003d False"},{"line_number":859,"context_line":"            if updated_port[\u0027mac_address\u0027] !\u003d original_port[\u0027mac_address\u0027]:"},{"line_number":860,"context_line":"                mac_addr_updated \u003d True"},{"line_number":861,"context_line":"                need_port_update_notify \u003d True"}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_18757763","line":858,"updated":"2014-10-27 17:17:39.000000000","message":"nit: can we rename to \"mac_address_updated\"?","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7aa18b2358b3ef6205913c9fdfb75e7b6fd724ab","unresolved":false,"context_lines":[{"line_number":855,"context_line":"                                                              port)"},{"line_number":856,"context_line":"            self.extension_manager.process_update_port(session, attrs,"},{"line_number":857,"context_line":"                                                       original_port)"},{"line_number":858,"context_line":"            mac_addr_updated \u003d False"},{"line_number":859,"context_line":"            if updated_port[\u0027mac_address\u0027] !\u003d original_port[\u0027mac_address\u0027]:"},{"line_number":860,"context_line":"                mac_addr_updated \u003d True"},{"line_number":861,"context_line":"                need_port_update_notify \u003d True"}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_bbba696c","line":858,"in_reply_to":"9aa7fdbe_18757763","updated":"2014-11-19 01:12:26.000000000","message":"Done","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"7d1fea9140d5c131feecc816821f18278b62e942","unresolved":false,"context_lines":[{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        # Notifications must be sent after the above transaction is complete"},{"line_number":882,"context_line":"        if l3plugin and is_dvr_enabled and mac_addr_updated:"},{"line_number":883,"context_line":"            # note: \"add\" actually does a \u0027replace\u0027 operation"},{"line_number":884,"context_line":"            l3plugin.dvr_vmarp_table_update(context, updated_port, \"add\")"},{"line_number":885,"context_line":"        self._notify_l3_agent_new_port(context, new_host_port)"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"9aa7fdbe_f85a73f0","line":883,"updated":"2014-10-27 17:17:39.000000000","message":"nit: #NOTE: \"add\" actually...","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7aa18b2358b3ef6205913c9fdfb75e7b6fd724ab","unresolved":false,"context_lines":[{"line_number":880,"context_line":""},{"line_number":881,"context_line":"        # Notifications must be sent after the above transaction is complete"},{"line_number":882,"context_line":"        if l3plugin and is_dvr_enabled and mac_addr_updated:"},{"line_number":883,"context_line":"            # note: \"add\" actually does a \u0027replace\u0027 operation"},{"line_number":884,"context_line":"            l3plugin.dvr_vmarp_table_update(context, updated_port, \"add\")"},{"line_number":885,"context_line":"        self._notify_l3_agent_new_port(context, new_host_port)"},{"line_number":886,"context_line":""}],"source_content_type":"text/x-python","patch_set":18,"id":"5a890539_1ba9bd24","line":883,"in_reply_to":"9aa7fdbe_f85a73f0","updated":"2014-11-19 01:12:26.000000000","message":"Done","commit_id":"f3099fd873a95702496d0fd941c4be92f783666a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c0cdd251e291aa5732fdb4b63637ea58e371f83b","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        orig_port \u003d mech_context.original"},{"line_number":188,"context_line":"        changes \u003d False"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        unplugged_types \u003d (portbindings.VIF_TYPE_BINDING_FAILED,"},{"line_number":191,"context_line":"                           portbindings.VIF_TYPE_UNBOUND)"},{"line_number":192,"context_line":"        if (orig_port and"},{"line_number":193,"context_line":"            orig_port[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027] and"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a961159_3ae28801","line":190,"updated":"2014-12-18 17:58:20.000000000","message":"this method is already huge, please consider breaking this logic out somewhere else","commit_id":"78f59a5378b7c0646af45d7e045f6de913d1a466"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"41f76f00366375ec4edbb5dcdf9a9cd63a4c8e11","unresolved":false,"context_lines":[{"line_number":187,"context_line":"        orig_port \u003d mech_context.original"},{"line_number":188,"context_line":"        changes \u003d False"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"        unplugged_types \u003d (portbindings.VIF_TYPE_BINDING_FAILED,"},{"line_number":191,"context_line":"                           portbindings.VIF_TYPE_UNBOUND)"},{"line_number":192,"context_line":"        if (orig_port and"},{"line_number":193,"context_line":"            orig_port[\u0027mac_address\u0027] !\u003d port[\u0027mac_address\u0027] and"}],"source_content_type":"text/x-python","patch_set":27,"id":"3a961159_9f4e076e","line":190,"in_reply_to":"3a961159_3ae28801","updated":"2014-12-19 07:23:24.000000000","message":"Done","commit_id":"78f59a5378b7c0646af45d7e045f6de913d1a466"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"bdf86a468fe0acc701faa7a3e235d3d26924fea9","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        if (attributes.is_attr_set(host) and binding.host !\u003d host):"},{"line_number":180,"context_line":"            return mech_context.current"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def _check_vif_type_for_mac_change(self, orig_port, port, binding):"},{"line_number":183,"context_line":"        unplugged_types \u003d (portbindings.VIF_TYPE_BINDING_FAILED,"},{"line_number":184,"context_line":"                           portbindings.VIF_TYPE_UNBOUND)"},{"line_number":185,"context_line":"        if (orig_port and"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_2962b0d8","line":182,"updated":"2015-01-28 09:34:17.000000000","message":"I\u0027m not sure the name of this method is relevant here : this method is checking that the mac addr can be changed no?\n\nwhat do you think of : _check_allowed_mac_update()?","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7ec2207f0aefb7fc0862b30abfb456a7298a2d22","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        if (attributes.is_attr_set(host) and binding.host !\u003d host):"},{"line_number":180,"context_line":"            return mech_context.current"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    def _check_vif_type_for_mac_change(self, orig_port, port, binding):"},{"line_number":183,"context_line":"        unplugged_types \u003d (portbindings.VIF_TYPE_BINDING_FAILED,"},{"line_number":184,"context_line":"                           portbindings.VIF_TYPE_UNBOUND)"},{"line_number":185,"context_line":"        if (orig_port and"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_869d145c","line":182,"in_reply_to":"fa81d914_2962b0d8","updated":"2015-01-29 06:46:43.000000000","message":"changed to _check_mac_update_allowed()","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"bdf86a468fe0acc701faa7a3e235d3d26924fea9","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        changes \u003d False"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        self._check_vif_type_for_mac_change(mech_context.original, port,"},{"line_number":199,"context_line":"                                            binding)"},{"line_number":200,"context_line":"        host \u003d attrs and attrs.get(portbindings.HOST_ID)"},{"line_number":201,"context_line":"        if (attributes.is_attr_set(host) and"},{"line_number":202,"context_line":"            binding.host !\u003d host):"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_e9e6d815","line":199,"updated":"2015-01-28 09:34:17.000000000","message":"I\u0027m not sure that this method should be called here : I\u0027m not sure that port binding is concerned by the modification of the mac addr?","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7ec2207f0aefb7fc0862b30abfb456a7298a2d22","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        changes \u003d False"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"        self._check_vif_type_for_mac_change(mech_context.original, port,"},{"line_number":199,"context_line":"                                            binding)"},{"line_number":200,"context_line":"        host \u003d attrs and attrs.get(portbindings.HOST_ID)"},{"line_number":201,"context_line":"        if (attributes.is_attr_set(host) and"},{"line_number":202,"context_line":"            binding.host !\u003d host):"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_0f38579f","line":199,"in_reply_to":"fa81d914_e9e6d815","updated":"2015-01-29 06:46:43.000000000","message":"Done","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"bdf86a468fe0acc701faa7a3e235d3d26924fea9","unresolved":false,"context_lines":[{"line_number":970,"context_line":"                               session.begin(subtransactions\u003dTrue)):"},{"line_number":971,"context_line":"            port_db, binding \u003d db.get_locked_port_and_binding(session, id)"},{"line_number":972,"context_line":"            if not port_db:"},{"line_number":973,"context_line":"                raise exc.PortNotFound(port_id\u003did)"},{"line_number":974,"context_line":"            original_port \u003d self._make_port_dict(port_db)"},{"line_number":975,"context_line":"            updated_port \u003d super(Ml2Plugin, self).update_port(context, id,"},{"line_number":976,"context_line":"                                                              port)"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_692bc8eb","line":973,"updated":"2015-01-28 09:34:17.000000000","message":"I think you should check that mac addr can be modified as early as possible. Here is good place.","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"7ec2207f0aefb7fc0862b30abfb456a7298a2d22","unresolved":false,"context_lines":[{"line_number":970,"context_line":"                               session.begin(subtransactions\u003dTrue)):"},{"line_number":971,"context_line":"            port_db, binding \u003d db.get_locked_port_and_binding(session, id)"},{"line_number":972,"context_line":"            if not port_db:"},{"line_number":973,"context_line":"                raise exc.PortNotFound(port_id\u003did)"},{"line_number":974,"context_line":"            original_port \u003d self._make_port_dict(port_db)"},{"line_number":975,"context_line":"            updated_port \u003d super(Ml2Plugin, self).update_port(context, id,"},{"line_number":976,"context_line":"                                                              port)"}],"source_content_type":"text/x-python","patch_set":37,"id":"fa81d914_4f424f11","line":973,"in_reply_to":"fa81d914_692bc8eb","updated":"2015-01-29 06:46:43.000000000","message":"Done","commit_id":"f028a280de9b998601b5d7d6812db44fa0297976"}],"neutron/tests/unit/ml2/drivers/brocade/test_brocade_mechanism_driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"84dc05ca4ebfa4e5bbd70c4ed688947fb77d26ed","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_update_port_mac(self):"},{"line_number":65,"context_line":"        # REVISIT: There\u0027s code in the driver to handle this, but not"},{"line_number":66,"context_line":"        # sure how to test it (!ACTIVE and binding_failed)."},{"line_number":67,"context_line":"        self.skipTest(\"REVISIT: how to test brocade mech update mac\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class TestBrocadeMechDriverSubnetsV2(test_db_plugin.TestSubnetsV2,"}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_3920e548","line":67,"updated":"2014-10-14 12:27:43.000000000","message":"Any chance you can get Shiv Harris to take a loot (at the Brocade driver too)","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_update_port_mac(self):"},{"line_number":65,"context_line":"        # REVISIT: There\u0027s code in the driver to handle this, but not"},{"line_number":66,"context_line":"        # sure how to test it (!ACTIVE and binding_failed)."},{"line_number":67,"context_line":"        self.skipTest(\"REVISIT: how to test brocade mech update mac\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class TestBrocadeMechDriverSubnetsV2(test_db_plugin.TestSubnetsV2,"}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_7249168b","line":67,"in_reply_to":"baa201ad_3920e548","updated":"2014-10-18 01:17:33.000000000","message":"I\u0027ll continue to try","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":5217,"name":"Shiv Haris","email":"shivharis@hotmail.com","username":"shh"},"change_message_id":"5e39b8b768007c34c234ebc8892bd774dd97b6cf","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_update_port_mac(self):"},{"line_number":65,"context_line":"        # REVISIT: There\u0027s code in the driver to handle this, but not"},{"line_number":66,"context_line":"        # sure how to test it (!ACTIVE and binding_failed)."},{"line_number":67,"context_line":"        self.skipTest(\"REVISIT: how to test brocade mech update mac\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class TestBrocadeMechDriverSubnetsV2(test_db_plugin.TestSubnetsV2,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_a6180e1f","line":67,"updated":"2014-10-23 23:11:50.000000000","message":"This code should not be here. The update port should also be tested in the base class - just like all the other tests are handled (network/ports/subnets)","commit_id":"4de9fab1e64ef421de9b237149cdc1a46776d4b8"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"d794cb9aa42c172ea8f02c43902ba2c405a4412f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_update_port_mac(self):"},{"line_number":65,"context_line":"        # REVISIT: There\u0027s code in the driver to handle this, but not"},{"line_number":66,"context_line":"        # sure how to test it (!ACTIVE and binding_failed)."},{"line_number":67,"context_line":"        self.skipTest(\"REVISIT: how to test brocade mech update mac\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class TestBrocadeMechDriverSubnetsV2(test_db_plugin.TestSubnetsV2,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_4f2af290","line":67,"in_reply_to":"9aa7fdbe_a6180e1f","updated":"2014-10-26 00:32:04.000000000","message":"Hey Shiv.  Since the port status check is no longer done, I removed this function and the base class tests pass fine now when run from this class.  Would you please take a look and verify that everything looks fine there.","commit_id":"4de9fab1e64ef421de9b237149cdc1a46776d4b8"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"ceee7f0c09ed0583f2c7bc3e634201bc65d4231b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_update_port_mac(self):"},{"line_number":65,"context_line":"        # REVISIT: There\u0027s code in the driver to handle this, but not"},{"line_number":66,"context_line":"        # sure how to test it (!ACTIVE and binding_failed)."},{"line_number":67,"context_line":"        self.skipTest(\"REVISIT: how to test brocade mech update mac\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class TestBrocadeMechDriverSubnetsV2(test_db_plugin.TestSubnetsV2,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_c766ddec","line":67,"in_reply_to":"9aa7fdbe_a6180e1f","updated":"2014-10-24 15:08:06.000000000","message":"Shiv, isn\u0027t this OK? Looks like NeutronDbPluginV2TestCase has test to be overrided, and some plugins override and this one skips.\n\nShould the comment be changed to TODO?","commit_id":"4de9fab1e64ef421de9b237149cdc1a46776d4b8"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"d794cb9aa42c172ea8f02c43902ba2c405a4412f","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    def test_update_port_mac(self):"},{"line_number":65,"context_line":"        # REVISIT: There\u0027s code in the driver to handle this, but not"},{"line_number":66,"context_line":"        # sure how to test it (!ACTIVE and binding_failed)."},{"line_number":67,"context_line":"        self.skipTest(\"REVISIT: how to test brocade mech update mac\")"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"class TestBrocadeMechDriverSubnetsV2(test_db_plugin.TestSubnetsV2,"}],"source_content_type":"text/x-python","patch_set":17,"id":"9aa7fdbe_ef0d663f","line":67,"in_reply_to":"9aa7fdbe_c766ddec","updated":"2014-10-26 00:32:04.000000000","message":"Hi Paul,\n\nAs mentioned above, running the base tests from this class works fine now.  Hopefully that covers it.","commit_id":"4de9fab1e64ef421de9b237149cdc1a46776d4b8"}],"neutron/tests/unit/ml2/drivers/cisco/nexus/test_cisco_mech.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8ce884851ed4cd4aaba217bdd51fe7808ead49e3","unresolved":false,"context_lines":[{"line_number":701,"context_line":"                                     c_exc.NexusMissingRequiredFields)"},{"line_number":702,"context_line":""},{"line_number":703,"context_line":"    def test_update_port_mac(self):"},{"line_number":704,"context_line":"        # REVISIT: test passes, but is back-end OK?"},{"line_number":705,"context_line":"        host_arg \u003d {"},{"line_number":706,"context_line":"            portbindings.HOST_ID: COMP_HOST_NAME,"},{"line_number":707,"context_line":"            \u0027device_id\u0027: DEVICE_ID_1,"}],"source_content_type":"text/x-python","patch_set":38,"id":"da86d52c_62890aca","line":704,"updated":"2015-02-02 15:19:10.000000000","message":"Put a TODO(who) here","commit_id":"cf99eb988e05c56d3842ac388dfe9ada5aa8af86"}],"neutron/tests/unit/ml2/drivers/test_l2population.py":[{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"bf66d1c351cd4145e9b21f11df6f5490f8b988d2","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                req \u003d self.new_update_request(\u0027ports\u0027, data, p1[\u0027id\u0027])"},{"line_number":600,"context_line":"                res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":601,"context_line":"                self.assertIn(\u0027port\u0027, res)"},{"line_number":602,"context_line":"                self.assertEqual(res[\u0027port\u0027][\u0027mac_address\u0027], new_mac)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def test_fixed_ips_changed(self):"},{"line_number":605,"context_line":"        self._register_ml2_agents()"}],"source_content_type":"text/x-python","patch_set":9,"id":"da9df570_4ffc403f","line":602,"updated":"2014-09-22 20:48:42.000000000","message":"Nit: args should be (expected, actual)","commit_id":"c86aa65c2baac7767187c4aba68f420c11c25e10"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"2c6e42cca3479d2cdd66c95224edc435b891ec80","unresolved":false,"context_lines":[{"line_number":599,"context_line":"                req \u003d self.new_update_request(\u0027ports\u0027, data, p1[\u0027id\u0027])"},{"line_number":600,"context_line":"                res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":601,"context_line":"                self.assertIn(\u0027port\u0027, res)"},{"line_number":602,"context_line":"                self.assertEqual(res[\u0027port\u0027][\u0027mac_address\u0027], new_mac)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    def test_fixed_ips_changed(self):"},{"line_number":605,"context_line":"        self._register_ml2_agents()"}],"source_content_type":"text/x-python","patch_set":9,"id":"da9df570_1a06d3ce","line":602,"in_reply_to":"da9df570_4ffc403f","updated":"2014-09-23 19:40:32.000000000","message":"thanks\n\ndone","commit_id":"c86aa65c2baac7767187c4aba68f420c11c25e10"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"a0cbe99464c1dc74486d0bab128fda291e0dac7f","unresolved":false,"context_lines":[{"line_number":839,"context_line":"                                  \u0027remove_fdb_entries\u0027)) as (upd_port_down,"},{"line_number":840,"context_line":"                                                             rem_fdb_entries):"},{"line_number":841,"context_line":"            l2pop_mech.delete_port_postcommit(mock.Mock())"},{"line_number":842,"context_line":"            self.assertTrue(upd_port_down.called)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_db3a8433","line":842,"updated":"2014-10-22 08:00:30.000000000","message":"newline is added at the end?","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"fa10865c58dddc90a89339b8962c842005c3075e","unresolved":false,"context_lines":[{"line_number":839,"context_line":"                                  \u0027remove_fdb_entries\u0027)) as (upd_port_down,"},{"line_number":840,"context_line":"                                                             rem_fdb_entries):"},{"line_number":841,"context_line":"            l2pop_mech.delete_port_postcommit(mock.Mock())"},{"line_number":842,"context_line":"            self.assertTrue(upd_port_down.called)"}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_dee97681","line":842,"in_reply_to":"9aa7fdbe_db3a8433","updated":"2014-10-23 00:53:47.000000000","message":"shouldn\u0027t there be a newline at the end?  Anyway, this was probably unintentional, although such things have caused tool problems for me in the past.\n\nI\u0027ll remove it.","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"170555a2d22ab902ab906ed01b77a05b3f2b8f98","unresolved":false,"context_lines":[{"line_number":730,"context_line":"            host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":731,"context_line":"            with self.port(subnet\u003dsubnet, cidr\u003d\u002710.0.0.0/24\u0027,"},{"line_number":732,"context_line":"                           device_owner\u003dDEVICE_OWNER_COMPUTE,"},{"line_number":733,"context_line":"#                           mac_address\u003d\u002710:20:30:40:50:60\u0027,"},{"line_number":734,"context_line":"                           arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":735,"context_line":"                           **host_arg) as port1:"},{"line_number":736,"context_line":"                p1 \u003d port1[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_d466be28","line":733,"updated":"2014-12-18 16:07:33.000000000","message":"we should either delete this or have an explanation of the comment","commit_id":"5bbe84cab7466c12b7deefc9669eb11775d75713"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"eb88c61a5db812a99994b53688c42df2edfd696c","unresolved":false,"context_lines":[{"line_number":730,"context_line":"            host_arg \u003d {portbindings.HOST_ID: HOST}"},{"line_number":731,"context_line":"            with self.port(subnet\u003dsubnet, cidr\u003d\u002710.0.0.0/24\u0027,"},{"line_number":732,"context_line":"                           device_owner\u003dDEVICE_OWNER_COMPUTE,"},{"line_number":733,"context_line":"#                           mac_address\u003d\u002710:20:30:40:50:60\u0027,"},{"line_number":734,"context_line":"                           arg_list\u003d(portbindings.HOST_ID,),"},{"line_number":735,"context_line":"                           **host_arg) as port1:"},{"line_number":736,"context_line":"                p1 \u003d port1[\u0027port\u0027]"}],"source_content_type":"text/x-python","patch_set":26,"id":"3a961159_cfb9cbcc","line":733,"in_reply_to":"3a961159_d466be28","updated":"2014-12-18 16:34:25.000000000","message":"Done","commit_id":"5bbe84cab7466c12b7deefc9669eb11775d75713"}],"neutron/tests/unit/ml2/test_ml2_plugin.py":[{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"fb42235dd26db4e502e5caa69b7587eba3ff019d","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":135,"context_line":"            res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":136,"context_line":"            self.assertIn(\u0027port\u0027, res)"},{"line_number":137,"context_line":"            self.assertEqual(res[\u0027port\u0027][\u0027mac_address\u0027], new_mac)"},{"line_number":138,"context_line":"            data[\u0027port\u0027][\u0027mac_address\u0027] \u003d orig_mac"},{"line_number":139,"context_line":"            data[\u0027port\u0027][\u0027device_owner\u0027] \u003d constants.DEVICE_OWNER_DHCP"},{"line_number":140,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_aeddbb16","line":137,"updated":"2014-09-01 10:34:58.000000000","message":"nit: expected, observed","commit_id":"aa2d9e47aed3370316f100f0a38606684eef707e"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"8ba8443fb89116a192f643087263c2adfbc1b9f5","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":135,"context_line":"            res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":136,"context_line":"            self.assertIn(\u0027port\u0027, res)"},{"line_number":137,"context_line":"            self.assertEqual(res[\u0027port\u0027][\u0027mac_address\u0027], new_mac)"},{"line_number":138,"context_line":"            data[\u0027port\u0027][\u0027mac_address\u0027] \u003d orig_mac"},{"line_number":139,"context_line":"            data[\u0027port\u0027][\u0027device_owner\u0027] \u003d constants.DEVICE_OWNER_DHCP"},{"line_number":140,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port[\u0027port\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_0c6604ed","line":137,"in_reply_to":"fa98f980_aeddbb16","updated":"2014-09-05 20:52:01.000000000","message":"Done","commit_id":"aa2d9e47aed3370316f100f0a38606684eef707e"},{"author":{"_account_id":12737,"name":"Jacek Swiderski","email":"jacek.swiderski@codilime.com","username":"Altran"},"change_message_id":"fb42235dd26db4e502e5caa69b7587eba3ff019d","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            data[\u0027port\u0027][\u0027device_owner\u0027] \u003d constants.DEVICE_OWNER_DHCP"},{"line_number":140,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":141,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":142,"context_line":"            self.assertEqual(res.status_int, webob.exc.HTTPBadRequest.code)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_update_non_existent_port(self):"},{"line_number":145,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_eee7c3e2","line":142,"updated":"2014-09-01 10:34:58.000000000","message":"ditto","commit_id":"aa2d9e47aed3370316f100f0a38606684eef707e"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"8ba8443fb89116a192f643087263c2adfbc1b9f5","unresolved":false,"context_lines":[{"line_number":139,"context_line":"            data[\u0027port\u0027][\u0027device_owner\u0027] \u003d constants.DEVICE_OWNER_DHCP"},{"line_number":140,"context_line":"            req \u003d self.new_update_request(\u0027ports\u0027, data, port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":141,"context_line":"            res \u003d req.get_response(self.api)"},{"line_number":142,"context_line":"            self.assertEqual(res.status_int, webob.exc.HTTPBadRequest.code)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"    def test_update_non_existent_port(self):"},{"line_number":145,"context_line":"        ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa98f980_2c6108d3","line":142,"in_reply_to":"fa98f980_eee7c3e2","updated":"2014-09-05 20:52:01.000000000","message":"Done","commit_id":"aa2d9e47aed3370316f100f0a38606684eef707e"},{"author":{"_account_id":10370,"name":"Romil Gupta","email":"romilgupta19@gmail.com","username":"romilg"},"change_message_id":"87ed7b563bf70c20c62ff92fa86bfe6d30eedf75","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"DEVICE_OWNER_COMPUTE \u003d \u0027compute:None\u0027"},{"line_number":60,"context_line":"HOST \u003d \u0027my_ml2_host\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class Ml2PluginV2TestCase(test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_d8a90126","line":61,"updated":"2014-10-18 05:56:29.000000000","message":"Nit: HOST \u003d \"fake_host\u0027. I understand any hostname we could use here, but it would be better if we follow the convention.","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"fa10865c58dddc90a89339b8962c842005c3075e","unresolved":false,"context_lines":[{"line_number":58,"context_line":""},{"line_number":59,"context_line":"DEVICE_OWNER_COMPUTE \u003d \u0027compute:None\u0027"},{"line_number":60,"context_line":"HOST \u003d \u0027my_ml2_host\u0027"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class Ml2PluginV2TestCase(test_plugin.NeutronDbPluginV2TestCase):"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"9aa7fdbe_8e880ee9","line":61,"in_reply_to":"9aa7fdbe_d8a90126","updated":"2014-10-23 00:53:47.000000000","message":"Done","commit_id":"0c7300fe17a3cd25c609300a1426c5d3c3f34230"}],"neutron/tests/unit/test_db_plugin.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"db693e51bbd50710a2aa664e2a62b796259b2de7","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"            res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":1084,"context_line":"            self.assertEqual(res[\u0027port\u0027][\u0027admin_state_up\u0027],"},{"line_number":1085,"context_line":"                             data[\u0027port\u0027][\u0027admin_state_up\u0027])"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"    def test_update_port_update_used_mac(self):"},{"line_number":1088,"context_line":"        with self.subnet() as subnet:"},{"line_number":1089,"context_line":"            with self.port(subnet\u003dsubnet) as port:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_efa7d64e","line":1086,"updated":"2014-09-16 15:29:25.000000000","message":"we also need tests for update mac","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1136427338fc7b93985a6679170d1fe86c8286fe","unresolved":false,"context_lines":[{"line_number":1083,"context_line":"            res \u003d self.deserialize(self.fmt, req.get_response(self.api))"},{"line_number":1084,"context_line":"            self.assertEqual(res[\u0027port\u0027][\u0027admin_state_up\u0027],"},{"line_number":1085,"context_line":"                             data[\u0027port\u0027][\u0027admin_state_up\u0027])"},{"line_number":1086,"context_line":""},{"line_number":1087,"context_line":"    def test_update_port_update_used_mac(self):"},{"line_number":1088,"context_line":"        with self.subnet() as subnet:"},{"line_number":1089,"context_line":"            with self.port(subnet\u003dsubnet) as port:"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa98f980_320d9338","line":1086,"in_reply_to":"fa98f980_efa7d64e","updated":"2014-09-18 06:30:19.000000000","message":"NOT a nit! :)\n\ndone","commit_id":"e6602cbb0f7d668688ae30f3941a634f829bbed6"},{"author":{"_account_id":6598,"name":"Berezovsky Irena","email":"irenab.dev@gmail.com","username":"irenab"},"change_message_id":"f29bb40dc898498cafeb6648806f701f3dbe8fed","unresolved":false,"context_lines":[{"line_number":44,"context_line":"DB_PLUGIN_KLASS \u003d \u0027neutron.db.db_base_plugin_v2.NeutronDbPluginV2\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DEVICE_OWNER_COMPUTE \u003d \u0027compute:None\u0027"},{"line_number":47,"context_line":"DEVICE_OWNER_NOT_COMPUTE \u003d \u0027network:dhcp\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def optional_ctx(obj, fallback):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_29aab870","line":47,"updated":"2014-09-21 17:53:53.000000000","message":"you can use constants defined in  common.constants.py","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"1b96728f9ecae1ddafe386a1dfdcc22538426ab7","unresolved":false,"context_lines":[{"line_number":44,"context_line":"DB_PLUGIN_KLASS \u003d \u0027neutron.db.db_base_plugin_v2.NeutronDbPluginV2\u0027"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"DEVICE_OWNER_COMPUTE \u003d \u0027compute:None\u0027"},{"line_number":47,"context_line":"DEVICE_OWNER_NOT_COMPUTE \u003d \u0027network:dhcp\u0027"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"def optional_ctx(obj, fallback):"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_122e7c92","line":47,"in_reply_to":"da9df570_29aab870","updated":"2014-09-25 19:05:27.000000000","message":"There are none for compute, though.  Just used DEVICE_OWNER_DHCP here.","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8cab7186b7af3237c54e2a0e0277273204b9a5e2","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"            if check_port_status:"},{"line_number":1107,"context_line":"                self.assertNotEqual(\u0027ACTIVE\u0027, port[\u0027port\u0027][\u0027status\u0027])"},{"line_number":1108,"context_line":"            res, new_mac \u003d self.update_port_mac(port[\u0027port\u0027])"},{"line_number":1109,"context_line":"            self.assertEqual(res.status_int, expected_status)"},{"line_number":1110,"context_line":"            if expected_status \u003d\u003d webob.exc.HTTPOk.code:"},{"line_number":1111,"context_line":"                result \u003d self.deserialize(self.fmt, res)"},{"line_number":1112,"context_line":"                self.assertIn(\u0027port\u0027, result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_cdcf66af","line":1109,"updated":"2014-09-22 13:38:57.000000000","message":"nit use (expected, actual) on assert.","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ee6e7671631e4c0b2b822e83730639d4e0aca2a2","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"            if check_port_status:"},{"line_number":1107,"context_line":"                self.assertNotEqual(\u0027ACTIVE\u0027, port[\u0027port\u0027][\u0027status\u0027])"},{"line_number":1108,"context_line":"            res, new_mac \u003d self.update_port_mac(port[\u0027port\u0027])"},{"line_number":1109,"context_line":"            self.assertEqual(res.status_int, expected_status)"},{"line_number":1110,"context_line":"            if expected_status \u003d\u003d webob.exc.HTTPOk.code:"},{"line_number":1111,"context_line":"                result \u003d self.deserialize(self.fmt, res)"},{"line_number":1112,"context_line":"                self.assertIn(\u0027port\u0027, result)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_b6a192ab","line":1109,"in_reply_to":"da9df570_cdcf66af","updated":"2014-09-22 16:06:51.000000000","message":"thanks, done","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":6659,"name":"Paul Michali","email":"pc@michali.net","username":"pcm"},"change_message_id":"8cab7186b7af3237c54e2a0e0277273204b9a5e2","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                    req \u003d self.new_update_request(\u0027ports\u0027, data,"},{"line_number":1139,"context_line":"                                                  port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":1140,"context_line":"                    res \u003d req.get_response(self.api)"},{"line_number":1141,"context_line":"                    self.assertEqual(res.status_int,"},{"line_number":1142,"context_line":"                                     webob.exc.HTTPConflict.code)"},{"line_number":1143,"context_line":"                    error \u003d self.deserialize(self.fmt, res)"},{"line_number":1144,"context_line":"                    self.assertEqual(expected_error,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_ad41420d","line":1141,"updated":"2014-09-22 13:38:57.000000000","message":"ditto","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"ee6e7671631e4c0b2b822e83730639d4e0aca2a2","unresolved":false,"context_lines":[{"line_number":1138,"context_line":"                    req \u003d self.new_update_request(\u0027ports\u0027, data,"},{"line_number":1139,"context_line":"                                                  port[\u0027port\u0027][\u0027id\u0027])"},{"line_number":1140,"context_line":"                    res \u003d req.get_response(self.api)"},{"line_number":1141,"context_line":"                    self.assertEqual(res.status_int,"},{"line_number":1142,"context_line":"                                     webob.exc.HTTPConflict.code)"},{"line_number":1143,"context_line":"                    error \u003d self.deserialize(self.fmt, res)"},{"line_number":1144,"context_line":"                    self.assertEqual(expected_error,"}],"source_content_type":"text/x-python","patch_set":7,"id":"da9df570_d68d3633","line":1141,"in_reply_to":"da9df570_ad41420d","updated":"2014-09-22 16:06:51.000000000","message":"Done","commit_id":"187cf065bfece838a3747477e8badfa1657ba817"},{"author":{"_account_id":9911,"name":"Wei Wang","email":"wangwei@unitedstack.com","username":"DamonWang"},"change_message_id":"e846e8684b3b685fdb2bf49d5e0d164e0abae25b","unresolved":false,"context_lines":[{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"    def test_update_port_mac(self):"},{"line_number":1113,"context_line":"        # port status is ACTIVE in the base plugin, so how to test?"},{"line_number":1114,"context_line":"        self.skipTest(\"how to test base plugin?\")"},{"line_number":1115,"context_line":"        # sub-classes for plugins/drivers that support mac address update"},{"line_number":1116,"context_line":"        # override this method"},{"line_number":1117,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"baa201ad_986399dc","line":1114,"updated":"2014-10-14 02:37:54.000000000","message":"Sub-class will override this method, this is a interesting question...\nmaybe write class\u0027s __base__ attr?","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"},{"author":{"_account_id":9093,"name":"Chuck Carlino","email":"chuckjcarlino@gmail.com","username":"ChuckC"},"change_message_id":"c826ec8ce8ecd8385e535ba7cf08f396557b26ed","unresolved":false,"context_lines":[{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"    def test_update_port_mac(self):"},{"line_number":1113,"context_line":"        # port status is ACTIVE in the base plugin, so how to test?"},{"line_number":1114,"context_line":"        self.skipTest(\"how to test base plugin?\")"},{"line_number":1115,"context_line":"        # sub-classes for plugins/drivers that support mac address update"},{"line_number":1116,"context_line":"        # override this method"},{"line_number":1117,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9aa7fdbe_3236ae04","line":1114,"in_reply_to":"baa201ad_986399dc","updated":"2014-10-18 01:17:33.000000000","message":"Due to Gary\u0027s comment in the product code, ACTIVE status is no longer a problem, so this test now works fine.","commit_id":"cb59a84bf9926f63bf5d9029a11d7cc5f23f9e58"}]}
